| *** toddjohn_ has joined #openstack-mistral | 00:27 | |
| *** toddjohn_ has quit IRC | 00:31 | |
| larrie_kong | to everyone here, I'm Lingxian, I changed my nickname, again. actually I'm not a fun of changing name frequently, but a good friend of NZ gave me an English name, Larris Kong(I didn't have a 'formal' English name before), and I like it so much. So, I decide to also change my irc name to larris. I surfix kong in the end just in case you didn't recognize me. | 00:35 |
|---|---|---|
| larrie_kong | ok, back to work. rakhmerov, are we ready for m-3? | 00:36 |
| larrie_kong | i think today is the deadline | 00:36 |
| larrie_kong | ooh, sorry, s/larris/larre, still don't get used to it | 00:37 |
| larrie_kong | f**k, wrong again, Larrie Kong, I'm Larrie, I'm Larrie, ok, Larrie, I like it. | 00:40 |
| larrie_kong | CTRL+L | 00:41 |
| openstackgerrit | Winson Chan proposed openstack/python-mistralclient: Fix cacert and insecure options on HTTP requests https://review.openstack.org/286942 | 00:47 |
| larrie_kong | nmakhotkin, akuznetsova , please help to review https://review.openstack.org/#/c/286288/, we need it to be merged in mistral-spec m-3 | 00:49 |
| *** larrie_kong is now known as kong | 01:04 | |
| *** cheneydc has joined #openstack-mistral | 01:06 | |
| openstackgerrit | Winson Chan proposed openstack/python-mistralclient: Fix cacert and insecure options on HTTP requests https://review.openstack.org/286942 | 01:20 |
| openstackgerrit | Cheney proposed openstack/mistral: Fix the problem when parse config file https://review.openstack.org/287549 | 01:32 |
| *** ninag has joined #openstack-mistral | 01:37 | |
| *** ninag has quit IRC | 01:37 | |
| *** bobh has joined #openstack-mistral | 01:37 | |
| *** bobh has quit IRC | 01:45 | |
| *** openstackgerrit has quit IRC | 01:47 | |
| *** openstackgerrit has joined #openstack-mistral | 01:48 | |
| *** bobh has joined #openstack-mistral | 01:50 | |
| *** bobh has quit IRC | 01:55 | |
| kong | ping nmakhotkin | 02:00 |
| kong | ping rakhmerov | 02:01 |
| *** bobh has joined #openstack-mistral | 02:50 | |
| *** achanda has joined #openstack-mistral | 03:11 | |
| *** igormarnat has quit IRC | 03:26 | |
| *** nmakhotkin has quit IRC | 03:26 | |
| *** nmakhotkin has joined #openstack-mistral | 03:26 | |
| *** igormarnat_ has joined #openstack-mistral | 03:26 | |
| *** igormarnat_ is now known as igormarnat | 03:26 | |
| *** bobh has quit IRC | 03:30 | |
| openstackgerrit | Merged openstack/mistral: Add release notes for M-3 https://review.openstack.org/286285 | 03:51 |
| *** achanda has quit IRC | 04:28 | |
| *** achanda has joined #openstack-mistral | 05:11 | |
| rakhmerov | :)) | 06:17 |
| rakhmerov | kong: still here? | 06:19 |
| rakhmerov | if yes, for how long? | 06:19 |
| rakhmerov | kong: no problems from my side to make a release | 06:22 |
| rakhmerov | _gryf: on functional/unit tests, what you said is right to me. It's basically how we try to organize tests in Mistral | 06:25 |
| rakhmerov | Maybe I'm missing something, I just didn't understand what else you think we should do to make it more clear | 06:26 |
| rakhmerov | ? | 06:26 |
| *** jtomasek has joined #openstack-mistral | 06:33 | |
| _gryf | rakhmerov, If I run the tox -e unit in mistral, there is a several services spining out, isn't it? | 06:50 |
| _gryf | s/tox -eunit/tox -epy27/ | 06:51 |
| _gryf | which in unit tests does not happen usually (i'm comparing it mostly how in Nova tests are organized) | 06:51 |
| _gryf | rakhmerov, also, FWIW, unit tests should run fast. Mistral isn't a huge project, therefore I'd expect, that ut with a building the env by tox would take at most a minute or so. | 06:53 |
| _gryf | frankly, I've never been able to run the tests succesfully on my local machine | 06:54 |
| _gryf | rakhmerov, maybe i'm missing something obvious, or I have a bad luck, or just stupid (cannot exlude anything of those ;) | 06:55 |
| *** bhaskarduvvuri has joined #openstack-mistral | 06:55 | |
| rakhmerov | _gryf: what several services do you mean? | 06:56 |
| _gryf | but for some reason the only environment I succesfully run the tests was 1core virtual machine | 06:56 |
| _gryf | rakhmerov, not sure. doesn't executors are spined out to take the job out of the tests code? | 06:57 |
| rakhmerov | _gryf: hm... it's weird. On my machine they always run successfully :) | 06:57 |
| _gryf | rakhmerov, so it must bve definitely something with my env :D | 06:57 |
| rakhmerov | _gryf: no, unit tests don't spin up anything | 06:57 |
| rakhmerov | if it really happens (and I'll see an evidence of that) this should be considered as a huge bug | 06:58 |
| rakhmerov | and we gotta fix it asap | 06:58 |
| rakhmerov | unit tests only run fake transport (in-memory MQ) and sqlite DB, that's it | 06:58 |
| _gryf | rakhmerov, http://paste.openstack.org/show/489087/ this is the output from yesterday | 06:58 |
| rakhmerov | no api servers, no rabbit, no mysql, no executors as separate processes | 06:59 |
| _gryf | there was a lot more output like that | 06:59 |
| rakhmerov | yes, I see | 06:59 |
| rakhmerov | ok, let me be honest with you | 06:59 |
| rakhmerov | I quite know why it's happening | 06:59 |
| rakhmerov | it's because we still have concurrent bugs in the code | 07:00 |
| rakhmerov | my guess is that no so many but we do | 07:00 |
| _gryf | mhmm | 07:00 |
| _gryf | so the code is racy, or the tests? | 07:00 |
| rakhmerov | I believe both | 07:00 |
| _gryf | bummer | 07:00 |
| rakhmerov | and especially they occur in unit tests | 07:00 |
| rakhmerov | it's not so bad, don't worry :) | 07:00 |
| rakhmerov | to the great extent it's related with using sqlite in unit tests | 07:01 |
| rakhmerov | because it's not a decent production DB | 07:01 |
| _gryf | right | 07:01 |
| rakhmerov | so some things designed based on TX knowledge etc. may not work properly with sqlite | 07:01 |
| rakhmerov | it's a known problem | 07:01 |
| _gryf | yeah | 07:02 |
| _gryf | got it. | 07:02 |
| rakhmerov | that's why we also added a gate to run everything against postgres | 07:02 |
| rakhmerov | but it's not 100% finished | 07:02 |
| _gryf | although in my understanding all things based on db communication in UT shouldn't be cut off? | 07:02 |
| rakhmerov | we need to finish it | 07:02 |
| _gryf | i mean | 07:02 |
| rakhmerov | and create similar gate for mysql | 07:02 |
| _gryf | shouldn't we operate on the objects only, without touching the db? | 07:03 |
| rakhmerov | _gryf: no, practically it's impossible | 07:03 |
| rakhmerov | we need some mock for a DB anyway | 07:03 |
| rakhmerov | too many things are related to that | 07:03 |
| rakhmerov | that mock in our case is sqlite | 07:04 |
| rakhmerov | a solution that I see is something like: | 07:04 |
| rakhmerov | 1. Investigate and understand typical problems caused by using sqlite | 07:04 |
| rakhmerov | 2. Create tooling specifically for UT to workaround these problems and use them in UT | 07:05 |
| rakhmerov | 3. Complete gates to run UT against Mysql and Postgres w/o those workarounds | 07:05 |
| rakhmerov | that will give us confidence that all is fine | 07:06 |
| _gryf | ok, got that. btw, how can I set up the tests to be executed against postgre? | 07:07 |
| rakhmerov | ooh, let me see | 07:08 |
| rakhmerov | there was an CLI option to do that | 07:08 |
| _gryf | if the sqlite is the problem, maybe it would be easier for me to set up the proper db engine and use it for the tests locally | 07:08 |
| rakhmerov | yes, maybe | 07:08 |
| rakhmerov | the problem with a normal DB is that tests don't run in parallel | 07:09 |
| rakhmerov | because they share a real DB | 07:09 |
| _gryf | ok | 07:09 |
| rakhmerov | so they run sequentially and take very long time (look at our postgres gate) | 07:09 |
| _gryf | so the tests take more time | 07:09 |
| rakhmerov | yeah | 07:09 |
| rakhmerov | of course, it could be solved too | 07:09 |
| rakhmerov | but it's not yet | 07:09 |
| rakhmerov | ~24 min for the gate | 07:10 |
| rakhmerov | not really usable for the local development | 07:10 |
| _gryf | right. it's way too long | 07:11 |
| rakhmerov | ./run_tests.sh -V --db-type postgresql | 07:11 |
| rakhmerov | this is how our gate runs tests | 07:11 |
| _gryf | rakhmerov, thanks, i'll try that | 07:12 |
| rakhmerov | ok | 07:12 |
| _gryf | and see how it's troublesome for me :) | 07:12 |
| _gryf | ok, running the tests. so far so good :) | 07:17 |
| openstackgerrit | Merged openstack/mistral-specs: Copy implemented spec files to the implemented folder https://review.openstack.org/286288 | 07:19 |
| *** tshtilma has joined #openstack-mistral | 07:20 | |
| *** achanda has quit IRC | 07:31 | |
| *** achanda has joined #openstack-mistral | 07:49 | |
| *** tshtilma has quit IRC | 07:50 | |
| *** bhaskarduvvuri has quit IRC | 07:57 | |
| *** bhaskarduvvuri has joined #openstack-mistral | 08:02 | |
| *** bhaskarduvvuri has quit IRC | 08:14 | |
| *** achanda has quit IRC | 08:32 | |
| *** LimorStotland has joined #openstack-mistral | 08:41 | |
| _gryf | rakhmerov, Ran 381 tests in 3605.433s FAILED (failures=58, skipped=5) | 09:05 |
| rakhmerov | wooohoo | 09:05 |
| rakhmerov | that's pretty bad | 09:05 |
| rakhmerov | I assume that something is wrong with your environment | 09:05 |
| _gryf | that's possible :) | 09:06 |
| rakhmerov | need to look at logs | 09:06 |
| _gryf | although it's a plain ubuntu 14.04 with devstack on it | 09:06 |
| _gryf | where can i find them? | 09:08 |
| *** bhaskarduvvuri has joined #openstack-mistral | 09:18 | |
| *** LimorStotland has quit IRC | 09:30 | |
| *** LimorStotland has joined #openstack-mistral | 09:31 | |
| *** openstackgerrit_ has joined #openstack-mistral | 09:54 | |
| *** openstackgerrit_ has quit IRC | 10:02 | |
| *** cheneydc has quit IRC | 10:02 | |
| kong | guys, mistral for m-3 have been released. https://review.openstack.org/#/c/287690/ | 10:31 |
| *** tshtilma has joined #openstack-mistral | 10:41 | |
| *** bhaskarduvvuri has quit IRC | 11:08 | |
| *** toddjohn_ has joined #openstack-mistral | 11:21 | |
| *** toddjohn_ has quit IRC | 11:26 | |
| *** LimorStotland has quit IRC | 11:28 | |
| *** LimorStotland has joined #openstack-mistral | 11:53 | |
| *** LimorStotland has quit IRC | 11:57 | |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** openstackgerrit has joined #openstack-mistral | 12:03 | |
| *** LimorStotland has joined #openstack-mistral | 12:27 | |
| *** dprince has joined #openstack-mistral | 12:40 | |
| *** dprince has quit IRC | 12:46 | |
| *** LimorStotland has quit IRC | 12:51 | |
| *** dprince has joined #openstack-mistral | 12:53 | |
| *** bhaskarduvvuri has joined #openstack-mistral | 12:59 | |
| *** tshtilma has quit IRC | 13:25 | |
| *** toddjohn_ has joined #openstack-mistral | 13:28 | |
| *** xenogear has quit IRC | 13:36 | |
| *** bhaskarduvvuri has quit IRC | 13:41 | |
| *** ninag has joined #openstack-mistral | 13:42 | |
| *** tshtilma has joined #openstack-mistral | 13:44 | |
| *** xenogear has joined #openstack-mistral | 14:00 | |
| *** toddjohn_ has quit IRC | 14:03 | |
| *** toddjohn_ has joined #openstack-mistral | 14:03 | |
| *** toddjohn_ has quit IRC | 14:08 | |
| *** bobh has joined #openstack-mistral | 14:24 | |
| *** toddjohn_ has joined #openstack-mistral | 14:38 | |
| *** LimorStotland has joined #openstack-mistral | 14:46 | |
| *** LimorStotland has quit IRC | 14:48 | |
| *** vgnbkr_ has joined #openstack-mistral | 15:17 | |
| *** achanda has joined #openstack-mistral | 15:33 | |
| *** tshtilma has quit IRC | 15:33 | |
| *** achanda has quit IRC | 15:39 | |
| *** tshtilma has joined #openstack-mistral | 15:42 | |
| *** ninag has quit IRC | 16:57 | |
| *** ninag has joined #openstack-mistral | 17:01 | |
| *** gyee has joined #openstack-mistral | 17:01 | |
| *** ninag_ has joined #openstack-mistral | 17:02 | |
| *** ninag has quit IRC | 17:05 | |
| *** ninag_ has quit IRC | 17:06 | |
| *** toddjohn_ has quit IRC | 17:09 | |
| *** toddjohn_ has joined #openstack-mistral | 17:09 | |
| *** toddjohn_ has quit IRC | 17:14 | |
| *** bobh has quit IRC | 17:25 | |
| *** toddjohn_ has joined #openstack-mistral | 17:26 | |
| *** tshtilma has quit IRC | 17:37 | |
| *** ninag has joined #openstack-mistral | 17:52 | |
| *** ninag_ has joined #openstack-mistral | 17:52 | |
| *** ninag has quit IRC | 17:56 | |
| *** bobh has joined #openstack-mistral | 18:08 | |
| *** Ephur has joined #openstack-mistral | 18:12 | |
| *** Ephur_ has joined #openstack-mistral | 18:16 | |
| *** Ephur has quit IRC | 18:18 | |
| *** tshtilma has joined #openstack-mistral | 18:46 | |
| *** gyee has quit IRC | 18:46 | |
| *** Ephur_ has quit IRC | 20:10 | |
| *** xenogear has quit IRC | 20:48 | |
| *** xenogear has joined #openstack-mistral | 20:50 | |
| *** gyee has joined #openstack-mistral | 20:55 | |
| *** vgnbkr_ has quit IRC | 21:02 | |
| *** tshtilma has quit IRC | 21:29 | |
| *** bobh has quit IRC | 21:53 | |
| *** toddjohn_ has quit IRC | 21:54 | |
| *** bobh has joined #openstack-mistral | 22:00 | |
| *** bobh has quit IRC | 22:02 | |
| *** Ephur has joined #openstack-mistral | 22:06 | |
| *** jtomasek has quit IRC | 22:19 | |
| *** dprince has quit IRC | 22:36 | |
| *** toddjohn_ has joined #openstack-mistral | 22:38 | |
| *** ninag_ has quit IRC | 22:47 | |
| *** toddjohn_ has quit IRC | 22:54 | |
| *** toddjohn_ has joined #openstack-mistral | 22:54 | |
| *** toddjohn_ has quit IRC | 22:55 | |
| *** toddjohn_ has joined #openstack-mistral | 22:55 | |
| *** toddjohn_ has quit IRC | 23:26 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!