*** toddjohn has joined #openstack-mistral | 00:56 | |
*** toddjohn has quit IRC | 01:01 | |
*** cheneydc has joined #openstack-mistral | 01:15 | |
*** toddjohn has joined #openstack-mistral | 01:58 | |
*** toddjohn has quit IRC | 02:02 | |
*** achanda has joined #openstack-mistral | 02:21 | |
*** toddjohn has joined #openstack-mistral | 02:59 | |
*** toddjohn has quit IRC | 03:04 | |
*** bobh_ has quit IRC | 03:50 | |
*** dongc has joined #openstack-mistral | 03:58 | |
*** cheneydc has quit IRC | 03:59 | |
*** dongc is now known as cheneydc | 03:59 | |
*** toddjohn has joined #openstack-mistral | 04:01 | |
*** toddjohn has quit IRC | 04:08 | |
rakhmerov | hparekh: hi | 04:24 |
---|---|---|
hparekh | rakhmerov: hi | 04:24 |
rakhmerov | did you have a chance to prepare something for the summit? | 04:24 |
rakhmerov | some slides, use cases etc. | 04:24 |
rakhmerov | if you did I could potentially use it | 04:24 |
hparekh | I planed for couple of use case like Leave Management and One is regarding JIra | 04:26 |
hparekh | I would like to demonstrate , how this two use case can achive using mistral workflow. | 04:26 |
hparekh | Although I cannot get time to prepare actual workflow. | 04:27 |
hparekh | rakhmerov, I will send you the detail statement and some work I have done by today | 04:30 |
rakhmerov | that would be cool | 04:30 |
rakhmerov | no rush though | 04:30 |
rakhmerov | it'd be ok to send them by the end of next week | 04:31 |
hparekh | ok | 04:31 |
*** dongc has joined #openstack-mistral | 05:10 | |
*** cheneydc has quit IRC | 05:10 | |
*** dongc is now known as cheneydc | 05:10 | |
*** dongc has joined #openstack-mistral | 05:19 | |
*** cheneydc has quit IRC | 05:20 | |
*** dongc is now known as cheneydc | 05:20 | |
*** cheneydc has quit IRC | 05:27 | |
*** cheneydc has joined #openstack-mistral | 05:30 | |
*** cheneydc has quit IRC | 05:38 | |
*** cheneydc has joined #openstack-mistral | 05:38 | |
*** cheneydc has quit IRC | 05:43 | |
*** cheneydc has joined #openstack-mistral | 05:43 | |
*** dongc has joined #openstack-mistral | 05:46 | |
*** cheneydc has quit IRC | 05:47 | |
*** cheneydc has joined #openstack-mistral | 05:50 | |
*** dongc has quit IRC | 05:51 | |
*** toddjohn has joined #openstack-mistral | 06:05 | |
*** toddjohn has quit IRC | 06:09 | |
*** achanda has quit IRC | 06:40 | |
*** achanda has joined #openstack-mistral | 07:40 | |
*** achanda has quit IRC | 07:44 | |
*** toddjohn has joined #openstack-mistral | 08:07 | |
*** toddjohn has quit IRC | 08:11 | |
*** chlong has quit IRC | 08:35 | |
*** achanda has joined #openstack-mistral | 09:13 | |
*** achanda has quit IRC | 09:18 | |
*** pbelamge has joined #openstack-mistral | 09:34 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Getting rid of task result proxies in workflow context https://review.openstack.org/301538 | 09:50 |
*** pbelamge has quit IRC | 09:55 | |
*** cheneydc has quit IRC | 10:02 | |
*** toddjohn has joined #openstack-mistral | 10:08 | |
*** toddjohn has quit IRC | 10:13 | |
ddeja | rakhmerov: Hi, I have found possible issue in Mistral Mitaka | 10:22 |
rakhmerov | ddeja: hi Dawid | 10:22 |
rakhmerov | what is that? | 10:22 |
ddeja | with experimental feature "ACK after processing message" | 10:22 |
rakhmerov | ok | 10:22 |
ddeja | On my devstack I have oslo_messaging in version 4.6.1 | 10:23 |
ddeja | (don't know why, since every OS service need >=4.0.0) | 10:23 |
ddeja | but in this version they have change the class RPCDispatcher | 10:23 |
ddeja | they removed one parapeter from __call__ method, which is then override in Nikolay patch | 10:24 |
ddeja | which results in TypeError: __init__() got an unexpected keyword argument 'executor_callback' | 10:24 |
rakhmerov | hm... | 10:24 |
ddeja | It look like mentioned parameter was not used for some time, so I'm not suprised that oslo team deleted it | 10:25 |
rakhmerov | so what was the version for which Nikolay made this fix? | 10:25 |
ddeja | I'm not sure, but for 4.0.0 it should be ok | 10:25 |
rakhmerov | nmakhotkin: Nikolay, hi | 10:26 |
rakhmerov | let's ask Nikolay | 10:26 |
ddeja | ok | 10:26 |
nmakhotkin | rakhmerov, hi! | 10:26 |
rakhmerov | nmakhotkin: can you please read the last ~20 messages | 10:26 |
rakhmerov | looks like we have a problem with that oslo messaging related patch | 10:26 |
ddeja | OK, I have just checked, the mentioned parameter was deleted in oslo_messaging 4.4.0 | 10:27 |
nmakhotkin | ok, I see | 10:27 |
ddeja | https://github.com/openstack/oslo.messaging/blob/4.4.0/oslo_messaging/rpc/dispatcher.py#L130 | 10:27 |
ddeja | https://github.com/openstack/oslo.messaging/blob/4.3.0/oslo_messaging/rpc/dispatcher.py#L130 | 10:27 |
nmakhotkin | that's very strange | 10:27 |
rakhmerov | so what do we need to do? | 10:28 |
rakhmerov | fix it and release RC3? | 10:28 |
nmakhotkin | I think yes | 10:28 |
nmakhotkin | we could delete that parameter as well | 10:28 |
rakhmerov | nmakhotkin: can you do this by tomorrow? | 10:28 |
rakhmerov | tomorrow is the last chance for this | 10:29 |
rakhmerov | to get it merged and ask for release | 10:29 |
ddeja | nmakhotkin: I don't think deliting it is good idea | 10:29 |
ddeja | since Mistral requires oslo_messaging>=4.0.0 | 10:29 |
ddeja | and in 4.0.0 this parameter is still present | 10:29 |
ddeja | but, in 4.4.0, it is not | 10:29 |
nmakhotkin | ddeja: so we could check if it exists | 10:29 |
rakhmerov | yes, that's what concerns me | 10:29 |
rakhmerov | right | 10:29 |
rakhmerov | hm... yeah, it would be better | 10:30 |
ddeja | or maybe be more specyfic about oslo_messaging version? | 10:30 |
rakhmerov | but I suggest we leave a HUGE TODO there to warn about potential issues if oslo_messaging changes | 10:30 |
_gryf | mh. | 10:33 |
_gryf | guys, dosn't this parameter is with default value? | 10:34 |
_gryf | if so, it can be simply removed from mistral implementation | 10:35 |
_gryf | so that it will work with 4.0 and 4.4 and above at the same time, doesn't it? | 10:35 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Getting rid of task result proxies in workflow context https://review.openstack.org/301538 | 10:48 |
*** szaher has quit IRC | 10:48 | |
*** achanda has joined #openstack-mistral | 11:13 | |
rakhmerov | nmakhotkin: what do you think about _gryf idea? | 11:14 |
*** achanda has quit IRC | 11:15 | |
nmakhotkin | I'm not sure it will work correctly on 4.0 | 11:15 |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Fixing issue with different versions of oslo_messaging https://review.openstack.org/301588 | 11:16 |
nmakhotkin | please take a look on the change at https://review.openstack.org/#/c/301588/ | 11:17 |
rakhmerov | ok | 11:26 |
rakhmerov | nmakhotkin: did you test it locally? :) | 11:27 |
rakhmerov | just in case ) | 11:27 |
nmakhotkin | rakhmerov: no, I didn't | 11:28 |
rakhmerov | please do | 11:28 |
rakhmerov | if you have time | 11:28 |
nmakhotkin | rakhmerov: I've just tested. It works fine for 4.3.0 and 4.4.0 | 11:31 |
rakhmerov | thanks! | 11:31 |
*** dprince has joined #openstack-mistral | 11:57 | |
*** toddjohn has joined #openstack-mistral | 12:10 | |
*** toddjohn has quit IRC | 12:14 | |
rakhmerov | nmakhotkin: I also updated https://review.openstack.org/#/c/301538/ | 12:15 |
rakhmerov | fixed everything in workflows for functional tests | 12:16 |
rakhmerov | _gryf, ddeja: guys, please take a look at Nikolay's last patch | 12:16 |
rakhmerov | https://review.openstack.org/#/c/301588/ | 12:16 |
rakhmerov | it looks ok to me, although it all should be considered a temporary solution | 12:17 |
ddeja | rakhmerov: Applying it right now on my devstack | 12:17 |
rakhmerov | ok | 12:17 |
ddeja | rakhmerov: It's working | 12:23 |
rakhmerov | cool | 12:23 |
rakhmerov | please leave your vote in the patch too | 12:24 |
ddeja | already done it :) | 12:24 |
*** toddjohn has joined #openstack-mistral | 12:27 | |
*** toddjohn has quit IRC | 13:00 | |
*** rbrady has quit IRC | 13:21 | |
*** hparekh has quit IRC | 13:21 | |
*** harlowja has quit IRC | 13:21 | |
*** FL1SK has quit IRC | 13:21 | |
*** lkannan has quit IRC | 13:21 | |
*** akuznetsova has quit IRC | 13:21 | |
*** zhenguo_ has quit IRC | 13:21 | |
*** bradjones has quit IRC | 13:21 | |
*** mandre has quit IRC | 13:21 | |
*** jtomasek has quit IRC | 13:21 | |
*** kong has quit IRC | 13:21 | |
*** krotscheck has quit IRC | 13:21 | |
*** docaedo has quit IRC | 13:21 | |
*** ddeja has quit IRC | 13:21 | |
*** dprince has quit IRC | 13:21 | |
*** Ephur has quit IRC | 13:21 | |
*** openstackgerrit has quit IRC | 13:21 | |
*** enykeev has quit IRC | 13:21 | |
*** dmowrer has quit IRC | 13:21 | |
*** _gryf has quit IRC | 13:22 | |
*** rushiagr has quit IRC | 13:22 | |
*** rakhmerov has quit IRC | 13:22 | |
*** nmakhotkin has quit IRC | 13:22 | |
*** toddjohn_ has quit IRC | 13:22 | |
*** pkoniszewski has quit IRC | 13:22 | |
*** igormarnat has quit IRC | 13:22 | |
*** aspiers has quit IRC | 13:22 | |
*** ruhe has quit IRC | 13:22 | |
*** vgnbkr has quit IRC | 13:22 | |
*** dprince has joined #openstack-mistral | 13:24 | |
*** dmowrer has joined #openstack-mistral | 13:24 | |
*** Ephur has joined #openstack-mistral | 13:24 | |
*** openstackgerrit has joined #openstack-mistral | 13:24 | |
*** jtomasek has joined #openstack-mistral | 13:24 | |
*** kong has joined #openstack-mistral | 13:24 | |
*** aspiers has joined #openstack-mistral | 13:24 | |
*** harlowja has joined #openstack-mistral | 13:24 | |
*** FL1SK has joined #openstack-mistral | 13:24 | |
*** rushiagr has joined #openstack-mistral | 13:24 | |
*** lkannan has joined #openstack-mistral | 13:24 | |
*** pkoniszewski has joined #openstack-mistral | 13:24 | |
*** krotscheck has joined #openstack-mistral | 13:24 | |
*** rakhmerov has joined #openstack-mistral | 13:24 | |
*** docaedo has joined #openstack-mistral | 13:24 | |
*** igormarnat has joined #openstack-mistral | 13:24 | |
*** akuznetsova has joined #openstack-mistral | 13:24 | |
*** ddeja has joined #openstack-mistral | 13:24 | |
*** hparekh has joined #openstack-mistral | 13:24 | |
*** ruhe has joined #openstack-mistral | 13:24 | |
*** _gryf has joined #openstack-mistral | 13:24 | |
*** nmakhotkin has joined #openstack-mistral | 13:24 | |
*** zhenguo_ has joined #openstack-mistral | 13:24 | |
*** bradjones has joined #openstack-mistral | 13:24 | |
*** enykeev has joined #openstack-mistral | 13:24 | |
*** toddjohn_ has joined #openstack-mistral | 13:24 | |
*** mandre has joined #openstack-mistral | 13:24 | |
*** vgnbkr has joined #openstack-mistral | 13:24 | |
*** rbrady has joined #openstack-mistral | 13:29 | |
*** toddjohn has joined #openstack-mistral | 13:34 | |
*** szaher has joined #openstack-mistral | 13:39 | |
*** bobh_ has joined #openstack-mistral | 13:47 | |
openstackgerrit | Merged openstack/mistral: Getting rid of task result proxies in workflow context https://review.openstack.org/301538 | 14:22 |
*** achanda has joined #openstack-mistral | 14:29 | |
*** achanda has quit IRC | 14:39 | |
*** Don_Nalezyty has joined #openstack-mistral | 14:42 | |
*** toddjohn has quit IRC | 16:10 | |
*** toddjohn has joined #openstack-mistral | 16:11 | |
*** toddjoh__ has joined #openstack-mistral | 16:15 | |
*** toddjohn has quit IRC | 16:15 | |
*** toddjoh__ has quit IRC | 16:19 | |
*** toddjohn has joined #openstack-mistral | 17:40 | |
*** Don_Nalezyty has quit IRC | 18:44 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/301660 | 18:47 |
*** bobh_ has quit IRC | 19:01 | |
*** toddjohn has quit IRC | 19:34 | |
*** toddjohn has joined #openstack-mistral | 19:35 | |
*** toddjohn has quit IRC | 19:40 | |
*** dprince has quit IRC | 19:57 | |
*** bobh_ has joined #openstack-mistral | 20:01 | |
*** bobh_ has quit IRC | 20:07 | |
*** bobh_ has joined #openstack-mistral | 20:23 | |
*** kong has quit IRC | 21:18 | |
*** lkannan has quit IRC | 21:19 | |
*** kong has joined #openstack-mistral | 21:19 | |
*** toddjohn has joined #openstack-mistral | 21:20 | |
*** lkannan has joined #openstack-mistral | 21:21 | |
*** toddjohn has quit IRC | 21:22 | |
*** toddjohn has joined #openstack-mistral | 21:22 | |
kong | ping rakhmerov | 21:29 |
*** rbrady has quit IRC | 21:38 | |
openstackgerrit | Merged openstack/mistral: Fixing issue with different versions of oslo_messaging https://review.openstack.org/301588 | 21:39 |
*** hparekh has quit IRC | 21:48 | |
*** hparekh has joined #openstack-mistral | 21:52 | |
*** bobh_ has quit IRC | 22:08 | |
kong | rakhmerov, nmakhotkin, akuznetsova please help to review the critical patch in stable/mitaka https://review.openstack.org/#/c/301930/ | 22:08 |
kong | I have discussed with release team already, it's ok we make a new release. | 22:09 |
kong | and BTW, dims in release team suggested us to run a job against oslo-messaging master, ' just throwing in a LIBS_FROM_GIT=oslo.messaging is enough' | 22:10 |
kong | I didn't know what's the exact meaning of it, akuznetsova, do you know what? | 22:10 |
kong | I don't have the privilege to +2 for the stable branch, so, please merge it today, and I | 22:17 |
kong | I'll submit a patch for release this afternoon or tonight in my time zone (UTC+12) | 22:17 |
kong | cheers, guys | 22:18 |
*** Ephur has quit IRC | 22:44 | |
*** toddjohn has quit IRC | 23:49 | |
*** toddjohn has joined #openstack-mistral | 23:49 | |
*** toddjohn has quit IRC | 23:52 | |
*** toddjohn has joined #openstack-mistral | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!