| *** toddjohn has joined #openstack-mistral | 00:00 | |
| *** toddjohn has quit IRC | 00:04 | |
| *** cheneydc has joined #openstack-mistral | 00:58 | |
| *** toddjohn has joined #openstack-mistral | 01:48 | |
| *** toddjohn has quit IRC | 01:52 | |
| *** tonytan4ever has joined #openstack-mistral | 02:11 | |
| *** openstackgerrit has quit IRC | 02:47 | |
| *** openstackgerrit has joined #openstack-mistral | 02:48 | |
| *** gyee has quit IRC | 02:50 | |
| *** toddjohn has joined #openstack-mistral | 03:36 | |
| *** toddjohn has quit IRC | 03:40 | |
| *** bobh has joined #openstack-mistral | 03:57 | |
| *** tonytan_brb has joined #openstack-mistral | 04:07 | |
| *** bobh has quit IRC | 04:07 | |
| *** tonytan4ever has quit IRC | 04:08 | |
| *** tonytan_brb has quit IRC | 04:36 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add a test that verifies an old bug with join https://review.openstack.org/326819 | 04:47 |
|---|---|---|
| *** vishwanathj has joined #openstack-mistral | 04:51 | |
| *** tonytan4ever has joined #openstack-mistral | 05:03 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add explicit preconditions for methods of Action, Task and Workflow https://review.openstack.org/326823 | 05:07 |
| *** tonytan4ever has quit IRC | 05:09 | |
| *** bobh has joined #openstack-mistral | 05:21 | |
| *** toddjohn has joined #openstack-mistral | 05:24 | |
| *** bobh has quit IRC | 05:24 | |
| *** toddjohn has quit IRC | 05:29 | |
| *** tonytan4ever has joined #openstack-mistral | 05:33 | |
| *** tonytan4ever has quit IRC | 05:38 | |
| *** jtomasek has quit IRC | 06:01 | |
| *** mflobo has left #openstack-mistral | 06:13 | |
| *** mflobo has joined #openstack-mistral | 06:14 | |
| *** vishwanathj has quit IRC | 06:36 | |
| *** vishwanathj has joined #openstack-mistral | 06:36 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Add Magnum actions https://review.openstack.org/326461 | 06:45 |
| *** jpeeler has quit IRC | 06:47 | |
| *** openstackgerrit has quit IRC | 06:48 | |
| *** openstackgerrit has joined #openstack-mistral | 06:48 | |
| *** jpeeler has joined #openstack-mistral | 06:55 | |
| *** toddjohn has joined #openstack-mistral | 07:12 | |
| *** toddjohn has quit IRC | 07:17 | |
| *** shardy has joined #openstack-mistral | 07:39 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-mistral | 07:48 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Add Magnum actions https://review.openstack.org/326461 | 07:53 |
| *** toddjohn has joined #openstack-mistral | 07:57 | |
| *** rbrady has quit IRC | 07:58 | |
| d0ugal | rakhmerov: I just replied to rbrady on the spec, but I didn't | 08:08 |
| d0ugal | rakhmerov: I just replied to rbrady on the spec, but I didn't notice you had replied also | 08:09 |
| d0ugal | ... hopefully my comment clears it up | 08:09 |
| rakhmerov | that's ok ) | 08:09 |
| rakhmerov | yeah, I see | 08:09 |
| rakhmerov | I agree with your comment | 08:10 |
| d0ugal | cool :) | 08:10 |
| rakhmerov | honestly, this repo is kind of abandoned | 08:10 |
| rakhmerov | almost | 08:10 |
| d0ugal | I thought that might be the case | 08:10 |
| rakhmerov | but I think in this context it could be useful, we could just revisit it and get into needed shape | 08:10 |
| d0ugal | +1 | 08:10 |
| d0ugal | Maybe we can delete code that is old and not relevant when reusing it | 08:11 |
| rakhmerov | yes | 08:11 |
| d0ugal | I don't think eventlet is even used despite being in the requirements btw | 08:11 |
| rakhmerov | right ) | 08:11 |
| rakhmerov | yeah, well, we could leave examples in there but create individual requirements.txt inside each one of them, if needed | 08:12 |
| rakhmerov | so that examples will live their own life | 08:12 |
| rakhmerov | d0ugal: btw, can you please look at my comments in https://review.openstack.org/#/c/326823/ ? | 08:12 |
| rakhmerov | d0ugal: I think it's my fault because the commit message may not be too clear | 08:13 |
| rakhmerov | but ddeja changed his opinion after my explanations :) | 08:13 |
| d0ugal | rakhmerov: Yeah, I am just thinking about it :) | 08:13 |
| d0ugal | rakhmerov: I guess I'm fine with it, I just can't think of a case when it would ever help. It would be interesting to have an example. | 08:14 |
| d0ugal | but I assume you know better than me :) | 08:14 |
| rakhmerov | d0ugal: I realize that it's not so common thing in Openstack | 08:14 |
| rakhmerov | d0ugal: ooh, let me explain then.. | 08:14 |
| rakhmerov | it's basically useful for debugging | 08:14 |
| *** vishwanathj has quit IRC | 08:14 | |
| _gryf | rakhmerov, I dont think assert statement is the best way to achieve what you are aiming there | 08:15 |
| rakhmerov | I lately came across a couple of situations when the program stack went far deep where a crash occurred | 08:15 |
| rakhmerov | but the reason was that some basic precondition was broken up the stack | 08:15 |
| _gryf | rakhmerov, esp. if operaotors would run python with -O/-OO | 08:15 |
| rakhmerov | and it just takes a lot of time to localize such problems | 08:15 |
| d0ugal | I've never know anyone to use -O/-OO :) | 08:16 |
| _gryf | d0ugal, ok, fair enough | 08:16 |
| d0ugal | but I still find it a bit strange | 08:16 |
| d0ugal | ... and I assume some people must use it. | 08:16 |
| _gryf | but still, i;d rather use apropriate decorator, than assert | 08:16 |
| rakhmerov | _gryf, d0ugal: well, honestly, I don't know why it looks confusing to you. It's a pretty typical thing. The general term is "contract-based programming" | 08:17 |
| rakhmerov | _gryf: decorator is a good point | 08:17 |
| _gryf | it is not confusing - it's just not reliable from my point of view | 08:18 |
| rakhmerov | I think we can come up with a number decorators for purposes like this | 08:18 |
| d0ugal | I think for me, when given the choice of an assert or raising a specific error, why use assert? :) | 08:18 |
| _gryf | assuming, that someone *may* run mistral with python -OO, this might break the program flow | 08:18 |
| rakhmerov | _gryf: why not reliable? Even if it occurs in production (without -O) the deployer will know that it's not a misconfiguration but rather a program logic issue | 08:19 |
| rakhmerov | d0ugal: because it's really lightweight | 08:19 |
| ddeja | rakhmerov: decorator is also what I;ve suggested in my first comment (after talk with _gryf ;) | 08:19 |
| rakhmerov | it's targeted mostly people who already know the code and add a little bit more to better understand, for example, what invariants exist around objects we're working with | 08:20 |
| rakhmerov | etc | 08:20 |
| _gryf | rakhmerov, right, of course, but if for some reason operator will run services with optimizations, it will not see any assertion errors and program will go on | 08:20 |
| ddeja | but still I think assert would be fine if it is intended to use for debug; raising an error would also be OK | 08:20 |
| _gryf | since asser statements will be literally removed from the code by optimization | 08:20 |
| rakhmerov | _gryf: agree, ideally all such errors must be eliminated during debugging and testing | 08:21 |
| _gryf | rakhmerov, ideally ;) | 08:21 |
| rakhmerov | ok, I don't want to be too insistive on that. If you think this is wrong I can abandon the patch | 08:22 |
| rakhmerov | I just did it because it really saved my time during debugging | 08:22 |
| d0ugal | It is probably better to have the check than not have it | 08:22 |
| rakhmerov | yep | 08:22 |
| d0ugal | I guess if it proves to be confusing more context can be added in the form of another error later | 08:22 |
| d0ugal | so | 08:22 |
| * d0ugal shrugs | 08:22 | |
| d0ugal | +1 | 08:22 |
| rakhmerov | moving forward, let's have decorators for this | 08:22 |
| rakhmerov | :)) | 08:23 |
| _gryf | rakhmerov, I'm cool with that, although some comments like TODO might be useful if such tests will finally artive some day :) | 08:23 |
| d0ugal | it's unfortunate that it can't be handled in the base class. | 08:23 |
| d0ugal | well, it can, but not with the current code I don't think. | 08:23 |
| rakhmerov | right | 08:23 |
| rakhmerov | d0ugal: I just assigned a simple bug to you | 08:29 |
| rakhmerov | https://bugs.launchpad.net/mistral/+bug/1568541 | 08:30 |
| openstack | Launchpad bug 1568541 in Mistral "action-update API on non existing action - creates action instead of returning 404" [Medium,New] - Assigned to Dougal Matthews (d0ugal) | 08:30 |
| d0ugal | rakhmerov: cool, that does some easy :) I should have some time to take a look today | 08:31 |
| rakhmerov | d0ugal: where are you located? | 08:31 |
| d0ugal | rakhmerov: Glasgow, Scotland | 08:31 |
| rakhmerov | ooh, I see | 08:31 |
| rakhmerov | not too far | 08:31 |
| rakhmerov | comparing to US | 08:31 |
| d0ugal | haha, indeed :) | 08:32 |
| d0ugal | rakhmerov: Where are you? | 08:34 |
| rakhmerov | Russia, Barnaul | 08:35 |
| d0ugal | I think you mentioned in the meeting but I forgot! | 08:35 |
| rakhmerov | it's a siberian city | 08:35 |
| d0ugal | oh, cool | 08:35 |
| d0ugal | Not somewhere I had heard of :) | 08:35 |
| rakhmerov | yeah, I'm the only openstacker in the city ) | 08:35 |
| d0ugal | hah | 08:35 |
| rakhmerov | it's close to Novosibirsk which is pretty famous | 08:35 |
| d0ugal | I don't know of any others in Glasgow, there are a few in Scotland however. | 08:35 |
| _gryf | rakhmerov, Barnaul? don't you lived in Saratov? | 08:36 |
| rakhmerov | for math, nuclear physics and biotech | 08:36 |
| rakhmerov | _gryf: nope | 08:36 |
| rakhmerov | :) | 08:36 |
| rakhmerov | I always was a remote Mirantis employee | 08:36 |
| _gryf | so I've got wrong information than | 08:36 |
| rakhmerov | just often went to business trips | 08:36 |
| *** dmk0202 has joined #openstack-mistral | 08:37 | |
| _gryf | so Mirantis have thier offices in Saratov, right? | 08:37 |
| rakhmerov | yes | 08:40 |
| rakhmerov | Moscow and Saratov in Russia | 08:40 |
| rakhmerov | Kharkiv in Ukraine | 08:40 |
| rakhmerov | and other countries: Poland, France, US | 08:41 |
| _gryf | rakhmerov, I see :) | 08:48 |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-mistral | 08:48 | |
| *** vishwanathj has joined #openstack-mistral | 08:55 | |
| *** rbrady has joined #openstack-mistral | 09:56 | |
| *** cheneydc has quit IRC | 09:56 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Removing redundant wf_ex_id parameter for rerun across the code https://review.openstack.org/326963 | 09:59 |
| *** toddjohn has quit IRC | 10:06 | |
| *** toddjohn has joined #openstack-mistral | 10:07 | |
| *** vishwanathj has quit IRC | 10:08 | |
| *** toddjohn has quit IRC | 10:11 | |
| *** rbrady is now known as rbrady-afk | 10:32 | |
| *** d0ugal has quit IRC | 10:59 | |
| *** d0ugal has joined #openstack-mistral | 11:01 | |
| *** rbrady-afk has quit IRC | 11:08 | |
| *** d0ugal has quit IRC | 11:09 | |
| *** toddjohn has joined #openstack-mistral | 11:23 | |
| *** toddjohn has quit IRC | 11:28 | |
| *** d0ugal has joined #openstack-mistral | 11:33 | |
| openstackgerrit | Merged openstack/mistral: Add a test that verifies an old bug with join https://review.openstack.org/326819 | 12:05 |
| *** dprince has joined #openstack-mistral | 12:15 | |
| *** toddjohn has joined #openstack-mistral | 12:17 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 12:19 |
| *** toddjohn has quit IRC | 12:22 | |
| *** rbrady has joined #openstack-mistral | 12:23 | |
| *** rbrady has quit IRC | 12:31 | |
| *** vishwanathj has joined #openstack-mistral | 12:41 | |
| *** rbrady has joined #openstack-mistral | 12:44 | |
| *** rbrady has quit IRC | 13:14 | |
| *** bobh has joined #openstack-mistral | 13:29 | |
| *** bobh has quit IRC | 13:41 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 14:22 |
| *** tonytan4ever has joined #openstack-mistral | 14:34 | |
| *** renato_r has joined #openstack-mistral | 15:00 | |
| *** tonytan4ever has quit IRC | 15:03 | |
| *** tonytan4ever has joined #openstack-mistral | 15:09 | |
| *** dprince has quit IRC | 15:13 | |
| *** dmk0202 has quit IRC | 15:29 | |
| *** chlong has quit IRC | 15:58 | |
| *** gyee has joined #openstack-mistral | 16:15 | |
| *** d0ugal has quit IRC | 16:33 | |
| *** dprince has joined #openstack-mistral | 16:41 | |
| *** d0ugal has joined #openstack-mistral | 16:50 | |
| *** tonytan4ever has quit IRC | 17:04 | |
| *** vishwanathj has quit IRC | 17:11 | |
| *** KriSstaL has joined #openstack-mistral | 17:21 | |
| *** dprince has quit IRC | 17:22 | |
| *** dprince has joined #openstack-mistral | 17:23 | |
| *** tonytan4ever has joined #openstack-mistral | 17:23 | |
| *** KriSstaL has left #openstack-mistral | 17:23 | |
| *** mgershen has quit IRC | 18:34 | |
| *** jtomasek has joined #openstack-mistral | 19:01 | |
| *** toddjohn has joined #openstack-mistral | 19:06 | |
| *** harlowja has quit IRC | 19:12 | |
| *** harlowja has joined #openstack-mistral | 19:15 | |
| *** mgershen has joined #openstack-mistral | 19:19 | |
| *** gyee has quit IRC | 19:40 | |
| *** openstackgerrit has quit IRC | 20:48 | |
| *** openstackgerrit has joined #openstack-mistral | 20:48 | |
| *** gyee has joined #openstack-mistral | 20:55 | |
| *** toddjohn_ has joined #openstack-mistral | 20:55 | |
| *** toddjohn has quit IRC | 20:59 | |
| *** chlong has joined #openstack-mistral | 21:06 | |
| *** toddjohn_ has quit IRC | 21:18 | |
| *** toddjohn has joined #openstack-mistral | 21:18 | |
| *** toddjohn has quit IRC | 21:24 | |
| *** tonytan4ever has quit IRC | 21:31 | |
| *** dprince has quit IRC | 22:01 | |
| *** renato_r has quit IRC | 23:33 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!