Friday, 2016-07-08

*** chlong has quit IRC00:05
*** bobh has joined #openstack-mistral00:40
*** vishwanathj has quit IRC00:41
*** cheneydc has joined #openstack-mistral00:58
*** cheneydc has quit IRC00:59
*** tonytan4ever has joined #openstack-mistral01:06
*** bobh has quit IRC01:22
*** chlong has joined #openstack-mistral01:27
*** bobh has joined #openstack-mistral01:31
*** bobh has quit IRC01:32
*** bobh has joined #openstack-mistral01:54
*** chlong has quit IRC02:08
*** gyee has quit IRC03:09
*** bobh has quit IRC03:33
*** chlong has joined #openstack-mistral04:20
*** igormarnat has quit IRC04:44
*** igormarnat has joined #openstack-mistral04:44
openstackgerritMerged openstack/mistral: Stylistic cleanups to lazy loading patch  https://review.openstack.org/33892505:18
*** kzaitsev_ws has quit IRC05:22
openstackgerritMerged openstack/mistral: Log warn openstack action generation failures  https://review.openstack.org/33899605:32
openstackgerritMerged openstack/mistral: Fix Murano action _get_fake_class  https://review.openstack.org/33895505:32
openstackgerritAndras Kovi proposed openstack/mistral: Add target parameters to REST API  https://review.openstack.org/33934905:33
*** kzaitsev_ws has joined #openstack-mistral06:09
openstackgerritMerged openstack/mistral: Fix Magnum action _get_fake_class  https://review.openstack.org/33899106:16
rakhmerovddeja: hi Dawid, I reviewed your patches06:16
ddejarakhmerov: Hi, yes, I saw emails06:17
rakhmerovgreat work, could you please address some minor comments today?06:17
rakhmerovthe first one is about ready to get merged06:17
rakhmerovon the second, it is ok too but I have doubts only about "idempotent" name06:18
rakhmerovnot sure we need to use it06:18
ddejarakhmerov: sure. I have some internal work to do ASAP ;) but I should complete it in ~2 hours and then I'll fix my patches06:18
rakhmerovwell, I think it's ok for internal usage but not sure we need to expose it in DSL06:18
rakhmerovyes, great06:18
rakhmerovand it seems like the whole thing is about to get done )06:19
ddejarakhmerov: That's OK, I can think about some other name. I like the 'safe-rerun'06:19
rakhmerovyou just need send another patch with DSL changes06:19
rakhmerovand please do good testing06:19
rakhmerovyes, "safe-rerun" looks ok06:19
rakhmerovor you can propose something else06:20
ddejarakhmerov: yes. I left the comment in config that kombu driver is experimental06:20
rakhmerovidempotent is too math'ish :)06:20
ddejaand it will stay there unitll I test it well :)06:20
ddejaoh, btw Renat, I found strange bug during work on latest patch: https://bugs.launchpad.net/mistral/+bug/159991806:22
openstackLaunchpad bug 1599918 in Mistral "Test mistral.tests.unit.engine.test_environment.EnvironmentTest.test_subworkflow_env_recursive print invalid stacktrace in case there is assertion error" [Undecided,New]06:22
*** prince__ has quit IRC06:22
ddejarakhmerov: I'm not sure who was working on function 'print_executions' from tests, but it sometimes behave really strange06:23
ddejarakhmerov: 'I'm not sure who was working on function' - I meant, I'm not sure who to ask ;)06:23
rakhmerovddeja: it's my thing )06:25
rakhmerovwhy strange?06:25
ddejawell, I explained in a bug description06:25
rakhmerovlet me see06:25
ddejabut basically, it throws exception that covers the 'AssertionError'06:26
ddejaAnd thus, make it hard to debug06:26
rakhmerovthe idea was as follows: some bugs are hard to reproduce locally, they only appear in gates. And in order to gather some info after test failures I added this printing to see state of all objects in DB06:26
rakhmerovall executinos06:26
ddejaoh, so it may missbehave locally?06:31
ddejaI mean, it was meant to run only on gate?06:32
rakhmerovno, not only on gate06:33
rakhmerovit happens locally too06:33
rakhmerovI mean it was done mostly for that06:33
ddejaOK06:33
rakhmerovbecause I often had situations when I was unable to reproduce some failures locally06:34
rakhmerovbut then were reproduced on gates often06:34
rakhmerovso I wanted to take advantage of gathering as much info as possible06:34
rakhmerovby printing all workflow state06:34
rakhmerovyeah, I see where the problem is06:35
rakhmerovI will fix it soon06:35
ddejaI don't want to resolve this bug right now, just wanted you to ACK that it is there :) Because for me it took 3 hours of debbuging to realse that the stack trace was covering my actuall stack trace06:35
ddejaoh, great :)06:35
rakhmerovyeah, the problem is simple06:35
rakhmerovI need to be doing this printing in TX, that's it )06:35
ddejaoh, OK06:36
rakhmerovotherwise lazy loading doesn't work in some cases06:36
rakhmerovyeah, SQLAlchemy issue06:36
ddejaOK06:36
*** chlong has quit IRC06:42
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix utility print_executions method  https://review.openstack.org/33936406:49
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix utility print_executions method  https://review.openstack.org/33936406:57
rakhmerovddeja: https://review.openstack.org/#/c/339364/06:59
*** tonytan4ever has quit IRC07:06
ddejarakhmerov: It wokrs, thanks. I left my +1 :)07:06
rakhmerov:)07:06
*** Ravikiran_K has joined #openstack-mistral07:25
*** tonytan4ever has joined #openstack-mistral07:26
*** shardy has joined #openstack-mistral07:34
*** jpich has joined #openstack-mistral07:44
*** Ravikiran_K has quit IRC08:06
openstackgerritRenat Akhmerov proposed openstack/mistral: Add more tests for error handling  https://review.openstack.org/33885608:13
openstackgerritRenat Akhmerov proposed openstack/mistral: Add error handling tests: invalid workflow input, error in first task  https://review.openstack.org/33886908:13
openstackgerritRenat Akhmerov proposed openstack/mistral: Add proper error handling for task continuation  https://review.openstack.org/33940108:13
openstackgerritRenat Akhmerov proposed openstack/mistral: Add proper handling for implicit task completion  https://review.openstack.org/33941308:58
openstackgerritMerged openstack/mistral: Add configuration option for endpoint type  https://review.openstack.org/33563709:01
*** tonytan4ever has quit IRC09:07
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760309:10
openstackgerritRenat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC  https://review.openstack.org/33648809:10
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710009:10
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760310:31
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710010:31
rakhmerovhparekh: hi, I addressed your comment in https://review.openstack.org/#/c/337100/10:32
rakhmerovadded if statement for now10:32
rakhmerovgood catch10:32
*** Ravikiran_K has joined #openstack-mistral10:59
hparekhrakhmerov, ok, Thanks11:00
*** dprince has joined #openstack-mistral12:16
*** shaikapsar has joined #openstack-mistral12:52
shaikapsarHi All, I'm getting an error message while executing mistral workflow. Failed to handle action completion [wf=std.create_instance, task=create_vm, action=nova.servers_create]: Can not evaluate YAQL expression: $.create_vm.id12:55
*** bobh has joined #openstack-mistral13:00
*** bobh has quit IRC13:11
openstackgerritMerged openstack/mistral: Add more tests for error handling  https://review.openstack.org/33885613:26
openstackgerritMerged openstack/mistral: Add error handling tests: invalid workflow input, error in first task  https://review.openstack.org/33886913:30
*** tonytan4ever has joined #openstack-mistral13:54
*** shaikapsar has quit IRC14:04
*** rrecio has joined #openstack-mistral14:51
*** rrecio_ has joined #openstack-mistral14:53
*** rrecio has quit IRC14:56
*** vishwanathj has joined #openstack-mistral15:10
openstackgerritDawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer  https://review.openstack.org/33654815:16
openstackgerritDawid Deja proposed openstack/mistral: Add tests for Kombu driver  https://review.openstack.org/33048315:16
openstackgerritDawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in Engine  https://review.openstack.org/33911315:16
*** bobh has joined #openstack-mistral15:21
Ravikiran_KHi..if i client execution id in mistral dashboard getting error15:24
Ravikiran_KError: Unable to retrieve tasks.: _get_task_resources_with_results() got multiple values for keyword argument 'wf_ex_id'15:25
Ravikiran_Ki clicked on execution id got above error15:26
therveRavikiran_K, Yeah looks like a bug introduced recently15:58
thervexavierhardy, ^^^15:59
*** vishwanathj has quit IRC16:30
*** Ravikiran_K has quit IRC17:15
*** bobh has quit IRC17:16
*** gyee has joined #openstack-mistral17:29
*** jpich has quit IRC17:33
*** dprince has quit IRC17:50
*** bobh has joined #openstack-mistral20:07
*** dprince has joined #openstack-mistral20:14
*** bobh has quit IRC20:35
*** bobh has joined #openstack-mistral20:37
*** shardy has quit IRC20:44
*** bobh has quit IRC21:28
*** dprince has quit IRC21:53
*** rbrady has quit IRC22:16
*** rbrady has joined #openstack-mistral22:29
*** rrecio_ has quit IRC23:47

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!