*** chlong has quit IRC | 00:05 | |
*** bobh has joined #openstack-mistral | 00:40 | |
*** vishwanathj has quit IRC | 00:41 | |
*** cheneydc has joined #openstack-mistral | 00:58 | |
*** cheneydc has quit IRC | 00:59 | |
*** tonytan4ever has joined #openstack-mistral | 01:06 | |
*** bobh has quit IRC | 01:22 | |
*** chlong has joined #openstack-mistral | 01:27 | |
*** bobh has joined #openstack-mistral | 01:31 | |
*** bobh has quit IRC | 01:32 | |
*** bobh has joined #openstack-mistral | 01:54 | |
*** chlong has quit IRC | 02:08 | |
*** gyee has quit IRC | 03:09 | |
*** bobh has quit IRC | 03:33 | |
*** chlong has joined #openstack-mistral | 04:20 | |
*** igormarnat has quit IRC | 04:44 | |
*** igormarnat has joined #openstack-mistral | 04:44 | |
openstackgerrit | Merged openstack/mistral: Stylistic cleanups to lazy loading patch https://review.openstack.org/338925 | 05:18 |
---|---|---|
*** kzaitsev_ws has quit IRC | 05:22 | |
openstackgerrit | Merged openstack/mistral: Log warn openstack action generation failures https://review.openstack.org/338996 | 05:32 |
openstackgerrit | Merged openstack/mistral: Fix Murano action _get_fake_class https://review.openstack.org/338955 | 05:32 |
openstackgerrit | Andras Kovi proposed openstack/mistral: Add target parameters to REST API https://review.openstack.org/339349 | 05:33 |
*** kzaitsev_ws has joined #openstack-mistral | 06:09 | |
openstackgerrit | Merged openstack/mistral: Fix Magnum action _get_fake_class https://review.openstack.org/338991 | 06:16 |
rakhmerov | ddeja: hi Dawid, I reviewed your patches | 06:16 |
ddeja | rakhmerov: Hi, yes, I saw emails | 06:17 |
rakhmerov | great work, could you please address some minor comments today? | 06:17 |
rakhmerov | the first one is about ready to get merged | 06:17 |
rakhmerov | on the second, it is ok too but I have doubts only about "idempotent" name | 06:18 |
rakhmerov | not sure we need to use it | 06:18 |
ddeja | rakhmerov: sure. I have some internal work to do ASAP ;) but I should complete it in ~2 hours and then I'll fix my patches | 06:18 |
rakhmerov | well, I think it's ok for internal usage but not sure we need to expose it in DSL | 06:18 |
rakhmerov | yes, great | 06:18 |
rakhmerov | and it seems like the whole thing is about to get done ) | 06:19 |
ddeja | rakhmerov: That's OK, I can think about some other name. I like the 'safe-rerun' | 06:19 |
rakhmerov | you just need send another patch with DSL changes | 06:19 |
rakhmerov | and please do good testing | 06:19 |
rakhmerov | yes, "safe-rerun" looks ok | 06:19 |
rakhmerov | or you can propose something else | 06:20 |
ddeja | rakhmerov: yes. I left the comment in config that kombu driver is experimental | 06:20 |
rakhmerov | idempotent is too math'ish :) | 06:20 |
ddeja | and it will stay there unitll I test it well :) | 06:20 |
ddeja | oh, btw Renat, I found strange bug during work on latest patch: https://bugs.launchpad.net/mistral/+bug/1599918 | 06:22 |
openstack | Launchpad bug 1599918 in Mistral "Test mistral.tests.unit.engine.test_environment.EnvironmentTest.test_subworkflow_env_recursive print invalid stacktrace in case there is assertion error" [Undecided,New] | 06:22 |
*** prince__ has quit IRC | 06:22 | |
ddeja | rakhmerov: I'm not sure who was working on function 'print_executions' from tests, but it sometimes behave really strange | 06:23 |
ddeja | rakhmerov: 'I'm not sure who was working on function' - I meant, I'm not sure who to ask ;) | 06:23 |
rakhmerov | ddeja: it's my thing ) | 06:25 |
rakhmerov | why strange? | 06:25 |
ddeja | well, I explained in a bug description | 06:25 |
rakhmerov | let me see | 06:25 |
ddeja | but basically, it throws exception that covers the 'AssertionError' | 06:26 |
ddeja | And thus, make it hard to debug | 06:26 |
rakhmerov | the idea was as follows: some bugs are hard to reproduce locally, they only appear in gates. And in order to gather some info after test failures I added this printing to see state of all objects in DB | 06:26 |
rakhmerov | all executinos | 06:26 |
ddeja | oh, so it may missbehave locally? | 06:31 |
ddeja | I mean, it was meant to run only on gate? | 06:32 |
rakhmerov | no, not only on gate | 06:33 |
rakhmerov | it happens locally too | 06:33 |
rakhmerov | I mean it was done mostly for that | 06:33 |
ddeja | OK | 06:33 |
rakhmerov | because I often had situations when I was unable to reproduce some failures locally | 06:34 |
rakhmerov | but then were reproduced on gates often | 06:34 |
rakhmerov | so I wanted to take advantage of gathering as much info as possible | 06:34 |
rakhmerov | by printing all workflow state | 06:34 |
rakhmerov | yeah, I see where the problem is | 06:35 |
rakhmerov | I will fix it soon | 06:35 |
ddeja | I don't want to resolve this bug right now, just wanted you to ACK that it is there :) Because for me it took 3 hours of debbuging to realse that the stack trace was covering my actuall stack trace | 06:35 |
ddeja | oh, great :) | 06:35 |
rakhmerov | yeah, the problem is simple | 06:35 |
rakhmerov | I need to be doing this printing in TX, that's it ) | 06:35 |
ddeja | oh, OK | 06:36 |
rakhmerov | otherwise lazy loading doesn't work in some cases | 06:36 |
rakhmerov | yeah, SQLAlchemy issue | 06:36 |
ddeja | OK | 06:36 |
*** chlong has quit IRC | 06:42 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix utility print_executions method https://review.openstack.org/339364 | 06:49 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix utility print_executions method https://review.openstack.org/339364 | 06:57 |
rakhmerov | ddeja: https://review.openstack.org/#/c/339364/ | 06:59 |
*** tonytan4ever has quit IRC | 07:06 | |
ddeja | rakhmerov: It wokrs, thanks. I left my +1 :) | 07:06 |
rakhmerov | :) | 07:06 |
*** Ravikiran_K has joined #openstack-mistral | 07:25 | |
*** tonytan4ever has joined #openstack-mistral | 07:26 | |
*** shardy has joined #openstack-mistral | 07:34 | |
*** jpich has joined #openstack-mistral | 07:44 | |
*** Ravikiran_K has quit IRC | 08:06 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add more tests for error handling https://review.openstack.org/338856 | 08:13 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add error handling tests: invalid workflow input, error in first task https://review.openstack.org/338869 | 08:13 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add proper error handling for task continuation https://review.openstack.org/339401 | 08:13 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add proper handling for implicit task completion https://review.openstack.org/339413 | 08:58 |
openstackgerrit | Merged openstack/mistral: Add configuration option for endpoint type https://review.openstack.org/335637 | 09:01 |
*** tonytan4ever has quit IRC | 09:07 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 09:10 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC https://review.openstack.org/336488 | 09:10 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 09:10 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 10:31 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 10:31 |
rakhmerov | hparekh: hi, I addressed your comment in https://review.openstack.org/#/c/337100/ | 10:32 |
rakhmerov | added if statement for now | 10:32 |
rakhmerov | good catch | 10:32 |
*** Ravikiran_K has joined #openstack-mistral | 10:59 | |
hparekh | rakhmerov, ok, Thanks | 11:00 |
*** dprince has joined #openstack-mistral | 12:16 | |
*** shaikapsar has joined #openstack-mistral | 12:52 | |
shaikapsar | Hi All, I'm getting an error message while executing mistral workflow. Failed to handle action completion [wf=std.create_instance, task=create_vm, action=nova.servers_create]: Can not evaluate YAQL expression: $.create_vm.id | 12:55 |
*** bobh has joined #openstack-mistral | 13:00 | |
*** bobh has quit IRC | 13:11 | |
openstackgerrit | Merged openstack/mistral: Add more tests for error handling https://review.openstack.org/338856 | 13:26 |
openstackgerrit | Merged openstack/mistral: Add error handling tests: invalid workflow input, error in first task https://review.openstack.org/338869 | 13:30 |
*** tonytan4ever has joined #openstack-mistral | 13:54 | |
*** shaikapsar has quit IRC | 14:04 | |
*** rrecio has joined #openstack-mistral | 14:51 | |
*** rrecio_ has joined #openstack-mistral | 14:53 | |
*** rrecio has quit IRC | 14:56 | |
*** vishwanathj has joined #openstack-mistral | 15:10 | |
openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer https://review.openstack.org/336548 | 15:16 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Add tests for Kombu driver https://review.openstack.org/330483 | 15:16 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in Engine https://review.openstack.org/339113 | 15:16 |
*** bobh has joined #openstack-mistral | 15:21 | |
Ravikiran_K | Hi..if i client execution id in mistral dashboard getting error | 15:24 |
Ravikiran_K | Error: Unable to retrieve tasks.: _get_task_resources_with_results() got multiple values for keyword argument 'wf_ex_id' | 15:25 |
Ravikiran_K | i clicked on execution id got above error | 15:26 |
therve | Ravikiran_K, Yeah looks like a bug introduced recently | 15:58 |
therve | xavierhardy, ^^^ | 15:59 |
*** vishwanathj has quit IRC | 16:30 | |
*** Ravikiran_K has quit IRC | 17:15 | |
*** bobh has quit IRC | 17:16 | |
*** gyee has joined #openstack-mistral | 17:29 | |
*** jpich has quit IRC | 17:33 | |
*** dprince has quit IRC | 17:50 | |
*** bobh has joined #openstack-mistral | 20:07 | |
*** dprince has joined #openstack-mistral | 20:14 | |
*** bobh has quit IRC | 20:35 | |
*** bobh has joined #openstack-mistral | 20:37 | |
*** shardy has quit IRC | 20:44 | |
*** bobh has quit IRC | 21:28 | |
*** dprince has quit IRC | 21:53 | |
*** rbrady has quit IRC | 22:16 | |
*** rbrady has joined #openstack-mistral | 22:29 | |
*** rrecio_ has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!