*** tonytan4ever has joined #openstack-mistral | 00:16 | |
*** achanda has quit IRC | 00:20 | |
*** tonytan4ever has quit IRC | 00:21 | |
*** chlong has joined #openstack-mistral | 00:26 | |
*** chlong has quit IRC | 00:30 | |
*** chlong has joined #openstack-mistral | 00:41 | |
*** bobh has joined #openstack-mistral | 00:43 | |
*** bobh has quit IRC | 00:45 | |
*** chlong has quit IRC | 01:10 | |
*** bobh has joined #openstack-mistral | 01:11 | |
kong | hparekh: hi, i have a question related to RBAC you added to mistral, that was when I doing event trigger implementation. As a admin user (user with admin role at the moment), what particular thing I can do in Mistral? Can I be able to look up workflows/actions belong to other tenants? Can I create a event trigger to listen to notifications sent out by | 01:14 |
---|---|---|
kong | resources of other tenants? | 01:14 |
*** toddjohn has joined #openstack-mistral | 01:14 | |
*** tonytan4ever has joined #openstack-mistral | 01:18 | |
*** tonytan4ever has quit IRC | 01:22 | |
*** toddjohn has quit IRC | 01:23 | |
*** chlong has joined #openstack-mistral | 01:23 | |
*** toddjohn has joined #openstack-mistral | 01:23 | |
*** toddjohn has quit IRC | 01:28 | |
*** chlong has quit IRC | 01:28 | |
*** chlong has joined #openstack-mistral | 01:30 | |
*** bobh has quit IRC | 01:55 | |
*** bobh has joined #openstack-mistral | 02:03 | |
*** tonytan4ever has joined #openstack-mistral | 02:52 | |
rakhmerov | hparekh: hi Hardik | 03:32 |
rakhmerov | you there? | 03:33 |
*** achanda has joined #openstack-mistral | 03:54 | |
hparekh | rakhmerov, Hi | 03:57 |
rakhmerov | yep, already solved ) | 04:00 |
*** achanda has quit IRC | 04:00 | |
rakhmerov | ddeja: hi Dawid, congrats on getting core status! | 04:06 |
*** chlong has quit IRC | 04:15 | |
openstackgerrit | Merged openstack/mistral: Enable user to use transport_url in kombu driver https://review.openstack.org/347935 | 04:15 |
*** bobh has quit IRC | 04:18 | |
*** chlong has joined #openstack-mistral | 04:31 | |
rakhmerov | hparekh, ddeja: guys, I'd like to ask you to document changes you recently made. Dawid: your RPC changes (including per-task delivery mode). Hardik: SSL support, you can make it dependent on https://review.openstack.org/#/c/344598 | 04:36 |
rakhmerov | hparekh: one small comment in https://review.openstack.org/#/c/344598 | 04:40 |
rakhmerov | I wonder what you think.. | 04:40 |
hparekh | rakhmerov, hmmmm.. I think its ok to use conf option direct. I cannot recall why I have provided 'use_ssl' option. Anyways I will incorporate your comment. Thanks | 04:56 |
hparekh | rakhmerov, Sure I will add release note and doc changes | 04:56 |
*** achanda has joined #openstack-mistral | 04:57 | |
*** tonytan4ever has quit IRC | 05:25 | |
*** vishwanathj has joined #openstack-mistral | 05:51 | |
*** vishwanathj has quit IRC | 05:55 | |
*** janki has joined #openstack-mistral | 05:55 | |
*** vishwanathj has joined #openstack-mistral | 06:21 | |
*** toddjohn has joined #openstack-mistral | 06:24 | |
*** tonytan4ever has joined #openstack-mistral | 06:26 | |
*** toddjohn has quit IRC | 06:28 | |
*** tonytan4ever has quit IRC | 06:31 | |
*** _achatterjee_ has joined #openstack-mistral | 06:46 | |
*** _achatterjee_ has quit IRC | 06:46 | |
*** achatterjee has joined #openstack-mistral | 06:46 | |
*** achatterjee has quit IRC | 06:47 | |
*** achatterjee has joined #openstack-mistral | 06:47 | |
*** chlong has quit IRC | 06:59 | |
*** slagle has quit IRC | 07:06 | |
*** stevebaker has quit IRC | 07:09 | |
*** chlong has joined #openstack-mistral | 07:11 | |
rakhmerov | hparekh: ok, thanks | 07:19 |
rakhmerov | hparekh, ddeja, kong: guys, I would appreciate if you review my patch sequence starting with https://review.openstack.org/#/c/347172 | 07:20 |
rakhmerov | they significantly improve Mistral performance | 07:20 |
rakhmerov | especially the second one with caching | 07:21 |
*** tonytan4ever has joined #openstack-mistral | 07:27 | |
*** tonytan4ever has quit IRC | 07:32 | |
*** chlong has quit IRC | 07:34 | |
ddeja | rakhmerov: Hi, thank you | 07:57 |
rakhmerov | ddeja: you're welcome ) | 07:57 |
ddeja | rakhmerov: I have 1 hour meeting starting in a minute, but then I will add docs and look on changes | 07:57 |
rakhmerov | ddeja: sure Dawid, no problem | 07:58 |
rakhmerov | btw, yes, you were supposed to be in that list with other folks, it's just a habbit :) | 07:58 |
rakhmerov | I'll get rid of it | 07:58 |
*** achanda_ has joined #openstack-mistral | 08:05 | |
*** achanda has quit IRC | 08:07 | |
*** shardy has joined #openstack-mistral | 08:11 | |
*** achanda_ has quit IRC | 08:52 | |
*** nmakhotkin has joined #openstack-mistral | 09:04 | |
*** vishwanathj has quit IRC | 09:22 | |
*** hparekh has quit IRC | 09:24 | |
*** tonytan4ever has joined #openstack-mistral | 09:28 | |
*** tonytan4ever has quit IRC | 09:33 | |
*** hparekh has joined #openstack-mistral | 09:37 | |
openstackgerrit | prince_katiyar proposed openstack/python-mistralclient: Add error message when OS_USERNAME or OS_PASSWORD not provided https://review.openstack.org/348142 | 09:49 |
*** achanda has joined #openstack-mistral | 09:52 | |
*** achanda has quit IRC | 09:58 | |
openstackgerrit | hardik proposed openstack/mistral: Added support for SSL connection in mistra-api server https://review.openstack.org/344598 | 09:59 |
*** toddjohn has joined #openstack-mistral | 10:00 | |
*** toddjohn has quit IRC | 10:04 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Invalidate workflow spec cache on workflow definition updates https://review.openstack.org/348828 | 10:26 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing https://review.openstack.org/347758 | 10:26 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Splitting executions into different tables https://review.openstack.org/347172 | 10:26 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add 'unique_key' parameter for scheduling delayed calls https://review.openstack.org/349445 | 10:26 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Update docs and add release not for safe-rerun flag https://review.openstack.org/349449 | 10:41 |
jtomasek | hi, I have a question on action-execution error handling. for example here: https://review.openstack.org/#/c/348537/1/tripleo_common/actions/heat_capabilities.py | 10:50 |
jtomasek | there is an action which in case of exception returns a Result (line 61) | 10:50 |
jtomasek | data=None, error=err_mgs | 10:51 |
jtomasek | is it somehow possible to make the response use different http code then 200? The problem is, that it is hard to distinguish whether the response is error or not, because both responses look the same, just the contents of 'output/result' is different | 10:53 |
jtomasek | rbrady: ^ | 10:53 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues https://review.openstack.org/349457 | 11:18 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues https://review.openstack.org/349457 | 11:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: Add 'unique_key' for delayed calls https://review.openstack.org/349445 | 11:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Splitting executions into different tables https://review.openstack.org/347172 | 11:37 |
*** dprince has joined #openstack-mistral | 11:38 | |
*** zhenguo has quit IRC | 11:51 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller https://review.openstack.org/349466 | 11:52 |
*** achanda has joined #openstack-mistral | 11:56 | |
ddeja | jtomasek: Hi, I'm afraid it is not possible | 11:59 |
jtomasek | ddeja: ok, I am wondering what is the difference between 'data' and 'error' in https://github.com/openstack/mistral/blob/master/mistral/workflow/utils.py#L23 | 12:00 |
ddeja | HTTP code says 200 means that mistral API respond correctly, it should not depend on what are the body of the message | 12:00 |
ddeja | jtomasek: some action returns some 'data', so this is what is stored in self.data | 12:01 |
jtomasek | ddeja: both seem to end up in 'output/result' | 12:01 |
*** achanda has quit IRC | 12:01 | |
ddeja | jtomasek: basically it is used internaly by mistral engine | 12:01 |
ddeja | to determine how given execution edned | 12:01 |
jtomasek | ddeja: yeah, so workflow is able to figure out if the action execution ended up as success or error | 12:02 |
ddeja | exactly | 12:02 |
jtomasek | ddeja: but in case when action-execution is called direcly via mistral api call (without being part of the workflow) it would be nice if the api call returned 200 for success and some error http code for error | 12:03 |
*** Ravikiran_K has joined #openstack-mistral | 12:03 | |
ddeja | jtomasek: oooh, I didn't understand the full context | 12:03 |
ddeja | no I see what you mean | 12:03 |
jtomasek | ddeja: http://docs.openstack.org/developer/mistral/developer/webapi/v2.html#post--v2-action_executions | 12:04 |
openstackgerrit | hardik proposed openstack/mistral: Added releasenote for https support https://review.openstack.org/349474 | 12:04 |
ddeja | jtomasek: hm, from what I know it is not possible to change the HTTP code of direct action call right now | 12:06 |
ddeja | rakhmerov: ^^ | 12:06 |
jtomasek | ddeja: the change might be relatively simple - add http code as another parameter to Result | 12:08 |
jtomasek | (or make it part of error) | 12:08 |
jtomasek | or mistral could set some error httpd code on the response if there was error parameter specified | 12:09 |
ddeja | jtomasek: agree. I'm just saying that it is not currently possible | 12:09 |
jtomasek | yep, thanks! | 12:10 |
ddeja | but I'm not sure if and how it can be set | 12:10 |
ddeja | I can talk about it on a mistral meeting today ^^ | 12:11 |
ddeja | jtomasek: ^^ | 12:11 |
jtomasek | ddeja: that would be great | 12:11 |
ddeja | jtomasek: or if you want you can do it by yourself: https://wiki.openstack.org/wiki/Meetings/MistralAgenda | 12:12 |
jtomasek | ddeja: ok, I will | 12:14 |
ddeja | jtomasek: cool :) | 12:15 |
*** toddjohn has joined #openstack-mistral | 12:41 | |
*** bobh has joined #openstack-mistral | 13:09 | |
*** tonytan4ever has joined #openstack-mistral | 13:15 | |
*** tonytan4ever has quit IRC | 13:19 | |
*** bobh has quit IRC | 13:32 | |
*** tonytan4ever has joined #openstack-mistral | 13:34 | |
*** tonytan_brb has joined #openstack-mistral | 13:39 | |
*** tonytan4ever has quit IRC | 13:41 | |
nmakhotkin | jtomasek, let me try to answer why it is happenning so | 13:49 |
nmakhotkin | hi | 13:49 |
nmakhotkin | IMO from mistral point all is right because: | 13:50 |
nmakhotkin | 1. Mistral api receives request correctly and passes it further to engine (to launch action) | 13:51 |
nmakhotkin | 2. 200 ok code means that Mistral just correctly executed action but this action returned an error | 13:52 |
nmakhotkin | Otherwise, if 400 code were sended, that would mean that something wrong with request itself (e.g. wrong action or it's parameters) or maybe something wrong on server side (but in this case mistral returns 5xx) | 13:54 |
jtomasek | nmakhotkin: yeah, this makes sense, but the flaw is that client is not able to identify if the action returned an error :/ It would be nice if the action could optionally set the httpd code for the response | 13:57 |
*** achanda has joined #openstack-mistral | 13:59 | |
nmakhotkin | jtomasek, hmmm | 13:59 |
nmakhotkin | I got | 13:59 |
nmakhotkin | maybe mistral could send different fields in the answer (say, 'error' instead of 'result') | 14:03 |
jtomasek | nmakhotkin: we'll probably have to examine the response on the client and make a decision if the response is error or not based on the contents of output/result | 14:03 |
jtomasek | nmakhotkin: yes, that could work | 14:03 |
jtomasek | nmakhotkin: that would even make sense, since the Result basically lets user do this (it has data and error parameters) | 14:04 |
*** kozhukalov has quit IRC | 14:04 | |
*** kong has quit IRC | 14:04 | |
*** bobh has joined #openstack-mistral | 14:04 | |
jtomasek | nmakhotkin: hmm, but problem might be that both can be present at the same time (data and error) | 14:04 |
nmakhotkin | yup | 14:05 |
openstackgerrit | Andras Kovi proposed openstack/mistral: Add target parameters to REST API https://review.openstack.org/339349 | 14:05 |
*** achanda has quit IRC | 14:05 | |
jtomasek | nmakhotkin: so probably appending error to output.result? or put it in addition (output.error) | 14:05 |
nmakhotkin | then I suggest setting a state of this action execution on server-side | 14:05 |
nmakhotkin | and then we can see state along with result | 14:06 |
nmakhotkin | success or error | 14:06 |
jtomasek | nmakhotkin: I see | 14:06 |
*** bobh has quit IRC | 14:07 | |
jtomasek | nmakhotkin: this is an example response from such action http://paste.openstack.org/show/545045/ | 14:08 |
jtomasek | nmakhotkin: the state is null, how is it possible to set it? | 14:09 |
jtomasek | nmakhotkin: note that action that is run directly as an action-execution does not get persisted | 14:10 |
*** tonytan4ever has joined #openstack-mistral | 14:14 | |
*** tonytan_brb has quit IRC | 14:17 | |
*** kong has joined #openstack-mistral | 14:18 | |
*** kozhukalov has joined #openstack-mistral | 14:18 | |
*** chlong has joined #openstack-mistral | 14:26 | |
*** chlong is now known as chlong|gone | 14:27 | |
*** chlong|gone has quit IRC | 14:32 | |
*** chlong|gone has joined #openstack-mistral | 14:33 | |
*** chlong|gone is now known as chlong | 14:34 | |
nmakhotkin | jtomasek: currently it is not possible yet | 14:36 |
nmakhotkin | but one simple change to Mistral will make it possible :) | 14:37 |
*** tonytan4ever has quit IRC | 14:38 | |
jtomasek | nmakhotkin: cool | 14:38 |
*** janki has quit IRC | 14:43 | |
*** tonytan4ever has joined #openstack-mistral | 14:44 | |
*** vishwanathj has joined #openstack-mistral | 14:46 | |
*** clenimar has quit IRC | 14:49 | |
*** clenimar has joined #openstack-mistral | 14:51 | |
*** tonytan_brb has joined #openstack-mistral | 14:51 | |
*** tonytan4ever has quit IRC | 14:54 | |
*** rrecio has joined #openstack-mistral | 14:55 | |
*** bobh has joined #openstack-mistral | 14:58 | |
*** jistr is now known as jistr|call | 15:00 | |
*** nmakhotkin has quit IRC | 15:02 | |
*** dprince has quit IRC | 15:10 | |
*** jistr|call is now known as jistr | 15:12 | |
*** clenimar has quit IRC | 15:13 | |
*** clenimar has joined #openstack-mistral | 15:30 | |
*** bobh_ has joined #openstack-mistral | 15:32 | |
*** bobh has quit IRC | 15:32 | |
*** toddjohn has quit IRC | 15:36 | |
*** toddjohn has joined #openstack-mistral | 15:36 | |
*** venkat has joined #openstack-mistral | 15:51 | |
*** venkat has quit IRC | 15:55 | |
*** jistr is now known as jistr|biab | 16:01 | |
*** achanda has joined #openstack-mistral | 16:03 | |
*** achanda has quit IRC | 16:08 | |
*** dprince has joined #openstack-mistral | 16:33 | |
*** jistr|biab is now known as jistr | 16:49 | |
*** clenimar has quit IRC | 17:03 | |
*** achanda has joined #openstack-mistral | 17:06 | |
*** achanda has quit IRC | 17:10 | |
*** achanda has joined #openstack-mistral | 17:11 | |
*** achanda has quit IRC | 17:11 | |
*** achanda has joined #openstack-mistral | 17:12 | |
*** bobh_ has quit IRC | 17:20 | |
*** clenimar has joined #openstack-mistral | 17:21 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Invalidate workflow spec cache on workflow definition updates https://review.openstack.org/348828 | 17:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller https://review.openstack.org/349466 | 17:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing https://review.openstack.org/347758 | 17:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues https://review.openstack.org/349457 | 17:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: Add 'unique_key' for delayed calls https://review.openstack.org/349445 | 17:23 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Splitting executions into different tables https://review.openstack.org/347172 | 17:23 |
rakhmerov | ddeja: I addressed your comments in my patch for splitting into different tables | 17:24 |
*** Ravikiran_K has quit IRC | 17:31 | |
*** bobh has joined #openstack-mistral | 18:21 | |
*** bobh has quit IRC | 18:26 | |
*** bobh has joined #openstack-mistral | 18:35 | |
*** harlowja has quit IRC | 19:14 | |
*** harlowja has joined #openstack-mistral | 19:15 | |
*** achanda has quit IRC | 19:19 | |
*** shardy has quit IRC | 19:56 | |
openstackgerrit | Winson Chan proposed openstack/mistral: Implement workflow composers https://review.openstack.org/348614 | 20:48 |
openstackgerrit | Winson Chan proposed openstack/mistral: Add utility functions in workflow spec for graphing https://review.openstack.org/348613 | 20:48 |
openstackgerrit | Winson Chan proposed openstack/mistral: Implements WorkflowGraph for graphing tasks and transitions https://review.openstack.org/348612 | 20:48 |
openstackgerrit | Winson Chan proposed openstack/mistral: Add sample workflow conductor to test task sequences https://review.openstack.org/349695 | 20:48 |
*** dprince has quit IRC | 20:50 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows https://review.openstack.org/337696 | 20:52 |
*** toddjohn has quit IRC | 21:13 | |
*** stevebaker has joined #openstack-mistral | 21:34 | |
*** tonytan4ever has joined #openstack-mistral | 21:54 | |
*** tonytan_brb has quit IRC | 21:57 | |
*** toddjohn has joined #openstack-mistral | 22:14 | |
*** bobh has quit IRC | 22:14 | |
*** toddjohn has quit IRC | 22:18 | |
*** toddjohn has joined #openstack-mistral | 22:30 | |
*** toddjohn has quit IRC | 22:53 | |
*** tonytan4ever has quit IRC | 23:07 | |
*** achanda has joined #openstack-mistral | 23:16 | |
*** achanda has quit IRC | 23:32 | |
*** toddjohn has joined #openstack-mistral | 23:42 | |
openstackgerrit | Merged openstack/mistral: Add cancelled state to executions https://review.openstack.org/346281 | 23:44 |
*** toddjohn has quit IRC | 23:55 | |
*** rrecio has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!