Monday, 2016-08-01

*** tonytan4ever has joined #openstack-mistral00:16
*** achanda has quit IRC00:20
*** tonytan4ever has quit IRC00:21
*** chlong has joined #openstack-mistral00:26
*** chlong has quit IRC00:30
*** chlong has joined #openstack-mistral00:41
*** bobh has joined #openstack-mistral00:43
*** bobh has quit IRC00:45
*** chlong has quit IRC01:10
*** bobh has joined #openstack-mistral01:11
konghparekh: hi, i have a question related to RBAC you added to mistral, that was when I doing event trigger implementation. As a admin user (user with admin role at the moment), what particular thing I can do in Mistral? Can I be able to look up workflows/actions belong to other tenants? Can I create a event trigger to listen to notifications sent out by01:14
kongresources of other tenants?01:14
*** toddjohn has joined #openstack-mistral01:14
*** tonytan4ever has joined #openstack-mistral01:18
*** tonytan4ever has quit IRC01:22
*** toddjohn has quit IRC01:23
*** chlong has joined #openstack-mistral01:23
*** toddjohn has joined #openstack-mistral01:23
*** toddjohn has quit IRC01:28
*** chlong has quit IRC01:28
*** chlong has joined #openstack-mistral01:30
*** bobh has quit IRC01:55
*** bobh has joined #openstack-mistral02:03
*** tonytan4ever has joined #openstack-mistral02:52
rakhmerovhparekh: hi Hardik03:32
rakhmerovyou there?03:33
*** achanda has joined #openstack-mistral03:54
hparekhrakhmerov, Hi03:57
rakhmerovyep, already solved )04:00
*** achanda has quit IRC04:00
rakhmerovddeja: hi Dawid, congrats on getting core status!04:06
*** chlong has quit IRC04:15
openstackgerritMerged openstack/mistral: Enable user to use transport_url in kombu driver  https://review.openstack.org/34793504:15
*** bobh has quit IRC04:18
*** chlong has joined #openstack-mistral04:31
rakhmerovhparekh, ddeja: guys, I'd like to ask you to document changes you recently made. Dawid: your RPC changes (including per-task delivery mode). Hardik: SSL support, you can make it dependent on https://review.openstack.org/#/c/34459804:36
rakhmerovhparekh: one small comment in https://review.openstack.org/#/c/34459804:40
rakhmerovI wonder what you think..04:40
hparekhrakhmerov, hmmmm.. I think its ok to use conf option direct. I cannot recall why I have provided 'use_ssl' option. Anyways I will incorporate your comment. Thanks04:56
hparekhrakhmerov, Sure I will add release note and doc changes04:56
*** achanda has joined #openstack-mistral04:57
*** tonytan4ever has quit IRC05:25
*** vishwanathj has joined #openstack-mistral05:51
*** vishwanathj has quit IRC05:55
*** janki has joined #openstack-mistral05:55
*** vishwanathj has joined #openstack-mistral06:21
*** toddjohn has joined #openstack-mistral06:24
*** tonytan4ever has joined #openstack-mistral06:26
*** toddjohn has quit IRC06:28
*** tonytan4ever has quit IRC06:31
*** _achatterjee_ has joined #openstack-mistral06:46
*** _achatterjee_ has quit IRC06:46
*** achatterjee has joined #openstack-mistral06:46
*** achatterjee has quit IRC06:47
*** achatterjee has joined #openstack-mistral06:47
*** chlong has quit IRC06:59
*** slagle has quit IRC07:06
*** stevebaker has quit IRC07:09
*** chlong has joined #openstack-mistral07:11
rakhmerovhparekh: ok, thanks07:19
rakhmerovhparekh, ddeja, kong: guys, I would appreciate if you review my patch sequence starting with https://review.openstack.org/#/c/34717207:20
rakhmerovthey significantly improve Mistral performance07:20
rakhmerovespecially the second one with caching07:21
*** tonytan4ever has joined #openstack-mistral07:27
*** tonytan4ever has quit IRC07:32
*** chlong has quit IRC07:34
ddejarakhmerov: Hi, thank you07:57
rakhmerovddeja: you're welcome )07:57
ddejarakhmerov: I have 1 hour meeting starting in a minute, but then I will add docs and look on changes07:57
rakhmerovddeja: sure Dawid, no problem07:58
rakhmerovbtw, yes, you were supposed to be in that list with other folks, it's just a habbit :)07:58
rakhmerovI'll get rid of it07:58
*** achanda_ has joined #openstack-mistral08:05
*** achanda has quit IRC08:07
*** shardy has joined #openstack-mistral08:11
*** achanda_ has quit IRC08:52
*** nmakhotkin has joined #openstack-mistral09:04
*** vishwanathj has quit IRC09:22
*** hparekh has quit IRC09:24
*** tonytan4ever has joined #openstack-mistral09:28
*** tonytan4ever has quit IRC09:33
*** hparekh has joined #openstack-mistral09:37
openstackgerritprince_katiyar proposed openstack/python-mistralclient: Add error message when OS_USERNAME or OS_PASSWORD not provided  https://review.openstack.org/34814209:49
*** achanda has joined #openstack-mistral09:52
*** achanda has quit IRC09:58
openstackgerrithardik proposed openstack/mistral: Added support for SSL connection in mistra-api server  https://review.openstack.org/34459809:59
*** toddjohn has joined #openstack-mistral10:00
*** toddjohn has quit IRC10:04
openstackgerritRenat Akhmerov proposed openstack/mistral: Invalidate workflow spec cache on workflow definition updates  https://review.openstack.org/34882810:26
openstackgerritRenat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing  https://review.openstack.org/34775810:26
openstackgerritRenat Akhmerov proposed openstack/mistral: Splitting executions into different tables  https://review.openstack.org/34717210:26
openstackgerritRenat Akhmerov proposed openstack/mistral: Add 'unique_key' parameter for scheduling delayed calls  https://review.openstack.org/34944510:26
openstackgerritDawid Deja proposed openstack/mistral: Update docs and add release not for safe-rerun flag  https://review.openstack.org/34944910:41
jtomasekhi, I have a question on action-execution error handling. for example here: https://review.openstack.org/#/c/348537/1/tripleo_common/actions/heat_capabilities.py10:50
jtomasekthere is an action which in case of exception returns a Result (line 61)10:50
jtomasekdata=None, error=err_mgs10:51
jtomasekis it somehow possible to make the response use different http code then 200? The problem is, that it is hard to distinguish whether the response is error or not, because both responses look the same, just the contents of 'output/result' is different10:53
jtomasekrbrady: ^10:53
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues  https://review.openstack.org/34945711:18
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues  https://review.openstack.org/34945711:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: Add 'unique_key' for delayed calls  https://review.openstack.org/34944511:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Splitting executions into different tables  https://review.openstack.org/34717211:37
*** dprince has joined #openstack-mistral11:38
*** zhenguo has quit IRC11:51
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller  https://review.openstack.org/34946611:52
*** achanda has joined #openstack-mistral11:56
ddejajtomasek: Hi, I'm afraid it is not possible11:59
jtomasekddeja: ok, I am wondering what is the difference between 'data' and 'error' in https://github.com/openstack/mistral/blob/master/mistral/workflow/utils.py#L2312:00
ddejaHTTP code says 200 means that mistral API respond correctly, it should not depend on what are the body of the message12:00
ddejajtomasek: some action returns some 'data', so this is what is stored in self.data12:01
jtomasekddeja: both seem to end up in 'output/result'12:01
*** achanda has quit IRC12:01
ddejajtomasek: basically it is used internaly by mistral engine12:01
ddejato determine how given execution edned12:01
jtomasekddeja: yeah, so workflow is able to figure out if the action execution ended up as success or error12:02
ddejaexactly12:02
jtomasekddeja: but in case when action-execution is called direcly via mistral api call (without being part of the workflow) it would be nice if the api call returned 200 for success and some error http code for error12:03
*** Ravikiran_K has joined #openstack-mistral12:03
ddejajtomasek: oooh, I didn't understand the full context12:03
ddejano I see what you mean12:03
jtomasekddeja: http://docs.openstack.org/developer/mistral/developer/webapi/v2.html#post--v2-action_executions12:04
openstackgerrithardik proposed openstack/mistral: Added releasenote for https support  https://review.openstack.org/34947412:04
ddejajtomasek: hm, from what I know it is not possible to change the HTTP code of direct action call right now12:06
ddejarakhmerov: ^^12:06
jtomasekddeja: the change might be relatively simple - add http code as another parameter to Result12:08
jtomasek(or make it part of error)12:08
jtomasekor mistral could set some error httpd code on the response if there was error parameter specified12:09
ddejajtomasek: agree. I'm just saying that it is not currently possible12:09
jtomasekyep, thanks!12:10
ddejabut I'm not sure if and how it can be set12:10
ddejaI can talk about it on a mistral meeting today ^^12:11
ddejajtomasek: ^^12:11
jtomasekddeja: that would be great12:11
ddejajtomasek: or if you want you can do it by yourself: https://wiki.openstack.org/wiki/Meetings/MistralAgenda12:12
jtomasekddeja: ok, I will12:14
ddejajtomasek: cool :)12:15
*** toddjohn has joined #openstack-mistral12:41
*** bobh has joined #openstack-mistral13:09
*** tonytan4ever has joined #openstack-mistral13:15
*** tonytan4ever has quit IRC13:19
*** bobh has quit IRC13:32
*** tonytan4ever has joined #openstack-mistral13:34
*** tonytan_brb has joined #openstack-mistral13:39
*** tonytan4ever has quit IRC13:41
nmakhotkinjtomasek, let me try to answer why it is happenning so13:49
nmakhotkinhi13:49
nmakhotkinIMO from mistral point all is right because:13:50
nmakhotkin1. Mistral api receives request correctly and passes it further to engine (to launch action)13:51
nmakhotkin2. 200 ok code means that Mistral just correctly executed action but this action returned an error13:52
nmakhotkinOtherwise, if 400 code were sended, that would mean that something wrong with request itself (e.g. wrong action or it's parameters) or maybe something wrong on server side (but in this case mistral returns 5xx)13:54
jtomaseknmakhotkin: yeah, this makes sense, but the flaw is that client is not able to identify if the action returned an error :/ It would be nice if the action could optionally set the httpd code for the response13:57
*** achanda has joined #openstack-mistral13:59
nmakhotkinjtomasek, hmmm13:59
nmakhotkinI got13:59
nmakhotkinmaybe mistral could send different fields in the answer (say, 'error' instead of 'result')14:03
jtomaseknmakhotkin: we'll probably have to examine the response on the client and make a decision if the response is error or not based on the contents of output/result14:03
jtomaseknmakhotkin: yes, that could work14:03
jtomaseknmakhotkin: that would even make sense, since the Result basically lets user do this (it has data and error parameters)14:04
*** kozhukalov has quit IRC14:04
*** kong has quit IRC14:04
*** bobh has joined #openstack-mistral14:04
jtomaseknmakhotkin: hmm, but problem might be that both can be present at the same time (data and error)14:04
nmakhotkinyup14:05
openstackgerritAndras Kovi proposed openstack/mistral: Add target parameters to REST API  https://review.openstack.org/33934914:05
*** achanda has quit IRC14:05
jtomaseknmakhotkin: so probably appending error to output.result? or put it in addition (output.error)14:05
nmakhotkinthen I suggest setting a state of this action execution on server-side14:05
nmakhotkinand then we can see state along with result14:06
nmakhotkinsuccess or error14:06
jtomaseknmakhotkin: I see14:06
*** bobh has quit IRC14:07
jtomaseknmakhotkin: this is an example response from such action http://paste.openstack.org/show/545045/14:08
jtomaseknmakhotkin: the state is null, how is it possible to set it?14:09
jtomaseknmakhotkin: note that action that is run directly as an action-execution does not get persisted14:10
*** tonytan4ever has joined #openstack-mistral14:14
*** tonytan_brb has quit IRC14:17
*** kong has joined #openstack-mistral14:18
*** kozhukalov has joined #openstack-mistral14:18
*** chlong has joined #openstack-mistral14:26
*** chlong is now known as chlong|gone14:27
*** chlong|gone has quit IRC14:32
*** chlong|gone has joined #openstack-mistral14:33
*** chlong|gone is now known as chlong14:34
nmakhotkinjtomasek: currently it is not possible yet14:36
nmakhotkinbut one simple change to Mistral will make it possible :)14:37
*** tonytan4ever has quit IRC14:38
jtomaseknmakhotkin: cool14:38
*** janki has quit IRC14:43
*** tonytan4ever has joined #openstack-mistral14:44
*** vishwanathj has joined #openstack-mistral14:46
*** clenimar has quit IRC14:49
*** clenimar has joined #openstack-mistral14:51
*** tonytan_brb has joined #openstack-mistral14:51
*** tonytan4ever has quit IRC14:54
*** rrecio has joined #openstack-mistral14:55
*** bobh has joined #openstack-mistral14:58
*** jistr is now known as jistr|call15:00
*** nmakhotkin has quit IRC15:02
*** dprince has quit IRC15:10
*** jistr|call is now known as jistr15:12
*** clenimar has quit IRC15:13
*** clenimar has joined #openstack-mistral15:30
*** bobh_ has joined #openstack-mistral15:32
*** bobh has quit IRC15:32
*** toddjohn has quit IRC15:36
*** toddjohn has joined #openstack-mistral15:36
*** venkat has joined #openstack-mistral15:51
*** venkat has quit IRC15:55
*** jistr is now known as jistr|biab16:01
*** achanda has joined #openstack-mistral16:03
*** achanda has quit IRC16:08
*** dprince has joined #openstack-mistral16:33
*** jistr|biab is now known as jistr16:49
*** clenimar has quit IRC17:03
*** achanda has joined #openstack-mistral17:06
*** achanda has quit IRC17:10
*** achanda has joined #openstack-mistral17:11
*** achanda has quit IRC17:11
*** achanda has joined #openstack-mistral17:12
*** bobh_ has quit IRC17:20
*** clenimar has joined #openstack-mistral17:21
openstackgerritRenat Akhmerov proposed openstack/mistral: Invalidate workflow spec cache on workflow definition updates  https://review.openstack.org/34882817:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller  https://review.openstack.org/34946617:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing  https://review.openstack.org/34775817:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: fix obvious workflow controller issues  https://review.openstack.org/34945717:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Towards non-locking model: Add 'unique_key' for delayed calls  https://review.openstack.org/34944517:23
openstackgerritRenat Akhmerov proposed openstack/mistral: Splitting executions into different tables  https://review.openstack.org/34717217:23
rakhmerovddeja: I addressed your comments in my patch for splitting into different tables17:24
*** Ravikiran_K has quit IRC17:31
*** bobh has joined #openstack-mistral18:21
*** bobh has quit IRC18:26
*** bobh has joined #openstack-mistral18:35
*** harlowja has quit IRC19:14
*** harlowja has joined #openstack-mistral19:15
*** achanda has quit IRC19:19
*** shardy has quit IRC19:56
openstackgerritWinson Chan proposed openstack/mistral: Implement workflow composers  https://review.openstack.org/34861420:48
openstackgerritWinson Chan proposed openstack/mistral: Add utility functions in workflow spec for graphing  https://review.openstack.org/34861320:48
openstackgerritWinson Chan proposed openstack/mistral: Implements WorkflowGraph for graphing tasks and transitions  https://review.openstack.org/34861220:48
openstackgerritWinson Chan proposed openstack/mistral: Add sample workflow conductor to test task sequences  https://review.openstack.org/34969520:48
*** dprince has quit IRC20:50
openstackgerritDougal Matthews proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows  https://review.openstack.org/33769620:52
*** toddjohn has quit IRC21:13
*** stevebaker has joined #openstack-mistral21:34
*** tonytan4ever has joined #openstack-mistral21:54
*** tonytan_brb has quit IRC21:57
*** toddjohn has joined #openstack-mistral22:14
*** bobh has quit IRC22:14
*** toddjohn has quit IRC22:18
*** toddjohn has joined #openstack-mistral22:30
*** toddjohn has quit IRC22:53
*** tonytan4ever has quit IRC23:07
*** achanda has joined #openstack-mistral23:16
*** achanda has quit IRC23:32
*** toddjohn has joined #openstack-mistral23:42
openstackgerritMerged openstack/mistral: Add cancelled state to executions  https://review.openstack.org/34628123:44
*** toddjohn has quit IRC23:55
*** rrecio has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!