| *** brian_price has quit IRC | 00:07 | |
| *** jistr has quit IRC | 00:27 | |
| *** tonytan4ever has quit IRC | 00:28 | |
| *** gyee has quit IRC | 00:28 | |
| *** jistr has joined #openstack-mistral | 00:30 | |
| *** Ephur has joined #openstack-mistral | 00:46 | |
| *** cheneydc has joined #openstack-mistral | 01:05 | |
| *** chlong has joined #openstack-mistral | 01:18 | |
| *** Ephur has quit IRC | 01:29 | |
| *** tonytan4ever has joined #openstack-mistral | 01:35 | |
| *** tonytan4ever has quit IRC | 01:40 | |
| *** cheneydc has quit IRC | 02:04 | |
| *** rakhmerov has quit IRC | 02:55 | |
| *** rakhmerov has joined #openstack-mistral | 03:04 | |
| *** chlong has quit IRC | 03:37 | |
| *** chlong has joined #openstack-mistral | 04:10 | |
| *** janki has joined #openstack-mistral | 04:20 | |
| *** achatterjee has joined #openstack-mistral | 04:22 | |
| *** jaosorior has joined #openstack-mistral | 04:46 | |
| *** tonytan4ever has joined #openstack-mistral | 04:52 | |
| *** tonytan4ever has quit IRC | 04:57 | |
| *** chlong has quit IRC | 05:21 | |
| jaosorior | Hey guys | 06:00 |
|---|---|---|
| jaosorior | anybody around yet? | 06:00 |
| *** evgenyl has quit IRC | 06:20 | |
| *** evgenyl has joined #openstack-mistral | 06:22 | |
| *** shardy has joined #openstack-mistral | 06:23 | |
| *** vishwanathj has joined #openstack-mistral | 06:43 | |
| *** jaosorior is now known as jaosorior_brb | 07:22 | |
| *** jpich has joined #openstack-mistral | 07:47 | |
| *** mflobo has joined #openstack-mistral | 07:59 | |
| mflobo | Good morning | 08:00 |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #openstack-mistral | 08:18 | |
| jtomasek | d0ugal or anyone: Hi, do you know how to make the workflow into ERROR state? | 08:23 |
| jtomasek | d0ugal: in run_validation workflow here https://review.openstack.org/#/c/353899/5/workbooks/validations.yaml we need to make the workflow exection state ERROR when the validation fails | 08:24 |
| ddeja | jtomasek: Hi, you can use std.fail | 08:25 |
| d0ugal | jtomasek: Isn't it more important for the messages to say failed? Why does it matter about the status of the workflow? | 08:26 |
| jtomasek | d0ugal: because of this: https://review.openstack.org/#/c/352207/1/mistral/api/controllers/v2/execution.py | 08:26 |
| jtomasek | d0ugal: list of executions doesn't include the 'output' any more | 08:26 |
| jtomasek | :/ | 08:26 |
| jtomasek | d0ugal: so when we have a list of validations executions, we need to figure out it's status. only possibility now is to use workflow state to track it | 08:27 |
| jtomasek | d0ugal: otherwise we'd have to make a separate request for every validation execution to get the output included in the list | 08:28 |
| d0ugal | jtomasek: hmm, is this just for workflows rather than action executions? or do you have the same problem there | 08:28 |
| d0ugal | jtomasek: I ask because some action executions fail intentionally :) | 08:29 |
| d0ugal | jtomasek: but yeah, otherwise calling the std.fail action would do the job | 08:29 |
| jtomasek | d0ugal: not sure about action executions, but validations use workflows, running a validation is a workflow, so we need to get a result of validation through workflow exectuions | 08:30 |
| d0ugal | right | 08:30 |
| d0ugal | jtomasek: I am not sure how we fit std.fail into that workflow tho' - looking. | 08:31 |
| jtomasek | yeah, an example would be nice | 08:31 |
| d0ugal | jtomasek: Myabe this: on-complete: [send_message, std.fail] | 08:31 |
| d0ugal | jtomasek: I need to test it tho' | 08:31 |
| d0ugal | jtomasek: That would be on line 39 | 08:31 |
| d0ugal | jtomasek: Testing, give me a few mins. | 08:32 |
| jtomasek | d0ugal, ddeja: thanks! | 08:32 |
| jtomasek | that action should also provide a way to set state_info, right, we could make use of that too | 08:32 |
| d0ugal | jtomasek: hmm, maybe - I'll look into that too :) | 08:33 |
| d0ugal | jtomasek: okay, that isn't correct. I think it will be a bit more complicated. | 08:35 |
| d0ugal | I really wish tast inheritance was a thing... :) | 08:36 |
| d0ugal | We end up duplicating tons | 08:36 |
| *** vishwanathj has quit IRC | 08:36 | |
| *** vishwanathj has joined #openstack-mistral | 08:37 | |
| jtomasek | d0ugal: so in general, we need to make the workflow work exactly as it does now, just to set it's state to something different then SUCCESS:) | 08:38 |
| d0ugal | jtomasek: Yup, got an example for ya | 08:38 |
| d0ugal | jtomasek: on-success calls tasks in the workflow, not actions. | 08:39 |
| *** mandre has joined #openstack-mistral | 08:39 | |
| d0ugal | jtomasek: so you need to create a task for it to call the std.fail action | 08:39 |
| d0ugal | jtomasek: like this: http://paste.openstack.org/show/563815/ | 08:39 |
| jtomasek | I see | 08:39 |
| d0ugal | jtomasek: (I just used another workflow I had handy - so that diff wont match up) | 08:39 |
| d0ugal | jtomasek: This is why inheritance would be nice, we could end up with a fail task on every workflow eventually :/ | 08:40 |
| d0ugal | (that and the Zaqar task we copy-pasta everywhere) | 08:40 |
| jtomasek | yeah | 08:40 |
| jtomasek | d0ugal: can I use it like this? http://paste.openstack.org/show/563816/ | 08:42 |
| d0ugal | jtomasek: Line 15? Yeah, that looks good. | 08:44 |
| jtomasek | d0ugal: ok, thanks, I'll give it a try | 08:44 |
| d0ugal | hrm, std.fail isn't in the docs - I'll have to add that. | 08:44 |
| d0ugal | jtomasek: Let me know if you have any issues | 08:45 |
| d0ugal | jtomasek: What did you mean before about state_info btw? | 08:46 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Add a note to the documentation about std.fail https://review.openstack.org/360987 | 08:50 |
| *** tonytan4ever has joined #openstack-mistral | 08:54 | |
| jtomasek | d0ugal: each execution has state_info http://docs.openstack.org/developer/mistral/developer/webapi/v2.html#get--v2-executions this is used to provide explanation on why execution failed | 08:55 |
| *** vishwanathj has quit IRC | 08:56 | |
| *** vishwanathj has joined #openstack-mistral | 08:57 | |
| *** tonytan4ever has quit IRC | 08:58 | |
| *** jaosorior_brb is now known as jaosorior | 08:59 | |
| d0ugal | jtomasek: ah, I don't know how to set that. | 09:00 |
| d0ugal | jtomasek: with std.fail I suspect you might get this message which isn't that useful https://github.com/openstack/mistral/blob/master/mistral/actions/std_actions.py#L96 | 09:01 |
| brunograz_ | Hi ddeja, i have a workaround for this issue which worked for us. Here at this line we put a condition verifying if "is_trust_scoped" is in the auth context. If so we create a new admin client using the credentials in the configuration file and execute the method get_token_data | 09:02 |
| brunograz_ | https://github.com/icclab/mistral/blob/master/mistral/utils/openstack/keystone.py#L74 | 09:02 |
| d0ugal | jtomasek: Maybe we need to create a tripleo.fail that does a bit more. | 09:02 |
| brunograz_ | it will look like - cli = client_for_admin(CONF.keystone_authtoken.admin_user).tokens.get_token_data(token, include_catalog=True) | 09:02 |
| ddeja | brunograz_: oooh I see | 09:03 |
| ddeja | oh, I think I know how to fix it properly | 09:03 |
| ddeja | let my try it | 09:04 |
| jtomasek | d0ugal: hmm, the solution does not work, because the output does not get through. -> the output of workflow execution which is state ERROR is { result: null } | 09:04 |
| jtomasek | d0ugal: this is not good:/ | 09:06 |
| d0ugal | jtomasek: damn. So I guess the run_validation action needs to do it | 09:06 |
| jtomasek | d0ugal: any idea how?:) | 09:07 |
| d0ugal | jtomasek: They can fail the workflow with a message, we do that here already: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/baremetal.py#L57-L6 | 09:07 |
| * janki is away: will be back | 09:07 | |
| * janki is back (gone 00:00:13) | 09:08 | |
| jtomasek | d0ugal: I wonder if the result is the same... when workflow fails, then it's execution won't store any output | 09:09 |
| d0ugal | jtomasek: hmm, I'm not sure. | 09:10 |
| jtomasek | d0ugal: hm, as I think about it, it would be preferable if the workflow succeeded. As the workflow actually succeeds to run but the validation fails. which is fine from the workflow standpoint | 09:11 |
| d0ugal | heh, yeah, that confused me initially :) | 09:11 |
| jtomasek | d0ugal: and we might use state_info to carry the validation result status | 09:11 |
| jtomasek | to resolve the problem of not having the 'output' available | 09:11 |
| d0ugal | Right | 09:12 |
| jtomasek | if we know how to set the state_info | 09:12 |
| d0ugal | jtomasek: I don't know :-D | 09:12 |
| ddeja | brunograz_: are you aware, that this workaround is a security issue? All of the user can perform their actions as mistral user | 09:16 |
| brunograz_ | ddeja: I was not aware of that, I will paste the snippet with the changes I did so you can have a look. | 09:19 |
| brunograz_ | ddeja: here you go - http://pastebin.com/7wdWSNL9 | 09:20 |
| jtomasek | rakhmerov: Hi, is it possible to set the execution state_info from the workflow or it's action? | 09:21 |
| ddeja | brunograz_: with this change all of the actions will be run as mistral user | 09:21 |
| ddeja | with it's permissions | 09:22 |
| ddeja | and they should be run as a user that created the trigger | 09:23 |
| brunograz_ | ddeja: correct if I'm wrong but this method is only returning endpoints and not a client or credentials. | 09:24 |
| *** mflobo has quit IRC | 09:24 | |
| brunograz_ | ddeja: the client is created in the class who called this method - in my case NovaActions in action/opentack/actions.py | 09:25 |
| ddeja | wait a second.. | 09:26 |
| brunograz_ | ddeja: link - https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/actions.py#L61 | 09:26 |
| ddeja | brunograz_: well, OK, it is only for getting the endpoint | 09:30 |
| ddeja | so it shouldn't be a problem | 09:31 |
| brunograz_ | ddeja: that's cool :) - I'm not sure of mistral internals so wanted to make sure that this workaround is not affecting anything else. | 09:35 |
| ddeja | brunograz_: I'm not 100% sure if it's not affecting anything else, but from a quick look into the code it does not | 09:36 |
| ddeja | I've just asked on the keystone channgel how to use trust properly, so that I can fix it | 09:36 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Add a note to the documentation about std.fail https://review.openstack.org/360987 | 09:45 |
| *** brunograz_ has quit IRC | 09:48 | |
| *** brunograz has joined #openstack-mistral | 09:48 | |
| *** vishwanathj has quit IRC | 10:06 | |
| *** vishwanathj has joined #openstack-mistral | 10:07 | |
| openstackgerrit | Shaik Apsar proposed openstack/mistral: Fix for 'Cannot authenticate without an auth_url' https://review.openstack.org/361069 | 10:37 |
| *** janki has quit IRC | 10:43 | |
| *** janki has joined #openstack-mistral | 10:44 | |
| *** vishwanathj has quit IRC | 10:53 | |
| *** vishwanathj has joined #openstack-mistral | 10:54 | |
| *** shardy is now known as shardy_lunch | 11:13 | |
| openstackgerrit | Shaik Apsar proposed openstack/mistral: Fix for 'Cannot authenticate without an auth_url' https://review.openstack.org/361069 | 11:27 |
| *** nmakhotkin has joined #openstack-mistral | 11:32 | |
| *** vishwanathj has quit IRC | 11:48 | |
| *** vishwanathj has joined #openstack-mistral | 11:49 | |
| *** jaosorior has quit IRC | 11:53 | |
| *** jaosorior has joined #openstack-mistral | 11:54 | |
| *** tonytan4ever has joined #openstack-mistral | 11:55 | |
| *** tonytan4ever has quit IRC | 12:00 | |
| openstackgerrit | Shaik Apsar proposed openstack/mistral: Fix for 'Cannot authenticate without an auth_url' https://review.openstack.org/361069 | 12:05 |
| *** tonytan4ever has joined #openstack-mistral | 12:09 | |
| *** shardy_lunch is now known as shardy | 12:11 | |
| *** mflobo has joined #openstack-mistral | 12:12 | |
| *** dprince has joined #openstack-mistral | 12:23 | |
| jtomasek | d0ugal: I've been digging into state_info a bit. Here is the workflow state handling https://github.com/openstack/mistral/blob/4bdda3b6eddb2aae0b939b493d94b46f5060b423/mistral/engine/workflows.py#L301 | 12:43 |
| jtomasek | d0ugal: set_state function sets the state and state_info | 12:44 |
| jtomasek | d0ugal: it sets state_info to msg, I think we just need to figure out where the msg is coming from | 12:44 |
| jtomasek | d0ugal: https://github.com/openstack/mistral/blob/4bdda3b6eddb2aae0b939b493d94b46f5060b423/mistral/engine/workflows.py#L297 | 12:45 |
| *** janki has quit IRC | 12:50 | |
| d0ugal | jtomasek: Sorry, will get back to you about this shortly | 13:07 |
| d0ugal | jtomasek: Juggling conversations. | 13:07 |
| jtomasek | d0ugal: hm, so no message is passed when _succeed_workflow is called, so state_info can't get set when workflow succeeds... | 13:26 |
| d0ugal | jtomasek: it is when it is called here: https://github.com/openstack/mistral/blob/4bdda3b6eddb2aae0b939b493d94b46f5060b423/mistral/engine/workflows.py#L112 | 13:32 |
| d0ugal | jtomasek: so stop seems to do what you want, but I have no idea where you can call that from? | 13:33 |
| jtomasek | d0ugal: https://github.com/openstack/mistral/blob/641232feb288dd06b34257bdc52d3807771d847c/mistral/api/controllers/v2/execution.py#L149 | 13:41 |
| jtomasek | d0ugal: it is used to stop or cancel workflow execution via api call | 13:42 |
| jtomasek | d0ugal: only viable solution seems to me to add optional parameter to executions listing api call which will include output for each execution | 13:43 |
| d0ugal | jtomasek: Do you have the link to the patch that removed it handy? | 13:43 |
| jtomasek | d0ugal: this one actually adds it to get execution https://review.openstack.org/#/c/352207/1/mistral/api/controllers/v2/execution.py | 13:44 |
| *** nmakhotkin has quit IRC | 13:44 | |
| jtomasek | d0ugal: https://review.openstack.org/#/c/350183/ or https://review.openstack.org/#/c/347172/ | 13:45 |
| jtomasek | ? | 13:45 |
| d0ugal | jtomasek: hmm, okay. | 13:50 |
| d0ugal | jtomasek: trying to figure out what I can do here to help | 13:50 |
| jtomasek | d0ugal: thanks | 13:50 |
| d0ugal | jtomasek: Which API endpoint is missing it? | 13:50 |
| jtomasek | GET v2/executions | 13:50 |
| d0ugal | jtomasek: I can look into putting a patch together next week - not sure how that fits in with deadlines etc. | 13:50 |
| d0ugal | jtomasek: ah, I see - so that one adds it to individual, you want it for them all. | 13:51 |
| jtomasek | d0ugal: this is something that would not affect tripleo-common, it is called directly by GUI | 13:51 |
| jtomasek | d0ugal: yes | 13:51 |
| jtomasek | d0ugal: oh, we would have to update mistral package though probably, but anyway having it sooner is much better than delaying it | 13:52 |
| d0ugal | jtomasek: Okay, I can manage that I think. Not totally sure it will be wanted, but we shall see :) | 13:52 |
| jtomasek | d0ugal: it should be probably parametrized, such as when some parameters is sent with GET v2/executions, then include output. otherwise not | 13:53 |
| d0ugal | jtomasek: yup, makes sense. | 13:53 |
| d0ugal | jtomasek: would you mind making a mistral bug and sending me the link? | 14:02 |
| d0ugal | or just assign it to me | 14:02 |
| jtomasek | d0ugal: ok | 14:03 |
| *** janki has joined #openstack-mistral | 14:09 | |
| *** mflobo has quit IRC | 14:14 | |
| *** szaher has quit IRC | 14:28 | |
| jtomasek | d0ugal: https://bugs.launchpad.net/mistral/+bug/1617351 | 14:30 |
| openstack | Launchpad bug 1617351 in Mistral "No output in executions listing" [Undecided,New] | 14:30 |
| *** dprince has quit IRC | 14:30 | |
| d0ugal | jtomasek: Great, thanks. | 14:30 |
| *** dprince has joined #openstack-mistral | 14:31 | |
| *** chlong has joined #openstack-mistral | 14:32 | |
| openstackgerrit | Andreas Jaeger proposed openstack/mistral-lib: Cleanup tox.ini, enable constraints https://review.openstack.org/361265 | 14:48 |
| *** mflobo has joined #openstack-mistral | 14:56 | |
| *** rrecio has joined #openstack-mistral | 14:57 | |
| *** rrecio_ has joined #openstack-mistral | 14:58 | |
| *** tonytan4ever has quit IRC | 15:01 | |
| *** jistr is now known as jistr|call | 15:01 | |
| *** rrecio has quit IRC | 15:01 | |
| *** tonytan4ever has joined #openstack-mistral | 15:01 | |
| *** dprince has quit IRC | 15:07 | |
| *** dprince has joined #openstack-mistral | 15:07 | |
| *** dprince has quit IRC | 15:08 | |
| *** dprince has joined #openstack-mistral | 15:08 | |
| *** brian_price has joined #openstack-mistral | 15:09 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable changing of rpc driver from devstack https://review.openstack.org/361287 | 15:09 |
| *** jistr|call is now known as jistr | 15:12 | |
| ddeja | kong, akuznetsova, rakhmerov - I propose adding a new gate for devstack that would test the kombu driver, take a look https://review.openstack.org/#/c/361307/ | 15:27 |
| *** mflobo has quit IRC | 15:27 | |
| *** mflobo has joined #openstack-mistral | 15:41 | |
| *** jaosorior has quit IRC | 15:58 | |
| *** chlong has quit IRC | 16:07 | |
| *** mflobo has quit IRC | 16:18 | |
| *** chlong has joined #openstack-mistral | 16:19 | |
| *** jpich has quit IRC | 16:40 | |
| *** chlong has quit IRC | 17:02 | |
| *** janki has quit IRC | 17:34 | |
| *** vishwanathj has quit IRC | 17:38 | |
| *** vishwanathj has joined #openstack-mistral | 17:39 | |
| *** rrecio_ has quit IRC | 18:02 | |
| *** rrecio has joined #openstack-mistral | 18:05 | |
| *** rbrady has quit IRC | 18:12 | |
| *** rbrady has joined #openstack-mistral | 18:12 | |
| *** rbrady has quit IRC | 18:18 | |
| *** rbrady has joined #openstack-mistral | 18:19 | |
| *** dprince has quit IRC | 18:26 | |
| *** shardy has quit IRC | 18:33 | |
| *** brian_price has quit IRC | 18:56 | |
| *** vishwanathj has quit IRC | 18:56 | |
| *** vishwanathj has joined #openstack-mistral | 18:57 | |
| *** Ephur has joined #openstack-mistral | 19:07 | |
| *** vishwanathj has quit IRC | 19:34 | |
| *** vishwanathj has joined #openstack-mistral | 19:35 | |
| *** mflobo has joined #openstack-mistral | 19:37 | |
| *** vishwanathj has quit IRC | 19:37 | |
| *** vishwanathj has joined #openstack-mistral | 19:38 | |
| *** mflobo has left #openstack-mistral | 19:41 | |
| *** dprince has joined #openstack-mistral | 19:43 | |
| *** tonytan_brb has joined #openstack-mistral | 20:13 | |
| *** tonytan4ever has quit IRC | 20:16 | |
| *** dprince has quit IRC | 20:57 | |
| *** clenimar has quit IRC | 21:01 | |
| *** vishwanathj has quit IRC | 21:22 | |
| *** vishwanathj has joined #openstack-mistral | 21:23 | |
| *** Ephur has quit IRC | 21:26 | |
| *** vishwanathj has quit IRC | 21:48 | |
| *** vishwanathj has joined #openstack-mistral | 21:49 | |
| *** vishwanathj has quit IRC | 22:14 | |
| *** vishwanathj has joined #openstack-mistral | 22:15 | |
| *** vishwanathj has quit IRC | 22:22 | |
| *** vishwanathj has joined #openstack-mistral | 22:23 | |
| *** vishwanathj has quit IRC | 22:35 | |
| *** vishwanathj has joined #openstack-mistral | 22:36 | |
| *** rrecio has quit IRC | 22:42 | |
| *** rrecio has joined #openstack-mistral | 22:58 | |
| *** rrecio has quit IRC | 23:09 | |
| *** vishwanathj has quit IRC | 23:40 | |
| *** vishwanathj has joined #openstack-mistral | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!