| *** bobh has joined #openstack-mistral | 00:19 | |
| *** vishwanathj has quit IRC | 00:43 | |
| *** rrecio_ has quit IRC | 02:55 | |
| *** rrecio has joined #openstack-mistral | 02:56 | |
| *** bobh has quit IRC | 03:00 | |
| *** hparekh has joined #openstack-mistral | 03:51 | |
| *** sharatss has joined #openstack-mistral | 04:26 | |
| *** jaosorior has joined #openstack-mistral | 04:47 | |
| *** jaosorior has quit IRC | 05:01 | |
| *** jaosorior has joined #openstack-mistral | 05:02 | |
| openstackgerrit | Hardik Parekh proposed openstack/mistral: Added unit tests for Workbook and Workflow filtering https://review.openstack.org/367272 | 05:12 |
|---|---|---|
| *** vishwanathj has joined #openstack-mistral | 05:47 | |
| *** jtomasek has joined #openstack-mistral | 06:12 | |
| *** janki has joined #openstack-mistral | 06:17 | |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/mistral-dashboard: Clean imports in code https://review.openstack.org/370561 | 06:50 |
| *** Ravikiran_K has joined #openstack-mistral | 07:13 | |
| *** shardy has joined #openstack-mistral | 07:20 | |
| *** nmakhotkin has joined #openstack-mistral | 07:33 | |
| *** jpich has joined #openstack-mistral | 07:36 | |
| openstackgerrit | Merged openstack/mistral-dashboard: Clean imports in code https://review.openstack.org/370561 | 07:40 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Revert "Change execution mechanism for 'join' tasks" https://review.openstack.org/370595 | 08:01 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Revert "Change execution mechanism for 'join' tasks" https://review.openstack.org/370595 | 08:07 |
| *** Ravikiran_K has quit IRC | 08:17 | |
| *** sharatss has quit IRC | 08:41 | |
| rakhmerov | d0ugal: hi | 08:49 |
| rakhmerov | what's the reason for https://review.openstack.org/#/c/370595? | 08:49 |
| rakhmerov | I'm moving forward with this whole thing now and it would be kind of frustrating to merge this patch, it's completely not aligned with my plans | 08:50 |
| d0ugal | rakhmerov: Hey, sure, I don't expect it to land | 08:51 |
| rakhmerov | :) | 08:51 |
| d0ugal | rakhmerov: all of tripleo CI is still totally broken, so we are testing all sorts to try and track down the issue | 08:51 |
| d0ugal | rakhmerov: by proposing patches we can have CI test against them | 08:51 |
| rakhmerov | Oooh, I see | 08:51 |
| d0ugal | Somebody suggested that patch might be an issue, I don't know but we are trying anything at this point | 08:51 |
| rakhmerov | sorry for that, I'm still working hard on it | 08:52 |
| d0ugal | rakhmerov: Sure, no problem! | 08:52 |
| rakhmerov | with my last changes it works much much better already | 08:52 |
| d0ugal | rakhmerov: We don't even know if it is mistral - I am trying reverts and patches in many repos :) | 08:52 |
| rakhmerov | several times faster etc | 08:52 |
| rakhmerov | yeah, sure, no problem | 08:52 |
| rakhmerov | please leave some comments in the commit messages so that people don't merge it by mistake :) | 08:53 |
| rakhmerov | btw, are you trying to use multiple Mistral engines or just one for now? | 08:53 |
| d0ugal | rakhmerov: Okay, will do - that is why I made it workflow-1, but I'll make it very obvious next time | 08:53 |
| rakhmerov | ok, thanks | 08:53 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: DO NOT MERGE. TESTING TRIPLEO CI https://review.openstack.org/370595 | 08:54 |
| d0ugal | Sorry for the extra noise :) | 08:54 |
| openstackgerrit | Merged openstack/mistral: Fix for raising exception directly to kombu https://review.openstack.org/355964 | 08:57 |
| ddeja | d0ugal: hi, I'm looking on your problem too double checking if mistral works correctly | 08:58 |
| d0ugal | ddeja: Thanks, I think generally it does | 08:59 |
| ddeja | and I've noticed that debug log level are turned of, could you switch it on? | 08:59 |
| d0ugal | we are only able to reproduce it in one place, but we don't know why yet. | 08:59 |
| d0ugal | hrm, good question. I'll ask. | 08:59 |
| ddeja | oh, so you think it is not mistral problem? | 08:59 |
| d0ugal | ddeja: We have no idea. It might be, it might not | 09:00 |
| d0ugal | if it is a Mistral problem it is surely an edge case :) | 09:00 |
| d0ugal | Since it fails consistently in one of our gates, but not the others. | 09:00 |
| d0ugal | The only error we have comes from Mistral. | 09:00 |
| *** hparekh has quit IRC | 09:01 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: TESTING TRIPLEOCI. DO NOT MERGE. https://review.openstack.org/370595 | 09:06 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: TESTING TRIPLEOCI. DO NOT MERGE. https://review.openstack.org/370595 | 09:06 |
| *** jtomasek has quit IRC | 09:08 | |
| *** jtomasek has joined #openstack-mistral | 09:09 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: DO NOT MERGE, I'M A DINOSAUR https://review.openstack.org/370636 | 09:26 |
| ddeja | d0ugal: could you run your gate job against this patch ^ | 09:27 |
| ddeja | it would help me debug a lot | 09:27 |
| *** hparekh has joined #openstack-mistral | 09:32 | |
| *** hparekh has quit IRC | 09:32 | |
| *** sharatss_ has joined #openstack-mistral | 09:37 | |
| d0ugal | ddeja: Yup, will do. | 09:37 |
| *** sharatss_ has quit IRC | 09:41 | |
| d0ugal | ddeja: This change should do it. https://review.openstack.org/#/c/370648/ | 09:42 |
| d0ugal | ddeja: but it will take some time, I'll let you know. | 09:42 |
| ddeja | ok, thanks | 09:43 |
| ddeja | rakhmerov: why there is no 'newton' branch? Or I just don't see them? | 09:51 |
| rakhmerov | ddeja: there should be | 09:53 |
| rakhmerov | let me check | 09:54 |
| ddeja | I don't see it both on my locacl repo (using branch -a) and on github | 09:54 |
| rakhmerov | ddeja: in fact, I did a very bad job with backporting needed patches into the stable branch | 09:54 |
| rakhmerov | so most of the bug fixes will have to go into RC2 | 09:54 |
| ddeja | ok | 09:54 |
| rakhmerov | or we can simply skip RC1 | 09:54 |
| rakhmerov | I'm too overwhelmed now with internal priorities, I'm planning to start backporting stuff early next week | 09:55 |
| rakhmerov | hm... I actually saw info before that stable/newton was created | 09:56 |
| therve | ddeja, newton branch should be created after RC1 | 09:56 |
| rakhmerov | weird | 09:56 |
| rakhmerov | yes, but usually it's created out of RC1 | 09:56 |
| rakhmerov | right | 09:56 |
| rakhmerov | kong: here? | 09:57 |
| therve | Yep | 10:01 |
| *** hparekh has joined #openstack-mistral | 10:09 | |
| ddeja | therve: OK, thanks | 10:49 |
| ddeja | d0ugal: it looks like all jenkins checkes passed... https://review.openstack.org/#/c/370648/ | 10:52 |
| *** rbrady has joined #openstack-mistral | 10:56 | |
| *** rbrady has joined #openstack-mistral | 10:56 | |
| *** shardy has quit IRC | 10:57 | |
| kong | rakhmerov: hi | 11:04 |
| rakhmerov | ddeja: and what does it mean to us? | 11:04 |
| rakhmerov | kong: hey, how are you? | 11:04 |
| kong | rakhmerov: good and you? | 11:04 |
| rakhmerov | kong: just wanted to ask you if you can handle RC1? Any issues? Anything you expect from me? | 11:04 |
| kong | rakhmerov: yeah, are we ready for rc1? | 11:05 |
| rakhmerov | I'm ok, just too busy ) | 11:05 |
| rakhmerov | kong: yes, I think so, when is the deadline for RC1? Today? | 11:05 |
| d0ugal | ddeja: Damn, I think we might have an issue with CI, it doesn't seem to be pulling in the mistral changes. This is super confusing | 11:05 |
| kong | 15 Sep UTC | 11:05 |
| d0ugal | ddeja: There are even jobs missing :/ | 11:05 |
| kong | I will submit a patch tomorrow morning in NZ time | 11:05 |
| rakhmerov | hm.. | 11:06 |
| rakhmerov | ok! | 11:06 |
| rakhmerov | kong: please do | 11:06 |
| kong | rakhmerov: sorry, I didn't make many contribution this cycle | 11:06 |
| rakhmerov | kong, ddeja, hparekh: can you guys please review https://review.openstack.org/#/c/368871/ and https://review.openstack.org/#/c/369292/ ? | 11:07 |
| rakhmerov | kong: that's no problem | 11:07 |
| rakhmerov | I'm hoping to squeeze my 4 patches into RC1 | 11:07 |
| rakhmerov | they make some HUGE performance improvements | 11:08 |
| kong | I also want to do this one https://review.openstack.org/#/c/336463/ | 11:08 |
| kong | after I fix the issue hardik pointed | 11:08 |
| rakhmerov | it now has -1, have you looked at it? | 11:08 |
| rakhmerov | ok | 11:08 |
| rakhmerov | yes | 11:08 |
| rakhmerov | please do, and ping me to review it, I'll do it asap | 11:09 |
| hparekh | rakhmerov, Ok I will review it | 11:09 |
| rakhmerov | thanks in advance | 11:09 |
| rakhmerov | the first patch I pointed to is actually very simple | 11:10 |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Add functional tests for event engine functions https://review.openstack.org/336463 | 11:11 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add a smarter delay between workflow completion checks https://review.openstack.org/369449 | 11:27 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Remove workflow spec, input and params from workflow context https://review.openstack.org/370105 | 11:27 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Copy cached WF spec stored by definition id into WF execution cache https://review.openstack.org/368871 | 11:27 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Optimize the logic that check if 'join' task is allowed to start https://review.openstack.org/369292 | 11:27 |
| rakhmerov | hparekh, ddeja: guys, I fixed the issue in https://review.openstack.org/#/c/368871/ that you pointed to | 11:28 |
| rakhmerov | please take a look | 11:28 |
| *** janki has quit IRC | 11:30 | |
| *** janki has joined #openstack-mistral | 11:32 | |
| *** janki has quit IRC | 11:39 | |
| ddeja | rakhmerov: reviewing | 11:40 |
| rakhmerov | ok | 11:40 |
| ddeja | rakhmerov: I can +2 +W your first change, but there is a request from hparekh (even though he left +2), I'm not sure what to do with it... | 11:43 |
| rakhmerov | :) | 11:43 |
| rakhmerov | let me do it separately | 11:43 |
| rakhmerov | would it be ok? | 11:43 |
| ddeja | ok | 11:43 |
| rakhmerov | relatively small issue | 11:44 |
| rakhmerov | thanks, I just did it in my current patch I'm working on | 11:44 |
| ddeja | OK | 11:44 |
| hparekh | rakhmerov, yeah It is ok for me in seprate patch:) | 11:44 |
| rakhmerov | thanks, appreciate that (we need these patches badly here) | 11:45 |
| hparekh | rakhmerov, Also if you get the time. please look into https://review.openstack.org/#/c/369834/. I left my comment there. I am not sure how can I add test for it as of now. | 11:47 |
| rakhmerov | hparekh, sure man, today I'll do it | 11:47 |
| *** bobh has joined #openstack-mistral | 12:06 | |
| *** rbrady has quit IRC | 12:08 | |
| openstackgerrit | Merged openstack/mistral: Copy cached WF spec stored by definition id into WF execution cache https://review.openstack.org/368871 | 12:10 |
| openstackgerrit | Merged openstack/mistral: Optimize the logic that check if 'join' task is allowed to start https://review.openstack.org/369292 | 12:10 |
| openstackgerrit | Merged openstack/mistral: Add a smarter delay between workflow completion checks https://review.openstack.org/369449 | 12:10 |
| openstackgerrit | Merged openstack/mistral: Remove workflow spec, input and params from workflow context https://review.openstack.org/370105 | 12:10 |
| openstackgerrit | Merged openstack/mistral: Add functional tests for event engine functions https://review.openstack.org/336463 | 12:10 |
| ddeja | heh, I'm too late, I was on second patch ;) | 12:11 |
| *** rbrady has joined #openstack-mistral | 12:11 | |
| rakhmerov | :)) | 12:13 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: Get rid of using workflow execution 'context' field https://review.openstack.org/370762 | 12:30 |
| *** hparekh has quit IRC | 12:31 | |
| openstackgerrit | Merged openstack/mistral: Added unit tests for Workbook and Workflow filtering https://review.openstack.org/367272 | 12:37 |
| openstackgerrit | Hardik Parekh proposed openstack/python-mistralclient: Remove unnecessary 'if' conditions https://review.openstack.org/370772 | 12:40 |
| *** sharatss has joined #openstack-mistral | 12:44 | |
| *** bobh has quit IRC | 12:45 | |
| *** shardy has joined #openstack-mistral | 12:50 | |
| *** rbrady has quit IRC | 12:59 | |
| *** rbrady has joined #openstack-mistral | 12:59 | |
| *** rbrady has left #openstack-mistral | 12:59 | |
| *** rbrady has joined #openstack-mistral | 13:00 | |
| *** jaosorior has quit IRC | 13:02 | |
| *** jaosorior has joined #openstack-mistral | 13:02 | |
| *** shardy has quit IRC | 13:22 | |
| *** brian_price has quit IRC | 13:23 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Updating mistralclient docs https://review.openstack.org/370821 | 13:23 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Updating mistralclient docs https://review.openstack.org/370821 | 13:27 |
| *** bobh has joined #openstack-mistral | 13:28 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Updating mistralclient docs https://review.openstack.org/370821 | 13:31 |
| *** bobh has quit IRC | 13:34 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Updating mistralclient docs https://review.openstack.org/370821 | 13:36 |
| *** nmakhotkin has quit IRC | 13:46 | |
| *** nmakhotkin has joined #openstack-mistral | 13:47 | |
| *** tonytan4ever has joined #openstack-mistral | 13:51 | |
| *** tonytan_brb has joined #openstack-mistral | 13:56 | |
| *** tonytan4ever has quit IRC | 13:58 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Adding a script for fast mistralclient help generation https://review.openstack.org/370858 | 14:06 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Adding a script for fast mistralclient help generation https://review.openstack.org/370858 | 14:08 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Adding a script for fast mistralclient help generation https://review.openstack.org/370858 | 14:09 |
| *** nmakhotkin has quit IRC | 14:36 | |
| *** rrecio_ has joined #openstack-mistral | 14:56 | |
| *** tonytan_brb is now known as tonytan4ever | 14:57 | |
| *** rrecio has quit IRC | 14:59 | |
| *** jaosorior has quit IRC | 15:18 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for raising excepton from kombu https://review.openstack.org/370937 | 15:18 |
| d0ugal | rakhmerov, ddeja: are either of you around? | 15:27 |
| d0ugal | Quick question, hopefully :) | 15:27 |
| ddeja | d0ugal: ? | 15:27 |
| d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L74-L78 | 15:27 |
| d0ugal | I just noticed we have some tasks that don't have "action" or "workflow" | 15:28 |
| d0ugal | they use on-success only | 15:28 |
| d0ugal | The documentation actually says we shouldn't do that. | 15:28 |
| d0ugal | I'm curious to know if this is likely to cause a problem? | 15:29 |
| d0ugal | I am going to update out workflows anyway | 15:29 |
| ddeja | d0ugal: if I remember correctly, if you don't specidy action, the std.noop action is being run | 15:29 |
| d0ugal | ddeja: k, thanks | 15:29 |
| ddeja | let me check | 15:29 |
| d0ugal | So in theory it shouldn't be a problem | 15:30 |
| ddeja | At the first glance, I don't see any | 15:30 |
| d0ugal | k, thanks | 15:30 |
| ddeja | can you point me to docs you are refering? | 15:30 |
| d0ugal | I'll update anyway because it is a bit confusing I think | 15:30 |
| ddeja | is it mistral dsl guide? | 15:30 |
| d0ugal | Yeah | 15:30 |
| d0ugal | "action - Name of the action associated with the task. Required but mutually exclusive with workflow." | 15:30 |
| d0ugal | ddeja: ^ | 15:30 |
| d0ugal | http://docs.openstack.org/developer/mistral/dsl/dsl_v2.html#common-task-attributes | 15:30 |
| d0ugal | I guess either the docs should be updated, or we should validate that. | 15:31 |
| d0ugal | I'll open a bug. | 15:31 |
| *** bobh has joined #openstack-mistral | 15:32 | |
| ddeja | d0ugal: yes, I've checked - it runs noop action | 15:33 |
| d0ugal | ddeja: k, thanks | 15:33 |
| *** sharatss has quit IRC | 15:33 | |
| d0ugal | ddeja: I guess that behaviour is fine, I opened a bug anyway: | 15:34 |
| d0ugal | https://bugs.launchpad.net/mistral/+bug/1624012 | 15:34 |
| openstack | Launchpad bug 1624012 in Mistral "Validate that either an action or a workflow is provided in workflow tasks" [Undecided,New] | 15:34 |
| d0ugal | but maybe just a documentation update is best. | 15:34 |
| ddeja | d0ugal: I guess that somebody forget to update the docs | 15:34 |
| ddeja | since there is code like self.action_name = action_name or 'std.noop' | 15:35 |
| d0ugal | right | 15:35 |
| *** bobh has quit IRC | 15:36 | |
| *** bobh has joined #openstack-mistral | 15:50 | |
| *** brian_price has joined #openstack-mistral | 15:55 | |
| *** jpich has quit IRC | 16:32 | |
| *** tonytan4ever has quit IRC | 16:42 | |
| *** janki has joined #openstack-mistral | 16:43 | |
| *** bobh has quit IRC | 17:16 | |
| *** tonytan4ever has joined #openstack-mistral | 17:37 | |
| *** janki has quit IRC | 17:40 | |
| *** bobh has joined #openstack-mistral | 18:16 | |
| *** bobh has quit IRC | 18:21 | |
| *** bobh has joined #openstack-mistral | 19:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-mistralclient: Updated from global requirements https://review.openstack.org/371123 | 20:25 |
| *** catintheroof has joined #openstack-mistral | 21:15 | |
| *** gyee has joined #openstack-mistral | 21:27 | |
| *** doriftoshoes has quit IRC | 21:45 | |
| *** brunograz has quit IRC | 21:45 | |
| *** brunograz_ has joined #openstack-mistral | 21:45 | |
| *** lkannan has quit IRC | 21:46 | |
| *** cargonza has quit IRC | 21:46 | |
| *** doriftoshoes has joined #openstack-mistral | 21:48 | |
| *** cargonza has joined #openstack-mistral | 21:52 | |
| *** lkannan has joined #openstack-mistral | 21:54 | |
| *** tonytan4ever has quit IRC | 22:27 | |
| *** bobh has quit IRC | 22:38 | |
| *** catintheroof has quit IRC | 23:21 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!