| *** Ravikiran_K has joined #openstack-mistral | 00:10 | |
| *** Alexey_Abashkin_ has quit IRC | 00:13 | |
| *** Alexey_Abashkin_ has joined #openstack-mistral | 00:14 | |
| *** Alexey_Abashkin_ has quit IRC | 00:18 | |
| *** vishwanathj has quit IRC | 00:22 | |
| *** Alexey_Abashkin_ has joined #openstack-mistral | 00:32 | |
| *** bobh has quit IRC | 00:44 | |
| *** tonytan4ever has joined #openstack-mistral | 00:48 | |
| *** tonytan4ever has quit IRC | 00:52 | |
| *** cheneydc has joined #openstack-mistral | 00:59 | |
| *** bobh has joined #openstack-mistral | 01:02 | |
| *** cheneydc has quit IRC | 01:04 | |
| *** tonytan4ever has joined #openstack-mistral | 01:49 | |
| *** tonytan4ever has quit IRC | 01:54 | |
| *** bobh has quit IRC | 02:10 | |
| *** tonytan4ever has joined #openstack-mistral | 02:23 | |
| *** bobh has joined #openstack-mistral | 02:43 | |
| *** hparekh has joined #openstack-mistral | 02:44 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Add std.command https://review.openstack.org/373606 | 02:59 |
|---|---|---|
| *** bobh has quit IRC | 03:02 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Add std.command https://review.openstack.org/373606 | 04:00 |
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: Deleting executions shouldn't be allowed unless they have finished (SUCCESS/ERROR Closes-bug: 1598135 https://review.openstack.org/373630 | 04:06 |
| openstack | bug 1598135 in Mistral "Deleting executions shouldn't be allowed unless they have finished (SUCCESS/ERROR)" [Undecided,In progress] https://launchpad.net/bugs/1598135 - Assigned to Lucky samadhiya (lucky-samadhiya) | 04:06 |
| *** Ravikiran_K has quit IRC | 04:35 | |
| *** jaosorior has joined #openstack-mistral | 04:50 | |
| *** jaosorior has quit IRC | 05:10 | |
| *** jaosorior has joined #openstack-mistral | 05:11 | |
| *** sharatss has quit IRC | 05:44 | |
| *** janki has joined #openstack-mistral | 05:47 | |
| *** sharatss has joined #openstack-mistral | 05:49 | |
| *** tonytan4ever has quit IRC | 06:14 | |
| *** shardy has joined #openstack-mistral | 06:14 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Replace MagicMock with Mock class https://review.openstack.org/373712 | 06:41 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/373706 | 06:43 |
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: Add unit test case for deletion of execution in case of (error and cancelled) https://review.openstack.org/373795 | 06:56 |
| *** Alexey_Abashkin_ has quit IRC | 07:20 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:23 | |
| *** jpich has joined #openstack-mistral | 07:36 | |
| *** tonytan4ever has joined #openstack-mistral | 07:44 | |
| *** tonytan4ever has quit IRC | 07:50 | |
| *** hparekh has quit IRC | 07:56 | |
| *** hparekh has joined #openstack-mistral | 07:56 | |
| *** hparekh_ has joined #openstack-mistral | 08:01 | |
| *** hparekh has quit IRC | 08:01 | |
| *** nmakhotkin has joined #openstack-mistral | 08:04 | |
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: Add unit test case for deletion of execution in case of (error and cancelled) https://review.openstack.org/373795 | 08:06 |
| *** jaosorior is now known as jaosorior_brb | 08:28 | |
| openstackgerrit | gecong proposed openstack/mistral: Replace assertEqual(None, *) with assertIsNone in tests https://review.openstack.org/373884 | 08:29 |
| *** shardy has quit IRC | 08:42 | |
| *** shardy has joined #openstack-mistral | 08:52 | |
| *** hparekh_ has quit IRC | 09:04 | |
| *** hparekh has joined #openstack-mistral | 09:20 | |
| *** hparekh_ has joined #openstack-mistral | 09:26 | |
| *** hparekh has quit IRC | 09:27 | |
| rakhmerov | hparekh_: hi Hardik, you here? | 09:43 |
| rakhmerov | ddeja: hi, how is it going? | 09:44 |
| ddeja | rakhmerov: Hi | 09:44 |
| rakhmerov | ddeja: did you have a chance to look at that RPC issue? | 09:44 |
| ddeja | unfortunately, I got info from my technical university that I have to finish my master thesis ASAP | 09:44 |
| rakhmerov | ooh | 09:45 |
| rakhmerov | ok | 09:45 |
| rakhmerov | you're running for master degree? | 09:45 |
| ddeja | yup. Right know I have engineering degree | 09:46 |
| rakhmerov | ok, cool :) | 09:46 |
| rakhmerov | when do you think you'll be able to look at the issue? | 09:46 |
| rakhmerov | (not 'to look' apparently but rather 'to fix') :) | 09:46 |
| ddeja | well, I hope to finish my thesis today/tommorow, so Friday | 09:46 |
| rakhmerov | ok, that's fine | 09:47 |
| ddeja | But I can send patch today that would make executor run in 'eventlet' mode | 09:47 |
| ddeja | it is totaly safe and easy | 09:47 |
| rakhmerov | yes, if you can it would be very good | 09:47 |
| ddeja | and I'll look more onto chanign sync to async on Friday | 09:47 |
| rakhmerov | d0ugal and others could test it with this change in the meantime | 09:47 |
| rakhmerov | yes | 09:48 |
| ddeja | yup | 09:48 |
| rakhmerov | sounds good to me | 09:48 |
| ddeja | I'll submit patch in next 2-3 hours | 09:48 |
| rakhmerov | ok | 09:48 |
| rakhmerov | hparekh_: ^ | 09:49 |
| rakhmerov | pls ping me once you're here | 09:49 |
| d0ugal | Thanks :) | 09:50 |
| rakhmerov | ddeja, hparekh_: also, once you have a change pls look at https://review.openstack.org/#/c/370762/, it makes cool changes, reduces space consumed by tasks and speeds mistral up | 09:51 |
| ddeja | rakhmerov: sure | 09:53 |
| *** hparekh__ has joined #openstack-mistral | 09:59 | |
| *** hparekh_ has quit IRC | 09:59 | |
| hparekh__ | rakhmerov, Hi | 10:00 |
| rakhmerov | hparekh__: hey, just a question about your patch again | 10:00 |
| hparekh__ | rakhmerov, yeah | 10:01 |
| rakhmerov | https://review.openstack.org/#/c/369834/ | 10:01 |
| rakhmerov | I still don't understand a little bit | 10:01 |
| rakhmerov | could you please provide some workflow definition (at least sudo) so that I understand it structure? | 10:01 |
| rakhmerov | I want to merge it but want to make sure on 100% that I understand the change and its consequences | 10:02 |
| rakhmerov | just please a WF definition, I'll be back in ~30 mins | 10:02 |
| hparekh__ | rakhmerov, You can reproduce this with out std.create_instance workflow | 10:04 |
| hparekh__ | If you see wait_vm_active it will fail stated that vm_id is not published in second iteration | 10:05 |
| hparekh__ | wait_vm_active is using vm_id to check wheteher vm is up or not. so it is retrying until it is up, but in second iteration it cannot find vm_id. | 10:07 |
| rakhmerov | ok, wait a second.. | 10:08 |
| rakhmerov | looking again.. | 10:08 |
| *** hparekh_ has joined #openstack-mistral | 10:10 | |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/373706 | 10:12 |
| *** avnish__ has joined #openstack-mistral | 10:12 | |
| *** prince_katiyar has joined #openstack-mistral | 10:13 | |
| *** hparekh__ has quit IRC | 10:14 | |
| *** prince_katiyar has quit IRC | 10:16 | |
| rakhmerov | hparekh_: ok, and why doesn't it see vm_id? | 10:16 |
| rakhmerov | and why only for the second iteration? | 10:17 |
| *** hparekh has joined #openstack-mistral | 10:23 | |
| *** hparekh_ has quit IRC | 10:23 | |
| rakhmerov | hparekh: ^ | 10:24 |
| hparekh | rakhmerov, Actually context is recertaed | 10:24 |
| rakhmerov | so you mean for the second iteration it gets recreated and vm_id gets lost? | 10:26 |
| *** brian_price has quit IRC | 10:28 | |
| hparekh | rakhmerov, yes exactily | 10:29 |
| rakhmerov | why does it get lost for the second iteration but it doesn't for the 1st? | 10:31 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Avoid storing workflow input in task inbound context https://review.openstack.org/370762 | 10:32 |
| *** janki has quit IRC | 10:33 | |
| *** mflobo has joined #openstack-mistral | 10:36 | |
| hparekh | rakhmerov, When it goes to recalculate context it use wf_ctrl.get_task_inbound_context | 10:36 |
| hparekh | which will not give published variable of 'create_vm' task | 10:36 |
| *** tonytan4ever has joined #openstack-mistral | 10:46 | |
| *** tonytan4ever has quit IRC | 10:52 | |
| *** janki has joined #openstack-mistral | 11:00 | |
| *** shardy is now known as shardy_lunch | 11:05 | |
| openstackgerrit | Merged openstack/python-mistralclient: Add 'created_at' and 'updated_at' to action-execution-get and action-execution-list command Closes-bug: 1618767 Change-Id: I422fdcdfa66d6b7a781542c7acc458f8c46edb18 https://review.openstack.org/372364 | 11:07 |
| openstack | bug 1618767 in Mistral "Some execution related Mistral CLI commands not returning start and end date" [Medium,In progress] https://launchpad.net/bugs/1618767 - Assigned to Lucky samadhiya (lucky-samadhiya) | 11:07 |
| rakhmerov | hparekh: ooh, ok, I got it now | 11:10 |
| rakhmerov | hparekh: you know, but honestly I think that outbound context should have published variables of previous tasks | 11:15 |
| rakhmerov | maybe we have a more serious bug somewhere | 11:15 |
| rakhmerov | ok, let's merge it now, I'm going to write some more tests for context related functionality and I'll include some tests for that | 11:16 |
| hparekh | rakhmerov, Ok, I think it need more investigation | 11:17 |
| rakhmerov | hparekh: btw, I made some changes in https://review.openstack.org/#/c/370762/ related to context calculations | 11:20 |
| rakhmerov | so the way how we calculate context has changed anyway | 11:20 |
| *** mflobo has quit IRC | 11:23 | |
| openstackgerrit | Merged openstack/mistral: Fixed task in_bound context when retrying https://review.openstack.org/369834 | 11:27 |
| *** jaosorior_brb is now known as jaosorior | 11:28 | |
| d0ugal | So, we have quite a few commands registered as plugins for openstackclient | 11:29 |
| d0ugal | However, many of them are impossible to use. | 11:29 |
| d0ugal | and I guess they have been for a while! | 11:29 |
| *** shardy_lunch is now known as shardy | 11:29 | |
| d0ugal | so, this means that nobody is using it I guess? | 11:29 |
| d0ugal | For example - "openstack workflow execution show output" - that wont work | 11:30 |
| d0ugal | as it takes the "output" part and thinks it is the execution id lik "openstack workflow execution show $ID" | 11:30 |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Add std.command https://review.openstack.org/373606 | 11:31 |
| openstackgerrit | Merged openstack/mistral: Add __ne__ built-in function https://review.openstack.org/372850 | 11:33 |
| *** hparekh has quit IRC | 11:46 | |
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: Add unit test case for deletion of execution in case of (error and cancelled) https://review.openstack.org/373795 | 11:47 |
| rakhmerov | d0ugal: right | 11:59 |
| rakhmerov | I don't believe someone is using them | 11:59 |
| d0ugal | rakhmerov: I opened a bug :) https://bugs.launchpad.net/mistral/+bug/1626054 | 11:59 |
| openstack | Launchpad bug 1626054 in Mistral "Multiple broken openstackclient commands" [Undecided,Confirmed] | 11:59 |
| *** bobh has joined #openstack-mistral | 11:59 | |
| d0ugal | rakhmerov: Yeah, I just tried using them in our documentation | 11:59 |
| rakhmerov | :) | 12:00 |
| rakhmerov | ok | 12:00 |
| d0ugal | fair low priority I think | 12:01 |
| d0ugal | since I think it has been like this since Liberty. | 12:01 |
| *** dprince has joined #openstack-mistral | 12:13 | |
| *** bobh has quit IRC | 12:28 | |
| *** mflobo has joined #openstack-mistral | 12:34 | |
| therve | ddeja, Hi! Is there a consensus for that timeout bug? | 12:53 |
| therve | It seems there was after the meeting but I wasn't sure | 12:53 |
| ddeja | therve: hi. I'll send the most basic fix in a minute | 13:02 |
| ddeja | and I'll focus on general solution later this week | 13:02 |
| *** vishwanathj has joined #openstack-mistral | 13:06 | |
| *** jaosorior has quit IRC | 13:10 | |
| *** jaosorior has joined #openstack-mistral | 13:11 | |
| *** bobh has joined #openstack-mistral | 13:11 | |
| *** _achatterjee_ has joined #openstack-mistral | 13:16 | |
| openstackgerrit | Merged openstack/python-mistralclient: Pass httpclient to managers https://review.openstack.org/365416 | 13:17 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for timeouting actions on run-action https://review.openstack.org/374145 | 13:24 |
| ddeja | therve, d0ugal, rakhmerov here you are ^ | 13:24 |
| rakhmerov | I'm here | 13:24 |
| d0ugal | ddeja: Thanks! I'll test it now. | 13:25 |
| rakhmerov | what's up? | 13:25 |
| rakhmerov | ooh, the patch | 13:25 |
| rakhmerov | ok | 13:25 |
| ddeja | rakhmerov: :) | 13:25 |
| rakhmerov | :) | 13:25 |
| rakhmerov | ddeja: looks good to me. Just one thing I'd like to ask you about is can you please add a short comment where we init the server for engine saying that for engine we must use a default executor value which is 'blocking' due to a known issue with green threads using external blocking calls? | 13:28 |
| rakhmerov | so that people see some info | 13:29 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Adding a script for fast mistralclient help generation https://review.openstack.org/370858 | 13:36 |
| *** janki has quit IRC | 13:41 | |
| ddeja | rakhmerov: OK | 13:44 |
| therve | ddeja, So I guess that solves your issue, but not the top one in the bug | 13:47 |
| ddeja | therve: but the top one is not an issue | 13:48 |
| therve | ddeja, How's that not an issue? :) | 13:49 |
| ddeja | because if you want to several mistral action in sequence, you need to use workflow, not run action inside run action | 13:49 |
| therve | Something worked, and now it doesn't. Plus it' probably a DOS vector | 13:49 |
| ddeja | therve: yes, it was working, but it is not something that run-action is designed for | 13:50 |
| therve | ddeja, OK, then it should raise an error, not block the entire deployment | 13:51 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for timeouting actions on run-action https://review.openstack.org/374145 | 13:51 |
| ddeja | therve: I agree, but due to the fact that actions may be written by users, I'm not sure if it is possible to achievie this | 13:52 |
| *** tonytan4ever has joined #openstack-mistral | 13:52 | |
| ddeja | I mean, rise error when 'run-action' is used to run-acion/execution-create | 13:53 |
| ddeja | I will add info about it to docs (if it isn't already there) | 13:53 |
| therve | I'm sorry, but I still feel the previous behavior was preferable than the current situation | 13:54 |
| therve | If it's not preventable, you can't simply deploy mistral anywhere | 13:54 |
| ddeja | but why would you like to use run action for running another action? Workflow is designed for such use? | 13:54 |
| therve | ddeja, Not even thinking about custom actions, I'm thinking about malicious users | 13:55 |
| ddeja | therve: but you can't reproduce it without writing custom actions | 13:57 |
| therve | ddeja, Sure you can? Simply run what's in the bug | 13:57 |
| therve | It will hang the service for 1 minute | 13:57 |
| ddeja | oh, OK, by deafult we are crating actions based on mistralclient... | 13:59 |
| ddeja | but still I don't see why someone would like to write "mistral run-action mistral.action_executions_create '{"name": "std.noop"}'" instead of "mistral run-action std.noop" | 14:00 |
| ddeja | IMO it would be enought to state it in docs that run-action cannot be used for running actions | 14:01 |
| ddeja | for running another mistral actions* | 14:01 |
| therve | ddeja, You're not answering my concern about malicious users though | 14:02 |
| therve | Frankly I don't understand why I have to convince you it's an issue | 14:03 |
| therve | That seems to be obviously broken | 14:04 |
| ddeja | oh, sorry | 14:04 |
| ddeja | I didn't sleep much last week ;) | 14:04 |
| ddeja | no I got it | 14:04 |
| ddeja | now I got it* | 14:04 |
| ddeja | yes, I'll look on it on Friday | 14:05 |
| ddeja | we have to solve it | 14:05 |
| ddeja | therve: sorry once again for confusion | 14:07 |
| therve | No worries | 14:07 |
| *** nmakhotkin has quit IRC | 14:10 | |
| * rakhmerov reading the conversation (with big eyes).. | 14:37 | |
| ddeja | rakhmerov: yeah, sorry, I confused two things, therve is totaly right | 14:38 |
| rakhmerov | yeah, I think he is | 14:40 |
| rakhmerov | but that second thing that we planned should probably help, right? | 14:40 |
| ddeja | rakhmerov: it helps for most of the problems | 14:41 |
| rakhmerov | yeah, ok | 14:41 |
| ddeja | but not for the "mistral run-action mistral.action_executions_create '{"name": "std.noop"}'" | 14:41 |
| rakhmerov | this is complicated, it's easy to get confused :) | 14:41 |
| rakhmerov | np | 14:41 |
| ddeja | this one couse deadlock in different place and I't wouldn't be easy to solve | 14:42 |
| rakhmerov | ok | 14:42 |
| rakhmerov | ddeja: let's discuss that again early next week, I may be able to help too | 14:48 |
| rakhmerov | as well as d0ugal ;) | 14:48 |
| rakhmerov | Monday | 14:48 |
| *** brian_price has joined #openstack-mistral | 14:48 | |
| ddeja | OK | 14:57 |
| *** openstack has joined #openstack-mistral | 15:01 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral: Accept service catalog from client side https://review.openstack.org/355368 | 15:03 |
| *** bobh has quit IRC | 15:06 | |
| *** rrecio has joined #openstack-mistral | 15:08 | |
| *** jaosorior has quit IRC | 15:39 | |
| *** d0ugal has quit IRC | 15:48 | |
| *** d0ugal has joined #openstack-mistral | 15:50 | |
| *** mflobo has left #openstack-mistral | 16:35 | |
| *** jpich has quit IRC | 16:48 | |
| *** bobh has joined #openstack-mistral | 17:07 | |
| *** dprince has quit IRC | 17:07 | |
| *** bobh has quit IRC | 17:13 | |
| *** bobh has joined #openstack-mistral | 18:10 | |
| *** jpich has joined #openstack-mistral | 18:14 | |
| *** tonytan4ever has quit IRC | 18:14 | |
| *** bobh has quit IRC | 18:14 | |
| *** tonytan4ever has joined #openstack-mistral | 18:15 | |
| *** shardy has quit IRC | 18:18 | |
| *** sharatss has quit IRC | 18:18 | |
| *** jpich has quit IRC | 18:35 | |
| *** ig0r_ has joined #openstack-mistral | 18:51 | |
| *** bobh has joined #openstack-mistral | 19:11 | |
| *** catintheroof has joined #openstack-mistral | 19:12 | |
| *** bobh has quit IRC | 19:16 | |
| *** tonytan_brb has joined #openstack-mistral | 19:41 | |
| *** tonytan4ever has quit IRC | 19:44 | |
| *** mflobo has joined #openstack-mistral | 19:59 | |
| *** mflobo has quit IRC | 19:59 | |
| *** catintheroof has quit IRC | 20:08 | |
| *** bobh has joined #openstack-mistral | 21:13 | |
| *** bobh has quit IRC | 21:18 | |
| *** ig0r_ has quit IRC | 21:45 | |
| *** bobh has joined #openstack-mistral | 22:10 | |
| *** bobh has quit IRC | 22:37 | |
| *** rrecio has quit IRC | 22:59 | |
| openstackgerrit | Winson Chan proposed openstack/python-mistralclient: Abstract authentication function https://review.openstack.org/371234 | 23:19 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!