| *** bobh has joined #openstack-mistral | 00:36 | |
| *** bobh has quit IRC | 02:21 | |
| *** bobh has joined #openstack-mistral | 03:22 | |
| *** bobh has quit IRC | 03:26 | |
| *** rrecio has joined #openstack-mistral | 04:03 | |
| *** rrecio has quit IRC | 04:13 | |
| *** janki has joined #openstack-mistral | 04:49 | |
| *** bobh has joined #openstack-mistral | 05:23 | |
| *** bobh has quit IRC | 05:28 | |
| sharatss | hi | 05:39 |
|---|---|---|
| *** jaosorior has joined #openstack-mistral | 06:09 | |
| rakhmerov | ddeja: hi, can you please review https://review.openstack.org/#/c/395696/ ? | 06:29 |
| *** sharatss has quit IRC | 06:31 | |
| *** sharatss has joined #openstack-mistral | 06:32 | |
| *** jaosorior has quit IRC | 06:39 | |
| *** jaosorior has joined #openstack-mistral | 06:39 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 06:51 | |
| *** AlexeyAbashkin has quit IRC | 06:57 | |
| *** bobh has joined #openstack-mistral | 07:25 | |
| *** jaosorior has quit IRC | 07:27 | |
| *** bobh has quit IRC | 07:30 | |
| *** hparekh has joined #openstack-mistral | 07:30 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added senlin action pack https://review.openstack.org/395587 | 07:47 |
| *** jaosorior has joined #openstack-mistral | 07:55 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:56 | |
| *** shardy has joined #openstack-mistral | 07:58 | |
| openstackgerrit | hnyang proposed openstack/mistral-extra: Add clone vm example https://review.openstack.org/396840 | 08:04 |
| openstackgerrit | Merged openstack/python-mistralclient: Remove unused scripts in tools https://review.openstack.org/395546 | 08:08 |
| *** ^Gal^ has joined #openstack-mistral | 08:14 | |
| openstackgerrit | hnyang proposed openstack/mistral-extra: Add clone vm example https://review.openstack.org/396840 | 08:19 |
| *** sharatss has quit IRC | 08:20 | |
| *** sharatss has joined #openstack-mistral | 08:21 | |
| ddeja | rakhmerov: sure, I have a meeting in 5 minutes but after that I'll review this | 08:26 |
| openstackgerrit | Merged openstack/mistral: Migrate mistral task_type https://review.openstack.org/395742 | 08:34 |
| openstackgerrit | Merged openstack/mistral: Remove unused scripts in tools https://review.openstack.org/395547 | 08:34 |
| openstackgerrit | Merged openstack/mistral: Fix missing exception decorators in REST API https://review.openstack.org/395705 | 08:39 |
| *** d0ugal has joined #openstack-mistral | 08:43 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added senlin action pack https://review.openstack.org/395587 | 08:44 |
| *** jpich has joined #openstack-mistral | 08:48 | |
| *** AlexeyAbashkin has quit IRC | 09:04 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Few changes in the doc https://review.openstack.org/397067 | 09:10 |
| xavierhardy | how does Jinja2 support works in Mistral ? | 09:18 |
| xavierhardy | Hi everyone | 09:18 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added senlin action pack https://review.openstack.org/395587 | 09:21 |
| *** brunograz1 has joined #openstack-mistral | 09:34 | |
| *** brunograz has quit IRC | 09:36 | |
| d0ugal | xavierhardy: Good question. It isn't documented :( | 09:38 |
| d0ugal | xavierhardy: for YAQL, you use <% %> | 09:39 |
| xavierhardy | Yes | 09:39 |
| d0ugal | xavierhardy: for jinja2 I think it is just {{ }} | 09:39 |
| xavierhardy | and for Jinja2 {{ }} ? | 09:39 |
| xavierhardy | OK | 09:39 |
| xavierhardy | I've seen in the code that it's possible to export custom functions for both YAQL and Jinja2 at the same time, that's cool | 09:40 |
| d0ugal | Yeah, this seems to confirm it: https://github.com/openstack/mistral/blob/master/mistral/expressions/jinja_expression.py#L29 | 09:40 |
| d0ugal | Yeah, it does seem possible :) | 09:40 |
| xavierhardy | which one gets called first ? | 09:41 |
| d0ugal | Not sure. | 09:42 |
| xavierhardy | or are they mutually exclusive ? | 09:42 |
| xavierhardy | OK | 09:42 |
| d0ugal | I don't really understand | 09:42 |
| d0ugal | I guess they are mutually exclusive - you either have jinja2 or yaql | 09:42 |
| d0ugal | both sounds messy :) | 09:42 |
| xavierhardy | no, apparently, you have both at the same time, hence "evaluators" is a plural | 09:42 |
| xavierhardy | but I'm not sure if you can use both in an expression in the same time | 09:43 |
| d0ugal | Right | 09:43 |
| xavierhardy | and what i'm not sure about is the type in Jinja2 | 09:43 |
| d0ugal | I think you can probably have both in the workflow, but not in the same expression | 09:43 |
| d0ugal | What do you mean by type? I didn't know jinja2 had different types :) | 09:43 |
| xavierhardy | Jinja2 just outputs string, what if I want to output an integer (and no the stirng of an integer) | 09:43 |
| d0ugal | hm | 09:43 |
| d0ugal | good question | 09:43 |
| *** ^Gal^ has quit IRC | 09:45 | |
| d0ugal | We need to be *much* stricter about requiring documentation for features IMO | 09:47 |
| *** openstackgerrit has quit IRC | 09:47 | |
| *** openstackgerrit has joined #openstack-mistral | 09:48 | |
| xavierhardy | yes | 09:56 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added pyv8 in requirement.txt in mistral code for bug ID : 1551561 closes-Bug: #1551561 https://review.openstack.org/369342 | 10:00 |
| openstack | bug 1551561 in Mistral "pyv8 is not required by mistral but javascipt action is installed by default" [Undecided,In progress] https://launchpad.net/bugs/1551561 - Assigned to Sharat Sharma (sharat-sharma) | 10:00 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Region name related command line arguments are added https://review.openstack.org/386403 | 10:07 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added pyv8 in requirement.txt https://review.openstack.org/369342 | 10:08 |
| openstackgerrit | Merged openstack/mistral: Fix REST API dangling transactions https://review.openstack.org/395696 | 10:16 |
| xavierhardy | The line already contains an expression of type 'jinja'. Mixing expression types in a single line is not allowed. | 10:20 |
| xavierhardy | OK, so you can't mix them | 10:20 |
| xavierhardy | Cool, that was merged ! | 10:20 |
| ddeja | xavierhardy: your welcome ;) | 10:21 |
| rakhmerov | xavierhardy, d0ugal: you're right about the syntax. For jinja it's just {{}} | 10:35 |
| d0ugal | rakhmerov: thanks | 10:35 |
| rakhmerov | you can use both at the same time | 10:35 |
| rakhmerov | within one YAML | 10:36 |
| rakhmerov | but not within one string | 10:36 |
| rakhmerov | that's the rule to remember | 10:36 |
| d0ugal | Makes sense :) | 10:36 |
| rakhmerov | as far as types: it should be the same with YAQL and Jinja | 10:37 |
| xavierhardy | ? | 10:37 |
| rakhmerov | type translations happen after parsing and evaluating expressions | 10:37 |
| xavierhardy | Jinja2 only produces String | 10:37 |
| xavierhardy | *strings | 10:37 |
| rakhmerov | yes, right | 10:37 |
| rakhmerov | YAQL in many cases too | 10:37 |
| rakhmerov | but then we convert values with json.loads() | 10:37 |
| xavierhardy | ? | 10:38 |
| xavierhardy | is it done ? | 10:38 |
| rakhmerov | assuming that we have JSON-compatible values | 10:38 |
| rakhmerov | yes | 10:38 |
| xavierhardy | OK | 10:38 |
| rakhmerov | if it's not done then this is a bug, but we have a bunch of tests for it | 10:38 |
| xavierhardy | at which point is it done ? | 10:38 |
| xavierhardy | for the whole string ? | 10:38 |
| rakhmerov | what do you mean by point? Place in code? | 10:39 |
| rakhmerov | d0ugal: would you be able to drive a meeting today? | 10:39 |
| rakhmerov | I'm sick today | 10:39 |
| d0ugal | rakhmerov: Sure | 10:39 |
| xavierhardy | yes and no, in the evaluation pipeline? | 10:39 |
| d0ugal | rakhmerov: I wanted to discuss the meeting time today, as it has been a week since I posted that etherpad now and I don't think we are getting any more replies | 10:40 |
| rakhmerov | well, somewhere in expressions module we have something like "evaluate_recursively()" method where we pass any structure (list, dict or string) | 10:40 |
| rakhmerov | and this structure is inspected and all expressions are evaluated | 10:41 |
| rakhmerov | and get converted with json.loads() | 10:41 |
| rakhmerov | d0ugal: ok, sure | 10:41 |
| xavierhardy | indeed: | 10:41 |
| xavierhardy | {"result": 42} | 10:41 |
| xavierhardy | that was a test of {{ _.status }} with status equals to 42 | 10:41 |
| rakhmerov | d0ugal: I'm ok with all times in the range I specified | 10:41 |
| rakhmerov | xavierhardy: and so? I'm not sure I understand what you mean by that | 10:45 |
| rakhmerov | you still have some concerns? | 10:45 |
| xavierhardy | no, it's fine | 10:46 |
| *** therve has quit IRC | 10:46 | |
| xavierhardy | It makes sense that YAQL and Jinja2 can't be used in the same string (because else comes the question: "who's first?") | 10:47 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Migrated to the new oslo.db enginefacade https://review.openstack.org/397125 | 10:47 |
| xavierhardy | and it makes sense to use json.loads to check the type of the output | 10:47 |
| xavierhardy | that's really cool | 10:47 |
| rakhmerov | ok :) | 10:47 |
| rakhmerov | yeah, it is cool | 10:47 |
| xavierhardy | + you can actually use any evaluator (as it is now configurable) | 10:48 |
| rakhmerov | xavierhardy: please not that jinja has some cool stuff like {{ if ... }} {{ else }} blocks | 10:48 |
| rakhmerov | which is missing in YAQL | 10:48 |
| xavierhardy | yes, and many know how to use Jinja2 but not YAQL (which unfortunately very powerful but lacks documentation) | 10:48 |
| rakhmerov | with them you can insert blocks if texts based on some conditions | 10:48 |
| xavierhardy | (though it should be fixed soon) | 10:48 |
| rakhmerov | xavierhardy: YAQL's documentation is claimed to be good now (but I still need to check) | 10:49 |
| xavierhardy | \o/ | 10:49 |
| xavierhardy | http://yaql.readthedocs.io/en/latest/standard_library.html | 10:49 |
| rakhmerov | a month or two ago they started documenting all the functions | 10:49 |
| xavierhardy | Yes, I know they rejected my Change Request | 10:50 |
| xavierhardy | and actually forked their WIP changes and uploaded them on Git pages | 10:50 |
| xavierhardy | ;) | 10:50 |
| xavierhardy | https://yaql.github.io/standard_library.html | 10:50 |
| rakhmerov | :) | 10:50 |
| xavierhardy | but now, it is now unnecessary | 10:50 |
| *** d0ugal has quit IRC | 10:56 | |
| xavierhardy | can someone review this please: https://review.openstack.org/#/c/396128/ ? It is also quite an important bug. | 10:57 |
| rakhmerov | ok | 11:00 |
| rakhmerov | xavierhardy: why do you delete a transactions in https://review.openstack.org/#/c/396128/2/mistral/services/triggers.py ? | 11:01 |
| xavierhardy | because I start in higher level if I remember well | 11:02 |
| xavierhardy | let me check | 11:02 |
| rakhmerov | ok | 11:02 |
| xavierhardy | yes | 11:02 |
| xavierhardy | https://review.openstack.org/#/c/396128/2/mistral/api/controllers/v2/event_trigger.py | 11:02 |
| xavierhardy | the get and delete/update need to be in the same transaction | 11:03 |
| xavierhardy | to avoid race conditions | 11:03 |
| rakhmerov | ooh, I see | 11:03 |
| rakhmerov | ok | 11:03 |
| rakhmerov | good | 11:03 |
| *** d0ugal has joined #openstack-mistral | 11:05 | |
| rakhmerov | xavierhardy: done | 11:05 |
| xavierhardy | Cool | 11:05 |
| rakhmerov | d0ugal: please take a look too once you have time | 11:05 |
| d0ugal | rakhmerov: at what? Sorry, my connection dropped. | 11:05 |
| rakhmerov | d0ugal: still planning to implement tests for that bug? | 11:06 |
| xavierhardy | https://review.openstack.org/#/c/396128/ | 11:06 |
| rakhmerov | ooh, https://review.openstack.org/#/c/396128/ | 11:06 |
| d0ugal | rakhmerov: Which bug? | 11:06 |
| *** brunograz1 has quit IRC | 11:06 | |
| d0ugal | oh, that one. | 11:06 |
| rakhmerov | what we did on Thursday-Friday | 11:06 |
| d0ugal | Yup | 11:06 |
| rakhmerov | ok | 11:06 |
| rakhmerov | we need to make sure that this is covered | 11:07 |
| rakhmerov | to prevent from regressions | 11:07 |
| d0ugal | Right, I can try adding tests. I need to think about the best way to do that. | 11:07 |
| xavierhardy | btw, shouldn't we merge that on stable/newton ? | 11:10 |
| d0ugal | xavierhardy: Yeah, I was just wondering about backports. | 11:16 |
| d0ugal | rakhmerov: ^ | 11:16 |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:27 | |
| xavierhardy | wait before merging, lazy loading is used in some of the controllers | 11:50 |
| xavierhardy | we need to check those too | 11:50 |
| xavierhardy | TasksController.get | 11:50 |
| xavierhardy | for instance | 11:50 |
| *** brunograz has joined #openstack-mistral | 11:52 | |
| *** sharatss has quit IRC | 11:56 | |
| *** sharatss has joined #openstack-mistral | 12:03 | |
| openstackgerrit | Xavier Hardy proposed openstack/mistral: Fix possible DB race conditions in REST controller https://review.openstack.org/396128 | 12:05 |
| *** shardy is now known as shardy_lunch | 12:09 | |
| *** mgershen has quit IRC | 12:12 | |
| *** dprince has joined #openstack-mistral | 12:21 | |
| d0ugal | rakhmerov: ^ see the update | 12:21 |
| d0ugal | rakhmerov: and backport of one patch: https://review.openstack.org/#/c/397158/ | 12:21 |
| d0ugal | I don't think I'll have time to write tests today, I'm not feeling all that great. | 12:22 |
| d0ugal | and my head is too slow to figure out how I would do it | 12:22 |
| *** catintheroof has joined #openstack-mistral | 12:24 | |
| *** AlexeyAbashkin has quit IRC | 12:35 | |
| *** bobh has joined #openstack-mistral | 13:00 | |
| *** bobh has quit IRC | 13:00 | |
| *** bobh has joined #openstack-mistral | 13:01 | |
| *** hparekh has quit IRC | 13:06 | |
| *** janki has quit IRC | 13:16 | |
| *** janki has joined #openstack-mistral | 13:21 | |
| *** bobh has quit IRC | 13:28 | |
| *** shardy_lunch is now known as shardy | 13:31 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 13:49 | |
| xavierhardy | https://review.openstack.org/#/c/397199/ | 13:51 |
| xavierhardy | cherry picking the Dangling transaction fix | 13:51 |
| xavierhardy | That's my first time cherry picking on Gerrit and OpenStack. I followed this: http://docs.openstack.org/project-team-guide/stable-branches.html . I hope this is fine. | 13:52 |
| xavierhardy | (with conflicts here) | 13:52 |
| *** sharatss has quit IRC | 13:59 | |
| *** AlexeyAbashkin has quit IRC | 14:02 | |
| *** khamtamtun has joined #openstack-mistral | 14:04 | |
| *** clenimar has joined #openstack-mistral | 14:04 | |
| *** bobh has joined #openstack-mistral | 14:07 | |
| *** khamtamtun has quit IRC | 14:16 | |
| *** rbrady has joined #openstack-mistral | 14:23 | |
| *** khamtamtun has joined #openstack-mistral | 14:25 | |
| *** ^Gal^ has joined #openstack-mistral | 14:28 | |
| *** jaosorior has quit IRC | 14:39 | |
| *** jaosorior has joined #openstack-mistral | 14:40 | |
| *** khamtamtun has quit IRC | 14:41 | |
| *** khamtamtun has joined #openstack-mistral | 14:42 | |
| *** khamtamtun has quit IRC | 14:43 | |
| *** catintheroof has quit IRC | 14:48 | |
| *** catintheroof has joined #openstack-mistral | 14:51 | |
| *** sharatss has joined #openstack-mistral | 14:51 | |
| *** bobh has quit IRC | 14:54 | |
| *** sharatss has quit IRC | 14:57 | |
| *** janki has quit IRC | 15:09 | |
| d0ugal | xavierhardy: looks good, just trying to figure out why CI failed. | 15:09 |
| *** rrecio has joined #openstack-mistral | 15:12 | |
| xavierhardy | Yes, I am not under the impression that it's linked to the code, but I might be wrong | 15:16 |
| *** clenimar has quit IRC | 15:22 | |
| *** sharatss has joined #openstack-mistral | 15:43 | |
| *** sharatss has quit IRC | 15:49 | |
| *** sharatss has joined #openstack-mistral | 15:51 | |
| d0ugal | Mistral meeting in 8 minutes in #openstack-meeting | 15:52 |
| *** mgershen has joined #openstack-mistral | 15:54 | |
| d0ugal | Mistral meeting started. | 16:00 |
| *** thrash has joined #openstack-mistral | 16:02 | |
| *** rrecio has quit IRC | 16:03 | |
| *** rrecio_ has joined #openstack-mistral | 16:08 | |
| *** khamtamtun has joined #openstack-mistral | 16:23 | |
| * d0ugal should probably go a bit more slowly :) | 16:24 | |
| ddeja | nah, that was OK | 16:25 |
| sharatss | d0ugal: that was cool! | 16:26 |
| *** sharatss has quit IRC | 16:41 | |
| *** khamtamtun has quit IRC | 16:43 | |
| *** weshay is now known as weshay_brb | 16:46 | |
| *** khamtamtun has joined #openstack-mistral | 16:49 | |
| *** shardy has quit IRC | 16:51 | |
| *** jaosorior has quit IRC | 17:05 | |
| *** jaosorior has joined #openstack-mistral | 17:08 | |
| *** rbrady is now known as rbrady-afk | 17:08 | |
| *** szaher has quit IRC | 17:21 | |
| *** weshay_brb is now known as weshay | 17:29 | |
| *** khamtamtun has quit IRC | 17:29 | |
| *** khamtamtun has joined #openstack-mistral | 17:29 | |
| *** jpich has quit IRC | 17:36 | |
| *** khamtamtun has quit IRC | 17:40 | |
| *** khamtamtun has joined #openstack-mistral | 17:46 | |
| *** jaosorior has quit IRC | 17:51 | |
| *** khamtamtun has quit IRC | 17:57 | |
| *** khamtamtun has joined #openstack-mistral | 17:57 | |
| *** khamtamtun has quit IRC | 18:07 | |
| *** khamtamtun has joined #openstack-mistral | 18:08 | |
| *** mgershen has quit IRC | 18:18 | |
| *** khamtamtun has quit IRC | 18:18 | |
| *** bobh has joined #openstack-mistral | 18:24 | |
| *** khamtamtun has joined #openstack-mistral | 18:40 | |
| *** khamtamtun has quit IRC | 18:50 | |
| *** bobh has quit IRC | 19:02 | |
| *** khamtamtun has joined #openstack-mistral | 19:06 | |
| *** dprince has quit IRC | 19:22 | |
| *** khamtamtun has quit IRC | 19:26 | |
| *** rbrady-afk is now known as rbrady | 19:27 | |
| *** khamtamtun has joined #openstack-mistral | 19:27 | |
| *** thrash is now known as thrash|biab | 19:57 | |
| *** mgershen has joined #openstack-mistral | 20:17 | |
| *** khamtamtun has quit IRC | 20:27 | |
| *** khamtamtun has joined #openstack-mistral | 20:31 | |
| *** thrash|biab is now known as thrash | 20:38 | |
| *** dprince has joined #openstack-mistral | 20:41 | |
| *** khamtamtun has quit IRC | 20:51 | |
| *** khamtamtun has joined #openstack-mistral | 20:53 | |
| *** khamtamtun has quit IRC | 20:55 | |
| *** zaneb has joined #openstack-mistral | 21:07 | |
| *** mgershen has quit IRC | 21:29 | |
| *** mgershen has joined #openstack-mistral | 23:03 | |
| *** dprince has quit IRC | 23:06 | |
| *** mgershen has quit IRC | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!