| *** catintheroof has quit IRC | 00:29 | |
| *** chlong has quit IRC | 00:59 | |
| *** weshay_relocatin is now known as weshay | 01:12 | |
| kong_ | rakhmerov, ddeja, d0ugal, need your review for openstack context suppport in workflow: https://review.openstack.org/#/c/407240/ | 01:40 |
|---|---|---|
| kong_ | we need this capability for internal operation, thanks | 01:41 |
| *** mgershen1 has joined #openstack-mistral | 01:50 | |
| *** mgershen has quit IRC | 01:52 | |
| *** bobh has joined #openstack-mistral | 03:01 | |
| *** thrash is now known as thrash|g0ne | 03:07 | |
| *** jamielennox is now known as jamielennox|away | 03:08 | |
| *** sharatss has quit IRC | 03:11 | |
| *** sharatss has joined #openstack-mistral | 03:11 | |
| *** jamielennox|away is now known as jamielennox | 03:22 | |
| rakhmerov | kong_, hparekh, ddeja: guys, I replied to your comments in https://review.openstack.org/#/c/410211/5 | 05:16 |
| rakhmerov | pls take a look | 05:16 |
| rakhmerov | kong_: reviewing your patch.. | 05:16 |
| openstackgerrit | Merged openstack/mistral-dashboard: Fix docs-gate for mistral-dashboard https://review.openstack.org/412362 | 05:23 |
| *** bobh has quit IRC | 05:40 | |
| *** bobh has joined #openstack-mistral | 05:57 | |
| *** jaosorior has joined #openstack-mistral | 05:57 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Added links to DSL docs in create/update views https://review.openstack.org/411770 | 06:06 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Small adjustments in WithItemsTask https://review.openstack.org/412761 | 06:13 |
| rakhmerov | kong_: I reviewed your patch, left a couple of important comments. | 06:14 |
| *** sharatss has quit IRC | 06:28 | |
| *** sharatss has joined #openstack-mistral | 06:29 | |
| openstackgerrit | Merged openstack/mistral-dashboard: Changed "Task Details" to "Task Execution Details" https://review.openstack.org/410631 | 06:33 |
| *** jaosorior has quit IRC | 06:41 | |
| *** jaosorior has joined #openstack-mistral | 06:42 | |
| openstackgerrit | Merged openstack/mistral: Exclude .tox folder from coverage report https://review.openstack.org/411137 | 07:16 |
| *** Ravikiran_K has joined #openstack-mistral | 07:23 | |
| *** jamielennox is now known as jamielennox|away | 07:28 | |
| *** Ravikiran_K has quit IRC | 07:44 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Use LOG.exception when adding an OpenStack action fails https://review.openstack.org/412430 | 07:56 |
| *** shardy has joined #openstack-mistral | 08:17 | |
| openstackgerrit | yunfeng zhou proposed openstack/mistral-dashboard: add CONTRIBUTING.rst https://review.openstack.org/412865 | 08:19 |
| openstackgerrit | yunfeng zhou proposed openstack/mistral-specs: add CONTRIBUTING.rst https://review.openstack.org/412866 | 08:21 |
| *** ^Gal^ has joined #openstack-mistral | 08:30 | |
| rakhmerov | d0ugal: hi Dougal, do you think we can close https://bugs.launchpad.net/mistral/+bug/1645295 ? | 08:34 |
| openstack | Launchpad bug 1645295 in Mistral "Custom actions can cause database errors if they pass the result class objects" [Critical,In progress] - Assigned to Dougal Matthews (d0ugal) | 08:34 |
| rakhmerov | seems like it's been addressed | 08:34 |
| rakhmerov | can you check pls? | 08:34 |
| d0ugal | rakhmerov: it hasn't been addressed. | 08:35 |
| rakhmerov | really? | 08:35 |
| rakhmerov | I sent a patch that handles serialization errors | 08:35 |
| rakhmerov | I thought it should fix it | 08:35 |
| d0ugal | rakhmerov: that was a different problem, I think | 08:35 |
| rakhmerov | ok | 08:35 |
| d0ugal | but I am not sure - did you add a test case to cover this scenario? | 08:35 |
| d0ugal | but sure, I can check at some point unless you want to | 08:36 |
| rakhmerov | I didn't | 08:36 |
| d0ugal | ok, so we should at least add a test for this I think. | 08:36 |
| rakhmerov | I am working on a different stuff | 08:36 |
| rakhmerov | yes, true | 08:36 |
| rakhmerov | ok, I won't close it | 08:36 |
| d0ugal | Thanks | 08:36 |
| rakhmerov | I'm just reviewing all the tickets now | 08:37 |
| *** jaosorior has quit IRC | 08:41 | |
| *** jaosorior has joined #openstack-mistral | 08:43 | |
| *** jpich has joined #openstack-mistral | 08:54 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Small adjustments in WithItemsTask https://review.openstack.org/412761 | 08:57 |
| ddeja | rakhmerov: Hi, I replied to your comment in https://review.openstack.org/#/c/410211/5 | 09:01 |
| rakhmerov | hi | 09:02 |
| rakhmerov | but it's less effective | 09:02 |
| rakhmerov | when you do list(iterator_kind_of_thing) it has to iterate through all items | 09:02 |
| rakhmerov | right? | 09:02 |
| rakhmerov | ddeja: ^\ | 09:02 |
| ddeja | yes | 09:02 |
| rakhmerov | whereas we need only one, the first one | 09:03 |
| ddeja | hm | 09:03 |
| rakhmerov | I know it looks slightly weird | 09:03 |
| rakhmerov | :) | 09:03 |
| rakhmerov | I was surprised that it doesn't allow access by inde | 09:04 |
| rakhmerov | x | 09:04 |
| ddeja | I'm sure there must be a better way to achive this | 09:04 |
| rakhmerov | I didn't find it | 09:04 |
| rakhmerov | seriously | 09:04 |
| ddeja | this is so confusing | 09:04 |
| rakhmerov | spent 10-15 mins digging in what this structure has (dict_values) | 09:04 |
| rakhmerov | I know | 09:04 |
| rakhmerov | welcome to Python :) | 09:04 |
| d0ugal | next? | 09:05 |
| * rakhmerov renat didn't mean to offend those who loves python | 09:05 | |
| rakhmerov | d0ugal: what about next? | 09:05 |
| d0ugal | rakhmerov: it will get you the first (next) item from an iterator | 09:05 |
| d0ugal | unfortunately it is something that changed in Python 3, so supporting both is a bit ugly :( | 09:07 |
| rakhmerov | d0ugal: what's the full syntax? | 09:08 |
| rakhmerov | it doesn't have method 'next' | 09:08 |
| d0ugal | next(with_items_values.values()) | 09:08 |
| d0ugal | python 3 ^ | 09:08 |
| d0ugal | six.next(iter(with_items_values.values())) | 09:09 |
| d0ugal | That should work in 2 and 3 | 09:09 |
| rakhmerov | :) | 09:09 |
| rakhmerov | ddeja, d0ugal: it doesn't look much better to me :) | 09:10 |
| rakhmerov | but ok | 09:10 |
| d0ugal | Indeed, it doesn't | 09:10 |
| rakhmerov | I hate using six | 09:10 |
| rakhmerov | honestly | 09:10 |
| d0ugal | it would be better if we only supported python 3 | 09:10 |
| d0ugal | python 2 would be | 09:10 |
| d0ugal | next(iter(with_items_values.values())) | 09:10 |
| d0ugal | oops | 09:10 |
| rakhmerov | d0ugal: it would be better if python supported backwards compatibility | 09:10 |
| rakhmerov | IMO | 09:10 |
| d0ugal | iter(with_items_values.values()).next() | 09:10 |
| d0ugal | rakhmerov: yeah, please make that happen ;) | 09:11 |
| rakhmerov | :) | 09:11 |
| rakhmerov | iter(d.values()).next() | 09:11 |
| rakhmerov | Traceback (most recent call last): | 09:11 |
| rakhmerov | File "<stdin>", line 1, in <module> | 09:11 |
| rakhmerov | AttributeError: 'dict_valueiterator' object has no attribute 'next' | 09:11 |
| ddeja | rakhmerov, d0ugal, yup, I found out the same with _gryf | 09:11 |
| ddeja | but hm, it is also not looking nice :/ | 09:12 |
| rakhmerov | yep | 09:12 |
| d0ugal | ddeja: _gryf? | 09:13 |
| ddeja | my teammate, Renat knows him from previous summits ;) | 09:13 |
| rakhmerov | ddeja, d0ugal: this also doesn't work, any other ideas? | 09:13 |
| d0ugal | aha | 09:13 |
| ddeja | d0ugal: and Python guru ;) | 09:13 |
| rakhmerov | yes, I do | 09:13 |
| rakhmerov | d0ugal has seen him too in Barcelona | 09:13 |
| d0ugal | rakhmerov: you didn't use what I suggested | 09:13 |
| d0ugal | rakhmerov: you need six.next | 09:13 |
| d0ugal | next is a global function in python 3 and an iterator function in python 2 | 09:14 |
| rakhmerov | ok, let me try with six, I tried your last one | 09:14 |
| d0ugal | six.next(iter(d.values()) | 09:14 |
| d0ugal | sorry, I shouldn't have given examples in 2 and 3 :-D | 09:14 |
| rakhmerov | TypeError: 'list' object cannot be interpreted as an integer | 09:17 |
| d0ugal | lol | 09:17 |
| d0ugal | let me get an example | 09:17 |
| rakhmerov | also doesn't work | 09:17 |
| d0ugal | You need to show me what code you are using | 09:17 |
| d0ugal | because it does work :) | 09:18 |
| d0ugal | rakhmerov: http://paste.openstack.org/show/592877/ | 09:18 |
| d0ugal | but maybe I am not understanding the problem | 09:19 |
| rakhmerov | d0ugal: in what python did you do this? | 09:19 |
| d0ugal | rakhmerov: 2.7 and 3.5 | 09:20 |
| rakhmerov | wait a sec, may be I made a mistake somewhere | 09:20 |
| d0ugal | Will the dictionary ever be empty? | 09:22 |
| rakhmerov | yeah, I made a mistake | 09:22 |
| rakhmerov | sorry | 09:22 |
| rakhmerov | I needed to ad [0] at the end since I have a list in place of your 1 | 09:22 |
| d0ugal | aha | 09:23 |
| rakhmerov | ok, let me change that and rerun all the tests | 09:24 |
| rakhmerov | hah!! | 09:24 |
| rakhmerov | ooh, np | 09:24 |
| rakhmerov | sorry ) | 09:24 |
| rakhmerov | ddeja, d0ugal, kong_: ok, please review again | 09:32 |
| rakhmerov | now it's really better (thanks to d0ugal) | 09:33 |
| ddeja | rakhmerov: great :D | 09:35 |
| rakhmerov | :) | 09:35 |
| ddeja | rakhmerov: one question thou | 09:36 |
| rakhmerov | нуы | 09:37 |
| ddeja | did you tested if it works when with_items_values is empty | 09:37 |
| rakhmerov | yes | 09:37 |
| rakhmerov | there's a test for that, yes | 09:37 |
| rakhmerov | let me check just in case | 09:37 |
| * ddeja should learn russian, it shouldn't be this hard ;) | 09:37 | |
| rakhmerov | :)) | 09:37 |
| rakhmerov | sorry, I just didn't switch my lang | 09:37 |
| rakhmerov | when I was typing "yes" | 09:38 |
| ddeja | rakhmerov: sure, no problem | 09:38 |
| rakhmerov | ddeja: yes, I checked | 09:39 |
| rakhmerov | there's such test | 09:39 |
| rakhmerov | test_with_items_empty_list | 09:39 |
| ddeja | I just cannot read cyrillic, wheareas my parents, as an example, they can. I was thinking that I should also learn if I'd like to go east for vacation one year :) | 09:39 |
| ddeja | rakhmerov: OK, thanks :) | 09:39 |
| rakhmerov | ddeja: come to visit where I leave :) | 09:40 |
| rakhmerov | it's fun here now | 09:40 |
| rakhmerov | -30 C is not so rare temperature ;) | 09:40 |
| rakhmerov | where I live | 09:40 |
| ddeja | rakhmerov: :o | 09:40 |
| d0ugal | wow | 09:41 |
| ddeja | I'd rather get my +5 | 09:41 |
| rakhmerov | right now is warm, only -10 | 09:41 |
| d0ugal | 1C here now | 09:41 |
| ddeja | well, it sometimes drops to -20, but it's only a few days in a winter | 09:41 |
| rakhmerov | usually Jan is very tough | 09:41 |
| d0ugal | ddeja: Where are you? | 09:41 |
| rakhmerov | it goes down to -45 | 09:41 |
| d0ugal | lol | 09:41 |
| * d0ugal should never complain about the cold in here | 09:42 | |
| ddeja | d0ugal: Gdańsk, Poland, at the seacoast of Baltic sea | 09:42 |
| rakhmerov | :)) | 09:42 |
| d0ugal | ddeja: oh, cool :) | 09:42 |
| rakhmerov | I'd like to go there one day | 09:42 |
| ddeja | d0ugal: and you? ;) | 09:42 |
| d0ugal | ddeja: Glasgow, Scotland | 09:42 |
| rakhmerov | never been to Poland | 09:42 |
| rakhmerov | and Scotland too :) | 09:42 |
| d0ugal | Yeah, I would like to visit Poland | 09:43 |
| ddeja | rakhmerov: that would be great! | 09:43 |
| d0ugal | and Russia, but maybe not when it is -45 ;) | 09:43 |
| rakhmerov | d0ugal: summer is nice here | 09:43 |
| rakhmerov | up to +35 | 09:43 |
| rakhmerov | and it's a dry climate here | 09:43 |
| rakhmerov | which is good | 09:43 |
| d0ugal | wow, that is a big change | 09:44 |
| rakhmerov | but, you know, you need to be more specific when you say "Russia" :) | 09:44 |
| rakhmerov | it's big | 09:44 |
| d0ugal | haha, indeed | 09:44 |
| rakhmerov | in Moscow it's usually warm any time | 09:44 |
| d0ugal | I don't know it well enough to be more specific ;) | 09:44 |
| rakhmerov | yeah, ok | 09:44 |
| d0ugal | but Moscow always seemed interesting | 09:44 |
| rakhmerov | I live in Western Siberia | 09:44 |
| rakhmerov | which is considered a tough climate area | 09:45 |
| ddeja | d0ugal: the closest is the Kaliningrad | 09:45 |
| d0ugal | The weather here it between 0 and 20 almost all year | 09:45 |
| ddeja | but I'm not sure how russian is that area :) | 09:45 |
| rakhmerov | yeah, I went to Kaliningrad a few years ago | 09:45 |
| d0ugal | we never really get that cold or that warm :( | 09:45 |
| ddeja | oh, so you were really close | 09:45 |
| rakhmerov | pretty nice place (at least what's left after all the bombings) | 09:45 |
| ddeja | a lot of people from that city come to Gdańsk for shopping | 09:45 |
| rakhmerov | ddeja: yes, I visited Baltic Sea also, yes | 09:46 |
| rakhmerov | I know, yep :) | 09:46 |
| rakhmerov | for them it's very easy for some reason | 09:46 |
| ddeja | since you don't need visas to get there :) | 09:46 |
| rakhmerov | they don't need even visa AFAIK | 09:46 |
| rakhmerov | right | 09:46 |
| ddeja | yes | 09:46 |
| ddeja | but not to all Poland | 09:46 |
| rakhmerov | it's kind of like "special economic zone" | 09:46 |
| ddeja | only some states | 09:46 |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: Workflow list - added missing fields https://review.openstack.org/412517 | 09:47 |
| *** Ravikiran_K has joined #openstack-mistral | 09:53 | |
| *** ist has quit IRC | 09:58 | |
| rakhmerov | ddeja: http://logs.openstack.org/11/410211/6/check/gate-mistral-devstack-dsvm-kombu-nv/3500a9c/logs/testr_results.html.gz | 10:26 |
| rakhmerov | something wrong with neutron and keystone plugins? | 10:26 |
| ddeja | rakhmerov: looking | 10:27 |
| rakhmerov | ok | 10:27 |
| rakhmerov | I didn't look carefully, just noticed | 10:28 |
| ddeja | rakhmerov: I need to see the full mistral log | 10:29 |
| rakhmerov | sure | 10:29 |
| ddeja | but it's strange | 10:29 |
| ddeja | since the error message suggests simultanous read's of something | 10:29 |
| ddeja | but kombu driver is one-thread as for now... | 10:30 |
| ddeja | signle-thread* | 10:30 |
| ddeja | rakhmerov: I'll take a look once jenkins end all tests | 10:31 |
| rakhmerov | ok, np | 10:31 |
| rakhmerov | once you're comfortable.. | 10:32 |
| *** mgershen1 has quit IRC | 10:40 | |
| *** mgershen has joined #openstack-mistral | 10:43 | |
| rakhmerov | kong_: here? | 10:51 |
| *** Ravikiran_K has quit IRC | 10:56 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Added links to DSL docs in create/update views https://review.openstack.org/411770 | 10:57 |
| *** mgershen has quit IRC | 11:03 | |
| *** mgershen has joined #openstack-mistral | 11:34 | |
| *** thrash|g0ne is now known as thrash | 11:37 | |
| openstackgerrit | Merged openstack/mistral: Refactor and improve 'with-items' algorithms https://review.openstack.org/410211 | 11:38 |
| *** ist has joined #openstack-mistral | 11:43 | |
| *** Ravikiran_K has joined #openstack-mistral | 12:06 | |
| *** ist has quit IRC | 12:09 | |
| *** shardy is now known as shardy_lunch | 12:11 | |
| *** mgershen has quit IRC | 12:18 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: Workflow list - added missing fields https://review.openstack.org/412517 | 12:24 |
| *** mgershen has joined #openstack-mistral | 12:25 | |
| openstackgerrit | Jeremy Liu proposed openstack/python-mistralclient: Keystone v3 needs extra parameters https://review.openstack.org/409675 | 12:27 |
| d0ugal | rakhmerov: I thought of a better solution :) | 12:30 |
| d0ugal | {'a': []}.popitem() | 12:31 |
| *** dprince has joined #openstack-mistral | 12:35 | |
| *** catintheroof has joined #openstack-mistral | 12:37 | |
| *** chlong has joined #openstack-mistral | 12:53 | |
| *** shardy_lunch is now known as shardy | 12:55 | |
| _gryf | d0ugal, rakhmerov, simply a = {'a': [1,2,3]}; len(a[next(iter(a))]) should do in both py2 and py3 if we don't want to modify that dictionary | 13:30 |
| d0ugal | _gryf: Why is that better than popitem()? | 13:31 |
| d0ugal | oh, I guess beacuse it modifies | 13:32 |
| _gryf | yup | 13:32 |
| d0ugal | honestly, I prefer next(iter(a.values())) | 13:34 |
| d0ugal | but *shrug* | 13:34 |
| _gryf | yeah | 13:34 |
| _gryf | in a case where dictionary is reasonably small | 13:34 |
| _gryf | that can make it | 13:35 |
| ddeja | _gryf: that particular dictionary may be quite big | 13:35 |
| d0ugal | it would have to be huge for that to be an issue | 13:35 |
| _gryf | so getting the first item is all we need i guess | 13:36 |
| d0ugal | See openstack-dev "[openstack-dev] [all][python3] use of six.iteritems()" | 13:37 |
| d0ugal | ^ a recent discussion about perf of dict items/iteritems | 13:38 |
| * _gryf is reading | 13:38 | |
| _gryf | so the rough conclusion was to not use (or overuse) six.iteritems | 13:45 |
| _gryf | i tend to agree, especially i didn't use six.iteritems in my sample :) | 13:46 |
| d0ugal | Indeed | 13:53 |
| *** catinthe_ has joined #openstack-mistral | 14:06 | |
| *** catintheroof has quit IRC | 14:08 | |
| *** chlong has quit IRC | 14:16 | |
| *** jaosorior has quit IRC | 14:48 | |
| *** bobh has quit IRC | 15:01 | |
| *** dprince has quit IRC | 15:31 | |
| *** harlowja has joined #openstack-mistral | 15:49 | |
| *** pradk has joined #openstack-mistral | 15:51 | |
| *** chlong has joined #openstack-mistral | 15:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/413149 | 15:59 |
| *** chlong has quit IRC | 16:01 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: Fixed: Dashboard: "Run action" functionality doesn't work https://review.openstack.org/413152 | 16:02 |
| *** chlong has joined #openstack-mistral | 16:16 | |
| *** bobh has joined #openstack-mistral | 16:23 | |
| *** chlong has quit IRC | 16:28 | |
| *** ^Gal^ has quit IRC | 16:33 | |
| *** ^Gal^_ has joined #openstack-mistral | 16:33 | |
| *** ^Gal^_ is now known as ^Gal^ | 16:33 | |
| *** bobh has quit IRC | 16:34 | |
| *** catintheroof has joined #openstack-mistral | 16:39 | |
| *** ^Gal^ has quit IRC | 16:42 | |
| *** catinthe_ has quit IRC | 16:42 | |
| *** harlowja has quit IRC | 16:42 | |
| *** chlong has joined #openstack-mistral | 16:42 | |
| *** jpich has quit IRC | 16:50 | |
| *** Ravikiran_K has quit IRC | 17:21 | |
| *** bobh has joined #openstack-mistral | 17:25 | |
| *** dprince has joined #openstack-mistral | 17:46 | |
| *** bobh has quit IRC | 17:49 | |
| *** harlowja has joined #openstack-mistral | 17:53 | |
| *** bobh has joined #openstack-mistral | 17:59 | |
| *** catinthe_ has joined #openstack-mistral | 18:03 | |
| *** catintheroof has quit IRC | 18:06 | |
| *** mgershen has quit IRC | 18:33 | |
| *** bobh has quit IRC | 18:39 | |
| *** bobh has joined #openstack-mistral | 18:41 | |
| *** chlong has quit IRC | 18:56 | |
| *** shardy has quit IRC | 19:03 | |
| *** bobh has quit IRC | 19:09 | |
| *** chlong has joined #openstack-mistral | 19:13 | |
| *** harlowja has quit IRC | 19:35 | |
| *** catintheroof has joined #openstack-mistral | 19:37 | |
| *** catinthe_ has quit IRC | 19:40 | |
| *** weshay is now known as weshay_relocate | 19:44 | |
| kong_ | rakhmerov: hi, i was not here last night. please feel free to leave message to me | 19:59 |
| kong_ | rakhmerov, ddeja, i saw your comments for openstack context stuff, thanks for that. i will reconsider the implementation today. | 20:01 |
| *** clenimar has quit IRC | 20:12 | |
| *** chlong has quit IRC | 20:15 | |
| *** chlong has joined #openstack-mistral | 20:27 | |
| *** ist has joined #openstack-mistral | 20:29 | |
| *** weshay_relocate is now known as weshay | 20:32 | |
| *** ist has quit IRC | 20:40 | |
| *** jamielennox|away is now known as jamielennox | 20:44 | |
| *** catintheroof has quit IRC | 20:47 | |
| *** shardy has joined #openstack-mistral | 21:20 | |
| *** weshay is now known as weshay_afk | 21:33 | |
| *** chlong has quit IRC | 21:46 | |
| *** dprince has quit IRC | 21:48 | |
| *** shardy has quit IRC | 22:02 | |
| *** chlong has joined #openstack-mistral | 22:57 | |
| *** pradk has quit IRC | 23:29 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!