| kong_ | rakhmerov, ddeja, d0ugal, could you please review the patch series: https://review.openstack.org/#/q/topic:bug/1633345 | 00:01 |
|---|---|---|
| *** jrist_ has joined #openstack-mistral | 00:09 | |
| *** jrist has quit IRC | 00:10 | |
| *** gongysh has quit IRC | 00:47 | |
| *** kong_ is now known as kong | 01:00 | |
| *** jamielennox is now known as jamielennox|away | 01:02 | |
| *** jamielennox|away is now known as jamielennox | 01:21 | |
| *** gongysh has joined #openstack-mistral | 02:00 | |
| *** harlowja has quit IRC | 03:05 | |
| *** ruhe has quit IRC | 03:05 | |
| *** ruhe has joined #openstack-mistral | 03:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/415969 | 05:07 |
| *** jamielennox is now known as jamielennox|away | 05:23 | |
| *** jamielennox|away is now known as jamielennox | 05:30 | |
| *** sharatss has joined #openstack-mistral | 05:55 | |
| openstackgerrit | Merged openstack/python-mistralclient: Add tests for filters in CLI list commands https://review.openstack.org/415158 | 06:03 |
| *** ist has joined #openstack-mistral | 06:17 | |
| *** _gryf_ has joined #openstack-mistral | 06:53 | |
| *** _gryf_ is now known as gryf | 06:53 | |
| *** gryf has quit IRC | 06:53 | |
| *** sharatss has quit IRC | 07:42 | |
| *** openstackgerrit has quit IRC | 07:50 | |
| *** sharatss has joined #openstack-mistral | 08:18 | |
| *** shardy has joined #openstack-mistral | 08:35 | |
| *** jpich has joined #openstack-mistral | 08:41 | |
| d0ugal | kong: will do! | 08:46 |
| d0ugal | It looks like the Mistral gate is broken? | 08:47 |
| d0ugal | https://review.openstack.org/#/c/413696/ | 08:47 |
| *** openstackgerrit has joined #openstack-mistral | 08:47 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Gate test https://review.openstack.org/413696 | 08:47 |
| d0ugal | rebasing it to see if that changes anything | 08:47 |
| d0ugal | but the failures in patchset 2 look real | 08:47 |
| ddeja | kong: sure, will do | 08:54 |
| ddeja | d0ugal: Hi, where did it start? | 08:54 |
| ddeja | when* | 08:54 |
| *** jtomasek has quit IRC | 08:58 | |
| d0ugal | ddeja: not sure :) | 09:01 |
| d0ugal | ddeja: I just noticed one of my other patches started failing for a new reason that looked unrelated | 09:01 |
| d0ugal | this does seem to be happening more lately :/ | 09:01 |
| d0ugal | ddeja: kong's patches passed, but they are based on a previous commit. so it must have been introduced between fca666a57c8e3578cc7ecf851b64f7c3ff501ea4 and HEAD | 09:04 |
| d0ugal | This one passed: https://review.openstack.org/#/c/407240/ | 09:05 |
| *** jtomasek has joined #openstack-mistral | 09:05 | |
| d0ugal | ... and that leaves only one commit I think | 09:06 |
| d0ugal | hmm | 09:06 |
| * d0ugal is confused | 09:06 | |
| *** tuan_ has joined #openstack-mistral | 09:09 | |
| ddeja | me too :/ | 09:31 |
| d0ugal | ddeja: so it is an ordering bug | 09:31 |
| d0ugal | ddeja: and it doesn't fail every time | 09:31 |
| d0ugal | sometimes these are the other way around: https://github.com/openstack/mistral/blob/master/mistral/tests/unit/engine/test_reverse_workflow_rerun.py#L154-L155 | 09:31 |
| ddeja | mhm | 09:32 |
| ddeja | it may happening due to recent change in the db | 09:32 |
| ddeja | oh, I see | 09:32 |
| ddeja | Then I'm 100% sure it is happening due to that change | 09:32 |
| d0ugal | Which change? | 09:32 |
| ddeja | droping of the microseconds from the DB | 09:33 |
| d0ugal | aha | 09:33 |
| *** goutham_pratapa has joined #openstack-mistral | 09:33 | |
| d0ugal | Why did we drop that? :) | 09:33 |
| ddeja | yes | 09:33 |
| *** jtomasek has quit IRC | 09:33 | |
| *** openstackgerrit has quit IRC | 09:33 | |
| ddeja | d0ugal: https://review.openstack.org/#/c/406143/ | 09:34 |
| ddeja | d0ugal: I'll send a patch to fix that unit test | 09:35 |
| d0ugal | oh, I remember now | 09:35 |
| d0ugal | it is hard to remember anything from last year :P | 09:35 |
| *** jtomasek has joined #openstack-mistral | 09:36 | |
| *** goutham_pratapa has quit IRC | 09:37 | |
| *** openstackgerrit has joined #openstack-mistral | 10:04 | |
| openstackgerrit | Bertrand Lallau proposed openstack/mistral: Move mock requirement to test-requirements.txt https://review.openstack.org/416915 | 10:04 |
| kong | ddeja, d0ugal, thanks you guys | 10:09 |
| *** openstack has joined #openstack-mistral | 10:15 | |
| *** ^Gal^ has joined #openstack-mistral | 10:24 | |
| *** gongysh has quit IRC | 10:31 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for failing kombu dsvm gate https://review.openstack.org/414533 | 10:47 |
| ddeja | kong: I can take a look on those patches, but the spec is not merged yet, so we cannot merge those IMO | 10:50 |
| *** sharatss has quit IRC | 11:03 | |
| *** thrash|g0ne is now known as thrash | 11:06 | |
| d0ugal | ddeja: Yeah, I think there is some feedback from rakhmerov that needs to be addressed too? | 11:08 |
| d0ugal | The first patch has a -1 for example. | 11:08 |
| d0ugal | /cc kong | 11:08 |
| d0ugal | ddeja: does this test pass for you locally? | 11:09 |
| d0ugal | tox -e py27 mistral.tests.unit.services.test_trigger_service.TriggerServiceV2Test.test_trigger_create | 11:09 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Testing trigger get_next_execution_time https://review.openstack.org/416938 | 11:16 |
| ist | hello, it seems new novaclient (7.0.0) has got an authentication issue in case of token authentication is used. I just created a novaclient bug for it: https://bugs.launchpad.net/python-novaclient/+bug/1654183 | 11:21 |
| openstack | Launchpad bug 1654183 in python-novaclient "Token based authentication in Client class does not work" [Undecided,New] | 11:21 |
| ist | do anyone faced this issue already? | 11:21 |
| *** sharatss has joined #openstack-mistral | 11:22 | |
| ist | new NovaClient released at 22. Dec. | 11:22 |
| d0ugal | ist: I don't think anyone is working on it | 11:25 |
| d0ugal | ist: I've not seen chatter in here, bugs or patches anyway | 11:25 |
| d0ugal | ist: but I am a bit confused, is this a Mistral bug? | 11:27 |
| d0ugal | it looks like you might be in the wrong channel :) | 11:27 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Testing trigger get_next_execution_time https://review.openstack.org/416938 | 11:28 |
| ist | no it is not a mistral bug, it is a novaclient bug, just it affects mistral also, due to nova actions are not working | 11:29 |
| ist | if newest nova client is installed beside mistral | 11:29 |
| d0ugal | ist: right, makes sense. | 11:30 |
| ddeja | d0ugal: no, it's not passing | 11:42 |
| ddeja | i found a bug in it yesterday | 11:42 |
| ddeja | and also in 2 others, also related to the trigger tests | 11:42 |
| d0ugal | ddeja: hah, fun | 11:43 |
| d0ugal | ddeja: I am trying to understand why it passes in CI | 11:43 |
| ddeja | because it works | 11:43 |
| ddeja | if local timezone is UTC | 11:43 |
| d0ugal | ddeja: I am in UTC :) | 11:44 |
| ddeja | that's weird then | 11:44 |
| *** tuan_ has quit IRC | 11:44 | |
| ddeja | so maybe it works in some other time zone | 11:44 |
| ddeja | or maybe when no timezone is set | 11:44 |
| ddeja | not sure | 11:45 |
| *** gongysh has joined #openstack-mistral | 11:45 | |
| ddeja | but basically, it misses the time by one hour on my setup | 11:45 |
| d0ugal | ddeja: well, my machine is set to Europe/London | 11:45 |
| d0ugal | that just happens to be the same as UTC right now | 11:45 |
| ddeja | d0ugal: yes, I know | 11:46 |
| *** ^Gal^ has quit IRC | 11:46 | |
| ddeja | hmm, maybe it works only if it is set directly to UTC 0 | 11:46 |
| d0ugal | yeah, that is what I mean | 11:46 |
| ddeja | but that would be weird | 11:47 |
| d0ugal | indeed. | 11:47 |
| ddeja | if it works if TZ = UTC0 but not if TZ = London | 11:47 |
| ddeja | since it is same in winter | 11:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Testing trigger get_next_execution_time https://review.openstack.org/416938 | 11:51 |
| *** tuan_ has joined #openstack-mistral | 12:01 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Use oslo_utils.timeutils to convert a datetime to UTC https://review.openstack.org/416938 | 12:04 |
| d0ugal | ddeja: ^ I think that'll fix it. The test passed locally for me. | 12:05 |
| d0ugal | The oslo_utils method was quite different from ours. https://github.com/openstack/oslo.utils/blob/master/oslo_utils/timeutils.py#L100 | 12:05 |
| * d0ugal wonders how to write a test for it | 12:06 | |
| ddeja | d0ugal: but hmm, It may work | 12:08 |
| ddeja | but I'm not sure if it is the right fix | 12:08 |
| ddeja | the story of introducing this method was to change local time to UTC ones | 12:09 |
| d0ugal | ddeja: that is what normalize_time does? | 12:09 |
| ddeja | oh | 12:09 |
| ddeja | if so, it should be ok | 12:09 |
| ddeja | I hope | 12:10 |
| d0ugal | ddeja: https://github.com/openstack/oslo.utils/blob/master/oslo_utils/timeutils.py#L101 | 12:10 |
| d0ugal | :-D | 12:10 |
| * d0ugal will bbiab | 12:11 | |
| *** gongysh has quit IRC | 12:14 | |
| *** ^Gal^ has joined #openstack-mistral | 12:18 | |
| ddeja | d0ugal: I'm afraid it is not working | 12:19 |
| ddeja | it's not converting time from my UTC+1 to UTC+0 | 12:19 |
| ddeja | whereas the method that is used right now does it | 12:19 |
| ddeja | just the tests are not implemented correctly | 12:20 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for failing kombu dsvm gate https://review.openstack.org/414533 | 12:31 |
| *** catintheroof has quit IRC | 12:38 | |
| *** catintheroof has joined #openstack-mistral | 12:44 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix unit test that rely on order of return from DB https://review.openstack.org/416965 | 12:49 |
| *** catintheroof has quit IRC | 12:57 | |
| *** catintheroof has joined #openstack-mistral | 12:58 | |
| *** shardy has quit IRC | 13:02 | |
| *** dprince has joined #openstack-mistral | 13:02 | |
| *** catintheroof has quit IRC | 13:02 | |
| *** catintheroof has joined #openstack-mistral | 13:04 | |
| *** tuan_ has quit IRC | 13:06 | |
| *** tuan_ has joined #openstack-mistral | 13:10 | |
| *** catintheroof has quit IRC | 13:11 | |
| *** d0ugal has quit IRC | 13:34 | |
| *** d0ugal has joined #openstack-mistral | 13:35 | |
| *** catintheroof has joined #openstack-mistral | 13:47 | |
| *** bobh has joined #openstack-mistral | 13:48 | |
| *** tuan_ has quit IRC | 13:56 | |
| *** shardy has joined #openstack-mistral | 14:28 | |
| *** tuan_ has joined #openstack-mistral | 14:31 | |
| *** ist has quit IRC | 15:00 | |
| *** chlong has joined #openstack-mistral | 15:05 | |
| *** sharatss has quit IRC | 15:05 | |
| *** sharatss has joined #openstack-mistral | 15:06 | |
| *** catintheroof has quit IRC | 15:32 | |
| *** d0ugal has quit IRC | 15:38 | |
| *** d0ugal has joined #openstack-mistral | 15:41 | |
| *** sharatss has quit IRC | 16:01 | |
| *** sharatss has joined #openstack-mistral | 16:01 | |
| *** bobh has quit IRC | 16:01 | |
| *** tuan_ has quit IRC | 16:27 | |
| *** catintheroof has joined #openstack-mistral | 16:32 | |
| *** weshay is now known as weshay_errand | 16:37 | |
| *** ^Gal^ has quit IRC | 16:51 | |
| *** ^Gal^_ has joined #openstack-mistral | 16:51 | |
| *** ^Gal^_ is now known as ^Gal^ | 16:51 | |
| *** ^Gal^ has quit IRC | 16:55 | |
| *** bobh has joined #openstack-mistral | 17:02 | |
| *** bobh has quit IRC | 17:08 | |
| *** jpich has quit IRC | 17:14 | |
| *** sharatss has quit IRC | 17:14 | |
| *** sharatss has joined #openstack-mistral | 17:14 | |
| *** rbrady is now known as rbrady-afk | 18:03 | |
| *** bobh has joined #openstack-mistral | 18:03 | |
| *** bobh has quit IRC | 18:08 | |
| *** weshay_errand is now known as weshay | 18:17 | |
| *** sharatss has quit IRC | 18:36 | |
| *** sharatss has joined #openstack-mistral | 18:36 | |
| *** sharatss has quit IRC | 18:46 | |
| *** sharatss has joined #openstack-mistral | 18:47 | |
| *** harlowja has joined #openstack-mistral | 19:16 | |
| *** ist has joined #openstack-mistral | 19:51 | |
| *** ist has quit IRC | 19:55 | |
| *** chlong has quit IRC | 20:03 | |
| *** bobh has joined #openstack-mistral | 20:05 | |
| *** bobh has quit IRC | 20:09 | |
| *** rbrady-afk is now known as rbrady | 20:10 | |
| *** ist has joined #openstack-mistral | 20:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/415969 | 20:23 |
| *** sharatss has quit IRC | 20:32 | |
| *** sharatss has joined #openstack-mistral | 20:32 | |
| *** catintheroof has quit IRC | 20:45 | |
| *** thrash has quit IRC | 21:55 | |
| *** dprince has quit IRC | 21:58 | |
| *** thrash has joined #openstack-mistral | 22:01 | |
| *** thrash has joined #openstack-mistral | 22:01 | |
| *** shardy_ has joined #openstack-mistral | 22:27 | |
| *** shardy_ has quit IRC | 22:28 | |
| *** shardy has quit IRC | 23:34 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!