| *** jamielennox|away is now known as jamielennox | 00:16 | |
| *** rbrady has quit IRC | 00:28 | |
| *** fultonj has joined #openstack-mistral | 01:19 | |
| *** fultonj has quit IRC | 01:28 | |
| *** gongysh has joined #openstack-mistral | 02:56 | |
| *** zhenguo has joined #openstack-mistral | 03:37 | |
| *** gongysh has quit IRC | 04:12 | |
| *** sharatss has joined #openstack-mistral | 04:33 | |
| *** jaosorior has joined #openstack-mistral | 05:41 | |
| *** pcastets has joined #openstack-mistral | 06:45 | |
| *** sharatss has quit IRC | 06:59 | |
| *** sharatss has joined #openstack-mistral | 07:00 | |
| *** rbux has joined #openstack-mistral | 07:01 | |
| *** Kevin_Zheng_ has joined #openstack-mistral | 07:14 | |
| *** Kevin_Zheng_ is now known as Kevin_Zheng | 07:17 | |
| *** ist has joined #openstack-mistral | 07:39 | |
| *** shardy has joined #openstack-mistral | 07:56 | |
| *** sharatss has quit IRC | 07:57 | |
| *** sharatss has joined #openstack-mistral | 07:58 | |
| ist | Hi, | 07:59 |
|---|---|---|
| ist | I just reported a problem, someone could check it: https://bugs.launchpad.net/mistral/+bug/1668523 | 07:59 |
| openstack | Launchpad bug 1668523 in Mistral "Workflow could not be cancelled if definition is deleted" [Undecided,New] | 07:59 |
| *** gongysh has joined #openstack-mistral | 08:08 | |
| *** shardy has quit IRC | 08:25 | |
| *** rbux has quit IRC | 08:36 | |
| *** rbux has joined #openstack-mistral | 08:37 | |
| *** rbux has quit IRC | 08:40 | |
| *** rbux has joined #openstack-mistral | 08:42 | |
| *** jpich has joined #openstack-mistral | 08:58 | |
| *** sharatss has quit IRC | 09:19 | |
| *** jaosorior has quit IRC | 09:39 | |
| *** jaosorior has joined #openstack-mistral | 09:40 | |
| *** gongysh has quit IRC | 09:46 | |
| d0ugal | ist: looking. | 10:12 |
| d0ugal | rakhmerov: when are you back? | 10:12 |
| ddeja | d0ugal: I belive rakhmerov will be back next week | 10:13 |
| d0ugal | ddeja: thanks - I didn't realise he was taking the full week off :) | 10:13 |
| d0ugal | slacker ;) | 10:13 |
| d0ugal | ist: Are you planning on working on that bug? | 10:22 |
| ist | we need a quick fix in our mistral copy, but during that we could discuss what would be the best solution | 10:24 |
| ist | in long term | 10:25 |
| d0ugal | ist: do you have the traceback from the logs? | 10:32 |
| *** pcastets has quit IRC | 10:32 | |
| d0ugal | ist: I guess the problem is here: https://github.com/openstack/mistral/blob/master/mistral/engine/workflow_handler.py#L50 | 10:35 |
| ist | I attached the stack trace to the bug.... | 10:36 |
| d0ugal | ist: thanks! | 10:36 |
| ist | yes exactly | 10:36 |
| ist | as I see this Workflow object uses wf_definition parameter only in case of execute call, so definition shall not have a mandatory constructor parameter | 10:38 |
| ist | It seems the correction could be very easy, just move wd_def parameter of Workflows constructor to parameter of start method. | 10:43 |
| ist | I will do it now | 10:43 |
| d0ugal | cool | 10:43 |
| d0ugal | I am trying that too :) | 10:43 |
| *** shardy has joined #openstack-mistral | 10:45 | |
| ist | with this we are saving some unnecessary DB query also when workflow execution state is changed. | 10:49 |
| d0ugal | yup | 10:49 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Make the workflow definition optional https://review.openstack.org/438908 | 10:57 |
| d0ugal | ist: is that the same as what you are trying? ^ | 10:57 |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Correction in workflow state change handling https://review.openstack.org/438913 | 10:59 |
| ist | similar, just I go a bit further to move wf_def parameter to start() function | 10:59 |
| ist | see previous review | 10:59 |
| d0ugal | ist: aha, yeah, that is a better idea | 11:01 |
| d0ugal | I'll check it out | 11:01 |
| d0ugal | I abandoned my change btw, just wanted to show you it | 11:01 |
| mgershen | don't forget to pas wf_def to _create_execution as well. | 11:02 |
| ist | I didn't forget | 11:05 |
| mgershen | great :) | 11:05 |
| ist | let's see that tests are passed or not... Unfortunately I have some local problem now and I did not able to run unit tests... | 11:07 |
| mgershen | I say it's fine to push untested, if you mark code as work in progress | 11:10 |
| d0ugal | +1 | 11:10 |
| *** jkilpatr has quit IRC | 11:41 | |
| *** jkilpatr has joined #openstack-mistral | 12:13 | |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Correction in workflow state change handling https://review.openstack.org/438913 | 12:15 |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Correction in workflow state change handling https://review.openstack.org/438913 | 12:26 |
| *** thrash|g0ne is now known as thrash | 12:31 | |
| *** kong has quit IRC | 12:39 | |
| *** sharatss has joined #openstack-mistral | 12:44 | |
| *** dprince has joined #openstack-mistral | 13:02 | |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Correction in workflow state change handling https://review.openstack.org/438913 | 13:08 |
| *** sharatss has quit IRC | 13:39 | |
| *** sharatss has joined #openstack-mistral | 13:40 | |
| *** shardy has quit IRC | 13:46 | |
| *** shardy has joined #openstack-mistral | 13:47 | |
| *** zhurong has joined #openstack-mistral | 13:51 | |
| *** openstackgerrit has quit IRC | 14:03 | |
| *** fultonj has joined #openstack-mistral | 14:03 | |
| *** toure|gone is now known as toure | 14:16 | |
| *** rbux has quit IRC | 14:18 | |
| *** rbrady has joined #openstack-mistral | 14:24 | |
| *** rbrady has quit IRC | 14:24 | |
| *** rbrady has joined #openstack-mistral | 14:24 | |
| *** chlong has joined #openstack-mistral | 14:31 | |
| *** openstackgerrit has joined #openstack-mistral | 14:52 | |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Correction in workflow state change handling https://review.openstack.org/438913 | 14:52 |
| *** zhurong has quit IRC | 15:10 | |
| *** chlong has quit IRC | 15:11 | |
| *** ist has quit IRC | 15:30 | |
| *** chlong has joined #openstack-mistral | 15:43 | |
| *** fultonj has quit IRC | 15:44 | |
| *** fultonj has joined #openstack-mistral | 15:46 | |
| *** jaosorior has quit IRC | 16:03 | |
| *** sharatss has quit IRC | 16:24 | |
| *** tuan_ has joined #openstack-mistral | 17:00 | |
| *** tuan_ has quit IRC | 17:19 | |
| *** jpich has quit IRC | 18:06 | |
| *** chlong has quit IRC | 18:06 | |
| *** dprince has quit IRC | 18:38 | |
| *** thrash is now known as thrash|biab | 18:48 | |
| *** dprince has joined #openstack-mistral | 19:08 | |
| *** chlong has joined #openstack-mistral | 19:25 | |
| *** shardy has quit IRC | 19:38 | |
| *** thrash|biab is now known as thrash | 19:44 | |
| *** harlowja has quit IRC | 20:15 | |
| *** harlowja has joined #openstack-mistral | 20:16 | |
| *** kong has joined #openstack-mistral | 20:58 | |
| *** chlong has quit IRC | 21:27 | |
| *** chlong has joined #openstack-mistral | 21:39 | |
| *** fultonj has quit IRC | 21:45 | |
| *** fultonj has joined #openstack-mistral | 21:47 | |
| *** jkilpatr has quit IRC | 21:52 | |
| *** fultonj has quit IRC | 21:57 | |
| *** chlong has quit IRC | 21:58 | |
| *** jkilpatr has joined #openstack-mistral | 22:33 | |
| *** dprince has quit IRC | 23:29 | |
| *** rbrady has quit IRC | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!