*** gongysh has joined #openstack-mistral | 00:04 | |
gongysh | kong hi | 00:08 |
---|---|---|
*** zhurong has joined #openstack-mistral | 00:41 | |
*** bobh has joined #openstack-mistral | 00:46 | |
*** bobh has quit IRC | 00:46 | |
kong | gongysh: hi | 00:47 |
*** bobh has joined #openstack-mistral | 00:47 | |
*** bobh_ has joined #openstack-mistral | 00:49 | |
*** bobh has quit IRC | 00:49 | |
*** bobh_ has quit IRC | 00:53 | |
*** bobh has joined #openstack-mistral | 00:53 | |
*** thrash is now known as thrash|g0ne | 01:14 | |
*** zhurong has quit IRC | 01:23 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral master: Add 'created_time' to execution() function https://review.openstack.org/448843 | 01:33 |
*** gongysh has quit IRC | 01:40 | |
*** jtaryma has joined #openstack-mistral | 01:42 | |
*** zhurong has joined #openstack-mistral | 01:43 | |
*** gongysh has joined #openstack-mistral | 02:36 | |
*** toure is now known as toure|gone | 03:10 | |
*** bobh has quit IRC | 03:29 | |
*** bobh has joined #openstack-mistral | 03:34 | |
*** bobh has quit IRC | 03:38 | |
*** bobh has joined #openstack-mistral | 03:38 | |
*** bobh has quit IRC | 03:43 | |
*** zhurong has quit IRC | 03:48 | |
*** gongysh has quit IRC | 04:34 | |
*** gongysh has joined #openstack-mistral | 05:03 | |
*** zhurong has joined #openstack-mistral | 05:53 | |
*** sharatss has joined #openstack-mistral | 06:04 | |
*** vgnbkr_ has joined #openstack-mistral | 06:12 | |
*** vgnbkr has quit IRC | 06:13 | |
*** vgnbkr_ is now known as vgnbkr | 06:13 | |
*** jaosorior has joined #openstack-mistral | 06:30 | |
*** jtaryma is now known as joanna | 06:35 | |
*** dmellado has quit IRC | 07:03 | |
rakhmerov | kong: hi | 07:04 |
rakhmerov | you here? | 07:04 |
rakhmerov | d0ugal: hi, just FYI: I'm back | 07:04 |
rakhmerov | feel better | 07:05 |
*** dmellado has joined #openstack-mistral | 07:08 | |
*** amoralej|off is now known as amoralej | 07:43 | |
d0ugal | rakhmerov: wb! | 07:44 |
rakhmerov | thanks | 07:44 |
*** sharatss has quit IRC | 07:48 | |
*** sharatss has joined #openstack-mistral | 07:48 | |
*** shardy has joined #openstack-mistral | 08:05 | |
openstackgerrit | Merged openstack/mistral master: Trim yaql/jinja operation log https://review.openstack.org/447741 | 08:12 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Change some 3rd party package default log levels https://review.openstack.org/447777 | 08:29 |
*** jaosorior is now known as jaosorior_brb | 08:55 | |
*** shardy has quit IRC | 08:58 | |
*** shardy has joined #openstack-mistral | 09:00 | |
*** openstackgerrit has quit IRC | 09:03 | |
*** mgershen1 has joined #openstack-mistral | 09:05 | |
*** mgershen has quit IRC | 09:06 | |
*** jrist has quit IRC | 09:12 | |
*** jrist has joined #openstack-mistral | 09:13 | |
*** gongysh has quit IRC | 09:38 | |
kong | rakhmerov: hi | 10:09 |
kong | welcome back | 10:09 |
rakhmerov | thanks | 10:10 |
rakhmerov | I just wanted to ask something.. | 10:10 |
rakhmerov | let me remember | 10:10 |
rakhmerov | kong: I guess about https://review.openstack.org/#/c/448340/ | 10:10 |
rakhmerov | but I already left a comment | 10:10 |
* kong is reading | 10:11 | |
kong | rakhmerov: for rpc_ctx, i just removed that from the beginning of the rpc server. if we found something import to know inside it, we should log it (not the whole rpc_ctx) somewhere else | 10:13 |
kong | another option is | 10:14 |
kong | because for my case, it's the service catalog very annoying | 10:14 |
rakhmerov | why is it a part of rpc_ctx? | 10:14 |
rakhmerov | service catalog | 10:14 |
rakhmerov | ooh, ok, because it gets inserted into security context | 10:15 |
kong | yep | 10:15 |
rakhmerov | and that one goes into rpc_ctx | 10:15 |
rakhmerov | yes | 10:15 |
rakhmerov | hm.. | 10:15 |
kong | if we really want to see what's inside security context | 10:15 |
kong | the right place is in openstack action | 10:16 |
rakhmerov | kong: ok, I don't have a strong opinion on this | 10:16 |
rakhmerov | I just wanted to discuss it with you and find out how big the problem is | 10:16 |
rakhmerov | kong: yep, agree on openstack action | 10:16 |
kong | maybe it is not affecting other people because they don't have a huge service catalog like me | 10:17 |
rakhmerov | ok | 10:17 |
rakhmerov | ok, I don't wanna block the patch | 10:17 |
rakhmerov | I'll change my vote | 10:17 |
kong | rakhmerov: and i have a question, how rpc_ctx is used? | 10:18 |
kong | i thought it is set as context somewhere but i can not find | 10:18 |
rakhmerov | there should be a hook somewhere | 10:18 |
rakhmerov | give me a sec.. | 10:18 |
rakhmerov | ok | 10:20 |
rakhmerov | kong: https://github.com/openstack/mistral/blob/master/mistral/context.py#L268 | 10:21 |
rakhmerov | but this may be slightly messed up | 10:21 |
rakhmerov | I'm not sure that a serializer is a good place for this | 10:22 |
kong | rakhmerov: but 'deserialize_context' is only used in scheduler, how does rpc_ctx set as context when mistral-executor receives rpc message? | 10:29 |
kong | i'm a little confused | 10:29 |
rakhmerov | kong: no | 10:30 |
rakhmerov | it's used implicitly by RPC subsystem (oslo.messaging) | 10:31 |
kong | i mean, when mistral-executor receives rpc request (rpc_ctx is the first param), where does mistral-executor set the thread context using rpc_ctx? | 10:32 |
rakhmerov | yes, second.. | 10:32 |
rakhmerov | just looking for the place.. | 10:33 |
rakhmerov | kong: https://github.com/openstack/mistral/blob/master/mistral/engine/rpc_backend/oslo/oslo_server.py#L55 | 10:35 |
rakhmerov | so when o.m receives a message it uses this serializer that deserializes rpc_ctx and sets a thread local | 10:35 |
*** thrash|g0ne is now known as thrash | 10:35 | |
kong | rakhmerov: ah, got it | 10:36 |
rakhmerov | yep | 10:36 |
kong | rakhmerov: thanks | 10:36 |
rakhmerov | np | 10:36 |
*** openstackgerrit has joined #openstack-mistral | 10:36 | |
openstackgerrit | Merged openstack/mistral master: Change some 3rd party package default log levels https://review.openstack.org/447777 | 10:36 |
openstackgerrit | Lingxian Kong proposed openstack/mistral master: Add 'created_time' to execution() function https://review.openstack.org/448843 | 10:37 |
*** jkilpatr has quit IRC | 10:50 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec https://review.openstack.org/446960 | 10:58 |
*** jaosorior_brb is now known as jaosorior | 11:02 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral master: Add 'created_at' to execution() yaql function https://review.openstack.org/448843 | 11:05 |
*** jistr is now known as jistr|afk | 11:06 | |
*** jkilpatr has joined #openstack-mistral | 11:06 | |
*** joanna has quit IRC | 11:36 | |
*** bobh has joined #openstack-mistral | 11:58 | |
*** shardy is now known as shardy_lunch | 12:08 | |
*** bobh has quit IRC | 12:14 | |
*** zhurong has quit IRC | 12:22 | |
*** rajesh_4k has joined #openstack-mistral | 12:26 | |
*** jistr|afk is now known as jistr | 12:27 | |
d0ugal | rajesh_4k: Hey, so what is it that you'd like to contribute? | 12:28 |
rajesh_4k | Hi d0ugal | 12:28 |
rajesh_4k | anything i would like share your tasks and contribute | 12:29 |
rajesh_4k | i have developed yardstick user interface for opnfv-yardstick | 12:29 |
rajesh_4k | so i can handle both GUI and backend | 12:29 |
d0ugal | rajesh_4k: nice, I am not familiar with that project | 12:30 |
d0ugal | but that is okay :) | 12:30 |
d0ugal | It is hard to tell you where to start - usually people contribute to Mistral (or other projects) because they have a problem or see something they want to improve | 12:31 |
rajesh_4k | ok sure | 12:31 |
d0ugal | but if you don't have any ideas, and you just want to help I guess the bug list is the best place to look. | 12:31 |
d0ugal | https://bugs.launchpad.net/mistral | 12:31 |
d0ugal | How much have you done with Mistral? | 12:31 |
thrash | d0ugal: rakhmerov https://bugs.launchpad.net/python-mistralclient/+bug/1675388 | 12:32 |
openstack | Launchpad bug 1675388 in python-mistralclient "UTC conversion not taking DST into account" [Undecided,New] - Assigned to Brad P. Crochet (brad-9) | 12:32 |
thrash | I have a fix already | 12:32 |
d0ugal | thrash: heh, well spotted. | 12:33 |
thrash | d0ugal: wait til you see the fix. :) | 12:33 |
d0ugal | This sounds fun. | 12:33 |
rajesh_4k | I just saw mistral installed in devstack and liked the working, functionality and the way things are working in that. | 12:33 |
rajesh_4k | so just wanted to know whether i can share any load | 12:34 |
rajesh_4k | if any. | 12:34 |
rajesh_4k | but anyways i will start off with the bugs | 12:34 |
rajesh_4k | thanks for the leads.. | 12:34 |
d0ugal | rajesh_4k: the load is huge and there is always lots to do :) but it is hard to know where you should start - maybe just find a bug that you think looks interesting | 12:34 |
rakhmerov | thrash: great | 12:34 |
d0ugal | rajesh_4k: rakhmerov may have a better idea! | 12:34 |
openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Take DST into account when converting to UTC https://review.openstack.org/449117 | 12:35 |
rajesh_4k | ok | 12:37 |
d0ugal | thrash: reading this hurts my head :) | 12:38 |
thrash | d0ugal: hahaha | 12:38 |
thrash | I mock time! Muahahaha | 12:38 |
d0ugal | but I think it looks good | 12:38 |
thrash | d0ugal: so... time.daylight signifies whether the tz even recognizes DST | 12:39 |
*** dprince has joined #openstack-mistral | 12:39 | |
thrash | time.localtime().tm_isdst signifies if it is currently *in* DST | 12:39 |
thrash | time.altzone is number of seconds offset if in DST, and time.timezone is "normal" time | 12:40 |
d0ugal | thrash: cool, I think that makes sense | 12:41 |
thrash | d0ugal: if you look closely, you'll actually notice that the new code actually came from the test. :P | 12:41 |
thrash | So I had to rewrite the tests so it wasn't running the exact same code. :D | 12:41 |
*** rajesh_4k has quit IRC | 12:41 | |
d0ugal | oh yeah, nice | 12:42 |
d0ugal | +2ed | 12:42 |
thrash | d0ugal: rakhmerov I think this should be backported to ocata... | 12:43 |
thrash | that is, if the previous time stuff I did made it into ocata, which I'm not sure of. | 12:44 |
*** catintheroof has joined #openstack-mistral | 12:44 | |
thrash | never mind... Doesn't look like it did. | 12:44 |
*** dprince has quit IRC | 12:49 | |
rakhmerov | rajesh_4k: I'm ready to help you | 12:50 |
rakhmerov | can we talk tomorrow? | 12:50 |
d0ugal | he left already :) | 12:50 |
*** dprince has joined #openstack-mistral | 12:51 | |
*** shardy_lunch is now known as shardy | 12:57 | |
*** catintheroof has quit IRC | 13:03 | |
*** amoralej is now known as amoralej|lunch | 13:07 | |
openstackgerrit | Anastasia Kuznetsova proposed openstack/mistral master: Pass encoding parameter during action result serialization https://review.openstack.org/449143 | 13:23 |
*** bobh has joined #openstack-mistral | 13:39 | |
*** sharatss has quit IRC | 14:10 | |
*** amoralej|lunch is now known as amoralej | 14:22 | |
thrash | d0ugal: guess I should add a releasenote... :/ | 14:53 |
d0ugal | thrash: up to you, I would say we have not fully adopted them in Mistral yet... | 14:55 |
d0ugal | but we should :) | 14:55 |
thrash | d0ugal: Ok. I'll let this one slide then. It already has a +2 and a couple of +1's. :) | 14:56 |
thrash | d0ugal: and tbh, it's fixing a bug that hasn't even been released yet so... | 14:56 |
d0ugal | :) | 15:02 |
*** toure|gone is now known as toure | 15:19 | |
*** thrash is now known as thrash|biab | 15:38 | |
*** jtaryma has joined #openstack-mistral | 15:45 | |
*** jkilpatr_ has joined #openstack-mistral | 15:47 | |
*** jkilpatr has quit IRC | 15:49 | |
*** amoralej is now known as amoralej|brb | 15:54 | |
*** dprince has quit IRC | 16:01 | |
*** dprince has joined #openstack-mistral | 16:07 | |
openstackgerrit | Merged openstack/mistral master: Add 'created_at' to execution() yaql function https://review.openstack.org/448843 | 16:11 |
*** thrash|biab is now known as thrash | 16:41 | |
*** rbrady is now known as rbrady-busy | 16:41 | |
*** amoralej|brb is now known as amoralej | 16:41 | |
*** jkilpatr_ has quit IRC | 16:47 | |
*** jkilpatr has joined #openstack-mistral | 16:48 | |
*** catintheroof has joined #openstack-mistral | 17:07 | |
*** dprince has quit IRC | 17:29 | |
*** jaosorior has quit IRC | 17:30 | |
*** dprince has joined #openstack-mistral | 17:49 | |
*** rbrady-busy is now known as rbrady | 17:59 | |
*** catintheroof has quit IRC | 18:07 | |
*** dprince has quit IRC | 18:51 | |
*** jtaryma is now known as joanna | 19:03 | |
*** toure is now known as toure|biab | 19:10 | |
*** toure|biab is now known as toure | 19:10 | |
*** shardy is now known as shardy_afk | 19:18 | |
*** dprince has joined #openstack-mistral | 19:25 | |
*** amoralej is now known as amoralej|off | 19:46 | |
*** toure is now known as toure|biab | 20:10 | |
*** toure|biab is now known as toure | 20:10 | |
*** jkilpatr has quit IRC | 20:21 | |
*** dprince has quit IRC | 20:59 | |
*** rbrady is now known as rbrady-afk | 21:00 | |
*** jkilpatr has joined #openstack-mistral | 21:08 | |
*** thrash is now known as thrash|g0ne | 21:23 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral master: Add release note for 'created_at' support in execution() https://review.openstack.org/449331 | 21:29 |
openstackgerrit | Lingxian Kong proposed openstack/python-mistralclient master: Add release note for region name bugfix https://review.openstack.org/449333 | 21:38 |
*** bobh has quit IRC | 21:58 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral master: Surpress log with context data and db data https://review.openstack.org/448340 | 22:42 |
*** catintheroof has joined #openstack-mistral | 23:13 | |
*** catintheroof has quit IRC | 23:20 | |
*** catintheroof has joined #openstack-mistral | 23:21 | |
*** catintheroof has quit IRC | 23:33 | |
*** catintheroof has joined #openstack-mistral | 23:38 | |
*** vishwanathj has quit IRC | 23:43 | |
*** catintheroof has quit IRC | 23:45 | |
*** bobh has joined #openstack-mistral | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!