| *** zhurong has joined #openstack-mistral | 01:50 | |
| *** thrash is now known as thrash|g0ne | 02:35 | |
| *** bobh has quit IRC | 03:02 | |
| *** gongysh has joined #openstack-mistral | 03:17 | |
| *** zhurong has quit IRC | 03:21 | |
| *** bobh has joined #openstack-mistral | 04:03 | |
| *** bobh has quit IRC | 04:07 | |
| *** warface has joined #openstack-mistral | 04:35 | |
| *** tung_doan has joined #openstack-mistral | 04:46 | |
| *** gkadam has joined #openstack-mistral | 05:00 | |
| *** gongysh has quit IRC | 05:11 | |
| *** warface has quit IRC | 05:44 | |
| *** warface has joined #openstack-mistral | 05:45 | |
| *** zhurong has joined #openstack-mistral | 05:52 | |
| *** zhurong has quit IRC | 06:01 | |
| openstackgerrit | Merged openstack/python-mistralclient master: fix release note formatting https://review.openstack.org/459341 | 06:07 |
|---|---|---|
| openstackgerrit | Merged openstack/python-mistralclient master: Explicitly set 'builders' option https://review.openstack.org/457940 | 06:07 |
| *** jaosorior_away is now known as jaosorior | 06:16 | |
| *** gongysh has joined #openstack-mistral | 06:17 | |
| gongysh | https://bugs.launchpad.net/mistral/+bug/1685583 | 06:18 |
| gongysh | do you guys have any idea on this bug? | 06:18 |
| openstack | Launchpad bug 1685583 in Mistral "action does not be deleted when workflow execution is delete" [Undecided,New] | 06:18 |
| apetrich | d0ugal, trying to figure out what is missing for mistral-lib release in rdo. I'm looking at the built packages and don't see it there | 07:00 |
| apetrich | d0ugal, but today is holiday in Italy and my go to person is off | 07:01 |
| d0ugal | dang | 07:01 |
| d0ugal | apetrich: I'll try and take a look shortly, just catching up :) | 07:01 |
| d0ugal | apetrich: where do you see the built packages? | 07:01 |
| apetrich | d0ugal, no worries. | 07:01 |
| apetrich | d0ugal, https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-master/ | 07:02 |
| d0ugal | https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk | 07:03 |
| d0ugal | apetrich: ^ we are on step 5 there now | 07:03 |
| apetrich | d0ugal, oh I see | 07:04 |
| apetrich | cool | 07:04 |
| apetrich | I didn't see that | 07:05 |
| *** jpich has joined #openstack-mistral | 07:33 | |
| *** fultonj_ has joined #openstack-mistral | 07:41 | |
| *** fultonj has quit IRC | 07:41 | |
| gongysh | kong, d0ugal ,hi | 08:32 |
| *** gongysh has quit IRC | 08:58 | |
| *** gongysh has joined #openstack-mistral | 09:16 | |
| *** sharatss has joined #openstack-mistral | 09:27 | |
| *** tuan_ has joined #openstack-mistral | 09:31 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral master: Fix doc generation for python 3 https://review.openstack.org/457204 | 09:38 |
| *** shardy has joined #openstack-mistral | 09:41 | |
| d0ugal | gongysh: hi | 09:49 |
| gongysh | d0ugal, https://bugs.launchpad.net/mistral/+bug/1685583 | 09:49 |
| openstack | Launchpad bug 1685583 in Mistral "action does not be deleted when workflow execution is delete" [Undecided,New] | 09:49 |
| gongysh | is there a way to stop the left over running action if we delete the workflow execution? | 09:50 |
| d0ugal | gongysh: Good question. I'm not sure, I don't have any actions that run forever | 09:51 |
| d0ugal | IMO users shouldn't be allowed to delete running workflows - they should be required to stop them first. | 09:51 |
| *** gongysh has quit IRC | 10:08 | |
| *** thrash|g0ne is now known as thrash | 10:27 | |
| thrash | d0ugal: welcome back | 10:27 |
| d0ugal | thrash: thanks :) | 10:27 |
| *** mgershen has joined #openstack-mistral | 10:30 | |
| *** mgershen1 has quit IRC | 10:33 | |
| thrash | d0ugal: so this is fun... The nova python api has a 'get_keys()' method on the Flavor object that it returns... Which has additional info. | 10:42 |
| thrash | d0ugal: https://docs.openstack.org/developer/python-novaclient/ref/v2/flavors.html | 10:43 |
| thrash | d0ugal: so... we don't necessarily get back all info from the auto-generated actions. *sigh* | 10:43 |
| *** jkilpatr has quit IRC | 10:49 | |
| d0ugal | thrash: damg | 10:54 |
| d0ugal | damn | 10:54 |
| d0ugal | I guess this is the downside of action generation | 10:55 |
| thrash | d0ugal: It's still useful... Just means that you need to use a custom action for anything other than base cases... | 10:58 |
| thrash | d0ugal: perhaps a proposal to put client generation in the base action? A client manager like OSC? | 10:59 |
| tuan_ | jaosorior: Hi, it seems that the tripleo gate is not fixed yet | 10:59 |
| tuan_ | :( | 10:59 |
| tuan_ | do you have some updated information about it | 10:59 |
| thrash | d0ugal: we have all of the 'get_x_client()' in the TripleoBase... | 10:59 |
| thrash | d0ugal: seems like that might be something useful | 11:00 |
| d0ugal | thrash: yeah, we will have that in mistral-extra when we move the openstack actions there | 11:00 |
| thrash | d0ugal: cool | 11:00 |
| d0ugal | thrash: there was some related discussion in "[openstack-dev] [mistral] Mistral Custom Actions API Design" a while ago | 11:01 |
| thrash | d0ugal: ack. I'll go look at that thread. | 11:02 |
| d0ugal | thrash: I'm not sure how we should expose client constructor args to users. | 11:04 |
| d0ugal | thrash: for example, this is quite tripleo specific: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/base.py#L65-L71 | 11:04 |
| jaosorior | thrash, d0ugal: Hey, if oyu have time can you look at the issue that tuan_ was encountering? I think it's gonna bite us at some point. | 11:05 |
| d0ugal | tuan_: what's the issue? | 11:05 |
| thrash | d0ugal: that's a good question... | 11:07 |
| d0ugal | thrash: rbrady was looking at this problem too - I forget what his use-case was tho' | 11:07 |
| tuan_ | d0ugal: the tripleo gate fails with the error of app | 11:08 |
| tuan_ | ERROR(app) | 11:08 |
| *** bobh has joined #openstack-mistral | 11:08 | |
| tuan_ | i will send you the log | 11:08 |
| d0ugal | tuan_: which patch? | 11:09 |
| tuan_ | d0ugal: this patch: https://review.openstack.org/#/c/455407/ | 11:09 |
| d0ugal | tuan_: okay, I'll look into the logs - give me a few mins. | 11:09 |
| tuan_ | even before this patch, another guy had also the same problem | 11:09 |
| tuan_ | with the latest master at that time | 11:09 |
| tuan_ | jaosorior: could you correct me if i am saying something wrong | 11:10 |
| tuan_ | :) | 11:10 |
| jaosorior | tuan_: will try. I'm in the middle of trying to debug another issue though :/ sorry if I take some time to respond | 11:10 |
| tuan_ | jaosorior: oh, i am sorry too to disturb you | 11:10 |
| tuan_ | so focus on your stuff | 11:10 |
| tuan_ | i will contact to dougal for this problem | 11:11 |
| *** jkilpatr has joined #openstack-mistral | 11:11 | |
| openstackgerrit | luong tuan proposed openstack/mistral master: Refactor mistral context using oslo_context https://review.openstack.org/455407 | 11:11 |
| *** bobh has quit IRC | 11:13 | |
| d0ugal | tuan_: I can't find where it fails in the logs :( | 11:14 |
| tuan_ | d0ugal: yep, we had the same result too | 11:14 |
| tuan_ | :) | 11:14 |
| jaosorior | ok, back for a bit | 11:15 |
| tuan_ | remember that before this patch | 11:15 |
| jaosorior | d0ugal: so there are two issues here. | 11:15 |
| tuan_ | jaosorior: so you turn | 11:15 |
| jaosorior | d0ugal: One is that there is some error that is not getting logged in mistral. (might be some middleware, who knows) | 11:15 |
| jaosorior | d0ugal: the second issue is that the mistralclient is hiding the errors it gets from the server | 11:15 |
| jaosorior | so, for instance, if we see an error 500. It will just say ERROR (app) | 11:15 |
| jaosorior | d0ugal: we had a similar issue IIRC in tripleoclient, that's why I pinged you about the second error. | 11:16 |
| d0ugal | right | 11:17 |
| d0ugal | yikes | 11:17 |
| tuan_ | jaosorior: i also consider that why 500 error happened | 11:17 |
| tuan_ | but no error in mistral-api server | 11:17 |
| jaosorior | tuan_: most likely is some middleware issue. those tend not to get logged for some reason. | 11:17 |
| tuan_ | well, even client logs out error | 11:18 |
| tuan_ | but with 500 as Internal Server Error | 11:18 |
| tuan_ | it should show out some error from server side | 11:18 |
| tuan_ | and in mistral-api server, we had DEBUG mode as log level | 11:18 |
| d0ugal | jaosorior, tuan_ - there is almost nothing in the mistral logs, maybe it isn't starting correctly? | 11:19 |
| tuan_ | d0ugal: with the vanilla mistral | 11:19 |
| tuan_ | everything works well | 11:19 |
| tuan_ | i have no idea with mistral with triplo | 11:20 |
| tuan_ | tripleo | 11:20 |
| d0ugal | jaosorior: the undercloud install failed in https://review.openstack.org/#/c/455407/ | 11:20 |
| d0ugal | on PS5 | 11:20 |
| tuan_ | yep | 11:20 |
| d0ugal | oh | 11:21 |
| d0ugal | I see the ERROR app | 11:21 |
| jaosorior | d0ugal: it's the error tuan_ is talking about. | 11:21 |
| d0ugal | okay, sorry, it seems I am just catching up | 11:21 |
| jaosorior | no logs in the mistral server | 11:21 |
| d0ugal | sorry :P | 11:21 |
| jaosorior | but some strange ERROR (app) as the sole output | 11:21 |
| d0ugal | You need to come to me with easier problems after I have been off! | 11:21 |
| jaosorior | d0ugal: no biggie, we should probably do better explaining the context of this | 11:21 |
| d0ugal | np | 11:22 |
| d0ugal | Okay, doing some experimenting now I see where this happens | 11:22 |
| d0ugal | jaosorior: I think our cut removes the error | 11:25 |
| d0ugal | "cut -f 2 -d ' '" | 11:25 |
| d0ugal | it should look more like http://paste.openstack.org/show/607851/ | 11:26 |
| jaosorior | d0ugal: by the way, I'm replacing those https://review.openstack.org/#/c/458808/ | 11:30 |
| d0ugal | jaosorior: oh, interesting - that will be less error prone | 11:30 |
| d0ugal | jaosorior: I am going to base a patch on yours, and add a depends on for tuan_ | 11:31 |
| d0ugal | 's patch | 11:31 |
| jaosorior | d0ugal: awesome, thanks for looking into this | 11:31 |
| *** tuan_ has quit IRC | 11:47 | |
| *** catintheroof has joined #openstack-mistral | 11:48 | |
| *** tuan_ has joined #openstack-mistral | 11:50 | |
| *** weshay_PTO is now known as weshay | 11:59 | |
| *** dprince has joined #openstack-mistral | 12:02 | |
| *** bobh has joined #openstack-mistral | 12:02 | |
| *** catintheroof has quit IRC | 12:08 | |
| *** tuan_ has quit IRC | 12:12 | |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Add a missing space to the help message for execution-create https://review.openstack.org/453666 | 12:12 |
| *** tuan_ has joined #openstack-mistral | 12:14 | |
| *** chlong has quit IRC | 12:20 | |
| shardy | tuan_: Hi! You had some questions related to trusts? | 12:22 |
| tuan_ | shardy: Hi, here you are | 12:23 |
| tuan_ | yep | 12:23 |
| tuan_ | actually, partially related to | 12:23 |
| tuan_ | :D | 12:23 |
| tuan_ | since now i am finding a place to store trustor_id and trustee_id | 12:23 |
| tuan_ | i saw that in Heat we store them in User_Creds table | 12:23 |
| shardy | Yeah we have a table for that | 12:24 |
| tuan_ | what is the purpose of that table | 12:24 |
| tuan_ | just store information of user | 12:24 |
| tuan_ | ? | 12:24 |
| shardy | tuan_: yeah, previously (or when deferred_auth_method=password is selected) we stored the user ID of the user that created the stack, and encrypted the password in the context | 12:24 |
| shardy | tuan_: but now, with the default configuration, we store only the trust ID and the trustor/trustee details | 12:25 |
| shardy | e.g no passwords or other sensitive data | 12:25 |
| shardy | When I say "now", I mean like since 2013 ;) | 12:25 |
| shardy | I just used that table because we already had it, I guess you can store it somewhere in the mistral DB? | 12:26 |
| tuan_ | shardy: Perfect | 12:26 |
| tuan_ | in Mistral i do not see any suitable table to store it | 12:26 |
| tuan_ | :D | 12:26 |
| tuan_ | may be we can create a new table to store them | 12:27 |
| tuan_ | we could not store trustee/trustor_id within workbook table | 12:27 |
| tuan_ | :D | 12:27 |
| shardy | tuan_: Yeah, I guess you need to associate the trust with a workflow execution? | 12:28 |
| shardy | In heat we create the user_creds record then reference it from the stack table | 12:28 |
| tuan_ | and in some actions related to stack (create, update, etc.), the trust is associcated? | 12:29 |
| shardy | tuan_: on create of the stack we create and store the trust | 12:29 |
| tuan_ | shardy: and other actions just get the trust from db | 12:30 |
| tuan_ | ? | 12:30 |
| shardy | tuan_: yes exactly | 12:30 |
| tuan_ | shardy: thanks Steve | 12:30 |
| tuan_ | so i think in mistral, we need somewhere to store the trust | 12:31 |
| shardy | I guess it's simpler for mistral as you only have one lifecycle operation, e.g you create the execution (and the trust) then it runs (potentially consuming the trust to reauthenticate) | 12:31 |
| shardy | ? | 12:31 |
| tuan_ | and the trust is created when we create a workbook, workflow | 12:31 |
| shardy | tuan_: but creating a workbook or workflow is independent of it's execution? | 12:31 |
| shardy | I would expect the trust to be created at the point of running the workflow, not storing its definition | 12:32 |
| tuan_ | shardy: i agree | 12:32 |
| tuan_ | let's create it only when running | 12:32 |
| shardy | Ok, sounds good then :) | 12:32 |
| tuan_ | what about a table call trust_creds in order to store the trust information (trust_id and trustor_id) | 12:33 |
| tuan_ | ? | 12:33 |
| shardy | tuan_: I don't have any strong opinion on the naming - heat uses user_creds because it supports more than one credential method, not just trusts | 12:34 |
| tuan_ | shardy: yeah, so i think let create something general and then may be later, it can be used in another purpose | 12:35 |
| tuan_ | so user_creds seems OK for me | 12:35 |
| shardy | I'm not a mistral expert but +1 FWIW :) | 12:35 |
| tuan_ | i think i will go forward with it and let's wait for the comments from others | 12:35 |
| tuan_ | shardy: thanks :D | 12:36 |
| tuan_ | and thank you again for your time | 12:36 |
| shardy | tuan_: sounds good, please add me to the review when you post it and I'll try to help with review feedback | 12:36 |
| tuan_ | shardy: yep, definitely i will | 12:36 |
| apetrich | d0ugal, so it merged | 12:46 |
| d0ugal | apetrich: yup! I am waiting for it to show up here: http://trunk.rdoproject.org/centos7-master/report.html | 12:46 |
| d0ugal | apetrich: I guess that is the next step? | 12:46 |
| d0ugal | apetrich: looking at the commit and build datetimes, it seems it might take about an hour? | 12:47 |
| d0ugal | or longer | 12:47 |
| apetrich | d0ugal, I assume so. I'm going to look at the promote ci. it might be there | 12:47 |
| d0ugal | apetrich: good idea, where do I see that? | 12:49 |
| apetrich | d0ugal, it is one of those I think https://ci.centos.org/search/?q=promote | 12:49 |
| apetrich | d0ugal, ignore that. promote will pass from master into master-passed-ci | 12:50 |
| d0ugal | ah | 12:50 |
| apetrich | not relevant | 12:50 |
| d0ugal | okay :) | 12:50 |
| *** sharatss has quit IRC | 12:53 | |
| *** sharat has joined #openstack-mistral | 12:53 | |
| *** catintheroof has joined #openstack-mistral | 13:01 | |
| apetrich | d0ugal, we might have to have a merging commit for it to trigger | 13:02 |
| d0ugal | apetrich: ah, makes sense. | 13:03 |
| d0ugal | apetrich: commit in mistral-lib? | 13:03 |
| apetrich | d0ugal, aye | 13:03 |
| d0ugal | hrm, I'm nnot sure what I could do lol | 13:04 |
| apetrich | yeah. that's the thing | 13:04 |
| apetrich | I'm talking to people lets see if I can figure this out | 13:05 |
| apetrich | never mind. we probably better ask on rdo | 13:10 |
| apetrich | d0ugal, so next commit to mistral-lib or to the dist git | 13:17 |
| d0ugal | apetrich: :( I can't think of anything that is needed right now | 13:19 |
| d0ugal | apetrich: if you want to make a commit to mistral-lib that just tweaks a docstring or something I'll +2 it :P | 13:20 |
| d0ugal | apetrich: the README could be updated, it contains lies :) | 13:21 |
| *** toure|gone is now known as toure | 13:33 | |
| apetrich | d0ugal, will look at it. s/lies<enter><esc>dd:wq | 13:35 |
| *** bobh has quit IRC | 13:38 | |
| *** chlong has joined #openstack-mistral | 13:40 | |
| *** sharat has quit IRC | 13:41 | |
| *** livelace has joined #openstack-mistral | 13:46 | |
| openstackgerrit | Adriano Petrich proposed openstack/mistral-lib master: Fix documentation for custom actions https://review.openstack.org/459695 | 13:47 |
| apetrich | d0ugal, ^^ | 13:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Remove the unused ApplicationContextNotFoundException https://review.openstack.org/459698 | 13:48 |
| d0ugal | apetrich: technically Result can be used for successful results too btw | 13:48 |
| apetrich | d0ugal, I don't think I saw an example of that on tripleo-common | 13:50 |
| apetrich | d0ugal, mostly was either **mistral_result that I assume can be successful or errors | 13:51 |
| d0ugal | apetrich: https://github.com/openstack/mistral-lib/blob/e8814640bb6c9325eb9c9bb3dbd295f65bcfb1df/mistral_lib/actions/types.py#L24 | 13:52 |
| d0ugal | apetrich: depending what arg you use determines if it was an error or just data being returned | 13:52 |
| apetrich | d0ugal, let me fix that doc | 13:53 |
| openstackgerrit | Adriano Petrich proposed openstack/mistral-lib master: Fix documentation for custom actions https://review.openstack.org/459695 | 14:00 |
| apetrich | d0ugal, I think it is better ^ | 14:00 |
| *** warface has quit IRC | 14:08 | |
| d0ugal | apetrich: there was a build btw: https://trunk.rdoproject.org/centos7/report.html | 15:08 |
| apetrich | d0ugal, woot | 15:09 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: [WIP] - DO NOT MERGE - Implement the sensitive data blueprint. https://review.openstack.org/459747 | 15:09 |
| thrash | d0ugal: ^^^ extreme beginning. :D | 15:10 |
| *** gkadam has quit IRC | 15:10 | |
| d0ugal | thrash: neat! | 15:10 |
| d0ugal | LGMT +2 | 15:10 |
| d0ugal | :P | 15:10 |
| thrash | d0ugal: hehe... It adds the 'hidden' field to the dsl, and.. That's about it. | 15:10 |
| thrash | But it is documented! :P | 15:10 |
| d0ugal | thrash: I spotted and appreciated that! | 15:11 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: [WIP] - DO NOT MERGE - Implement the sensitive data blueprint. https://review.openstack.org/459747 | 15:13 |
| thrash | d0ugal: and... a release note. lol | 15:13 |
| d0ugal | thrash: lol, I almost joked about that. | 15:13 |
| thrash | hehe | 15:13 |
| *** tuan_ has quit IRC | 15:19 | |
| *** shardy is now known as shardy_afk | 15:25 | |
| *** shardy_afk is now known as shardy | 15:49 | |
| *** jpich has quit IRC | 16:06 | |
| *** chlong has quit IRC | 16:10 | |
| *** chlong has joined #openstack-mistral | 16:24 | |
| openstackgerrit | Toure Dunnon proposed openstack/mistral master: [WIP] Workflow Error Analysis (do not merge!) https://review.openstack.org/455447 | 16:55 |
| *** clenimar has joined #openstack-mistral | 16:58 | |
| openstackgerrit | Toure Dunnon proposed openstack/mistral master: [WIP] Workflow Error Analysis (do not merge!) https://review.openstack.org/455447 | 17:18 |
| *** jaosorior is now known as jaosorior_away | 17:19 | |
| *** chlong has quit IRC | 17:37 | |
| *** livelace has quit IRC | 17:40 | |
| *** chlong has joined #openstack-mistral | 17:53 | |
| *** dprince has quit IRC | 18:03 | |
| *** fultonj_ is now known as fultonj | 18:09 | |
| *** shardy has quit IRC | 18:36 | |
| *** dprince has joined #openstack-mistral | 18:39 | |
| tung_doan | d0ugal: thrash: Hi, could you guys please let me know if Mistral have some ways to trigger a workflow using a custom event/notification? Seems just OpenStack notifications are introduced in this spec: https://specs.openstack.org/openstack/mistral-specs/specs/newton/approved/event-notification-trigger.html | 18:46 |
| *** Kevin_Zheng has quit IRC | 18:47 | |
| thrash | tung_doan: not sure I follow about an "OpenStack" notification... | 18:48 |
| d0ugal | tung_doan: you can trigger a workflow with a zaqar queue | 19:10 |
| d0ugal | tung_doan: https://www.openstack.org/videos/video/building-self-healing-applications-with-aodh-zaqar-and-mistral | 19:10 |
| *** catinthe_ has joined #openstack-mistral | 19:28 | |
| *** catintheroof has quit IRC | 19:30 | |
| *** chlong has quit IRC | 19:46 | |
| *** chlong has joined #openstack-mistral | 19:57 | |
| *** bobh has joined #openstack-mistral | 20:00 | |
| *** jkilpatr has quit IRC | 20:10 | |
| *** catinthe_ has quit IRC | 20:42 | |
| *** jkilpatr has joined #openstack-mistral | 20:48 | |
| *** dprince has quit IRC | 21:08 | |
| *** chlong has quit IRC | 21:28 | |
| *** harlowja has quit IRC | 22:34 | |
| *** bobh has quit IRC | 22:57 | |
| *** openstack has joined #openstack-mistral | 23:28 | |
| *** harlowja has joined #openstack-mistral | 23:29 | |
| kong | tung_doan: hi, yeah, mistral does support run workflow based on notifications defined. We have the feature supported in API, but lack of documentation for now. | 23:35 |
| kong | In order to use that feature, mistral needs to be deployed in OpenStacn environment because it needs to listen to MQ | 23:36 |
| kong | but for event/notifications out of openstack, d0ugal is right, you need several openstack services combination (at least zaqar and mistral) | 23:39 |
| *** bobh has joined #openstack-mistral | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!