| *** bobh has joined #openstack-mistral | 00:03 | |
| *** bobh has quit IRC | 00:28 | |
| *** bobh has joined #openstack-mistral | 00:31 | |
| *** bobh has quit IRC | 00:50 | |
| *** bobh has joined #openstack-mistral | 01:20 | |
| *** bobh has quit IRC | 01:45 | |
| *** warface has quit IRC | 01:49 | |
| *** bobh has joined #openstack-mistral | 01:52 | |
| *** bobh has quit IRC | 02:24 | |
| *** bobh has joined #openstack-mistral | 02:27 | |
| *** bobh has quit IRC | 02:43 | |
| *** bobh has joined #openstack-mistral | 02:46 | |
| *** bobh has quit IRC | 03:08 | |
| *** warface has joined #openstack-mistral | 03:38 | |
| *** warface is now known as Guest1047 | 03:38 | |
| *** Guest1047 has quit IRC | 03:39 | |
| *** Kevin_Zheng has quit IRC | 03:59 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Revert "Remove 'sphinxcontrib.autohttp.flask' from sphinx config" https://review.openstack.org/471585 | 04:17 |
|---|---|---|
| rakhmerov | warface: nope, I don't remember why. I guess it was considered the most popular platform, that's it (although it might be worth asking the guy who did it originally) | 04:24 |
| *** livelace has joined #openstack-mistral | 04:32 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Set the default value of --limit parameter https://review.openstack.org/476110 | 04:36 |
| openstackgerrit | Renat Akhmerov proposed openstack/python-mistralclient master: Set the default value of --limit parameter https://review.openstack.org/476110 | 04:43 |
| *** mattybrennan has quit IRC | 05:25 | |
| *** mattybrennan has joined #openstack-mistral | 05:30 | |
| *** sharatss has joined #openstack-mistral | 05:43 | |
| sharatss | rakhmerov, d0ugal hi | 05:44 |
| sharatss | https://review.openstack.org/#/c/458515/ everytime i recheck this a different case fails | 05:44 |
| sharatss | any idea how to solve this? | 05:44 |
| openstackgerrit | Merged openstack/python-mistralclient master: Updated from global requirements https://review.openstack.org/478081 | 06:00 |
| rakhmerov | sharatss: what tests usually fail? | 06:09 |
| sharatss | rakhmerov, either this http://logs.openstack.org/15/458515/25/check/gate-python-mistralclient-devstack-dsvm-ubuntu-xenial/7f10a48/console.html#_2017-06-27_11_47_07_882789 | 06:10 |
| sharatss | or same in workflow | 06:10 |
| rakhmerov | do you have any theories why they fail? | 06:13 |
| rakhmerov | concurrent problems? | 06:13 |
| *** sharatss_ has joined #openstack-mistral | 06:13 | |
| *** sharatss has quit IRC | 06:14 | |
| *** sharatss has joined #openstack-mistral | 06:17 | |
| rakhmerov | did you try to investigate? | 06:17 |
| *** sharat has joined #openstack-mistral | 06:20 | |
| *** sharatss_ has quit IRC | 06:20 | |
| *** sharatss_ has joined #openstack-mistral | 06:22 | |
| *** sharatss has quit IRC | 06:22 | |
| *** sharat has quit IRC | 06:24 | |
| *** sharatss_ has quit IRC | 06:36 | |
| *** warface has joined #openstack-mistral | 06:38 | |
| openstackgerrit | Mike Fedosin proposed openstack/mistral master: Use recommended function to setup auth middleware in devstack https://review.openstack.org/473796 | 06:49 |
| *** sharatss has joined #openstack-mistral | 06:57 | |
| *** warface_ has joined #openstack-mistral | 07:06 | |
| d0ugal | sharatss: I'll try and take a look shortly | 07:11 |
| sharatss | d0ugal, thanks | 07:30 |
| *** shardy has joined #openstack-mistral | 07:33 | |
| *** jpich has joined #openstack-mistral | 07:35 | |
| therve | sharatss, You rebased on top of https://review.openstack.org/#/c/458515/ ? | 07:51 |
| therve | Those new tests are not correct | 07:53 |
| therve | You have 25 patch sets and about 38 builds, and 3 succeeded, that's not a recipe for success | 07:58 |
| *** dtantsur|afk is now known as dtantsur | 08:09 | |
| *** warface has quit IRC | 08:23 | |
| *** warface has joined #openstack-mistral | 08:23 | |
| *** warface is now known as Guest60913 | 08:24 | |
| *** Guest60913 has quit IRC | 08:24 | |
| *** sharatss has quit IRC | 09:04 | |
| *** abhishekk has joined #openstack-mistral | 09:22 | |
| abhishekk | hi, I have written one custom action but while executing the workflow I am getting error, run() takes exactly 1 argument (2 given) | 09:23 |
| abhishekk | any idea? | 09:23 |
| abhishekk | this is my action and yaml file, http://paste.openstack.org/show/613891/ | 09:24 |
| therve | run takes 2 arguments | 09:41 |
| abhishekk | self and context right? | 09:42 |
| therve | Yeah | 09:42 |
| abhishekk | even passing context I am facing same error :( | 09:42 |
| therve | Probably not | 09:42 |
| abhishekk | let me check once again | 09:43 |
| therve | I'm don't understand what you're trying to do. Your action doesn't actually do anything. | 09:43 |
| abhishekk | therve: Problem resolved, I was restarting only engine service and not executor | 09:47 |
| abhishekk | thank you | 09:47 |
| therve | You're welcome. | 09:47 |
| abhishekk | I am writing custom action for evauation instances | 09:47 |
| abhishekk | I am new to mistral, just evaluating it for understanding | 09:48 |
| therve | OK :). You shouldn't need to write any python code for that, though. | 09:50 |
| *** jtomasek has quit IRC | 09:52 | |
| *** jtomasek has joined #openstack-mistral | 09:53 | |
| *** jpich has quit IRC | 09:56 | |
| *** jpich has joined #openstack-mistral | 09:58 | |
| *** jtomasek has quit IRC | 09:59 | |
| *** jtomasek has joined #openstack-mistral | 09:59 | |
| *** jkilpatr has quit IRC | 10:00 | |
| abhishekk | therve: i need to do some customization to standard nova actions | 10:13 |
| abhishekk | therve: how I can access output of one task to other task, for example I am returning instance_list from my FilterVmAction and I am using filtered_vms: <% $.instance_list %> which is giving YAQLExpression error | 10:14 |
| *** warface has joined #openstack-mistral | 10:17 | |
| *** warface has quit IRC | 10:22 | |
| *** warface has joined #openstack-mistral | 10:27 | |
| *** warface is now known as Guest79850 | 10:27 | |
| *** Guest79850 has quit IRC | 10:29 | |
| warface_ | rakhmerov: ok, thanks. I might have to change the docker image, if it works out well, will update you guys. | 10:53 |
| *** jkilpatr has joined #openstack-mistral | 10:58 | |
| rakhmerov | ok | 11:02 |
| *** dtantsur is now known as dtantsur|lunch | 11:15 | |
| *** jkilpatr has quit IRC | 11:41 | |
| therve | abhishekk, Using "publish" in general | 11:46 |
| abhishekk | therve: done, thank you | 11:47 |
| *** jkilpatr has joined #openstack-mistral | 12:01 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: Add cron name/id to workflow execution description https://review.openstack.org/458384 | 12:08 |
| *** jkilpatr has quit IRC | 12:11 | |
| *** jkilpatr has joined #openstack-mistral | 12:12 | |
| *** chlong_ has quit IRC | 12:15 | |
| *** jkilpatr has quit IRC | 12:28 | |
| *** dprince has joined #openstack-mistral | 12:39 | |
| *** dtantsur|lunch is now known as dtantsur | 12:42 | |
| *** thrash|g0ne is now known as thrash | 12:45 | |
| *** toure is now known as toure|brb | 13:23 | |
| *** bobh has joined #openstack-mistral | 13:31 | |
| *** toure|brb is now known as toure | 13:33 | |
| *** chlong_ has joined #openstack-mistral | 13:34 | |
| *** zhurong_ has joined #openstack-mistral | 13:38 | |
| *** jaosorior has quit IRC | 14:05 | |
| *** jaosorior has joined #openstack-mistral | 14:08 | |
| fultonj | i have a question about the expected data structure that a mistral action should return | 14:54 |
| fultonj | i have seen this pattern | 14:54 |
| fultonj | http://paste.openstack.org/show/613939/ | 14:54 |
| fultonj | ^ is this arbitrary or is there a convention? | 14:54 |
| fultonj | rbrady: d0ugal ^ ? | 14:54 |
| d0ugal | fultonj: it should, ideally, return a Result class. | 14:55 |
| fultonj | more context at https://review.openstack.org/#/c/477541/5/tripleo_common/actions/files.py | 14:55 |
| d0ugal | https://github.com/openstack/mistral-lib/blob/master/mistral_lib/actions/types.py#L21 | 14:55 |
| d0ugal | fultonj: if error is passed to that class, Mistral consider the action to have errored and will propogate that | 14:56 |
| *** gfidente has joined #openstack-mistral | 14:56 | |
| d0ugal | otherwise data can be passed to be used by following workflow tasks | 14:56 |
| d0ugal | I have never used the cancel input, but I believe that is a way for the aciton to terminate the workflow if needed. | 14:56 |
| d0ugal | fultonj: Yeah, so that patch will need to be updated to use mistral-lib :) | 14:56 |
| d0ugal | fultonj: https://github.com/openstack/tripleo-common/commit/a30bb5bca200b35cd1400c2b970477c7c5493944 | 14:57 |
| d0ugal | it is trivial to migrate | 14:57 |
| d0ugal | fultonj: I don't think the stderr/stdout is very useful - I'm not quite sure where that pattern started (maybe in the validations code?) | 14:58 |
| d0ugal | but I would probably remove it tbh | 14:58 |
| fultonj | d0ugal: thanks | 14:59 |
| fultonj | https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/validations.py#L57-L81 | 14:59 |
| d0ugal | because I see you already use data and error - that is everything Mistral wants | 14:59 |
| fultonj | i aw that example and picked it up wanted to check | 14:59 |
| d0ugal | right | 14:59 |
| fultonj | thank you i will look more into the above | 15:00 |
| d0ugal | fultonj: I think it only makes sense when you want to return both but don't want to fail the action. i.e. here: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/validations.py#L124-L125 | 15:00 |
| d0ugal | They pass both as "data" | 15:00 |
| *** zhurong_ has quit IRC | 15:03 | |
| fultonj | ok | 15:04 |
| fultonj | i thought it was something people would always expect | 15:04 |
| fultonj | but i could just go with msg | 15:04 |
| fultonj | i think i'll just switch everything to mistral_workflow_utils.Result objects | 15:05 |
| gfidente | fultonj d0ugal yeah I find confusing having an outer error and a stderr in data | 15:05 |
| d0ugal | fultonj: but mistral_lib.actions.Result :) | 15:06 |
| d0ugal | fultonj: one you rebase that patch, it will fail, as I just removed mistral from the requirements.txt | 15:06 |
| gfidente | d0ugal so about that restart | 15:12 |
| gfidente | now from the python console I can import a module like tripleo_common.actions.plan | 15:13 |
| gfidente | but api.log says no module named tripleo_common.actions.plan | 15:13 |
| gfidente | I know it is me | 15:14 |
| gfidente | but what am I missing? | 15:14 |
| d0ugal | gfidente: one sec | 15:14 |
| d0ugal | gfidente: just in a ad-hoc meeting | 15:16 |
| gfidente | sure | 15:16 |
| gfidente | no worries and thanks in advance | 15:16 |
| *** rbrady has quit IRC | 15:18 | |
| *** rbrady has joined #openstack-mistral | 15:20 | |
| *** rbrady has quit IRC | 15:20 | |
| *** rbrady has joined #openstack-mistral | 15:20 | |
| *** fultonj has quit IRC | 15:28 | |
| *** fultonj has joined #openstack-mistral | 15:30 | |
| * fultonj was disconnected | 15:33 | |
| fultonj | following up... | 15:34 |
| fultonj | from mistral_lib import actions | 15:34 |
| fultonj | msg = "you're foo isn't bar'ing" | 15:34 |
| fultonj | return actions.Result(error={"msg": msg}) | 15:34 |
| fultonj | msg = "you're foo is bar'ing" | 15:34 |
| fultonj | return actions.Result(data={"msg": msg}) | 15:34 |
| fultonj | d0ugal: is ^ this OK? | 15:34 |
| d0ugal | gfidente: back | 15:34 |
| d0ugal | fultonj: that looks good - but why not just pass a string and remove msg? | 15:34 |
| d0ugal | I would only pass a dict if you have other meta data you want to include | 15:35 |
| gfidente | d0ugal forget about it | 15:35 |
| fultonj | d0ugal: so whether or not it's nested depends on the situation? | 15:35 |
| gfidente | d0ugal done | 15:35 |
| fultonj | d0ugal: there are cases where i do want to pass info in my task, e.g. "path" => "/foo/bar" | 15:35 |
| fultonj | so i thought being consistent would be nice, even if you get a one key->value deep dict | 15:36 |
| d0ugal | fultonj: true, I am not really against msg - just thinking "out loud" | 15:36 |
| *** jkilpatr has joined #openstack-mistral | 15:37 | |
| fultonj | d0ugal: ok, it's not religion for me so i'm flexible :) | 15:37 |
| d0ugal | fultonj: Stick with what you have and then you can add more keys | 15:37 |
| fultonj | trying to learn the conventions used for mistral'ers | 15:37 |
| d0ugal | it is more flexible | 15:37 |
| d0ugal | changing from "message" to {"msg":"message"} laster would be painful | 15:38 |
| d0ugal | fultonj: I think we are still establishing conventions in tripleo :) | 15:38 |
| fultonj | "which was the style back in pike" --Grandpa Simpson | 15:38 |
| fultonj | thanks | 15:38 |
| fultonj | one more question on context | 15:39 |
| d0ugal | sure | 15:41 |
| fultonj | sorry about the lag | 15:52 |
| fultonj | my unit test isn't using it but i think it should... | 15:53 |
| fultonj | https://review.openstack.org/#/c/477541/5/tripleo_common/tests/actions/test_files.p | 15:53 |
| fultonj | https://review.openstack.org/#/c/477541/5/tripleo_common/tests/actions/test_files.py | 15:53 |
| fultonj | via the decorator i wish patch into the behavior or os.path.exists to have it just say "yeah, it's there" to my class | 15:54 |
| fultonj | so i seem to be getting by without the magic mock object | 15:54 |
| fultonj | other examples pass the magic mock context object however | 15:55 |
| fultonj | because their code uses context | 15:55 |
| fultonj | mistral = self.get_workflow_client(context) | 15:55 |
| fultonj | for example | 15:56 |
| fultonj | if my action works without it and if my code fits my description (in my head at least) do you think i am missing anything | 15:56 |
| fultonj | ? | 15:56 |
| fultonj | d0ugal: ^ (sorry /me was distracted for 10 minuntes) | 15:57 |
| fultonj | i.e. i think i can drop "self.ctx = mock.MagicMock()" from my unit test | 16:01 |
| *** warface_ has quit IRC | 16:05 | |
| *** rbrady has quit IRC | 16:18 | |
| *** rbrady has joined #openstack-mistral | 16:30 | |
| *** rbrady has quit IRC | 16:30 | |
| *** rbrady has joined #openstack-mistral | 16:30 | |
| *** jpich has quit IRC | 16:39 | |
| *** dprince has quit IRC | 16:40 | |
| *** jkilpatr has quit IRC | 16:50 | |
| d0ugal | fultonj: sorry, I got distracted and hit the end of my day | 17:07 |
| * d0ugal reads up | 17:07 | |
| fultonj | hi d0ugal np | 17:07 |
| d0ugal | fultonj: I'm not sure what is wrong, if you post the code I can always take a look tomorrow | 17:08 |
| d0ugal | sorry, just passing my now | 17:08 |
| fultonj | d0ugal: ok, now worries | 17:08 |
| fultonj | i will just ask in the review | 17:08 |
| fultonj | no worries (i mean) | 17:08 |
| d0ugal | cheers | 17:09 |
| *** gfidente is now known as gfidente|afk | 17:11 | |
| *** dtantsur is now known as dtantsur|afk | 17:16 | |
| thrash | d0ugal: you around? | 17:33 |
| *** dprince has joined #openstack-mistral | 17:58 | |
| *** shardy has quit IRC | 18:02 | |
| *** bobh has quit IRC | 18:03 | |
| *** thrash is now known as thrash|brb | 18:07 | |
| *** jkilpatr has joined #openstack-mistral | 18:09 | |
| d0ugal | thrash|brb: ish | 18:31 |
| *** gfidente|afk is now known as gfidente | 19:04 | |
| *** livelace has quit IRC | 19:46 | |
| *** thrash|brb is now known as thrash | 20:16 | |
| *** dprince has quit IRC | 20:57 | |
| *** chlong_ has quit IRC | 22:18 | |
| *** bobh has joined #openstack-mistral | 22:24 | |
| *** toure is now known as toure|gone | 22:30 | |
| *** bobh has quit IRC | 22:31 | |
| *** bobh has joined #openstack-mistral | 23:40 | |
| *** bobh has quit IRC | 23:43 | |
| openstackgerrit | Toure Dunnon proposed openstack/mistral master: Workflow Error Analysis https://review.openstack.org/455447 | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!