| *** bobh has joined #openstack-mistral | 00:21 | |
| *** yangyapeng has quit IRC | 00:48 | |
| *** yangyapeng has joined #openstack-mistral | 00:48 | |
| *** catintheroof has quit IRC | 00:49 | |
| *** catintheroof has joined #openstack-mistral | 00:49 | |
| *** catintheroof has quit IRC | 00:50 | |
| *** yangyapeng has quit IRC | 00:52 | |
| *** zhurong has joined #openstack-mistral | 00:54 | |
| *** bobh has quit IRC | 01:03 | |
| *** bobh has joined #openstack-mistral | 01:11 | |
| *** bobh has quit IRC | 01:25 | |
| *** bobh has joined #openstack-mistral | 01:31 | |
| *** Kevin_Zheng has joined #openstack-mistral | 01:33 | |
| *** bobh has quit IRC | 01:37 | |
| *** bobh has joined #openstack-mistral | 01:42 | |
| *** yangyapeng has joined #openstack-mistral | 01:58 | |
| *** openstackgerrit has joined #openstack-mistral | 02:03 | |
| openstackgerrit | junbo.li proposed openstack/mistral master: TrivialFix: Fix error ignore directory for git https://review.openstack.org/504298 | 02:03 |
|---|---|---|
| *** bobh has quit IRC | 02:04 | |
| *** bobh has joined #openstack-mistral | 02:30 | |
| *** yangyapeng has quit IRC | 02:33 | |
| *** bobh has quit IRC | 03:47 | |
| *** zhurong has quit IRC | 04:53 | |
| *** jaosorior has joined #openstack-mistral | 05:01 | |
| *** jtomasek has joined #openstack-mistral | 05:09 | |
| *** jtomasek has quit IRC | 05:12 | |
| *** oidgar has quit IRC | 06:08 | |
| *** yangyapeng has joined #openstack-mistral | 06:44 | |
| *** zhurong has joined #openstack-mistral | 06:45 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: Testing ad-hoc asynchronous actions https://review.openstack.org/505508 | 06:53 |
| rakhmerov | d0ugal, rbrady: hi, can anyone of you take this bug? https://bugs.launchpad.net/mistral/+bug/1718353 | 06:55 |
| openstack | Launchpad bug 1718353 in Mistral "The "context" parameter of Action.run() isn't filled properly for asynchronous actions" [High,Confirmed] - Assigned to Ryan Brady (rbrady) | 06:55 |
| rakhmerov | I found a gap in our mistral-lib design | 06:55 |
| rakhmerov | and implementation of ad-hoc actions based on it | 06:55 |
| *** shardy has joined #openstack-mistral | 07:02 | |
| *** openstackgerrit has quit IRC | 07:02 | |
| *** yangyapeng has quit IRC | 07:12 | |
| *** yangyapeng has joined #openstack-mistral | 07:13 | |
| *** yangyapeng has joined #openstack-mistral | 07:14 | |
| *** yangyapeng has quit IRC | 07:15 | |
| *** yangyapeng has joined #openstack-mistral | 07:15 | |
| *** yangyapeng has joined #openstack-mistral | 07:16 | |
| *** yangyapeng has joined #openstack-mistral | 07:17 | |
| *** yangyapeng has joined #openstack-mistral | 07:18 | |
| *** yangyapeng has joined #openstack-mistral | 07:19 | |
| *** yangyapeng has quit IRC | 07:19 | |
| *** yangyapeng has joined #openstack-mistral | 07:20 | |
| *** yangyapeng has quit IRC | 07:21 | |
| *** yangyapeng has joined #openstack-mistral | 07:21 | |
| *** zhurong has quit IRC | 07:48 | |
| d0ugal | rakhmerov: ah, good spot. I'll try and take a look | 07:49 |
| *** yangyapeng has quit IRC | 07:50 | |
| *** yangyapeng has joined #openstack-mistral | 07:51 | |
| *** jaosorior has quit IRC | 07:55 | |
| rakhmerov | d0ugal: that would be great, there's not much work there I think | 07:56 |
| rakhmerov | it's just something that we left after refactoring | 07:57 |
| d0ugal | Yup, I think it should be easy - just finding the right place to pass in the context. | 07:58 |
| d0ugal | It is a little worrying that no tests fail :) | 07:58 |
| *** jpich has joined #openstack-mistral | 07:59 | |
| *** yangyapeng has quit IRC | 08:05 | |
| *** jtomasek has joined #openstack-mistral | 08:05 | |
| *** yangyapeng has joined #openstack-mistral | 08:06 | |
| *** yangyapeng has quit IRC | 08:10 | |
| *** jaosorior has joined #openstack-mistral | 08:19 | |
| *** yangyapeng has joined #openstack-mistral | 08:25 | |
| *** yangyapeng has quit IRC | 08:30 | |
| *** zhurong has joined #openstack-mistral | 08:44 | |
| rakhmerov | d0ugal: yes | 08:45 |
| rakhmerov | one more thing that I'm slightly worried about is that you probably have actions based on mistral-lib's Action that take "context" and potentially use it | 08:46 |
| rakhmerov | if we change its structure you'll need to fix these actions in TripleO | 08:46 |
| d0ugal | rakhmerov: right, I've not had a chance to take a close look yet. I am working on a different bug | 08:49 |
| d0ugal | I'll try and get to it soon, but hopefully we don't have to change it or we can maybe do something to make it easy to migrate | 08:50 |
| rakhmerov | well, yes, if TripleO actions don't yet use "context" then it's fine | 08:50 |
| rakhmerov | we don't need to change anything | 08:50 |
| rakhmerov | d0ugal: ok, thanks | 08:50 |
| d0ugal | rakhmerov: we use context :) | 08:51 |
| rakhmerov | :) | 08:51 |
| d0ugal | auth_uri, user_name, auth_token, project_name, project_id, insecure | 08:53 |
| rakhmerov | ooh | 08:53 |
| d0ugal | rakhmerov: A quick search of tripleo_common reveals we use those properties on context | 08:53 |
| rakhmerov | bad news | 08:53 |
| rakhmerov | ) | 08:53 |
| d0ugal | but I think i don't fully understand the bug yet | 08:55 |
| d0ugal | I'll need to do some investigation shortly | 08:55 |
| *** openstackgerrit has joined #openstack-mistral | 09:09 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Use @db_utils.retry_on_deadlock to retry scheduler transactions https://review.openstack.org/501657 | 09:09 |
| rakhmerov | d0ugal: ok, sure, ping me if needed | 09:10 |
| rakhmerov | I'll explain | 09:10 |
| rakhmerov | d0ugal: also, please review https://review.openstack.org/#/c/501657/ when you have a few mins | 09:11 |
| rakhmerov | pretty important | 09:11 |
| d0ugal | k, I'll look once I get a fresh coffee ;) | 09:13 |
| d0ugal | :) | 09:13 |
| d0ugal | back in 5 | 09:13 |
| rakhmerov | :) | 09:14 |
| rakhmerov | it passes the tests, I just added docstrings per Andras's requrest | 09:14 |
| rakhmerov | d0ugal: I'm looking at https://review.openstack.org/#/c/504305/2/etc/README.mistral.conf, is it really true that we now need to support a config in trunk? | 09:18 |
| rakhmerov | It used to be true long ago then it changed again | 09:19 |
| rakhmerov | so now they decided to go back to the old idea? | 09:19 |
| rakhmerov | is there any requirement published somewhere maybe? | 09:19 |
| d0ugal | rakhmerov: That change doesn't add it back - it just adds a README to make it clearer how to generate the config | 09:20 |
| d0ugal | I'm not sure it is really needed, but I thought "why not" | 09:20 |
| rakhmerov | The mistral.conf sample file is no longer generated and | 09:21 |
| rakhmerov | maintained in Trunk. | 09:21 |
| rakhmerov | this is slightly confusing | 09:21 |
| d0ugal | lol | 09:21 |
| rakhmerov | hm.. | 09:21 |
| d0ugal | that just states the current situation | 09:21 |
| rakhmerov | well, true, yeah.. | 09:21 |
| rakhmerov | ok, let it be! ) | 09:21 |
| d0ugal | let me see what other projects do... | 09:21 |
| d0ugal | rakhmerov: https://github.com/openstack/nova/blob/master/etc/nova/README-nova.conf.txt | 09:22 |
| d0ugal | nova has something similar. | 09:22 |
| rakhmerov | ok | 09:22 |
| rakhmerov | thanks | 09:22 |
| openstackgerrit | Merged openstack/mistral-dashboard master: Fix CSS for "Cancel" button in workflow execution https://review.openstack.org/503699 | 09:24 |
| openstackgerrit | Merged openstack/mistral master: Update URL and indentations https://review.openstack.org/493482 | 09:51 |
| *** zhurong has quit IRC | 10:22 | |
| *** thrash|g0ne is now known as thrash | 10:38 | |
| *** jkilpatr has quit IRC | 10:44 | |
| d0ugal | rakhmerov: so I think I understand | 11:08 |
| rakhmerov | ok | 11:08 |
| d0ugal | rakhmerov: basically we just need a "action context" that contains some of the current information plus some other details? | 11:09 |
| rakhmerov | there's no access now to things like "workflow_execution_id" | 11:09 |
| d0ugal | Right | 11:09 |
| rakhmerov | yes | 11:09 |
| d0ugal | and I think that is a very logical thing to want | 11:09 |
| d0ugal | Okay, I'll work on a patch this afternoon. | 11:09 |
| rakhmerov | we moved away from "action_context" parameter in initializers in favor of "context" in run() method | 11:09 |
| d0ugal | Yup | 11:10 |
| rakhmerov | but it doesn't provide this info | 11:10 |
| rakhmerov | one more thing, I believe we may want to insert same condition (if mistral_lib blablabla) in the engine where we fulfill this "action_context" param | 11:10 |
| d0ugal | rakhmerov: I think to do the transition the ActionContext will need to keep all the old names, but maybe as @property functions that output deprecation warnings | 11:10 |
| rakhmerov | yeah | 11:11 |
| rakhmerov | somehow we need to make this transition | 11:11 |
| d0ugal | Then we can design what the context should look like and we can transition tripleo over (and give anyone else that has found it time too) | 11:11 |
| d0ugal | I think it should be easy :) | 11:11 |
| rakhmerov | ok | 11:11 |
| d0ugal | and then just need to backport it to Pike | 11:11 |
| d0ugal | I think it'll take 3 patches and 3 backports :) | 11:12 |
| *** jkilpatr has joined #openstack-mistral | 11:16 | |
| *** pratapagoutham has joined #openstack-mistral | 11:30 | |
| pratapagoutham | https://review.openstack.org/#/c/505240/ can anyone review this commit ?? | 11:32 |
| *** bobh has joined #openstack-mistral | 11:52 | |
| openstackgerrit | Merged openstack/mistral master: Add root_execution_id to sub-workflow executions https://review.openstack.org/490063 | 12:00 |
| *** bobh has quit IRC | 12:08 | |
| *** dprince has joined #openstack-mistral | 12:09 | |
| *** xavierhardy has left #openstack-mistral | 12:22 | |
| *** niraj_singh has joined #openstack-mistral | 12:28 | |
| niraj_singh | i am creating dashboard for masakari. i took reference of mistral but getting an error "Danger: There was an error submitting the form. Please try again." after clicking on create button. | 12:31 |
| niraj_singh | is there any clue about above problem?? | 12:33 |
| *** bobh has joined #openstack-mistral | 12:59 | |
| *** catintheroof has joined #openstack-mistral | 13:02 | |
| *** pratapagoutham has quit IRC | 13:21 | |
| *** chlong has joined #openstack-mistral | 13:40 | |
| *** zhurong has joined #openstack-mistral | 13:55 | |
| *** gkadam has joined #openstack-mistral | 14:04 | |
| *** apetrich has quit IRC | 14:27 | |
| *** apetrich has joined #openstack-mistral | 14:27 | |
| *** gkadam is now known as gkadam-afk | 14:37 | |
| *** zhurong has quit IRC | 15:05 | |
| d0ugal | niraj_singh: do you have any tracebacks in the logs? | 15:27 |
| d0ugal | niraj_singh: I would probably ask in the horizon channel (I assume there is one) | 15:29 |
| *** jtomasek has quit IRC | 15:36 | |
| openstackgerrit | Merged openstack/mistral master: Use @db_utils.retry_on_deadlock to retry scheduler transactions https://review.openstack.org/501657 | 16:46 |
| *** shardy has quit IRC | 16:48 | |
| *** jpich has quit IRC | 16:50 | |
| *** gkadam-afk is now known as gkadam-away | 17:05 | |
| *** toure is now known as toure_biab | 17:22 | |
| *** toure_biab is now known as toure | 18:22 | |
| *** toure is now known as toure_biab | 20:04 | |
| *** catintheroof has quit IRC | 20:32 | |
| *** dprince has quit IRC | 20:41 | |
| *** jistr has quit IRC | 20:52 | |
| *** jkilpatr has quit IRC | 21:05 | |
| *** dprince has joined #openstack-mistral | 21:11 | |
| *** jkilpatr has joined #openstack-mistral | 21:25 | |
| *** chlong has quit IRC | 21:26 | |
| *** kong_ has joined #openstack-mistral | 21:33 | |
| *** kong has quit IRC | 21:33 | |
| *** kong_ is now known as kong | 21:33 | |
| *** dprince has quit IRC | 22:02 | |
| *** catintheroof has joined #openstack-mistral | 22:15 | |
| *** bobh has quit IRC | 22:16 | |
| *** bobh has joined #openstack-mistral | 22:17 | |
| *** bobh has quit IRC | 22:21 | |
| *** thrash is now known as thrash|g0ne | 22:47 | |
| *** jistr has joined #openstack-mistral | 22:53 | |
| *** jistr has quit IRC | 23:02 | |
| *** jistr has joined #openstack-mistral | 23:04 | |
| *** catintheroof has quit IRC | 23:19 | |
| *** bobh has joined #openstack-mistral | 23:23 | |
| *** bobh has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!