| *** yangyape_ has quit IRC | 00:08 | |
| *** yangyapeng has joined #openstack-mistral | 00:09 | |
| *** yangyapeng has quit IRC | 00:13 | |
| *** catintheroof has joined #openstack-mistral | 00:19 | |
| *** zhurong has joined #openstack-mistral | 01:01 | |
| *** yangyapeng has joined #openstack-mistral | 01:12 | |
| *** yangyapeng has quit IRC | 01:16 | |
| *** catintheroof has quit IRC | 01:37 | |
| *** catintheroof has joined #openstack-mistral | 01:38 | |
| *** catintheroof has quit IRC | 01:57 | |
| *** yangyapeng has joined #openstack-mistral | 02:22 | |
| *** yangyapeng has quit IRC | 02:25 | |
| *** yangyapeng has joined #openstack-mistral | 02:25 | |
| rakhmerov | toure_biab: ok, sure ) | 02:40 |
|---|---|---|
| openstackgerrit | Bob Haddleton proposed openstack/mistral master: Add type definitions to support on-complete, on-error, on-success https://review.openstack.org/499790 | 02:49 |
| bobh | rakhmerov: ping | 02:50 |
| rakhmerov | bobh: hi Bob ) | 02:50 |
| rakhmerov | how are you? | 02:50 |
| bobh | good - how was your trip home? | 02:50 |
| rakhmerov | it was ok but very long :) | 02:50 |
| rakhmerov | about 36 hours | 02:50 |
| bobh | ouch | 02:51 |
| rakhmerov | I just barely recovered actually ) | 02:51 |
| bobh | lots of frequent flier miles | 02:51 |
| rakhmerov | yep | 02:51 |
| rakhmerov | hahah ) | 02:51 |
| bobh | quick question before I call it a night: | 02:51 |
| rakhmerov | yes, sure | 02:51 |
| rakhmerov | fire away | 02:51 |
| bobh | right now there is a restriction that there can't be the same task name twice in an on-complete/success/error statement | 02:52 |
| bobh | which is easy to enforce in the case of a simple task name | 02:52 |
| rakhmerov | yes | 02:52 |
| bobh | but when the task has parameters or is a dict with a condition it's a lot harder to enforce in the language definition | 02:53 |
| rakhmerov | task has parameters? | 02:53 |
| rakhmerov | what exactly do you mean by that? | 02:53 |
| bobh | lol - good question - I was hoping you could tell me | 02:53 |
| rakhmerov | well, in fact, tasks don't have parameters (yet) | 02:54 |
| bobh | it was one of the test cases I found in the code when I was working on this patchset | 02:54 |
| rakhmerov | there's a BP to add kind of explicit task parameters | 02:54 |
| rakhmerov | yes | 02:54 |
| rakhmerov | ok | 02:54 |
| bobh | ok, well there were test cases for it so it's supported in the language | 02:54 |
| rakhmerov | so, now we don't have parameters, tasks simply take what's needed from the data flow context and define input parameters for their actions | 02:55 |
| bobh | but if the same task is listed with different parameters or as a dict with different conditions we can't detect that with uniqueItems | 02:55 |
| rakhmerov | in the language may be, yes | 02:55 |
| rakhmerov | oooh! | 02:55 |
| rakhmerov | wait a second | 02:55 |
| *** yangyapeng has quit IRC | 02:55 | |
| rakhmerov | yes, all we support now as far as parameters is "msg" | 02:56 |
| *** yangyapeng has joined #openstack-mistral | 02:56 | |
| rakhmerov | it's when we use built-in engine commands instead of tasks such as "succeed", "fail" etc. | 02:56 |
| rakhmerov | we can do it as fail(msg='Failing because of X,Y,Z') | 02:57 |
| bobh | so the parameter gets placed ed into the context or is just used by the engine/executor? | 02:57 |
| rakhmerov | and this case it will be reflected in state_info of workflow execution object | 02:57 |
| rakhmerov | no, it doesn't go to the context | 02:57 |
| rakhmerov | it just changes "state_info" | 02:57 |
| bobh | ok | 02:57 |
| rakhmerov | there's a pair of fields "state" and "state_info". In my example, "fail" sets "state" to ERROR and "msg" assigns a value to "state_info" | 02:59 |
| bobh | cool - that's a good way to pass information upstream | 02:59 |
| rakhmerov | which is logical, we set a state and a message that provides more info about why we switched to this state | 02:59 |
| rakhmerov | yes | 02:59 |
| bobh | I added a bunch of error-case checks for 499790 but the one thing I noticed is the duplicate task names are still possible with parameters or conditions, so maybe that needs to be checked later in the workflow creation process | 03:00 |
| rakhmerov | yes | 03:00 |
| rakhmerov | generally speaking, I'm not sure we need to deny duplicates | 03:00 |
| rakhmerov | why not have them? | 03:00 |
| rakhmerov | I may want to run two or three instances of the same task after completion of a task | 03:01 |
| bobh | That's what I was thinking too | 03:01 |
| bobh | just wasnt sure if it was supported | 03:01 |
| rakhmerov | even our workflow model allows many instance of the same task | 03:01 |
| rakhmerov | it is supported | 03:02 |
| rakhmerov | e.g. when we have cycles | 03:02 |
| rakhmerov | A -> B -> A | 03:02 |
| rakhmerov | in this case we may have more than 1 instance of A | 03:02 |
| bobh | great - then I think I have covered most of the corner cases - I'm sure someone will find some obscure case that I didn't cover | 03:02 |
| rakhmerov | we don't generally recommend to use cycles (and they don't work with joins completely) but we support them | 03:03 |
| rakhmerov | ok | 03:03 |
| bobh | let me know if you see anything missing | 03:04 |
| rakhmerov | ok, sure | 03:04 |
| rakhmerov | I'll try to review today | 03:04 |
| bobh | Thanks! I'm going to work on the join: all/partial/any whatever we want to call it spec this week | 03:05 |
| bobh | I'd like to get that into queens | 03:05 |
| bobh | I have conflict for the weekly meeting this week so probably won't make it | 03:05 |
| rakhmerov | ooh, you mean that kind of "positive" join that we discussed? | 03:05 |
| bobh | yes | 03:05 |
| rakhmerov | bobh: no issue with meetings. Actually some teams are moving away from having weekly meetings at all | 03:06 |
| rakhmerov | we still have them but they are not so representative, two many time zones etc. | 03:06 |
| bobh | I also need to ping Winson on the notifications and see where he's at - I'd really like to get something into queens and I have some specific notifier types I'd like to support | 03:06 |
| bobh | that's true | 03:07 |
| rakhmerov | we're thinking to cancel them too and have them only "on demand" | 03:07 |
| bobh | it's nice to get together but hard to get everyone involved | 03:07 |
| rakhmerov | bobh: ok, cool | 03:07 |
| rakhmerov | yes | 03:07 |
| bobh | rakhmerov: I'm going to call it a night - have a good day! | 03:07 |
| rakhmerov | thank you ) | 03:08 |
| rakhmerov | good night | 03:08 |
| *** bobh has quit IRC | 03:08 | |
| *** zhurong has quit IRC | 03:08 | |
| *** zhurong has joined #openstack-mistral | 03:11 | |
| *** gkadam has joined #openstack-mistral | 03:38 | |
| *** gkadam has quit IRC | 03:39 | |
| *** gkadam has joined #openstack-mistral | 03:39 | |
| *** Dinesh_Bhor has joined #openstack-mistral | 04:14 | |
| *** livelace has joined #openstack-mistral | 05:03 | |
| openstackgerrit | junbo.li proposed openstack/mistral master: TrivialFix: Fix error ignore directory in .gitignore https://review.openstack.org/504298 | 05:16 |
| *** zhurong has quit IRC | 05:21 | |
| apetrich | Morning | 06:11 |
| rakhmerov | apetrich: good morning ) | 06:12 |
| rakhmerov | how are you feeling? | 06:12 |
| apetrich | rakhmerov, better! thank you! | 06:13 |
| rakhmerov | :) | 06:14 |
| rakhmerov | ok | 06:14 |
| *** zhurong has joined #openstack-mistral | 06:15 | |
| *** zhurong has quit IRC | 07:14 | |
| *** zhurong has joined #openstack-mistral | 07:32 | |
| *** shardy has joined #openstack-mistral | 07:55 | |
| *** jpich has joined #openstack-mistral | 07:55 | |
| *** gkadam is now known as gkadam-afk | 07:55 | |
| *** zhurong has quit IRC | 08:32 | |
| *** gkadam-afk is now known as gkadam | 08:41 | |
| *** oidgar has joined #openstack-mistral | 08:46 | |
| *** zhurong has joined #openstack-mistral | 08:52 | |
| *** jaosorior has joined #openstack-mistral | 09:28 | |
| *** livelace has quit IRC | 10:03 | |
| *** zhurong has quit IRC | 10:21 | |
| *** zhurong has joined #openstack-mistral | 10:24 | |
| *** jkilpatr has joined #openstack-mistral | 10:48 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 10:58 | |
| *** AlexeyAbashkin has quit IRC | 11:00 | |
| *** yangyapeng has quit IRC | 11:05 | |
| *** livelace has joined #openstack-mistral | 11:06 | |
| *** bobh has joined #openstack-mistral | 11:36 | |
| *** dprince has joined #openstack-mistral | 12:01 | |
| *** bobh has quit IRC | 12:12 | |
| *** yangyapeng has joined #openstack-mistral | 12:20 | |
| *** thrash|bbl is now known as thrash | 12:24 | |
| *** gkadam has quit IRC | 12:36 | |
| *** zhurong has quit IRC | 12:50 | |
| *** oidgar has quit IRC | 12:59 | |
| *** jistr is now known as jistr|mtg | 13:03 | |
| *** toure_biab is now known as toure|gone | 13:06 | |
| *** toure|gone is now known as toure | 13:06 | |
| *** oidgar has joined #openstack-mistral | 13:15 | |
| *** jistr|mtg is now known as jistr | 13:29 | |
| toure | apetrich your back, welcome to the land of the living :) | 13:30 |
| apetrich | toure, cheers mate. | 13:56 |
| * apetrich considers if provisional living is a better title | 13:56 | |
| toure | :) | 13:57 |
| *** chlong has joined #openstack-mistral | 13:57 | |
| *** oidgar has quit IRC | 14:13 | |
| *** livelace2 has joined #openstack-mistral | 14:20 | |
| rakhmerov | toure, apetrich, thrash, rbrady: hi | 14:24 |
| rakhmerov | do we need a meeting today? | 14:24 |
| rakhmerov | we can have it and we can skip it ) (d0ugal and bobh won't join) | 14:25 |
| *** bobh has joined #openstack-mistral | 14:25 | |
| toure | rakhmerov I don't have anything pressing... | 14:26 |
| rakhmerov | ok | 14:26 |
| thrash | rakhmerov: I only have one outstanding review, and it's tiny: https://review.openstack.org/#/c/506761/ | 14:26 |
| thrash | docs | 14:26 |
| *** oidgar has joined #openstack-mistral | 14:26 | |
| rakhmerov | yeah, ok ) | 14:26 |
| rbrady | I don't have anything pressing. I've been reviewing d0ugal's context patches | 14:26 |
| rakhmerov | thrash: any progress on castellan/custodia thing? | 14:26 |
| thrash | rakhmerov: rbrady has been working on that. | 14:27 |
| rakhmerov | rbrady: ok Ryan | 14:27 |
| rakhmerov | ooh, ok | 14:27 |
| rakhmerov | rbrady: ? | 14:27 |
| rbrady | rakhmerov: I started a POC, I have custodia running, working on adding castellan now | 14:27 |
| thrash | rakhmerov: https://review.openstack.org/#/c/504298/9 how do you feel about this one? | 14:27 |
| rakhmerov | awesome | 14:27 |
| toure | rakhmerov yeah I did give that re-run execution spec a shot, let me know what you think https://review.openstack.org/#/c/506652/ | 14:27 |
| thrash | rakhmerov: I have the opinion that generated files should not be committed to git... | 14:27 |
| toure | it is rough | 14:27 |
| rakhmerov | thrash: honestly, haven't looked at it yet (very busy this week with internal things) | 14:27 |
| thrash | rakhmerov: ack | 14:28 |
| rakhmerov | thrash: true | 14:28 |
| rakhmerov | ok, so seems like we just have a bunch of reviews! | 14:28 |
| rakhmerov | :) | 14:28 |
| thrash | rakhmerov: I suppose so lol | 14:28 |
| rakhmerov | I'll review everything this week and ask others to do it | 14:28 |
| rakhmerov | ok, then let's skip the meeting today | 14:29 |
| toure | I guess we just had the meeting :) | 14:29 |
| rakhmerov | thanks for your updates :) | 14:29 |
| rakhmerov | toure: right, haha ) | 14:29 |
| rakhmerov | it was quick and very efficient | 14:29 |
| toure | yup | 14:29 |
| rakhmerov | ok, have a good week! | 14:29 |
| toure | you too :) | 14:29 |
| *** livelace2 has quit IRC | 14:35 | |
| *** livelace2 has joined #openstack-mistral | 14:49 | |
| openstackgerrit | junbo.li proposed openstack/mistral master: TrivialFix: Add doc/build directory in .gitignore https://review.openstack.org/504298 | 14:52 |
| *** bobh has quit IRC | 14:57 | |
| *** katkapilatova has quit IRC | 15:31 | |
| *** oidgar has quit IRC | 15:33 | |
| *** oidgar has joined #openstack-mistral | 15:50 | |
| *** bobh has joined #openstack-mistral | 15:57 | |
| *** oidgar has quit IRC | 16:02 | |
| *** bobh has quit IRC | 16:03 | |
| *** Dinesh_Bhor has quit IRC | 16:07 | |
| *** oidgar has joined #openstack-mistral | 16:15 | |
| *** katkapilatova has joined #openstack-mistral | 16:17 | |
| *** jpich has quit IRC | 16:21 | |
| *** gkadam has joined #openstack-mistral | 16:24 | |
| *** oidgar has quit IRC | 16:33 | |
| *** gkadam has quit IRC | 16:42 | |
| *** vishwanathj has joined #openstack-mistral | 16:45 | |
| *** livelace2 has quit IRC | 16:47 | |
| *** bobh has joined #openstack-mistral | 16:47 | |
| *** livelace has quit IRC | 16:59 | |
| *** livelace2 has joined #openstack-mistral | 17:01 | |
| *** chlong has quit IRC | 17:10 | |
| *** harlowja has joined #openstack-mistral | 17:20 | |
| *** chlong has joined #openstack-mistral | 17:28 | |
| *** thrash is now known as thrash|biab | 17:29 | |
| *** oidgar has joined #openstack-mistral | 17:32 | |
| *** livelace2 has quit IRC | 18:12 | |
| *** livelace2 has joined #openstack-mistral | 18:25 | |
| *** livelace2 has quit IRC | 18:30 | |
| *** livelace2 has joined #openstack-mistral | 18:38 | |
| *** thrash|biab is now known as thrash | 18:41 | |
| *** livelace2 has quit IRC | 18:44 | |
| *** yangyape_ has joined #openstack-mistral | 18:54 | |
| *** yangyapeng has quit IRC | 18:55 | |
| *** livelace2 has joined #openstack-mistral | 18:56 | |
| *** rbrady is now known as rbrady-afk | 19:01 | |
| *** chlong has quit IRC | 19:06 | |
| *** toure is now known as toure_biab | 19:30 | |
| *** chlong has joined #openstack-mistral | 19:31 | |
| *** oidgar has quit IRC | 19:46 | |
| *** oidgar has joined #openstack-mistral | 19:49 | |
| *** oidgar has quit IRC | 20:02 | |
| *** chlong has quit IRC | 20:05 | |
| *** dprince has quit IRC | 20:19 | |
| *** dprince has joined #openstack-mistral | 20:47 | |
| *** jtomasek has quit IRC | 20:57 | |
| openstackgerrit | Mike Fedosin proposed openstack/python-mistralclient master: Fix several problems in keycloak auth module https://review.openstack.org/507269 | 21:00 |
| openstackgerrit | Mike Fedosin proposed openstack/python-mistralclient master: Fix several problems in keycloak auth module https://review.openstack.org/507269 | 21:02 |
| openstackgerrit | Mike Fedosin proposed openstack/python-mistralclient master: Fix several problems in keycloak auth module https://review.openstack.org/507269 | 21:17 |
| *** chlong has joined #openstack-mistral | 21:20 | |
| *** jtomasek has joined #openstack-mistral | 21:27 | |
| *** chlong has quit IRC | 21:27 | |
| *** chlong has joined #openstack-mistral | 21:28 | |
| *** jtomasek has quit IRC | 21:28 | |
| *** dprince has quit IRC | 21:46 | |
| *** shardy has quit IRC | 21:47 | |
| openstackgerrit | Bob Haddleton proposed openstack/mistral master: Allow mistral actions to run when authentication is not configured. https://review.openstack.org/506959 | 23:03 |
| *** bobh has quit IRC | 23:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!