| *** threestrands has joined #openstack-mistral | 00:05 | |
| *** threestrands has quit IRC | 00:05 | |
| *** threestrands has joined #openstack-mistral | 00:05 | |
| *** yangyapeng has quit IRC | 00:20 | |
| *** apetrich has joined #openstack-mistral | 00:32 | |
| *** bobh has joined #openstack-mistral | 00:46 | |
| *** bobh has quit IRC | 00:49 | |
| *** bobh has joined #openstack-mistral | 00:55 | |
| *** bobh has quit IRC | 00:58 | |
| *** daidv has joined #openstack-mistral | 01:02 | |
| *** daidv_ has joined #openstack-mistral | 01:03 | |
| *** yangyapeng has joined #openstack-mistral | 01:19 | |
| *** zhurong has joined #openstack-mistral | 01:21 | |
| *** bobh has joined #openstack-mistral | 01:50 | |
| *** bobh has quit IRC | 02:03 | |
| *** bobh has joined #openstack-mistral | 02:25 | |
| *** apetrich has quit IRC | 02:28 | |
| *** bobh has quit IRC | 02:33 | |
| *** bobh has joined #openstack-mistral | 02:33 | |
| *** bobh has quit IRC | 03:28 | |
| *** zhurong has quit IRC | 03:43 | |
| *** threestrands_ has joined #openstack-mistral | 05:02 | |
| *** threestrands has quit IRC | 05:04 | |
| *** threestrands_ has quit IRC | 05:14 | |
| *** nguyentrihai has joined #openstack-mistral | 05:14 | |
| *** gkadam has joined #openstack-mistral | 05:38 | |
| *** gkadam has quit IRC | 05:50 | |
| *** gkadam has joined #openstack-mistral | 05:51 | |
| *** gkadam has quit IRC | 06:19 | |
| *** brunograz has quit IRC | 07:45 | |
| *** brunograz has joined #openstack-mistral | 08:01 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 08:21 | |
| *** jpich has joined #openstack-mistral | 08:34 | |
| *** brunograz has quit IRC | 08:39 | |
| *** gkadam has joined #openstack-mistral | 08:42 | |
| *** apetrich has joined #openstack-mistral | 09:02 | |
| *** apetrich has quit IRC | 09:12 | |
| *** apetrich has joined #openstack-mistral | 09:24 | |
| *** shardy has joined #openstack-mistral | 09:29 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Revert "zuul: update tripleo zuul v3 jobs" https://review.openstack.org/522769 | 10:21 |
|---|---|---|
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Revert "Updated from global requirements" https://review.openstack.org/522770 | 10:25 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: [DNM] What is the token https://review.openstack.org/522773 | 10:34 |
| *** daidv has quit IRC | 10:59 | |
| *** daidv_ has quit IRC | 10:59 | |
| *** dtantsur|afk is now known as dtantsur | 11:26 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: [DNM] Heat debug output https://review.openstack.org/522787 | 11:41 |
| *** yangyapeng has quit IRC | 12:00 | |
| therve | d0ugal, Looks like you're scratching for something | 12:31 |
| *** yangyapeng has joined #openstack-mistral | 12:32 | |
| d0ugal | therve: aye | 12:42 |
| d0ugal | therve: I am so confused :) | 12:42 |
| therve | d0ugal, What's going on? | 12:42 |
| d0ugal | therve: https://bugs.launchpad.net/tripleo/+bug/1733345 | 12:43 |
| openstack | Launchpad bug 1733345 in tripleo "Master promotion: error creating the default Deployment Plan overcloud" [Critical,In progress] - Assigned to wes hayutin (weshayutin) | 12:43 |
| d0ugal | therve: see my last comment | 12:43 |
| therve | d0ugal, So the session fix wasn't enough? | 12:44 |
| d0ugal | therve: no, that done nothing. | 12:44 |
| therve | Sweet | 12:44 |
| d0ugal | some clients use sessions now, some don't | 12:44 |
| d0ugal | but they are all broken AFAICT | 12:44 |
| d0ugal | therve: it passes in normal CI but fails in tripleo promotion and mistrals tempest tests | 12:45 |
| d0ugal | so there is something different in the envs, but I don't know waht | 12:45 |
| therve | d0ugal, What is "normal CI" ? | 12:45 |
| d0ugal | therve: tripleo's non-promotion jobs | 12:45 |
| therve | d0ugal, Which uses a "old" version of... stuff? | 12:45 |
| d0ugal | therve: I guess, but I'm not sure what exactly. | 12:47 |
| d0ugal | therve: Mistral's tempest shouldn't use old stuff tho' | 12:48 |
| * d0ugal finds an example | 12:48 | |
| d0ugal | therve: https://review.openstack.org/520429 - passes tripleo but devstack has auth errors. | 12:49 |
| d0ugal | http://logs.openstack.org/29/520429/2/check/mistral-devstack-dsvm/325f26c/job-output.txt.gz#_2017-11-16_12_03_36_236684 | 12:49 |
| d0ugal | the auth errors there are very similar to what we are seeing in the tripleo promotion | 12:49 |
| *** bobh has joined #openstack-mistral | 12:50 | |
| d0ugal | I was trying to get the keystone token so I could manually check it works (not sure how you do that bit yet) | 12:50 |
| d0ugal | but I wasn't able to get the token. | 12:50 |
| d0ugal | We have an env with the issue that you can access if you want to dig in :) | 12:50 |
| d0ugal | I am about to go out for a bit for lunch tho' - but apetrich can add your keys. | 12:50 |
| d0ugal | therve: when I tried to get the token it appeared to be a string "***" - I am not sure if there is fancy masking going on or if somehow we have a masked vrsion of the token that we are trying to use | 12:52 |
| d0ugal | anyway, I need a break. | 12:52 |
| d0ugal | back in a bit | 12:52 |
| *** bobh has quit IRC | 12:53 | |
| therve | d0ugal, OK, I'll try to have a look :) | 13:00 |
| therve | Oh those jobs are non-voting :/ | 13:01 |
| therve | d0ugal, Think I've found :) | 13:23 |
| therve | It's jaosorior's fault | 13:26 |
| therve | d0ugal, https://github.com/openstack/mistral/blob/master/mistral/context.py#L63 and https://review.openstack.org/#/c/518244/ | 13:27 |
| *** openstackgerrit has quit IRC | 13:32 | |
| therve | 'This method is not named "to_dict"' to avoid recursive call.' What? This is all kind of wrong... | 13:38 |
| jaosorior | therve: oh; should probably not use that function | 13:39 |
| jaosorior | as discussed with the oslo folks | 13:39 |
| therve | jaosorior, Probably, right? :) | 13:39 |
| jaosorior | it's ONLY for logging | 13:39 |
| jaosorior | use to_dict if you want to use the actual token and such | 13:39 |
| jaosorior | afterwards you can use that function if you want to log the value. | 13:40 |
| jaosorior | but yeah, sorry for breaking you guys; wasn't intentional | 13:40 |
| therve | jaosorior, Yeah I'm just teasing you, this code is horribly broken | 13:40 |
| jaosorior | therve: well, oslo could have better docs | 13:41 |
| therve | Sure. get_logging_values is somewhat self documenting though :) | 13:42 |
| jaosorior | touché | 13:44 |
| jaosorior | therve: how is convert_to_dict used? | 13:46 |
| therve | jaosorior, Serialize context between mistral components | 13:46 |
| jaosorior | therve: serialize it for what? is it being copied around? | 13:46 |
| therve | jaosorior, Yeah it's passed through Rabbit | 13:46 |
| jaosorior | therve: oh | 13:47 |
| jaosorior | uhm... | 13:47 |
| jaosorior | therve: does heat have the same issue? | 13:48 |
| jaosorior | therve: how does heat handle user credentials in the engine? | 13:48 |
| therve | jaosorior, No we don't call get_logging_values, we call to_dict as expected :) | 13:48 |
| jaosorior | therve: that makes sense | 13:49 |
| jaosorior | therve: The only issue of course is logging. | 13:49 |
| jaosorior | therve: do you set the context in the thread's environment? | 13:49 |
| therve | jaosorior, I guess? Not sure I follow | 13:50 |
| jaosorior | therve: nevermind :) nothing you have to worry about | 13:50 |
| jaosorior | I'll get to check out heat's logging soon enough | 13:50 |
| therve | Ah yeah | 13:50 |
| therve | It's possible it's horrib le | 13:50 |
| jaosorior | therve: I was working on some logging stuff at some point. And I want to move everything in tripleo (optionally) to output json logs directly | 13:50 |
| jaosorior | therve: using json logs, you see EVERYTHING; so that's where you notice when projects are not providing enough info for the logs, or have funky practices for handling contexts | 13:51 |
| jaosorior | therve: used to be the case that if anybody used the JSON formatter, or the fluentd formatter it would leak keystone tokens; hence that change I did for oslo.context | 13:51 |
| jaosorior | therve: it seems to me that nobody used those though. Because the code that actually put the token in the JSON structure didn't work either :D | 13:52 |
| therve | Ah I see | 13:52 |
| jaosorior | * the code that actually put the context in the JSON structure | 13:52 |
| jaosorior | so, there was no vulnerability, because it never actually worked | 13:52 |
| jaosorior | which is nice, but sad | 13:52 |
| *** openstackgerrit has joined #openstack-mistral | 13:53 | |
| openstackgerrit | Thomas Herve proposed openstack/mistral master: Don't use oslo context get_logging_values https://review.openstack.org/522822 | 13:53 |
| therve | Yeah | 13:53 |
| therve | Mostly sad :) | 13:54 |
| jaosorior | anyway, now it works :D, and it doesn't leak. | 13:54 |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Wrong handling of is_system flag at workbooks causes DB error with MySQL 5.7 https://review.openstack.org/522823 | 13:55 |
| *** Dinesh_Bhor has quit IRC | 13:57 | |
| jpich | Nice debugging work therve !! | 14:09 |
| therve | jpich, Let's see if it works first :) | 14:11 |
| *** dtantsur is now known as dtantsur|brb | 14:11 | |
| jpich | Fair enough :) | 14:11 |
| apetrich | therve, oh I see | 14:32 |
| apetrich | therve, testing now. | 14:32 |
| apetrich | therve, it works | 14:35 |
| apetrich | mistral run-action heat.stacks_list | 14:35 |
| apetrich | {"result": []} | 14:35 |
| apetrich | brilliant | 14:35 |
| therve | Sweet! | 15:03 |
| d0ugal | That is me just back | 15:04 |
| * d0ugal reads up | 15:04 | |
| apetrich | good news is good news | 15:05 |
| d0ugal | therve: thanks for the help. | 15:07 |
| d0ugal | That had been driving me mad | 15:07 |
| apetrich | that makes two of us | 15:07 |
| d0ugal | I might use this approach again. Get stuck on a problem, tell therve about it and then go and eat pizza for a while. | 15:07 |
| d0ugal | okay, now to find another reviewer. | 15:08 |
| *** AlexeyAbashkin has quit IRC | 15:12 | |
| d0ugal | So I guess in the places that it did work, an old oslo context was in use. | 15:12 |
| *** dtantsur|brb is now known as dtantsur | 15:35 | |
| *** jaosorior has quit IRC | 15:44 | |
| therve | d0ugal, Should we take the opportunity to make those tempest tests voting? | 15:53 |
| therve | (seems like my connection is flaky) | 15:53 |
| d0ugal | therve: yes, we should. | 15:59 |
| d0ugal | therve: somehow tripleo stopped being voting too | 15:59 |
| therve | Maybe in the zuul migration | 16:01 |
| *** yangyapeng has quit IRC | 17:09 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Make more CI jobs voting https://review.openstack.org/522880 | 17:10 |
| *** shardy has quit IRC | 17:13 | |
| *** dtantsur is now known as dtantsur|afk | 17:17 | |
| *** gkadam has quit IRC | 17:17 | |
| *** jpich has quit IRC | 17:59 | |
| openstackgerrit | Merged openstack/mistral master: Don't use oslo context get_logging_values https://review.openstack.org/522822 | 18:09 |
| *** yangyapeng has joined #openstack-mistral | 18:09 | |
| *** yangyapeng has quit IRC | 18:14 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:22 | |
| *** AlexeyAbashkin has quit IRC | 18:27 | |
| *** jistr has quit IRC | 19:30 | |
| *** jistr has joined #openstack-mistral | 19:31 | |
| *** jtomasek has quit IRC | 19:34 | |
| *** d0ugal has quit IRC | 20:56 | |
| *** d0ugal has joined #openstack-mistral | 21:01 | |
| *** yangyapeng has joined #openstack-mistral | 21:08 | |
| *** yangyapeng has quit IRC | 21:13 | |
| *** bobh has joined #openstack-mistral | 22:15 | |
| *** bobh has quit IRC | 23:17 | |
| *** bobh has joined #openstack-mistral | 23:36 | |
| *** yangyapeng has joined #openstack-mistral | 23:39 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Make more CI jobs voting https://review.openstack.org/522880 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!