*** bobh has quit IRC | 00:06 | |
*** rakhmerov has quit IRC | 00:16 | |
*** rakhmerov has joined #openstack-mistral | 00:19 | |
*** yangyapeng has quit IRC | 00:21 | |
*** zhurong has joined #openstack-mistral | 01:01 | |
*** yangyapeng has joined #openstack-mistral | 01:16 | |
*** bobh has joined #openstack-mistral | 01:41 | |
bobh | rakhmerov: ping | 01:42 |
---|---|---|
*** zhurong has quit IRC | 02:00 | |
*** thrash is now known as thrash|g0ne | 02:20 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 02:22 |
*** zhurong has joined #openstack-mistral | 02:29 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 03:13 |
*** threestrands has joined #openstack-mistral | 03:27 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-mistralclient master: Updated from global requirements https://review.openstack.org/520514 | 03:32 |
*** bobh has quit IRC | 04:05 | |
*** zhurong has quit IRC | 04:27 | |
*** bobh has joined #openstack-mistral | 04:33 | |
*** zhurong has joined #openstack-mistral | 04:54 | |
*** jaosorior has joined #openstack-mistral | 04:55 | |
*** bobh has quit IRC | 05:01 | |
*** threestrands has quit IRC | 05:25 | |
*** vishwana_ has joined #openstack-mistral | 05:41 | |
*** vishwanathj has quit IRC | 05:45 | |
*** zhurong has quit IRC | 07:16 | |
*** oidgar has joined #openstack-mistral | 07:26 | |
*** zhurong has joined #openstack-mistral | 07:49 | |
*** oidgar has quit IRC | 07:53 | |
*** vishwana_ has quit IRC | 08:04 | |
*** vishwanathj has joined #openstack-mistral | 08:04 | |
*** jaosorior_ has joined #openstack-mistral | 08:10 | |
*** jaosorior has quit IRC | 08:13 | |
*** jtomasek has joined #openstack-mistral | 08:16 | |
*** shardy has joined #openstack-mistral | 08:24 | |
*** gkadam has joined #openstack-mistral | 08:38 | |
d0ugal | rakhmerov: Morning | 08:40 |
chandankumar | rakhmerov: d0ugal need acks on these reviews https://review.openstack.org/#/c/524869/ and https://review.openstack.org/#/c/524868/ | 08:42 |
chandankumar | thanks :-) | 08:42 |
d0ugal | chandankumar: thanks, LGTM. rakhmerov is due back from vaction today, I think - but I have not seen him yet :) | 08:44 |
*** jaosorior_ is now known as jaosorior | 08:47 | |
openstackgerrit | Merged openstack/mistral master: Remove setting of version/release from releasenotes https://review.openstack.org/520958 | 08:55 |
*** jpich has joined #openstack-mistral | 08:56 | |
*** oidgar has joined #openstack-mistral | 09:00 | |
d0ugal | apetrich: Hey | 09:04 |
apetrich | d0ugal, hiya | 09:05 |
d0ugal | apetrich: I am trying to figure out what passes in kwargs here: https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/base.py#L40 | 09:06 |
d0ugal | Any ideas? :-D | 09:06 |
d0ugal | apetrich: http://logs.openstack.org/85/506185/20/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/d66ce3a/logs/undercloud/var/log/mistral/executor.log.txt.gz#_2017-12-04_16_43_10_007 | 09:07 |
apetrich | it used to have a context there, but I don't think it is that | 09:07 |
apetrich | oh | 09:07 |
d0ugal | I think the error is because the kwargs is empty | 09:07 |
d0ugal | but that is a guess, so maybe something totally different | 09:07 |
apetrich | HTTPaction used to pass something | 09:08 |
apetrich | also I think javascriptAction passes something in the constructor but I don't think that javascriptAction is subclassed from openstack.base | 09:09 |
d0ugal | Nah, it wont be | 09:09 |
apetrich | httpaction also is actions.action https://github.com/openstack/mistral/blob/master/mistral/actions/std_actions.py#L100 | 09:10 |
apetrich | so not that | 09:10 |
d0ugal | apetrich: oooh | 09:17 |
d0ugal | Nevermind. I thought I had a clue. I don't. | 09:19 |
d0ugal | No clues. | 09:19 |
therve | d0ugal, You mean action init arguments? | 09:47 |
d0ugal | therve: yeah, but I feel like the openstack actions are "special" | 09:47 |
therve | d0ugal, Isn't that done by the executor? | 09:47 |
d0ugal | therve: Yeah, I think so | 09:47 |
therve | d0ugal, eg https://github.com/openstack/mistral/blob/master/mistral/executors/default_executor.py#L86 | 09:48 |
d0ugal | therve: but I also thought all my changes to the executor were safe... so that leaves me puzzled :) | 09:48 |
therve | Ah :) | 09:48 |
d0ugal | https://review.openstack.org/#/c/506185/20 | 09:48 |
d0ugal | If you fancy a glance, because I've not worked on this for so long I have probably missed something obvious | 09:49 |
d0ugal | I was blocked by the lack of tripleo promotions for a long time | 09:49 |
therve | d0ugal, devstack tests fail in a suspicious fashion too | 09:54 |
therve | Might be easier to debug than tripleo :) | 09:54 |
d0ugal | therve: true, I was just looking those failures | 09:54 |
d0ugal | they also have far more tracebacks to reference. | 09:55 |
therve | d0ugal, You're not passing the token to the SecurityContext | 10:00 |
d0ugal | therve: oh, crap. | 10:01 |
d0ugal | I need to make that fail more obviously. | 10:01 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Pass the new ActionContext to mistral-lib https://review.openstack.org/506185 | 10:10 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use the new action context in MistralHTTPAction https://review.openstack.org/520348 | 10:10 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove the __init__ method from the test action https://review.openstack.org/513061 | 10:10 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Rename task_id to task_execution_id https://review.openstack.org/514688 | 10:10 |
d0ugal | therve: thanks for the help, you have an uncanny ability to spot things I can't :) | 10:17 |
openstackgerrit | Merged openstack/mistral-lib master: Avoid tox_install.sh for constraints support https://review.openstack.org/524799 | 10:29 |
*** daidv has quit IRC | 10:50 | |
*** daidv has joined #openstack-mistral | 11:05 | |
*** jkilpatr has quit IRC | 11:36 | |
*** katkapilatova has joined #openstack-mistral | 11:42 | |
*** jkilpatr has joined #openstack-mistral | 11:55 | |
*** oidgar is now known as oidgar__ | 11:58 | |
*** oidgar__ has quit IRC | 12:02 | |
*** oidgar__ has joined #openstack-mistral | 12:02 | |
*** oidgar__ has quit IRC | 12:03 | |
*** oidgar has joined #openstack-mistral | 12:03 | |
*** bobh has joined #openstack-mistral | 12:14 | |
openstackgerrit | Merged openstack/mistral master: Avoid tox_install.sh for constraints support https://review.openstack.org/524798 | 12:26 |
*** zhurong has quit IRC | 12:36 | |
openstackgerrit | Mike Fedosin proposed openstack/mistral master: Cache action definitions https://review.openstack.org/520218 | 12:44 |
*** zhurong has joined #openstack-mistral | 12:45 | |
*** dprince has joined #openstack-mistral | 12:58 | |
*** zhurong has quit IRC | 13:02 | |
*** zhurong has joined #openstack-mistral | 13:02 | |
*** bobh has quit IRC | 13:11 | |
*** thrash|g0ne is now known as thrash | 13:26 | |
*** zhurong has quit IRC | 13:27 | |
*** bobh has joined #openstack-mistral | 13:29 | |
*** yangyapeng has quit IRC | 13:33 | |
*** yangyapeng has joined #openstack-mistral | 13:34 | |
*** oidgar has quit IRC | 13:34 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 13:35 |
openstackgerrit | Merged openstack/python-mistralclient master: Remove setting of version/release from releasenotes https://review.openstack.org/520730 | 13:38 |
*** yangyapeng has quit IRC | 13:38 | |
*** jkilpatr has quit IRC | 13:47 | |
*** jkilpatr has joined #openstack-mistral | 13:48 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Pass the new ActionContext to mistral-lib https://review.openstack.org/506185 | 14:02 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use the new action context in MistralHTTPAction https://review.openstack.org/520348 | 14:02 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove the __init__ method from the test action https://review.openstack.org/513061 | 14:02 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Rename task_id to task_execution_id https://review.openstack.org/514688 | 14:02 |
*** oidgar has joined #openstack-mistral | 14:03 | |
openstackgerrit | Merged openstack/python-mistralclient master: Avoid tox_install.sh for constraints support https://review.openstack.org/524833 | 14:21 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 14:37 |
*** jaosorior has quit IRC | 14:46 | |
mfedosin | hello! I've updated the patch with caching of action definitions: https://review.openstack.org/#/c/520218/ | 15:05 |
mfedosin | rakhmerov: d0ugal ^ | 15:06 |
d0ugal | mfedosin: Already looking at it :) | 15:06 |
d0ugal | I think I have one comment | 15:06 |
mfedosin | I hope tempest failed not because of this | 15:06 |
mfedosin | sure :) | 15:06 |
d0ugal | mfedosin: one of the tempest tests passed (mistral-devstack-dsvm-non-apache, so I think they are okay) | 15:06 |
d0ugal | I put my brackets in weird places there, sorry :) | 15:07 |
*** shardy is now known as shardy_afk | 15:08 | |
d0ugal | mfedosin: commented | 15:11 |
mfedosin | thanks | 15:11 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 15:13 |
d0ugal | thrash: ^ I just rebased your patch. I think CI might be broken for mistralclient? I guess that is the closest we have to a fix | 15:14 |
d0ugal | This is what failed: https://review.openstack.org/#/c/520514/ | 15:14 |
d0ugal | oh, maybe it is just unstable tempest | 15:14 |
thrash | d0ugal: looking | 15:14 |
d0ugal | somewhat scary error :) http://logs.openstack.org/14/520514/2/gate/legacy-python-mistralclient-devstack-dsvm/44aae88/job-output.txt.gz#_2017-12-05_14_28_39_334369 | 15:15 |
thrash | d0ugal: uhhh yeah | 15:15 |
thrash | d0ugal: that patch depends on what I'm working on in mistral itself... | 15:16 |
d0ugal | oh | 15:16 |
thrash | I think... | 15:16 |
thrash | d0ugal: yeah... depends on https://review.openstack.org/#/c/509428/ | 15:16 |
thrash | which I'm close with... | 15:16 |
d0ugal | Right | 15:17 |
d0ugal | I'll keep tracking that one then :) | 15:17 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 15:17 |
thrash | :D | 15:17 |
thrash | right now just trying to get the tests actually running. | 15:17 |
d0ugal | thrash: it is missing tempest and tripleo? | 15:17 |
thrash | d0ugal: I've commented some of the tests out for now so since those are working. No sense in running tripleo tests for this. | 15:18 |
thrash | I'll re-enable them once I get them all working. | 15:18 |
d0ugal | k, makes sense | 15:19 |
d0ugal | I need to try and learn some of this stuff one day | 15:19 |
d0ugal | It's just a big black box to me | 15:19 |
thrash | d0ugal: I'm learning as I go. :D | 15:19 |
thrash | It's actually a lot simpler than it was. zuulv3 allows us to reuse jobs a whole lot easier. | 15:20 |
*** bobh has quit IRC | 15:30 | |
*** oidgar has quit IRC | 15:34 | |
*** shardy_afk is now known as shardy | 15:42 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 15:45 |
*** openstackgerrit has quit IRC | 15:48 | |
*** thrash is now known as thrash|biab | 15:54 | |
*** bobh has joined #openstack-mistral | 16:10 | |
*** katkapilatova has quit IRC | 16:30 | |
*** oidgar has joined #openstack-mistral | 16:38 | |
*** openstackgerrit has joined #openstack-mistral | 16:40 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 16:40 |
*** thrash|biab is now known as thrash | 16:40 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 17:06 |
*** jpich has quit IRC | 17:06 | |
*** gkadam has quit IRC | 17:30 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 17:58 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 18:00 |
*** oidgar has quit IRC | 18:10 | |
*** bobh has quit IRC | 18:32 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 18:42 |
*** shardy has quit IRC | 18:58 | |
*** gkadam has joined #openstack-mistral | 20:05 | |
*** jrist has quit IRC | 20:05 | |
*** yangyapeng has joined #openstack-mistral | 20:20 | |
*** yangyapeng has quit IRC | 20:24 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: DNM: TEST Zuul v3 jobs https://review.openstack.org/509428 | 21:14 |
*** jtomasek has quit IRC | 21:18 | |
*** jkilpatr has quit IRC | 21:35 | |
*** gkadam has quit IRC | 21:38 | |
*** jrist has joined #openstack-mistral | 21:46 | |
*** threestrands has joined #openstack-mistral | 22:05 | |
*** threestrands has quit IRC | 22:05 | |
*** threestrands has joined #openstack-mistral | 22:05 | |
*** dprince has quit IRC | 22:18 | |
*** yangyapeng has joined #openstack-mistral | 23:51 | |
*** yangyapeng has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!