| *** d0ugal has joined #openstack-mistral | 00:04 | |
| *** yangyapeng has joined #openstack-mistral | 00:27 | |
| *** yangyapeng has quit IRC | 00:31 | |
| *** bobh has joined #openstack-mistral | 00:39 | |
| *** d0ugal has quit IRC | 00:40 | |
| *** d0ugal has joined #openstack-mistral | 00:51 | |
| *** bobh has quit IRC | 01:14 | |
| *** bobh has joined #openstack-mistral | 01:14 | |
| *** yangyapeng has joined #openstack-mistral | 01:16 | |
| *** yangyapeng has quit IRC | 01:17 | |
| *** yangyapeng has joined #openstack-mistral | 01:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral master: Updated from global requirements https://review.openstack.org/528872 | 01:23 |
|---|---|---|
| *** vishwanathj has joined #openstack-mistral | 01:30 | |
| *** bobh has quit IRC | 02:20 | |
| *** bobh has joined #openstack-mistral | 02:21 | |
| *** bobh has quit IRC | 02:24 | |
| *** bobh has joined #openstack-mistral | 02:24 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 02:38 | |
| *** AlexeyAbashkin has quit IRC | 02:43 | |
| *** bobh has quit IRC | 02:52 | |
| *** bobh has joined #openstack-mistral | 02:53 | |
| *** bobh has quit IRC | 03:17 | |
| *** bobh has joined #openstack-mistral | 04:00 | |
| *** bobh has quit IRC | 04:04 | |
| *** {aborted} is now known as chandankumar | 05:43 | |
| openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/528872 | 06:13 |
| rakhmerov | apetrich: hi | 06:32 |
| *** gkadam has joined #openstack-mistral | 06:38 | |
| *** _gryf has joined #openstack-mistral | 06:59 | |
| *** shardy has joined #openstack-mistral | 07:37 | |
| *** shardy has quit IRC | 07:37 | |
| *** shardy has joined #openstack-mistral | 07:41 | |
| *** _gryf has quit IRC | 07:52 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:52 | |
| *** d0ugal has quit IRC | 08:03 | |
| *** d0ugal has joined #openstack-mistral | 08:07 | |
| *** kushalagrawal has joined #openstack-mistral | 08:15 | |
| d0ugal | rakhmerov: Hey | 08:37 |
| rakhmerov | d0ugal: hi | 08:37 |
| d0ugal | rakhmerov: apetrich is on vacation today and tomorrow. | 08:37 |
| rakhmerov | yep, ok | 08:37 |
| rakhmerov | his patch is approved | 08:37 |
| d0ugal | I spotted :) thanks! | 08:37 |
| rakhmerov | :) | 08:37 |
| rakhmerov | we have a failing test again in our client https://review.openstack.org/#/c/528907/ | 08:38 |
| rakhmerov | did you happen to look at it? | 08:39 |
| d0ugal | rakhmerov: no, I think the mistralclient CI has been broken for a while now | 08:39 |
| rakhmerov | hm.. | 08:39 |
| rakhmerov | ok | 08:39 |
| *** jtomasek has joined #openstack-mistral | 08:39 | |
| rakhmerov | you mean it's been going on for a long time? | 08:39 |
| rakhmerov | how long? | 08:39 |
| d0ugal | I think maybe CI is just incorrectly configured? | 08:39 |
| d0ugal | Not sure. | 08:39 |
| rakhmerov | ok | 08:39 |
| d0ugal | When did something last merge? :) | 08:40 |
| rakhmerov | not sure. | 08:40 |
| rakhmerov | need to check | 08:40 |
| d0ugal | mistralclient doesn't get many patches. | 08:40 |
| rakhmerov | yep | 08:40 |
| d0ugal | https://review.openstack.org/521572 | 08:40 |
| d0ugal | I think that was the last patch to pass CI | 08:40 |
| d0ugal | (and merge) | 08:40 |
| rakhmerov | yep, right | 08:41 |
| rakhmerov | ok, I'll look at it later | 08:42 |
| d0ugal | Thanks, I can try too | 08:42 |
| d0ugal | but I'm not sure I'll have time this week - and then holidays. | 08:42 |
| rakhmerov | I understand | 08:42 |
| rakhmerov | I think in general people are not going to be active in the next ~2 weeks, right? ) | 08:42 |
| d0ugal | right :) | 08:49 |
| d0ugal | both thrash|g0ne and toure|gone have finished for the holidays already | 08:49 |
| rakhmerov | ooh, ok | 08:51 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Disable unstable tempest test_run_ssh_proxied_action test https://review.openstack.org/528999 | 08:58 |
| d0ugal | rakhmerov: ^ that test blocked both apetrich and thrash's patches. | 08:59 |
| rakhmerov | yes, I know about it | 08:59 |
| rakhmerov | I'm actually in favor of approving it with 1 +2 | 08:59 |
| d0ugal | rakhmerov: sure, it is fairly low risk :) | 09:00 |
| d0ugal | I could +2 it also ;) | 09:00 |
| rakhmerov | :) | 09:00 |
| rakhmerov | as you wish, sir :) | 09:00 |
| chandankumar | d0ugal: rakhmerov just an update tempest plugin split work block on mistral packaging change which is block on rdo cloud | 09:01 |
| d0ugal | chandankumar: k, thanks. | 09:01 |
| d0ugal | chandankumar: hopefully it is fixed soon, it also blocks me :( | 09:02 |
| *** jpich has joined #openstack-mistral | 09:29 | |
| therve | d0ugal, Do you have a few mins to chat about https://review.openstack.org/527348 ? | 09:42 |
| d0ugal | therve: sure | 09:43 |
| therve | d0ugal, So I looked at the latest failure, and it looks "real" | 09:44 |
| therve | Do you know how users are setup for the tempest tests? | 09:44 |
| therve | I wonder if they have the admin role | 09:44 |
| d0ugal | I've been meaning to take a look, but I forgot. | 09:44 |
| d0ugal | No, I've not learned how that works yet | 09:44 |
| therve | If they do, there is somewhat a bug wrt to admin deleting workflow by names | 09:44 |
| d0ugal | Interesting. | 09:44 |
| *** yangyapeng has quit IRC | 09:45 | |
| rakhmerov | as far as I remember there are two clients in the tempest tests: one with a regular user role and another one with admin | 09:45 |
| d0ugal | chandankumar: ^ do you know? | 09:46 |
| d0ugal | Oh, yeah, I seen the multiple clients. | 09:46 |
| d0ugal | https://github.com/openstack/mistral/blob/master/mistral_tempest_tests/tests/base.py#L56-L61 | 09:47 |
| therve | Right there are 2 client instances | 09:47 |
| d0ugal | therve, rakhmerov ^ | 09:47 |
| therve | But in theory we use the non-admin one | 09:47 |
| rakhmerov | yes | 09:47 |
| d0ugal | right | 09:47 |
| therve | I'm talking about that error http://logs.openstack.org/48/527348/4/check/mistral-devstack-dsvm-non-apache/f6bae24/job-output.txt.gz#_2017-12-14_07_51_20_765379 | 09:48 |
| therve | AFAIU, it would only happen if you're first able to get the object, but then delete is protected | 09:48 |
| therve | Wait no, not that one | 09:49 |
| therve | http://logs.openstack.org/48/527348/4/check/mistral-devstack-dsvm-non-apache/f6bae24/job-output.txt.gz#_2017-12-14_07_51_21_007048 | 09:49 |
| chandankumar | in tempest there are two users one is admin and another is normal user starting with alt | 09:49 |
| rakhmerov | therve: the last one looks like a cleanup problem in tests | 09:50 |
| therve | Yeah I'm getting confused | 09:50 |
| therve | rakhmerov, OK so it is http://logs.openstack.org/48/527348/4/check/mistral-devstack-dsvm-non-apache/f6bae24/job-output.txt.gz#_2017-12-14_07_51_20_765379 | 09:50 |
| therve | And the second one is probably a side effect of that one | 09:51 |
| rakhmerov | btw, this error with event triggers started reproducing on all of our patches | 09:51 |
| therve | Right, to me it would happen with an admin user | 09:51 |
| rakhmerov | yes, one of them is probably a consequence of another one.. | 09:52 |
| therve | Because it can see wfs from other projects, but can't delete them | 09:52 |
| rakhmerov | therve: let me look at it.. | 09:52 |
| therve | Hum, though there is a is_admin check in check_db_obj_access as well | 09:53 |
| rakhmerov | yes, in Mistral DB API it should work | 09:53 |
| rakhmerov | maybe there's a bug there though. | 09:53 |
| rakhmerov | I wonder what the difference is between these two lines: | 09:55 |
| rakhmerov | self.client.delete_obj('event_triggers', trigger_id) | 09:55 |
| rakhmerov | self.client.event_triggers.remove(trigger_id) | 09:55 |
| therve | rakhmerov, I wonder if there is a race with test_delete_wf_with_trigger_associate_in_other_tenant | 09:57 |
| rakhmerov | hm.. strange. We seem to use the same client for creation and deletion | 09:57 |
| therve | The public scope of the workflow could mess things up? | 09:57 |
| rakhmerov | therve: where did you find this test? | 09:58 |
| d0ugal | sorry, got called away. /me reads up | 09:58 |
| therve | rakhmerov, I looked at _secure_query, and it tests either the project id, or the scope | 09:58 |
| rakhmerov | yes | 09:58 |
| rakhmerov | so? | 09:59 |
| therve | The only test that touches scope is that test | 09:59 |
| therve | And it runs just around our failures: http://logs.openstack.org/48/527348/4/check/mistral-devstack-dsvm-non-apache/f6bae24/job-output.txt.gz#_2017-12-14_07_48_54_335393 | 09:59 |
| rakhmerov | in what module is this test? | 09:59 |
| rakhmerov | trying to find it.. | 09:59 |
| therve | mistral_tempest_tests/tests/api/v2/test_workflows.py | 09:59 |
| rakhmerov | ok | 09:59 |
| rakhmerov | well, "public" reduces the security level | 10:01 |
| rakhmerov | it makes it less secure | 10:01 |
| d0ugal | rakhmerov: in those two lines - the first calls the API, the second removes the trigger from the list "cache" on the client | 10:02 |
| rakhmerov | therve: btw, in test_workflows.py I don't see where the clean up happens | 10:03 |
| rakhmerov | d0ugal: ok | 10:03 |
| therve | rakhmerov, in tearDown | 10:03 |
| rakhmerov | ooh, yeah | 10:03 |
| rakhmerov | missed it | 10:03 |
| rakhmerov | therve: maybe we need to reproduce something in the unit test to make sure that _secure_query works in all cases? | 10:04 |
| rakhmerov | with "public" etc. | 10:04 |
| rakhmerov | I though we had tested it but maybe something is wrong there | 10:05 |
| rakhmerov | the interesting thing is that it started happening not long ago | 10:05 |
| rakhmerov | maybe there were some related changes in Keystone? | 10:05 |
| rakhmerov | again | 10:05 |
| therve | I think it works, just the test puts in a condition that fails | 10:05 |
| therve | Maybe just moving tests around so that they happen more concurrently | 10:05 |
| rakhmerov | maybe, yes | 10:05 |
| rakhmerov | yep | 10:06 |
| rakhmerov | you know, maybe we really create such a workflow on behalf of admin somewhere? | 10:06 |
| rakhmerov | and they run concurrently then this can happen | 10:06 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Disable unstable tempest test_run_ssh_proxied_action test https://review.openstack.org/528999 | 10:09 |
| therve | Hummmm | 10:15 |
| therve | rakhmerov, Do you know about LockFixture? | 10:15 |
| d0ugal | I am failing to get my head around this | 10:15 |
| therve | I feel that the problem is that LockFixture isn't used everywhere | 10:16 |
| therve | The same workflow names are used everywhere (which is a stupid idea btw) | 10:16 |
| d0ugal | +1 | 10:17 |
| d0ugal | I was trying to figure out how to make the workflow names dynamic - we might need to turn the workflow file into a jinja template or something | 10:17 |
| therve | So either we add more locks where it's missing, or we make the workflow names dynamic | 10:17 |
| therve | Well | 10:17 |
| therve | You don't need jinja, just use replace :) | 10:17 |
| d0ugal | well, sure | 10:17 |
| d0ugal | some form of template then | 10:18 |
| therve | I feel that adding more locks is never the answer, yes that'd be a good idea | 10:18 |
| d0ugal | I'll have a look into doing that | 10:20 |
| d0ugal | and I might use jinja :P | 10:20 |
| * therve shrugs | 10:21 | |
| therve | I don't think it's a great idea, but I don't have +2 :) | 10:21 |
| d0ugal | hah | 10:21 |
| d0ugal | It might be overkill, but at least it has a common understanding about what is going on | 10:21 |
| d0ugal | anyway, i'll see how I get on | 10:21 |
| rakhmerov | therve: LockFixture no :) | 10:24 |
| rakhmerov | never used it | 10:24 |
| rakhmerov | therve: you want +2? :) | 10:26 |
| rakhmerov | we can discuss that :) | 10:26 |
| therve | Yeah I don't have enough time to do reviews :) | 10:26 |
| rakhmerov | interesting, I actually thought we used dynamic names, at least in part of the tests | 10:26 |
| rakhmerov | therve: ok ) | 10:26 |
| rakhmerov | but if you change your mind let me know ) | 10:27 |
| therve | Thanks :) | 10:28 |
| d0ugal | rakhmerov: we do use dynamic names in places - but not for the workflow names in the workbook files. | 10:28 |
| rakhmerov | ooh, I see | 10:28 |
| rakhmerov | yes | 10:28 |
| d0ugal | I am going to try and change that | 10:28 |
| rakhmerov | ok, appreciate | 10:28 |
| therve | I think LockFixture is the reason the tests don't explode all the time. And as it's not used consistently, random errors happen. | 10:30 |
| rakhmerov | ok, maybe then we need to use it everywhere? | 10:31 |
| rakhmerov | but i'd like to understand first what it does exactly | 10:31 |
| therve | From what I understand it makes tests run in sequence | 10:33 |
| rakhmerov | ok | 10:37 |
| rakhmerov | but if it's for same resources then it makes sense | 10:37 |
| rakhmerov | well, yes, unless we want dynamic names.. | 10:38 |
| rakhmerov | which is a better option probably | 10:38 |
| therve | Yeah I'd say so | 10:38 |
| *** jtomasek has quit IRC | 10:38 | |
| *** jtomasek has joined #openstack-mistral | 10:39 | |
| *** jpich has quit IRC | 10:40 | |
| *** yangyapeng has joined #openstack-mistral | 10:47 | |
| *** yangyapeng has quit IRC | 10:53 | |
| rakhmerov | therve, d0ugal: also some interesting observation: I may be wrong but seems like this test fails only on "non-apache" version of devstack job | 10:55 |
| *** yangyapeng has joined #openstack-mistral | 11:03 | |
| *** yangyapeng has quit IRC | 11:08 | |
| *** AlexeyAbashkin has quit IRC | 11:22 | |
| *** yangyapeng has joined #openstack-mistral | 11:24 | |
| *** jtomasek has quit IRC | 11:29 | |
| *** yangyapeng has quit IRC | 11:29 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:38 | |
| *** yangyapeng has joined #openstack-mistral | 11:45 | |
| *** yangyapeng has quit IRC | 11:49 | |
| *** yangyapeng has joined #openstack-mistral | 12:05 | |
| *** yangyapeng has quit IRC | 12:11 | |
| *** katkapilatova has joined #openstack-mistral | 12:27 | |
| *** yangyapeng has joined #openstack-mistral | 12:29 | |
| *** yangyapeng has quit IRC | 12:34 | |
| *** weshay_pto is now known as weshay | 12:48 | |
| *** yangyapeng has joined #openstack-mistral | 12:49 | |
| *** bobh has joined #openstack-mistral | 12:52 | |
| *** bobh has quit IRC | 12:53 | |
| *** yangyapeng has quit IRC | 12:53 | |
| *** zhurong has joined #openstack-mistral | 12:59 | |
| *** zhurong has quit IRC | 13:02 | |
| *** zhurong has joined #openstack-mistral | 13:03 | |
| *** yangyapeng has joined #openstack-mistral | 13:10 | |
| *** d0ugal has quit IRC | 13:14 | |
| *** yangyapeng has quit IRC | 13:15 | |
| *** d0ugal has joined #openstack-mistral | 13:22 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Disable unstable tempest test_run_ssh_proxied_action test https://review.openstack.org/528999 | 13:24 |
| *** zhurong has quit IRC | 13:25 | |
| *** dprince has joined #openstack-mistral | 13:25 | |
| *** yangyapeng has joined #openstack-mistral | 13:30 | |
| *** yangyapeng has quit IRC | 13:35 | |
| *** d0ugal has quit IRC | 13:37 | |
| *** yangyapeng has joined #openstack-mistral | 13:39 | |
| *** d0ugal has joined #openstack-mistral | 13:39 | |
| d0ugal | thrash|g0ne: step away from the computer | 13:42 |
| *** yangyapeng has quit IRC | 13:44 | |
| *** yangyapeng has joined #openstack-mistral | 14:06 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use dynamic names for Workflows in Workbooks https://review.openstack.org/529078 | 14:10 |
| *** yangyapeng has quit IRC | 14:12 | |
| *** katkapilatova has quit IRC | 14:14 | |
| *** jtomasek has joined #openstack-mistral | 14:24 | |
| *** yangyapeng has joined #openstack-mistral | 14:24 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use dynamic names for Workflows in Workbooks https://review.openstack.org/529078 | 14:28 |
| *** yangyapeng has quit IRC | 14:29 | |
| *** yangyapeng has joined #openstack-mistral | 15:01 | |
| *** livelace has joined #openstack-mistral | 15:23 | |
| *** bobh has joined #openstack-mistral | 15:26 | |
| *** jtomasek has quit IRC | 15:50 | |
| *** livelace has quit IRC | 16:06 | |
| *** apetrich has joined #openstack-mistral | 16:08 | |
| *** rbrady is now known as rbrady-afk | 16:33 | |
| *** AlexeyAbashkin has quit IRC | 17:01 | |
| *** gkadam has quit IRC | 17:22 | |
| *** jtomasek has joined #openstack-mistral | 17:58 | |
| *** harlowja has joined #openstack-mistral | 18:15 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:22 | |
| *** AlexeyAbashkin has quit IRC | 18:27 | |
| *** bobh has quit IRC | 18:32 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:46 | |
| *** AlexeyAbashkin has quit IRC | 18:58 | |
| *** gkadam has joined #openstack-mistral | 19:03 | |
| *** rbrady-afk is now known as rbrady | 19:13 | |
| *** shardy has quit IRC | 19:14 | |
| *** openstack has joined #openstack-mistral | 19:42 | |
| *** ChanServ sets mode: +o openstack | 19:42 | |
| *** dprince has quit IRC | 19:55 | |
| *** jtomasek has quit IRC | 20:15 | |
| *** gkadam has quit IRC | 20:18 | |
| *** dprince has joined #openstack-mistral | 20:23 | |
| *** shardy has joined #openstack-mistral | 20:36 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 20:37 | |
| *** AlexeyAbashkin has quit IRC | 20:41 | |
| *** shardy has quit IRC | 22:37 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!