| *** bobh has joined #openstack-mistral | 00:04 | |
| *** weshay is now known as weshay_PTO | 00:04 | |
| *** openstackgerrit has quit IRC | 01:03 | |
| *** pengdake_ has joined #openstack-mistral | 01:04 | |
| *** yangyapeng has quit IRC | 01:12 | |
| *** yangyapeng has joined #openstack-mistral | 01:12 | |
| *** itlinux has joined #openstack-mistral | 01:15 | |
| *** mcdoker181818 has quit IRC | 01:27 | |
| *** mcdoker181818 has joined #openstack-mistral | 01:29 | |
| *** itlinux has quit IRC | 01:43 | |
| *** yangyapeng has quit IRC | 01:53 | |
| *** yangyapeng has joined #openstack-mistral | 01:54 | |
| *** bobh has quit IRC | 01:54 | |
| *** itlinux has joined #openstack-mistral | 01:56 | |
| *** mcdoker181818 has quit IRC | 01:57 | |
| *** mcdoker181818 has joined #openstack-mistral | 01:59 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 02:21 | |
| *** itlinux has quit IRC | 02:22 | |
| *** AlexeyAbashkin has quit IRC | 02:25 | |
| *** itlinux has joined #openstack-mistral | 02:26 | |
| *** itlinux has quit IRC | 02:40 | |
| *** hardikjasani has joined #openstack-mistral | 02:46 | |
| *** thrash is now known as thrash|g0ne | 02:49 | |
| *** harlowja has quit IRC | 03:04 | |
| *** mcdoker181818 has quit IRC | 03:16 | |
| *** mcdoker181818 has joined #openstack-mistral | 03:18 | |
| *** yangyapeng has quit IRC | 03:28 | |
| *** yangyapeng has joined #openstack-mistral | 03:29 | |
| *** yangyapeng has quit IRC | 03:33 | |
| *** mcdoker181818 has quit IRC | 03:51 | |
| *** mcdoker181818 has joined #openstack-mistral | 03:53 | |
| *** nsingh has left #openstack-mistral | 03:56 | |
| *** gkadam has joined #openstack-mistral | 04:04 | |
| *** pengdake_ has quit IRC | 04:11 | |
| *** openstackgerrit has joined #openstack-mistral | 04:12 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Fix a race condition with execution creation https://review.openstack.org/543501 | 04:12 |
|---|---|---|
| openstackgerrit | yatin proposed openstack/python-mistralclient master: Don't override session during auth https://review.openstack.org/543460 | 04:30 |
| *** pengdake_ has joined #openstack-mistral | 04:40 | |
| *** threestrands has quit IRC | 04:50 | |
| *** mcdoker181818 has quit IRC | 05:10 | |
| *** mcdoker181818 has joined #openstack-mistral | 05:13 | |
| *** pengdake_ has quit IRC | 05:15 | |
| *** mcdoker181818 has quit IRC | 05:21 | |
| *** mcdoker181818 has joined #openstack-mistral | 05:21 | |
| *** harlowja has joined #openstack-mistral | 05:52 | |
| *** pengdake_ has joined #openstack-mistral | 05:54 | |
| *** ykarel has joined #openstack-mistral | 05:57 | |
| ykarel | Hi, can we get +W on https://review.openstack.org/#/c/543460/ | 05:58 |
| *** itlinux has joined #openstack-mistral | 05:59 | |
| *** itlinux has quit IRC | 06:08 | |
| *** harlowja has quit IRC | 06:33 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Don't override session during auth https://review.openstack.org/543460 | 07:42 |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:48 | |
| *** d0ugal has quit IRC | 07:52 | |
| *** apetrich has quit IRC | 07:55 | |
| *** apetrich has joined #openstack-mistral | 07:56 | |
| openstackgerrit | Adriano Petrich proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client https://review.openstack.org/543447 | 07:57 |
| *** d0ugal has joined #openstack-mistral | 08:02 | |
| *** jtomasek has joined #openstack-mistral | 08:05 | |
| *** oidgar has joined #openstack-mistral | 08:26 | |
| ykarel | d0ugal, hi | 08:30 |
| ykarel | https://review.openstack.org/#/c/543846/ | 08:31 |
| ykarel | can ^^ be considered for release: https://review.openstack.org/#/c/543402 | 08:31 |
| therve | ykarel, I think we need a 3.2.1 no? | 08:42 |
| therve | d0ugal, ^^ | 08:43 |
| ykarel | both works for me | 08:43 |
| ykarel | sooner is better | 08:44 |
| apetrich | I thought we needed a to bump to 3.3 for some reason | 08:44 |
| apetrich | rakhmerov, do you recall? | 08:44 |
| therve | If we release master, maybe, but we should probably backport and release that instead | 08:45 |
| apetrich | therve, oh I see. Agreed | 08:45 |
| apetrich | why can't I +2 the backport? | 08:46 |
| therve | stable policy | 08:48 |
| apetrich | oh I didn't know that | 08:48 |
| ykarel | but i can see a +2 in https://review.openstack.org/#/c/539553/, is some policy changed recently | 08:51 |
| ykarel | or it's because of branching requirements projects | 08:51 |
| rakhmerov | apetrich: hi | 09:06 |
| rakhmerov | I was at the meeting | 09:06 |
| rakhmerov | reading.. | 09:06 |
| *** kong has quit IRC | 09:07 | |
| apetrich | rakhmerov, nothing to it. just that we need to backport the session fix to 3.2.1 on python-mistralclient | 09:07 |
| rakhmerov | ok | 09:08 |
| *** jpich has joined #openstack-mistral | 09:09 | |
| rakhmerov | apetrich: approved | 09:10 |
| apetrich | rakhmerov, cheers! | 09:11 |
| rakhmerov | I just wonder whether we need to hold on with merging https://review.openstack.org/#/c/543402/ ) | 09:11 |
| rakhmerov | and instead just change the hash in it | 09:11 |
| rakhmerov | d0ugal: what do you think? | 09:11 |
| apetrich | rakhmerov, d0ugal will bbiab | 09:17 |
| rakhmerov | ? | 09:17 |
| rakhmerov | not sure what that means ) | 09:18 |
| *** ykarel is now known as ykarel|lunch | 09:22 | |
| apetrich | rakhmerov, sorry he's out and be back later | 09:28 |
| apetrich | or in a bit | 09:28 |
| rakhmerov | ok | 09:31 |
| *** gkadam_ has joined #openstack-mistral | 09:34 | |
| *** gkadam has quit IRC | 09:36 | |
| *** pengdake_ has quit IRC | 10:05 | |
| *** ykarel|lunch is now known as ykarel | 10:13 | |
| *** shardy has quit IRC | 10:19 | |
| *** shardy has joined #openstack-mistral | 10:21 | |
| *** thrash|g0ne is now known as thrash | 11:06 | |
| d0ugal | rakhmerov, apetrich - back now. | 11:11 |
| rakhmerov | yep | 11:11 |
| d0ugal | apetrich, therve - 3.3 was because there is a feature addition | 11:12 |
| d0ugal | I am not sure if we should release 3.3.0 and 3.2.1 | 11:13 |
| d0ugal | or just 3.3.0 | 11:13 |
| d0ugal | apetrich: https://review.openstack.org/#/c/543447/ | 11:14 |
| d0ugal | Looks like we still have a tripleo failure, so lets see if that is legit first | 11:14 |
| d0ugal | Interesting. Not seen this before. | 11:15 |
| d0ugal | http://logs.openstack.org/47/543447/3/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/4036573/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-02-13_08_49_27 | 11:15 |
| *** shardy has quit IRC | 11:20 | |
| *** shardy has joined #openstack-mistral | 11:21 | |
| *** shardy has quit IRC | 11:35 | |
| *** ykarel is now known as ykarel|afk | 11:36 | |
| *** mwhahaha has quit IRC | 11:51 | |
| *** mwhahaha has joined #openstack-mistral | 11:52 | |
| *** shardy has joined #openstack-mistral | 11:52 | |
| d0ugal | I think the refactor that landed changed the exception that is raised by mistralclient, which is a big issue. | 11:57 |
| d0ugal | https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L1765 | 11:57 |
| d0ugal | That is where tripleo is failing now, but the exception isn't handled, because it is wrong. I assume this is because it changed | 11:57 |
| apetrich | oh that failure is expected. | 12:00 |
| d0ugal | aye | 12:01 |
| d0ugal | apetrich: on every new install | 12:02 |
| d0ugal | apetrich: upgrades etc. will already have it. | 12:02 |
| apetrich | oh true | 12:02 |
| *** portdirect has quit IRC | 12:03 | |
| *** portdirect has joined #openstack-mistral | 12:04 | |
| *** akazakov has joined #openstack-mistral | 12:06 | |
| d0ugal | jaosorior: How well do you remember this patch? :) https://review.openstack.org/#/c/455174/ | 12:11 |
| d0ugal | jaosorior: I am wondering if it could have changed the exceptions that mistralclient raises | 12:11 |
| d0ugal | hmm | 12:12 |
| d0ugal | but that should have been in 3.1.4, so it should be fine | 12:12 |
| d0ugal | apetrich: https://github.com/openstack/python-mistralclient/compare/3.1.4...3.2.0 | 12:12 |
| apetrich | d0ugal, was it released? why are we just seeing those errors | 12:12 |
| apetrich | d0ugal, looking | 12:12 |
| apetrich | that does not seems messy at all | 12:13 |
| d0ugal | apetrich: yeah, that patch I linked was in 3.1.4, so ignore that | 12:13 |
| d0ugal | but the regression should be in that range of commits | 12:13 |
| therve | d0ugal, I don't think it's in 3.1.4 | 12:14 |
| therve | Same issue as yesterday | 12:14 |
| apetrich | therve, aye, but I still didn't get why are we seeing those old regressions just now. Do you know why? | 12:15 |
| jaosorior | d0ugal: this part could change the exceptions https://review.openstack.org/#/c/455174/69/mistralclient/api/httpclient.py although, in some cases we were already using the keystone session object. | 12:15 |
| jaosorior | d0ugal: this attempted to catch the exceptions though https://review.openstack.org/#/c/455174/69/mistralclient/api/base.py | 12:16 |
| d0ugal | jaosorior: for context, we are seeing this error: http://logs.openstack.org/47/543447/3/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/7857e17/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-02-13_11_46_01 | 12:16 |
| d0ugal | jaosorior: and I think it is because this exception changed: https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L1766 | 12:16 |
| d0ugal | therve: yeah, you are correct - that patch never made it into 3.1.4. I got confused by the dates. | 12:17 |
| jaosorior | d0ugal: that sounds reasonable. Though I have no recollection on why the exception changed in this https://review.openstack.org/#/c/455174/69/mistralclient/api/base.py | 12:19 |
| *** gkadam_ has quit IRC | 12:19 | |
| d0ugal | jaosorior: k, thanks | 12:19 |
| d0ugal | I'll keep digging :) | 12:19 |
| therve | I'm pretty sure I made that change | 12:19 |
| d0ugal | lol | 12:19 |
| jaosorior | they seem to have changed in patchset 40 | 12:20 |
| d0ugal | ah | 12:20 |
| jaosorior | d0ugal: but yeah, instead of raising keystone exceptions, it raises mistral specific ones | 12:20 |
| d0ugal | I forgot so many people were involved | 12:20 |
| *** hjensas has joined #openstack-mistral | 12:21 | |
| therve | I think tests were broken, so I didn't do it gratuitously | 12:22 |
| therve | But yeah https://bugs.launchpad.net/heat/+bug/1714679 is the bug we had in heat | 12:22 |
| openstack | Launchpad bug 1714679 in OpenStack Heat "deleting stack with mistral workflow resource (already deleted) fails with error" [High,Fix released] - Assigned to Rabi Mishra (rabi) | 12:22 |
| jaosorior | d0ugal: yeah, I started the patch and at some point couldn't continue it, so sharat sharma took over, then therve was helping with it too... and who knows who else :D | 12:22 |
| therve | I suspect the undercloud bit was in a transition where we used sessions, but mistral didn't support it super well | 12:22 |
| therve | So my change was intended as a backward compatible change :/ | 12:22 |
| d0ugal | Right | 12:22 |
| therve | So we just need to fix instack I think, because raising mistral specific errors make sense | 12:23 |
| therve | *or*, we change the base class of the exceptions | 12:23 |
| d0ugal | therve: despite being backwards incompatible? | 12:23 |
| therve | So | 12:23 |
| d0ugal | I'm concerned about exception handling in other places | 12:23 |
| *** ykarel|afk is now known as ykarel | 12:23 | |
| d0ugal | I guess I could try and quickly scan tripleo-common | 12:23 |
| therve | d0ugal, If you used mistral without sessions, it raised mistral errors | 12:24 |
| therve | If you used sessions, it raised keystoneauth errors | 12:24 |
| d0ugal | oh, maybe we only ever catch APIException anyway. https://github.com/openstack/tripleo-common/blob/8a0910b15747bfcf025fe546a0a0523bdfed5afa/tripleo_common/actions/validations.py#L126 | 12:24 |
| d0ugal | so t-c may be good. | 12:24 |
| d0ugal | but who knows about other users | 12:24 |
| therve | The patch to use session everywhere fixed by raising mistral error all the time | 12:24 |
| d0ugal | Right | 12:24 |
| therve | d0ugal, Right because tc doesn't use sessions | 12:25 |
| d0ugal | oh yeah | 12:25 |
| jaosorior | didn't we start using sessions in the undercloud already? | 12:25 |
| therve | jaosorior, Yes that's the issue :) | 12:26 |
| jaosorior | ah | 12:26 |
| jaosorior | right | 12:26 |
| therve | instack-undercloud used sessions, but mistraclient didn't support it well | 12:26 |
| jaosorior | uh.... how did we hit the issue now? that commit has been there for a bit | 12:26 |
| therve | We only test releases | 12:26 |
| therve | d0ugal, I'd catch both errors in instack | 12:26 |
| jaosorior | oh, and the change just got out now with this release? | 12:26 |
| therve | I think that's the right thing to do | 12:27 |
| therve | jaosorior, Right | 12:27 |
| jaosorior | oooh | 12:27 |
| jaosorior | sorry, I'm a bit behind on this | 12:27 |
| apetrich | therve, d0ugal yeah for catching both on instack | 12:27 |
| therve | d0ugal, apetrich https://review.openstack.org/#/c/500346/ FWIW | 12:27 |
| therve | That's what we had to deal with in Heat | 12:28 |
| d0ugal | therve, jaosorior, apetrich: https://review.openstack.org/#/c/543916/ | 12:29 |
| d0ugal | I caught both before I seen the above, glad you agree :) | 12:29 |
| d0ugal | I guess I need a bug for this to be backported... | 12:30 |
| openstackgerrit | Sagi Shnaidman proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client https://review.openstack.org/543447 | 12:31 |
| apetrich | d0ugal, there's one. let me find it | 12:32 |
| apetrich | d0ugal, https://bugs.launchpad.net/tripleo/+bug/1748751 | 12:32 |
| openstack | Launchpad bug 1748751 in python-mistralclient "Undercloud Install Fail - Configuring Mistral Workloads - Authentication Error - when using RDO master" [Undecided,In progress] - Assigned to Thomas Herve (therve) | 12:32 |
| apetrich | oh not tha | 12:32 |
| apetrich | t | 12:32 |
| *** ykarel_ has joined #openstack-mistral | 12:33 | |
| apetrich | never mind. I'm not finding it | 12:34 |
| *** ykarel has quit IRC | 12:35 | |
| *** hardikjasani has quit IRC | 13:26 | |
| *** dprince has joined #openstack-mistral | 13:27 | |
| *** dprince has quit IRC | 13:43 | |
| *** ykarel_ is now known as ykarel|afk | 13:47 | |
| *** ykarel_ has joined #openstack-mistral | 13:56 | |
| *** ykarel|afk has quit IRC | 13:59 | |
| *** dprince has joined #openstack-mistral | 14:00 | |
| *** bobh has joined #openstack-mistral | 14:22 | |
| *** shardy has quit IRC | 14:24 | |
| *** shardy has joined #openstack-mistral | 14:25 | |
| *** openstackgerrit has quit IRC | 14:33 | |
| *** oidgar has quit IRC | 14:34 | |
| *** oidgar has joined #openstack-mistral | 14:45 | |
| *** thrash is now known as thrash|biab | 15:05 | |
| *** thrash|biab is now known as thrash | 15:29 | |
| *** shardy has quit IRC | 15:54 | |
| *** itlinux has joined #openstack-mistral | 16:01 | |
| *** mcdoker181818 has quit IRC | 16:09 | |
| *** mcdoker181818 has joined #openstack-mistral | 16:11 | |
| *** oidgar has quit IRC | 16:16 | |
| *** mcdoker181818 has quit IRC | 16:22 | |
| *** mcdoker181818 has joined #openstack-mistral | 16:25 | |
| *** ykarel_ has quit IRC | 16:28 | |
| *** openstackgerrit has joined #openstack-mistral | 16:36 | |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client https://review.openstack.org/543447 | 16:36 |
| *** itlinux has quit IRC | 16:46 | |
| *** itlinux has joined #openstack-mistral | 16:50 | |
| *** thrash is now known as thrash|f00dz | 17:06 | |
| *** jpich has quit IRC | 17:12 | |
| *** itlinux has quit IRC | 17:26 | |
| *** itlinux has joined #openstack-mistral | 17:31 | |
| *** AlexeyAbashkin has quit IRC | 17:38 | |
| *** thrash|f00dz is now known as thrash | 18:24 | |
| *** itlinux has quit IRC | 18:30 | |
| *** itlinux has joined #openstack-mistral | 18:44 | |
| *** itlinux has quit IRC | 18:57 | |
| *** itlinux has joined #openstack-mistral | 18:59 | |
| *** harlowja has joined #openstack-mistral | 19:03 | |
| *** itlinux has quit IRC | 19:39 | |
| *** itlinux has joined #openstack-mistral | 19:43 | |
| *** itlinux has quit IRC | 19:46 | |
| *** bobh has quit IRC | 19:52 | |
| *** itlinux has joined #openstack-mistral | 20:36 | |
| *** mcdoker181818 has quit IRC | 20:39 | |
| *** mcdoker181818 has joined #openstack-mistral | 20:40 | |
| *** mcdoker181818 has quit IRC | 20:47 | |
| *** mcdoker181818 has joined #openstack-mistral | 20:48 | |
| *** mcdoker181818 has quit IRC | 21:22 | |
| *** dprince has quit IRC | 21:31 | |
| *** itlinux has quit IRC | 22:23 | |
| *** itlinux has joined #openstack-mistral | 22:27 | |
| *** thrash is now known as thrash|g0ne | 22:32 | |
| *** akazakov has quit IRC | 22:35 | |
| *** itlinux has quit IRC | 22:46 | |
| *** kong has joined #openstack-mistral | 22:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!