| *** harlowja has quit IRC | 01:19 | |
| openstackgerrit | wangqi proposed openstack/mistral master: [sytle] use http code constant instead of int https://review.openstack.org/571374 | 03:56 |
|---|---|---|
| openstackgerrit | wangqi proposed openstack/mistral master: [sytle] use http code constant instead of int https://review.openstack.org/571374 | 03:59 |
| *** hardikjasani has joined #openstack-mistral | 04:46 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 05:04 | |
| *** AlexeyAbashkin has quit IRC | 05:23 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 05:28 | |
| *** AlexeyAbashkin has quit IRC | 05:35 | |
| *** jaosorior has quit IRC | 05:58 | |
| *** jaosorior has joined #openstack-mistral | 06:14 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:30 | |
| *** shardy has joined #openstack-mistral | 07:32 | |
| *** jpich has joined #openstack-mistral | 07:55 | |
| opetrenko_ | Hello guys, https://review.openstack.org/#/c/570206/2 this review failed with some strange failure, not corresponding to commit changes | 08:00 |
| opetrenko_ | https://review.openstack.org/#/c/570572/ review please | 08:09 |
| openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Use on-clause and retry_policy get_spec for validation https://review.openstack.org/499790 | 08:20 |
| openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Refresh a number of retry a task when task was rerun https://review.openstack.org/569643 | 08:36 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Create Base class for Mistral Exceptions and Errors https://review.openstack.org/570206 | 08:47 |
| d0ugal | opetrenko_: I agree, the error looks unrelated. I rebased the patch so it is tested again. | 08:47 |
| openstackgerrit | Kupai József proposed openstack/mistral master: A mechanism to close stuck running action executions https://review.openstack.org/527085 | 09:04 |
| *** apetrich has quit IRC | 09:34 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add YAQL engine options https://review.openstack.org/477816 | 09:53 |
| *** thrash|g0ne is now known as thrash | 11:16 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Switch to using stestr https://review.openstack.org/569875 | 11:17 |
| rakhmerov | d0ugal: hi | 11:23 |
| rakhmerov | d0ugal: I investigated yesterday's thing related to yaml_dump() | 11:23 |
| rakhmerov | the thing is that if we do <% { k => v1, ...} %> in a workflow then YAQL uses its own internal structure called FrozenDict instead of a built-in dict and the yaml library doesn't know how to serialize it into yaml | 11:25 |
| openstackgerrit | Merged openstack/mistral master: Add test for _try_import https://review.openstack.org/570572 | 11:25 |
| rakhmerov | it seems a lot like a bug in YAQL actually because, IMO, a result returned from an expression evaluation should be free of any internal YAQL types | 11:26 |
| rakhmerov | d0ugal: ooh... and now I think I know what to do! | 11:27 |
| rakhmerov | :) | 11:27 |
| rakhmerov | just found a utility that sanitizes a result | 11:27 |
| d0ugal | nice! | 11:36 |
| d0ugal | Glad I helped! lol :) | 11:36 |
| rakhmerov | yes, thanks ) So I'm thinking how to address that in a better way | 11:39 |
| rakhmerov | it's still a little tricky | 11:39 |
| *** hardikjasani has quit IRC | 12:02 | |
| *** apetrich has joined #openstack-mistral | 12:29 | |
| openstackgerrit | Merged openstack/mistral master: Fix workflows query with fields=input https://review.openstack.org/566594 | 12:36 |
| *** toure|gone is now known as toure | 12:54 | |
| openstackgerrit | Merged openstack/mistral master: Create Base class for Mistral Exceptions and Errors https://review.openstack.org/570206 | 12:56 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 12:58 |
| *** jistr is now known as jistr|mtg | 12:59 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add YAQL engine options https://review.openstack.org/477816 | 13:01 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add YAQL engine options https://review.openstack.org/477816 | 13:02 |
| rakhmerov | d0ugal: so https://review.openstack.org/#/c/477816/7/mistral/utils/expression_utils.py, line 192 solves the issue although it's slightly hacky | 13:03 |
| rakhmerov | ideally we need to fix a bug in YAQL but that may be challenging | 13:03 |
| rakhmerov | anyway, waiting for your opinion | 13:04 |
| rakhmerov | whether it's ok or not | 13:04 |
| d0ugal | rakhmerov: looking | 13:05 |
| rakhmerov | ok | 13:07 |
| d0ugal | rakhmerov: Yeah, that is hacky :) | 13:07 |
| d0ugal | but I guess it is okay | 13:07 |
| rakhmerov | :) | 13:07 |
| d0ugal | I just wonder what other data structures YAQL might return - will we hit other errors later? | 13:07 |
| rakhmerov | if I have some more time later I will look how to fix it in YAQL | 13:07 |
| rakhmerov | d0ugal: I checked that for lists, works fine | 13:08 |
| toure | d0ugal rakhmerov I was just about to state that | 13:08 |
| rakhmerov | it gives a tuple actually there instead of a list | 13:08 |
| d0ugal | right | 13:08 |
| rakhmerov | so should be fine | 13:08 |
| d0ugal | so I guess it is probably okay - we can fix other cases as it comes up. | 13:08 |
| rakhmerov | json_dump also works fine, I added a test | 13:08 |
| *** rbrady-afk is now known as rbrady | 13:08 | |
| rakhmerov | d0ugal: yep | 13:08 |
| d0ugal | cool | 13:08 |
| rakhmerov | ok, so please review the rest. If that's ok I'll follow up with a release note patch | 13:09 |
| d0ugal | rakhmerov: LGTM | 13:09 |
| rakhmerov | ok | 13:09 |
| *** shardy has quit IRC | 13:11 | |
| *** shardy has joined #openstack-mistral | 13:12 | |
| pgaxatte | hello | 13:12 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add YAQL engine options https://review.openstack.org/477816 | 13:13 |
| pgaxatte | d0ugal: about the output formatting bug I was talking about yesterday | 13:13 |
| pgaxatte | it might not be a bug | 13:13 |
| pgaxatte | the workflow create behaves like a list operation (regarding output formats) because you can create multiple workflows with one definition file | 13:14 |
| d0ugal | ah, good point | 13:14 |
| pgaxatte | i don't know if this behavior is good or bad but i believe this a bit unexpected | 13:15 |
| d0ugal | Agreed, it is a little odd | 13:15 |
| pgaxatte | i don't mind having a different file for each workflow | 13:15 |
| d0ugal | Lots of people would mind :) | 13:16 |
| d0ugal | but I use a workbook when I want multiple workflows in a file. | 13:16 |
| pgaxatte | exactly | 13:16 |
| pgaxatte | but i'm pretty sure you cannot create multiple workbooks inside one file | 13:16 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Switch to using stestr https://review.openstack.org/569876 | 13:17 |
| rakhmerov | d0ugal, pgaxatte: it was done intentionally | 13:19 |
| rakhmerov | because one may want to have 1 file for many workflows w/o having to include them into a workbook | 13:20 |
| rakhmerov | so we decided to give such an opportunity | 13:20 |
| d0ugal | yeah, it makes sense to me | 13:20 |
| rakhmerov | pgaxatte: as far as workbooks, right, we can't create many in one file | 13:21 |
| d0ugal | It is just a little strainge from the CLI/API point of view. You probably wouldn't expect workflow create to create multiple - but it can. | 13:21 |
| pgaxatte | yes especially since other create command don't have the same behavior | 13:22 |
| pgaxatte | I filed a bug on this yesterday, you can close it :) | 13:22 |
| pgaxatte | https://bugs.launchpad.net/python-mistralclient/+bug/1774172 | 13:22 |
| openstack | Launchpad bug 1774172 in python-mistralclient "Output format are inconsistent across create actions in openstack cli" [Undecided,New] | 13:22 |
| d0ugal | pgaxatte: Done. Thanks for investigating this! | 13:23 |
| pgaxatte | I'll just adapt my puppet provider accordingly and add a note saying this is the desired behavior | 13:23 |
| pgaxatte | d0ugal: no problem :) but i'm a bit disappointed, I thought this would be an easy win :D | 13:24 |
| d0ugal | so did I at a first glance! | 13:24 |
| pgaxatte | any idea who maintains the puppet-mistral repo? | 13:26 |
| pgaxatte | i'd like to push my dev to add a workflow from puppet | 13:27 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Release note for adding YAQL engine options https://review.openstack.org/571481 | 13:29 |
| rakhmerov | :) | 13:30 |
| rakhmerov | pgaxatte: good question, hm.. d0ugal: was it Red Hat? | 13:31 |
| d0ugal | pgaxatte: I believe EmilienM and mwhahaha are puppet-mistral cores | 13:32 |
| d0ugal | There is probably even an IRC channel for them somewhere... | 13:32 |
| mwhahaha | #puppet-openstack | 13:33 |
| mwhahaha | we maintain it from a we need it in tripleo standpoint :D but patches welcome | 13:33 |
| d0ugal | thanks (I guessed the other way around) | 13:33 |
| pgaxatte | mwhahaha: ok thanks, i'll meet you there :) | 13:36 |
| *** thrash is now known as thrash|biab | 14:01 | |
| *** apetrich has quit IRC | 14:09 | |
| *** thrash|biab is now known as thrash | 14:54 | |
| *** jistr|mtg is now known as jistr | 14:57 | |
| opetrenko_ | Hi guys, do we have any EBNF documentation about our dsl? | 15:00 |
| d0ugal | opetrenko_: no, not that I am aware of. | 15:26 |
| *** AlexeyAbashkin has quit IRC | 15:37 | |
| *** jpich has quit IRC | 16:09 | |
| *** apetrich has joined #openstack-mistral | 16:18 | |
| *** shardy has quit IRC | 17:23 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:32 | |
| *** d0ugal_ has joined #openstack-mistral | 17:40 | |
| *** d0ugal has quit IRC | 17:42 | |
| *** AlexeyAbashkin has quit IRC | 17:45 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:45 | |
| *** AlexeyAbashkin has quit IRC | 17:45 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:46 | |
| *** d0ugal__ has joined #openstack-mistral | 17:51 | |
| *** d0ugal_ has quit IRC | 17:53 | |
| *** d0ugal__ has quit IRC | 17:59 | |
| *** Alexey_Abashkin has joined #openstack-mistral | 18:04 | |
| *** AlexeyAbashkin has quit IRC | 18:07 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 18:07 | |
| *** AlexeyAbashkin has quit IRC | 18:13 | |
| *** d0ugal__ has joined #openstack-mistral | 18:23 | |
| *** d0ugal__ has quit IRC | 18:34 | |
| *** d0ugal__ has joined #openstack-mistral | 18:59 | |
| *** harlowja has joined #openstack-mistral | 20:01 | |
| *** apetrich has quit IRC | 20:23 | |
| *** apetrich has joined #openstack-mistral | 20:23 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 20:33 | |
| *** AlexeyAbashkin has quit IRC | 20:50 | |
| *** harlowja has quit IRC | 21:00 | |
| *** thrash is now known as thrash|g0ne | 21:15 | |
| *** harlowja has joined #openstack-mistral | 22:21 | |
| *** d0ugal__ has quit IRC | 22:48 | |
| *** d0ugal__ has joined #openstack-mistral | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!