| *** jtomasek has joined #openstack-mistral | 01:03 | |
| *** jtomasek has quit IRC | 01:07 | |
| *** thrash is now known as thrash|g0ne | 01:30 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 04:51 |
|---|---|---|
| *** hardikjasani has joined #openstack-mistral | 05:15 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 05:39 |
| *** jtomasek has joined #openstack-mistral | 06:05 | |
| *** shardy has joined #openstack-mistral | 07:26 | |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Add started_at and finished_at to task execution. https://review.openstack.org/607703 | 07:40 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 07:58 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 08:04 |
| d0ugal | therve: Hey - should we also backport this? https://review.openstack.org/#/c/607306/ | 08:06 |
| therve | d0ugal: Depends what happens around log rotation... | 08:07 |
| therve | If you want/need SIGHUP to work, yes :) | 08:07 |
| d0ugal | I guess I do :) | 08:07 |
| d0ugal | therve: would you mind adding a release note? | 08:07 |
| therve | Nope! | 08:08 |
| d0ugal | Thanks | 08:08 |
| openstackgerrit | Thomas Herve proposed openstack/mistral master: Wait for rpc server on shutdown https://review.openstack.org/607306 | 08:10 |
| therve | d0ugal: We have various issues around SIGHUP handing in Heat as well | 08:10 |
| d0ugal | oh, interesting. I'll take a look | 08:10 |
| therve | I wonder if we should consider changing the behavior imposed by oslo.service | 08:10 |
| therve | Restarting all the services to reload log/conf files seem dumb to me | 08:11 |
| d0ugal | Agreed | 08:11 |
| d0ugal | but I can see why it was done - it was probably the easiest fix. | 08:11 |
| therve | I know long-running heat stacks are broken, I wonder about workflows | 08:11 |
| d0ugal | How long is long-running? | 08:12 |
| therve | In case of heat, hours | 08:12 |
| d0ugal | I don't think we have any workflows that run that long (because of keystone token issues) | 08:12 |
| therve | There is just no way that you're going to "wait" for completion in this case | 08:12 |
| d0ugal | but rakhmerov may have some in a non-keystone setup | 08:12 |
| therve | Even 20 minutes | 08:13 |
| d0ugal | oh, we have that for sure with introspection | 08:13 |
| therve | If you have a SIGHUP at say 10 minutes into 20, what do you do? | 08:14 |
| d0ugal | ¯\_(ツ)_/¯ | 08:14 |
| rakhmerov | d0ugal: hey | 08:15 |
| rakhmerov | what's the question? | 08:15 |
| rakhmerov | yes, we have workflows running for days | 08:16 |
| rakhmerov | in a non-keystone env, right | 08:16 |
| d0ugal | rakhmerov: Not sure we have a specific question, but therve is investigating SIGHUP issues. Do you use the oslo or kombu rpc backend? | 08:16 |
| rakhmerov | oslo | 08:16 |
| rakhmerov | I would not recommend to use Kombu RPC, at least under load | 08:17 |
| rakhmerov | it has a number of issues actually | 08:17 |
| d0ugal | Good to know. | 08:17 |
| rakhmerov | yeah | 08:17 |
| d0ugal | rakhmerov: https://review.openstack.org/#/c/607306/ | 08:17 |
| d0ugal | We use oslo | 08:17 |
| rakhmerov | haah.. | 08:20 |
| rakhmerov | tricky thing | 08:20 |
| *** gkadam has joined #openstack-mistral | 08:30 | |
| *** gkadam has quit IRC | 08:31 | |
| *** mcdoker18 has quit IRC | 08:35 | |
| pgaxatte | hello | 08:48 |
| pgaxatte | I have a small question related to the plugin system | 08:48 |
| pgaxatte | this is more related to setuptools actually but since it used in mistral to extend the actions possible I figured I'd ask you :D | 08:49 |
| pgaxatte | can I have mistral installed in the normal sys.path via my distribution's packages and register an action plugin deployed somewhere else in a venv? | 08:50 |
| pgaxatte | mistral would be run without a venv and resides in /usr/lib/python.... | 08:50 |
| pgaxatte | whereas the code of the custom action would be totally outside the sys.path, in a venv somewhere | 08:51 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 08:57 |
| therve | pgaxatte: Well mistral needs to be able to import your code, right? | 09:21 |
| therve | If it's in a different venv, that doesn't sound doable | 09:21 |
| pgaxatte | therve: that's what I thought so it raises a problem to me | 09:22 |
| pgaxatte | because maybe I want to use a different version of some lib in a specific action | 09:22 |
| therve | Yeah that won't work | 09:22 |
| pgaxatte | and I don't want to have to know in advance the dependencies of all my custom actions so that I can build a mistral in a venv with everything it needs | 09:23 |
| pgaxatte | if I know in advance WHERE my plugins venv will be, can't I extend mistral's sys.path before running it? | 09:25 |
| therve | Right, but you'll use the same version of the lib everywhere then? | 09:26 |
| pgaxatte | the different version of the lib was an hypothetical question, I'd probably need additionnal packages rather than different versions of them | 09:27 |
| therve | OK that's a totally different issue though | 09:33 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 09:54 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 10:23 |
| openstackgerrit | 98k proposed openstack/python-mistralclient master: build universal wheels https://review.openstack.org/607915 | 11:24 |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Add started_at and finished_at to task execution. https://review.openstack.org/607703 | 11:59 |
| *** thrash|g0ne is now known as thrash | 12:11 | |
| *** nguyenhai93 has quit IRC | 12:43 | |
| *** nguyenhai93 has joined #openstack-mistral | 12:43 | |
| *** bobh has joined #openstack-mistral | 12:59 | |
| *** hardikjasani has quit IRC | 13:25 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: Fix state change propagation in workflows https://review.openstack.org/607960 | 13:35 |
| *** gkadam has joined #openstack-mistral | 14:00 | |
| *** jaosorior has quit IRC | 14:16 | |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Use SessionClient for Ironic actions https://review.openstack.org/607974 | 14:35 |
| *** thrash is now known as thrash|biab | 14:54 | |
| *** bobh has quit IRC | 14:58 | |
| *** toure is now known as toure|biab | 14:59 | |
| *** bobh has joined #openstack-mistral | 15:04 | |
| *** bobh has quit IRC | 15:10 | |
| *** toure|biab is now known as toure | 15:19 | |
| *** bobh has joined #openstack-mistral | 15:37 | |
| *** thrash|biab is now known as thrash | 15:39 | |
| *** bobh has quit IRC | 15:44 | |
| *** shardy has quit IRC | 17:04 | |
| *** gkadam has quit IRC | 17:08 | |
| *** bobh has joined #openstack-mistral | 17:45 | |
| *** pgaxatte has quit IRC | 19:00 | |
| *** pgaxatte has joined #openstack-mistral | 19:06 | |
| *** jtomasek has quit IRC | 20:39 | |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Add started_at and finished_at to task execution. https://review.openstack.org/607703 | 20:51 |
| *** thrash is now known as thrash|g0ne | 21:04 | |
| *** toure is now known as toure|gone | 21:22 | |
| *** bobh has quit IRC | 21:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!