| *** bobh_ has joined #openstack-mistral | 01:05 | |
| *** bobh has quit IRC | 01:08 | |
| *** bobh has joined #openstack-mistral | 01:15 | |
| *** bobh_ has quit IRC | 01:16 | |
| *** bobh has quit IRC | 01:20 | |
| *** bobh has joined #openstack-mistral | 01:41 | |
| *** bobh_ has joined #openstack-mistral | 02:32 | |
| *** bobh has quit IRC | 02:34 | |
| *** bobh has joined #openstack-mistral | 03:05 | |
| *** bobh_ has quit IRC | 03:08 | |
| *** apetrich has quit IRC | 03:15 | |
| *** bobh_ has joined #openstack-mistral | 03:26 | |
| *** bobh has quit IRC | 03:29 | |
| *** bobh_ has quit IRC | 03:50 | |
| *** shardy has quit IRC | 04:33 | |
| *** shardy has joined #openstack-mistral | 04:34 | |
| *** bobh has joined #openstack-mistral | 04:55 | |
| *** bobh has quit IRC | 05:22 | |
| *** pgaxatte has joined #openstack-mistral | 07:30 | |
| *** apetrich has joined #openstack-mistral | 07:32 | |
| *** shardy has quit IRC | 08:05 | |
| *** shardy has joined #openstack-mistral | 08:05 | |
| *** jaosorior has joined #openstack-mistral | 08:39 | |
| *** shardy has quit IRC | 09:27 | |
| *** shardy has joined #openstack-mistral | 09:27 | |
| d0ugal | pgaxatte: because when you delete the root execution the child executions are deleted automatically | 10:16 |
|---|---|---|
| pgaxatte | hi d0ugal :) | 10:17 |
| d0ugal | pgaxatte: so only the completed root executions need to be explicitly deleted | 10:17 |
| d0ugal | Hi | 10:17 |
| pgaxatte | thanks for the answer I was feeling rather lonely here! | 10:17 |
| d0ugal | haha, sorry for the delay! | 10:17 |
| d0ugal | I believe rakhmerov is back next week. | 10:18 |
| pgaxatte | I understand the tasks and action executions are deleted via cascade delete on the db | 10:18 |
| d0ugal | oh okay :) | 10:18 |
| pgaxatte | (let me read the code again to check what suprised me :D) | 10:19 |
| pgaxatte | ok reading this: https://github.com/openstack/mistral/blob/master/mistral/db/v2/sqlalchemy/api.py#L1320 | 10:21 |
| pgaxatte | task_execution_id is not root_exec | 10:21 |
| d0ugal | well, it kind of is :) | 10:21 |
| pgaxatte | it's set to null when the workflow has run everything, right? | 10:21 |
| d0ugal | task_execution_id refers to the task in the parent execution that started the workflow | 10:22 |
| pgaxatte | i understand it like a pointer to the current task running | 10:22 |
| d0ugal | so if it is null, then it is a root execution | 10:22 |
| pgaxatte | ohhhh | 10:22 |
| pgaxatte | ok | 10:22 |
| pgaxatte | ok so we start the expiration from the root of the exec | 10:23 |
| d0ugal | This code could be updated to use the new root_execution_id field, then it might be easier to read | 10:23 |
| pgaxatte | but in my opinion it does not clean the subworkflows | 10:23 |
| d0ugal | It does for me :-D | 10:23 |
| pgaxatte | we had to turn it off on our side | 10:23 |
| pgaxatte | it caused a lot of deadlocks | 10:23 |
| d0ugal | If it didn't - databases would be very full and we would get many complaints | 10:24 |
| d0ugal | so I wonder why your setup is different | 10:24 |
| pgaxatte | i'm not sure either | 10:24 |
| pgaxatte | we have a lot of executions | 10:24 |
| pgaxatte | we can run like 100 thousands actions per day | 10:24 |
| pgaxatte | so action_executions is growing fast | 10:25 |
| pgaxatte | and we did not activate expiration from the start | 10:25 |
| d0ugal | I believe rakhmerov is working at a similar scale, so it would be worth checking with him | 10:25 |
| pgaxatte | and the expiration on large set is creating deadlocks | 10:25 |
| pgaxatte | because the db is a bit sluggish too but i think the expiration itself is not optimizes | 10:26 |
| pgaxatte | optimized | 10:26 |
| pgaxatte | (if i may) | 10:26 |
| pgaxatte | from what i understand of it | 10:27 |
| pgaxatte | it seems to delete line by line | 10:27 |
| pgaxatte | each workflow exec | 10:27 |
| d0ugal | Yup, I think so | 10:28 |
| pgaxatte | because we check the auth context and use _secure_query | 10:28 |
| pgaxatte | https://github.com/openstack/mistral/blob/master/mistral/services/expiration_policy.py#L90 | 10:28 |
| pgaxatte | BUT i don't see why we need to | 10:28 |
| d0ugal | It was changed to delete like that because of timeouts deleting many executions in one query iirc | 10:28 |
| pgaxatte | hmmmm do you use postgres or mysql? | 10:29 |
| d0ugal | mysql, unfortunately :-D | 10:29 |
| pgaxatte | because i could see the reason why with different locking schemes | 10:29 |
| pgaxatte | yeah so table locks everywhere :D | 10:29 |
| d0ugal | But we have many small Mistral deploys, not one big one | 10:29 |
| d0ugal | So we don't usually hit this problem | 10:30 |
| pgaxatte | and because of the cascade it locks like 3 or 4 tables | 10:30 |
| pgaxatte | even if we did not remove all the lines at once but in batches it would be beneficial | 10:31 |
| pgaxatte | and i don't see why we need _secure_query | 10:31 |
| d0ugal | No, I don't understand that part tbh | 10:31 |
| d0ugal | bbiab, coffee and snack required :) | 10:31 |
| pgaxatte | it seems useful for deleting resources that could be shared between projects | 10:31 |
| pgaxatte | d0ugal: no problem :D | 10:31 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: fix typo mistakes https://review.openstack.org/625418 | 11:42 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Replace tripleo-scenario003-multinode with scenario003-standalone https://review.openstack.org/628274 | 11:42 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Update mailinglist from dev to discuss https://review.openstack.org/625775 | 11:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Amend the spelling error of a word https://review.openstack.org/572714 | 11:48 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove those copy words occured twice times in wf_lang_v2.rst https://review.openstack.org/617540 | 11:50 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove the deprecated json_pp YAQL/Jinja2 function https://review.openstack.org/622379 | 11:51 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix input, params, output, published filters https://review.openstack.org/505206 | 11:51 |
| openstackgerrit | Merged openstack/mistral master: Gate fix for failing at openstack-tox-docs https://review.openstack.org/627439 | 12:32 |
| openstackgerrit | Merged openstack/mistral master: Remove those copy words occured twice times in wf_lang_v2.rst https://review.openstack.org/617540 | 12:57 |
| *** mmethot has joined #openstack-mistral | 14:00 | |
| *** shardy has quit IRC | 14:23 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Amend the spelling error of a word https://review.openstack.org/572714 | 14:59 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Update mailinglist from dev to discuss https://review.openstack.org/625775 | 14:59 |
| openstackgerrit | zhulingjie proposed openstack/mistral master: Update hacking version to latest https://review.openstack.org/628508 | 15:59 |
| *** apetrich has quit IRC | 16:07 | |
| *** jrist has joined #openstack-mistral | 16:08 | |
| *** apetrich has joined #openstack-mistral | 16:28 | |
| *** apetrich has quit IRC | 16:35 | |
| openstackgerrit | zhulingjie proposed openstack/mistral-specs master: Update hacking version to latest https://review.openstack.org/628621 | 17:02 |
| openstackgerrit | zhulingjie proposed openstack/mistral-extra master: Update hacking version to latest https://review.openstack.org/628622 | 17:02 |
| openstackgerrit | zhulingjie proposed openstack/mistral-tempest-plugin master: Update hacking version to latest https://review.openstack.org/628623 | 17:02 |
| openstackgerrit | zhulingjie proposed openstack/mistral-lib master: Update hacking version to latest https://review.openstack.org/628624 | 17:02 |
| *** pgaxatte has quit IRC | 17:04 | |
| openstackgerrit | Merged openstack/mistral master: Update mailinglist from dev to discuss https://review.openstack.org/625775 | 17:08 |
| *** bobh has joined #openstack-mistral | 19:01 | |
| *** bobh_ has joined #openstack-mistral | 19:17 | |
| *** bobh has quit IRC | 19:19 | |
| *** jtomasek has quit IRC | 20:51 | |
| *** bobh_ has quit IRC | 21:47 | |
| *** bobh has joined #openstack-mistral | 21:49 | |
| *** bobh has quit IRC | 21:54 | |
| *** jaosorior has quit IRC | 22:42 | |
| *** bobh has joined #openstack-mistral | 22:52 | |
| *** bobh has quit IRC | 23:21 | |
| *** bobh has joined #openstack-mistral | 23:36 | |
| *** openstack has joined #openstack-mistral | 23:45 | |
| *** ChanServ sets mode: +o openstack | 23:45 | |
| *** bobh has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!