*** apetrich has quit IRC | 03:16 | |
rakhmerov | jlejeune: yes, a request initiating a workflow execution must be properly authenticated | 04:27 |
---|---|---|
*** hardikjasani has joined #openstack-mistral | 05:09 | |
*** pgaxatte has joined #openstack-mistral | 07:29 | |
*** apetrich has joined #openstack-mistral | 07:48 | |
jlejeune | rakhmerov: yep that what I saw yesterday | 08:05 |
jlejeune | I'll find another way | 08:06 |
jlejeune | thanks | 08:06 |
rakhmerov | щл | 08:30 |
rakhmerov | ok | 08:30 |
openstackgerrit | Andras Kovi proposed openstack/mistral master: Process all task batches in wf output evaluation https://review.openstack.org/630918 | 09:50 |
rakhmerov | d0ugal, apetrich: hi guys, please review https://review.openstack.org/#/c/630918 | 09:57 |
rakhmerov | it fixes a terrible bug | 09:57 |
apetrich | I can look in a minute | 09:57 |
d0ugal | rakhmerov: Shouldn't it be changed from "break" to "continue" instead of deleting? | 09:58 |
rakhmerov | d0ugal: let me see again.. | 09:59 |
d0ugal | if "batch" is false, is it always a empty iterable? if it is anything else (like None) then like 175 will fail | 09:59 |
rakhmerov | d0ugal: well, the next line will filter it out anyway | 09:59 |
rakhmerov | so the current version looks ok to me too | 10:00 |
d0ugal | okay, so you are sure it is always a iterable? | 10:00 |
rakhmerov | no, it will return an empty list | 10:00 |
d0ugal | k | 10:00 |
d0ugal | Then that seems fine | 10:00 |
rakhmerov | yes | 10:00 |
rakhmerov | I am sure | 10:00 |
*** jaosorior has joined #openstack-mistral | 10:09 | |
*** jtomasek has quit IRC | 10:40 | |
*** jtomasek has joined #openstack-mistral | 10:40 | |
*** apetrich has quit IRC | 10:54 | |
*** apetrich has joined #openstack-mistral | 11:07 | |
*** openstackgerrit has quit IRC | 11:22 | |
*** apetrich has quit IRC | 11:44 | |
*** apetrich has joined #openstack-mistral | 12:01 | |
*** gyee has joined #openstack-mistral | 12:53 | |
*** openstackgerrit has joined #openstack-mistral | 12:55 | |
openstackgerrit | Andras Kovi proposed openstack/mistral master: Process all task batches in wf output evaluation https://review.openstack.org/630918 | 12:55 |
*** gyee has quit IRC | 13:34 | |
*** hardikjasani has quit IRC | 13:49 | |
*** apetrich has quit IRC | 14:07 | |
*** mmethot has joined #openstack-mistral | 14:12 | |
*** apetrich has joined #openstack-mistral | 14:12 | |
*** pgaxatte has quit IRC | 16:52 | |
openstackgerrit | Xavier Hardy proposed openstack/mistral master: Fix input, params, output, published filters https://review.openstack.org/505206 | 21:50 |
*** jtomasek has quit IRC | 23:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!