*** bobh has joined #openstack-mistral | 01:22 | |
*** bobh has quit IRC | 02:31 | |
*** bobh has joined #openstack-mistral | 02:32 | |
*** bobh has quit IRC | 02:36 | |
*** bobh has joined #openstack-mistral | 04:30 | |
*** bobh has quit IRC | 04:35 | |
rakhmerov | mgariepy: hi, I guess so | 04:38 |
---|---|---|
rakhmerov | looking at your patch... | 04:39 |
rakhmerov | ooh, seems like the patch is not ready for review yet | 04:40 |
openstackgerrit | Merged openstack/mistral stable/rocky: Add release note for I04ba85488b27cb05c3b81ad8c973c3cc3fe56d36 https://review.openstack.org/651488 | 05:04 |
*** bobh has joined #openstack-mistral | 05:35 | |
*** bobh has quit IRC | 05:39 | |
*** jtomasek has quit IRC | 05:48 | |
*** pgaxatte has joined #openstack-mistral | 06:25 | |
*** bobh has joined #openstack-mistral | 07:14 | |
*** bobh has quit IRC | 07:18 | |
openstackgerrit | Merged openstack/mistral master: Fix an expression context for all_errors_handled() https://review.openstack.org/651195 | 08:04 |
*** jtomasek has joined #openstack-mistral | 08:06 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/stein: Fix an expression context for all_errors_handled() https://review.openstack.org/651717 | 08:15 |
openstackgerrit | jacky06 proposed openstack/mistral master: Drop py35 jobs https://review.openstack.org/651426 | 08:31 |
*** bobh has joined #openstack-mistral | 09:56 | |
*** bobh has quit IRC | 10:00 | |
vgvoleg | Hi all, please let me know if you agree with this https://blueprints.launchpad.net/mistral/+spec/add-sleep-option-to-echo-action | 12:01 |
vgvoleg | i'm ready to push this changes if you don't mind :) | 12:02 |
mgariepy | rakhmerov, hello, yep i got some issue with the tests .. | 12:05 |
openstackgerrit | Marc Gariépy (mgariepy) proposed openstack/mistral master: Add reply-to to std.email https://review.openstack.org/651582 | 12:25 |
openstackgerrit | Marc Gariépy (mgariepy) proposed openstack/mistral master: Add reply-to to std.email https://review.openstack.org/651582 | 12:37 |
*** d0ugal has quit IRC | 13:46 | |
*** d0ugal has joined #openstack-mistral | 14:01 | |
*** gkadam has joined #openstack-mistral | 14:02 | |
*** gkadam has quit IRC | 14:03 | |
*** bobh has joined #openstack-mistral | 14:44 | |
*** bobh has quit IRC | 14:49 | |
*** bobh has joined #openstack-mistral | 14:50 | |
mgariepy | rakhmerov, it's ready for review now, feel free to update it if you need to I really don't mind. | 14:51 |
*** d0ugal has quit IRC | 15:35 | |
*** pgaxatte has quit IRC | 15:58 | |
vgvoleg | Guys, I've used flake8 for mistral and found 3 bad places | 16:10 |
vgvoleg | mistral/tests/unit/engine/test_commands.py:363:1: E305 expected 2 blank lines after class or function definition, found 1 | 16:10 |
*** smrcascao has joined #openstack-mistral | 16:10 | |
vgvoleg | mistral/tests/unit/engine/test_commands.py:452:1: E305 expected 2 blank lines after class or function definition, found 1 | 16:10 |
vgvoleg | mistral/db/sqlalchemy/migration/cli.py:141:1: E305 expected 2 blank lines after class or function definition, found 1 | 16:11 |
vgvoleg | What should I do to fix this in upstream? Should I create a bug? It breaks my CI :D | 16:12 |
mgariepy | or submit a patch to fix it ? | 16:14 |
vgvoleg | oh, it's a misunderstanding | 16:24 |
vgvoleg | When I asked about a bug, I mean could this be called a bug? | 16:25 |
vgvoleg | of course I can submit a patch, I just want to know the "right bureaucratic" way | 16:26 |
mgariepy | hehe ok ;) | 16:29 |
mgariepy | no idea then, i only submitted 2 patch for the project. | 16:29 |
*** jtomasek has quit IRC | 17:37 | |
*** bobh has quit IRC | 17:58 | |
*** bobh has joined #openstack-mistral | 18:03 | |
*** bobh has quit IRC | 18:13 | |
*** bobh has joined #openstack-mistral | 18:16 | |
*** bobh has quit IRC | 22:10 | |
*** aspiers has quit IRC | 23:21 | |
*** aspiers has joined #openstack-mistral | 23:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!