*** ricolin has joined #openstack-mistral | 01:05 | |
openstackgerrit | pengyuesheng proposed openstack/mistral-dashboard master: Modify the url of upper_constraints_file https://review.opendev.org/665839 | 01:39 |
---|---|---|
openstackgerrit | pengyuesheng proposed openstack/python-mistralclient master: Modify the url of upper_constraints_file https://review.opendev.org/665840 | 01:50 |
*** apetrich has quit IRC | 01:57 | |
*** threestrands has joined #openstack-mistral | 04:05 | |
rakhmerov | :) | 04:55 |
openstackgerrit | Merged openstack/mistral-dashboard master: Modify the url of upper_constraints_file https://review.opendev.org/665839 | 05:12 |
*** csatari has quit IRC | 05:36 | |
*** csatari has joined #openstack-mistral | 05:38 | |
openstackgerrit | Merged openstack/python-mistralclient master: Modify the url of upper_constraints_file https://review.opendev.org/665840 | 05:53 |
openstackgerrit | Merged openstack/mistral master: Use eventlet-aware threading events https://review.opendev.org/557487 | 06:35 |
*** pgaxatte has joined #openstack-mistral | 06:43 | |
*** apetrich has joined #openstack-mistral | 07:05 | |
rakhmerov | apetrich: hi Adriano, can you please https://review.opendev.org/#/c/665096/ ? | 07:07 |
rakhmerov | and https://review.opendev.org/#/c/665553/ | 07:08 |
apetrich | rakhmerov, sure do. looking at them | 07:08 |
rakhmerov | thanks! | 07:09 |
rakhmerov | both improve performance pretty significantly | 07:09 |
apetrich | the json I was looking at it yesterday | 07:12 |
apetrich | The other one could use more comments. it is a hard bit of code to understand | 07:13 |
apetrich | rakhmerov, I'd +2 the "fixing upstream tasks executions" but I think we need more comments there. | 07:18 |
rakhmerov | ok | 07:18 |
apetrich | but it feels so hard to -1 it :) | 07:19 |
rakhmerov | :) | 07:19 |
apetrich | also why are we gating with a standalone CI scenario? | 07:20 |
apetrich | we don't even run mistral on the standalone scenario | 07:21 |
rakhmerov | what do you mean? | 07:24 |
rakhmerov | not getting your point ) | 07:24 |
rakhmerov | apetrich: ^ | 07:24 |
apetrich | rakhmerov, tripleo-ci-centos-7-scenario003-standaloneSUCCESS in 1h 10m 29s | 07:24 |
apetrich | that scenario does not run mistral at all | 07:24 |
rakhmerov | really? ) | 07:25 |
apetrich | pretty sure. let me double check | 07:25 |
rakhmerov | I actually don't know :) | 07:25 |
apetrich | it was in the past let me see if that changed | 07:25 |
rakhmerov | apetrich: honestly, I have no idea. I've never payed too much attention to these jobs, except investigating some failures using overcloud_deploy log | 07:26 |
apetrich | rakhmerov, a few months ago I had a patch that had a typo on it.Silly mistake tested everything and did a last minute (wrong) change and submitted and everything was red but that was green, so I went investigating why | 07:29 |
rakhmerov | so? | 07:29 |
apetrich | I saw that it was green because it didn't run mistral, and I think we removed that from the gates | 07:30 |
rakhmerov | :) | 07:30 |
rakhmerov | I didn't know that | 07:30 |
rakhmerov | I guess I missed that somehow | 07:30 |
rakhmerov | but it doesn't seem to make sense to have this job if it doesn't run Mistral ) | 07:31 |
apetrich | yeah it is not a gate at all for us. | 07:31 |
apetrich | let me just check to see if that changed | 07:31 |
apetrich | so I think it changed. the mistral containers are there. Just the container logs are not being saved | 07:35 |
*** threestrands has quit IRC | 07:36 | |
rakhmerov | ok | 07:37 |
rakhmerov | apetrich: please also see https://review.opendev.org/665096 | 07:38 |
apetrich | rakhmerov, I'm half way there | 07:38 |
apetrich | :) | 07:38 |
rakhmerov | thanks ) | 07:39 |
apetrich | Done. thanks | 07:50 |
vgvoleg | also bump https://review.opendev.org/#/c/599288/ and https://review.opendev.org/#/c/663776/ | 07:51 |
vgvoleg | btw guys I've found that join tasks work incorrect in retry cases | 07:52 |
vgvoleg | rerun* | 07:53 |
vgvoleg | I'll create a patch during couple of hours, but there would be something like this https://github.com/openstack/mistral/blob/master/mistral/engine/policies.py#L400 and I really don't like it | 07:55 |
rakhmerov | apetrich: thanks! | 07:57 |
rakhmerov | vgvoleg: Oleg, ok :) | 08:15 |
rakhmerov | I'll review those patches asap | 08:15 |
openstackgerrit | Merged openstack/mistral master: Make more JSON fields in execution objects lazy-loaded https://review.opendev.org/665096 | 09:58 |
*** d0ugal has joined #openstack-mistral | 10:07 | |
*** d0ugal has quit IRC | 10:18 | |
*** d0ugal has joined #openstack-mistral | 10:33 | |
*** d0ugal has quit IRC | 10:39 | |
*** d0ugal has joined #openstack-mistral | 10:39 | |
*** mgariepy has joined #openstack-mistral | 12:14 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Fix workflow execution cascade delete error https://review.opendev.org/664509 | 12:39 |
*** mgariepy has quit IRC | 12:39 | |
*** mgariepy has joined #openstack-mistral | 12:55 | |
*** pgaxatte has quit IRC | 14:40 | |
openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Reformat rerun logic for tasks with join https://review.opendev.org/666016 | 15:11 |
*** ricolin has quit IRC | 16:46 | |
*** mgariepy has quit IRC | 16:54 | |
*** mgariepy has joined #openstack-mistral | 16:55 | |
openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Reformat rerun logic for tasks with join https://review.opendev.org/666016 | 17:00 |
*** altlogbot_0 has quit IRC | 17:00 | |
*** irclogbot_3 has quit IRC | 17:01 | |
*** altlogbot_2 has joined #openstack-mistral | 17:01 | |
*** irclogbot_0 has joined #openstack-mistral | 17:03 | |
openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: WIP: xxx-before policies for join tasks https://review.opendev.org/666070 | 17:32 |
*** mgariepy has quit IRC | 20:36 | |
*** jtomasek has quit IRC | 20:43 | |
*** d0ugal has quit IRC | 21:30 | |
*** d0ugal has joined #openstack-mistral | 21:30 | |
*** quenti[m] has quit IRC | 22:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!