| zigo | amorin: I think I've finally found my "unit test stuck" mistery !!! :) | 08:29 |
|---|---|---|
| zigo | I'll open a launchpad bug + patch soon. | 08:29 |
| zigo | Basically, in mistral/engine/post_tx_queue.py, we need to: | 08:31 |
| zigo | - t = threading.Thread(target=_within_new_thread) | 08:31 |
| zigo | + t = threading.Thread(target=_within_new_thread, daemon=True) | 08:31 |
| zigo | Otherwise, the thread cannot be shutdown. | 08:32 |
| amorin | nice! | 08:36 |
| zigo | Oh, just found another issue ... :) | 09:07 |
| zigo | (leaking tests) | 09:07 |
| opendevreview | Thomas Goirand proposed openstack/mistral master: Make the post-transaction engine thread a daemon https://review.opendev.org/c/openstack/mistral/+/1010620 | 09:11 |
| opendevreview | Thomas Goirand proposed openstack/mistral master: Fix leakage of auth_enable state in unit tests https://review.opendev.org/c/openstack/mistral/+/1010627 | 09:41 |
| amorin | thanks zigo! I will review asap | 12:55 |
| zigo | Cheers. | 12:55 |
| zigo | FYI, https://github.com/mtreinish/stestr/pull/400 really starts to be rock-solid-I-love-the-feature thing! :P | 12:55 |
| amorin | nice, that will accelerate the execution! have you tried it on mistral and identify how much time you save? | 12:56 |
| zigo | Usually, you win about 1/3rd of the time. | 13:13 |
| zigo | At least, that's what I experienced with the 16k+ tests in Neutron, for example. | 13:14 |
| zigo | I'm adding a progress thingy: | 13:15 |
| zigo | [42/312 (13.5%) elapsed: 00:01:23, ETA: ~00:09:12] | 13:15 |
| zigo | :) | 13:15 |
| opendevreview | Thomas Goirand proposed openstack/mistral master: Fix named lock tests failing with dynamic test dispatch https://review.opendev.org/c/openstack/mistral/+/1010693 | 14:07 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!