Monday, 2017-01-09

*** wanghao has joined #openstack-mogan00:37
*** little has joined #openstack-mogan01:05
*** little has quit IRC01:20
*** RuiChen has quit IRC01:23
*** RuiChen has joined #openstack-mogan01:26
zhenguomorning mogan!02:04
zhenguoshaohe_feng, liusheng: are you around?02:06
*** little has joined #openstack-mogan02:11
*** liusheng has joined #openstack-mogan02:32
*** yuntongjin has joined #openstack-mogan02:32
*** yuntongjin has quit IRC02:38
*** yuntongjin has joined #openstack-mogan02:40
*** RuiChen has quit IRC02:42
*** RuiChen has joined #openstack-mogan02:42
openstackgerritliusheng proposed openstack/nimble: Don't need to wait fixed time after deletion in tempest  https://review.openstack.org/41772402:49
*** RuiChen has quit IRC02:58
*** RuiChen has joined #openstack-mogan03:02
*** kevinz has joined #openstack-mogan03:13
*** Jeffrey4l_ has quit IRC03:18
*** yuntongjin has quit IRC03:26
openstackgerritliusheng proposed openstack/nimble: Don't need to wait fixed time after deletion in tempest  https://review.openstack.org/41772403:50
openstackgerritliusheng proposed openstack/nimble: Versioned notification: Add instance action notification base  https://review.openstack.org/41733504:07
openstackgerritZhenguo Niu proposed openstack/nimble: Move power target check before fetching instance from db  https://review.openstack.org/41774004:25
*** yuntongjin has joined #openstack-mogan04:50
openstackgerritZhenguo Niu proposed openstack/nimble: [WIP] Add rebuild instance support  https://review.openstack.org/41774605:13
*** wanghao_ has joined #openstack-mogan06:05
*** wanghao has quit IRC06:07
*** little has quit IRC06:17
*** little has joined #openstack-mogan06:17
openstackgerritliusheng proposed openstack/nimble: Versioned notification add support for instance.create.start  https://review.openstack.org/41775506:34
*** zhangjl has joined #openstack-mogan06:44
openstackgerritZhenguo Niu proposed openstack/nimble: [WIP] Support Floating IPs association/dissociation  https://review.openstack.org/41776006:50
zhenguoshaohe_feng: are you around?06:50
zhenguohi all, before doing further work, I would like you all to help review https://review.openstack.org/417746 and https://review.openstack.org/417760 to see our API defination which affects the following APIs.06:53
zhenguoas we don't follow nova's way to define REST APIs like instances/instance_ident/action, hope to get suggestions from all of you, thanks!06:55
* zhenguo brb06:56
*** little has quit IRC07:04
*** little has joined #openstack-mogan07:04
zhangjlhey, all07:44
zhangjlmy devstack cannot work07:44
zhangjl/opt/stack/mogan/devstack/plugin.sh: line 106: /usr/local/bin/mogan-dbsync: No such file or directory07:44
shaohe_fengzhangjl: yes.07:44
shaohe_fengzhenguo: yes07:45
shaohe_fengzhenguo: we need to support rootwrap  in mogan.07:45
shaohe_fengzhenguo: I have seen, most project support rootwrap07:46
zhangjlagree07:46
shaohe_fengzhenguo: for we will not allow a user can do everything by "sudo"07:46
zhenguozhangjl, shaohe_feng: hi07:47
openstackgerritZhenguo Niu proposed openstack/nimble: Remove target_power_state  https://review.openstack.org/41776907:47
zhangjlzhenguo:hi07:47
zhenguozhangjl: is this your first time to rebuild the devastack env after renaming?07:48
zhangjlyes07:48
zhenguozhangjl: it works well here, and we have a tempest job to build it for every patch07:48
zhenguozhangjl: so maybe you need to deep clean the env and rebuild again07:48
zhangjlzhenguo:so strange. ok, let me try07:49
zhenguoshaohe_feng: yes, agree07:49
zhenguozhangjl: yes, it's weird, I just clean up the python lib and rebuild again then it's ok07:49
zhangjlzhenguo:ok, i see07:49
zhenguoshaohe_feng: hi, I would like to introduce a new provision_state/task_state to instance to tack our task07:51
zhenguos/tack/track07:52
zhenguoshaohe_feng: and will save power_state to db instead of issuing a request to ironic every time, although this need db sync with ironic07:53
zhenguoshaohe_feng: I find a power_state_sync periodic task also have other benefits, like when the node power goes down for some reason, it will power it gain to keep consistent with the instance07:55
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server start' to set a server power on  https://review.openstack.org/41777208:03
zhenguohi every task owner, please remember to set status on the etherpad https://etherpad.openstack.org/p/nimble-task , or please feel to ping me if needed, thanks!08:06
zhenguos/set/update08:06
zhenguols08:06
shaohe_fengzhenguo: do you means the power_state_sync periodic task will also power on/off the node?08:14
zhenguoshaohe_feng: yes08:14
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server start' to set a server power on  https://review.openstack.org/41777208:15
zhenguoshaohe_feng: like when the instance is in power on, you manually power off the node, it will power it again to be consistent with instance08:15
zhenguoshaohe_feng: and I think saving a power state to db seems resonable, I don't quite like the current way to get it from ironic every time08:16
*** openstackgerrit has quit IRC08:18
zhenguoshaohe_feng, liusheng: for API defination, we will try to follow the REST instruction, instance will have two sub resources,  states and networks.08:21
zhenguoall networks related actions will under networks like instances/instance_uuid/networks/floatingip, instances/instance_uuid/networks/ports,  and GET /instances/instance_uuid/networks will return all network info08:22
zhenguoall states related actions will under states like instances/instance_uuid/power which we currently do08:23
*** openstackgerrit has joined #openstack-mogan08:23
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server stop' to set a server power off  https://review.openstack.org/41777808:23
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server reboot' to set a server power reboot  https://review.openstack.org/41777908:23
zhenguoand a new provision action added like instances/instance_uuid/provision,  then rebuild/rescure and all other instance related operations will do like this08:24
zhenguoand GET instances/instance_uuid/states will retrun {'power_state': xx, 'task_state'}, task_state will be introduced later08:24
zhenguohi all, wdyt? do you think nova's instances/instance_uuid/action pattern is better or our way is ok?08:26
liushengzhenguo: so if we only GET instances/{instance-uuid}, it won't return these fields ?08:27
zhenguoliusheng: no, it will retrun needed fields including power_state and network_info08:27
liushengzhenguo: I mean return the power_state, network_info08:27
liushengzhenguo: yes08:27
liushengzhenguo: I am afraid that will brings many APIs08:28
zhenguoliusheng: just two more, GET states/networks08:29
zhenguoliusheng: but if users find it's not useful, we can not provide them08:29
liushengzhenguo: only GET ? or PUT ?08:29
zhenguoliusheng: GET08:30
zhenguoliusheng: states/power and states/provision will be PUT08:30
zhenguoliusheng: you need to add a json field, so not that APIs08:30
zhenguonot that many APIs I mean08:31
zhenguoliusheng: nova only has one API for management instances/instance_uuid/action, hah08:31
liushengzhenguo: lol, but seems Nova don't have a specific API to query a server's power state08:33
zhenguoliusheng: yes, I rememeber at the begining of this mogan, shaohe_feng do many reserches about REST API defination, finally he said nova's API is bad08:33
liushengzhenguo: hah08:34
liushengzhenguo: we need a expert08:34
zhenguoliusheng: hah, yes08:34
zhenguoliusheng: in fact, the best API defination should be that when reading the verb and URL you should know what you will do with the resource08:36
zhenguoliusheng: like POST/PUT/DELETE /instances08:37
liushengzhenguo: eys08:37
liushengzhenguo: yes08:37
shaohe_fengliusheng: nova one api can do many thing.08:40
zhenguoshaohe_feng: hah08:41
shaohe_fengliusheng: the redhat's API define follow  API pattern.08:42
zhenguoliusheng: just FYI, I noticed Ironic also add versioned object notification suport recently, maybe we can leverage some notifications from Ironic, like we can catch some notifications from ironic, not sure if it is possible08:43
shaohe_fengliusheng: nova is rackspace pattern.08:44
shaohe_fengliusheng:  redhat's API follow RESTFUL pattern.08:44
shaohe_fengliusheng: not sure we should compatible with nova08:45
liushengzhenguo: hmm, we focus on different things08:45
zhenguoliusheng: ok08:45
liushengshaohe_feng: thanks for the info!08:45
shaohe_fengzhenguo: liusheng: such as the up layer, for example, will effect heat with different API style?08:47
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server reboot' to set a server power reboot  https://review.openstack.org/41777908:48
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server stop' to set a server power off  https://review.openstack.org/41777808:48
openstackgerritliusheng proposed openstack/python-nimbleclient: Refator: use 'server start' to set a server power on  https://review.openstack.org/41777208:48
zhenguoshaohe_feng: seems not, different API do different job is better, in heat we will not share the same thing with nova, so will not impact it08:49
liushengshaohe_feng: you mean mention this with Heat core ?08:49
shaohe_fengzhenguo: liusheng: Good.08:52
liushengzhenguo, shaohe_feng heat calls clients of other projects08:53
zhenguoshaohe_feng: hi, If you don't have objection for this https://review.openstack.org/#/c/417769/ , I will merge it directly :P08:58
shaohe_fengzhenguo: let me check it first.09:01
zhenguoshaohe_feng: ok09:01
shaohe_fengzhenguo: It is reasonable to remove target_power_state. it is not a native attr of node states09:04
zhenguoshaohe_feng: hah, thanks, will introduce a task_state later09:04
* zhenguo brb09:06
*** yuntongjin has quit IRC09:20
*** wanghao_ has quit IRC09:27
*** little has quit IRC09:28
zhenguohi all, please feel free to create/update the BP https://blueprints.launchpad.net/mogan you are working on, seems the owner in task tracking etherpad is inconsistent with launchpad.09:28
*** little has joined #openstack-mogan09:28
*** little has quit IRC09:49
openstackgerritZhenguo Niu proposed openstack/nimble: Run sync_node_resources periodic task immediately  https://review.openstack.org/41780309:51
openstackgerritliusheng proposed openstack/nimble: Remove dict compatibility or versioned object  https://review.openstack.org/41780810:10
*** kevinz has quit IRC10:16
*** zhangjl has quit IRC10:16
shaohe_fengzhenguo: liusheng: how do I enable openstack  cli  autocomplete10:20
liushengshaohe_feng: type "openstack" and into interactive modelm, does it work ?10:34
*** wanghao has joined #openstack-mogan10:46
zhenguoshaohe_feng: wrt https://review.openstack.org/#/c/417308/ , I get your comments, you mean we don't need the looping call to wait the power transition finished?11:23
*** wanghao has quit IRC11:32
*** kevinz has joined #openstack-mogan12:16
*** kevinz has quit IRC13:49
*** kevinz has joined #openstack-mogan13:50
*** kevinz has quit IRC14:15
*** Jeffrey4l_ has joined #openstack-mogan15:35
openstackgerritMerged openstack/python-nimbleclient: Enable tests coverage report when run tox -ecover  https://review.openstack.org/41639315:58
*** Jeffrey4l_ has quit IRC16:22
*** Jeffrey4l_ has joined #openstack-mogan16:24
*** l4yerffeJ has joined #openstack-mogan16:24
*** Jeffrey4l__ has joined #openstack-mogan16:35
*** l4yerffeJ has quit IRC16:38
*** Jeffrey4l_ has quit IRC16:39
*** l4yerffeJ has joined #openstack-mogan16:43
*** l4yerffeJ has quit IRC16:44
*** Jeffrey4l__ has quit IRC16:51
openstackgerritMerged openstack/python-nimbleclient: The --nic parameter should be required  https://review.openstack.org/41725917:16
openstackgerritMerged openstack/python-nimbleclient: Refator: use 'server start' to set a server power on  https://review.openstack.org/41777217:27
openstackgerritMerged openstack/python-nimbleclient: Refator: use 'server stop' to set a server power off  https://review.openstack.org/41777817:29
openstackgerritMerged openstack/python-nimbleclient: Refator: use 'server reboot' to set a server power reboot  https://review.openstack.org/41777917:29
openstackgerritMerged openstack/python-nimbleclient: Remove the --long parameter when listing flavors  https://review.openstack.org/41640417:33
*** liusheng has quit IRC17:40
*** liusheng has joined #openstack-mogan17:41
*** liusheng has quit IRC17:47
*** liusheng has joined #openstack-mogan17:47
*** Jeffrey4l_ has joined #openstack-mogan18:23
*** Jeffrey4l__ has joined #openstack-mogan21:34
*** Jeffrey4l_ has quit IRC21:35

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!