| *** yuntongjin has joined #openstack-mogan | 01:50 | |
| zhenguo | morning mogan! | 01:54 |
|---|---|---|
| *** yuntongjin has quit IRC | 02:00 | |
| Kevin_Zheng | -1ed on your nova patch | 02:01 |
| Kevin_Zheng | other people might -1 if I dont LOL | 02:02 |
| zhenguo | Kevin_Zheng: hah | 02:16 |
| liusheng | zhenguo: Hi zhenguo, about the policy refactor, if we added mogan:instance:set_power_state:on, mogan:instance:set_power_state:off, ... do we still need a mogan:instance:set_power_state ? | 02:44 |
| zhenguo | liusheng: not any more | 02:44 |
| liusheng | zhenguo: ok, got it | 02:44 |
| zhenguo | liusheng: are you working on that? | 02:45 |
| liusheng | zhenguo: yes | 02:45 |
| zhenguo | liusheng: oh, thanks | 02:45 |
| *** l4yerffeJ has quit IRC | 02:48 | |
| *** l4yerffeJ has joined #openstack-mogan | 02:49 | |
| *** openstackgerrit has joined #openstack-mogan | 02:58 | |
| openstackgerrit | liusheng proposed openstack/mogan: Refactor policy: Support precision control of power action https://review.openstack.org/424951 | 02:59 |
| *** yuntongjin has joined #openstack-mogan | 02:59 | |
| openstackgerrit | liusheng proposed openstack/mogan: Refactor policy: Support precision control of power action https://review.openstack.org/424951 | 03:01 |
| liusheng | zhenguo: have upload a patch for the policy refactoring, but didn't add tests yet. ^^ | 03:02 |
| zhenguo | liusheng: that's ok, really appreciate! | 03:02 |
| liusheng | zhenguo: np :) | 03:02 |
| openstackgerrit | liusheng proposed openstack/mogan: Refactor policy: Support precision control of power action https://review.openstack.org/424951 | 03:08 |
| openstackgerrit | liusheng proposed openstack/mogan: Use policy-generator to generate policy sample file https://review.openstack.org/424962 | 03:39 |
| *** yuntongjin has quit IRC | 03:51 | |
| *** l4yerffeJ has quit IRC | 04:01 | |
| *** l4yerffeJ has joined #openstack-mogan | 04:01 | |
| openstackgerrit | liusheng proposed openstack/mogan: Refactor policy: Support precision control of power action https://review.openstack.org/424951 | 04:02 |
| *** wanghao has joined #openstack-mogan | 04:33 | |
| *** wanghao has quit IRC | 04:35 | |
| openstackgerrit | liusheng proposed openstack/mogan: Use policy-generator to generate policy sample file https://review.openstack.org/424962 | 04:58 |
| openstackgerrit | zhangjl proposed openstack/mogan-specs: Adds specification for lock instances https://review.openstack.org/420486 | 05:48 |
| *** Jeffrey4l_ has quit IRC | 06:48 | |
| *** Jeffrey4l has joined #openstack-mogan | 06:53 | |
| zhenguo | hi all, tomorrow's irc weekly meeting will be canceled as most of us will be out of office. | 06:57 |
| zhenguo | liusheng: wrt https://review.openstack.org/#/c/424951/4/mogan/common/policy.py , is it easy to expand if I want to add other args check? like we will introduce provision state change | 07:26 |
| liusheng | zhenguo: yes, we only need to add args check in the global var FUNC_PARAMS_INTERESTED, and add the defaut rule | 07:27 |
| zhenguo | liusheng: so it would be like {'power': 'target', 'provision': 'target'}? | 07:28 |
| liusheng | zhenguo: yes, the value is a list, since I think may we have more than one paremeter need to be handled | 07:29 |
| zhenguo | liusheng: ok, sounds cool, have you tested it ? | 07:30 |
| liusheng | zhenguo: oh wait, may I need a real test, I just test tested the function can generate the action string to be mogan:instance:set_power_state:reboot | 07:32 |
| liusheng | zhenguo: please wait a min, let me use demo user to test | 07:32 |
| zhenguo | liusheng: seems we have policy unit tests, maybe need to update them to see | 07:32 |
| zhenguo | liusheng: ok | 07:32 |
| liusheng | zhenguo: you mean ut ? didn' found | 07:34 |
| zhenguo | liusheng: oh, I remember we have, let me check | 07:34 |
| zhenguo | liusheng: https://github.com/openstack/mogan/blob/master/mogan/tests/unit/api/v1/test_instance.py#L47 | 07:37 |
| zhenguo | liusheng: seems only instances basic operations covered | 07:37 |
| liusheng | zhenguo: ok, thanks, will add tests | 07:38 |
| zhenguo | liusheng: thanks | 07:38 |
| liusheng | zhenguo: we lack of many tests, hah | 07:38 |
| zhenguo | liusheng: yes, indeed :( | 07:38 |
| zhenguo | liusheng: maybe we can invite some test guys to help us, lol | 07:39 |
| liusheng | zhenguo: hah, hope that | 07:40 |
| *** wanghao has joined #openstack-mogan | 07:41 | |
| *** wanghao has quit IRC | 08:07 | |
| *** yuntongjin has joined #openstack-mogan | 08:20 | |
| *** Jeffrey4l_ has joined #openstack-mogan | 08:30 | |
| *** l4yerffeJ_ has joined #openstack-mogan | 08:30 | |
| *** l4yerffeJ has quit IRC | 08:34 | |
| *** Jeffrey4l has quit IRC | 08:34 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan: Add support for floating IPs association https://review.openstack.org/417760 | 08:44 |
| *** yuntongjin has quit IRC | 08:50 | |
| RuiChen | Happy new year, mogan | 09:13 |
| zhenguo | Happy new year! | 09:13 |
| *** liusheng has quit IRC | 09:29 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan: Add support for floating IPs association https://review.openstack.org/417760 | 09:51 |
| * zhenguo disappeared | 09:52 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** yuntongjin has joined #openstack-mogan | 10:28 | |
| *** yuntongjin has quit IRC | 10:49 | |
| *** RuiChen has quit IRC | 11:17 | |
| *** yuntongjin has joined #openstack-mogan | 11:29 | |
| *** yuntongjin has quit IRC | 12:20 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to slow performance | 12:46 | |
| -openstackstatus- NOTICE: Gerrit has been successfully restarted | 12:50 | |
| *** Jeffrey4l_ has quit IRC | 17:06 | |
| *** l4yerffeJ_ has quit IRC | 17:21 | |
| *** l4yerffeJ_ has joined #openstack-mogan | 17:21 | |
| *** Jeffrey4l has joined #openstack-mogan | 17:25 | |
| *** Jeffrey4l has quit IRC | 17:30 | |
| *** Jeffrey4l has joined #openstack-mogan | 18:41 | |
| *** Jeffrey4l has quit IRC | 18:46 | |
| *** Jeffrey4l has joined #openstack-mogan | 19:10 | |
| *** Jeffrey4l has quit IRC | 19:15 | |
| *** Jeffrey4l has joined #openstack-mogan | 19:58 | |
| *** Jeffrey4l has quit IRC | 20:04 | |
| *** Jeffrey4l has joined #openstack-mogan | 20:45 | |
| *** l4yerffeJ has joined #openstack-mogan | 21:34 | |
| *** Jeffrey4l_ has joined #openstack-mogan | 21:34 | |
| *** l4yerffeJ_ has quit IRC | 21:35 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** l4yerffeJ_ has joined #openstack-mogan | 23:03 | |
| *** l4yerffeJ has quit IRC | 23:03 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!