| *** wanghao has joined #openstack-mogan | 00:38 | |
| *** litao has joined #openstack-mogan | 00:51 | |
| *** litao has quit IRC | 00:56 | |
| *** litao has joined #openstack-mogan | 00:56 | |
| *** yuntongjin has quit IRC | 01:17 | |
| *** kevinz has joined #openstack-mogan | 01:23 | |
| liusheng | zhenguo: sorry reply lately | 01:24 |
|---|---|---|
| liusheng | zhenguo: it doesn't work | 01:24 |
| *** zhangjl has joined #openstack-mogan | 01:30 | |
| *** yuntongjin has joined #openstack-mogan | 01:30 | |
| zhenguo | liusheng: you mean upgrade ironicclient doesn't work? | 01:47 |
| liusheng | zhenguo: yes | 01:47 |
| zhenguo | liusheng: the same exception? | 01:47 |
| liusheng | zhenguo: yes | 01:48 |
| zhenguo | liusheng: it's weird | 01:49 |
| zhenguo | liusheng: and upgrade ironic? | 01:49 |
| liusheng | zhenguo: yes, I have update ironic code before stack.sh | 01:49 |
| liusheng | zhenguo: I am diging it | 01:49 |
| *** litao has quit IRC | 01:49 | |
| zhenguo | liusheng: you can try to call ironicclient directly with 1.29 | 01:49 |
| *** litao has joined #openstack-mogan | 01:50 | |
| *** wanghao has quit IRC | 01:51 | |
| *** wanghao has joined #openstack-mogan | 01:51 | |
| shaohe_feng | zhenguo: morni g | 01:53 |
| zhenguo | shaohe_feng: morning | 01:53 |
| zhenguo | shaohe_feng: sorry, you need to rebase your patch again :( | 01:53 |
| shaohe_feng | zhenguo: it does not matter | 01:56 |
| shaohe_feng | zhenguo: I'm a git expert. :) | 01:56 |
| zhenguo | shaohe_feng: hah, indeed | 01:56 |
| litao | morning | 01:57 |
| liusheng | morning | 01:57 |
| luyao | morning | 01:57 |
| liusheng | zhenguo: I will finish my patch tody | 01:57 |
| zhenguo | liusheng: thanks | 01:58 |
| zhenguo | litao, luyao: morning | 01:58 |
| zhenguo | #startmeeting mogan | 02:00 |
| openstack | Meeting started Thu Feb 16 02:00:19 2017 UTC and is due to finish in 60 minutes. The chair is zhenguo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 02:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 02:00 |
| openstack | The meeting name has been set to 'mogan' | 02:00 |
| zhenguo | hi everyone! | 02:00 |
| shaohe_feng | hi | 02:00 |
| zhenguo | wait for all say hi | 02:01 |
| luyao | hi | 02:02 |
| zhenguo | liusheng, litao, wanghao, zhangjl, yuntongjin: are you around? | 02:02 |
| liusheng | o/ | 02:03 |
| zhenguo | ok | 02:03 |
| zhenguo | as always, the agenda: | 02:03 |
| zhenguo | #link https://wiki.openstack.org/wiki/Meetings/Mogan#Agenda_for_next_meeting | 02:03 |
| zhangjl | yes | 02:04 |
| zhenguo | #topic announcements and reminders | 02:04 |
| zhangjl | zhenguo:sorry for late reply | 02:04 |
| zhenguo | zhangjl: np, hah | 02:04 |
| zhenguo | I created a mogan-ui repo, need to find some UI guys working on that | 02:04 |
| zhenguo | but seems not high priority | 02:05 |
| shaohe_feng | yes, we need ui. | 02:05 |
| zhangjl | shaohe_feng:agree | 02:05 |
| liusheng | zhenguo: does that will be integrated to horizon ? | 02:05 |
| zhenguo | yes, sure | 02:05 |
| liusheng | zhenguo: ok | 02:05 |
| zhenguo | in fact, I created senlin-dashbaord and refactored mistral-dashbaord, so maybe I can add some basic framework | 02:06 |
| shaohe_feng | that's friendily to most users who are "xiao bai" | 02:06 |
| zhenguo | lol | 02:06 |
| zhenguo | but as horizon is moving to Angular JS, but I'm not a JS guy :( | 02:07 |
| shaohe_feng | Yanli is a angular expert | 02:07 |
| shaohe_feng | yanglin | 02:07 |
| zhenguo | aha | 02:07 |
| shaohe_feng | I just use jquery. | 02:07 |
| zhenguo | maybe I can find some guys from senlin-dashbaord, | 02:08 |
| shaohe_feng | good | 02:08 |
| zhenguo | ok | 02:08 |
| zhenguo | let's move on | 02:08 |
| zhenguo | The Ocata release is comming | 02:09 |
| zhenguo | we still have many work to do before that | 02:09 |
| zhenguo | the first release if very important for us | 02:09 |
| zhenguo | and If you want to be a big tent project, you must at least have one release | 02:09 |
| zhenguo | maybe we can discuss this more in the next topic | 02:10 |
| zhenguo | anything else? | 02:11 |
| shaohe_feng | no from me. | 02:11 |
| zhenguo | aha, one more, something still broken after renaming | 02:11 |
| shaohe_feng | when will the O release freeze? | 02:11 |
| zhenguo | all git-related stat prior to the renaming have been lost on stackalytics | 02:11 |
| zhenguo | shaohe_feng: seems we dont' need freeze, | 02:12 |
| shaohe_feng | that's good. | 02:12 |
| litao | i am here | 02:13 |
| zhenguo | shaohe_feng: hmm.. maybe by this week? in fact, I'm not quite familiar with the release thing | 02:13 |
| zhenguo | litao: o/ | 02:13 |
| zhenguo | who knows who to release for a non official project | 02:13 |
| zhenguo | s/who/how | 02:13 |
| liusheng | zhenguo: just need to submit patch to openstack/releases | 02:14 |
| liusheng | zhenguo: oh, we are non official | 02:14 |
| liusheng | zhenguo: maybe just add git tag and release in pypi ? | 02:14 |
| zhenguo | liusheng: seems yes | 02:15 |
| zhenguo | liusheng: will dig later | 02:15 |
| zhenguo | and we need release moganclient as well | 02:15 |
| zhenguo | it works well for a long time | 02:15 |
| zhenguo | aha, seems not that long, lol | 02:15 |
| liusheng | zhenguo: lol | 02:16 |
| zhenguo | ok, not much of announcement, anyone else have thing here? | 02:16 |
| zhenguo | if not, let's move on | 02:17 |
| zhenguo | #topic task tracking | 02:17 |
| zhenguo | #link https://etherpad.openstack.org/p/mogan-task | 02:17 |
| * zhenguo gives folks a few minutes to review | 02:17 | |
| zhenguo | I have moved some tasks to Pike | 02:19 |
| shaohe_feng | no more developer on so many task | 02:20 |
| zhenguo | yes :( | 02:21 |
| zhenguo | and we should try to make others landed by this week | 02:21 |
| zhenguo | myabe by Friday, I will fly to Atlanta this Saturday | 02:22 |
| shaohe_feng | great. | 02:22 |
| liusheng | zhenguo: have a good trip | 02:22 |
| zhenguo | thanks | 02:23 |
| shaohe_feng | have a good jouney | 02:23 |
| zhenguo | hope os | 02:23 |
| zhenguo | s/os/so | 02:23 |
| zhenguo | hah, after all these tasks merged, I'm afraid it's may not stable... | 02:24 |
| shaohe_feng | is everything goes well for your visa? | 02:24 |
| litao | cool | 02:24 |
| zhenguo | shaohe_feng: yes, | 02:24 |
| shaohe_feng | seems Trump does not like foreigner to USA | 02:24 |
| zhenguo | hah, indeed | 02:24 |
| litao | zhenguo: fixing bugs maybe attract many developers | 02:25 |
| shaohe_feng | zhenguo: we need more test. more play mogan, more bug will be found. | 02:25 |
| zhenguo | sure, will try to find more developers | 02:26 |
| shaohe_feng | yes. | 02:26 |
| zhenguo | every task owner, can you finish yours by tomorow or maybe by today? | 02:27 |
| litao | we can use it in my own cloud platform first, such in huawei | 02:27 |
| liusheng | we are even better than some big-tent projects :( | 02:27 |
| shaohe_feng | yes. try our best to do it. | 02:27 |
| zhenguo | yes, big tent is our goal this year | 02:27 |
| litao | np | 02:28 |
| zhenguo | it's really hard to attract developers if we are not official | 02:28 |
| liusheng | we will work hard together :) | 02:28 |
| zhenguo | thanks | 02:28 |
| zhangjl | and i will introduce my colleagues into mogan | 02:29 |
| zhenguo | zhangjl: thanks a lot, | 02:29 |
| liusheng | cool | 02:29 |
| shaohe_feng | good. | 02:30 |
| zhenguo | ok, looks like things are moving along nicely | 02:30 |
| zhenguo | luyao: are you around? | 02:31 |
| luyao | zhenguo, yes | 02:31 |
| zhenguo | luyao: I find you just refactored the instance fault patch, thanks | 02:31 |
| luyao | zhenguo, no thanks,I will try my best to finish it | 02:32 |
| zhenguo | luyao: I will try to make sure to land it by tomorrow | 02:32 |
| wanghao | I will try my best and hope to finish the work today, so many works recently.... | 02:32 |
| zhenguo | wanghao: thanks a lot | 02:32 |
| zhenguo | wanghao: I just landed the mult instance creating patch, seems you need to rebase yours | 02:33 |
| wanghao | zhenguo: sure | 02:33 |
| *** fengzhr has joined #openstack-mogan | 02:33 | |
| *** Lizhixin has joined #openstack-mogan | 02:33 | |
| zhenguo | wanghao: thanks | 02:34 |
| zhangjl | zhenguo:fengzhr, Lizhixin are my colleagues | 02:34 |
| zhenguo | oh, welcome!!!! | 02:34 |
| luyao | zhenguo, what's meaning of "land"？ | 02:34 |
| *** xuao has joined #openstack-mogan | 02:34 | |
| shaohe_feng | welcome!!!! | 02:34 |
| zhangjl | zhenguo: and xuao | 02:34 |
| litao | welcome | 02:35 |
| zhangjl | zhenguo: they are `fresh man` of mogan | 02:35 |
| zhenguo | haha, big thanks zhangjl, and welcome new guys | 02:35 |
| litao | so many people, haha | 02:35 |
| zhenguo | haha | 02:35 |
| zhenguo | luyao: hi, 'land' means merge it, hah | 02:36 |
| shaohe_feng | what's meaning of "address"？ | 02:37 |
| zhenguo | shaohe_feng: address issues/problems means fix it | 02:37 |
| zhenguo | just learned that from native speakers | 02:38 |
| zhenguo | ok | 02:39 |
| shaohe_feng | zhenguo: you English is good. | 02:39 |
| zhenguo | shaohe_feng: not true | 02:39 |
| shaohe_feng | as native speakers | 02:39 |
| zhenguo | shaohe_feng: hoho | 02:39 |
| zhenguo | shaohe_feng: the last task is yours | 02:39 |
| zhenguo | and the biggest task I think | 02:39 |
| shaohe_feng | yes. | 02:40 |
| liusheng | you can smoothly communicate with foreigners | 02:40 |
| zhenguo | hah | 02:40 |
| shaohe_feng | need more effor on it. | 02:40 |
| zhenguo | I will try my best to review and test it | 02:40 |
| shaohe_feng | Good. Thanks. | 02:41 |
| zhenguo | np | 02:41 |
| zhenguo | task owners, please feel free to ping me if needed, I will be here waiting for you, lol | 02:41 |
| zhangjl | zhenguo:ok | 02:41 |
| zhenguo | let's try to get all them in by this week | 02:41 |
| zhenguo | and do you have othe concerns about the O release? | 02:42 |
| zhenguo | and something maybe need to be finished but not included in the list | 02:43 |
| zhenguo | aha, one more, the instance nics | 02:43 |
| zhenguo | it's yours liusheng :) | 02:43 |
| liusheng | zhenguo: sure, I will also try my best, lol | 02:44 |
| liusheng | zhenguo: we don't have releasenotes :( | 02:44 |
| zhenguo | that's will affect the networks and fips API | 02:44 |
| zhenguo | liusheng: yes | 02:44 |
| liusheng | zhenguo: oh. sorry for may slow process :( | 02:44 |
| zhenguo | next release we should be more offical | 02:44 |
| zhenguo | liusheng: np, that's because the internal tasks, | 02:45 |
| liusheng | zhenguo: the releasenotes can be show in our doc web page | 02:45 |
| zhenguo | liusheng: hah, but it's the first release | 02:46 |
| liusheng | zhenguo: it is convenient to show what features we have supportted now, we may need add it in the future | 02:46 |
| liusheng | zhenguo: yes | 02:46 |
| zhenguo | sure, from Pike we should to that | 02:47 |
| zhenguo | and for the client release, do you have some suggestions? | 02:48 |
| liusheng | zhenguo: I have experience about releasing client of big-tent | 02:48 |
| liusheng | zhenguo: but we are non-big-tent | 02:48 |
| zhenguo | liusheng: yes ：（ | 02:48 |
| liusheng | zhenguo: maybe just add git tag and publish it to pypi | 02:49 |
| zhenguo | maybe yes, | 02:49 |
| zhenguo | and before release, seems we have to add more cmds | 02:49 |
| zhenguo | as the current tasks all change APIs or added new ones | 02:49 |
| liusheng | zhenguo: ok, you mean flotingip releats ? | 02:50 |
| *** Guest81465 has joined #openstack-mogan | 02:50 | |
| zhenguo | liusheng: yes, and multi instance creating, lock/unlock instances, instance faults | 02:50 |
| liusheng | zhenguo: I will try | 02:50 |
| zhenguo | all | 02:50 |
| litao | zhenguo: I think we need to supprt to rescue instances | 02:51 |
| zhenguo | big task for you | 02:51 |
| liusheng | zhenguo: the client patches maybe easy | 02:51 |
| zhenguo | liusheng: thanks | 02:51 |
| zhenguo | litao: yes | 02:51 |
| liusheng | zhenguo: np | 02:51 |
| zhenguo | litao: let me check whether ironic support that first | 02:51 |
| wanghao | hi guys, do you try "pip install mogan" or not, seems it not work well in my devstack.... | 02:52 |
| zhenguo | wanghao: no | 02:52 |
| zhenguo | wanghao: we don't have any package in pypi now | 02:53 |
| zhenguo | litao: seems ironic not support rescue yet, but someone working on that, | 02:53 |
| wanghao | yes, so maybe we should fix it.... and Do we have some doc to guide user how to install mogan if there has been a devstack env. | 02:53 |
| zhenguo | wanghao: yes, we have a dev quickstart doc | 02:54 |
| zhenguo | wanghao: I will add our developers doc to the webside soon | 02:54 |
| litao | zhenguo: OK | 02:54 |
| wanghao | zhenguo: cool | 02:54 |
| wanghao | zhenguo: so I'd like to just remove the "pip install" way from mogan. | 02:55 |
| zhenguo | with this http://111.20.68.219:7950/v1/ | 02:55 |
| zhenguo | wanghao: you mean docs? | 02:55 |
| wanghao | zhenguo: yes. installation.rst | 02:56 |
| zhenguo | wanghao: in fact, it has been removed in the master | 02:56 |
| wanghao | zhenguo: is there some impacts for doc? | 02:56 |
| zhenguo | wanghao: I have refactored the doc tree | 02:56 |
| wanghao | zhenguo: ok I didn't update the code. | 02:57 |
| zhenguo | wanghao: hah | 02:57 |
| *** Guest81465 has left #openstack-mogan | 02:57 | |
| zhenguo | ok, only two minutes left | 02:58 |
| zhenguo | #topic open discussion | 02:58 |
| zhenguo | lol | 02:58 |
| zhenguo | zhangjl: you invited the whole team here? | 02:58 |
| zhangjl | zhenguo: yes | 02:59 |
| zhenguo | zhangjl: hah | 02:59 |
| zhenguo | oh, it's almost time, thanks all for joining the meeting! | 03:00 |
| zhenguo | thanks y' | 03:00 |
| zhenguo | #endmeeting | 03:00 |
| openstack | Meeting ended Thu Feb 16 03:00:35 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/mogan/2017/mogan.2017-02-16-02.00.html | 03:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/mogan/2017/mogan.2017-02-16-02.00.txt | 03:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/mogan/2017/mogan.2017-02-16-02.00.log.html | 03:00 |
| shaohe_feng | work. | 03:05 |
| litao | zhenguo: please review my patch about multi-instance in mogan-client | 03:05 |
| litao | liusheng: | 03:06 |
| openstackgerrit | zhangjl proposed openstack/mogan master: Lock instances support in Mogan(part 2) https://review.openstack.org/431490 | 03:07 |
| liusheng | litao: ok, thanks, I will review later, something wrong with my env now.. | 03:08 |
| litao | liusheng: thks | 03:11 |
| zhenguo | litao: ok, | 03:14 |
| zhenguo | FYI, hi all, please help to vote our presentations https://www.openstack.org/summit/boston-2017/vote-for-speakers#/17882 | 03:17 |
| zhenguo | liusheng: please helpt to take a look at this https://review.openstack.org/#/c/431490/3/mogan/common/policy.py | 03:24 |
| zhenguo | liusheng: wrt the lock/unlock policies defination like power | 03:24 |
| liusheng | zhenguo: yes, agree with your comments | 03:27 |
| zhenguo | liusheng: as it still use target argument, do we need to modify that? | 03:28 |
| zhenguo | liusheng: we need to use set_lock_state:true/false ? | 03:29 |
| liusheng | zhenguo: don't need, but the value scope of target ? | 03:30 |
| liusheng | zhenguo: what's the value scope | 03:30 |
| zhenguo | liusheng: true or false, a boolean | 03:30 |
| liusheng | zhenguo: I have left comments | 03:30 |
| zhenguo | liusheng: ok, thanks | 03:31 |
| zhenguo | zhangjl: please check liusheng's comments, thanks | 03:31 |
| zhangjl | zhenguo,liusheng:thks | 03:31 |
| zhenguo | zhangyang: hi, are you or liudong still interested in working on this bp https://blueprints.launchpad.net/mogan/+spec/engine-driver-framework ? | 03:35 |
| zhangyang | zhenguo:Yes, i am working on it. | 03:38 |
| zhenguo | zhangyang: ok thanks | 03:38 |
| zhangyang | zhenguo: It's almost done, I'll add some unit test today and then propose. | 03:39 |
| zhenguo | zhangyang: awesome! | 03:40 |
| zhenguo | zhangyang: have you tested Mogan with cloudboot(?) instead of ironic? | 03:40 |
| zhangyang | zhenguo: 😁 | 03:40 |
| zhangyang | zhenguo: No, not yet. | 03:40 |
| zhenguo | zhangyang: hah | 03:41 |
| zhangyang | zhenguo: The cloudboot driver is not finished yet. just modified ironic driver. | 03:41 |
| zhenguo | zhangyang: hah, hope to see that works | 03:42 |
| zhangyang | zhenguo: Yeah. | 03:42 |
| *** yuntongjin has quit IRC | 03:58 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Update instance base options while creating https://review.openstack.org/434626 | 03:58 |
| openstackgerrit | Zhong Luyao proposed openstack/mogan master: Add fault field for object Instance https://review.openstack.org/421192 | 04:52 |
| zhenguo | hi all, maybe you have noticed, I added a coverage job, it shows now our test coverage is 63%, and from there you can see which file needs more test cases, if you are interested and got time, please help to enrich that. | 05:01 |
| zhenguo | hah, from https://wiki.openstack.org/wiki/MelangeAPIBase, I find the DELETE api with adress like our disassociate fip | 05:05 |
| zhenguo | @ shaohe_feng | 05:06 |
| shaohe_feng | zhenguo: hello | 05:17 |
| zhenguo | shaohe_feng: o/ | 05:17 |
| openstackgerrit | Merged openstack/mogan master: Update instance base options while creating https://review.openstack.org/434626 | 05:25 |
| shaohe_feng | zhenguo: https://wiki.openstack.org/wiki/MelangeAPIBase#Deallocate_tenant.27s_address | 05:28 |
| zhenguo | shaohe_feng: yes, so address makes sense? | 05:28 |
| shaohe_feng | yes. | 05:29 |
| zhenguo | lol | 05:29 |
| * zhenguo brb | 05:31 | |
| openstackgerrit | ShaoHe Feng proposed openstack/mogan master: support configdrive https://review.openstack.org/416434 | 05:38 |
| *** wanghao_ has joined #openstack-mogan | 05:46 | |
| *** wanghao has quit IRC | 05:48 | |
| *** wanghao has joined #openstack-mogan | 05:48 | |
| *** wanghao_ has quit IRC | 05:52 | |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 06:58 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 06:59 |
| zhenguo | liusheng: are you around? | 07:14 |
| zhenguo | liusheng:https://github.com/openstack/mogan/blob/master/mogan/common/policy.py#L197 | 07:15 |
| liusheng | zhenguo: yes | 07:15 |
| zhenguo | liusheng: please take a look at this, it's not suit for boolean value | 07:15 |
| zhenguo | liusheng: or interger value 0 | 07:16 |
| liusheng | zhenguo: oh, sorry seems I made a bug.. | 07:16 |
| zhenguo | liusheng: hah, is there a simple way to handle that | 07:18 |
| liusheng | zhenguo: maybe just remove the if condition | 07:18 |
| liusheng | zhenguo: let me check | 07:18 |
| zhenguo | liusheng: thanks | 07:18 |
| *** xuao has quit IRC | 07:24 | |
| zhenguo | liusheng: as lock/unlock instance use a target with boolean value, this bug blocks the task, seems i't ok to just get rid of the if condition | 07:32 |
| liusheng | zhenguo: yes my patch is comming | 07:33 |
| zhenguo | liusheng: ok, thanks | 07:33 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix precise policy control https://review.openstack.org/434691 | 07:33 |
| zhenguo | zhangjl: hi, liusheng jsut sent a patch to address that issue. | 07:36 |
| zhangjl | zhenguo:ok | 07:37 |
| liusheng | zhangjl, zhenguo FYI, I just found if we support target:True and False, the default policy must be xxx:True than xxx:true | 07:38 |
| liusheng | zhenguo: may need to improve it | 07:39 |
| zhangjl | liusheng:yes, i just found it | 07:39 |
| liusheng | zhenguo: and the default policy rules must cover all the value scope of target :( | 07:40 |
| liusheng | zhenguo: not sure it can be the *default* rule | 07:41 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 07:41 |
| *** Lizhixin has left #openstack-mogan | 07:49 | |
| zhenguo | liusheng, zhangjl: how about using strutils.bool_from_string to convert it? | 07:54 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 07:54 |
| zhangjl | zhenguo:maybe not. | 07:54 |
| zhenguo | zhangjl, liusheng: xxx:True seems a bit strange | 07:55 |
| zhangjl | zhenguo:the params in _add_action_extra has been change to boolean from json body | 07:56 |
| liusheng | zhenguo: the strutils.bool_from_string can be covert any value, and convert them to True and False, it will also convert 1 to True, but how to handle if we need to set the value is 1 | 07:56 |
| zhangjl | liusheng:agree | 07:57 |
| zhenguo | liusheng, zhangjl: yes, is there something like string_from_boo | 07:57 |
| liusheng | zhenguo,zhangjl do the value of target can only be True or False ? | 07:59 |
| zhenguo | seems yes | 07:59 |
| liusheng | zhenguo, zhangjl seems in some cases, the input boolean value can be any True value or False value | 07:59 |
| liusheng | zhenguo: in other projects | 07:59 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 07:59 |
| liusheng | zhenguo: the api inpu value can be 0, 1, true false, False, True ... | 08:00 |
| zhangjl | liusheng:i tested, 1, 0, false, true, True, False also be ok | 08:00 |
| zhangjl | because it will be changed to boolean in pecan | 08:00 |
| zhenguo | zhangjl, liusheng: yes, and before passing to authorize, has it been converted? | 08:01 |
| zhangjl | liusheng,zhenguo:in other projects | 08:01 |
| liusheng | zhangjl: yes, do you know if the the policy check decorator is before the pecan boolean conversion or not | 08:01 |
| zhangjl | liusheng:no... | 08:01 |
| zhenguo | seems wmse decrator is the first one | 08:02 |
| zhenguo | need to confirm | 08:02 |
| liusheng | zhenguo: I am just thinking, do we need precise policy contol on these two action ? | 08:03 |
| zhenguo | liusheng: you mean lock/unlock should be same policy ? | 08:04 |
| liusheng | zhenguo: is there use case that we need a policy rule for lock and another policy rule for unlock ? | 08:04 |
| liusheng | zhenguo: it is my doubt | 08:04 |
| zhenguo | liusheng, zhangjl: seems there's not a use case | 08:05 |
| liusheng | zhenguo, zhangjl if so, how about make things simple and make people happy, lol | 08:05 |
| zhenguo | lol, agree | 08:05 |
| zhangjl | zhenguo: hah | 08:05 |
| zhenguo | let's land it soon | 08:06 |
| zhangjl | zhenguo,liusheng:agree | 08:06 |
| zhenguo | ok, so no need to update the patch | 08:06 |
| zhangjl | zhenguo:ok | 08:07 |
| zhenguo | zhangjl: have +Aed the patch, waiting for the following up one to add checks | 08:09 |
| *** zhangjl1 has joined #openstack-mogan | 08:11 | |
| *** zhangjl has quit IRC | 08:13 | |
| *** zhangjl1 has quit IRC | 08:15 | |
| openstackgerrit | Merged openstack/mogan master: Lock instances support in Mogan(part 2) https://review.openstack.org/431490 | 08:35 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 08:44 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 08:52 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: Split out network_info from Instance object https://review.openstack.org/430139 | 08:56 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 08:58 |
| openstackgerrit | Tao Li proposed openstack/mogan master: Add api-ref documents for multi-instance-create https://review.openstack.org/434760 | 09:14 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Following up patch of multi instance creating https://review.openstack.org/434764 | 09:23 |
| *** litao has quit IRC | 09:29 | |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit has joined #openstack-mogan | 09:35 | |
| openstackgerrit | Zhong Luyao proposed openstack/mogan master: Add fault field for object Instance https://review.openstack.org/421192 | 09:35 |
| zhenguo | luyao: hi, we don't need this sa.Column('fault', sa.Text(), nullable=True) in db schema and models | 09:40 |
| zhenguo | luyao: it is joined when we construct instance object | 09:41 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 09:45 |
| *** wanghao has quit IRC | 09:45 | |
| *** kevinz has quit IRC | 10:38 | |
| zhenguo | liusheng: seem somthing wrong when running 'openstack baremetal server get bm2' | 11:21 |
| zhenguo | liusheng: it will issue 4 request to mogan | 11:22 |
| liusheng | zhenguo: do we have "server get" command ? | 11:22 |
| zhenguo | liusheng: sorry, server show | 11:22 |
| openstackgerrit | zhangjl proposed openstack/mogan master: Lock instances support in Mogan(part 3) https://review.openstack.org/434823 | 11:23 |
| zhenguo | liusheng: seeems it will try to issue GET /instances/bm2-1 first | 11:23 |
| liusheng | zhenguo: did you use name or id ? | 11:23 |
| zhenguo | liusheng: name | 11:23 |
| liusheng | zhenguo: seems because it need try to find | 11:24 |
| liusheng | zhenguo: osc_lib | 11:24 |
| zhenguo | liusheng: seems yes | 11:24 |
| liusheng | zhenguo: it need to get one, list and get one again etc. | 11:24 |
| zhenguo | liusheng: it will list all instances, and find the matched instance uuid, then issue the correct request | 11:24 |
| liusheng | zhenguo: yes | 11:24 |
| liusheng | zhenguo: may can improve in osc_lib | 11:24 |
| zhenguo | liusheng: seems right, no better way | 11:25 |
| liusheng | zhenguo: long ago aodhclient implemented the similar function by it's own, it will use the uuid_like util method to check firstly | 11:26 |
| liusheng | zhenguo: seems that can reduce some requests | 11:26 |
| zhenguo | liusheng: yes, will save 2 requests | 11:26 |
| zhenguo | liusheng: but no rush, at least it can work now | 11:27 |
| liusheng | zhenguo: ok | 11:27 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Following up patch of multi instance creating https://review.openstack.org/434764 | 11:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Following up patch of multi instance creating https://review.openstack.org/434764 | 12:26 |
| * zhenguo goes home | 12:27 | |
| *** yuntongjin has joined #openstack-mogan | 12:28 | |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: Split out network_info from Instance object https://review.openstack.org/430139 | 12:37 |
| *** kevinz has joined #openstack-mogan | 13:12 | |
| *** kevinz has quit IRC | 13:21 | |
| *** kevinz has joined #openstack-mogan | 13:21 | |
| *** Jeffrey4l has quit IRC | 13:30 | |
| *** Jeffrey4l has joined #openstack-mogan | 13:31 | |
| *** l4yerffeJ has joined #openstack-mogan | 13:33 | |
| *** l4yerffeJ has quit IRC | 13:33 | |
| *** l4yerffeJ has joined #openstack-mogan | 13:34 | |
| *** kevinz has quit IRC | 13:42 | |
| *** kevinz has joined #openstack-mogan | 13:42 | |
| *** l4yerffeJ has quit IRC | 13:49 | |
| *** yuntongjin has quit IRC | 13:58 | |
| *** kevinz has quit IRC | 14:16 | |
| *** kevinz has joined #openstack-mogan | 14:16 | |
| *** kevinz has quit IRC | 14:23 | |
| openstackgerrit | ZhangYang proposed openstack/mogan master: Add engine driver framework base driver. https://review.openstack.org/434953 | 14:53 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: Split out network_info from Instance object https://review.openstack.org/430139 | 14:59 |
| openstackgerrit | Merged openstack/mogan master: Following up patch of multi instance creating https://review.openstack.org/434764 | 15:11 |
| openstackgerrit | liusheng proposed openstack/mogan master: Split out network_info from Instance object https://review.openstack.org/430139 | 16:58 |
| *** liusheng has quit IRC | 17:02 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** Jeffrey4l has joined #openstack-mogan | 21:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!