| *** wxy has joined #openstack-mogan | 00:42 | |
| *** wanghao has joined #openstack-mogan | 00:51 | |
| *** litao has joined #openstack-mogan | 00:52 | |
| *** kevinz has joined #openstack-mogan | 01:13 | |
| *** zhangjl has joined #openstack-mogan | 01:19 | |
| wanghao | zhenguo: qutoa patch has been updated, pls have a review. | 01:22 |
|---|---|---|
| zhenguo | wanghao: thanks | 01:39 |
| wanghao | zhenguo: np | 01:40 |
| *** wanghao has quit IRC | 01:48 | |
| *** wanghao has joined #openstack-mogan | 01:48 | |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: test support console -- ignore me https://review.openstack.org/420274 | 02:27 |
| openstackgerrit | liusheng proposed openstack/mogan master: Split out network_info from Instance object https://review.openstack.org/430139 | 02:46 |
| openstackgerrit | liusheng proposed openstack/mogan master: Split out network_info from Instance object https://review.openstack.org/430139 | 02:59 |
| *** litao has quit IRC | 03:27 | |
| *** litao has joined #openstack-mogan | 03:28 | |
| *** wanghao has quit IRC | 03:28 | |
| *** wanghao has joined #openstack-mogan | 03:28 | |
| *** l4yerffeJ has joined #openstack-mogan | 03:38 | |
| *** l4yerffeJ has quit IRC | 03:42 | |
| *** l4yerffeJ has joined #openstack-mogan | 03:43 | |
| *** yuntongjin has joined #openstack-mogan | 04:20 | |
| *** yuntongjin has quit IRC | 04:25 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Include lock state in InstanceStates API object https://review.openstack.org/439385 | 04:54 |
| openstackgerrit | Merged openstack/python-moganclient master: Updated from global requirements https://review.openstack.org/439358 | 05:08 |
| openstackgerrit | Merged openstack/mogan master: Updated from global requirements https://review.openstack.org/439223 | 05:34 |
| openstackgerrit | Merged openstack/mogan master: Move api samples to correct directories https://review.openstack.org/438851 | 05:34 |
| *** yuntongjin has joined #openstack-mogan | 05:49 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Split out network_info from Instance object https://review.openstack.org/430139 | 06:19 |
| *** yuntongjin has quit IRC | 06:28 | |
| *** yuntongjin has joined #openstack-mogan | 06:37 | |
| openstackgerrit | Merged openstack/mogan master: Include lock state in InstanceStates API object https://review.openstack.org/439385 | 07:11 |
| zhenguo | liusheng: hi, after refactoring to use instance.nics, should we change the API response as well? in fact, currently the instance.network_info is ports | 07:18 |
| *** luyao has joined #openstack-mogan | 07:19 | |
| liusheng | zhenguo: yes, I want to also refactor the api, and want to ask your opinion :) | 07:22 |
| zhenguo | liusheng: hah, I think the current patch is ok, we can add another path for API side | 07:22 |
| liusheng | zhenguo: yes, how do you think the "nics" field in instance body is like a list of dict, e.g. [{'port_id'xxx, 'port_type':xx, 'floatingip': xx, 'ip':xx}, .. another port] ? | 07:24 |
| liusheng | zhenguo: since currently it is a dict and the keys is the port uuids. | 07:25 |
| zhenguo | liusheng: I think is ok, btw, do we have a uuid for nic? | 07:25 |
| liusheng | zhenguo: it is implicit the port uuid | 07:25 |
| liusheng | zhenguo: no, the primary key of nic is also port_id | 07:26 |
| zhenguo | liusheng: should we consider to add a uuid for nic, as it's a separate object now, like when detaching a interface, we should use it's uuid? | 07:27 |
| zhenguo | liusheng: or does it make sense that we have a nic which not associate neutron port id? | 07:28 |
| zhenguo | liusheng: I remember nova now support to create instance with nics that set net-id=none | 07:28 |
| liusheng | zhenguo: I don't think so, the nic is still a port in fact, but include some extra info | 07:29 |
| liusheng | zhenguo: yes | 07:29 |
| zhenguo | liusheng: let's try to make is clear, does nic equals to port? | 07:31 |
| liusheng | zhenguo: I think the "port_id" field in a nic object is always not null, so the nic must include a port's identity. and also it can include port_type, floatingip. ip_address .. fields | 07:32 |
| liusheng | zhenguo: what do you think ? | 07:32 |
| liusheng | zhenguo: it is like a phhsical Network Interface Card, and include all the attributes of the nic | 07:34 |
| zhenguo | liusheng: so you think a nic must be associate with a port? | 07:36 |
| liusheng | zhenguo: yes | 07:36 |
| zhenguo | liusheng: for baremetal, as the physical interfaces is fixed, should we include all to the instance? | 07:37 |
| zhenguo | liusheng: like you may have a node which has 4 ports, but when request to creating a instance you may only set --nic with one net-id, so the instance should include one nic or 4 nics | 07:38 |
| liusheng | zhenguo: but if want to use the physical interface, we must create a port with its mac firstly, right ? | 07:38 |
| zhenguo | liusheng: correct, if you want to make the interface work, you must create a neutron prot | 07:39 |
| zhenguo | liusheng: but the instance may have some nics that doesn't work now, and users can attach it to a neutron net work to make it work, make sense? | 07:40 |
| zhenguo | liusheng: or detach some nics | 07:40 |
| liusheng | zhenguo: if we specified --nic with one net-id, I think the current code logic will create 4 ports in the net, and 4 nic objects will be also created internally | 07:40 |
| zhenguo | liusheng: I mean just specify --nic net-id=xx once | 07:41 |
| liusheng | zhenguo: oh | 07:42 |
| liusheng | zhenguo: users may need to create neutron port firstly if they want to attach a interface | 07:42 |
| zhenguo | liusheng: no | 07:42 |
| zhenguo | liusheng: we can provide a attach API | 07:43 |
| liusheng | zhenguo: hmm I got you | 07:43 |
| liusheng | zhenguo: if so, the only identity of a physical interface I think is the mac address | 07:44 |
| liusheng | zhenguo: right ? | 07:44 |
| zhenguo | liusheng: seems yes, but I'm not sure this make sense | 07:44 |
| zhenguo | liusheng: this means we should sync all ironic ports to our nics | 07:44 |
| liusheng | zhenguo: just talked with zhenyu, he said seems Nova has a tendency that it is recommended to only support create instance by port specified | 07:46 |
| liusheng | zhenguo: the creating instance with network specified way may will be deprecated | 07:46 |
| liusheng | zhenguo: it is a legacy problem that Nova historical has nova-network | 07:47 |
| zhenguo | liusheng: oh, so users should create a port themselves? | 07:47 |
| liusheng | zhenguo: yes | 07:47 |
| zhenguo | liusheng: hah, in fact, we don't support to specify port id now | 07:48 |
| liusheng | zhenguo: lol | 07:48 |
| zhenguo | lol | 07:48 |
| liusheng | zhenguo: we should support that way :) | 07:49 |
| zhenguo | liusheng: sure, hah | 07:49 |
| zhenguo | liusheng: we can keep the current instance nics way, will test it and land it, thanks | 07:49 |
| liusheng | zhenguo: thanks | 07:49 |
| zhenguo | np | 07:49 |
| liusheng | zhenguo: btw, I need you to teach me about the console lol | 07:50 |
| liusheng | zhenguo: do you have time ? | 07:50 |
| zhenguo | liusheng: hah, does it work now | 07:50 |
| liusheng | zhenguo: for now, I only uploaded a experimental patch, throngh it I can start mogan-shellinaboxproxy and mogan-consoauth service | 07:51 |
| liusheng | zhenguo: and a api get_vnc_console | 07:52 |
| liusheng | zhenguo: I can get the a console url by the api paste it in browser and mogan-shellinaboxproxy can handle the request | 07:52 |
| zhenguo | liusheng: so it works now? | 07:53 |
| liusheng | zhenguo: but I don't know how config ironic, the ironic node -- libvirt doman cannot open the connection, as you have suggested me, I can modify the xml to make it work | 07:54 |
| liusheng | zhenguo: but I don't how to config ironic make it work | 07:54 |
| liusheng | zhenguo: do you still remember ? | 07:55 |
| liusheng | zhenguo: <console type='pty'> | 07:55 |
| liusheng | <target type='serial' port='0'/> | 07:55 |
| liusheng | </console> | 07:55 |
| zhenguo | liusheng: you mean ironic shellinabox console also not work now? | 07:55 |
| liusheng | zhenguo: the above xml you have suggested me to modify it to the xml | 07:55 |
| zhenguo | liusheng: you can enable ironic node console and get a console url | 07:55 |
| zhenguo | liusheng: so with 'virsh console' works not not? | 07:56 |
| liusheng | zhenguo: cannot work, same problem | 07:56 |
| zhenguo | liusheng: I remember it works after that change | 07:57 |
| liusheng | zhenguo: yes | 07:57 |
| liusheng | zhenguo: definitely I cannot modify manually evey time :) | 07:58 |
| zhenguo | liusheng: hah | 07:58 |
| zhenguo | liusheng: so if you manually modifyed the xml file, it can work, right? | 08:03 |
| liusheng | zhenguo: http://10.229.40.107:8866/?token=f8d78212-abaa-4b74-8d3a-9c07fe3fd841 | 08:04 |
| liusheng | zhenguo: you can try in your bluecloud | 08:04 |
| liusheng | zhenguo: error: internal error: character device <null> is not using a PTY | 08:05 |
| *** litao has quit IRC | 08:05 | |
| *** litao has joined #openstack-mogan | 08:05 | |
| zhenguo | liusheng: that's because your virsh xml still have problems | 08:06 |
| zhenguo | liusheng: you should make sure virsh console work first | 08:06 |
| liusheng | zhenguo: yes, but I don't know how to config | 08:06 |
| liusheng | zhenguo: may some related config options in ironic ? | 08:07 |
| zhenguo | liusheng: yes, I added that option, | 08:07 |
| liusheng | zhenguo: which one ? | 08:07 |
| zhenguo | liusheng: but not sure whether it works or not | 08:07 |
| zhenguo | liusheng: wait for a sec, let me find | 08:07 |
| liusheng | zhenguo: you have uploaded patch of mogan's devstack plugin ? | 08:08 |
| zhenguo | liusheng: no | 08:09 |
| zhenguo | liusheng: https://github.com/openstack/ironic/blob/master/devstack/tools/ironic/scripts/configure-vm.py#L45-L52 | 08:09 |
| liusheng | zhenguo: you mean fixed in ironic ? | 08:10 |
| zhenguo | liusheng: Ironic seems already support this, which added by me after ssh cosnole support | 08:10 |
| liusheng | zhenguo: ok, don't need any config option ? | 08:11 |
| liusheng | zhenguo: I can try tup update ironic code in my env and try again | 08:13 |
| zhenguo | liusheng: please hold on, let me figure it out | 08:13 |
| liusheng | zhenguo: ok thanks | 08:14 |
| zhenguo | liusheng: as I understand if you set IRONIC_VM_LOG_CONSOLE to False, it will create a vm with pty console | 08:22 |
| liusheng | zhenguo: you mean config it in local.conf ? | 08:23 |
| zhenguo | liusheng: yes, but seems it not work in my env | 08:23 |
| liusheng | zhenguo: :( | 08:24 |
| openstackgerrit | Zhong Luyao proposed openstack/mogan master: Add fault object https://review.openstack.org/421192 | 08:25 |
| zhenguo | liusheng: you can read the code from here https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L1303 | 08:26 |
| liusheng | zhenguo: ok | 08:26 |
| zhenguo | luyao: sorry, seems the instance fault patch will conflict after this https://review.openstack.org/#/c/430139/ landed :( | 08:28 |
| luyao | zhenguo, never mind, i saw that, I will do rebase on it | 08:35 |
| zhenguo | luyao: thanks | 08:35 |
| openstackgerrit | Merged openstack/mogan master: Split out network_info from Instance object https://review.openstack.org/430139 | 08:36 |
| zhenguo | luyao: and seems the patch only include fault object change right? you plan to add a following up patch for real instance faults added? | 08:36 |
| luyao | zhenguo, yes, I intend to do so | 08:37 |
| zhenguo | luyao: ok, thanks a lot | 08:37 |
| liusheng | zhenguo: https://github.com/openstack/ironic/blob/master/devstack/tools/ironic/scripts/configure-vm.py#L123-L126 seems it is relate with these lines of code | 08:38 |
| luyao | zhenguo, no thanks,:) | 08:38 |
| zhenguo | luyao: yes, and seems if you set the option to false, it will set console to pty | 08:39 |
| zhenguo | oh, sorry send to wrong person | 08:40 |
| zhenguo | liusheng: https://review.openstack.org/#/c/256272/ | 08:41 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: [api-ef]Add locked to states API https://review.openstack.org/439456 | 08:48 |
| zhenguo | wanghao: sorry, seems the quota patch needs to be rebased after the nics patch landed :( | 08:49 |
| liusheng | zhenguo: yes, it seems only depend on IRONIC_VM_LOG_CONSOLE | 08:49 |
| openstackgerrit | wanghao proposed openstack/mogan master: Quota support in Mogan(part 1) https://review.openstack.org/417326 | 08:49 |
| liusheng | zhenguo: I will try again | 08:49 |
| wanghao | zhenguo: yes, it's coming | 08:49 |
| zhenguo | wanghao: haha, | 08:49 |
| wanghao | zhenguo: :) | 08:50 |
| zhenguo | wanghao: will land it soon after tested it | 08:50 |
| zhenguo | liusheng: yes, but on my env, I just checked the option is set, but the xml file isn't as expected, you can try | 08:51 |
| *** yuntongjin has quit IRC | 08:52 | |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: test support console -- ignore me https://review.openstack.org/420274 | 08:59 |
| *** wanghao_ has joined #openstack-mogan | 09:00 | |
| *** wanghao has quit IRC | 09:04 | |
| *** yuntongjin has joined #openstack-mogan | 09:24 | |
| *** wanghao_ has quit IRC | 09:24 | |
| *** wanghao has joined #openstack-mogan | 09:25 | |
| *** wanghao has quit IRC | 09:32 | |
| *** litao has quit IRC | 09:34 | |
| *** zhangjl has quit IRC | 09:44 | |
| *** yuntongjin has quit IRC | 10:01 | |
| openstackgerrit | Merged openstack/mogan master: [api-ef]Add locked to states API https://review.openstack.org/439456 | 10:01 |
| openstackgerrit | Zhong Luyao proposed openstack/mogan master: Add fault object https://review.openstack.org/421192 | 10:07 |
| *** kevinz has quit IRC | 10:12 | |
| *** Jeffrey4l has quit IRC | 10:30 | |
| *** Jeffrey4l has joined #openstack-mogan | 10:49 | |
| *** kevinz has joined #openstack-mogan | 12:18 | |
| *** kevinz has quit IRC | 12:18 | |
| *** yuntongjin has joined #openstack-mogan | 12:43 | |
| *** yuntongjin has quit IRC | 13:13 | |
| *** yuntongjin has joined #openstack-mogan | 13:14 | |
| *** yuntongjin has quit IRC | 13:46 | |
| *** yuntongjin has joined #openstack-mogan | 13:46 | |
| Kevin_Zheng | what irc client you guys using | 14:01 |
| *** yuntongjin has quit IRC | 14:09 | |
| openstackgerrit | Merged openstack/mogan master: Add fault object https://review.openstack.org/421192 | 14:58 |
| *** Jeffrey4l has quit IRC | 17:59 | |
| *** openstackgerrit has quit IRC | 20:03 | |
| *** l4yerffeJ has quit IRC | 20:41 | |
| kong | Kevin_Zheng: irccloud | 20:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!