| *** wanghao has joined #openstack-mogan | 00:08 | |
| openstackgerrit | Tao Li proposed openstack/mogan master: Improve the multi-instance creation https://review.openstack.org/453675 | 01:01 |
|---|---|---|
| zhenguo | morning mogan! | 01:02 |
| Xinran | zhenguo, Hi, please review detach interface if you have time here is the link https://review.openstack.org/#/c/461767 thx | 01:14 |
| zhenguo | Xinran: ok, sorry for the delay | 01:14 |
| zhenguo | Xinran: but seems attch interface should be land first, wdyt? | 01:15 |
| zhenguo | liusheng: hi, maybe we can should mogan during the Bug Smash, what do you thing must be done before that? | 01:17 |
| zhenguo | liusheng: s/should/show | 01:18 |
| zhenguo | s/thing/think | 01:18 |
| zhenguo | so many typos :D | 01:18 |
| Xinran | zhenguo, we can detach whichever port provided the port id is given, each server has a port attached automatically during the creation , so i think we can test with that | 01:19 |
| zhenguo | Xinran: aha, yes | 01:19 |
| zhenguo | Xinran: it can be test separately :D | 01:19 |
| Xinran | zhenguo, yes | 01:20 |
| zhenguo | Xinran: wil review soon, thanks! | 01:20 |
| *** liusheng has joined #openstack-mogan | 01:21 | |
| Xinran | zhenguo, np | 01:21 |
| *** kevinz has joined #openstack-mogan | 01:34 | |
| zhenguo | liusheng: hi, is keypair name a unique key? | 02:06 |
| liusheng | zhenguo: name&user_id | 02:07 |
| zhenguo | liusheng: ok, got it, thanks! | 02:07 |
| liusheng | zhenguo: np | 02:07 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Add keypairs panel https://review.openstack.org/463223 | 03:12 |
| zhenguo | liusheng: I just added the keypair panel to mogan-ui with all functionalities, you can try if you would like :D | 03:14 |
| liusheng | zhenguo: thanks, cool! | 03:14 |
| zhenguo | liusheng: and do you think keypair should be mandatory when creating a server in UI | 03:15 |
| liusheng | zhenguo: just because we cannot set password now ? lol | 03:15 |
| zhenguo | liusheng: hah, | 03:15 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Add keypairs panel https://review.openstack.org/463223 | 03:30 |
| openstackgerrit | Merged openstack/mogan master: Add releasenotes for Mogan https://review.openstack.org/460868 | 03:42 |
| openstackgerrit | Merged openstack/mogan-ui master: Add keypairs panel https://review.openstack.org/463223 | 03:45 |
| zhenguo | liusheng: hi, do you want to take the task to return flavor access projects? | 03:50 |
| liusheng | zhenguo: ok, sure | 03:51 |
| zhenguo | liusheng: really appreciated! | 03:51 |
| liusheng | zhenguo: will go for lunch :D | 03:51 |
| liusheng | zhenguo: np | 03:51 |
| zhenguo | liusheng: hah | 03:51 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Fix delete action allow check https://review.openstack.org/463239 | 05:02 |
| *** Kevin_Zheng has quit IRC | 05:07 | |
| *** Kevin_Zheng has joined #openstack-mogan | 06:12 | |
| openstackgerrit | Merged openstack/mogan-ui master: Fix delete action allow check https://review.openstack.org/463239 | 06:15 |
| *** liusheng has quit IRC | 06:19 | |
| *** liusheng has joined #openstack-mogan | 06:20 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Add mogan exceptions https://review.openstack.org/463255 | 06:43 |
| *** litao has joined #openstack-mogan | 06:54 | |
| litao | zhenguo: pls review the patch: https://review.openstack.org/#/c/453675/ | 06:54 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Add mogan exceptions https://review.openstack.org/463255 | 06:55 |
| zhenguo | litao: sure, thanks for the update! | 06:55 |
| Xinran | liusheng, hi, thanks for your comments, i tried with self.driver.BaseEngineDriver.unplug_vifs, but the method is not implemented. It was only implemented in IronicDriver. | 06:56 |
| litao | zhenguo: np | 06:56 |
| zhenguo | litao: and congratulations to Fiberhome for Gold Member :D | 06:58 |
| zhenguo | Xinran: that should be an issue, | 06:58 |
| liusheng | Xinran: may need to add the method in driver layer, what do you think zhenguo ? | 06:58 |
| liusheng | zhenguo: :D | 06:59 |
| zhenguo | Xinran, liusheng: every driver should be inherited from base driver | 06:59 |
| zhenguo | liusheng: sure, we need to add it | 06:59 |
| liusheng | zhenguo: yes, agreed | 06:59 |
| liusheng | Xinran: since we need to consider to also support other possible drivers, e.g. cloudboot | 07:00 |
| Xinran | But there is no method implemented in BaseEngineDriver, each sub class will override the method they need. That's what I think. | 07:01 |
| Xinran | zhenguo, liusheng Cause for different drivers, maybe the implemention of method will be different. Wdyt | 07:04 |
| zhenguo | Xinran: yes, they will all override it, but we need to leave it to the base driver with required arguments, every driver should follow it | 07:06 |
| liusheng | Xinran: yes, the implementation in different drivers maybe different, but it's better to keep same input parameters and same effects/outputs | 07:07 |
| Xinran | zhenguo, liusheng yes, it did exist the method unplug_vifs in BaseEngineDriver, but we need call IronicDriver.unplug_vifs to do something. So i can't just import a universal baremental driver | 07:10 |
| zhenguo | Xinran: I just left some comments in the patch | 07:10 |
| zhenguo | Xinran: it should be like this https://github.com/openstack/mogan/blob/master/mogan/engine/base_manager.py#L40 , sorry for the misleading | 07:13 |
| zhenguo | Xinran: and as I commented, I don't like to import ironic driver in neutron api file | 07:13 |
| liusheng | Xinran: self.driver = driver.load_engine_driver(CONF.engine.engine_driver), this statement will load the ironic driver, so it actually call the mothod in ironic driver | 07:14 |
| Xinran | zhenguo, ok i see. luyao and I we did both attach/detach neutron port with/from server and attach/detach neutron port with/from ironic port | 07:15 |
| liusheng | zhenguo: agreed, it is better to put these stuff in engine/manager.py | 07:16 |
| zhenguo | Xinran: yes, and we dont' import driver in API, you can use a rpc call to engine to do it, and neutron api should only handle it's own stuff, after that you can call driver.unplu_vif | 07:16 |
| zhenguo | for both Xinran and luyao :) | 07:17 |
| zhenguo | liusheng: yes | 07:17 |
| openstackgerrit | Merged openstack/mogan-ui master: Add mogan exceptions https://review.openstack.org/463255 | 07:32 |
| Xinran | zhenguo, liusheng Is it means that I use a rpc call in server.py and i should implement the detach fonction in engine/manager but not in network_api ? | 07:33 |
| Xinran | Or the neutron part in network_api and ironic_part in engine/manager? | 07:34 |
| liusheng | Xinran: you can see, in engine/manager.py, there is a self.network_api which contains the network related methods defined in network/api.py, so you can put all the neutron related operations in to the network/api.py and put the main proces in manager.py | 07:37 |
| Xinran | liusheng, Cool Got it thanks you all | 07:39 |
| liusheng | Xinran: you are welcome :D | 07:39 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Fix server get exception when deleting https://review.openstack.org/463267 | 07:50 |
| openstackgerrit | Merged openstack/mogan-ui master: Fix server get exception when deleting https://review.openstack.org/463267 | 08:04 |
| zhenguo | w | 08:16 |
| zhenguo | :w | 08:16 |
| zhenguo | oops | 08:16 |
| * zhenguo brb | 08:36 | |
| litao | zhenguo: thks， Huawei is an old brother for Gold Member：） | 09:34 |
| zhenguo | litao: lol | 09:35 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Launch server workflow support https://review.openstack.org/463288 | 09:41 |
| * zhenguo brb | 09:42 | |
| *** kevinz has quit IRC | 10:32 | |
| *** zhenguo has quit IRC | 10:46 | |
| *** zhenguo has joined #openstack-mogan | 10:46 | |
| openstackgerrit | Zhong Luyao proposed openstack/mogan master: Attach interface for server https://review.openstack.org/459921 | 10:47 |
| *** wanghao has quit IRC | 10:53 | |
| openstackgerrit | Xinran WANG proposed openstack/mogan master: Detach interface for server https://review.openstack.org/461767 | 11:00 |
| openstackgerrit | liusheng proposed openstack/mogan master: Return access projects info query flavor https://review.openstack.org/463308 | 11:06 |
| openstackgerrit | Xinran WANG proposed openstack/mogan master: Detach interface for server https://review.openstack.org/461767 | 11:09 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Launch server workflow support https://review.openstack.org/463288 | 11:30 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-ui master: Launch server workflow support https://review.openstack.org/463288 | 11:50 |
| *** kevinz has joined #openstack-mogan | 11:52 | |
| *** litao has quit IRC | 11:59 | |
| *** kevinz has quit IRC | 12:03 | |
| *** kevinz has joined #openstack-mogan | 12:04 | |
| openstackgerrit | Merged openstack/mogan-ui master: Launch server workflow support https://review.openstack.org/463288 | 13:54 |
| *** kevinz has quit IRC | 14:05 | |
| *** kevinz has joined #openstack-mogan | 14:46 | |
| *** kevinz has quit IRC | 14:51 | |
| *** wanghao has joined #openstack-mogan | 15:42 | |
| *** wanghao has quit IRC | 15:55 | |
| *** wanghao_ has joined #openstack-mogan | 17:37 | |
| *** wanghao_ has quit IRC | 19:56 | |
| *** wanghao_ has joined #openstack-mogan | 22:16 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!