*** wanghao_ has joined #openstack-mogan | 00:36 | |
*** wanghao has quit IRC | 00:39 | |
zhenguo | morning mogan! | 01:00 |
---|---|---|
liusheng | morning | 01:01 |
*** fredli__ has joined #openstack-mogan | 01:01 | |
zhenguo | liusheng: hi, please have a look at this https://review.openstack.org/#/c/475755/ | 01:09 |
liusheng | zhenguo: oh | 01:10 |
liusheng | zhenguo: ok | 01:10 |
openstackgerrit | wanghao proposed openstack/mogan master: Refactor exception raise by using mogan exception https://review.openstack.org/475971 | 01:15 |
wanghao_ | moring | 01:18 |
wanghao_ | zhenguo: ping | 01:18 |
*** liujiong has joined #openstack-mogan | 01:18 | |
wanghao_ | zhenguo: I found some exception which is not defined in exception.py, so I added them in my patch: https://review.openstack.org/#/c/475971/1 | 01:18 |
zhenguo | wanghao_: maybe for them we can just raise wsme Client Error, hah | 01:21 |
wanghao_ | zhenguo: I'm not sure that's ok, you know, I find that we just catch the exception, but there is nowhere to raise them, so I think it's a bug too.... | 01:23 |
wanghao_ | zhenguo: even we raise a wsme client error in catch block, but the code can't got there since no place to raise some exception. | 01:26 |
zhenguo | wanghao_: yeah, in catch block we should not raise client error, but on client side, if there's something wrong like the parameter is not suitable, we can just raise wsme error | 01:27 |
wanghao_ | that could be | 01:28 |
wanghao_ | but I didn't delete those exception, because I'm not sure if they're useful, so I just defined them. | 01:31 |
wanghao_ | maybe we check them later. | 01:31 |
zhenguo | wanghao_: ok | 01:31 |
zhenguo | wanghao_: thansk for working on that | 01:32 |
wanghao_ | zhenguo: np, just find it when I refactor exception raise. | 01:32 |
zhenguo | wanghao_: hah | 01:32 |
zhenguo | liusheng: seems this https://review.openstack.org/#/c/475302/ should wait for the patch adding floating ip to server nics landed | 01:37 |
liusheng | zhenguo: which patch ? | 01:38 |
zhenguo | liusheng: this one https://review.openstack.org/#/c/475622/ | 01:39 |
zhenguo | liusheng: aha, just saw the TODO there | 01:39 |
liusheng | zhenguo: oh, this patch also update the tempest added in the previous patch | 01:40 |
liusheng | zhenguo: yes, the TODO will be done in 2ed patch. lol | 01:40 |
zhenguo | liusheng: lol. if so, it's okay | 01:40 |
*** fredli__ has quit IRC | 02:02 | |
openstackgerrit | Vu Cong Tuan proposed openstack/mogan master: Stop using deprecated 'message' attribute in Exception https://review.openstack.org/475627 | 02:02 |
openstackgerrit | wanghao proposed openstack/mogan-specs master: Manage existing nodes in Mogan https://review.openstack.org/459967 | 02:37 |
openstackgerrit | Merged openstack/mogan master: Update api docs to add missing parameters https://review.openstack.org/475755 | 02:42 |
zhenguo | liusheng: how's the placement POC going? | 02:47 |
liusheng | zhenguo: still doing some coding research :( | 02:48 |
zhenguo | liusheng: hah | 02:48 |
liusheng | zhenguo: do you have any suggestion ? | 02:49 |
zhenguo | liusheng: at first step, we can just create resource provider for each baremtetal node there | 02:49 |
zhenguo | liusheng: which will not affect our current scheuling | 02:49 |
liusheng | zhenguo: yes, I am trying to do this | 02:50 |
zhenguo | liusheng: ok, thanks | 02:50 |
zhenguo | liusheng: the flavor refactoring work will be done soon, then we can test | 02:50 |
liusheng | zhenguo: np :D, ok | 02:50 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Adds `resources` field for flavors. https://review.openstack.org/475626 | 03:42 |
shaohe_feng | zhenguo: hello, I'm coming back | 05:37 |
zhenguo | shaohe_feng: hah, waiting for your review... | 06:03 |
*** wanghao_ has quit IRC | 06:07 | |
openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 06:07 |
zhenguo | liusheng: hi, for the flavor resources, I don't plan to change our current scheduler to filter it, but wait for placement ready, then we will sent resources fitler directly to placement | 06:10 |
zhenguo | liusheng: so, the new flavor task is almost done with the resources patch landed | 06:10 |
liusheng | zhenguo: yes, that make sense | 06:11 |
zhenguo | liusheng: and after we migrate to placement, seems we lose the ability to filter az | 06:11 |
zhenguo | liusheng: as we don't have place to save az info in inventory | 06:11 |
liusheng | zhenguo: :( we will skip all the filters of currectly scheduler ? | 06:12 |
zhenguo | liusheng: but we can set a trait to the resource provider then filter based on that, and list az will list resource providers from placement | 06:12 |
zhenguo | liusheng: yes | 06:12 |
liusheng | zhenguo: ok, will try | 06:12 |
zhenguo | liusheng: only sent the fitlers to placement | 06:12 |
liusheng | zhenguo: may the availability zone filter will be added into placement | 06:13 |
zhenguo | liusheng: no | 06:13 |
zhenguo | liusheng: we just sent traits info to the placement to let it filter resource providers with that trait for us | 06:14 |
zhenguo | liusheng: it's more general | 06:14 |
zhenguo | liusheng: traits can be anyting | 06:14 |
liusheng | zhenguo: yes, I know that maybe a way, I mean may placement guys add some specific filter like az in placement | 06:15 |
zhenguo | liusheng: there's not a filter notion in placement | 06:15 |
zhenguo | liusheng: they just make some sql query from db, | 06:15 |
zhenguo | liusheng: so, it's more quickly | 06:15 |
liusheng | zhenguo: ...yes, I know that. hah | 06:16 |
zhenguo | liusheng: hah | 06:16 |
zhenguo | liusheng: and for aggregates, seems there are already some openstack CLI to help manage it | 06:17 |
zhenguo | liusheng: we may not need to do extra work for that, only some way to pass aggregate info from flavors | 06:18 |
liusheng | zhenguo: osc CLI of placement ? | 06:18 |
zhenguo | liusheng: yes | 06:18 |
liusheng | zhenguo: that seems is aggregate in Nova, not in placement | 06:20 |
zhenguo | liusheng: seems yes | 06:20 |
zhenguo | liusheng: just saw that from https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/resource-provider-traits.html | 06:20 |
zhenguo | liusheng: but I don't find the CLI like openstack resource-provider ... | 06:20 |
liusheng | zhenguo: just have a try by typing "openstack --debug aggregate list" | 06:21 |
zhenguo | liuisheng: yes, that's a host aggreate | 06:22 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 06:26 |
*** wanghao has joined #openstack-mogan | 06:36 | |
*** wanghao has quit IRC | 07:37 | |
*** wanghao has joined #openstack-mogan | 07:39 | |
openstackgerrit | wanghao proposed openstack/mogan master: Refactor exception raise by using mogan exception https://review.openstack.org/475971 | 08:01 |
*** zhuli has joined #openstack-mogan | 08:43 | |
zhuli | Hello | 08:43 |
zhenguo | zhuli: hi, welcome here :D | 08:46 |
*** wanghao has quit IRC | 08:53 | |
*** wanghao has joined #openstack-mogan | 08:54 | |
*** wanghao has quit IRC | 09:31 | |
* zhenguo away | 09:58 | |
*** liujiong has quit IRC | 10:16 | |
*** litao__ has quit IRC | 12:04 | |
*** litao__ has joined #openstack-mogan | 14:13 | |
*** harlowja has joined #openstack-mogan | 17:07 | |
*** openstackgerrit has quit IRC | 20:03 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!