*** wanghao_ has quit IRC | 00:44 | |
*** wanghao has joined #openstack-mogan | 00:44 | |
zhenguo | morning mogan! | 00:56 |
---|---|---|
wanghao | morning! | 01:05 |
*** XueFengLiu has joined #openstack-mogan | 01:07 | |
*** litao__ has joined #openstack-mogan | 01:27 | |
*** wanghao has quit IRC | 01:32 | |
Xinran | zhenguo, sorry, I just saw your message... I was not in company yestoday. | 02:11 |
Xinran | zhenguo, will abandon now :) | 02:12 |
zhenguo | Xinran: thanks! | 02:12 |
Xinran | zhenguo, np | 02:12 |
zhenguo | liusheng: seems we can't create server via osc after scheduler_hints patch landed | 02:16 |
liusheng | zhenguo: yes | 02:16 |
zhenguo | liusheng: please rebase you client patch | 02:17 |
liusheng | zhenguo: only can by api request | 02:17 |
liusheng | zhenguo: ok | 02:17 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 02:20 |
openstackgerrit | liusheng proposed openstack/python-moganclient master: Add support for scheduler hint https://review.openstack.org/463553 | 02:21 |
zhenguo | liusheng: seems we can't handle server group gracefully, e,g. if you just create one server with an affinity empty server group, you can't decide which affinity zone it placed, then following up server creating may just failed as there's not avaiallbe node | 02:27 |
liusheng | zhenguo: an affinity empty server group ?, if a server group is empty, scheduler need to select an affinity zone with enough available nodes | 02:31 |
zhenguo | liusheng: yes, if I just create one server, it will radomly choose an affinity zone right? | 02:31 |
liusheng | zhenguo: yes | 02:31 |
zhenguo | liusheng: maybe just choose one with only one availble node | 02:32 |
zhenguo | liusheng: it's also not smart | 02:32 |
liusheng | zhenguo: you mean choose the affinity zone including least nodes ? | 02:33 |
zhenguo | liusheng: we can't control | 02:34 |
liusheng | zhenguo: if so, we need to get tha total affinity_zone-nodes mapping at the begin of each scheduling like previous | 02:35 |
zhenguo | liusheng: although you mean get the best affinity zone, but you can't control others choose nodes from it | 02:36 |
zhenguo | s/mean/can | 02:36 |
liusheng | zhenguo: yes | 02:36 |
zhenguo | liusheng: nova also face the same problem | 02:36 |
liusheng | zhenguo: yes, the don't have the dedicated host concept | 02:37 |
zhenguo | liusheng: how about we just providing the same functinalites like nova | 02:37 |
zhenguo | liusheng: in Pike | 02:37 |
zhenguo | liusheng: and remove the current get avaialble nodes for multi creation logic | 02:38 |
liusheng | zhenguo: yes, I think so, we can improve if there is performance bottleneck or we have another good idea | 02:38 |
liusheng | zhenguo: why need to remove ? | 02:38 |
zhenguo | liusheng: it's too complex | 02:39 |
liusheng | zhenguo: not very complex, if you don't use multiple creation, the process is also very simple | 02:39 |
zhenguo | liusheng: maybe need others to review that codes | 02:40 |
liusheng | zhenguo: actually, at some places I think current way is similar with Nova | 02:40 |
liusheng | zhenguo: ok | 02:41 |
zhenguo | liusheng: please help to look at the socat console patch, you can test it with our bare metal env | 02:42 |
liusheng | zhenguo: ok | 02:42 |
zhenguo | liusheng: I changed the API partten | 02:42 |
liusheng | zhenguo: did you have tested sucessfully ? | 02:42 |
zhenguo | litao__: for shellinagox, yes | 02:42 |
liusheng | zhenguo: hah | 02:43 |
zhenguo | litao__: for socat console, I can connect it, but don't print it in the screen | 02:43 |
liusheng | zhenguo: you sent to litao, why ti cannot print | 02:43 |
zhenguo | oops | 02:43 |
zhenguo | liusheng: I don't know how, lol | 02:44 |
zhenguo | liusheng: need to use horizon | 02:44 |
liusheng | zhenguo: lol | 02:44 |
zhenguo | liusheng: I only know how to connect to a socket | 02:44 |
zhenguo | liusheng: not sure how to print it in the web | 02:44 |
liusheng | zhenguo: btw for your client address conversation patch, do you think we need to networ id in "server list" output ? | 02:44 |
zhenguo | liusheng: seems nova does | 02:45 |
zhenguo | liusheng: do you have a nova env? | 02:45 |
liusheng | zhenguo: yes, Nova use network name | 02:45 |
zhenguo | liusheng: oh maybe we can get network name on client side | 02:45 |
liusheng | zhenguo: if a server with many nics, it may look ugly if we print the network id :( | 02:45 |
zhenguo | liusheng: also for image and flavor | 02:45 |
zhenguo | liusheng: we can get the name | 02:46 |
liusheng | zhenguo: yes, that is a way | 02:46 |
zhenguo | liusheng: but if serve with many nics, you will pring the same ip address maybe | 02:46 |
liusheng | zhenguo: or maybe we get it in API side | 02:46 |
zhenguo | liusheng: if there's no network | 02:46 |
liusheng | zhenguo: yes | 02:46 |
zhenguo | liusheng: for API, uuid is enough | 02:47 |
zhenguo | liusheng: client and dashboard can with name | 02:47 |
zhenguo | liusheng: I find nova also transform flavor and image to name on client side | 02:47 |
liusheng | zhenguo: seems yes, so.. hah | 02:47 |
zhenguo | liusheng: we need to improve our client | 02:48 |
liusheng | zhenguo: for address, maybe you can do in your patch ? | 02:48 |
zhenguo | liusheng: yes | 02:48 |
liusheng | zhenguo: ok | 02:48 |
* zhenguo brb | 02:49 | |
zhenguo | litao__: please rebase the managing running servers patch when you got time | 03:24 |
zhenguo | Xinran: please remember to upload the server key_name patch | 03:24 |
litao__ | zhenguo: yes, I am rebasing , and update codes | 03:25 |
zhenguo | litao__: thanks :D | 03:25 |
zhenguo | liusheng: please help to improve the mogan client, for server group I will test it. | 03:26 |
*** wanghao has joined #openstack-mogan | 03:26 | |
liusheng | zhenguo: ok, besides the scheduler hints support patch, other functionalities are all supportted | 03:27 |
zhenguo | liusheng: I remember we discussed about the udpate/set returns | 03:28 |
zhenguo | liusheng: currently we don't print anything | 03:28 |
liusheng | zhenguo: oh, yes | 03:28 |
liusheng | zhenguo: let me check | 03:28 |
zhenguo | liusheng: you can help to compare with nova's osc one by one | 03:28 |
liusheng | zhenguo: ok | 03:28 |
zhenguo | liusheng: maybe we should land all API changes by today, to reserve some time for testing | 03:29 |
Xinran | zhenguo, ok, will update today | 03:31 |
zhenguo | Xinran: thanks | 03:31 |
zhenguo | Xinran: both key_name and attaching interface with port_id are changing the APIs, so we should land them soon | 03:31 |
Xinran | zhenguo, ok, sorry for the delay | 03:33 |
zhenguo | Xinran: np, hah | 03:34 |
liusheng | zhenguo: ok | 03:36 |
zhenguo | liusheng: I will go through our APIs to make sure there's no big issues with the format | 03:37 |
liusheng | zhenguo: ok, seems all the set/unset commands in OSC did print anything | 03:38 |
liusheng | zhenguo: I have tested server, flavor, aggregeate | 03:39 |
zhenguo | liusheng: you mean nova osc? | 03:39 |
liusheng | zhenguo: yes | 03:39 |
zhenguo | liusheng: if so, it's ok | 03:40 |
liusheng | zhenguo: ok | 03:40 |
zhenguo | liusheng: should we also format the server show on client? | 03:52 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 03:52 |
* zhenguo brb | 03:53 | |
liusheng | zhenguo: currently, it is jsut a raw dict, right ? | 03:54 |
liusheng | zhenguo: maybe it is better to format | 03:54 |
zhenguo | liusheng: yes | 04:46 |
openstackgerrit | Merged openstack/python-moganclient master: Add support for scheduler hint https://review.openstack.org/463553 | 04:59 |
*** wanghao_ has joined #openstack-mogan | 06:00 | |
*** wanghao has quit IRC | 06:04 | |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 06:19 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 06:27 |
zhenguo | liusheng: can you try to set html_static to _build/html/_static on our RTD? | 06:39 |
liusheng | zhenguo: o, let me try | 06:39 |
zhenguo | liusheng: I just run the command according to the builds log manually and find the dir | 06:39 |
openstackgerrit | Xinran WANG proposed openstack/mogan master: support specifying port_id when attaching interface https://review.openstack.org/494121 | 06:40 |
* zhenguo brb | 06:41 | |
liusheng | zhenguo: not sure if the dir is same in RTD | 06:41 |
zhenguo | liusheng: in fact, you can find that from the build log WARNING | 06:50 |
liusheng | zhenguo: copying static files... WARNING: html_static_path entry '/home/docs/checkouts/readthedocs.org/readthedocs/templates/sphinx/_static' does not exist | 06:51 |
zhenguo | liusheng: no wanring about the _build/html/_static dir? | 06:52 |
liusheng | zhenguo: WARNING: html_static_path entry '/home/docs/checkouts/readthedocs.org/readthedocs/templates/sphinx/_static' does not exist | 06:52 |
liusheng | zhenguo: above warning | 06:52 |
zhenguo | liusheng: only this one? | 06:52 |
zhenguo | liusheng: you can check the previous build log | 06:52 |
zhenguo | liusheng: the page is still same? | 06:53 |
liusheng | zhenguo: yes | 06:53 |
zhenguo | liusheng: can you share you priviate test project with me on RTD | 06:55 |
liusheng | zhenguo: ok | 06:56 |
liusheng | zhenguo: sure | 06:56 |
liusheng | zhenguo: done, the my-mogan-api-ref | 06:56 |
zhenguo | liusheng: thanks, seems they can find the specified dir | 06:59 |
liusheng | zhenguo: do you know is there any tool we can conect to the RDT to see the build dir ? | 07:00 |
zhenguo | liusheng: seems no | 07:01 |
liusheng | zhenguo: :( | 07:01 |
zhenguo | liusheng: you can find the log of warning from the previous build log | 07:01 |
zhenguo | liusheng: the can't find the specified dir before | 07:01 |
zhenguo | liusheng: two warning log | 07:01 |
liusheng | zhenguo: yes, it just see cannot find the dir we specified. but we don't know what's is it real static file dir | 07:02 |
zhenguo | liusheng: but from the new build log, you can just find one log warning about the readthedocs dir | 07:03 |
zhenguo | liusheng: which indicates our specified dir is correct | 07:03 |
zhenguo | liusheng: maybe I got the reason | 07:08 |
liusheng | zhenguo: what | 07:09 |
zhenguo | liusheng: because the files we needed not in css dir but just under _static directly | 07:09 |
zhenguo | liusheng: all files under css, images, js copied correctly | 07:10 |
liusheng | zhenguo: yes | 07:11 |
liusheng | zhenguo: in local env, it is under _static/ | 07:11 |
liusheng | zhenguo: oh, there is css/ dir | 07:12 |
zhenguo | liusheng: but according to the html it will just find the file in _static/api-site.css | 07:16 |
Xinran | zhenguo, I got error when stack my local env, baremetalcompute flavor create is not an openstack command | 07:35 |
zhenguo | Xinran: you need to update you python-moganclient | 07:35 |
Xinran | zhenguo, I have already update it | 07:36 |
zhenguo | Xinran: weird | 07:36 |
zhenguo | Xinran: maybe you can manually setup it | 07:36 |
Xinran | zhenguo, let me try :) | 07:36 |
zhenguo | Xinran: ok | 07:36 |
zhenguo | liusheng: maybe we can just move docs to RTD for now | 07:37 |
zhenguo | liusheng: and maybe changed to not using openstackdocs theme | 07:38 |
Xinran | zhenguo, still the same problem :( | 07:38 |
zhenguo | Xinran: oh | 07:38 |
liusheng | zhenguo: don't use openstackdoc theme it won't have the problem, right ? | 07:38 |
zhenguo | Xinran: after you update the repo and install it? | 07:38 |
zhenguo | liusheng: api-ref still have problems | 07:39 |
zhenguo | liusheng: docs we can just use readthecos theme | 07:39 |
Xinran | zhenguo, hah it works. I just update another branch of moganclient | 07:39 |
Xinran | zhenguo, thanks | 07:40 |
zhenguo | Xinran: hah, np | 07:40 |
liusheng | zhenguo: hmm, maybe, and we can try to solve the problem if have enough time, and don't need to update the url | 07:40 |
zhenguo | liusheng: yes | 07:41 |
zhenguo | liusheng: for now, we can move docs there, but api-ref also maintained manually | 07:41 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Temporarily remove openstackdocs theme https://review.openstack.org/498156 | 07:41 |
zhenguo | liusheng: can you try above patch for docs? | 07:41 |
liusheng | zhenguo: there is a sample, seems it can use the openstack theme: http://cloudkitty.readthedocs.io/en/latest/ | 07:42 |
liusheng | zhenguo: not sure why | 07:42 |
zhenguo | liusheng: we can also use openstacktheme for docs, now warnings and errors on the page | 07:44 |
liusheng | zhenguo: oh, our problem only existed in api-ref | 07:44 |
zhenguo | liusheng: yes, because os-api-ref extension | 07:44 |
zhenguo | liusheng: we can maintain that before we are official | 07:45 |
zhenguo | liusheng: maybe soon, hah | 07:45 |
liusheng | zhenguo: hah, yes | 07:46 |
zhenguo | liusheng: we don't need to waste time to figure out why it doesn't work | 07:46 |
liusheng | zhenguo: hah | 07:46 |
zhenguo | liusheng: but do you think it's better to not using openstackdocs theme before we are official? | 07:47 |
liusheng | zhenguo: http://my-mogan-api-ref.readthedocs.io/en/latest/ | 07:47 |
liusheng | zhenguo: maybe it is better to provide a public api doc | 07:47 |
liusheng | zhenguo: in case we need to show some times | 07:47 |
zhenguo | liusheng: do you find the theme is also ok although soem button is not work | 07:49 |
zhenguo | liusheng: but at lest the REST verb can show now | 07:49 |
liusheng | zhenguo: yes | 07:49 |
zhenguo | liusheng: ok, so let's change the theme | 07:50 |
liusheng | zhenguo: the detail button cannot work.. | 07:50 |
zhenguo | liusheng: it's ok | 07:50 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Temporarily remove openstackdocs theme https://review.openstack.org/498156 | 07:52 |
liusheng | zhenguo: and just found, if we host our doc in RTD, it can be search by google. lol | 07:53 |
zhenguo | liusheng: so we can land the above patch, and you need to rebase your patch to update the docs link | 07:53 |
zhenguo | liusheng: hah | 07:53 |
zhenguo | liusheng: does our doc links changed on RTD | 07:54 |
liusheng | zhenguo: ok | 07:54 |
liusheng | zhenguo: no, do yo prefer the subproject link or a saperated link for api-ref ? | 07:55 |
zhenguo | liusheng: both are ok | 07:55 |
liusheng | zhenguo: if subproject link is ok, I don't need to update this patch: https://review.openstack.org/#/c/493456 | 07:55 |
zhenguo | liusheng: ok | 07:57 |
zhenguo | liusheng: so let's just land them | 07:58 |
liusheng | zhenguo: ok | 07:59 |
zhenguo | liusheng: on my test, this is ok https://review.openstack.org/#/c/498652/ | 08:00 |
liusheng | zhenguo: ok, I am testing | 08:01 |
liusheng | zhenguo: don't format in "server show" ? | 08:03 |
zhenguo | liusheng: not sure format to what, also like that? | 08:03 |
zhenguo | liusheng: but maybe we need another patch to format all server stuff like image uuid to name and flavor uuid to name | 08:04 |
liusheng | zhenguo: seems for Nova vm, the OSC server show is same with "server list" | 08:04 |
liusheng | zhenguo: ok | 08:04 |
zhenguo | liusheng: oh, if so, I can format the server show as well | 08:05 |
liusheng | zhenguo: ok | 08:05 |
zhenguo | liusheng: maybe you can help to format the image and flavor | 08:05 |
liusheng | zhenguo: sure | 08:05 |
zhenguo | liusheng: thanks | 08:05 |
liusheng | zhenguo: np :D | 08:06 |
zhenguo | liusheng: for socat console, maybe you can just test the shellinabox part, as the api is same, we also need to add change the client | 08:06 |
zhenguo | wanghao: do you have time to write the client code for listing manageable servers? | 08:06 |
zhenguo | liusheng, Xinran: seems luyao helped to update the attaching/detaching interface client patch | 08:07 |
zhenguo | wanghao_^^ | 08:07 |
liusheng | zhenguo: ok, will review | 08:08 |
zhenguo | shaohe_feng: if you are around, please have a look at the two up patches which already got +2 | 08:08 |
*** Xinran has quit IRC | 08:08 | |
*** Xinran has joined #openstack-mogan | 08:15 | |
*** shaohe_feng has quit IRC | 08:16 | |
*** shaohe_feng has joined #openstack-mogan | 08:19 | |
liusheng | zhenguo: seems the luyao's patch have some issues, and may need the patch https://review.openstack.org/#/c/494121/ landed firstly, if luyao don't have time I can help to update the patch later | 08:19 |
zhenguo | liusheng: ok, thanks | 08:20 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 08:41 |
* zhenguo brb | 08:45 | |
openstackgerrit | Merged openstack/python-moganclient master: Format server addresses https://review.openstack.org/498652 | 08:55 |
zhenguo | litao__: how's the managing running server's patch? | 09:00 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add socat console support https://review.openstack.org/493836 | 09:07 |
zhenguo | liusheng: do we have a default affinity zone for servers not in any? | 09:10 |
liusheng | zhenguo: no | 09:10 |
zhenguo | liusheng: do we need that? | 09:10 |
liusheng | zhenguo: maybe don't, if need, the default affinity zone including all nodes ? | 09:11 |
zhenguo | liusheng: no, just for nodes not in any affinity zone | 09:11 |
zhenguo | liusheng: seems not easy to control ha | 09:12 |
liusheng | zhenguo: but if we don't set any affinity zone, it will include all the node, right ? and if we add a node to a affinity zone, we need to remove it from the default one firstly | 09:12 |
liusheng | zhenguo: hah, yes | 09:13 |
zhenguo | liusheng: will we support to specify same-affinity-zone or different-affinity-zone with a existing server id in scheduler hints when claiming a server? | 09:14 |
liusheng | zhenguo: is that different with affinity and anti-affinity ? | 09:15 |
zhenguo | liusheng: that doens't need a server group | 09:15 |
liusheng | zhenguo: oh, seems like server creating with host specified in Nova. hah | 09:16 |
zhenguo | liusheng: yes | 09:16 |
zhenguo | liusheng: seems that's useful | 09:16 |
zhenguo | liusheng: we don't always use server group | 09:16 |
liusheng | zhenguo: maybe we can consider in the future | 09:16 |
liusheng | zhenguo: yes | 09:17 |
zhenguo | liusheng: if we have time left, we can do it, seems not complex | 09:17 |
zhenguo | liusheng: we can check whether the specified server with an affinity zone, if not we just deny it | 09:17 |
liusheng | zhenguo: and do you think should we expose affinity APIs? or provide a api to show the relationship mapping with affinity zone and nodes | 09:17 |
zhenguo | liusheng: seems they can use aggregate to show | 09:18 |
zhenguo | liusheng: if we provide list aggregate by metadata key or just for affinity zone and availability zone | 09:19 |
liusheng | zhenguo: seems it is not very convenient | 09:19 |
liusheng | zhenguo: yes, I mean that | 09:19 |
wanghao_ | zhenguo: I think I can do it, but maybe until next week. | 09:19 |
liusheng | zhenguo: like availability zone | 09:19 |
zhenguo | wanghao_: hah, if so we can help :D | 09:19 |
zhenguo | liusheng: can we list which nodes in availability zone? | 09:19 |
zhenguo | wanghao_: we plan to cut release this week | 09:20 |
liusheng | zhenguo: no, that is what I think we should to improve | 09:20 |
zhenguo | liusheng: maybe admins need that info | 09:20 |
liusheng | zhenguo: I think it is help to admins | 09:20 |
liusheng | zhenguo: hah, yes | 09:20 |
zhenguo | liusheng: I will review the server group patch again, lol | 09:22 |
liusheng | zhenguo: hah, thanks | 09:22 |
zhenguo | liusheng: hah | 09:22 |
*** wanghao_ has quit IRC | 09:23 | |
*** wanghao has joined #openstack-mogan | 09:24 | |
openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 09:24 |
*** wanghao has quit IRC | 09:28 | |
zhenguo | liusheng: some comments inline | 09:32 |
liusheng | zhenguo: ok | 09:33 |
openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 09:35 |
liusheng | zhenguo: thanks, replied inline, and will update the patch | 09:38 |
zhenguo | liusheng: ok, thanks! | 09:38 |
zhenguo | liusheng: Pike will be formally released tomorrow before 1500utc | 09:48 |
liusheng | zhenguo: so urgent! | 09:49 |
zhenguo | liusheng: it's just for official, right? | 09:50 |
liusheng | zhenguo: not sure :( | 09:50 |
zhenguo | liusheng: for us, we just create a branch | 09:50 |
liusheng | zhenguo: yes, it is | 09:50 |
openstackgerrit | Xinran WANG proposed openstack/mogan master: support specifying port_id when attaching interface https://review.openstack.org/494121 | 09:51 |
* zhenguo brb | 10:18 | |
openstackgerrit | liusheng proposed openstack/mogan master: Use server group in scheduler https://review.openstack.org/496151 | 10:18 |
openstackgerrit | Merged openstack/mogan master: Present Mogan docs on readthedocs https://review.openstack.org/493456 | 10:57 |
openstackgerrit | Merged openstack/mogan master: Temporarily remove openstackdocs theme https://review.openstack.org/498156 | 11:17 |
zhenguo | liusheng: seems we need to make a new build for docs on RTD | 11:19 |
liusheng | zhenguo: why ? | 11:19 |
zhenguo | liusheng: it can not automatically trigger the rebuild with new commits | 11:19 |
liusheng | zhenguo: oh, that need to click the button | 11:20 |
zhenguo | liusheng: ok, I will try | 11:20 |
liusheng | zhenguo: but according to the RDT docs, it should be able to config a httphook | 11:20 |
zhenguo | liusheng: seems we are not the owner of our repo, hah | 11:21 |
liusheng | zhenguo: hah, yes, it is belong to openstack | 11:22 |
zhenguo | liusheng: hah | 11:22 |
liusheng | zhenguo: does that matter ? | 11:22 |
zhenguo | liusheng: not sure if we can add the hook | 11:22 |
liusheng | zhenguo: let me try | 11:22 |
zhenguo | liusheng: ok, thanks | 11:22 |
openstackgerrit | liusheng proposed openstack/mogan master: Use server group in scheduler https://review.openstack.org/496151 | 11:22 |
zhenguo | liusheng: oh, build failed | 11:24 |
zhenguo | liusheng: we use this http://mogan-api-ref.readthedocs.io/en/latest/ for api now | 11:44 |
zhenguo | liusheng: seems as I removed api-ref as a subproject of mogan on RTD | 11:44 |
liusheng | zhenguo: so need to add the subproject ? or update the link ? | 11:46 |
zhenguo | liusheng: you can add the subproject | 11:46 |
liusheng | zhenguo: ok | 11:46 |
zhenguo | liusheng: I don't know why mogan docs build failed | 11:46 |
liusheng | zhenguo: any hint ? | 11:46 |
zhenguo | liusheng: you can see the build logs | 11:47 |
openstackgerrit | Xinran WANG proposed openstack/mogan master: support specifying port_id when attaching interface https://review.openstack.org/494121 | 11:49 |
liusheng | zhenguo: werid, it is ok previously | 11:50 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Change to use new console URI https://review.openstack.org/498775 | 11:50 |
zhenguo | liusheng: yes | 11:50 |
liusheng | zhenguo: seems need to install the missed packages, but it is ok previously... | 11:55 |
zhenguo | liusheng: you can try on you private repo with my change to comment the oenstackdocs theme | 11:56 |
zhenguo | liusheng: not sure if it's related to that | 11:56 |
zhenguo | Xinran: I mean you can specify port_id when claiming a server | 11:58 |
zhenguo | Xinran: just like what you are doing for attaching interface | 11:59 |
*** litao__ has quit IRC | 11:59 | |
Xinran | zhenguo, oh... | 12:00 |
Xinran | zhenguo, create server with port_id in place of network ? | 12:00 |
zhenguo | Xinran: yes, we also support that | 12:01 |
zhenguo | Xinran: we already supported | 12:01 |
Xinran | zhenguo, ah.. didn't find it in code | 12:02 |
zhenguo | Xinran: http://mogan-api-ref.readthedocs.io/en/latest/v1/index.html#request | 12:03 |
zhenguo | Xinran: you mean the schema will check port_id and net_id not specified at the same time? | 12:07 |
Xinran | zhenguo, ok I see, in create_server.py | 12:07 |
zhenguo | Xinran: yes | 12:08 |
Xinran | zhenguo, I mean the schma will check if our in put is one of port_id and net_id | 12:08 |
Xinran | zhenguo, I will add another patch to fix this | 12:08 |
zhenguo | Xinran: ok, thanks | 12:09 |
zhenguo | Xinran: have you tested with the schema when specified both? | 12:09 |
zhenguo | Xinran: seems the OneOf there just for required fields | 12:10 |
Xinran | zhenguo, yes I have tested. | 12:10 |
zhenguo | Xinran: oh, if so it's ok | 12:10 |
Xinran | zhenguo, it will cause error | 12:10 |
liusheng | zhenguo: seems another problem occured if I uncomment the http theme option | 12:10 |
liusheng | zhenguo: sigh :( | 12:10 |
zhenguo | liusheng: :( | 12:11 |
zhenguo | Xinran: got it | 12:11 |
liusheng | zhenguo: https://readthedocs.org/projects/my-mogan-api-ref/builds/5898843/ | 12:11 |
zhenguo | liusheng: maybe just rebase my patch? | 12:12 |
liusheng | zhenguo: which one ? | 12:13 |
zhenguo | liusheng: openstackdocs theme | 12:13 |
liusheng | zhenguo: I have forked the latest code of mogan, and uncomment the line | 12:13 |
zhenguo | liusheng: oh, sorry, I mean revert | 12:14 |
liusheng | zhenguo: it is equal revert :( | 12:14 |
zhenguo | liusheng: uncomment also cause problems? | 12:14 |
liusheng | zhenguo: another problem | 12:15 |
liusheng | zhenguo: ^^^ | 12:15 |
liusheng | zhenguo: https://readthedocs.org/projects/my-mogan-api-ref/builds/5898843/ | 12:15 |
zhenguo | liusheng: if so, our gate should be broken? | 12:16 |
liusheng | zhenguo: no, seems only RTD cannot build | 12:16 |
zhenguo | liusheng: oh | 12:17 |
*** XueFengLiu has quit IRC | 16:16 | |
*** XueFengLiu has joined #openstack-mogan | 16:19 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!