| *** wanghao has quit IRC | 00:54 | |
| *** wanghao has joined #openstack-mogan | 00:55 | |
| zhenguo | morning mogan! | 01:05 |
|---|---|---|
| zhenguo | liusheng: can we format the server node with name and uuid as well? | 01:11 |
| zhenguo | liusheng: as we only support list node name | 01:11 |
| zhenguo | liusheng: admin have to go to ironic to see the uuid and name relationship | 01:12 |
| liusheng | zhenguo: if so we need to call ironic | 01:12 |
| zhenguo | liusheng: can we? | 01:12 |
| liusheng | zhenguo: and not sure if Ironic support duplicated name | 01:12 |
| zhenguo | liusheng: no | 01:12 |
| zhenguo | liusheng: we also use name in RP | 01:13 |
| zhenguo | liusheng: it can't be duplicated | 01:13 |
| liusheng | zhenguo: maybe it is better to support that in server side ? wdyt ? | 01:13 |
| zhenguo | liusheng: you mean return the node name instead of uuid? | 01:13 |
| liusheng | zhenguo: because usually, the API return is more exact and client side transform it to human readable | 01:14 |
| zhenguo | liusheng: yes | 01:15 |
| zhenguo | liusheng: we can change to use node name instead | 01:15 |
| liusheng | zhenguo: use node name in where ? | 01:17 |
| zhenguo | liusheng: API | 01:17 |
| liusheng | zhenguo: I mean maybe we can return node uuid in API, or both node name and node uuid | 01:17 |
| zhenguo | liusheng: which should be consistent with our node list output | 01:17 |
| zhenguo | liusheng: we just return the node uuid now | 01:18 |
| zhenguo | liusheng: on client side, seems you can't call ironic to get the name if you are not admin | 01:19 |
| liusheng | zhenguo: I found we only return node name | 01:19 |
| zhenguo | liusheng: I mean server show | 01:19 |
| liusheng | zhenguo: oh, sorry :( | 01:20 |
| zhenguo | liusheng: server show should be consistent with node list | 01:20 |
| liusheng | zhenguo: hmmm, seems yes | 01:20 |
| zhenguo | liusheng: and aggregate node list | 01:20 |
| zhenguo | liusheng: I will make a change to replace it with name on API side | 01:21 |
| zhenguo | liusheng: seems need to change the scheduler return | 01:21 |
| liusheng | zhenguo: I am afraid if it is a choice if we always use node name than node uuid, since may we will support other drivers, we need to ensure the node name is unique in other drivers | 01:22 |
| zhenguo | liusheng: that's a limitation of placement | 01:23 |
| zhenguo | liusheng: the rp name is unique | 01:23 |
| liusheng | zhenguo: and need to sure it can support get a node with node name directly | 01:23 |
| zhenguo | liusheng: so if other driver's name is not unique they should make it unique | 01:23 |
| liusheng | zhenguo: GET /xxx/node-name | 01:23 |
| zhenguo | liusheng: ironic support that | 01:23 |
| liusheng | zhenguo: I mean we need ensure other drivers suppport that | 01:24 |
| zhenguo | liusheng: why | 01:24 |
| liusheng | zhenguo: it is convenient to get a node info, if we always use node name than node uuid | 01:24 |
| zhenguo | liusheng: in fact, we don't use node name but the RP's name | 01:25 |
| zhenguo | liusheng: driver can decide uuid or name for the RP name | 01:25 |
| liusheng | zhenguo: oh, yes | 01:25 |
| zhenguo | liusheng: RP name is always unique | 01:25 |
| zhenguo | liusheng: they can use uuid for Rp name | 01:26 |
| liusheng | zhenguo: make sense | 01:28 |
| openstackgerrit | Merged openstack/python-moganclient master: Format the output for server object https://review.openstack.org/500511 | 01:51 |
| zhenguo | liusheng: can you please help to review the up patches? we can't move along without your reviews :P | 03:13 |
| liusheng | zhenguo: ok, reviewing | 03:15 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Return node(name or uuid) with server instead of node_uuid https://review.openstack.org/500664 | 03:37 |
| openstackgerrit | Xinran WANG proposed openstack/mogan master: Use attach_interface during the server creation https://review.openstack.org/500668 | 04:00 |
| Xinran | zhenguo, pls review this patch if you got time, sorry for the delay. I wasn't in beijing these days. https://review.openstack.org/500668 | 04:01 |
| openstackgerrit | Merged openstack/mogan master: Rollback to the original status when server powering action failed https://review.openstack.org/476862 | 04:42 |
| zhenguo | Xinran: thanks | 04:44 |
| *** wanghao has quit IRC | 05:50 | |
| *** wanghao has joined #openstack-mogan | 05:51 | |
| *** wanghao_ has joined #openstack-mogan | 06:07 | |
| *** wanghao has quit IRC | 06:10 | |
| zhenguo | liusheng: I just deleted you mogan project on RTD | 06:13 |
| liusheng | zhenguo: ok, you need a new project ? | 06:14 |
| zhenguo | liusheng: I tried to use another name with my own repo, it built successfully | 06:14 |
| liusheng | zhenguo: ok, feel free to test | 06:15 |
| zhenguo | liusheng: seems we don't have permissions to add webhook to openstack/mogan | 06:18 |
| liusheng | zhenguo: seems yes, I have tried, but don't know how to add | 06:18 |
| zhenguo | liusheng: I got a warning that there's no permissions | 06:19 |
| zhenguo | liusheng: in fact, it will automatically added | 06:19 |
| zhenguo | liusheng: you can check you own repo's settings/webhook | 06:19 |
| liusheng | zhenguo: I found that, but it cannot work | 06:20 |
| zhenguo | liusheng: http://mogan.readthedocs.io/en/latest/ | 06:25 |
| *** litao__ has joined #openstack-mogan | 06:26 | |
| liusheng | zhenguo: this looks good | 06:26 |
| zhenguo | liusheng: hah | 06:26 |
| liusheng | zhenguo: what changes you made ? | 06:26 |
| zhenguo | liusheng: just changed to my repo | 06:26 |
| liusheng | zhenguo: ... :D | 06:27 |
| zhenguo | liusheng: deleted yours and create a new one named mogan | 06:27 |
| liusheng | zhenguo: strange | 06:27 |
| *** wanghao has joined #openstack-mogan | 06:41 | |
| *** wanghao_ has quit IRC | 06:42 | |
| liusheng | zhenguo: don't need to save the partition info into db ? | 06:52 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Return node(name or uuid) with server instead of node_uuid https://review.openstack.org/500664 | 06:54 |
| zhenguo | liusheng: not sure | 06:54 |
| zhenguo | liusheng: do you think we need to save that information | 06:54 |
| liusheng | zhenguo: maybe user want to know, such as before rebuilding a server | 06:54 |
| liusheng | zhenguo: also not sure, hah | 06:54 |
| zhenguo | liusheng: seems it's useful, | 06:55 |
| zhenguo | liusheng: which format do you like? | 06:55 |
| liusheng | zhenguo: or maybe only visable by admins | 06:55 |
| zhenguo | liusheng: seems we should expose that to users, as it just set by them | 06:55 |
| liusheng | zhenguo: seems the input format is good | 06:55 |
| zhenguo | liusheng: hah | 06:56 |
| liusheng | zhenguo: yes | 06:56 |
| zhenguo | liusheng: we may support more advanced partitions when ironic side is done | 06:56 |
| zhenguo | liusheng: like LVM | 06:56 |
| liusheng | zhenguo: ok, sounds good | 06:57 |
| zhenguo | liusheng: seems nova will same root_gb, ephemeral_gb, and swap_mb separatedly | 06:57 |
| liusheng | zhenguo: same/save ? | 06:58 |
| zhenguo | liusheng: oh, save | 06:58 |
| liusheng | zhenguo: hah, I think the benifit for separated saving is for the usage of retriving, like filter query | 07:00 |
| liusheng | zhenguo: but seems don't need have this requirement | 07:00 |
| zhenguo | liusheng: yes | 07:00 |
| zhenguo | liusheng: seems we don't need that | 07:00 |
| zhenguo | liusheng: and also find ironic support to pass some root disk hints | 07:00 |
| zhenguo | liusheng: to choose which disk to be used as root | 07:00 |
| liusheng | zhenguo: nova don't support that ? | 07:01 |
| liusheng | zhenguo: I mean Nova + Ironic | 07:01 |
| zhenguo | liusheng: seems they can | 07:01 |
| zhenguo | liusheng: but actually, they don't know what disk they can choose, lol | 07:01 |
| liusheng | zhenguo: oh, we can implement that later maybe in Q | 07:01 |
| liusheng | zhenguo: lol | 07:01 |
| zhenguo | liusheng: I plan to pass something like (> root+ephemeral+swap) | 07:02 |
| zhenguo | liusheng: they can support such hints | 07:02 |
| zhenguo | liusheng: will add on driver side | 07:02 |
| zhenguo | liusheng: maybe a following up patch | 07:02 |
| liusheng | zhenguo: ok, sounds like useful features | 07:03 |
| liusheng | zhenguo: so you prefer to merge your partition patch before releasing and improve later, or add support to save the partition info ? | 07:05 |
| zhenguo | liusheng: before | 07:07 |
| zhenguo | liusheng: prior | 07:07 |
| liusheng | zhenguo: ok, hah | 07:07 |
| zhenguo | liusheng: it's almost good, need to wait infra guys to land the project config parth | 07:08 |
| zhenguo | *patch | 07:08 |
| liusheng | zhenguo: otherwise, it cannot pass gate ? | 07:08 |
| zhenguo | liusheng: yes | 07:08 |
| zhenguo | liusheng: as the default tempest partition image doesn't contain grub2 | 07:08 |
| liusheng | zhenguo: oh, may need to ping some infra guys if this is urgent | 07:09 |
| zhenguo | liusheng: seems some one is coming | 07:10 |
| liusheng | zhenguo: hah, cool | 07:10 |
| zhenguo | liusheng: you can also leave a +1 there | 07:11 |
| liusheng | zhenguo: I have given | 07:11 |
| zhenguo | liusheng: oh, it seems lost after I updated the patch | 07:12 |
| liusheng | zhenguo: oh, yes, given again | 07:13 |
| zhenguo | liusheng: http://mogan.readthedocs.io/projects/api-ref/en/latest/v1/index.html | 07:13 |
| zhenguo | liusheng: hah I managed to make it work | 07:13 |
| liusheng | zhenguo: cooool! | 07:13 |
| zhenguo | liusheng: hah | 07:13 |
| liusheng | zhenguo: how to make it work ? | 07:13 |
| zhenguo | liusheng: created a _static manually | 07:13 |
| zhenguo | liusheng: but the change is on my private repo | 07:14 |
| liusheng | zhenguo: oh, maybe we can merge it now, once we are official project, we can get rid of that | 07:14 |
| zhenguo | liusheng: I can't make openstack/mogan work | 07:14 |
| zhenguo | liusheng: only build with my own repo successfuly for docs | 07:15 |
| liusheng | zhenguo: it is strange, same code | 07:15 |
| zhenguo | liusheng: yes | 07:15 |
| zhenguo | liusheng: but it's ok, I can upadte if needed, as the webhook is also not work for openstack/mogan | 07:15 |
| liusheng | zhenguo: yes, that is a way | 07:16 |
| liusheng | zhenguo: how if we specified the partitions size as 0 ? | 07:17 |
| zhenguo | liusheng: I will check it with the image size or min_size first | 07:19 |
| zhenguo | liusheng: for partiton images | 07:19 |
| liusheng | zhenguo: ok | 07:20 |
| zhenguo | liusheng: for whole disk image, we don't support to specify partitions | 07:20 |
| zhenguo | liusheng: ironic will check as well | 07:20 |
| liusheng | zhenguo: ok | 07:21 |
| zhenguo | liusheng: please have a look at this https://review.openstack.org/#/c/500452/ as well | 07:29 |
| liusheng | zhenguo: ok, sure | 07:29 |
| *** wanghao has quit IRC | 07:57 | |
| *** wanghao has joined #openstack-mogan | 07:57 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add root disk partitions support https://review.openstack.org/499039 | 09:00 |
| zhenguo | liusheng: hi, do you like to keep the RTD theme for moganclient or chanage it to openstackdoctheme | 09:04 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add preserve_ephemeral support for rebuilding https://review.openstack.org/500452 | 09:08 |
| liusheng | zhenguo: if it can work with openstackdoctheme in RTD, may 2ed choice is better | 09:24 |
| liusheng | zhenguo: what do you think ? | 09:24 |
| zhenguo | liusheng: yes | 09:27 |
| zhenguo | liusheng: you can make the change | 09:28 |
| zhenguo | liusheng: and remember to add docs | 09:28 |
| liusheng | zhenguo: let me try | 09:28 |
| liusheng | zhenguo: yes, I am working on | 09:28 |
| zhenguo | liusheng: thanks | 09:28 |
| liusheng | zhenguo: np :D | 09:28 |
| *** wanghao has quit IRC | 09:29 | |
| *** wanghao has joined #openstack-mogan | 09:29 | |
| *** wanghao has quit IRC | 09:29 | |
| *** wanghao has joined #openstack-mogan | 09:30 | |
| *** wanghao has quit IRC | 09:30 | |
| *** wanghao has joined #openstack-mogan | 09:31 | |
| *** wanghao has quit IRC | 09:31 | |
| *** wanghao has joined #openstack-mogan | 09:31 | |
| *** wanghao has quit IRC | 09:32 | |
| *** wanghao has joined #openstack-mogan | 09:32 | |
| *** wanghao has quit IRC | 09:33 | |
| *** wanghao has joined #openstack-mogan | 09:33 | |
| *** wanghao has quit IRC | 09:33 | |
| *** wanghao has joined #openstack-mogan | 09:34 | |
| *** wanghao has quit IRC | 09:34 | |
| *** wanghao has joined #openstack-mogan | 09:35 | |
| openstackgerrit | Xinran WANG proposed openstack/mogan master: Update port['device_id'] when creating server https://review.openstack.org/500668 | 10:02 |
| zhenguo | liusheng: and this https://review.openstack.org/#/c/498775/ | 10:59 |
| liusheng | zhenguo: ok | 11:01 |
| *** litao__ has quit IRC | 12:13 | |
| *** shaohe_feng has quit IRC | 13:06 | |
| *** shaohe_feng has joined #openstack-mogan | 13:14 | |
| *** shaohe_feng has quit IRC | 13:33 | |
| *** shaohe_feng has joined #openstack-mogan | 13:33 | |
| openstackgerrit | Merged openstack/mogan master: [DOC] Add states and transitons diagram https://review.openstack.org/471293 | 14:22 |
| openstackgerrit | Merged openstack/mogan master: Add root disk partitions docs https://review.openstack.org/500316 | 14:23 |
| openstackgerrit | Merged openstack/mogan master: Return node(name or uuid) with server instead of node_uuid https://review.openstack.org/500664 | 15:01 |
| openstackgerrit | Yaguo Zhou proposed openstack/mogan master: Replace DbMigrationError with DBMigrationError https://review.openstack.org/500870 | 15:04 |
| *** lin_yang has joined #openstack-mogan | 15:18 | |
| *** harlowja has joined #openstack-mogan | 17:08 | |
| *** lin_yang has quit IRC | 19:01 | |
| *** harlowja has quit IRC | 21:13 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!