| zhenguo | morning mogan! | 01:01 |
|---|---|---|
| zhenguo | shaohe_feng: please have a look at this https://review.openstack.org/#/c/501597/ when you are online | 01:03 |
| *** harlowja has quit IRC | 01:11 | |
| liusheng | morning | 01:19 |
| *** litao__ has joined #openstack-mogan | 01:21 | |
| openstackgerrit | Merged openstack/python-moganclient master: Updated from global requirements https://review.openstack.org/501358 | 01:22 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Update port['device_id'] when creating server https://review.openstack.org/500668 | 01:24 |
| zhenguo | Xinran, liusheng: I just updated this https://review.openstack.org/#/c/500668/ to make it only add port availability check and bind port then, will add a separated patch to handle the port deletion which will also consider port detach. | 01:27 |
| liusheng | zhenguo: ok, will check later | 01:28 |
| zhenguo | liusheng: ok, thanks | 01:28 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Update port['device_id'] when creating server https://review.openstack.org/500668 | 01:30 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 01:59 |
| Xinran | zhenguo, just left some comments on this patch | 02:04 |
| zhenguo | Xinran: ok | 02:04 |
| wanghao_ | morning | 02:07 |
| zhenguo | Xinran, liusheng: seem my replies | 02:07 |
| zhenguo | wanghao_: o/ | 02:07 |
| wanghao_ | haha | 02:09 |
| liusheng | zhenguo: how about catching the exception ? | 02:09 |
| zhenguo | liusheng: how | 02:10 |
| liusheng | zhenguo: when exception occured in plug_vif, save the nic and reraise the exception ? | 02:11 |
| zhenguo | liusheng: it's that better to set mac_address later? | 02:11 |
| zhenguo | liusheng: I don't think so, that seems redundant | 02:11 |
| liusheng | zhenguo: oh, it is just save in object, not in db | 02:13 |
| zhenguo | liusheng: yes it's just in object | 02:13 |
| zhenguo | liusheng: and the plug_vif may failed sometimes | 02:13 |
| zhenguo | liusheng: I remember the current implementation is your proposal | 02:14 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 02:14 |
| liusheng | zhenguo: lol | 02:14 |
| liusheng | zhenguo: apologize, you are right | 02:15 |
| zhenguo | liusheng: hah | 02:15 |
| openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 02:30 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 02:41 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Clean the duplicated formatter method definitions https://review.openstack.org/501931 | 03:05 |
| liusheng | zhenguo: hi, in Ironic, is enrolling node an admin only api ? will it set the user and project to the node ? | 03:30 |
| zhenguo | liusheng: seems not | 03:31 |
| liusheng | zhenguo: not admin only api ? | 03:31 |
| zhenguo | liusheng: no, not project and user with the node | 03:32 |
| liusheng | zhenguo: oh, just found when we managing a existing server, as the API is admin api, the server will only belong to admin | 03:32 |
| zhenguo | liusheng: oh, seems yes | 03:35 |
| liusheng | zhenguo: any thoughts ? | 03:35 |
| zhenguo | liusheng: how cinder handle that? | 03:36 |
| zhenguo | liusheng: they can specify project_id when adopting? | 03:36 |
| liusheng | zhenguo: now sure, is wanghao here ? | 03:36 |
| liusheng | zhenguo: let me ask | 03:36 |
| liusheng | zhenguo: cinder can transfer a volume to others :( | 03:37 |
| zhenguo | liusheng: after managed? | 03:38 |
| zhenguo | liusheng: or at the same time | 03:38 |
| liusheng | zhenguo: a saperated interface | 03:38 |
| zhenguo | liusheng: oh | 03:39 |
| zhenguo | liusheng: seems we need to do that in next cycle | 03:39 |
| liusheng | zhenguo: yes, it's better. or we need to support specifying user/project when managing | 03:40 |
| zhenguo | liusheng: not sure there's side effect | 03:41 |
| * zhenguo brb | 03:41 | |
| liusheng | zhenguo: imagine this: I have a env of Mogan, but some day I want to manage a set of other servers to this env, certainly I want to use these servers by myself, but I only belong to the administrators | 03:42 |
| *** shaohe_feng has quit IRC | 03:46 | |
| *** shaohe_feng has joined #openstack-mogan | 03:47 | |
| zhenguo | liusheng: we need to find why cinder don't manage with specified project_id | 03:50 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add preserve_on_delete to server nic object https://review.openstack.org/501940 | 03:54 |
| *** wanghao has joined #openstack-mogan | 04:25 | |
| *** wanghao_ has quit IRC | 04:27 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add preserve_on_delete to server nic object https://review.openstack.org/501940 | 05:07 |
| openstackgerrit | Merged openstack/mogan-specs master: Fix the typo and replace http with https for doc links https://review.openstack.org/501547 | 05:24 |
| *** Kevin_Zheng has quit IRC | 05:33 | |
| litao__ | zhenguo: ,liusheng : https://review.openstack.org/#/c/481544/ pls | 05:41 |
| *** dims has quit IRC | 05:54 | |
| zhenguo | litao__: ok | 06:03 |
| liusheng | litao__: I have left some comments | 06:04 |
| liusheng | litao__: zhenguo can review again. lol | 06:04 |
| zhenguo | litao__, liusheng: left some nits inline as well. | 06:11 |
| liusheng | zhenguo: need to cut release today ? | 06:15 |
| zhenguo | liusheng: can we? | 06:15 |
| liusheng | zhenguo: if you plan to do, we can take over the patches have small problem to land them today | 06:16 |
| liusheng | zhenguo: seems others may be busy in other things | 06:16 |
| zhenguo | liusheng: yes, after that, I'd like to go through the API and CLI again. | 06:16 |
| zhenguo | liusheng: just in case | 06:17 |
| liusheng | zhenguo: I can help the client patches if needed | 06:17 |
| zhenguo | liusheng: thanks | 06:17 |
| liusheng | zhenguo: np :D | 06:18 |
| *** harlowja has joined #openstack-mogan | 06:19 | |
| openstackgerrit | Merged openstack/python-moganclient master: Correct the network parameter when creating server https://review.openstack.org/501658 | 06:25 |
| openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 06:29 |
| liusheng | zhenguo: https://review.openstack.org/#/c/501634 | 06:32 |
| liusheng | zhenguo: please seem my comments | 06:32 |
| zhenguo | liusheng: I also planed to used that | 06:33 |
| zhenguo | liusheng: but found you can specify multi --nic | 06:33 |
| zhenguo | liusheng: then got a list | 06:33 |
| liusheng | zhenguo: oh, seems a problem, let me check if there is other proper action | 06:34 |
| zhenguo | liusheng: ok | 06:34 |
| liusheng | zhenguo: MultiKeyValueCommaAction this ? | 06:34 |
| liusheng | zhenguo: let me try | 06:34 |
| zhenguo | liusheng: ok, and please feel free to update that patch :P | 06:35 |
| *** harlowja has quit IRC | 06:40 | |
| *** dims has joined #openstack-mogan | 06:51 | |
| openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 06:56 |
| *** wanghao has quit IRC | 07:00 | |
| zhenguo | liusheng: I find a bug of the addresses show on client | 07:05 |
| liusheng | zhenguo: what ? | 07:06 |
| zhenguo | liusheng: seems when there are multi addresses, it only show one | 07:06 |
| liusheng | zhenguo: list command ? | 07:06 |
| zhenguo | liusheng: both list and show | 07:06 |
| liusheng | zhenguo: or show | 07:06 |
| liusheng | zhenguo: oh | 07:06 |
| liusheng | zhenguo: seems we handled that situation, need to check | 07:07 |
| *** wanghao has joined #openstack-mogan | 07:07 | |
| zhenguo | liusheng: please check again | 07:07 |
| liusheng | zhenguo: ok | 07:08 |
| liusheng | zhenguo: for you client patch, seems we cannot use the MultiKeyValueAction :( | 07:12 |
| zhenguo | liusheng: so just keep the current approach? | 07:12 |
| liusheng | zhenguo: it cannot pass a nargs='?' | 07:13 |
| zhenguo | liusheng: ? | 07:13 |
| liusheng | zhenguo: the osc_lib don't allow this parameter, this parameter means the action can only except once value | 07:14 |
| liusheng | zhenguo: let's keep current approach, may improve in future | 07:15 |
| zhenguo | liusheng: ok | 07:15 |
| openstackgerrit | Merged openstack/python-moganclient master: Add support for specifing patitions when claming a server https://review.openstack.org/501634 | 07:24 |
| liusheng | zhenguo: in my env, it can correctly show server with multiple nics | 07:29 |
| zhenguo | liusheng: oh | 07:29 |
| zhenguo | liusheng: with your new patch? | 07:29 |
| liusheng | zhenguo: no, seems it is ok long ago | 07:29 |
| liusheng | zhenguo: not sure why in your env | 07:29 |
| zhenguo | liusheng: I fetch you patch to specify port-id, then attach a interface, but only show one | 07:30 |
| liusheng | zhenguo: oh, I created a server with twice --nic with different net-id | 07:31 |
| liusheng | zhenguo: if so, it seems a bug in API side ? | 07:31 |
| zhenguo | liusheng: let me try to specify tow nic | 07:31 |
| zhenguo | two | 07:31 |
| zhenguo | liusheng: just tried, still only one address | 07:36 |
| liusheng | zhenguo: strange, may you can try to update code and requirements, you can go my env to see | 07:37 |
| zhenguo | liusheng: oh, seems my API only return one address | 07:37 |
| liusheng | zhenguo: may need to update mogan code, ahh | 07:38 |
| zhenguo | liusheng: yes | 07:38 |
| zhenguo | liusheng: have you ever tested this https://review.openstack.org/#/c/481544/ ? | 07:51 |
| liusheng | zhenguo: no, | 07:51 |
| zhenguo | liusheng:ｈａｈ | 07:52 |
| openstackgerrit | Merged openstack/python-moganclient master: Clean the duplicated formatter method definitions https://review.openstack.org/501931 | 07:52 |
| liusheng | zhenguo: not very fimilar with the process and may need to test in our physical env :( | 07:52 |
| zhenguo | liusheng: virtual env is also ok | 07:53 |
| zhenguo | liusheng: you can create a server then remove it's instance_uuid manually | 07:53 |
| liusheng | zhenguo: oh, need also to delete in Mogan ? | 07:54 |
| openstackgerrit | Merged openstack/python-moganclient master: Add a more detailed README doc https://review.openstack.org/501526 | 07:54 |
| zhenguo | liusheng: seems yes, but may unnecessary | 07:54 |
| zhenguo | liusheng: you can manage it with a different name | 07:54 |
| liusheng | zhenguo: ok, let me try | 07:55 |
| zhenguo | liusheng: thanks | 07:55 |
| zhenguo | Xinran: I will add you as a reviewer on this https://review.openstack.org/#/c/501940/ , please look at it when you got time | 07:58 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 08:17 |
| litao__ | zhenguo,liusheng :https://review.openstack.org/#/c/501777/ | 08:25 |
| zhenguo | litao__: ok, not sure why the managing patch still not passed the gate, takes about 2 hours | 08:26 |
| litao__ | zhenguo: Yes, I also be confused | 08:28 |
| openstackgerrit | Merged openstack/mogan master: Correct db and model inconsistent https://review.openstack.org/501597 | 08:38 |
| litao__ | zhenguo: The status is queued | 08:42 |
| litao__ | zhenguo: Not just mogan, other projects are also like this | 08:43 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 08:47 |
| zhenguo | litao__: sigh | 08:57 |
| *** liusheng has quit IRC | 09:00 | |
| *** liusheng has joined #openstack-mogan | 09:00 | |
| zhenguo | liusheng: I got the reason why there's only one address | 09:01 |
| zhenguo | liusheng: because I use the same network :( | 09:01 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 09:01 |
| liusheng | zhenguo: oh, it is reaonalbe? | 09:01 |
| zhenguo | liusheng: yes, the key is network di | 09:01 |
| zhenguo | *id | 09:01 |
| liusheng | litao__, wanghao sorry, I have update your client patches, and I will test them sucessfully with end-to-end | 09:02 |
| liusheng | zhenguo: shold we support create a server with two nic in a network ? | 09:02 |
| zhenguo | liusheng: seems that would lead problems | 09:02 |
| liusheng | zhenguo: may be need to fix in client | 09:04 |
| zhenguo | liusheng: no client, the API will only return one | 09:04 |
| liusheng | zhenguo: oh, sigh, it is a problem | 09:04 |
| zhenguo | liusheng: nova also do like that | 09:05 |
| zhenguo | liusheng: the key of the dict is network | 09:05 |
| liusheng | zhenguo: not sure if Nova hve the problem | 09:05 |
| zhenguo | liusheng: so if two ports in one network, we can only show one | 09:05 |
| zhenguo | liusheng: oh, or should be combine that? | 09:06 |
| liusheng | zhenguo: but we need to show two ip addresses | 09:06 |
| zhenguo | liusheng: conbime that with same key | 09:06 |
| liusheng | zhenguo: yes | 09:06 |
| zhenguo | liusheng: make sense | 09:06 |
| liusheng | zhenguo: I will test all the server managing patches | 09:08 |
| zhenguo | liusheng: cool | 09:10 |
| zhenguo | liusheng: seems we'd better to not release today, lol | 09:10 |
| liusheng | zhenguo: hah | 09:11 |
| liusheng | zhenguo: seems not very stable | 09:11 |
| zhenguo | liusheng: yes | 09:11 |
| zhenguo | liusheng: by next week | 09:11 |
| liusheng | zhenguo: ok | 09:11 |
| liusheng | zhenguo: but we are non-official project | 09:11 |
| zhenguo | liusheng: we can do more tests | 09:11 |
| zhenguo | liusheng: yes | 09:12 |
| liusheng | zhenguo: ok | 09:12 |
| zhenguo | liusheng: we can run our first release under our CI system | 09:12 |
| liusheng | zhenguo: ok | 09:12 |
| zhenguo | liusheng: need to talk to Kun later | 09:12 |
| liusheng | zhenguo: ok | 09:13 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add preserve_on_delete to server nic object https://review.openstack.org/501940 | 09:17 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 09:18 |
| liusheng | wanghao: ping | 09:27 |
| wanghao | liusheng: pong | 09:27 |
| wanghao | I saw your change, not use servers? | 09:28 |
| liusheng | wanghao: yes, it is better to keep consistency | 09:28 |
| wanghao | liusheng: okay, I will change it again | 09:28 |
| liusheng | wanghao: I remember zhenguo has submitted a change for this | 09:28 |
| zhenguo | liusheng: what | 09:29 |
| liusheng | wanghao: in my patctset, I have test the unit test and pep8 ok | 09:29 |
| liusheng | zhenguo: hah | 09:29 |
| wanghao | liusheng: okay, I add a new one UT in my patchset | 09:29 |
| liusheng | zhenguo: seem i remember you have a change to make the stuff without "s", right ? | 09:30 |
| liusheng | wanghao: ok | 09:30 |
| zhenguo | liusheng: you mean server list? | 09:30 |
| zhenguo | liusheng: instead of servers list | 09:31 |
| liusheng | zhenguo: no, just some class name and file name | 09:31 |
| zhenguo | liusheng: mogan or client? | 09:31 |
| liusheng | zhenguo: client | 09:31 |
| zhenguo | liusheng: no, just mogan | 09:31 |
| liusheng | zhenguo: oh, for now, in moganclient, most stuff without "s", I think we'd better to keep consistent | 09:32 |
| zhenguo | liusheng: yes, please | 09:32 |
| liusheng | zhenguo: hah, I have hijacked both wanghao's and litao's client patches | 09:33 |
| liusheng | zhenguo: in my testing, I cannot manage the server, duplicated name error as you mentioned | 09:34 |
| zhenguo | liusheng: hah | 09:34 |
| zhenguo | liusheng: yes, not sure why there's duplicated name error | 09:34 |
| zhenguo | liusheng: you manage it with a new name right? | 09:35 |
| liusheng | zhenguo: I guess may it because I didn't delete the old server after manaully updating the node's instance_uuid | 09:35 |
| liusheng | zhenguo: yes | 09:35 |
| liusheng | zhenguo: maybe the server.node_uuid have the unique constrait ? | 09:35 |
| zhenguo | liusheng: but we not use the original name | 09:35 |
| zhenguo | liusheng: maybe, need to check | 09:35 |
| zhenguo | liusheng: and you can try to delete the server in db | 09:35 |
| liusheng | zhenguo: as I saied, the exception definition is unreasonble, it treat all duplications as duplicated name error | 09:36 |
| liusheng | zhenguo: hah | 09:36 |
| zhenguo | liusheng: yes | 09:36 |
| liusheng | zhenguo: let me try | 09:36 |
| zhenguo | liusheng: ok | 09:36 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 09:37 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 09:41 |
| liusheng | zhenguo, litao__ server managing tested ok in my env, but the flavor is empty, is it reasonable ? | 09:45 |
| zhenguo | liusheng: yes | 09:45 |
| zhenguo | liusheng: we don't have flavor | 09:45 |
| *** wanghao has quit IRC | 09:45 | |
| zhenguo | liusheng: the duplicate is node_uuid, right? | 09:45 |
| liusheng | zhenguo: not sure, but it is ok after I clean my db, hah | 09:46 |
| zhenguo | liusheng: so, seems it is, but make sense | 09:46 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Fix addresses show within one network https://review.openstack.org/502021 | 10:00 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 10:04 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 10:04 |
| -openstackstatus- NOTICE: Our CI systems experience a hickup, no new jobs are started. Please stay tuned and wait untils this resolved. | 10:47 | |
| Xinran | zhenguo, ok | 11:26 |
| *** litao__ has quit IRC | 11:49 | |
| -openstackstatus- NOTICE: nodepool issue related to bad images has been resolved, builds should be coming back online soon. Restarted gerrit due to reasons. Happy Friday. | 13:46 | |
| openstackgerrit | Merged openstack/mogan master: Update port['device_id'] when creating server https://review.openstack.org/500668 | 14:18 |
| *** harlowja has joined #openstack-mogan | 17:00 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!