*** bobh has joined #openstack-monasca | 00:30 | |
*** bobh has quit IRC | 00:36 | |
*** bobh has joined #openstack-monasca | 00:39 | |
*** bobh has quit IRC | 00:44 | |
*** bobh has joined #openstack-monasca | 00:51 | |
*** tovin07_ has joined #openstack-monasca | 01:00 | |
*** bobh has quit IRC | 01:15 | |
*** Tom_ has joined #openstack-monasca | 02:23 | |
*** bobh has joined #openstack-monasca | 03:17 | |
*** bobh has quit IRC | 03:19 | |
*** nicolasbock has quit IRC | 03:40 | |
*** bobh has joined #openstack-monasca | 03:45 | |
*** bobh has quit IRC | 03:49 | |
*** Tom_ has quit IRC | 04:06 | |
*** aspiers has joined #openstack-monasca | 04:27 | |
aspiers | if anyone is at the PTG, please could they join this session tomorrow morning? https://etherpad.openstack.org/p/self-healing-queens-ptg | 04:27 |
---|---|---|
*** Tom has joined #openstack-monasca | 04:38 | |
*** Tom has quit IRC | 04:42 | |
*** Tom has joined #openstack-monasca | 05:50 | |
*** jgu_ has quit IRC | 05:52 | |
*** jgu_ has joined #openstack-monasca | 05:53 | |
*** huxinhui_ has joined #openstack-monasca | 06:12 | |
*** toabctl has joined #openstack-monasca | 06:36 | |
*** pcaruana has joined #openstack-monasca | 06:42 | |
*** jgu_ has quit IRC | 07:31 | |
*** tobiajo has joined #openstack-monasca | 07:45 | |
*** tobiajo has quit IRC | 08:12 | |
*** tobiajo has joined #openstack-monasca | 08:14 | |
*** Guest53207 is now known as sc | 08:30 | |
*** nicolasbock has joined #openstack-monasca | 10:02 | |
*** nicolasbock has quit IRC | 10:07 | |
*** Tom has quit IRC | 10:18 | |
*** Tom has joined #openstack-monasca | 10:18 | |
*** nicolasbock has joined #openstack-monasca | 10:20 | |
*** Tom has quit IRC | 10:23 | |
*** tovin07_ has quit IRC | 10:30 | |
*** prithiv__ has joined #openstack-monasca | 11:34 | |
*** prithiv__ has quit IRC | 11:35 | |
*** huxinhui_ has quit IRC | 11:41 | |
*** bobh has joined #openstack-monasca | 13:13 | |
*** rbrndt has joined #openstack-monasca | 14:19 | |
*** Tom___ has joined #openstack-monasca | 14:24 | |
*** Tom___ has quit IRC | 14:25 | |
*** Tom___ has joined #openstack-monasca | 14:26 | |
*** jgu_ has joined #openstack-monasca | 15:16 | |
*** pcaruana has quit IRC | 15:20 | |
*** zhurong has joined #openstack-monasca | 15:21 | |
*** tobiajo has quit IRC | 15:37 | |
prometheanfire | we noticed that monasca-notification requires the 'jira' python module and it is not in global-requirements.txt or blacklist.txt | 15:52 |
rbrndt | Ah, it probably shouldn't require that package as it is optional | 15:56 |
prometheanfire | so it can be removed from your requirements file? | 15:56 |
rbrndt | I'll look into it, but yes I believe so | 15:57 |
prometheanfire | cool | 15:57 |
prometheanfire | thanks | 15:57 |
prometheanfire | it looks like it snuck in because the check-requirements job doesn't look at setup.cfg changes, we'll be fixing that :P | 16:01 |
prometheanfire | if you do end up needing it, please request it to be added to requirements | 16:02 |
*** zhurong has quit IRC | 16:06 | |
rbrndt | prometheanfire: I don't see it in anything but setup.cfg is that what is causing the problem? | 16:09 |
prometheanfire | yep | 16:09 |
prometheanfire | it's not listed in upper-constraints.txt (requirements project/repo) so it's not tracked for co-installability or licence validity | 16:10 |
prometheanfire | or code quality | 16:10 |
rbrndt | So, I guess I'm confused as to the solution here. We want to include it there in case people want to use the plugin that requires it | 16:10 |
rbrndt | but its not a strict requirement for the base functionality | 16:11 |
prometheanfire | then make a review to add it to requirements :D | 16:11 |
prometheanfire | same as any new library :D | 16:11 |
rbrndt | But we don't want to install it by default | 16:11 |
prometheanfire | test libs are still libs | 16:11 |
prometheanfire | that's fine | 16:11 |
rbrndt | Ok, let me look into how we did this for our other component that has plugins | 16:12 |
prometheanfire | it was the only one we found for monasca (monasca-agent isn't managed by requirements so doesn't count) | 16:13 |
prometheanfire | the process for adding new requirements is doc'd here https://github.com/openstack/requirements/#for-new-requirements | 16:15 |
prometheanfire | those questions should be answered in the commit message as well | 16:16 |
*** zhurong has joined #openstack-monasca | 16:18 | |
rbrndt | ok, thanks. I'll raise this to the PTL and he can decide how he wants to handle it | 16:18 |
prometheanfire | cool | 16:19 |
*** bobh has quit IRC | 16:56 | |
*** Tom___ has quit IRC | 17:02 | |
*** aagate has quit IRC | 17:09 | |
*** bobh has joined #openstack-monasca | 17:32 | |
*** rbrndt has quit IRC | 17:35 | |
*** zhurong has quit IRC | 17:42 | |
*** bobh has quit IRC | 17:53 | |
*** rbrndt has joined #openstack-monasca | 18:27 | |
*** prometheanfire has quit IRC | 18:32 | |
*** prometheanfire has joined #openstack-monasca | 18:46 | |
*** bobh has joined #openstack-monasca | 19:06 | |
*** bobh has quit IRC | 19:10 | |
*** bobh has joined #openstack-monasca | 19:22 | |
*** bobh has quit IRC | 19:35 | |
*** zhurong has joined #openstack-monasca | 19:51 | |
*** zhurong has quit IRC | 21:35 | |
*** aagate has joined #openstack-monasca | 21:59 | |
*** rbrndt has quit IRC | 23:05 | |
*** rbrndt has joined #openstack-monasca | 23:05 | |
*** rbrndt has quit IRC | 23:05 | |
*** vishwana_ has joined #openstack-monasca | 23:45 | |
*** jamesgu has joined #openstack-monasca | 23:45 | |
*** joadavis1 has joined #openstack-monasca | 23:48 | |
*** vishwanathj has quit IRC | 23:48 | |
*** joadavis has quit IRC | 23:48 | |
*** jgu_ has quit IRC | 23:48 | |
*** portdirect has quit IRC | 23:49 | |
*** portdirect has joined #openstack-monasca | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!