Wednesday, 2019-03-13

*** dangtrinhnt has left #openstack-monasca00:55
*** pandy has joined #openstack-monasca06:16
*** pcaruana has joined #openstack-monasca06:19
*** witek has joined #openstack-monasca08:35
*** pandy has quit IRC09:07
*** dougsz has joined #openstack-monasca09:10
*** pandy has joined #openstack-monasca09:46
*** mohankumar has joined #openstack-monasca09:50
mohankumarHi @witek @dougsz one qq , is it possiple one user (admin) to read alarms from across all tenents ?09:51
dougszThey need the correct role in all the projects09:52
witekand iterate across the projects09:53
mohankumarsay for (e.g) i need to list all the alarms using monasca alarm-list using keystone admin user .09:54
mohankumarnow with admin user i can list only alarms configured for admin tenant09:55
mohankumar@dougsz : I ve  added admin user in all the projects and assigned admin role09:56
dougszyou can change the OS_PROJECT env var and then list alarms in each project individually as witek says above09:56
pandyhttps://github.com/openstack/monasca-agent/blob/master/docs/MonascaMetrics.md#cross-tenant-metric-submission09:56
dougsz(assuming you are using env vars for auth)09:57
pandyin sourcerc file for OS_PROJECT try to iterate all projects from "openstack project list"09:58
mohankumardougsz , witek: yes that can be done . But every time I query alarm list for particular projects (tenants) I'm afraid more keystone hits will happen to fetch project specific tokens10:01
*** pandy has quit IRC10:03
mohankumar**In my case I've more projects ~800-1000 projects10:04
*** pandy has joined #openstack-monasca10:05
witekdo you define the alarms for every project individually?10:06
mohankumaryes10:07
mohankumarI use grafana to create alarms10:07
mohankumarwitek , if i use cli , may it help ?10:08
witekyou could automate the process, but the problem remains the same10:08
mohankumarwitek : so current code base ,  we don't ve this option right to list alarms from cross tenants with single api call?10:10
witekI think it's a valid use case, we could think about adding a convenience function to get all alarms across the tenants10:10
witekno10:11
mohankumarwitek :  yes , it helps if we could add this option , something like "monasca alarm-list --all-projects"10:12
mohankumarcan I take it forward ?10:12
witeksure, that would be great10:13
mohankumarwitek : Thanks !10:13
witekplease start with the story describing the motivation and expected result10:14
mohankumarwitek : yes sure10:14
*** pandy has joined #openstack-monasca10:15
witekwe should also think about restricting access to this resource only for admins10:15
mohankumarwitek : agree10:20
*** pandy has quit IRC10:20
*** pandy has joined #openstack-monasca10:23
pandysimilar like openstack server list --all-tenants10:25
pandySorry my network went down and just noticed all my messages are back logged10:26
pandywitek, I am agreed with mohankumar & keystone hit will be more for large project numbers, can have dedicated api or customised parameters to monasca similar like "server list --all-projects"10:31
*** chaconpiza has joined #openstack-monasca10:33
pandywitek, FYI regarding customising mail template, added new notification type as "CUSTOM_MAIL" to monasca-client and doing necessary changes in monasca-notification, will send merge request to review10:35
openstackgerritjianweizhang proposed openstack/monasca-api master: monasca-api can not config cassandra cluster port  https://review.openstack.org/64221610:35
witekthanks pandy10:38
*** mohankumar has quit IRC10:57
openstackgerritDaisuke Fujita proposed openstack/monasca-analytics master: add download_file function in devstack plugin.sh  https://review.openstack.org/43721511:02
*** dougsz has quit IRC11:50
*** dougsz has joined #openstack-monasca12:19
*** dougsz has quit IRC12:28
*** dougsz has joined #openstack-monasca12:38
openstackgerritDobroslaw Zybort proposed openstack/monasca-common master: Don't remove tempest tests from installation folder  https://review.openstack.org/64303612:40
*** pandy has quit IRC12:41
*** pandy has joined #openstack-monasca12:41
*** dougsz has quit IRC13:12
openstackgerritMerged openstack/monasca-common master: Support full links in Docker wait script  https://review.openstack.org/64274213:43
openstackgerritAdrian Czarnecki proposed openstack/monasca-api master: [WIP] Add unit test  https://review.openstack.org/64163114:01
*** irclogbot_2 has quit IRC14:09
openstackgerritDobroslaw Zybort proposed openstack/monasca-tempest-plugin master: Create Docker image and build in Zuul  https://review.openstack.org/64036114:10
*** irclogbot_2 has joined #openstack-monasca14:11
openstackgerritMichaƂ Piotrowski proposed openstack/python-monascaclient master: Create Docker image and build in Zuul  https://review.openstack.org/64003314:19
*** irclogbot_2 has quit IRC14:25
*** irclogbot_2 has joined #openstack-monasca14:26
*** dougsz has joined #openstack-monasca14:29
openstackgerritMerged openstack/monasca-api master: Improve tests coverage  https://review.openstack.org/63271814:52
openstackgerritMerged openstack/monasca-common master: Don't remove tempest tests from installation folder  https://review.openstack.org/64303614:52
witekCourtesy Monasca meeting reminder in #openstack-monasca: witek, jayahn,iurygregory,ezpz,igorn,haad,sc,joadavis, akiraY,tobiajo,dougsz_,fouadben, amofakhar, aagate, haruki,kaiokmo,pandiyan,charana,guilhermesp,chaconpiza,toabctl15:01
witek#startmeeting monasca15:01
openstackMeeting started Wed Mar 13 15:01:29 2019 UTC and is due to finish in 60 minutes.  The chair is witek. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
*** openstack changes topic to " (Meeting topic: monasca)"15:01
openstackThe meeting name has been set to 'monasca'15:01
witekhello15:01
dougsz\o hey15:01
DobroslawHi15:01
witekhi dougsz and Dobroslaw15:01
witekplease put items into agenda if you have any15:02
witekhttps://etherpad.openstack.org/p/monasca-team-meeting-agenda15:02
witekand if not we can go through the list of new changes in review15:03
witek#topic reviews15:03
*** openstack changes topic to "reviews (Meeting topic: monasca)"15:03
witekhttps://review.openstack.org/64208215:04
witekfirst one from Stig15:04
dougszStill need to review that one15:05
dougszMy main concern is making sure it's backwards compatible15:05
*** hosanai has joined #openstack-monasca15:05
witekit gets some configuration details from Ceph config file and configures the plugin using that, right?15:06
dougszah yes, there is another change in the pipeline I am thinking of15:07
witekI see, not published yet15:07
DobroslawIt looks mostly as handling edge case15:08
witekOK, the next two are the changes for Cassandra15:10
witekhttps://review.openstack.org/64237215:10
witekhttps://review.openstack.org/64221615:10
witekgood to see some changes there after a long time15:11
witekbuilding Docker image for python client:15:12
witekhttps://review.openstack.org/64003315:12
DobroslawI will test it tomorrow, code looks fine for me now15:13
witekis it enough to run `./build_image.sh` to try it out?15:13
DobroslawYes15:13
witekand how can the client be used afterwards?15:14
DobroslawLike for connecting to existing network of docker comppse15:15
witekany example? what should I run if I would like to list metrics for example?15:15
DobroslawUgh, I'm writing from phone now, will sent you tomorrow15:16
witekI'll ask in review :)15:16
DobroslawOK15:16
*** mohankumar has joined #openstack-monasca15:17
DobroslawReadme could be updated with more examples15:17
witeknext one:15:18
witekhttps://review.openstack.org/#/c/632718/15:18
witekoh, merged already15:18
witekgreat15:18
DobroslawMerged already :-)15:19
witek+2000 lines15:19
joadavisimpressive15:19
DobroslawAll thanks to adriancz15:19
witekgood job, that's pre step for API merging15:20
witekany other reviews?15:20
pandywitek, am submitting review for custom email notification in couple of minutes15:21
dougszGood stuff! adriancz15:21
witek#topic bugs15:22
*** openstack changes topic to "bugs (Meeting topic: monasca)"15:22
witekwe have three bug reports in etherpad15:23
witekhttps://storyboard.openstack.org/#!/story/200522415:23
openstackgerritPandiyan proposed openstack/monasca-notification master: [WIP] Adding custom_email notification method  https://review.openstack.org/64307515:23
witekI think we miss some details here15:23
dougsz^ That one is from the monasca grafana fork15:23
dougszNot the datasource15:23
dougszQuestions are: 1) How do we track bugs for that component?15:24
dougsz2) Is the monasca-grafana fork 'supported'?15:24
witekwe haven't had many bug reports for Grafana fork, so I'm fine with having it in StoryBoard15:26
witekalthought it would fit better as Github issue15:26
dougszThey are disabled at the moment - perhaps we should enable them?15:26
witekoh, yes, probably good idea :)15:27
kaiokmoI've run through this same issue as well a couple times :)15:27
dougszYeah, there is no token refresh mechanism. I think you should at least get sent back to the login page.15:27
kaiokmothat would make sense15:28
dougszWe should hopefully be able to pick it up, as quite a few users complain about it.15:28
DobroslawUnfortunately adding backend plugins to grafana do not have any progress in last year...15:29
witekfor supporting Grafana fork, we still don't have a better mechanism if you don't want or cannot proxy requests via Horizon15:29
witekwhat we could do is to start working on adding support for Keystone Application Credentials in Monasca datasource15:30
dougszyeah, that is one promising avenue15:31
dougszJust need to find the manpower15:31
witekthe problem is, that we're storing these credentials on client, which is a security risk15:31
witekthe work on adding whitelisting to Application Credentials in Keystone is work in progress though15:32
witekso I think we can use them securely soon15:32
dougszI've enabled github issues for the fork and moved the bug report15:33
witekthanks dougsz !15:33
witekdoes Palimariu work with you?15:34
dougszHe's a user of a Monasca deployment we've done.15:34
dougszTrying to encourage upstream involvement :)15:35
witekI see, very good!15:35
witekthen we have two security issues15:36
witekhttps://storyboard.openstack.org/#!/story/200521515:36
*** irclogbot_2 has quit IRC15:36
*** hosanai has quit IRC15:36
pandywitek, I have initiated custom-email changes for monasca-notification, I need to add test cases for the same and added witek, dougz to review.15:37
witekhold on pandy15:37
joadavisThe two security issues are from a batch I came across last week15:37
joadavisthey are old ones from a year or so ago, though I still see them in the code15:38
*** irclogbot_2 has joined #openstack-monasca15:38
joadavisI think these are "hardening opportunities" rather than gaping security issues15:38
witekI cannot open https://storyboard.openstack.org/#!/story/200521715:38
dougsz+115:38
dougsz40415:38
joadavisThere are a few more in our internal bug tracking which I need to try publishing15:38
joadavisSorry, I think I marked that one with the 'security bug' checkbox, which makes it private15:39
joadavisI can go uncheck that15:39
dougszah, I see15:39
joadavisok, you can try again15:39
witeknow I can see it15:40
joadavisI'll go back through the list today and post any other relevant ones15:40
joadavisIn general, these seem like small changes.15:40
witekshould we tag these as bugs, so that these are easier to find?15:40
joadavisBut I know at least one would likely need a configuration setting to be implemented well15:41
joadavisSure. I wanted to bring it up in this meeting so we can discuss how best to handle them15:41
dougszThanks for reporting joadavis15:41
dougszhttps://storyboard.openstack.org/#!/story/2005215 is relevant to you Pandy?15:42
pandydougsz, not relevant to me15:43
witekthese seem to be small tasks which should be easy to be picked up by anyone15:43
joadavisyes.  I wish I'd been aware of this internal list months ago, as we could have easily included them in Rocky.15:43
witekwell, we can have them in Stein or Train :)15:44
witekthanks joadavis15:45
witekhere, pandy's change for email notification templating:15:45
witekhttps://review.openstack.org/64307515:46
witekI've added it to the list on etherpad15:46
pandywitek, I have just proposed WIP patch for custom email notification.15:46
joadaviscool (and that might be a good pairing with story 2005215)15:47
pandyStill I need to add "Tenant_Name" in subject, for that need to through libraries to import.15:48
witekI think, I'd rather modify the existing plugin instead of adding a new one15:48
*** irclogbot_2 has quit IRC15:49
witekha, the same comment from dougsz in review :)15:49
dougsz:)15:49
pandyyes, I was thought about it, but don't want to change existing functionality did like this15:50
witekthanks for the change pandy15:50
*** irclogbot_2 has joined #openstack-monasca15:50
witekdo you think you can do the second step of adding it to the API after that one is merged?15:51
pandyYou mean after python-client changes ?15:52
*** irclogbot_2 has quit IRC15:52
dougszBoth really, so users can set custom templates from the client, and the API supports that operation15:53
witekyes15:53
pandydougsz,  yes. I feel good to have new plugins without touching existing one, so users can choose as their wish15:54
dougszA fair bit of work there I would imagine, I assume we would store templates in the DB15:54
witeknew point in the agenda15:55
*** irclogbot_2 has joined #openstack-monasca15:55
pandyyes, dougsz need to store in DB, which witek conveyed last time15:55
witek#topic building Kolla images15:55
*** openstack changes topic to "building Kolla images (Meeting topic: monasca)"15:55
dougszah yes, so this came up last week, totally possible.15:55
witekdo you know any details, I guess Dobroslaw is interested15:56
dougszYou can easily get Kolla to build per repo images.15:57
pandySorry to interupt. witek, dougsz hope both are agreed to have new plugins, if need to do changes in existing one please let me know, so I can find the possiblities.15:57
dougszI think the configuration mechanism is quite different to the existing Monasca docker images15:57
dougszAs Dobroslaw knows :)15:57
DobroslawYes15:57
DobroslawProviding config files Vs env variables15:58
dougszThe images are also fairly heavyweight - either Debian or Centos based15:58
dougszOn the plus side, the Kolla images maintained to some extent by the Kolla team15:59
dougsz*are maintained15:59
witekif I understood correctly, we had a problem with triggering the CI job when tagging the repo16:00
dougszpandy: I would rather not have a duplicate plugin, would be nice if we have one email plugin, and it does it's job well16:00
witekI have to jump to another meeting16:00
witeksee you next week16:01
witekbye16:01
dougsznp, thanks all16:01
DobroslawThanks16:01
witek#endmeeting16:01
*** openstack changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca"16:01
openstackMeeting ended Wed Mar 13 16:01:16 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/monasca/2019/monasca.2019-03-13-15.01.html16:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/monasca/2019/monasca.2019-03-13-15.01.txt16:01
openstackLog:            http://eavesdrop.openstack.org/meetings/monasca/2019/monasca.2019-03-13-15.01.log.html16:01
Dobroslawpandy: maybe it would be possible to have such defaults that for end user there will be no difference with old mail plugin16:02
joadavis+1. Then you could put the new custom templating in place in the existing email plugin16:03
DobroslawDifference only would be that user could provide custom template if he want16:03
pandydougsz, understand.16:03
dougszpandy, if you look at the Slack template patch in review, it should only change the default behaviour *if* a template is provided16:04
pandydougsz, yes, just had a look. I will refer it :)16:05
*** sum12 has left #openstack-monasca16:07
*** mohankumar has quit IRC16:07
*** sum12 has joined #openstack-monasca16:10
*** jamesgu__ has joined #openstack-monasca17:39
*** pandy has quit IRC17:48
*** dougsz has quit IRC17:58
*** pcaruana has quit IRC18:29
*** gmann is now known as gmann_afk18:48
*** sum12 has quit IRC19:51
*** sum12 has joined #openstack-monasca19:51
*** gmann_afk is now known as gmann20:41
*** witek has quit IRC21:21

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!