| *** Wasaac has joined #openstack-monasca | 01:15 | |
| *** Wasaac has quit IRC | 01:19 | |
| *** pcaruana has joined #openstack-monasca | 04:44 | |
| *** pcaruana has quit IRC | 04:56 | |
| *** pcaruana has joined #openstack-monasca | 06:21 | |
| -openstackstatus- NOTICE: The git service on opendev.org is currently down. | 06:50 | |
| *** ChanServ changes topic to "The git service on opendev.org is currently down." | 06:50 | |
| *** witek has joined #openstack-monasca | 07:37 | |
| openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: [WIP] Update devstack plugin to support new api https://review.opendev.org/672263 | 08:10 |
|---|---|---|
| *** dougsz has joined #openstack-monasca | 08:12 | |
| *** Wasaac has joined #openstack-monasca | 08:31 | |
| -openstackstatus- NOTICE: Services at opendev.org like our git server and at openstack.org are currently down, looks like an outage in one of our cloud providers. | 08:33 | |
| *** ChanServ changes topic to "Services at opendev.org like our git server and at openstack.org are currently down, looks like an outage in one of our cloud providers." | 08:33 | |
| *** ChanServ changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca" | 08:40 | |
| -openstackstatus- NOTICE: The problem in our cloud provider has been fixed, services should be working again | 08:40 | |
| openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: [WIP] Update devstack plugin to support new api https://review.opendev.org/672263 | 08:50 |
| *** Wasaac has quit IRC | 08:55 | |
| *** Wasaac has joined #openstack-monasca | 08:55 | |
| openstackgerrit | pengyuesheng proposed openstack/monasca-api master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/672668 | 09:07 |
| *** ivve has joined #openstack-monasca | 09:08 | |
| openstackgerrit | pengyuesheng proposed openstack/monasca-api master: Blacklist sphinx 2.1.0 (autodoc bug) https://review.opendev.org/672670 | 09:10 |
| openstackgerrit | Merged openstack/monasca-log-api master: Update api-ref location https://review.opendev.org/672104 | 09:12 |
| brtknr | witek: would you please revisit this: https://review.opendev.org/#/c/668507/5 | 09:30 |
| brtknr | I expanded the test as you requested | 09:30 |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-log-api master: Return valid url when querying versions endpoint https://review.opendev.org/668507 | 09:32 |
| witek | thanks, will do | 09:32 |
| openstackgerrit | Dobroslaw Zybort proposed openstack/monasca-thresh master: Create Docker image and build in Zuul for Monasca-Thresh https://review.opendev.org/649298 | 10:19 |
| *** brtknr has quit IRC | 10:27 | |
| *** brtknr has joined #openstack-monasca | 10:33 | |
| *** brtknr has quit IRC | 10:56 | |
| *** brtknr has joined #openstack-monasca | 10:56 | |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-tempest-plugin master: Support time range to query dimension names/values https://review.opendev.org/670564 | 11:10 |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-tempest-plugin master: Support time range to query dimension names/values https://review.opendev.org/670564 | 11:16 |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-api master: Support time range to query dimension names/values https://review.opendev.org/670318 | 11:28 |
| *** mkarpiarz has joined #openstack-monasca | 11:31 | |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-grafana-datasource master: Support time range to query dimension names/values https://review.opendev.org/670316 | 11:31 |
| *** Wasaac has quit IRC | 11:36 | |
| *** pcaruana has quit IRC | 11:42 | |
| openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: [WIP] Update devstack plugin to support new api https://review.opendev.org/672263 | 11:48 |
| *** pcaruana has joined #openstack-monasca | 12:22 | |
| witek | adriancz, Dobroslaw, dougsz, sc: could I get +2 on that cherry-pick please? https://review.opendev.org/672035 | 12:28 |
| Dobroslaw | done | 12:28 |
| witek | thanks | 12:28 |
| adriancz | Done | 12:29 |
| adriancz | Dobek was faster : P | 12:29 |
| witek | or you too slow :) | 12:30 |
| *** Wasaac has joined #openstack-monasca | 12:40 | |
| *** Wasaac has quit IRC | 12:41 | |
| *** Wasaac has joined #openstack-monasca | 12:41 | |
| *** Wasaac has quit IRC | 13:05 | |
| *** Wasaac_ has joined #openstack-monasca | 13:06 | |
| brtknr | witek: I am not entirely sure I understand your comment | 13:08 |
| brtknr | > Thanks, that's good but it's not catching the bad case which you've described in the story. The new test should ideally fail without your fix and pass after applying it. | 13:08 |
| brtknr | Try adding another route in setup method and test for empty path. | 13:08 |
| brtknr | I have added this line: `expected_url = '{}://{}'.format(expected_protocol, expected_host)` | 13:09 |
| brtknr | Without the change, the expected url would have been `expected_url = '{}:{}'.format(expected_protocol, expected_host)` | 13:09 |
| witek | only if you test the request with empty path | 13:10 |
| brtknr | Are would proposing that I should do an assertFalse with the second case? | 13:11 |
| witek | if you test with path=`/versions` the result is correct even without your fix | 13:11 |
| witek | let me comment in review, that'll be easier | 13:11 |
| brtknr | witek: Hmm the test fails with a 404 when the path is '/' | 13:17 |
| witek | have you added the route? | 13:18 |
| brtknr | witek: oops, good point! | 13:31 |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-log-api master: Return valid url when querying versions endpoint https://review.opendev.org/668507 | 13:32 |
| brtknr | witek: please take another look ^ | 13:32 |
| brtknr | witek: its passing locally :) | 13:32 |
| witek | nice, thanks! | 13:37 |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-log-api master: Return valid url when querying versions endpoint https://review.opendev.org/668507 | 13:42 |
| brtknr | witek: oops, 1 small change | 13:43 |
| *** Wasaac_ has quit IRC | 13:52 | |
| *** Wasaac has joined #openstack-monasca | 13:53 | |
| *** Wasaac has quit IRC | 13:53 | |
| *** Wasaac has joined #openstack-monasca | 13:53 | |
| openstackgerrit | Merged openstack/monasca-transform master: do not set INFLUXDB_VERSION https://review.opendev.org/670080 | 13:55 |
| openstackgerrit | Dobroslaw Zybort proposed openstack/monasca-thresh master: Create Docker image and build in Zuul for Monasca-Thresh https://review.opendev.org/649298 | 14:10 |
| *** bobh has joined #openstack-monasca | 14:23 | |
| *** joadavis has joined #openstack-monasca | 14:26 | |
| openstackgerrit | Bharat Kunwar proposed openstack/monasca-tempest-plugin master: Support time range to query dimension names/values https://review.opendev.org/670564 | 14:50 |
| *** Wasaac has quit IRC | 14:53 | |
| *** Wasaac has joined #openstack-monasca | 14:54 | |
| *** Wasaac has quit IRC | 14:56 | |
| *** Wasaac has joined #openstack-monasca | 14:56 | |
| brtknr | dougsz: witek: this one is ready for review... looks like show tag keys and values has a granularity of 1 day although i cannot find any documentation to back this up | 14:56 |
| brtknr | https://review.opendev.org/670564 | 14:56 |
| *** adriancz has quit IRC | 15:39 | |
| *** altlogbot_3 has quit IRC | 15:48 | |
| *** altlogbot_2 has joined #openstack-monasca | 15:50 | |
| brtknr | witek: hmm now only the cassandra test is failing but tempest is not aware of whether the backend is influxdb or cassandra... how do I skip the timerange related tests when the backend is cassandra? | 15:53 |
| brtknr | https://review.opendev.org/#/c/670564/ | 15:53 |
| openstackgerrit | Merged openstack/monasca-log-api master: Return valid url when querying versions endpoint https://review.opendev.org/668507 | 15:54 |
| *** Wasaac has quit IRC | 16:09 | |
| *** Wasaac has joined #openstack-monasca | 16:10 | |
| *** witek has quit IRC | 16:31 | |
| *** joadavis has quit IRC | 16:32 | |
| *** Wasaac has quit IRC | 16:42 | |
| *** Wasaac has joined #openstack-monasca | 16:50 | |
| *** Wasaac has quit IRC | 16:54 | |
| *** dougsz has quit IRC | 16:57 | |
| *** ivve has quit IRC | 17:01 | |
| *** bobh has quit IRC | 17:39 | |
| *** bobh has joined #openstack-monasca | 18:11 | |
| *** bobh has quit IRC | 18:17 | |
| *** ivve has joined #openstack-monasca | 18:35 | |
| *** bobh has joined #openstack-monasca | 19:05 | |
| *** bobh has quit IRC | 19:11 | |
| *** dkushwaha has quit IRC | 19:59 | |
| *** bobh has joined #openstack-monasca | 20:53 | |
| *** bobh has quit IRC | 20:59 | |
| *** pcaruana has quit IRC | 21:28 | |
| *** ivve has quit IRC | 21:30 | |
| *** arseni-lipinski has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!