*** trident has joined #openstack-monasca | 00:03 | |
*** bobh has joined #openstack-monasca | 00:35 | |
*** bobh has quit IRC | 00:42 | |
*** bobh has joined #openstack-monasca | 00:45 | |
*** bobh has quit IRC | 01:00 | |
*** bobh has joined #openstack-monasca | 01:39 | |
*** bobh has quit IRC | 01:44 | |
*** bobh has joined #openstack-monasca | 01:53 | |
*** bobh has quit IRC | 01:54 | |
*** bobh has joined #openstack-monasca | 02:09 | |
*** bobh has quit IRC | 02:43 | |
*** bobh has joined #openstack-monasca | 02:46 | |
*** bobh has quit IRC | 02:50 | |
*** openstackgerrit has quit IRC | 06:51 | |
*** trident has quit IRC | 07:21 | |
*** ivve has joined #openstack-monasca | 07:27 | |
*** trident has joined #openstack-monasca | 07:29 | |
*** trident has quit IRC | 07:34 | |
*** trident has joined #openstack-monasca | 07:43 | |
*** dougsz has joined #openstack-monasca | 08:17 | |
*** witek_ has joined #openstack-monasca | 08:35 | |
*** mbindlish_ has joined #openstack-monasca | 08:49 | |
*** trident has quit IRC | 09:01 | |
*** trident has joined #openstack-monasca | 09:09 | |
*** openstackgerrit has joined #openstack-monasca | 09:29 | |
openstackgerrit | Thomas Bechtold proposed openstack/monasca-statsd master: Switch to openstackdocstheme https://review.opendev.org/679983 | 09:29 |
---|---|---|
brtknr | witek_: what do the 3 zuul failures in this review mean: https://review.opendev.org/#/c/674484/ | 09:31 |
brtknr | looks like monasca-tempest-python2-influxdb is related to the influxdb client version but the other two seem unrelated to my change | 09:31 |
*** witek_ has quit IRC | 10:09 | |
*** witek has joined #openstack-monasca | 10:14 | |
*** arseni-lipinski has joined #openstack-monasca | 10:14 | |
brtknr | witek: dougsz and I also wannted to reach a decision on this change: https://review.opendev.org/#/q/topic:story/2006204+(status:open+OR+status:merged) | 10:24 |
brtknr | we have a better understand of why the show tag key/value queries return approximately accurate results | 10:25 |
brtknr | its because the accuracy is defined by the shard duration | 10:25 |
brtknr | e.g. if a show tag key/value query where time < now()-1h and now()-2h returns the result for the entire day if the shard duration is 1 day | 10:27 |
brtknr | this is an improvement over the current situation where the entire database is searched which is inefficient, but this the result is not 100% accurate | 10:27 |
dougsz | brtknr: The main concern I have is that with the above behaviour, in for example a Grafana dashboard which runs a query to get the hostnames for the current time window, you could end up with hostnames *outside* of the time window, and this could be confusing to users. | 10:28 |
dougsz | It's a shame we hit this behaviour, because otherwise, I think it would be a very useful improvement. | 10:29 |
dougsz | I suppose to be fair, the existing hostname query in a Grafana dashboard returns hostnames for all time, which is even worse | 10:30 |
brtknr | thats correct, the correct fix is to do a nested SELECT query but that is comparitively slower | 10:30 |
dougsz | On a DB where the query across all time takes a few minutes, how long does the SELECT query take? | 10:32 |
dougsz | Maybe it's not as fast as your current implementation, but if it's always better than the existing implementation then that could be a path forwards. | 10:33 |
brtknr | i cant get the result for the SELECT query because it seems to time out | 10:52 |
brtknr | "SHOW TAG VALUES WITH KEY=hostname" runs in 2 seconds on our p3 project | 10:53 |
brtknr | 'SELECT DISTINCT("hostname") from (SELECT "hostname","value" FROM /.*/)' | 10:54 |
brtknr | the second one times out | 10:54 |
brtknr | mind that the first query is scanning the entire database | 10:54 |
brtknr | i am trying a time bound query now | 10:58 |
brtknr | this query which is an hour time window takes 18 seconds: 'SELECT DISTINCT("hostname") from (SELECT * FROM /.*/ WHERE time >= 1564081121495ms AND time < 1564084721497ms GROUP BY *)' | 11:01 |
brtknr | A 1 day time window times out after 1 minute | 11:03 |
brtknr | on the other hand, the equavalent tag query takes 0.9s: | 11:04 |
brtknr | "SHOW TAG VALUES WITH KEY=hostname WHERE time >= 1564081121495ms AND time < 1564084721497ms" | 11:04 |
brtknr | real 0m0.927s | 11:04 |
brtknr | user 0m0.014s | 11:04 |
brtknr | sys 0m0.009s | 11:04 |
*** witek has quit IRC | 12:06 | |
*** coreycb has joined #openstack-monasca | 12:56 | |
coreycb | hi folks is witek still the PTL for monasca? i've not been able to get in touch with him via email. | 12:57 |
*** witek has joined #openstack-monasca | 12:58 | |
coreycb | good timing, witek is monasca-analytics on your radar for the python3-train community goal? the goal deadline is a week from this friday | 12:58 |
coreycb | https://review.opendev.org/#/q/topic:python3-train%20status:open%20(%20label:Verified-1%20OR%20label:Verified-2%20) | 12:58 |
*** pcaruana has quit IRC | 13:10 | |
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Exclude influxdb 5.2.3 for python https://review.opendev.org/680405 | 13:19 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Exclude influxdb 5.2.3 for python https://review.opendev.org/680412 | 13:37 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Implement separate db per tenancy https://review.opendev.org/674484 | 13:38 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Tool to migrate existing data to db per tenant https://review.opendev.org/679794 | 13:38 |
*** mbindlish_ has quit IRC | 13:39 | |
*** arseni-lipinski has quit IRC | 13:39 | |
*** pcaruana has joined #openstack-monasca | 13:39 | |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-api master: Implement separate db per tenancy https://review.opendev.org/674478 | 13:40 |
brtknr | adriancz: hope you dont mind that I copied your commit to monasca-persister | 13:41 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Exclude influxdb 5.2.3 for python https://review.opendev.org/680412 | 13:43 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Implement separate db per tenancy https://review.opendev.org/674484 | 13:43 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Tool to migrate existing data to db per tenant https://review.opendev.org/679794 | 13:43 |
adriancz | No, i don't go ahead : ) | 13:44 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Exclude influxdb 5.2.3 for python https://review.opendev.org/680412 | 13:45 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Implement separate db per tenancy https://review.opendev.org/674484 | 13:45 |
openstackgerrit | Bharat Kunwar proposed openstack/monasca-persister master: Tool to migrate existing data to db per tenant https://review.opendev.org/679794 | 13:45 |
adriancz | @brtknr thanks for this change, i totally forgot to add this change to persister | 13:49 |
brtknr | adriancz: np :) i was really confused about why the global requirements wasn't having any effect to the CI, didn't realise a local change was also necessary | 13:49 |
*** pcaruana has quit IRC | 14:12 | |
brtknr | adriancz: any idea why the python2 test still fails? https://review.opendev.org/#/c/680405/ | 14:20 |
adriancz | no idea | 14:21 |
adriancz | i will check this tomorrow | 14:24 |
brtknr | adriancz: thanks | 14:27 |
adriancz | devstack still install influxdb=5.2.3, https://zuul.opendev.org/t/openstack/build/ea6b33df80ff454e86ec9f26900a3a45/log/job-output.txt#15972 | 14:30 |
*** piotrowskim has quit IRC | 14:58 | |
brtknr | adriancz: hmm | 15:17 |
brtknr | adriancz: https://opendev.org/openstack/requirements/src/branch/master/upper-constraints.txt looks like the generated upper-constraints.txt is incorrect | 15:31 |
*** altlogbot_0 has quit IRC | 16:01 | |
*** irclogbot_2 has quit IRC | 16:02 | |
*** altlogbot_0 has joined #openstack-monasca | 16:02 | |
*** irclogbot_2 has joined #openstack-monasca | 16:04 | |
brtknr | adriancz: should get fixed when this merges: https://review.opendev.org/#/c/679916/2 | 16:06 |
*** irclogbot_2 has quit IRC | 16:07 | |
*** irclogbot_1 has joined #openstack-monasca | 16:08 | |
*** ivve has quit IRC | 16:19 | |
*** spsurya has quit IRC | 16:48 | |
*** witek has quit IRC | 16:54 | |
*** dougsz has quit IRC | 17:00 | |
*** adriancz has quit IRC | 17:06 | |
*** trident has quit IRC | 19:09 | |
*** trident has joined #openstack-monasca | 19:20 | |
*** joadavis has quit IRC | 20:37 | |
*** joadavis has joined #openstack-monasca | 20:46 | |
-openstackstatus- NOTICE: Gerrit is being restarted to pick up configuration changes. Should be quick. Sorry for the interruption. | 21:14 | |
*** sum12 has quit IRC | 22:14 | |
*** sum12 has joined #openstack-monasca | 22:16 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!