*** vishalmanchanda has joined #openstack-monasca | 00:21 | |
*** vishalmanchanda has quit IRC | 03:09 | |
*** johanssone has quit IRC | 03:52 | |
*** johanssone has joined #openstack-monasca | 03:53 | |
*** johanssone has quit IRC | 04:00 | |
*** johanssone has joined #openstack-monasca | 04:01 | |
*** vishalmanchanda has joined #openstack-monasca | 04:31 | |
*** piotrowskim has joined #openstack-monasca | 07:32 | |
*** witek_ has joined #openstack-monasca | 08:46 | |
*** dougsz has quit IRC | 08:52 | |
*** dougsz has joined #openstack-monasca | 09:15 | |
*** ivve has joined #openstack-monasca | 11:30 | |
*** jawad_axd has joined #openstack-monasca | 11:54 | |
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Change name of topic used to send alarm and alarm def events https://review.opendev.org/708335 | 11:55 |
---|---|---|
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Change name of topic used to send alarm and alarm def events https://review.opendev.org/708335 | 12:10 |
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Change name of topic used to send alarm and alarm def events https://review.opendev.org/708335 | 12:48 |
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Change name of topic used to send alarm and alarm def events https://review.opendev.org/708335 | 12:49 |
*** bandorf has joined #openstack-monasca | 12:59 | |
witek_ | #startmeeting monasca | 13:00 |
openstack | Meeting started Tue Feb 25 13:00:35 2020 UTC and is due to finish in 60 minutes. The chair is witek_. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:00 |
*** openstack changes topic to " (Meeting topic: monasca)" | 13:00 | |
openstack | The meeting name has been set to 'monasca' | 13:00 |
adriancz | Hello | 13:00 |
witek_ | hello everyone | 13:00 |
Dobroslaw | hi | 13:00 |
chaconpiza | Hello | 13:00 |
piotrowskim | hi | 13:01 |
witek_ | agenda for today: | 13:01 |
witek_ | https://etherpad.openstack.org/p/monasca-team-meeting-agenda | 13:01 |
witek_ | let's start | 13:01 |
dougsz | hi | 13:01 |
witek_ | #topic monasca-notification: drop YAML configuration support | 13:02 |
*** openstack changes topic to "monasca-notification: drop YAML configuration support (Meeting topic: monasca)" | 13:02 | |
witek_ | we've hit a bug this week in CI with monasca-notification not being able to start | 13:02 |
witek_ | because of CLI option yaml_config being wrongly declared | 13:03 |
witek_ | the bug was easy to fix, but that brings me to the point that it's actually long overdue to remove support for YAML config there | 13:04 |
witek_ | dougsz has started this work already | 13:04 |
witek_ | https://review.opendev.org/656769 | 13:04 |
chaconpiza | I understood that you left the option to use the yaml because of monasca-docker, right? | 13:05 |
witek_ | I wanted to just fix the existing code | 13:05 |
witek_ | but I think we should go one step further and remove deprecated code | 13:05 |
dougsz | Thanks for iterating on that patch witek | 13:06 |
witek_ | and yes, Docker deployment still relies on YAML config | 13:06 |
witek_ | there are also some other places marked for removal in that context but these are not that important | 13:08 |
adriancz | I agree with Witek we should remove deprecated code | 13:09 |
chaconpiza | +1 | 13:09 |
bandorf | +1 | 13:10 |
dougsz | +1, i already printed the yaml config and set fire to it | 13:10 |
witek_ | :) | 13:10 |
witek_ | not CO_2 friendly | 13:10 |
chaconpiza | :D | 13:11 |
dougsz | :D | 13:11 |
witek_ | who would like to take an action item to add support for oslo.config in Docker? | 13:11 |
piotrowskim | i can try | 13:13 |
piotrowskim | adrian told me he will help me at the begining :) | 13:13 |
witek_ | great, I think it should not be complicated | 13:13 |
witek_ | thanks | 13:13 |
dougsz | Thanks piotrowskim, I can review | 13:13 |
dougsz | Feel free to push changes to https://review.opendev.org/656769 and add yourself as co-author | 13:14 |
piotrowskim | ok | 13:14 |
witek_ | just for reference: | 13:15 |
witek_ | https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line | 13:15 |
witek_ | I guess we can move on? | 13:16 |
witek_ | #topic Updating alarm definitions | 13:16 |
*** openstack changes topic to "Updating alarm definitions (Meeting topic: monasca)" | 13:16 | |
chaconpiza | Similar to this bug: | 13:17 |
chaconpiza | https://storyboard.openstack.org/#!/story/2006750 | 13:17 |
chaconpiza | bandorf and Goetz found a bug (at least in stable/pike) when the alarm definition is updated. | 13:17 |
chaconpiza | More specific when the 'times' is updated in the expression | 13:18 |
chaconpiza | In this case it seems that the bug is not in monasca-api, but in the thresh | 13:18 |
chaconpiza | I read the kafka message (topic event) that thresh receives after the alarm-definition is updated | 13:19 |
chaconpiza | the parameters time and times were correct, but not updated | 13:20 |
chaconpiza | Right now I am trying to reproduce it in devstack (master branches) | 13:20 |
chaconpiza | I will create a similar Story in case of bug in master branch | 13:21 |
witek_ | I'm not sure, but it might be that this is documented not to be supported | 13:21 |
chaconpiza | Yes, I remember something about restrictions on update. | 13:22 |
chaconpiza | And the problem for final user is that it is not possible to create an alarm-definition in monasca-ui assigning parameters time and times | 13:23 |
chaconpiza | So, if the final user doesn't have access to CLI, he should create the alarm-def in the UI and then updated it | 13:24 |
chaconpiza | :( | 13:24 |
witek_ | yes, that workaround doesn't work, indeed | 13:25 |
bandorf | Witek, do you know where this has been documented? | 13:26 |
bandorf | This would finally mean that you can't handle alarm definitions using time/times can't be managed with the UI | 13:26 |
witek_ | not from the top of my head, api-spec or monasca-thresh repo | 13:27 |
witek_ | possibly it could be easier to extend the UI then fix thresh | 13:28 |
chaconpiza | +1 | 13:28 |
bandorf | The problem we found so far: The expression in the alarm-definition will be updated, but not the expression in the sub-alarm-definition. | 13:29 |
witek_ | https://github.com/openstack/monasca-api/blob/master/docs/monasca-api-spec.md#changing-alarm-definitions | 13:29 |
witek_ | that does not cover changing periods though | 13:30 |
bandorf | That's OK, we neither change match_by (not used in this case) nor the metric itself | 13:30 |
bandorf | Does anybody know where in thresh the updated of sub-alarm-definition should happen? | 13:31 |
bandorf | We can search as well, just maybe, somebody already knows. That would shorten our search... | 13:31 |
dougsz | Sorry, it's been a long time since I looked at it | 13:32 |
witek_ | not without looking into it, sorry | 13:33 |
bandorf | OK, thanks | 13:33 |
chaconpiza | maybe is arround to this point https://github.com/openstack/monasca-thresh/blob/master/thresh/src/main/java/monasca/thresh/infrastructure/thresholding/AlarmCreationBolt.java#L150 | 13:34 |
witek_ | seems plausible | 13:35 |
witek_ | let's move on | 13:35 |
witek_ | #topic Update events topic | 13:36 |
*** openstack changes topic to "Update events topic (Meeting topic: monasca)" | 13:36 | |
witek_ | adriancz works on merging events API | 13:36 |
witek_ | and proposed renaming the currently used topic in monasca-api | 13:37 |
witek_ | https://review.opendev.org/708335 | 13:37 |
adriancz | i still working on this change ( i need to update docker ) | 13:37 |
witek_ | I understand the motivation but I'm wondering about the impact | 13:38 |
bandorf | we would have to think about migration as well, right? | 13:38 |
adriancz | but this change is more like open discussion if we should change this name | 13:38 |
dougsz | hm, yeah, would be nice to avoid the migration challenge | 13:39 |
chaconpiza | so far the topic events is used in the metrics-pipeline to handle alarm-definitions-(creation, update and removal) | 13:39 |
witek_ | that's why I'm bringing it here up, to bring it to attention and share | 13:39 |
chaconpiza | what about the call the other events like external-events | 13:40 |
chaconpiza | or something like that | 13:40 |
chaconpiza | or openstack-events | 13:41 |
witek_ | I guess we don't have to decide anything now, just spend some time to think it over and leave your opinion in review | 13:41 |
bandorf | To be honest, it's really ugly to have a concept of "events", a kafka-topic named "events", and they are not related. | 13:42 |
witek_ | agree | 13:42 |
adriancz | +1 | 13:42 |
witek_ | do we want to continue the discussion in review or mailing list? | 13:43 |
dougsz | +1, will add review | 13:43 |
chaconpiza | +1 review | 13:44 |
witek_ | thanks | 13:44 |
witek_ | do we have anything else for today? | 13:44 |
bandorf | Not from me | 13:45 |
witek_ | testing auto-scaling has fixed itself on its own :) | 13:45 |
witek_ | https://review.opendev.org/700886 | 13:46 |
*** joadavis has joined #openstack-monasca | 13:46 | |
witek_ | hi joadavis, you made it :) | 13:46 |
witek_ | what time is it? | 13:47 |
witek_ | I think we should wrap up, thanks for joining | 13:47 |
witek_ | and see you next week | 13:48 |
witek_ | bye | 13:48 |
dougsz | bye all, thanks | 13:48 |
witek_ | #endmeeting | 13:48 |
*** openstack changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca" | 13:48 | |
adriancz | thanks | 13:48 |
adriancz | by | 13:48 |
openstack | Meeting ended Tue Feb 25 13:48:15 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 13:48 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-02-25-13.00.html | 13:48 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-02-25-13.00.txt | 13:48 |
openstack | Log: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-02-25-13.00.log.html | 13:48 |
Dobroslaw | thx | 13:48 |
chaconpiza | thanks, byt | 13:48 |
bandorf | Thanks, bye everybody | 13:48 |
joadavis | heh, well, I made it because my family woke me that our internet was failing. :P | 13:49 |
joadavis | <wave to all> | 13:49 |
adriancz | : ) | 13:49 |
*** bandorf has quit IRC | 13:50 | |
joadavis | (reading meeting log) | 13:51 |
joadavis | BTW, a change to expand the remove_config feature in monasca_setup is ready for reviews - https://review.opendev.org/#/c/623611/ | 13:57 |
*** witek_ has quit IRC | 14:05 | |
*** jawad_axd has quit IRC | 14:42 | |
*** jawad_axd has joined #openstack-monasca | 14:43 | |
*** jawad_axd has quit IRC | 14:43 | |
*** jawad_axd has joined #openstack-monasca | 14:45 | |
*** jawad_ax_ has joined #openstack-monasca | 14:48 | |
*** jawad_axd has quit IRC | 14:49 | |
*** jawad_ax_ has quit IRC | 14:52 | |
*** irclogbot_0 has quit IRC | 15:27 | |
*** johanssone has quit IRC | 15:27 | |
*** irclogbot_2 has joined #openstack-monasca | 15:28 | |
*** johanssone has joined #openstack-monasca | 15:29 | |
openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: [WIP] Merge events-api https://review.opendev.org/702875 | 15:53 |
*** jawad_axd has joined #openstack-monasca | 16:02 | |
*** jawad_axd has quit IRC | 16:06 | |
*** vishalmanchanda has quit IRC | 17:11 | |
*** ivve has quit IRC | 17:47 | |
*** dougsz has quit IRC | 18:07 | |
*** trident has quit IRC | 18:52 | |
*** trident has joined #openstack-monasca | 18:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!