openstackgerrit | Andreas Jaeger proposed openstack/monasca-api master: Add ujson requirement https://review.opendev.org/717956 | 05:46 |
---|---|---|
AJaeger | monasca-api is completly broken, see the change above as first step to fix - but now I'm stuck. Could anybody help, please? | 06:31 |
*** witek_ has joined #openstack-monasca | 07:48 | |
chaconpiza | Hi AJaeger, I will take a look | 08:20 |
*** witek_ is now known as witek | 08:32 | |
AJaeger | thanks chaconpiza | 08:35 |
openstackgerrit | Martin Chacon Piza proposed openstack/monasca-api master: Replacing ujson with simplejson https://review.opendev.org/718014 | 09:58 |
chaconpiza | AJaeger, thanks for your change. But we are already replacing ujson with simplejson. | 10:00 |
chaconpiza | http://lists.openstack.org/pipermail/openstack-discuss/2020-January/012285.html | 10:00 |
AJaeger | thanks, chaconpiza ! | 10:05 |
*** vishalmanchanda has joined #openstack-monasca | 10:40 | |
AJaeger | chaconpiza: now you could recheck if you want | 11:04 |
chaconpiza | thanks, I will prepare a second patch set | 11:08 |
*** dougsz has joined #openstack-monasca | 12:03 | |
chaconpiza | Courtesy Monasca meeting reminder in #openstack-monasca: witek, jayahn,iurygregory,ezpz,igorn,haad,sc,joadavis, akiraY,tobiajo,dougsz,fouadben, amofakhar, haru5ny (haruki),kaiokmo,pandiyan,guilhermesp,chaconpiza,hosanai,Wasaac,brtknr,bandorf | 12:57 |
chaconpiza | #startmeeting monasca | 13:00 |
openstack | Meeting started Tue Apr 7 13:00:29 2020 UTC and is due to finish in 60 minutes. The chair is chaconpiza. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:00 |
*** openstack changes topic to " (Meeting topic: monasca)" | 13:00 | |
openstack | The meeting name has been set to 'monasca' | 13:00 |
chaconpiza | Hello | 13:00 |
witek | hi everyone | 13:00 |
chaconpiza | Today's agenda as usual under this link https://etherpad.openstack.org/p/monasca-team-meeting-agenda | 13:01 |
dougsz | hi all | 13:01 |
adriancz | hi | 13:01 |
chaconpiza | bandorf and piotrowskim will be absent today, then we can start. | 13:02 |
chaconpiza | #topic Cleanup py27 support | 13:02 |
*** openstack changes topic to "Cleanup py27 support (Meeting topic: monasca)" | 13:02 | |
witek | AJaeger has provided a series of changes as part of dropping Py2 support story | 13:03 |
chaconpiza | AJaeger started but it seems that there are changes that need help | 13:03 |
witek | :) | 13:03 |
witek | go on | 13:03 |
chaconpiza | from the first filter https://review.opendev.org/#/q/(projects:openstack/monasca+OR+project:openstack/python-monascaclient)+topic:update-hacking | 13:04 |
chaconpiza | I see the 3 APIs require attention | 13:05 |
chaconpiza | sorry, the first filter is for the topic update-hacking | 13:06 |
witek | in monasca-api we have ripple effects with ujson -> simplejson | 13:07 |
witek | as we released monasca-common without ujson dependency already | 13:07 |
witek | in case of log-api and events I think CI was broken already before | 13:08 |
chaconpiza | We are talking about https://review.opendev.org/#/c/717555/ | 13:10 |
chaconpiza | and https://review.opendev.org/#/c/717553/ | 13:11 |
witek | right | 13:11 |
witek | I'd focus on other repos first and try to complete the json library migration | 13:13 |
chaconpiza | any volunteer? I will take a look on the related to the events-api https://review.opendev.org/#/c/717553/ | 13:13 |
witek | because there are apparently some corner cases where unit test fail | 13:13 |
chaconpiza | adriancz, would you check the one related to log-api? https://review.opendev.org/#/c/717555/ | 13:14 |
witek | I'll take persister changes then | 13:14 |
adriancz | i can check this | 13:14 |
chaconpiza | great | 13:15 |
chaconpiza | ok, if there isn't more to discuss lets go to the next point in the agenda | 13:17 |
chaconpiza | #topic Follow up ujson -> simplejson migration | 13:18 |
*** openstack changes topic to "Follow up ujson -> simplejson migration (Meeting topic: monasca)" | 13:18 | |
chaconpiza | So far, as witek mentioned, the ujson - simplejson replacement is done only in monasca-common | 13:19 |
chaconpiza | https://review.opendev.org/#/c/716925/ | 13:19 |
chaconpiza | Since we had the deadline for monasca-common release | 13:19 |
chaconpiza | Today AJaeger sent a change to add ujson in monasca-api, to mitigate that wave effect. | 13:21 |
chaconpiza | I sent a change for the replacement ujson-simplejson https://review.opendev.org/#/c/718014/ | 13:21 |
chaconpiza | Now I am not sure why it failed using the lower-constraints | 13:22 |
witek | apparently there are some small differences in the older simplejson version | 13:23 |
witek | e.g. \'{"test_body": "test"}\' != \'{"test_body":"test"}\'' | 13:24 |
chaconpiza | I though the same, but I am forcing to use the lower version==3.13.2 with python3.7 and it works in my VM | 13:24 |
witek | that's strange | 13:26 |
witek | I can reproduce running `tox -elower-constraints` | 13:27 |
chaconpiza | Probably I need to install something, I got ImportError: cannot import name 'Feature' with this command. | 13:28 |
chaconpiza | I forced the version simplejson==3.13.2 in requirements | 13:29 |
chaconpiza | to simulated the lower constraint's version | 13:30 |
chaconpiza | Ok, first I need to be able to run 'tox -elower-constraints' then fix the issue. All right :) | 13:30 |
witek | I'll look at the migration in persister repo | 13:31 |
witek | I've seen problems there as well | 13:31 |
witek | and we should use that occasion to drop the code for Python 2 | 13:31 |
chaconpiza | I used this topic https://review.opendev.org/#/q/topic:ujson-replacement+(status:open+OR+status:merged) | 13:32 |
witek | ok | 13:32 |
witek | we should create a story for this | 13:33 |
chaconpiza | I will create the story | 13:33 |
chaconpiza | Ok, then let's move to the next point | 13:34 |
chaconpiza | #topic Deadline last feature release python-monascaclient - April 9 | 13:34 |
*** openstack changes topic to "Deadline last feature release python-monascaclient - April 9 (Meeting topic: monasca)" | 13:34 | |
chaconpiza | I think there is not ujson in that repository | 13:35 |
witek | no, should be good | 13:35 |
witek | we still have some open changes in review though | 13:36 |
witek | dougsz: was there anything preventing us from merging your periodic notification changes? | 13:37 |
witek | I see the tempest test has failed on https://review.opendev.org/694596 on gate job for some reason | 13:38 |
witek | might just need a recheck | 13:38 |
dougsz | witek: Nothing apart from CI :) | 13:40 |
witek | :) | 13:40 |
dougsz | Will have a look later, thanks for prodding them. | 13:40 |
witek | let's try then to fix monasca-api CI, so that we can merge all changes from topic:periodic_notifications | 13:42 |
witek | and then release | 13:43 |
chaconpiza | ok | 13:43 |
chaconpiza | make sense to add priorities in the tickets heading the new python-monascaclient release? | 13:44 |
witek | we can mark them on reviews, yes | 13:45 |
chaconpiza | cool | 13:45 |
chaconpiza | all right, then the end: | 13:46 |
chaconpiza | #topic aob | 13:46 |
*** openstack changes topic to "aob (Meeting topic: monasca)" | 13:46 | |
witek | I'd like to propose adding chaconpiza to the core team | 13:46 |
chaconpiza | +1 ;) | 13:47 |
witek | :) | 13:47 |
witek | no objections, that's good :) | 13:47 |
chaconpiza | Changing the topic, in the deploy of monasca using docker containers | 13:48 |
chaconpiza | the Grafana container has a docker health check | 13:48 |
chaconpiza | which basically executes wget -q http://localhost:3000 -O - > /dev/null | 13:49 |
openstackgerrit | Keith Berger proposed openstack/monasca-agent master: Add a new config variable to identify ping command https://review.opendev.org/717402 | 13:50 |
chaconpiza | well, it seems that this continues checks increments the size of the grafana/data/sessions | 13:50 |
chaconpiza | without to release it at any time | 13:50 |
chaconpiza | at least using Grafana 4.5 | 13:51 |
chaconpiza | We are investigating it and we will reported it here | 13:52 |
witek | where is grafana/data/sessions stored? Grafana DB? | 13:53 |
chaconpiza | we use 'files' for that. | 13:53 |
chaconpiza | https://grafana.com/docs/grafana/v4.5/installation/configuration/#session | 13:54 |
witek | I see | 13:55 |
witek | the option has been removed in 6.2 | 13:56 |
chaconpiza | :) | 13:56 |
chaconpiza | Ok, we are running out of time. | 13:57 |
witek | thanks chaconpiza | 13:57 |
chaconpiza | Thanks all | 13:57 |
witek | and adriancz and dougsz | 13:58 |
witek | happy Easter all! | 13:58 |
chaconpiza | Happy Easter! | 13:58 |
witek | bye | 13:58 |
dougsz | You too all, sorry I couldn't fully engage today | 13:58 |
chaconpiza | bye | 13:58 |
dougsz | bye | 13:59 |
witek | no worries, take care | 13:59 |
chaconpiza | #endmeeting | 13:59 |
*** openstack changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca" | 13:59 | |
openstack | Meeting ended Tue Apr 7 13:59:12 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 13:59 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-07-13.00.html | 13:59 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-07-13.00.txt | 13:59 |
openstack | Log: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-07-13.00.log.html | 13:59 |
*** mensis has joined #openstack-monasca | 13:59 | |
mensis | Hello, i'm trying to install Monasca in devstack. When i check '/var/log/monasca/agent/collector.log', i get the following errors http://paste.openstack.org/show/791737/ it seems like it cannot connect to kafka broker, but when i check kafka it's working properly. Any suggestions please? | 14:04 |
openstackgerrit | Keith Berger proposed openstack/monasca-agent master: Remove incorrect assignment of ping_cmd to 'True' https://review.opendev.org/717402 | 14:30 |
witek | mensis: I think that's a bug in Kafka plugin, you can test the rest though | 14:35 |
mensis | When i check the Monitoring panel in Horizon, i dont see anything. Also when i go to 'Alarm Definitions' panel i get 'Could not retrieve alarm definitions' and if i try to create alarm definition i get 'unable to retrieve notifications ınternal server error http 500' 'unable to retrieve metrics' errors | 14:40 |
witek | make sure to change to the monitoring project, Monasca is multi-tenant | 14:41 |
witek | mini-mon/password | 14:42 |
mensis | thanks i did not know that, i log into mini-mon user and i still get the same error | 14:51 |
witek | are you in the monitoring project? | 15:22 |
*** witek has quit IRC | 16:42 | |
*** dougsz has quit IRC | 17:05 | |
*** mensis has quit IRC | 17:20 | |
*** dougsz has joined #openstack-monasca | 17:21 | |
*** dougsz has quit IRC | 17:22 | |
*** vishalmanchanda has quit IRC | 17:47 | |
*** dougsz has joined #openstack-monasca | 18:45 | |
openstackgerrit | Keith Berger proposed openstack/monasca-agent master: Do not copy /sbin/ip to /usr/bin/monasa-agent-ip https://review.opendev.org/718195 | 19:21 |
*** dougsz has quit IRC | 20:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!