| open10k8s | Hi team, can i get review on https://review.opendev.org/c/openstack/monasca-ui/+/812255? Thanks. | 08:45 |
|---|---|---|
| opendevreview | Merged openstack/monasca-ui master: Convert dimension value type from byte to str in MonascaProxyView https://review.opendev.org/c/openstack/monasca-ui/+/812255 | 08:52 |
| open10k8s | Hi team, I Cherry-picked for stable/wallaby https://review.opendev.org/c/openstack/monasca-ui/+/812314. can you review this also? thanks. | 10:42 |
| open10k8s | btw, once this is merged to wallaby, how can i get this change in the monitoring(pip) package when i install horizon? | 10:43 |
| chaconpiza | Hi Oleksandr (open10k8s) Thanks for your contributions. | 11:21 |
| chaconpiza | Lower-constraints check from this change https://review.opendev.org/c/openstack/monasca-ui/+/812314 will timeout. I already rebase your change on top of this other change https://review.opendev.org/c/openstack/monasca-ui/+/812315 | 11:23 |
| chaconpiza | let's wait ;-) | 11:23 |
| open10k8s | chaconpiza: Thanks. Btw, i found that https://review.opendev.org/c/openstack/monasca-ui/+/812320 just has been merged and it is the same purpose. | 13:05 |
| open10k8s | But i think it would be good to have a condition check before urllib.parse? How about your opinion? | 13:06 |
| chaconpiza | Yes, I agree | 13:07 |
| chaconpiza | thanks | 13:07 |
| open10k8s | :thumbsup: | 13:09 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!