*** vthapar has joined #openstack-net-bgpvpn | 07:31 | |
*** matrohon has joined #openstack-net-bgpvpn | 08:13 | |
vthapar | matrohon, morning! | 08:18 |
---|---|---|
matrohon | vthapar, hi | 08:21 |
vthapar | matrohon, was working on the precommit code. noticed we don't have any exceptions class(es). | 08:26 |
matrohon | vthapar, I've added an exception class for driver's error | 08:26 |
matrohon | vthapar, you can also create your own classes | 08:27 |
vthapar | matrohon, okay. the one you added is a generic driver error. can I add custom string to provide relevant information to user? | 08:29 |
*** tmorin has joined #openstack-net-bgpvpn | 08:43 | |
openstackgerrit | Vishal Thapar proposed openstack/networking-bgpvpn: ODL: Add precommit to create/update_bgpvpn https://review.openstack.org/296289 | 09:01 |
*** openstackgerrit has quit IRC | 09:03 | |
*** openstackgerrit has joined #openstack-net-bgpvpn | 09:04 | |
tmorin | matrohon: salut ! have you investigated what fails for the gate job of https://review.openstack.org/#/c/295849/ ? | 09:16 |
matrohon | tmorin : not yet, I want to complete precommit patch first | 09:17 |
tmorin | ok | 09:19 |
tmorin | I've spent a few minutes, but I can't even find where are the logs for tempest tests :) | 09:19 |
matrohon | so th eplan is to try to have those tests running before adding enikher's patch that add tempest job to project-config? | 09:21 |
matrohon | tmorin, ^ | 09:21 |
tmorin | it does not really matter | 09:22 |
tmorin | we could add enikher's job even if it is not working yet | 09:22 |
tmorin | because this is only experimental | 09:22 |
tmorin | enikher's change requires a few fixes, but apart from that we could merge it | 09:23 |
tmorin | as I see it, 295849 is in the meantime a kind of playground to fix what will have to be fixed for tempest test to run fine | 09:24 |
matrohon | that's how I saw it too | 09:25 |
*** vthapar has quit IRC | 11:04 | |
*** tmorin has quit IRC | 11:47 | |
*** tmorin has joined #openstack-net-bgpvpn | 13:14 | |
openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Add precommit hooks for create_bgpvpn_net/router_assoc https://review.openstack.org/296439 | 13:35 |
*** openstack has joined #openstack-net-bgpvpn | 14:23 | |
openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Enabling tempest tests in our jobs https://review.openstack.org/295849 | 14:39 |
openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Test tempest-dsvm-networking-bgpvpn-bagpipe job https://review.openstack.org/296515 | 14:58 |
tmorin | matrohon: sorry, I was away | 15:40 |
tmorin | except net-ovn and neutron-lbaas maybe, I didn't look much around to see the kind of things people do in these rcfiles | 15:40 |
matrohon | tmorin : I triggered some gate jobs todays | 15:42 |
matrohon | tmorin : It looks like our rc files don't work as expected | 15:42 |
matrohon | tmorin, we can see that OVERRIDE_ENABLED_SERVICES is not taken into account | 15:43 |
tmorin | the ovn job do set OVERRIDE_ENABLED_SERVICES in their rcfiles | 15:44 |
matrohon | tmorin, I know, I had a look at it, but something goes wrong for us | 15:45 |
matrohon | tmorin, http://logs.openstack.org/49/295849/3/experimental/gate-install-dsvm-networking-bgpvpn/ca4351a/logs/devstacklog.txt.gz#_2016-03-23_15_00_58_840 | 15:45 |
matrohon | tmorin : it works fine for ovn... http://logs.openstack.org/39/275439/2/check/gate-tempest-dsvm-networking-ovn/1de1142/logs/devstacklog.txt.gz#_2016-02-04_20_58_43_804 | 15:53 |
tmorin | I'm wondering if the reason could be the fact that we do not have the pre_test_hook.sh and post_test_hook.sh | 16:00 |
matrohon | I just commented enikher's patch this way | 16:01 |
matrohon | https://review.openstack.org/#/c/258522/3 | 16:01 |
matrohon | tmorin, gtg, submit the change if you want | 16:01 |
matrohon | otherwise I'll do it later | 16:02 |
tmorin | which change ? | 16:02 |
matrohon | https://review.openstack.org/#/c/258522/3 | 16:02 |
matrohon | I will add some test to see if file exists in this patch | 16:02 |
tmorin | it's better/easier to add the pre/post_test_hook.sh files in our repo | 16:03 |
tmorin | easier than havnig a change reviewed by infra | 16:03 |
matrohon | you can give it a try | 16:03 |
matrohon | gtg, ciao | 16:03 |
tmorin | keeping in mind the following comment from dougwig: https://review.openstack.org/#/c/291103/3/jenkins/jobs/networking-bgpvpn.yaml@39 | 16:04 |
*** matrohon has quit IRC | 16:09 | |
openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: Test tempest-dsvm-networking-bgpvpn-bagpipe job https://review.openstack.org/296515 | 16:12 |
*** openstack has joined #openstack-net-bgpvpn | 19:22 | |
*** openstack has joined #openstack-net-bgpvpn | 20:32 | |
*** tmorin has quit IRC | 20:57 | |
*** matrohon has joined #openstack-net-bgpvpn | 21:06 | |
*** matrohon has quit IRC | 21:49 | |
*** matrohon has joined #openstack-net-bgpvpn | 21:50 | |
*** matrohon has quit IRC | 22:12 | |
*** openstack has joined #openstack-net-bgpvpn | 23:23 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!