Wednesday, 2015-10-21

openstackgerritChandra Sekhar Vejendla proposed openstack/networking-ovn: This patch set adds support for add/delete router interfaces. Adding router port involves:     - Create row in logical_router_port table     - Update the ports in logical_router table with the     logical_router_port added above     - Update the options c  https://review.openstack.org/23782000:04
openstackgerritChandra Sekhar Vejendla proposed openstack/networking-ovn: This patch set adds support for add/delete router interfaces. Adding router port involves:     - Create row in logical_router_port table     - Update the ports in logical_router table with the     logical_router_port added above     - Update the options c  https://review.openstack.org/23782000:14
*** yamamoto has joined #openstack-neutron-ovn00:23
*** chandrav has quit IRC00:26
openstackgerritRussell Bryant proposed openstack/networking-ovn: Add security group support using OVN ACLs.  https://review.openstack.org/22381700:33
*** yamamoto has quit IRC00:42
*** chandrav has joined #openstack-neutron-ovn00:44
*** azbiswas has joined #openstack-neutron-ovn00:57
*** azbiswas has quit IRC00:59
*** carl_baldwin has quit IRC01:07
*** BB has quit IRC01:14
*** chandrav has quit IRC01:25
*** salv-orlando has joined #openstack-neutron-ovn01:32
*** gangil has quit IRC01:39
*** yamamoto has joined #openstack-neutron-ovn01:42
*** chandrav has joined #openstack-neutron-ovn01:43
*** chandrav has quit IRC01:44
*** chandrav has joined #openstack-neutron-ovn01:45
*** salv-orlando has quit IRC01:46
*** yamamoto has quit IRC01:48
*** yamamoto has joined #openstack-neutron-ovn02:30
*** carl_baldwin has joined #openstack-neutron-ovn03:05
*** gangil has joined #openstack-neutron-ovn03:11
*** gangil has joined #openstack-neutron-ovn03:11
*** carl_baldwin has quit IRC03:19
*** cascardo has quit IRC03:21
*** carl_baldwin has joined #openstack-neutron-ovn03:22
*** salv-orlando has joined #openstack-neutron-ovn03:45
*** salv-orlando has quit IRC03:55
*** carl_baldwin has quit IRC04:20
openstackgerritChandra Sekhar Vejendla proposed openstack/networking-ovn: Add/delete router interfaces  https://review.openstack.org/23782004:31
*** azbiswas has joined #openstack-neutron-ovn04:46
*** salv-orlando has joined #openstack-neutron-ovn05:13
*** openstackgerrit has quit IRC05:16
*** openstackgerrit has joined #openstack-neutron-ovn05:17
*** salv-orlando has quit IRC05:19
*** armax has quit IRC06:32
*** salv-orlando has joined #openstack-neutron-ovn06:46
*** azbiswas has quit IRC07:10
*** salv-orlando has quit IRC07:46
*** asuvvari has joined #openstack-neutron-ovn08:03
*** asuvvari has quit IRC08:07
*** openstackgerrit has quit IRC09:01
*** openstackgerrit has joined #openstack-neutron-ovn09:01
*** openstackgerrit has quit IRC09:31
*** openstackgerrit has joined #openstack-neutron-ovn09:32
*** salv-orlando has joined #openstack-neutron-ovn09:36
*** fzdarsky has joined #openstack-neutron-ovn09:40
*** salv-orlando has quit IRC09:59
*** asuvvari has joined #openstack-neutron-ovn10:07
*** asuvvari has quit IRC10:12
*** chandrav has joined #openstack-neutron-ovn10:21
*** salv-orlando has joined #openstack-neutron-ovn10:27
*** salv-orlando has quit IRC10:40
*** chandrav has quit IRC11:27
*** salv-orlando has joined #openstack-neutron-ovn11:30
*** thumpba has joined #openstack-neutron-ovn11:55
*** openstackgerrit has quit IRC12:16
*** openstackgerrit has joined #openstack-neutron-ovn12:17
*** yamamoto has quit IRC12:21
*** flaviof is now known as flaviof_12:23
*** thumpba has quit IRC12:30
*** chandrav has joined #openstack-neutron-ovn12:39
*** thumpba has joined #openstack-neutron-ovn12:47
*** cascardo has joined #openstack-neutron-ovn12:48
*** salv-orlando has quit IRC12:53
*** salv-orlando has joined #openstack-neutron-ovn13:07
*** yamamoto has joined #openstack-neutron-ovn13:14
*** mestery has quit IRC13:16
*** mestery has joined #openstack-neutron-ovn13:29
*** chandrav has quit IRC13:32
*** subscope has joined #openstack-neutron-ovn13:43
*** subscope has quit IRC13:44
*** gsagie_ has joined #openstack-neutron-ovn13:50
*** njohnston is now known as nate_gone14:32
*** asuvvari has joined #openstack-neutron-ovn14:33
*** nate_gone is now known as njohnston14:34
openstackgerritRussell Bryant proposed openstack/networking-ovn: Add security group support using OVN ACLs.  https://review.openstack.org/22381714:42
*** yamamoto has quit IRC14:46
*** cascardo has quit IRC14:47
*** carl_baldwin has joined #openstack-neutron-ovn15:02
*** gangil has quit IRC15:07
*** yamamoto has joined #openstack-neutron-ovn15:09
mesteryYo russellb! Just got my keynote demo to work using Neutron, OVN, Kuryr and docker :)15:11
mesteryFirst time, thanks to gsagie and team for the help ;)15:11
russellb:-D15:11
russellbawesome!!15:11
mesteryyup15:12
russellbDON'T TOUCH IT15:12
russellbNOBODY MOVE15:12
mesterylol15:12
*** regXboi has joined #openstack-neutron-ovn15:12
russellbcongrats :)15:12
mesteryCan I carry the laptop to tokyo in it's currently powered on state you think? ;)15:12
* mestery to TSA agent15:12
mesteryYOU DON'T UNDERSTAND, IT'S FOR A KEYNOTE DEMO!15:12
russellbheh, totally15:13
russellbroll a gas powered generator through TSA as well15:13
russellbI CAN'T LET THIS LAPTOP RUN OUT OF POWER15:13
russellbanyway yay :)15:14
* russellb has fingers crossed on the next security groups tempest run ... sigh15:14
mesteryrofl15:15
mesteryYeah, I'm sending good thoughts your way too for your demo15:15
russellbyou're on stage too15:17
russellband the title says "feature complete and ready to test" lol15:17
mesteryhahahahahaha :)15:17
mesteryWell15:17
mesteryit'll all work15:17
mesteryTrust us15:17
mesterywe're professionals!15:17
russellbtotally15:17
russellbidea: system that lets you add $ to an account that helps fund capacity for openstack infra, that on deposit, increases priority of your current jobs15:18
russellbi'd pay to not have jobs sit in a queue :)15:19
russellband just like that, it starts!15:19
*** azbiswas has joined #openstack-neutron-ovn15:29
*** yamamoto_ has joined #openstack-neutron-ovn15:29
*** armax has joined #openstack-neutron-ovn15:29
*** yamamoto has quit IRC15:32
*** cascardo has joined #openstack-neutron-ovn15:34
*** cascardo has quit IRC15:43
*** cascardo has joined #openstack-neutron-ovn15:45
azbiswasrussellb: The gate-tempest-dsvm-networking-ovn tests are failing for the router add/delete when ssh or ping is attempted to a floating ip.15:52
*** gsagie_ has quit IRC15:55
azbiswasgsagie: We will incorporate your comments.15:57
azbiswasThe question is whether we need to fix the fip l3 communication issues before the commit15:58
russellbazbiswas: once we start using OVN's L3 support, I'm not sure if we can use the L3 agent anymore, i wouldn't be surprised if that doesn't work16:00
russellband we don't have NAT / floating IP support yet for OVN's L3 support16:01
russellbso I suppose that's expected to fail at the moment16:01
azbiswasso we ignore those failures for now?16:01
russellbwe're supposed to have code for that this week though16:01
azbiswasright16:01
russellbyes for now16:01
russellbi'm sure that's a lot of failures though16:02
azbiswas7 in the gate16:02
*** chandrav has joined #openstack-neutron-ovn16:02
azbiswassurprisingly low16:02
russellbwow...16:02
russellbdoes seem low16:02
azbiswaschandrav: I was just giving russellb the update about the failures in the gate16:02
russellbbut you can just update devstack/devstackgaterc with rules to skip those tests for now16:02
azbiswasif it's consistent failures - yes we will turn them off16:04
russellbi also turned voting off for the tempest job temporarily16:04
russellbok sounds good16:04
chandravrusselb: I am not sure all the tests fail consistently, some are random16:04
russellbi turned voting off because i expect we're going to have a rough time trying to migrate to all of these new features16:04
chandravso even if i turn off some, there might be other failures.16:04
russellbso we can merge patches with failures if we want16:05
russellbok16:05
chandravbut i'll turn off the ones that fail consistently16:05
azbiswasI wonder if gsagie is around - he had some comments about if_exists16:05
*** gsagie_ has joined #openstack-neutron-ovn16:10
*** cascardo has quit IRC16:12
azbiswasgsagie_: question about the if_exists variable16:15
gsagie_azbiswas: ?16:16
azbiswasgsagie_: I agree about the if_exists comment in SetLogicalPortCommand(BaseCommand):16:17
azbiswasmy question was about class AddLRouterPortCommand(BaseCommand):16:17
azbiswasare you saying we shouldn't suppress failure in this case either?16:18
gsagie_azviswas: i think so16:18
gsagie_azbiswas16:18
gsagie_first, there is no if_exists in this class16:18
azbiswasthat's a mistake :)16:18
gsagie_its called there "may_exists"16:18
azbiswasyes16:18
gsagie_But, usually these are referring to the actual object that you are creating/setting, meaning in this case the logical router port, if you are trying to add logical router port to an router which doesnt exists, i think we want to see this error16:19
gsagie_The if_exists there suppose to be that the router port might already be there16:20
gsagie_Its not "that important" but its better to keep this consistent i think16:20
azbiswasgsagie_: I understand, I was looking at the incorrect object16:20
azbiswasyour comment is correct16:21
azbiswasthanks16:21
azbiswaswe will may the changes, merge and re-submit16:21
chandravgsagie_: for the SetLogicalPortCommand, in the calling function i set if_exists=False, so it should throw an error16:22
azbiswasI think if_exists is associated with the port16:23
russellbtempest passed on https://review.openstack.org/#/c/223817/25 \o/16:23
azbiswasnot the router port16:23
azbiswasrussellb: that's pretty cool!16:23
*** flaviof_ is now known as flaviof16:23
gsagie_azbiswas : yes, thats my way of looking at it anyway but i am open for other opinions as well16:24
gsagie_Flavio.. :) you coming to Tokyo i hope?16:24
*** cascardo has joined #openstack-neutron-ovn16:25
gsagie_flaviof16:25
russellbwho wants to review security group support?  :)16:26
russellbarosen said it looked good to him once tempest passed..16:26
chandravgsagie_: regarding your other comment about the else part in SetLogicalPortCommand. when a interface is added to a router, we are trying to set only the options column of that port. other columns should already have been set.16:26
gsagie_chandrav : thats fine, but there is no need for the else, it will have the same effect if the columns is empty (which it is by default)16:27
chandravsure16:27
azbiswasrussellb: we were just have a discussion about if_exists in router context, so I have a question about class DelACLCommand(BaseCommand): - why are we suppressing error if lswitch doesn't exist16:31
azbiswasand if_exists is set16:31
russellbwhy?16:32
russellbi dunno, that's what if_exists does elsewhere right?16:32
* russellb reads scrollback16:33
russellbah, i see16:33
azbiswaswe were just discussing that if_exists should be associated with the actual object being added/deleted16:33
russellbyeah i guess it's a little weird16:33
azbiswasdoes that count as a review? :)16:34
russellbin my case, it's honestly mainly copy/paste i didn't think about it much16:34
russellbyes!16:34
russellbthough i'm afraid to touch it after it worked once :-p16:34
gsagie_azbiswas: you can offer a fixing patch after the router one :)16:34
azbiswassure :)16:35
*** chandrav has quit IRC16:39
azbiswasrussellb: When are you planning on merging the ACL patch, we may have to merge the router work on top of this patch.16:42
*** chandrav has joined #openstack-neutron-ovn16:43
russellbazbiswas: hopefully they don't conflict too bad :/16:43
russellbi *think* it's ready to merge onw16:43
russellbnow16:43
azbiswasok we will pick it up then16:43
russellbi can help resolve conflicts if it merges first16:43
russellbgsagie_: any chance you have some time to look over the security groups patch?16:44
gsagie_russellb: sure16:44
russellbOK, be gentle ;)16:44
*** arosen has joined #openstack-neutron-ovn16:51
*** cascardo has quit IRC16:54
*** cascardo has joined #openstack-neutron-ovn16:55
*** gsagie_ has quit IRC17:07
*** BB has joined #openstack-neutron-ovn17:09
*** yamamoto_ has quit IRC17:17
*** salv-orl_ has joined #openstack-neutron-ovn17:18
arosenrussellb:  Nice work on the security groups stuff! I just manually tested several things and the dataplane bits also worked :) Even the removal of rules worked too (which I figured they would since tempest passes ;) )17:20
russellbarosen: thanks for testing!17:20
russellbi've gained some more grey hairs over it in the last week17:20
*** salv-orlando has quit IRC17:21
russellbi know there's more i could do, like unit tests17:21
russellband there's some tempest stuff still to figure out17:21
russellbbut seems like a good milestone that it mostly works17:21
russellbnow i want to test the L3 work on top of it17:22
arosenyea i agree. I think getting lots of the logic in there now is a great starting point to start building off of.17:22
arosenovn native l3?17:22
russellbyeah17:23
russellbit doesn't have NAT yet though17:23
arosenah right, Justin/Ben were telling me about that a couple weeks ago.17:23
russellbthey're cooking something up though17:24
*** yamamoto has joined #openstack-neutron-ovn17:25
russellb... but for now, COFFEE.17:27
russellbarosen: we still get this a lot: u'SAVEPOINT sa_savepoint_1 does not exist17:31
russellbarosen: weren't you chasing that?  seemed like an oslo.db bug or something?17:31
*** flaviof is now known as flaviof_17:31
flaviof_gsagie: hey17:32
flaviof_gsagie: Tokyo, yeah!17:32
*** njohnston is now known as nate_gone17:34
russellbsomeone has draft patches for native distributed DHCP, as well :)17:36
arosenYea,,, I was...I think it's a race where a network is deleted at the same time as the dhcp-agent is creating it's port and we are raising here in the plugin: https://github.com/openstack/networking-ovn/blob/master/networking_ovn/plugin.py#L429 but we never see the trace because of some weird transaction handing/oslo.db stuff from the create-port call coming in on the dhcp-rpc interface :(17:36
russellbah, well how about we just drop the dhcp agent then?  :)17:36
arosenwe see this same savepoint error in the vmware plugin  logs too. I think it's the same issue there.17:36
russellbwip, but https://github.com/numansiddique/ovs/pull/1/files17:37
arosenhow does this change the ovsdb schema?17:38
arosenDo we just configure the dhcp-addresses as part of the port in ovsdb/17:38
russellbyes17:38
russellblet me look at his email for detalis..17:38
russellb"If you want to test it, you can set the netmask and router ip as17:39
russellb$sudo ovn-nbctl lport-set-options <LPORT_UUID> dhcp_opt_netmask=255.255.255.0 dhcp_opt_router=10.0.0.1 "17:39
russellband i guess it gets the address to respond with from the addresses column on logical port17:39
russellbi haven't looked closely yet17:39
russellbmay need some more config to make it a little more flexible17:40
russellbi was just excited to see the progress17:40
arosenyea me too. I think it's awesome to see a plugin provide native dhcp support.17:42
*** asuvvari has quit IRC17:43
arosenWe've been dreaming of having this for all the vmw backends for a while now but haven't gotten it.17:43
*** asuvvari has joined #openstack-neutron-ovn17:43
*** nate_gone is now known as njohnston17:45
*** salv-orl_ has quit IRC17:45
*** asuvvari has quit IRC17:48
*** asuvvari has joined #openstack-neutron-ovn17:51
*** mestery has quit IRC17:52
*** yamamoto has quit IRC17:55
*** azbiswas has quit IRC17:58
chandravrussellb: is there a way to force jenkins check to run couple of times ?18:03
russellbchandrav: after it finishes, you can leave a comment that says "recheck"18:04
russellbif you want it to run multiple times in parallel, you have to post multiple patches18:04
russellbyou could post the same patch a few times with different Change-Id headers to do that ...18:04
chandrava comment with recheck will run jenkins job again ?18:05
russellbyes18:05
chandravthats easy, thx :)18:05
russellbi've also got a patch to disable some jenkins jobs to make it go a little faster, i'll go ahead and post it18:05
russellbthough don't wait on it18:05
openstackgerritRussell Bryant proposed openstack/networking-ovn: Add security group support using OVN ACLs.  https://review.openstack.org/22381718:06
openstackgerritRussell Bryant proposed openstack/networking-ovn: Exclude some more tempest tests.  https://review.openstack.org/23819718:06
chandravok18:06
russellbarosen: lost your +2, but the only change was adding TODOs to the devstack plugin to fix the git repo, and rebasing on the patch to disable a bunch of unrelated tests18:06
*** gangil has joined #openstack-neutron-ovn18:11
*** gangil has joined #openstack-neutron-ovn18:11
russellbchandrav: would you like me to rebase on top of the security groups patch?  or do you have some local changes you're working on?18:14
russellbi started doing it locally anyway because i was going to test it...18:14
russellbbut haven't gone very far18:14
chandravi am working on some changes18:14
russellbok18:15
russellblet me know if i can help :)18:15
*** mestery has joined #openstack-neutron-ovn18:20
*** salv-orlando has joined #openstack-neutron-ovn18:25
*** thumpba has quit IRC18:34
*** yamamoto has joined #openstack-neutron-ovn18:55
*** fzdarsky has quit IRC18:58
*** yamamoto has quit IRC19:00
openstackgerritMerged openstack/networking-ovn: Exclude some more tempest tests.  https://review.openstack.org/23819719:10
*** fzdarsky has joined #openstack-neutron-ovn19:13
*** gangil has quit IRC19:23
*** azbiswas has joined #openstack-neutron-ovn19:26
*** azbiswas_ has joined #openstack-neutron-ovn19:27
*** azbiswas has quit IRC19:30
*** thumpba has joined #openstack-neutron-ovn19:35
*** thumpba has quit IRC19:41
*** fzdarsky has quit IRC19:41
*** gangil has joined #openstack-neutron-ovn20:18
*** gangil has joined #openstack-neutron-ovn20:18
*** salv-orlando has quit IRC20:22
*** shettyg has joined #openstack-neutron-ovn20:28
*** salv-orlando has joined #openstack-neutron-ovn20:50
openstackgerritMerged openstack/networking-ovn: Add security group support using OVN ACLs.  https://review.openstack.org/22381720:54
* russellb gasps20:55
*** salv-orlando has quit IRC20:55
russellbchandrav: azbiswas_ note that after that patch has gone in ^^^ you'll have to make sure your devstack environment is using the right ovs branch that includes the conntrack kernel backports20:55
russellbthe devstack plugin handles it automatically, but only if /opt/stack/ovs doesn't exist20:56
russellbso you may have to manually update your ovs tree, or just delete it and let it get re-created20:56
azbiswas_russellb: That's what we have been doing21:03
russellbok great, just wanted to make sure :)21:03
*** regXboi has quit IRC21:20
*** azbiswas_ is now known as azbiswas21:40
*** BB has quit IRC21:46
*** flaviof_ is now known as flaviof21:46
*** carl_baldwin has quit IRC22:06
*** thumpba has joined #openstack-neutron-ovn22:07
*** salv-orlando has joined #openstack-neutron-ovn22:22
*** asuvvari has quit IRC22:27
*** asuvvari has joined #openstack-neutron-ovn22:28
*** asuvvari has quit IRC22:32
*** thumpba has quit IRC22:38
*** salv-orlando has quit IRC22:40
*** thumpba_ has joined #openstack-neutron-ovn22:42
*** asuvvari has joined #openstack-neutron-ovn22:44
*** thumpba_ has quit IRC22:44
*** asuvvari has quit IRC22:48
*** thumpba has joined #openstack-neutron-ovn22:48
shettygSent in a RFC for k8 + ovn + openstack integration. I validated the design with a huge k8 + OpenStack user today and it looks like it passes the sniff test.22:53
*** otherwiseguy has quit IRC22:53
*** thumpba has quit IRC22:55
*** thumpba has joined #openstack-neutron-ovn22:58
*** thumpba has quit IRC23:04
*** otherwiseguy has joined #openstack-neutron-ovn23:11
*** yamamoto has joined #openstack-neutron-ovn23:18
openstackgerritChandra Sekhar Vejendla proposed openstack/networking-ovn: Add/delete router interfaces  https://review.openstack.org/23782023:19
*** yamamoto has quit IRC23:26
*** salv-orlando has joined #openstack-neutron-ovn23:37
*** yamamoto has joined #openstack-neutron-ovn23:55
*** salv-orlando has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!