Monday, 2013-12-30

*** vkozhukalov has joined #openstack-neutron00:10
*** networkstatic has joined #openstack-neutron00:13
*** harlowja_away is now known as harlowja00:31
*** harlowja is now known as harlowja_away00:32
*** vkozhukalov has quit IRC00:40
*** dims has quit IRC01:02
*** dims has joined #openstack-neutron01:03
*** banix has joined #openstack-neutron01:12
*** layer427expert has joined #openstack-neutron01:12
*** dave_tucker is now known as dave_tucker_zzz01:32
*** banix has quit IRC01:32
*** nati_ueno has joined #openstack-neutron01:55
*** clev has joined #openstack-neutron02:36
*** markwash has joined #openstack-neutron02:39
*** nati_ueno has quit IRC03:07
*** nati_ueno has joined #openstack-neutron03:09
*** clev has quit IRC03:16
*** networkstatic has quit IRC03:42
*** networkstatic has joined #openstack-neutron03:42
*** dguitarbite_ has joined #openstack-neutron03:45
*** mrsnivvel has joined #openstack-neutron04:11
*** Mierdin has joined #openstack-neutron04:18
*** harlowja_away has quit IRC04:27
*** ashaikh has joined #openstack-neutron04:59
*** mrsnivvel has quit IRC05:00
*** mrsnivvel has joined #openstack-neutron05:01
*** mrsnivvel has quit IRC05:02
*** mrsnivvel has joined #openstack-neutron05:03
*** chandankumar has joined #openstack-neutron05:03
*** chandankumar has quit IRC05:25
*** markwash has quit IRC05:34
openstackgerritDazhao Yu proposed a change to openstack/neutron: Calculate stateless IPv6 address  https://review.openstack.org/5618405:42
*** markwash has joined #openstack-neutron05:49
*** ashaikh has quit IRC05:58
*** ashaikh has joined #openstack-neutron06:03
*** markwash has quit IRC06:25
*** yfried has joined #openstack-neutron06:26
*** ashaikh has quit IRC06:34
openstackgerritJenkins proposed a change to openstack/neutron: Imported Translations from Transifex  https://review.openstack.org/6387706:36
*** sc68cal has quit IRC06:38
*** ashaikh has joined #openstack-neutron06:52
*** garyk has joined #openstack-neutron07:03
*** sc68cal has joined #openstack-neutron07:13
*** sc68cal has quit IRC07:15
openstackgerritA change was merged to openstack/neutron: Add post-mortem debug option for tests  https://review.openstack.org/4377607:27
*** irenab_ has joined #openstack-neutron07:28
*** ashaikh has quit IRC07:32
*** nati_ueno has quit IRC07:39
*** nati_ueno has joined #openstack-neutron07:40
*** nati_ueno has quit IRC07:44
*** sc68cal has joined #openstack-neutron07:46
*** chandankumar has joined #openstack-neutron07:57
*** zz_ajo is now known as ajo08:01
*** chandankumar has quit IRC08:02
*** evgenyf has joined #openstack-neutron08:06
*** gongysh has joined #openstack-neutron08:16
*** lowkey has quit IRC08:20
*** lowk3y has joined #openstack-neutron08:21
*** chandankumar has joined #openstack-neutron08:41
openstackgerritJianing Yang proposed a change to openstack/neutron: Implement basic functionalities for port forwarding  https://review.openstack.org/6051208:45
*** irenab_ has quit IRC08:49
*** zhhuabj has joined #openstack-neutron08:58
*** salv-orlando has quit IRC09:00
*** safchain has joined #openstack-neutron09:08
*** Qlawy has quit IRC09:32
*** Qlawy has joined #openstack-neutron09:34
openstackgerritgaryk proposed a change to openstack/neutron: Update RPC code from oslo  https://review.openstack.org/6441909:48
openstackgerritEvgeny Fedoruk proposed a change to openstack/neutron: Multiple service providers with same driver  https://review.openstack.org/6413909:49
openstackgerritgaryk proposed a change to openstack/neutron: Update RPC code from oslo  https://review.openstack.org/6441909:53
openstackgerritgaryk proposed a change to openstack/neutron: Update RPC code from oslo  https://review.openstack.org/6441909:56
*** safchain has quit IRC09:57
openstackgerritJianing Yang proposed a change to openstack/neutron: Implement basic functionalities for port forwarding  https://review.openstack.org/6051209:58
*** dims has quit IRC10:06
*** dims has joined #openstack-neutron10:09
*** dguitarbite_ has quit IRC10:10
*** dguitarbite_ has joined #openstack-neutron10:13
yfriedSumitNaiksatam: ping\10:14
SumitNaiksatamyfried: hi10:14
yfriedSumitNaiksatam: can you log to *-qa? I would like to ask you some tempest questions10:15
SumitNaiksatamyfried: i am about to hit the sack, its 2.15 AM in my time zone10:16
SumitNaiksatamyfried: perhaps you can send me an email10:16
yfriedSumitNaiksatam: sorry. didn't know. where is that? can you point to someone else I could ask about FWaaS?10:17
SumitNaiksatamyfried: i am PST10:17
*** sc68cal has quit IRC10:17
SumitNaiksatamyfried: i don't think anyone else working on FWaaS is currently online10:17
SumitNaiksatamyfried: what's it about?10:18
yfriedyour mail and review - I want to know if there's anywhere I can read about the status of FWaaS in tempest and list myself down to contribute some tests. Also - when will the gate be able to accept these test10:19
yfrieds10:19
SumitNaiksatamyfried: were you able to get the tests to work in your local setup?10:21
yfriedSumitNaiksatam: ofcourse - wouldn't push them otherwise :)10:21
yfriedSumitNaiksatam: but I'm currently working on a RHOS-Havana10:22
SumitNaiksatamyfried: so whats the problem with the gate?10:22
yfriedSumitNaiksatam: it doesn't have fwaas enabled and the tests fail10:22
yfriedSumitNaiksatam: I was told it broke down the gate last time it was enabled10:23
SumitNaiksatamyfried: ah ok...i was aware that there was an explicit step to enable this10:24
*** sc68cal has joined #openstack-neutron10:24
SumitNaiksatamyfried: is this a configuration on the gate?10:24
*** safchain has joined #openstack-neutron10:25
yfriedSumitNaiksatam: I think so - enable q-fwaas in devstack10:25
SumitNaiksatamyfried: ah you mean, devstack10:25
SumitNaiksatamyfried: okay, so we have fwaas support in devstack, i believe its a matter of telling the gate folks to add q-fwaas in their config10:26
SumitNaiksatamyfried: localrc config that is10:26
SumitNaiksatamyfried: i believe you did the same in your local setup?10:26
yfriedSumitNaiksatam: I didn't use devstack for this - I changed neturon.conf10:27
yfriedneutorn.conf10:28
SumitNaiksatamyfried: ok10:28
SumitNaiksatamyfried: but i think for the gate we would have to ask the qa folks to turn fwaas on, lets check with them, and they might instruct as to do a dry run using devstack and tempest to check if just turning it on breaks anything10:29
yfriedSumitNaiksatam: when you say qa folks - you mean tempest-core group?10:30
SumitNaiksatamyfried: yeah10:30
SumitNaiksatamyfried: actually, not sure, if its them or the infra team10:31
SumitNaiksatamyfried: probably its the CI infra team10:31
yfriedSumitNaiksatam: I talked with clarkb in infra - he's afraid that it will break down again, and wants to know what has changed10:32
yfriedSumitNaiksatam: I was hoping you would know that10:32
SumitNaiksatamyfried: again?10:33
yfriedSumitNaiksatam: but I've kept you long enough.10:33
SumitNaiksatamyfried: i don't think fwaas was ever turned on10:33
yfriedSumitNaiksatam: just repeating what he said10:33
SumitNaiksatamyfried: at least not that i know of10:33
SumitNaiksatamyfried: do you want to start email thread with him and cc me as well?10:33
yfried(09:32:37 PM) clarkb: the last time they enabled it the gate fell apart10:33
yfriedSumitNaiksatam: I did start an email thread - you responded to that10:34
SumitNaiksatamyfried: yeah10:34
yfriedSumitNaiksatam: you are tired - you need to sleep... :)10:34
SumitNaiksatamyfried: perhaps sending the email specifically to clarkb might catch his attention10:35
SumitNaiksatamyfried: i don't think he in on now10:35
yfriedI think he has said his piece. I will ask him to respond to the mail.10:36
SumitNaiksatamyfried: okay, anything else?10:36
yfriedSumitNaiksatam: just so I know - are you a neutron guy? you are part of FWaaS and you are unaware of the gate issue?10:36
yfriedSumitNaiksatam: trying to understand if this is something that was caught early and so - wasn't known to most.10:37
SumitNaiksatamyfried: i am in neutron team, and also the sub team lead for fwaas, but i am not aware of the gate issue; no one in the fwaas sub team was in the loop on that (i might have missed emails on that if there were any)10:38
SumitNaiksatamyfried: so it could be the case that this was caught early as you mention10:38
yfriedSumitNaiksatam: tnx. I will ask clarkb to explain this on the thread10:39
SumitNaiksatamyfried: however there were no tempest tests for fwaas before this10:39
SumitNaiksatamyfried: thanks for following up on this, i will get back to this tomorrow10:40
SumitNaiksatamyfried: ttyl, bye10:40
yfriedSumitNaiksatam: I know. one last thing - do you know if there's anywhere I can register to write these tests apart from the summit pad10:40
SumitNaiksatamyfried: we have a fwaas wiki page10:40
SumitNaiksatamyfried: that has links to blueprints we are working on10:41
SumitNaiksatamyfried: i was currently signed up for the api tests10:42
SumitNaiksatamyfried: but you beat me to it, so go ahead and continue with your work10:42
yfriedSumitNaiksatam: please send me the link so it doesn't happen again10:42
SumitNaiksatamyfried: #link https://wiki.openstack.org/wiki/Neutron/FWaaS10:43
yfriedSumitNaiksatam: tnx. good night10:44
SumitNaiksatamyfried: bye10:45
*** gongysh has quit IRC10:45
openstackgerritSylvain Afchain proposed a change to openstack/neutron: Add param and iptables rules to protect dnsmasq ports  https://review.openstack.org/6199410:57
*** dims has quit IRC11:20
*** dims has joined #openstack-neutron11:24
*** amuller has joined #openstack-neutron11:26
*** markwash has joined #openstack-neutron11:33
*** irenab_ has joined #openstack-neutron11:36
*** markwash has quit IRC11:37
*** markwash has joined #openstack-neutron11:39
*** Mierdin has quit IRC11:40
*** markwash has quit IRC11:41
*** fouxm_ has joined #openstack-neutron11:41
*** Mierdin has joined #openstack-neutron11:42
*** fouxm has quit IRC11:43
*** fouxm_ is now known as fouxm11:46
*** dims has quit IRC11:47
*** fouxm_ has joined #openstack-neutron11:48
*** dims has joined #openstack-neutron11:51
*** fouxm_ has quit IRC11:53
*** HenryG_ has joined #openstack-neutron12:00
*** enikanorov__ has joined #openstack-neutron12:01
*** dims has quit IRC12:05
*** Qlawy_ has joined #openstack-neutron12:05
*** zhhuabj has quit IRC12:06
*** Qlawy has quit IRC12:06
*** HenryG has quit IRC12:06
*** AndreyGrebenniko has quit IRC12:06
*** kruskakli has quit IRC12:06
*** dguitarbite_ has quit IRC12:07
*** enikanorov_ has quit IRC12:07
*** larsks has quit IRC12:07
*** AndreyGrebenniko has joined #openstack-neutron12:07
*** dims has joined #openstack-neutron12:07
*** dguitarbite__ has joined #openstack-neutron12:08
*** amuller has quit IRC12:10
*** amuller has joined #openstack-neutron12:10
*** zhhuabj has joined #openstack-neutron12:11
*** larsks has joined #openstack-neutron12:11
*** Mierdin has quit IRC12:13
*** dguitarbite__ has quit IRC12:14
*** dguitarbite_ has joined #openstack-neutron12:17
*** Qlawy_ is now known as Qlawy12:23
*** Qlawy has joined #openstack-neutron12:24
*** jroovers has joined #openstack-neutron12:25
*** dims has quit IRC12:32
*** dims has joined #openstack-neutron12:37
openstackgerritJianing Yang proposed a change to openstack/neutron: Implement basic functionalities for port forwarding  https://review.openstack.org/6051212:38
jroovershi anteaya, let me know when you are around - got a question about Montreal code sprint12:53
openstackgerritmouad benchchaoui proposed a change to openstack/neutron: Make the metadata namespace proxy transparent  https://review.openstack.org/2813712:59
*** mrsnivvel has quit IRC13:06
*** ekarlso has quit IRC13:20
*** ekarlso has joined #openstack-neutron13:20
*** dave_tucker_zzz is now known as dave_tucker13:20
*** mrsnivvel has joined #openstack-neutron13:23
*** networkstatic is now known as networkstatic_zZ13:24
*** banix has joined #openstack-neutron13:40
*** banix has quit IRC13:57
*** irenab_ has quit IRC13:58
anteayaI'm here14:00
*** dave_tucker is now known as dave_tucker_zzz14:01
*** yfried has quit IRC14:06
*** chandankumar has quit IRC14:12
jrooversanteaya, ok, let's continue here then :-)14:13
anteayathanks14:15
anteayaso let's start from the beginning14:15
anteayawhat is happening14:15
jrooversok14:15
jrooversso, initially I made some changes using this change14:16
jroovershttps://review.openstack.org/#/c/62867/14:16
jrooversrelated to Quotas negative testing14:16
anteayamlavalle: when you are around, https://etherpad.openstack.org/p/icehouse-summit-qa-neutron has grown too large to be useable, I am unable to open it14:18
anteayacan you break it into more manageable pieces please14:18
anteayaand also tell me how many lines it has grown to? We didn't know that etherpads have an upper bound14:19
anteayajroovers: and then?14:19
jrooversso for this to work, I needed to make a few changes to the XML network Client to support the right API calls14:19
jrooversenikanorov suggested however, to wait for another patch to merge first14:19
jrooversthat basically took care of that in a more generic way14:19
jrooversthat change has been merged now14:19
jrooversso I wanted to adjust my change to incorporate that new code14:19
jrooversbut since I'm not really a Git genius, I couldn't get it to work like I wanted, and I was a little afraid to mess the change set up - so I created a new one14:19
jrooversand abandoned the old one with a comment referring to the new one14:19
anteayajroovers: ah ha, this is were asking questions is the best way forward14:19
anteaya*where14:19
anteayanoone expects you to be a git genius14:20
jroovershttps://review.openstack.org/#/c/64434/14:20
anteayabut making sure that patches keep their history is very important, it saves time and is more efficient in the long run14:20
anteayabecause the new patch doesn't automatically link back to the old patch14:21
jrooversmlavalle, I agree with anteyea, the file is also unusable to me14:21
anteayaso the history is lost14:21
anteayaor potentially lost14:21
anteayaso what to do now14:22
jrooversanteaya, well, now I just submitted to new patch, and it is in review14:22
anteayaplease join me in #openstack-infra14:22
*** WackoRobie has joined #openstack-neutron14:22
jrooversanteaya, new change: https://review.openstack.org/#/c/64434/14:23
anteayajroovers: let's chat in #openstack-infra, please14:25
jrooversanteaya, so I'm a little confused now - did I do right (i.e. is is ok?) to submit it as a new change14:25
anteayano14:25
jrooversor should I have fixed it in the original change14:25
anteayaplease stop creating new changes to deal with git issues14:25
anteayaplease join me in #openstack-infra14:26
anteayawaiting for you to join me in #openstack-infra14:28
*** aymenfrikha has joined #openstack-neutron14:29
jrooversanteaya, understood14:30
jrooversanteaya, well, I don't know. We could leave it like this as it is not that big of a change or we could go back, reopen the old patch, figure out the required git changes, and abondon the current one.14:32
jrooversanteaya, IMHO though, that will confuse even more14:32
anteayaplease join me in #openstack-infra14:32
anteayaI'm waiting to discuss this with you in that channel14:33
anteayadoes this create a problem for you?14:34
jrooversmlavalle, anteaya, I removed all the empty lines in the etherpad, it is good now: https://etherpad.openstack.org/p/icehouse-summit-qa-neutron14:43
jrooverskinda annoying that etherpad automatically adds lines when you scroll though14:44
*** jroovers has quit IRC14:44
*** sc68cal has quit IRC14:44
*** pcm_ has joined #openstack-neutron14:45
*** jroovers has joined #openstack-neutron14:46
*** pcm_ has quit IRC14:48
*** pcm_ has joined #openstack-neutron14:49
*** safchain has quit IRC14:49
*** sc68cal has joined #openstack-neutron14:50
*** otherwiseguy has joined #openstack-neutron14:54
*** dims has quit IRC14:56
*** dims has joined #openstack-neutron14:57
*** banix has joined #openstack-neutron14:57
*** networkstatic_zZ has quit IRC15:01
*** networkstatic has joined #openstack-neutron15:01
anteayajroovers: the blank lines in the etherpad are an artifact of it having problems loading in a browser, possibly my browser15:06
anteayaif I try to open it again, I would put money on those blank lines reappearing15:06
jrooversanteaya: yeah, they seem to reappear15:06
anteayayeah15:06
jrooversctrl+shift+arrow right15:07
jrooversselects all lines until the end15:07
jrooversand then delete15:07
jrooversnot really a fix, but temporary workaround to make the etherpad usable15:07
*** yfried has joined #openstack-neutron15:13
*** WackoRobie has quit IRC15:19
*** WackoRobie has joined #openstack-neutron15:19
*** safchain has joined #openstack-neutron15:28
*** safchain has quit IRC15:29
*** otherwiseguy has quit IRC15:29
*** safchain has joined #openstack-neutron15:32
*** jaypipes has joined #openstack-neutron15:56
*** garyk has quit IRC15:57
*** evgenyf has quit IRC16:03
*** otherwiseguy has joined #openstack-neutron16:12
*** dguitarbite_ has quit IRC16:16
*** thedodd has joined #openstack-neutron16:17
*** jroovers has quit IRC16:28
*** mlavalle has joined #openstack-neutron16:30
*** WackoRobie has quit IRC16:41
*** lowk3y is now known as lowkey16:43
*** WackoRobie has joined #openstack-neutron16:47
*** SumitNaiksatam has quit IRC16:48
*** WackoRobie has quit IRC16:48
*** dave_tucker_zzz is now known as dave_tucker16:48
*** mlavalle has quit IRC16:53
*** dave_tucker is now known as dave_tucker_zzz16:53
*** jhurlbert has joined #openstack-neutron17:01
*** amuller has quit IRC17:24
*** nati_ueno has joined #openstack-neutron17:29
*** WackoRobie has joined #openstack-neutron17:33
*** safchain has quit IRC17:33
*** clev has joined #openstack-neutron17:41
*** nati_ueno has quit IRC17:47
*** nati_uen_ has joined #openstack-neutron17:47
*** garyk has joined #openstack-neutron17:59
*** WackoRobie has quit IRC17:59
*** layer427expert has quit IRC18:04
*** harlowja has joined #openstack-neutron18:14
*** bladee has joined #openstack-neutron18:15
*** bladee has quit IRC18:19
*** alagalah has quit IRC18:23
*** mlavalle has joined #openstack-neutron18:23
*** clev has quit IRC18:27
*** layer427expert has joined #openstack-neutron18:35
*** Mierdin has joined #openstack-neutron18:39
*** nati_ueno has joined #openstack-neutron18:40
*** nati_uen_ has quit IRC18:42
*** polfilm has joined #openstack-neutron18:49
*** sdague has quit IRC18:50
*** nati_ueno has quit IRC19:12
*** nati_ueno has joined #openstack-neutron19:13
*** SumitNaiksatam has joined #openstack-neutron19:17
*** nati_ueno has quit IRC19:18
*** polfilm has quit IRC19:22
*** polfilm has joined #openstack-neutron19:23
*** jroovers has joined #openstack-neutron19:26
*** jorisroovers has joined #openstack-neutron19:27
*** dave_tucker_zzz is now known as dave_tucker19:31
*** jroovers has quit IRC19:31
*** mlavalle has quit IRC19:35
*** layer427expert has quit IRC19:36
*** networkstatic is now known as networkstatic_zZ19:37
*** garyk has quit IRC19:40
*** WackoRobie has joined #openstack-neutron20:06
*** nati_ueno has joined #openstack-neutron20:09
yfriedSumitNaiksatam: hi20:12
yfriedSumitNaiksatam: sleep well?20:12
*** polfilm has quit IRC20:13
SumitNaiksatamyfried: hi20:14
yfriedSumitNaiksatam: This might be a stupid question, and if it is explained somewhere please just link to it, but -20:15
yfriedhow is fwaas better than security groups?20:15
yfriedSumitNaiksatam: what can you get with fwaas that cannot be done by applying a secgroup to a router port?20:16
SumitNaiksatamyfried: current fwaas is limited to perimeter firewall20:17
SumitNaiksatamyfried: but that is just one default/reference implementation20:17
SumitNaiksatamyfried: the api and resource model opens the possibility for supporting richer firewall backends and also opens the possibility of L2 and bump-in-the-wire firewalls20:18
yfriedSumitNaiksatam: I am unfamiliar with the 2 last things you mentioned.20:21
yfriedSumitNaiksatam: when you say "Open the possibility", do you mean - after significant changes to the existing feature?20:22
SumitNaiksatamyfried: firewalls work in different modes depending on where they are inserted into the network20:22
SumitNaiksatamyfried: we have a base resource model to support iptables-based firewalls20:23
yfriedSumitNaiksatam: meaning - based on series of allow/deny rules?20:23
yfriedSumitNaiksatam: ^iptables-based firewalls20:24
SumitNaiksatamyfried: we plan to add several extensions like zones, address objects, application policies20:24
SumitNaiksatamyfried: which will enable the richer use cases20:24
SumitNaiksatamyfried: in addition we are trying to introduce the different insertion modes as well20:25
SumitNaiksatamyfried: all firewall policies will ultimately break down to a sequence of rules20:25
yfriedSumitNaiksatam: cool. so right now it isn't different than applying secgroup to router port? Just making sure I'm not missing something20:25
SumitNaiksatamyfried: we might support additional actions in addition to allow/deny in the future20:25
SumitNaiksatamyfried: with sec groups you have to choose which port to apply the rules on20:27
SumitNaiksatamyfried: with fwaas, you define the rules and policies, and the backend figures out what it needs to do20:28
SumitNaiksatamyfried: with the current implementation of fwaas backend, the ultimate result might be very similar to what you descrive20:28
SumitNaiksatam*describe20:28
*** nati_ueno has quit IRC20:29
*** dave_tucker is now known as dave_tucker_zzz20:30
*** nati_ueno has joined #openstack-neutron20:30
yfriedSumitNaiksatam: ok. great. I will look into this on the blueprints. We were wondering about this at the office (both dev and qa ppl). Now I can give everyone an answer20:32
yfriedSumitNaiksatam: thank you for your patience20:32
yfriedSumitNaiksatam: I'm trying to create a devstack instance on a fedora19 VM to test fwaas20:33
SumitNaiksatamyfried: sure20:33
yfriedSumitNaiksatam: I keep failing. do you have a localrc file I could try?20:33
SumitNaiksatamyfried: whats the failure you see?20:34
yfriedSumitNaiksatam: I'm getting a cinder issue - lib/cinder:180 No suitable rootwrap found20:34
SumitNaiksatamyfried: hmmm20:34
SumitNaiksatamyfried: that should be unrelated to turning fwaas on20:34
yfriedSumitNaiksatam: I'm completely unfamiliar with devstack, as I usually work on rhos20:34
*** nati_ueno has quit IRC20:34
yfriedSumitNaiksatam: I assume20:34
yfriedso20:34
SumitNaiksatamyfried: okay, but how about trying with turning cinder to start with?20:35
SumitNaiksatamyfried: turning off i meant20:35
yfriedSumitNaiksatam: I will20:35
*** alagalah has joined #openstack-neutron20:36
SumitNaiksatamyfried: adding q-fwaas to the list of enabled services should be all that you would need to do turn fwaas on20:36
SumitNaiksatamyfried: i mean in the localrc20:37
yfriedSumitNaiksatam: AFAIK you need to add stuff to make neutron work, as it doesn't use it by default20:37
*** alagalah has quit IRC20:37
yfriedSumitNaiksatam: I'm off to bed now. thank you for you time20:38
SumitNaiksatamyfried: sure20:38
SumitNaiksatamyfried: btw, i was curious, how were you planning to add sec group to the router port?20:38
SumitNaiksatamyfried: we can catch up later20:38
yfriedSumitNaiksatam: you can sign a port to secgroup same as you do VM. now I really need to go20:39
SumitNaiksatamyfried: ttyl, bye20:39
*** mtaylor is now known as mordred20:44
*** WackoRobie has quit IRC20:45
*** jmeridth has joined #openstack-neutron20:48
*** WackoRobie has joined #openstack-neutron20:51
*** sdague has joined #openstack-neutron20:54
*** dave_tucker_zzz is now known as dave_tucker20:57
*** otherwiseguy has quit IRC20:58
*** nati_ueno has joined #openstack-neutron21:02
*** pcm_ has quit IRC21:02
*** WackoRobie has quit IRC21:18
*** dave_tucker is now known as dave_tucker_zzz21:25
*** layer427expert has joined #openstack-neutron21:29
*** salv-orlando has joined #openstack-neutron21:30
*** banix has quit IRC21:31
*** dguitarbite_ has joined #openstack-neutron21:33
*** networkstatic_zZ is now known as networkstatic21:34
*** dguitarbite_ has quit IRC21:44
*** dave_tucker_zzz is now known as dave_tucker21:52
*** aymenfrikha has left #openstack-neutron21:54
jorisroovershi everyone, just added some negative tests for neutron agent management to tempest. Any feedback/review is very much appreciated! https://review.openstack.org/#/c/64476/21:54
*** otherwiseguy has joined #openstack-neutron21:55
enikanorov__jorisroovers: afaik Sean Dague was -1 to new negative tests patches due to the effort of making the auto-generated from schema21:56
jorisrooversenikanorov__, I was not aware21:57
jorisrooversenikanorov__, mm, I'm afraid that will impact both the patches I worked on today21:57
jorisrooverssdague, are you here?21:58
jorisrooversenikanorov__, I just saw the remark about negative tests on https://etherpad.openstack.org/p/icehouse-summit-qa-neutron22:00
jorisrooversenikanorov__, missed that before :(22:00
jorisrooversanteaya, are you around for some advice?22:04
*** WackoRobie has joined #openstack-neutron22:29
anteayajorisroovers: go ahead22:31
layer427expertI have a question on unit tests... anyone around who can answer?22:32
jorisrooverswell anteaya, I'm looking for some guidance on where to focus next. I just heard from enikanorov__ that the negative API tests that I've been working on are going to be replaced by automatically generated tests22:33
anteayalayer427expert: ask your question, if someone is able to respond they will up in22:33
*** WackoRobie has quit IRC22:33
jorisrooversanteaya, so I've already commit 3 patches, but haven't been able to get anything merged yet22:33
anteayajorisroovers: yes, the negative tests for tempest is a bit of a trip hazard22:33
jorisroovers*commited22:33
anteayaat one point, there was an exception for -neutron22:33
jorisrooversanteaya, uhu, that is what  I just learned22:33
anteayait seems that exception has closed, though I don't know when22:34
anteayaI needed to see that you were willing to spend some time on tempest22:34
anteayaso for selfish reasons, I needed you to continue22:34
anteayasince that was your current direction22:34
jorisrooversanteaya, ok...22:34
layer427expertFor LBAAS drivers there is not valid unit test for the main driver if you can not call utilize the appliance API. How can we construct an acceptable UNit test?22:34
anteayaand you did learn how to rebase as well as learn how to ask questions22:34
anteayaboth very useful skills which will serve you well going forward22:35
jorisrooversanteaya, yeah, I must admit that it is kinda frustrating hitting these walls22:35
anteayajorisroovers: given that I only have 2 days left before I am offline, I couldn't redirect you to something and then run away22:35
anteayajorisroovers: yes it is22:35
anteayaI agree with you22:35
jorisrooversanteaya, but at the same time, I've learned a tremendous amount already22:36
anteayagood22:36
anteayajorisroovers: you have submitted 3 patches to gerrit22:36
anteayanone have them have been commited yet, yes?22:36
jorisrooversanteaya, correct, none have been merged22:36
anteayajorisroovers: okay, so at least doing the work you have done you have learned more about tempest than you did previously22:37
jorisrooversanteaya, agreed :-)22:37
anteayajorisroovers: is there anything on the etherpad that speaks to you?22:37
* jorisroovers takes another look22:38
jorisrooversanteaya, well the API and scenario tests22:39
jorisrooversanteaya, but it doesn't matter that much22:39
jorisrooversI think the most important thing is to have a feeling of accomplishment before leaving for Montreal22:40
jorisrooversanteaya, aka, getting something merged22:40
anteayajorisroovers: you can get something merged in Montreal22:40
anteayaif you have a few patches up ready to be merged22:41
jorisrooversanteaya, fair enough22:41
anteayaso API or scenario?22:41
anteayawhich do you like?22:41
anteayalayer427expert: can you find an example of a unit test in other drivers that would be a good example?22:41
jorisrooverslet's go for API as I have most familiarity with that, I'll spend some time later this week looking at how the scenario testing works22:41
anteayalayer427expert: can you find anything in here? http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/unit22:43
anteayajorisroovers: focusing on API is fine22:43
jorisrooversanteaya, ok22:43
anteayajorisroovers: you can just concentrate on one API test to start22:43
anteayais there one specific API test you want to work on?22:43
layer427expertI have been looking at them but it seems that there is little value in the test that I saw.22:43
anteayalayer427expert: care to share the url of the test you saw?22:44
layer427expertLooking at the radware test. http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py22:45
layer427expertIt seams that mocking up the driver device interaction is good but it actually does not fully test the system.22:46
anteayalayer427expert: do expand your critque of this file22:46
*** networkstatic has quit IRC22:46
jorisrooversanteaya, mm, I think I'll need to do a little bit of reading about the exact functionality that is tested for most of them22:46
layer427expertThe code is fine in the file.22:46
*** networkstatic has joined #openstack-neutron22:47
layer427expertIt is just the value of testing in a MOCK API environment.22:47
jorisrooversanteaya, perhaps "5.1 Create a network from an administrative user specifying provider extended attributes"22:47
anteayalayer427expert: please expand on your point22:47
anteayajorisroovers: put your name beside it and go to town22:47
layer427expertMost of the errors that I have observed only come from the device side of the system.22:47
jorisrooversanteaya, ok will do22:48
anteayajorisroovers: thank you22:48
anteayalayer427expert: such as?22:48
layer427expertsorry trying to have two conversations at once...22:48
anteayalayer427expert: okay22:48
jorisrooversanteaya, ok thanks. I'm gonna call it a day here, get myself a beer :-)22:49
layer427expertThe main point is if tempest test passes then what is the value of the unit test?22:49
anteayajorisroovers: enjoy22:49
anteayalayer427expert: unit tests test the function22:49
anteayatempest tests test the api, or should once they are written22:49
jorisrooversanteaya, thanks again for the help. I'm positive I'll get something merged soon. If I don't talk to you any more, see you in Montreal. Looking forward to it!22:50
anteayajorisroovers: awesome22:50
anteayamy pleasure22:50
anteayaconsider me offline from Jan. 1st through to code sprint22:50
layer427expertI get the but is the function not tested during the tempest testing? I understand why it is done in other context but the driver layer is the only layer that i am talking about.22:50
anteayait has to work for the tempest tests to return useful values22:52
anteayaif it isn't tested by itself and the tempest test fails, on what level did the failure occur?22:52
layer427expertSo I guess the main point just around the driver layer is it double effort if tempest returns a pass?22:52
anteayaI'm not clear on why you feel the driver layer should be given differential treatment for testing22:53
anteayaplease expand on this22:53
*** thedodd has quit IRC22:55
layer427expertbecause the point of the driver layer is to interact with a non native system. If the point of the unit test is to measure the reliability of the code then the tempest test should provide this since the native environment is present and has to be fully operational. With that said it was just a thought.22:55
anteayait fair to talk about testing and the purpose behind it22:56
anteayaunfortunately I don't have the level of experience with drivers that you do22:57
anteayawhat I am seeing in -neutron as a whole is a lack of cohesiveness, especially regarding testing, since everyone seems to feel their code is an exception to the rule22:57
anteayaso we have more exceptions that we have rules in the project22:58
anteayaso that is the perspective that I am coming from22:58
layer427expertI can appreciate that perspective.22:58
anteayathanks22:58
layer427expertNeutron because of the (sw|hw) appliances makes it a special case in general.22:59
anteayaand one of the overarching features of openstack is that the projects are integrated, meaning the code is tested together as a unit in the gate, before it can be merged22:59
anteayalayer427expert: it is less of a special case than people want it to be23:00
layer427expert:)23:00
anteayafocusing on the value of of being integrated with the rest of the openstack projects23:00
anteayaseems to be something that neutron contributors take for granted23:01
anteayarather than recognizing it is something that has to be focused on, with every commit23:01
anteayanot treated as an afterthought for someone else to do, because "I am too busy with more important things.23:01
anteaya"23:01
anteayabecause I/me/my code is an exception23:02
layer427expertI would not say taken for granted.23:02
layer427expertI would not say that people feel that they are special as much as question why something has to occur.23:03
layer427expertIt is about optimization.23:03
layer427expertthanks23:03
*** layer427expert has quit IRC23:03
anteayanp23:03
sc68calanteaya: I usually say that you need unit tests AND tempest because python isn't going to stop you if you call a function with the incorrect # of arguements23:08
sc68calor the wrong order, etc.23:08
sc68caland unit tests is going to be the first place you catch it :)23:08
* sc68cal has done it thousands of times 23:08
*** jorisroovers has quit IRC23:10
anteayasc68cal: good points23:11
anteayatoo bad layer427expert left before he could hear them23:11
anteayayes, the different layers of tests provide different functions23:12
anteayaI'm still a bit foggy on the perspective of why drivers don't need to have unit tests23:12
anteayanot that I would agree, but as a process toward understanding23:13
sc68calhmmm - which type of drivers do not have unit tests?23:14
sc68calthe ones that just call Vendor APIs or devices?23:15
sc68calthey should at least have unit tests to verify they create valid HTTP or RPC calls to their hardware/software23:15
anteayawell I think the point was that they do, but that layer427expert was operating from the perspective that they are less than the most efficient approach23:16
anteayasc68cal: again, good point23:16
*** dave_tucker is now known as dave_tucker_zzz23:28
*** RajeshMohan has joined #openstack-neutron23:29
*** aymenfrikha has joined #openstack-neutron23:32
*** dave_tucker_zzz is now known as dave_tucker23:39
*** markwash has joined #openstack-neutron23:40
*** clev has joined #openstack-neutron23:41
openstackgerritSukhdev Kapur proposed a change to openstack/neutron: This is just a test for Gerrit for third party testing- plz ignore  https://review.openstack.org/6277123:43
*** mili has joined #openstack-neutron23:50
*** clev has quit IRC23:53
*** banix has joined #openstack-neutron23:54
*** mili has quit IRC23:57
*** banix has quit IRC23:57
*** banix has joined #openstack-neutron23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!