*** dsundarraj has joined #openstack-neutron | 00:02 | |
ChuckC | ZZelle: hi, any test results to share? | 00:03 |
---|---|---|
*** dsundarr_ has joined #openstack-neutron | 00:04 | |
*** gildub has joined #openstack-neutron | 00:06 | |
*** dsundarraj has quit IRC | 00:07 | |
*** dsundarr_ has quit IRC | 00:08 | |
*** xuhanp has joined #openstack-neutron | 00:09 | |
*** yamamoto has joined #openstack-neutron | 00:09 | |
*** tomoe_ has joined #openstack-neutron | 00:12 | |
*** dims has quit IRC | 00:13 | |
*** seizadi has quit IRC | 00:13 | |
*** padkrish_ has quit IRC | 00:14 | |
*** jorgem has quit IRC | 00:14 | |
*** padkrish has joined #openstack-neutron | 00:14 | |
*** padkrish has quit IRC | 00:19 | |
*** vishwanathj has joined #openstack-neutron | 00:19 | |
*** padkrish has joined #openstack-neutron | 00:20 | |
*** openstackgerrit has quit IRC | 00:21 | |
*** packet has quit IRC | 00:21 | |
*** openstackgerrit has joined #openstack-neutron | 00:21 | |
*** dims has joined #openstack-neutron | 00:22 | |
*** leenheer has quit IRC | 00:23 | |
*** leenheer has joined #openstack-neutron | 00:23 | |
*** david-lyle is now known as david-lyle_afk | 00:28 | |
*** mlavalle has quit IRC | 00:29 | |
*** Sukhdev has quit IRC | 00:30 | |
*** sbfox has quit IRC | 00:30 | |
*** xuhanp has quit IRC | 00:36 | |
*** tomoe_ has quit IRC | 00:41 | |
*** Sukhdev has joined #openstack-neutron | 00:44 | |
*** tomoe_ has joined #openstack-neutron | 00:44 | |
Sukhdev | arosen: Ping | 00:44 |
Sukhdev | arosen: wanted to chat about your comment on https://review.openstack.org/#/c/148749/ | 00:45 |
*** dsneddon has quit IRC | 00:45 | |
*** bjornar_ has joined #openstack-neutron | 00:46 | |
*** suresh12_ has quit IRC | 00:47 | |
*** markvoelker has quit IRC | 00:48 | |
*** banix has joined #openstack-neutron | 00:48 | |
*** yamamoto has quit IRC | 00:48 | |
openstackgerrit | Sukhdev Kapur proposed openstack/neutron: Thining Arista ML2 driver from neutron tree https://review.openstack.org/148749 | 00:50 |
*** isq has quit IRC | 00:51 | |
*** RichardRaseley has quit IRC | 00:53 | |
*** achanda has quit IRC | 00:56 | |
*** manishg has quit IRC | 00:57 | |
*** dsneddon has joined #openstack-neutron | 00:58 | |
*** chenleji has quit IRC | 00:58 | |
*** chenleji has joined #openstack-neutron | 00:58 | |
*** manishg has joined #openstack-neutron | 00:58 | |
*** markvoelker has joined #openstack-neutron | 00:59 | |
*** oomichi has joined #openstack-neutron | 01:00 | |
*** baoli has joined #openstack-neutron | 01:00 | |
*** dsneddon has quit IRC | 01:00 | |
*** achanda has joined #openstack-neutron | 01:00 | |
*** dsneddon has joined #openstack-neutron | 01:01 | |
*** manishg has quit IRC | 01:03 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Basic subnetpool CRUD. Do not merge https://review.openstack.org/148698 | 01:03 |
*** tidwellr has quit IRC | 01:03 | |
*** addnull has joined #openstack-neutron | 01:03 | |
*** openstackgerrit has quit IRC | 01:05 | |
*** openstackgerrit has joined #openstack-neutron | 01:05 | |
*** leenheer has quit IRC | 01:06 | |
*** salv-orlando has joined #openstack-neutron | 01:07 | |
*** prad has quit IRC | 01:08 | |
*** salv-orlando has quit IRC | 01:08 | |
*** dims has quit IRC | 01:10 | |
*** banix has quit IRC | 01:10 | |
*** tiswanso has quit IRC | 01:11 | |
*** tellesnobrega_ has quit IRC | 01:15 | |
*** jaypipes has quit IRC | 01:15 | |
*** a_le has quit IRC | 01:21 | |
*** seizadi has joined #openstack-neutron | 01:25 | |
*** tiswanso has joined #openstack-neutron | 01:26 | |
*** armax has quit IRC | 01:34 | |
*** yapeng has joined #openstack-neutron | 01:35 | |
*** a_le has joined #openstack-neutron | 01:35 | |
*** banix has joined #openstack-neutron | 01:36 | |
*** Marga_ has joined #openstack-neutron | 01:37 | |
*** yapeng has quit IRC | 01:39 | |
*** eliqiao has joined #openstack-neutron | 01:40 | |
*** Sukhdev has quit IRC | 01:40 | |
*** banix has quit IRC | 01:40 | |
*** stanzgy has joined #openstack-neutron | 01:40 | |
*** popw has joined #openstack-neutron | 01:41 | |
*** Marga_ has quit IRC | 01:43 | |
*** Marga_ has joined #openstack-neutron | 01:44 | |
*** roeyc has quit IRC | 01:45 | |
*** markmcclain has joined #openstack-neutron | 01:46 | |
*** marun has quit IRC | 01:46 | |
spandhe | gus: hey Angus! I have a very first cut of the tool here: https://github.com/shraddha-pandhe/Tools/tree/master/NovaNetToNeutronMigration | 01:48 |
*** bjornar_ has quit IRC | 01:48 | |
*** xuhanp has joined #openstack-neutron | 01:48 | |
spandhe | Its very immature right now.. Ill keep updating it. Just want to know if the overall logic or direction is OK or not.. | 01:48 |
spandhe | anteaya: ^ | 01:51 |
spandhe | This is for avoiding hypervisor reboot during migration | 01:51 |
*** seizadi has quit IRC | 01:52 | |
*** aranjan has quit IRC | 01:53 | |
*** markmcclain has quit IRC | 01:54 | |
*** banix has joined #openstack-neutron | 01:55 | |
openstackgerrit | Jian LI proposed openstack/neutron: Fix extra-dhcp-opt on stateless dhcpv6 subnet https://review.openstack.org/147455 | 01:57 |
*** markvoelker has quit IRC | 01:57 | |
*** markvoelker has joined #openstack-neutron | 01:58 | |
*** markvoelker has quit IRC | 02:02 | |
*** markmcclain has joined #openstack-neutron | 02:03 | |
*** tsg has quit IRC | 02:04 | |
*** seizadi has joined #openstack-neutron | 02:06 | |
gus | spandhe: thanks! I'll take a look | 02:06 |
spandhe | thanks gus! | 02:06 |
*** manishg has joined #openstack-neutron | 02:08 | |
*** yapeng has joined #openstack-neutron | 02:08 | |
*** achanda has quit IRC | 02:09 | |
gus | spandhe: looks good from my quick read. | 02:09 |
*** achanda has joined #openstack-neutron | 02:10 | |
*** SridharRamaswamy has quit IRC | 02:10 | |
*** manishg_ has joined #openstack-neutron | 02:10 | |
gus | I see you have lots of logic to limit it to only a particular set of hypervisors (good), but the "List of all hypervisors in the cluster" on migrate_vifs_to_neutron.py:40 makes me nervous ;) | 02:10 |
gus | it's really just the list passed in via -f, but if someone _were_ to put the full list there, then they'd shutdown all the hypervisors in the cluster at once (oops). | 02:11 |
*** nlahouti has quit IRC | 02:11 | |
*** manishg__ has joined #openstack-neutron | 02:12 | |
*** liusheng has quit IRC | 02:12 | |
*** nlahouti has joined #openstack-neutron | 02:12 | |
*** nlahouti has quit IRC | 02:12 | |
*** killer_prince has quit IRC | 02:13 | |
*** manishg has quit IRC | 02:13 | |
*** manishg has joined #openstack-neutron | 02:13 | |
*** rwsu is now known as rwsu-afk | 02:13 | |
*** manishg_ has quit IRC | 02:15 | |
*** s3wong has quit IRC | 02:16 | |
*** manishg__ has quit IRC | 02:16 | |
*** manishg_ has joined #openstack-neutron | 02:16 | |
*** manishg has quit IRC | 02:18 | |
*** openstackgerrit has quit IRC | 02:20 | |
*** erkules_ has joined #openstack-neutron | 02:21 | |
*** openstackgerrit has joined #openstack-neutron | 02:21 | |
*** manishg_ has quit IRC | 02:21 | |
*** erkules has quit IRC | 02:23 | |
*** techcet has quit IRC | 02:23 | |
*** techcet_ has joined #openstack-neutron | 02:23 | |
*** padkrish has quit IRC | 02:24 | |
*** padkrish has joined #openstack-neutron | 02:25 | |
*** trinaths has joined #openstack-neutron | 02:26 | |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Set locale before check dnsmasq version https://review.openstack.org/149524 | 02:28 |
*** markmcclain has quit IRC | 02:29 | |
*** padkrish has quit IRC | 02:30 | |
*** killer_prince has joined #openstack-neutron | 02:31 | |
*** killer_prince is now known as lazy_prince | 02:32 | |
*** banix has quit IRC | 02:35 | |
*** addnull has quit IRC | 02:38 | |
spandhe | gus: not shutting down hypervisors.. just the VMs | 02:38 |
spandhe | gus: comment bug. Ill fix the comment | 02:38 |
spandhe | gus: I am sure there will be a lot of revisions to the script | 02:39 |
*** trinaths has quit IRC | 02:43 | |
*** tellesnobrega_ has joined #openstack-neutron | 02:43 | |
*** dims has joined #openstack-neutron | 02:45 | |
*** mlavalle has joined #openstack-neutron | 02:46 | |
*** baoli has quit IRC | 02:47 | |
*** techcet_ has quit IRC | 02:49 | |
spandhe | gus: I think I missed your message just now.. saw the notification, but no message.. can you please resend? | 02:50 |
*** sripriya has quit IRC | 02:50 | |
*** rkukura has quit IRC | 02:50 | |
*** rkukura has joined #openstack-neutron | 02:51 | |
*** mohitsharma has joined #openstack-neutron | 02:54 | |
*** a_le has quit IRC | 02:59 | |
*** radez_g0n3 is now known as radez | 03:04 | |
*** seizadi has quit IRC | 03:07 | |
*** techcet has joined #openstack-neutron | 03:07 | |
*** jckasper has joined #openstack-neutron | 03:14 | |
*** jckasper has quit IRC | 03:14 | |
*** jckasper has joined #openstack-neutron | 03:14 | |
*** Murali has joined #openstack-neutron | 03:18 | |
*** lazy_prince has quit IRC | 03:19 | |
*** openstackgerrit has quit IRC | 03:20 | |
*** openstackgerrit has joined #openstack-neutron | 03:20 | |
*** avozza is now known as zz_avozza | 03:24 | |
*** Murali has quit IRC | 03:24 | |
*** tiswanso has quit IRC | 03:30 | |
*** tflynn_ has joined #openstack-neutron | 03:32 | |
*** achanda has quit IRC | 03:32 | |
*** sthillma has joined #openstack-neutron | 03:34 | |
*** sbalukoff has quit IRC | 03:35 | |
*** padkrish has joined #openstack-neutron | 03:35 | |
*** tflynn has quit IRC | 03:36 | |
*** tflynn_ has quit IRC | 03:36 | |
*** oda-g has joined #openstack-neutron | 03:37 | |
*** leenheer has joined #openstack-neutron | 03:37 | |
*** Marga_ has quit IRC | 03:37 | |
*** leenheer has quit IRC | 03:37 | |
*** sthillma has quit IRC | 03:38 | |
*** Marga_ has joined #openstack-neutron | 03:38 | |
*** baoli has joined #openstack-neutron | 03:39 | |
*** padkrish has quit IRC | 03:40 | |
*** claudiub has quit IRC | 03:42 | |
*** eliqiao has quit IRC | 03:43 | |
*** Guest99731 has quit IRC | 03:43 | |
*** xuhanp has quit IRC | 03:43 | |
*** spandhe has quit IRC | 03:44 | |
*** ivar-laz_ has joined #openstack-neutron | 03:44 | |
*** eliqiao has joined #openstack-neutron | 03:45 | |
*** ivar-lazzaro has quit IRC | 03:47 | |
*** ivar-laz_ has quit IRC | 03:49 | |
*** dkehn has quit IRC | 03:52 | |
*** rkukura has quit IRC | 03:52 | |
*** dkehn has joined #openstack-neutron | 03:52 | |
*** achanda has joined #openstack-neutron | 03:56 | |
*** manishg has joined #openstack-neutron | 03:58 | |
*** a_le has joined #openstack-neutron | 03:59 | |
*** manishg has quit IRC | 03:59 | |
*** manishg has joined #openstack-neutron | 03:59 | |
*** Guest99731 has joined #openstack-neutron | 03:59 | |
*** yeungp has quit IRC | 04:00 | |
*** xuhanp has joined #openstack-neutron | 04:00 | |
*** oomichi has quit IRC | 04:01 | |
*** yeungp has joined #openstack-neutron | 04:01 | |
*** ijw has quit IRC | 04:03 | |
*** Marga_ has quit IRC | 04:03 | |
*** a_le has quit IRC | 04:03 | |
*** manishg has quit IRC | 04:03 | |
*** radez is now known as radez_g0n3 | 04:04 | |
*** markmcclain has joined #openstack-neutron | 04:04 | |
*** yeungp has quit IRC | 04:06 | |
*** a_le has joined #openstack-neutron | 04:06 | |
*** yamahata has joined #openstack-neutron | 04:06 | |
*** achanda has quit IRC | 04:06 | |
*** eliqiao has quit IRC | 04:07 | |
*** dims has quit IRC | 04:08 | |
*** dims has joined #openstack-neutron | 04:09 | |
*** xuhanp has quit IRC | 04:09 | |
*** pal has joined #openstack-neutron | 04:10 | |
*** Guest99731 has quit IRC | 04:10 | |
*** yamahata has quit IRC | 04:11 | |
*** boris-42 has quit IRC | 04:13 | |
*** eliqiao has joined #openstack-neutron | 04:15 | |
*** mlavalle has quit IRC | 04:15 | |
*** leenheer has joined #openstack-neutron | 04:18 | |
*** markvoelker has joined #openstack-neutron | 04:21 | |
*** xuhanp has joined #openstack-neutron | 04:22 | |
*** sbfox has joined #openstack-neutron | 04:22 | |
*** Guest99731 has joined #openstack-neutron | 04:22 | |
*** dims has quit IRC | 04:23 | |
*** vthapar has joined #openstack-neutron | 04:24 | |
*** yamahata has joined #openstack-neutron | 04:25 | |
*** SumitNaiksatam has quit IRC | 04:25 | |
*** SumitNaiksatam has joined #openstack-neutron | 04:26 | |
*** hanzhang has joined #openstack-neutron | 04:26 | |
*** flwang has quit IRC | 04:27 | |
*** shz has quit IRC | 04:28 | |
*** addnull has joined #openstack-neutron | 04:29 | |
*** killer_prince has joined #openstack-neutron | 04:29 | |
*** killer_prince is now known as lazy_prince | 04:29 | |
*** yamahata has quit IRC | 04:29 | |
*** leenheer has quit IRC | 04:30 | |
*** anish_ has joined #openstack-neutron | 04:31 | |
*** anilvenkata has joined #openstack-neutron | 04:32 | |
*** nlahouti has joined #openstack-neutron | 04:38 | |
*** ijw has joined #openstack-neutron | 04:40 | |
*** nlahouti has quit IRC | 04:41 | |
*** nlahouti has joined #openstack-neutron | 04:41 | |
openstackgerrit | Merged openstack/neutron: Fix AttributeError when using DVRServerRpcApi https://review.openstack.org/150179 | 04:42 |
*** lazy_prince has quit IRC | 04:44 | |
*** achanda has joined #openstack-neutron | 04:45 | |
*** ijw_ has joined #openstack-neutron | 04:45 | |
*** shz has joined #openstack-neutron | 04:45 | |
*** tellesnobrega_ has quit IRC | 04:46 | |
*** killer_prince has joined #openstack-neutron | 04:46 | |
*** killer_prince is now known as lazy_prince | 04:46 | |
*** achanda has quit IRC | 04:46 | |
*** yamahata has joined #openstack-neutron | 04:47 | |
openstackgerrit | vishwanath jayaraman proposed openstack/neutron-fwaas: Implementation of Brocade Vyatta Firewall driver https://review.openstack.org/147600 | 04:47 |
*** harlowja is now known as harlowja_away | 04:48 | |
*** ijw has quit IRC | 04:48 | |
*** hanzhang has quit IRC | 04:48 | |
*** a_le has quit IRC | 04:50 | |
*** yamahata has quit IRC | 04:52 | |
*** markvoelker has quit IRC | 04:53 | |
*** markvoelker_ has joined #openstack-neutron | 04:53 | |
*** neeti has joined #openstack-neutron | 04:56 | |
*** achanda has joined #openstack-neutron | 04:57 | |
*** eliqiao has quit IRC | 04:57 | |
*** eliqiao has joined #openstack-neutron | 04:57 | |
*** popw has quit IRC | 04:58 | |
*** popw has joined #openstack-neutron | 04:58 | |
*** f13o has quit IRC | 05:00 | |
*** timbyr_ has quit IRC | 05:00 | |
*** mohitsharma has quit IRC | 05:01 | |
*** markmcclain has quit IRC | 05:02 | |
*** stanzgy has quit IRC | 05:04 | |
*** xgerman_ has joined #openstack-neutron | 05:04 | |
*** sbalukoff has joined #openstack-neutron | 05:08 | |
*** popw has quit IRC | 05:11 | |
*** Sukhdev has joined #openstack-neutron | 05:11 | |
*** markmcclain has joined #openstack-neutron | 05:11 | |
*** zzzeek has quit IRC | 05:12 | |
*** sbfox has quit IRC | 05:13 | |
*** timbyr_ has joined #openstack-neutron | 05:13 | |
*** f13o has joined #openstack-neutron | 05:13 | |
*** seizadi has joined #openstack-neutron | 05:14 | |
*** mestery has quit IRC | 05:15 | |
*** a_le has joined #openstack-neutron | 05:16 | |
*** mestery has joined #openstack-neutron | 05:16 | |
*** markvoelker_ has quit IRC | 05:16 | |
*** carl_baldwin has joined #openstack-neutron | 05:16 | |
*** ajo has joined #openstack-neutron | 05:16 | |
*** markvoelker has joined #openstack-neutron | 05:16 | |
*** stanzgy has joined #openstack-neutron | 05:17 | |
HenryG | kevinbenton: ping | 05:18 |
kevinbenton | HenryG: pong | 05:18 |
HenryG | kevinbenton: two unrelated questions ... | 05:18 |
HenryG | First a mock question | 05:19 |
kevinbenton | to prepare me for the real question? ;) | 05:19 |
*** julim_ has joined #openstack-neutron | 05:19 | |
openstackgerrit | Billy Olsen proposed openstack/neutron: Refactor logging in loop to only log debug messages once https://review.openstack.org/149784 | 05:20 |
HenryG | kevinbenton: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_linux_external_process.py#L141 | 05:20 |
*** markmcclain has quit IRC | 05:21 | |
HenryG | kevinbenton: What is that actually mocking? Shouldn't it be mock.patch('os.path.isdir') ? | 05:21 |
*** trinaths has joined #openstack-neutron | 05:21 | |
*** markvoelker has quit IRC | 05:22 | |
HenryG | kevinbenton: I am turning to you since I know you are an expert on mock :) | 05:22 |
kevinbenton | so i think in that case they are ultimately mocking the same thing | 05:22 |
*** julim has quit IRC | 05:22 | |
*** markmcclain has joined #openstack-neutron | 05:22 | |
HenryG | kevinbenton: THen how can line 146 make sense? | 05:23 |
*** vishwanathj has quit IRC | 05:23 | |
kevinbenton | HenryG: well it does, doesn't it? | 05:23 |
*** yapeng has quit IRC | 05:24 | |
*** yshafrir has joined #openstack-neutron | 05:24 | |
*** dims has joined #openstack-neutron | 05:24 | |
*** popw has joined #openstack-neutron | 05:24 | |
kevinbenton | if they are setting ensure_pids_dir=False | 05:24 |
*** baoli has quit IRC | 05:24 | |
HenryG | kevinbenton: ah, ok | 05:24 |
kevinbenton | HenryG: i think the part that might not make sense is setting the return value | 05:24 |
HenryG | kevinbenton: yup | 05:24 |
kevinbenton | HenryG: since they are asserting that nothing is calling it | 05:24 |
*** leenheer has joined #openstack-neutron | 05:26 | |
*** popw1 has joined #openstack-neutron | 05:26 | |
kevinbenton | HenryG: yeah, it passes if i remove that return value | 05:26 |
*** yamamoto_ has joined #openstack-neutron | 05:27 | |
*** popw has quit IRC | 05:28 | |
*** dims has quit IRC | 05:28 | |
HenryG | kevinbenton: thanks for helping me get past a mind block there | 05:28 |
*** markmcclain has quit IRC | 05:29 | |
HenryG | kevinbenton: Second question: Role Base Access Control | 05:29 |
HenryG | kevinbenton: You filed a spec | 05:29 |
kevinbenton | HenryG: right, it didn't receiving an approval :( | 05:30 |
*** anilvenkata has quit IRC | 05:30 | |
kevinbenton | receive * | 05:30 |
HenryG | kevinbenton: Are you going to try again for The-release-that-should-be-named-Lemming? | 05:30 |
kevinbenton | HenryG: yes, definitely | 05:31 |
HenryG | kevinbenton: Cool. Have you done any implementing/POC/etc? | 05:31 |
*** Murali has joined #openstack-neutron | 05:32 | |
kevinbenton | HenryG: no, not yet. just some discussions with Salvatore and Carl of the approach | 05:32 |
kevinbenton | HenryG: it got shot down early enough that there wasn't code yet | 05:32 |
*** tflynn has joined #openstack-neutron | 05:33 | |
HenryG | kevinbenton: NP. Let me know when that picks up again. | 05:33 |
kevinbenton | HenryG: sounds good | 05:33 |
*** addnull has quit IRC | 05:33 | |
*** seizadi has quit IRC | 05:33 | |
kevinbenton | HenryG: back to the mock thing. A time where patching a path would be different than the library directly is when you are patching a module's import | 05:35 |
kevinbenton | e.g. mock.patch.object(ep.utils, 'os') will change the ep.utils reference to os | 05:35 |
HenryG | kevinbenton: Makes sense, thanks. And mock.patch('os') would mock it for everyone, not just ep.utils? | 05:36 |
*** tflynn has quit IRC | 05:37 | |
HenryG | Though I imagine that could break everything o_O | 05:38 |
kevinbenton | HenryG: right, but mock won't even let you do that | 05:38 |
HenryG | kevinbenton: If I want to shoot myself in the foot with mock I have to do it in more subtle ways? | 05:39 |
kevinbenton | HenryG: it will just say it's an invalid target | 05:39 |
HenryG | :) | 05:39 |
kevinbenton | HenryG: yeah | 05:39 |
HenryG | kevinbenton: Thanks for your time. I'm off to bed. | 05:40 |
kevinbenton | HenryG: gnight! | 05:40 |
*** cburgess has quit IRC | 05:41 | |
*** sthillma has joined #openstack-neutron | 05:41 | |
*** cburgess has joined #openstack-neutron | 05:41 | |
*** sthillma has quit IRC | 05:42 | |
*** Longgeek has joined #openstack-neutron | 05:43 | |
*** anilvenkata has joined #openstack-neutron | 05:46 | |
*** markvoelker has joined #openstack-neutron | 05:47 | |
*** anilvenkata has left #openstack-neutron | 05:48 | |
*** anilvenkata has joined #openstack-neutron | 05:49 | |
*** shz has quit IRC | 05:52 | |
*** markvoelker has quit IRC | 05:52 | |
*** popw1 has quit IRC | 05:52 | |
*** popw has joined #openstack-neutron | 05:53 | |
*** ijw_ has quit IRC | 05:54 | |
*** ijw has joined #openstack-neutron | 05:55 | |
openstackgerrit | Merged openstack/neutron: Drop bin/neutron-rootwrap https://review.openstack.org/148975 | 05:55 |
*** oomichi_ has joined #openstack-neutron | 05:57 | |
*** oomichi_ has quit IRC | 05:57 | |
*** leenheer has quit IRC | 05:58 | |
*** salv-orlando has joined #openstack-neutron | 05:59 | |
*** sbfox has joined #openstack-neutron | 05:59 | |
*** josecastroleon_ has joined #openstack-neutron | 06:00 | |
*** tflynn has joined #openstack-neutron | 06:00 | |
*** tflynn has quit IRC | 06:01 | |
*** carl_baldwin has quit IRC | 06:02 | |
*** tflynn has joined #openstack-neutron | 06:02 | |
*** Longgeek has quit IRC | 06:03 | |
*** padkrish has joined #openstack-neutron | 06:03 | |
*** josecastroleon has quit IRC | 06:03 | |
*** vks has joined #openstack-neutron | 06:04 | |
*** padkrish has quit IRC | 06:04 | |
*** josecastroleon__ has joined #openstack-neutron | 06:05 | |
*** padkrish has joined #openstack-neutron | 06:05 | |
*** pradipta_away is now known as pradipta | 06:08 | |
*** josecastroleon_ has quit IRC | 06:09 | |
*** timbyr_ has quit IRC | 06:10 | |
*** SridharG has joined #openstack-neutron | 06:10 | |
*** leenheer has joined #openstack-neutron | 06:10 | |
*** seizadi has joined #openstack-neutron | 06:14 | |
*** spandhe has joined #openstack-neutron | 06:14 | |
*** etacsufbo has joined #openstack-neutron | 06:15 | |
*** markmcclain has joined #openstack-neutron | 06:17 | |
*** Guest99731 has quit IRC | 06:17 | |
*** Guest99731 has joined #openstack-neutron | 06:18 | |
*** Longgeek has joined #openstack-neutron | 06:18 | |
*** anshul has joined #openstack-neutron | 06:19 | |
*** timbyr_ has joined #openstack-neutron | 06:19 | |
*** xgerman_ has quit IRC | 06:21 | |
*** Longgeek has quit IRC | 06:22 | |
*** yatin has joined #openstack-neutron | 06:25 | |
*** leenheer has quit IRC | 06:25 | |
*** reed has quit IRC | 06:26 | |
*** yapeng has joined #openstack-neutron | 06:27 | |
*** seizadi has quit IRC | 06:28 | |
*** yapeng has quit IRC | 06:28 | |
*** lazy_prince has quit IRC | 06:28 | |
*** Sukhdev has quit IRC | 06:30 | |
*** vthapar has quit IRC | 06:31 | |
*** mohitsharma has joined #openstack-neutron | 06:32 | |
*** spandhe has quit IRC | 06:33 | |
*** spandhe has joined #openstack-neutron | 06:37 | |
*** tflynn has quit IRC | 06:39 | |
*** tflynn has joined #openstack-neutron | 06:39 | |
*** numan has joined #openstack-neutron | 06:40 | |
*** nlahouti has quit IRC | 06:42 | |
*** killer_prince has joined #openstack-neutron | 06:43 | |
*** killer_prince is now known as lazy_prince | 06:43 | |
openstackgerrit | Jian LI proposed openstack/neutron: Include icmpv6 in sg_supported_protocols https://review.openstack.org/151128 | 06:44 |
*** nlahouti has joined #openstack-neutron | 06:46 | |
*** aepifanov has joined #openstack-neutron | 06:47 | |
*** zhiyuan has joined #openstack-neutron | 06:48 | |
*** markvoelker has joined #openstack-neutron | 06:48 | |
*** afazekas has joined #openstack-neutron | 06:51 | |
*** JoshNang has quit IRC | 06:52 | |
*** markvoelker has quit IRC | 06:52 | |
*** achanda has quit IRC | 06:53 | |
*** gildub has quit IRC | 06:53 | |
*** evgenyf has joined #openstack-neutron | 06:55 | |
*** nlahouti has quit IRC | 06:55 | |
*** achanda has joined #openstack-neutron | 06:58 | |
*** vthapar has joined #openstack-neutron | 06:59 | |
*** JoshNang has joined #openstack-neutron | 07:01 | |
*** irenab has joined #openstack-neutron | 07:05 | |
openstackgerrit | Merged openstack/neutron: Make agent config available to the router classes https://review.openstack.org/149067 | 07:05 |
openstackgerrit | Merged openstack/neutron: test_agent_scheduler: Fix a misleading variable name https://review.openstack.org/150689 | 07:06 |
*** coolsvap|afk is now known as coolsvap | 07:10 | |
*** Miouge has joined #openstack-neutron | 07:11 | |
*** salv-orlando has quit IRC | 07:11 | |
*** Miouge has quit IRC | 07:12 | |
enikanorov_ | rossella_s: hi | 07:13 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: ml2: Simplify _process_provider_create https://review.openstack.org/151130 | 07:14 |
*** markmcclain has quit IRC | 07:15 | |
openstackgerrit | Jian LI proposed openstack/neutron: Fix extra-dhcp-opt on stateless dhcpv6 subnet https://review.openstack.org/147455 | 07:16 |
*** lpetrut has joined #openstack-neutron | 07:16 | |
*** achanda has quit IRC | 07:19 | |
*** pal has quit IRC | 07:19 | |
*** pal has joined #openstack-neutron | 07:20 | |
*** markvoelker has joined #openstack-neutron | 07:21 | |
*** jaypipes has joined #openstack-neutron | 07:22 | |
*** rotbeard has joined #openstack-neutron | 07:23 | |
*** ronis has joined #openstack-neutron | 07:24 | |
*** apuimedo has joined #openstack-neutron | 07:26 | |
*** markvoelker has quit IRC | 07:27 | |
*** irenab has quit IRC | 07:29 | |
*** sc68cal has quit IRC | 07:32 | |
*** anish_ has quit IRC | 07:32 | |
*** jaypipes has quit IRC | 07:33 | |
*** scheuran has joined #openstack-neutron | 07:33 | |
*** oomichi has joined #openstack-neutron | 07:33 | |
*** sc68cal has joined #openstack-neutron | 07:36 | |
*** padkrish has quit IRC | 07:37 | |
*** doude has joined #openstack-neutron | 07:38 | |
*** padkrish has joined #openstack-neutron | 07:38 | |
*** belmoreira has joined #openstack-neutron | 07:40 | |
*** aleksandr_null has quit IRC | 07:40 | |
*** vthapar_ has joined #openstack-neutron | 07:41 | |
*** aleksandr_null has joined #openstack-neutron | 07:42 | |
*** yamahata has joined #openstack-neutron | 07:44 | |
*** vthapar has quit IRC | 07:44 | |
*** Miouge has joined #openstack-neutron | 07:48 | |
*** yamahata has quit IRC | 07:49 | |
*** shz has joined #openstack-neutron | 07:52 | |
*** matrohon has joined #openstack-neutron | 07:53 | |
*** Miouge has quit IRC | 07:54 | |
*** pask81 has joined #openstack-neutron | 07:56 | |
*** Guest99731 has quit IRC | 07:57 | |
openstackgerrit | Merged openstack/neutron: Updated from global requirements https://review.openstack.org/149970 | 07:57 |
*** timbyr_ has quit IRC | 07:58 | |
*** f13o has quit IRC | 07:58 | |
*** devvesa has joined #openstack-neutron | 07:59 | |
*** nyechiel__ has joined #openstack-neutron | 07:59 | |
*** ronis_ has joined #openstack-neutron | 08:01 | |
*** yamahata has joined #openstack-neutron | 08:02 | |
*** ronis has quit IRC | 08:02 | |
*** Miouge has joined #openstack-neutron | 08:05 | |
*** addnull has joined #openstack-neutron | 08:06 | |
*** pask81 has quit IRC | 08:06 | |
*** yamahata has quit IRC | 08:07 | |
*** spandhe has quit IRC | 08:09 | |
*** etacsufbo has quit IRC | 08:10 | |
*** itzikb has joined #openstack-neutron | 08:10 | |
*** nmagnezi has joined #openstack-neutron | 08:10 | |
*** jlibosva has joined #openstack-neutron | 08:12 | |
*** shz has quit IRC | 08:12 | |
*** salv-orlando has joined #openstack-neutron | 08:12 | |
*** shz has joined #openstack-neutron | 08:12 | |
*** safchain has joined #openstack-neutron | 08:13 | |
*** timbyr_ has joined #openstack-neutron | 08:15 | |
*** f13o has joined #openstack-neutron | 08:16 | |
openstackgerrit | Trinath Somanchi proposed openstack/neutron-fwaas: Freescale FWaaS Plugin https://review.openstack.org/148884 | 08:16 |
*** salv-orlando has quit IRC | 08:16 | |
*** yapeng has joined #openstack-neutron | 08:16 | |
*** ronis_ has quit IRC | 08:17 | |
*** yamamoto_ has quit IRC | 08:17 | |
openstackgerrit | Merged openstack/neutron: Make the interface driver available to the router classes https://review.openstack.org/150872 | 08:18 |
openstackgerrit | Merged openstack/neutron: TestL2PopulationRpcTestCase: Stop loading linuxbridge mech driver https://review.openstack.org/149955 | 08:19 |
*** pask81 has joined #openstack-neutron | 08:19 | |
*** yamahata has joined #openstack-neutron | 08:21 | |
*** yapeng has quit IRC | 08:22 | |
*** vthapar_ has quit IRC | 08:22 | |
*** kawa2014 has joined #openstack-neutron | 08:23 | |
*** markvoelker has joined #openstack-neutron | 08:25 | |
*** padkrish has quit IRC | 08:25 | |
*** yamahata has quit IRC | 08:25 | |
*** Miouge has quit IRC | 08:26 | |
*** pask81 has quit IRC | 08:26 | |
*** mestery has quit IRC | 08:29 | |
*** yamahata has joined #openstack-neutron | 08:29 | |
*** bjornar_ has joined #openstack-neutron | 08:30 | |
openstackgerrit | watanabe isao proposed openstack/python-neutronclient: Skip None id when getting security_group_ids https://review.openstack.org/150728 | 08:30 |
*** markvoelker has quit IRC | 08:31 | |
*** mestery has joined #openstack-neutron | 08:31 | |
*** aveiga has quit IRC | 08:32 | |
*** aveiga has joined #openstack-neutron | 08:32 | |
*** ronis_ has joined #openstack-neutron | 08:32 | |
*** tflynn has quit IRC | 08:33 | |
*** tflynn has joined #openstack-neutron | 08:34 | |
*** pask81 has joined #openstack-neutron | 08:34 | |
*** yamahata has quit IRC | 08:34 | |
*** etacsufbo has joined #openstack-neutron | 08:35 | |
*** chlong has quit IRC | 08:36 | |
*** zz_avozza is now known as avozza | 08:36 | |
*** Miouge has joined #openstack-neutron | 08:38 | |
*** etacsufbo has quit IRC | 08:41 | |
*** lpetrut has quit IRC | 08:44 | |
*** pask811 has joined #openstack-neutron | 08:45 | |
*** yamahata has joined #openstack-neutron | 08:47 | |
*** pask81 has quit IRC | 08:47 | |
*** vthapar has joined #openstack-neutron | 08:50 | |
*** yamahata has quit IRC | 08:51 | |
*** jp_at_hp has joined #openstack-neutron | 08:51 | |
*** jpena has joined #openstack-neutron | 08:52 | |
*** irenab has joined #openstack-neutron | 08:53 | |
*** eliqiao has left #openstack-neutron | 08:55 | |
*** ygbo has joined #openstack-neutron | 08:58 | |
ajo | kevinbenton, sometimes I feel like if we need a rewritten dnsmasq for ourselves ;D | 09:00 |
ajo | not only that I found dnsmasq code not specially good (yet works), | 09:00 |
ajo | but that we need to tweak it quite a bit everywhere ;) | 09:00 |
*** karimb has joined #openstack-neutron | 09:00 | |
ajo | it would be gorgeous to to be able to send FORCERENEWS for example | 09:01 |
rossella_s | enikanorov_: hi | 09:01 |
ajo | hi rossella_s :) | 09:02 |
*** bjornar_ has quit IRC | 09:02 | |
rossella_s | ajo: hi | 09:02 |
kevinbenton | ajo: yeah, definitely | 09:02 |
ajo | kevinbenton, may be we should start contributing dnsmasq, for that sort of things, but given it's tiny nature and embedded target, they would start refusing new features like that | 09:03 |
*** chenleji has quit IRC | 09:03 | |
kevinbenton | ajo: most likely | 09:03 |
ajo | I need to talk the author for a different reason, but I will rise that topic | 09:04 |
*** nyechiel has joined #openstack-neutron | 09:04 | |
ajo | (suppressing certain kind of logs, and being able to send FORCERENEW) if they'll accept such patches I can write them | 09:04 |
lukasa | FWIW, I've found it fairly easy to work with Simon | 09:05 |
*** avozza is now known as zz_avozza | 09:05 | |
ajo | at least the first one should be quite easy, the 2nd one can be a bit more complicated depending on how they handle config reloads, and how does the readonly leases work | 09:05 |
*** Miouge has quit IRC | 09:05 | |
*** nyechiel__ has quit IRC | 09:05 | |
lukasa | My team's had a few patches go into dnsmasq and it hasn't really been a problem. Though I suspect the scope of the work you're considering is larger than what we did... | 09:05 |
*** irenab has quit IRC | 09:06 | |
kevinbenton | ajo: well FORCERENEW is tricky too because if that packet is lost, the client will be stuck with the old address | 09:06 |
ajo | kevinbenton, that's true, but in combination with a lower lease, we can speedup a lot the ip change | 09:06 |
ajo | like instantaneous | 09:06 |
ajo | sorry | 09:06 |
ajo | lower renewal-time | 09:06 |
*** ijw has quit IRC | 09:06 | |
kevinbenton | ajo: definitely | 09:06 |
ajo | lukasa, thanks for the input, that's really good to know, | 09:07 |
kevinbenton | ajo: i think ideally with FORCERENEW you would have some state tracking that would retry several times if a follow-up renewal wasn't seen form the client | 09:07 |
kevinbenton | ajo: but that's quite a bit of complexity | 09:07 |
ajo | kevinbenton, yes, may be too much for an embedded dnsmasq, | 09:07 |
ajo | or even for the time I could put together for this | 09:08 |
ajo | but, a first implementation with blind FORCERENEW would be a good start | 09:08 |
kevinbenton | ajo: ack. don't spend time on the dhcp-renewal time though. i have a patch mostly ready to go for that | 09:08 |
ajo | kevinbenton ack | 09:08 |
kevinbenton | ajo: because i wanted to test it to make sure what i was saying wasn't bogus :) | 09:08 |
*** tflynn has quit IRC | 09:09 | |
*** tflynn has joined #openstack-neutron | 09:09 | |
*** chenleji has joined #openstack-neutron | 09:10 | |
*** addnull has quit IRC | 09:10 | |
openstackgerrit | watanabe isao proposed openstack/neutron: Bug-Fix for unexpected DHCP agent redundant https://review.openstack.org/138659 | 09:12 |
*** salv-orlando has joined #openstack-neutron | 09:12 | |
*** irenab has joined #openstack-neutron | 09:13 | |
*** chenleji has quit IRC | 09:13 | |
*** chenleji has joined #openstack-neutron | 09:14 | |
*** jpich has joined #openstack-neutron | 09:14 | |
*** flwang has joined #openstack-neutron | 09:14 | |
*** tflynn has quit IRC | 09:15 | |
ajo | kevinbenton, I also wonder how un-performant (or not so un-performant) would be to provide a python dhcp server from the dhcp-agent itself | 09:15 |
*** watanabe_isao has quit IRC | 09:15 | |
kevinbenton | ajo: i had thought about that in another context | 09:15 |
kevinbenton | ajo: when there are 1000 networks being serviced by one node, the overhead of dnsmasq processes starts to add up | 09:16 |
*** jistr has joined #openstack-neutron | 09:16 | |
kevinbenton | ajo: if that could all be serviced by the dhcp agent process, that would be nice | 09:17 |
ajo | kevinbenton, yes... the spawn time, etc... | 09:17 |
kevinbenton | ajo: right | 09:17 |
ajo | kevinbenton, we would yet have to plug all the interfaces, and listen into them, etc.. | 09:17 |
*** irenab has quit IRC | 09:17 | |
ajo | but that would save a lot of dnsmasq respawning, as we would be in control of the network info all the time | 09:17 |
kevinbenton | ajo: precisely | 09:18 |
*** salv-orlando has quit IRC | 09:18 | |
ajo | kevinbenton, I also heard somebody talking about OF-DHCP, but not sure if that's totally possible with openflow | 09:18 |
ajo | and also, wouldn't work for all networks, | 09:18 |
ajo | the good of the current dhcp-agent is that it works for all... | 09:18 |
kevinbenton | ajo: right | 09:19 |
kevinbenton | ajo: using linux bridge, etc | 09:19 |
ajo | yup | 09:19 |
*** lpetrut has joined #openstack-neutron | 09:19 | |
kevinbenton | ajo: i wonder if we still need namespaces at that point | 09:19 |
ajo | kevinbenton, I suppose we do, because we need to set an IP on the interface | 09:20 |
ajo | kevinbenton, unless all traffic was handled in raw, but that's mad :D | 09:20 |
kevinbenton | ajo: yeah, raw packet processing might be painful | 09:20 |
*** achanda has joined #openstack-neutron | 09:21 | |
kevinbenton | ajo: not having the IP on the tap would lose the nice debugging feature of pinging from the dhcp interface | 09:21 |
kevinbenton | ajo: so it's probably worth keeping | 09:22 |
ajo | kevinbenton, true, even if UDP is doable in raw... debugging would be a PITA | 09:22 |
*** Longgeek has joined #openstack-neutron | 09:23 | |
*** addnull has joined #openstack-neutron | 09:23 | |
kevinbenton | ajo: so then we need something likea unix domain socket to communicate between the agent and the namespace | 09:23 |
kevinbenton | ajo: and then some mini agent running in the namespace... | 09:23 |
ajo | karimb, hmmm, argh, we're back to the old model (at least from the startup perspective) | 09:24 |
ajo | karimb-> kevinbenton sorry | 09:24 |
ajo | :) | 09:24 |
kevinbenton | ajo: right | 09:24 |
karimb | karimb, :) | 09:24 |
karimb | ajo, :) | 09:24 |
openstackgerrit | Merged openstack/neutron: tests: don't spread fixtures.TempDir throughout test cases https://review.openstack.org/148054 | 09:24 |
ajo | kevinbenton, couldn't we fork and switch to the namespace? | 09:24 |
*** erkules_ is now known as erkules | 09:24 | |
ajo | we would have a lot of processes for dhcp-agent, but yet, that'd be faster | 09:25 |
openstackgerrit | Merged openstack/neutron: Allow 'max_l3_agents_per_router' to be set to '0' https://review.openstack.org/149947 | 09:25 |
*** sbfox has quit IRC | 09:25 | |
*** zz_avozza is now known as avozza | 09:25 | |
ajo | kevinbenton, I have to experiment around this eventually to see if it's possible/reasonable | 09:25 |
kevinbenton | ajo: even if we had mini-agents running in the namespace, they wouldn't have to restart all of the time if their job was just to relay info to the main agent | 09:25 |
ajo | also forking, would help with really distributing the load across cores | 09:26 |
kevinbenton | ajo: so it wouldn't be quite as bad as now | 09:26 |
ajo | kevinbenton, totally | 09:26 |
kevinbenton | ajo: yeah, forking might be an option | 09:26 |
kevinbenton | ajo: ok. well i'm off to bed. catch you later | 09:26 |
ajo | kevinbenton, have a good sleep ;) | 09:26 |
kevinbenton | ajo: you too, whenever bed time rolls around :) | 09:27 |
*** ihrachyshka has joined #openstack-neutron | 09:27 | |
*** Longgeek has quit IRC | 09:27 | |
ajo | I just started the day :D | 09:27 |
ajo | (GMT+1 here) | 09:27 |
*** markvoelker has joined #openstack-neutron | 09:28 | |
kevinbenton | ah, well then in 14 hours or so | 09:29 |
ajo | :) | 09:29 |
*** chenleji has quit IRC | 09:32 | |
*** chenleji has joined #openstack-neutron | 09:33 | |
*** scheuran has quit IRC | 09:34 | |
*** markvoelker has quit IRC | 09:34 | |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Fix dist_fip_count problem during router migration https://review.openstack.org/151153 | 09:34 |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Fixed L3 agent manual scheduling for HA routers https://review.openstack.org/143297 | 09:37 |
*** nyechiel has quit IRC | 09:37 | |
*** Miouge has joined #openstack-neutron | 09:45 | |
*** lpetrut has quit IRC | 09:47 | |
*** lpetrut has joined #openstack-neutron | 09:47 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Refactor _convert_sgr_to_iptables_rules in iptables_firewall https://review.openstack.org/150833 | 09:48 |
ajo | haleyb , rossella_s ^ addressed your comment, and refactored an extra (common) part out to a function | 09:48 |
rossella_s | ajo: thanks! | 09:49 |
*** scheuran has joined #openstack-neutron | 09:49 | |
*** moshele has joined #openstack-neutron | 09:49 | |
rossella_s | ajo: you are so fast | 09:50 |
rossella_s | :p | 09:50 |
*** tomoe_ has quit IRC | 09:50 | |
ajo | rossella_s, sadly sometimes only :/, when I'm not too swamped with D/S things | 09:50 |
rossella_s | ajo: I know that feeling | 09:51 |
ajo | :] | 09:51 |
*** yfried__ has quit IRC | 09:52 | |
*** a_le has quit IRC | 09:52 | |
*** hanzhang has joined #openstack-neutron | 09:57 | |
*** shz has quit IRC | 09:59 | |
*** Marga_ has joined #openstack-neutron | 10:00 | |
*** salv-orlando has joined #openstack-neutron | 10:00 | |
*** igordcard has joined #openstack-neutron | 10:02 | |
*** feleouet has quit IRC | 10:04 | |
*** matrohon has quit IRC | 10:04 | |
*** yapeng has joined #openstack-neutron | 10:06 | |
*** mohitsharma has quit IRC | 10:07 | |
*** mohitsharma has joined #openstack-neutron | 10:08 | |
*** pask811 has quit IRC | 10:10 | |
*** yapeng has quit IRC | 10:10 | |
*** Miouge has quit IRC | 10:12 | |
*** changbl has quit IRC | 10:12 | |
trinaths | Initial py27 tests fail for neutron-fwaas with the error http://paste.openstack.org/show/163598/ . Is there any wrong with the repository? | 10:12 |
*** chlong has joined #openstack-neutron | 10:13 | |
*** karimb has quit IRC | 10:15 | |
*** aepifanov has quit IRC | 10:15 | |
*** aepifanov has joined #openstack-neutron | 10:15 | |
*** tellesnobrega_ has joined #openstack-neutron | 10:17 | |
*** a_le has joined #openstack-neutron | 10:19 | |
*** oreillyd has joined #openstack-neutron | 10:20 | |
*** akamyshnikova has quit IRC | 10:20 | |
*** akamyshnikova has joined #openstack-neutron | 10:22 | |
*** mohitsharma has quit IRC | 10:22 | |
*** addnull has quit IRC | 10:24 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional tests https://review.openstack.org/143412 | 10:24 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Refactor Pinger class https://review.openstack.org/151167 | 10:24 |
*** pask81 has joined #openstack-neutron | 10:25 | |
*** anilvenkata has quit IRC | 10:25 | |
*** chlong has quit IRC | 10:27 | |
*** mohitsharma has joined #openstack-neutron | 10:27 | |
*** hanzhang has quit IRC | 10:28 | |
*** markvoelker has joined #openstack-neutron | 10:30 | |
*** karimb has joined #openstack-neutron | 10:30 | |
*** a_le has quit IRC | 10:30 | |
*** karimb has quit IRC | 10:30 | |
*** geekinutah has quit IRC | 10:31 | |
*** karimb has joined #openstack-neutron | 10:31 | |
*** pask811 has joined #openstack-neutron | 10:31 | |
*** mohitsharma has quit IRC | 10:32 | |
*** pask81 has quit IRC | 10:34 | |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Default security group table https://review.openstack.org/142101 | 10:34 |
*** markvoelker has quit IRC | 10:34 | |
*** nyechiel has joined #openstack-neutron | 10:35 | |
*** scheuran has quit IRC | 10:35 | |
*** geekinutah has joined #openstack-neutron | 10:36 | |
*** harlowja_away has quit IRC | 10:36 | |
*** pradipta is now known as pradipta_away | 10:39 | |
*** tellesnobrega_ has quit IRC | 10:43 | |
*** chlong has joined #openstack-neutron | 10:44 | |
*** scheuran has joined #openstack-neutron | 10:49 | |
*** Marga_ has quit IRC | 10:49 | |
*** stanzgy has quit IRC | 10:51 | |
ajo | salv-orlando, ping, what's the future of extensions?, are we going to pull all them in to the core models?, | 10:53 |
ajo | will we allow extensions in the future, or that kind of stuff should go directly , not as a extension? | 10:54 |
*** pask811 has quit IRC | 10:54 | |
ajo | (I was looking at the -not for now- qos spec from Sean Collins) | 10:54 |
*** pask81 has joined #openstack-neutron | 10:55 | |
*** tellesnobrega_ has joined #openstack-neutron | 11:00 | |
*** tellesnobrega_ has quit IRC | 11:06 | |
*** tellesnobrega_ has joined #openstack-neutron | 11:07 | |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Fix dist_fip_count problem during router migration https://review.openstack.org/151153 | 11:07 |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Remove qg from router namespace for DVR migration https://review.openstack.org/151181 | 11:07 |
*** xuhanp has quit IRC | 11:07 | |
*** Miouge has joined #openstack-neutron | 11:08 | |
*** oomichi has quit IRC | 11:08 | |
*** jlanoux has joined #openstack-neutron | 11:08 | |
*** tellesnobrega_ has quit IRC | 11:11 | |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Default security group table https://review.openstack.org/142101 | 11:12 |
trinaths | Initial py27 tests fail for neutron-fwaas with the error http://paste.openstack.org/show/163598/ . Is there any wrong with the repository? An error on ReouterInfo, from neutron/agents/l3/reouter_info.py | 11:13 |
openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn https://review.openstack.org/145005 | 11:15 |
*** Marga_ has joined #openstack-neutron | 11:19 | |
*** Marga_ has quit IRC | 11:20 | |
*** Marga_ has joined #openstack-neutron | 11:21 | |
*** achanda has quit IRC | 11:22 | |
*** anish_ has joined #openstack-neutron | 11:23 | |
*** Marga_ has quit IRC | 11:25 | |
openstackgerrit | Moshe Levi proposed openstack/neutron: Thin MLNX ML2 mechanism driver and agent https://review.openstack.org/148614 | 11:26 |
*** pask81 has quit IRC | 11:26 | |
*** oomichi_ has joined #openstack-neutron | 11:27 | |
*** pask81 has joined #openstack-neutron | 11:28 | |
*** markvoelker has joined #openstack-neutron | 11:31 | |
*** doude has quit IRC | 11:31 | |
*** pask81 has quit IRC | 11:32 | |
*** markvoelker has quit IRC | 11:35 | |
*** igordcard has quit IRC | 11:37 | |
*** igordcard has joined #openstack-neutron | 11:39 | |
*** chlong has quit IRC | 11:39 | |
*** aix has joined #openstack-neutron | 11:40 | |
*** igordcard has quit IRC | 11:41 | |
*** pc_m has joined #openstack-neutron | 11:43 | |
*** Miouge has quit IRC | 11:43 | |
*** karimb has quit IRC | 11:46 | |
*** baoli has joined #openstack-neutron | 11:48 | |
*** pask81 has joined #openstack-neutron | 11:49 | |
*** amotoki has quit IRC | 11:51 | |
enikanorov_ | rossella_s: wanted to ask, how that decorator should be used (from oslo.db) | 11:51 |
*** yapeng has joined #openstack-neutron | 11:55 | |
*** karimb has joined #openstack-neutron | 11:55 | |
*** olc has quit IRC | 11:56 | |
trinaths | pc_m: Hi | 11:57 |
*** yapeng has quit IRC | 11:59 | |
*** oomichi_ has quit IRC | 11:59 | |
pc_m | trinaths: hi | 12:01 |
*** pal has quit IRC | 12:01 | |
*** olc has joined #openstack-neutron | 12:02 | |
*** chlong has joined #openstack-neutron | 12:05 | |
trinaths | pc_m: thanks for the review. I have answered your questions/comments on the code with new patchset. | 12:07 |
pc_m | trinaths: ok. I'll be getting to reviews in a little while and can look at it. | 12:07 |
*** radez_g0n3 is now known as radez | 12:08 | |
trinaths | pc_m: okay. There is some issue with fwaas repo. py27 tests fail at RouterInfo lib. | 12:08 |
rossella_s | enikanorov_ : the same way the safe_for_db_retry is used, just for deadlock error | 12:09 |
rossella_s | enikanorov_: does that answer your question? | 12:09 |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Fixed L3 agent manual scheduling for HA routers https://review.openstack.org/143297 | 12:09 |
enikanorov_ | rossella_s: i mean, i can't just wrap any method with safe_for_db_retry, can I? | 12:09 |
trinaths | pc_m: here is the log I captured. http://paste.openstack.org/show/163598/ . Did not find the real reason behind. | 12:10 |
enikanorov_ | rossella_s: is there an example anywhare? | 12:10 |
*** trinaths has quit IRC | 12:10 | |
enikanorov_ | rossella_s: when i was adding UT for the new feature of the wrapper, I had to call it directly, decorator itself is not enough | 12:11 |
rossella_s | enikanorov_ : I think you can add it to any method | 12:12 |
rossella_s | enikanorov_ : in the UT I added for my patch, I decorated a test method, that was enough | 12:13 |
rossella_s | enikanorov_ : look at DBDeadlockTestCase ... | 12:13 |
*** lazy_prince has quit IRC | 12:14 | |
*** raildo has joined #openstack-neutron | 12:14 | |
enikanorov_ | i don't quite understand, honestly. Code says that decorated dbapi calls will be repeated | 12:14 |
enikanorov_ | i'm not sure if that's what we want | 12:14 |
enikanorov_ | i just don't understand how the decorator is invoked | 12:15 |
enikanorov_ | when you decorate any method with any of these decorators - it will not add retries, unless decorated method has some dbapi call inside | 12:16 |
*** oomichi_ has joined #openstack-neutron | 12:16 | |
*** Miouge has joined #openstack-neutron | 12:16 | |
enikanorov_ | but i don't understand what part is then retried upon any of supported conditions | 12:16 |
rossella_s | enikanorov_ : what part...what do you mean? the whole method decorated will be retried, is that your question? | 12:17 |
*** killer_prince has joined #openstack-neutron | 12:18 | |
*** killer_prince is now known as lazy_prince | 12:18 | |
enikanorov_ | rossella_s: that would be my expectation, but that's not so I guess | 12:18 |
rossella_s | enikanorov_ : why do you say so? do you have any evidence? btw I am pretty sure there's an example for that decorator somewhere in the code but I can't find it right now | 12:18 |
enikanorov_ | def retry_on_deadlock(f): | 12:19 |
enikanorov_ | f.enable_retry_on_deadlock = True | 12:19 |
enikanorov_ | return f | 12:19 |
*** anilvenkata has joined #openstack-neutron | 12:19 | |
enikanorov_ | it doesn't do anything, as you see | 12:19 |
enikanorov_ | so this decorator itself will not make f to repeat | 12:19 |
enikanorov_ | i guess f has to have calls to dbapi inside to make this magic work | 12:21 |
*** Marga_ has joined #openstack-neutron | 12:22 | |
rossella_s | yep...it works only for dbapi, you are right | 12:22 |
rossella_s | the magic is in __getattr__ of DBApi | 12:22 |
*** baoli has quit IRC | 12:22 | |
rossella_s | so it won't work for any method, you are right | 12:22 |
rossella_s | sorry I have to go right now, I will be back after lunch, will ping you then | 12:22 |
*** Marga_ has quit IRC | 12:26 | |
*** vks has quit IRC | 12:29 | |
*** markvoelker has joined #openstack-neutron | 12:31 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Implements the ProcessMonitor in the l3_agent https://review.openstack.org/114931 | 12:32 |
*** neeti has quit IRC | 12:33 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Implements the ProcessMonitor in the l3_agent https://review.openstack.org/114931 | 12:35 |
*** markvoelker has quit IRC | 12:36 | |
openstackgerrit | Dane LeBlanc proposed openstack/neutron: Support Multiple IPv6 Prefixes and Addresses for IPv6 Network https://review.openstack.org/113339 | 12:37 |
*** tomoe_ has joined #openstack-neutron | 12:37 | |
*** amuller has joined #openstack-neutron | 12:41 | |
*** julim has joined #openstack-neutron | 12:43 | |
*** baoli has joined #openstack-neutron | 12:45 | |
*** belmoreira has quit IRC | 12:46 | |
*** julim_ has quit IRC | 12:46 | |
*** avozza is now known as zz_avozza | 12:46 | |
*** baoli_ has joined #openstack-neutron | 12:46 | |
*** mwagner_lap has quit IRC | 12:47 | |
*** baoli_ has quit IRC | 12:48 | |
*** baoli has quit IRC | 12:50 | |
*** baoli has joined #openstack-neutron | 12:50 | |
*** zz_avozza is now known as avozza | 12:53 | |
openstackgerrit | Russell Bryant proposed openstack/neutron: Scope dvr rpc api using a messaging namespace https://review.openstack.org/149735 | 12:56 |
*** adam_g is now known as adam_g_out | 12:57 | |
*** Networkn3rd has quit IRC | 13:00 | |
*** doude has joined #openstack-neutron | 13:04 | |
*** yatin has quit IRC | 13:06 | |
ZZelle | ChuckC, hi | 13:06 |
*** thorst1 has joined #openstack-neutron | 13:07 | |
*** karimb has quit IRC | 13:07 | |
*** Miouge has quit IRC | 13:09 | |
*** Miouge has joined #openstack-neutron | 13:12 | |
*** ronis_ has quit IRC | 13:13 | |
*** oomichi_ has quit IRC | 13:14 | |
*** EmilienM|afk is now known as EmilienM | 13:14 | |
*** yshafrir has quit IRC | 13:15 | |
*** radez is now known as radez_g0n3 | 13:19 | |
*** Miouge has quit IRC | 13:20 | |
*** Marga_ has joined #openstack-neutron | 13:22 | |
*** pal has joined #openstack-neutron | 13:23 | |
*** nmagnezi has quit IRC | 13:23 | |
*** Miouge has joined #openstack-neutron | 13:23 | |
*** Marga_ has quit IRC | 13:27 | |
*** nmagnezi has joined #openstack-neutron | 13:30 | |
*** irenab has joined #openstack-neutron | 13:31 | |
*** boris-42 has joined #openstack-neutron | 13:31 | |
*** markvoelker has joined #openstack-neutron | 13:33 | |
openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Fix the neutron-vpnaas unit test failures https://review.openstack.org/151233 | 13:34 |
*** markvoelker has quit IRC | 13:35 | |
*** markvoelker_ has joined #openstack-neutron | 13:35 | |
rossella_s | enikanorov_ ping | 13:36 |
enikanorov_ | rossella_s: pong | 13:36 |
*** Miouge has quit IRC | 13:36 | |
rossella_s | enikanorov_ : I am back, so yes if you were planning to use that decorator outside of the DBAPI it won't work | 13:36 |
rossella_s | enikanorov_ : it that what you are hitting? | 13:36 |
enikanorov_ | rossella_s: so basically my question was, is it enough to wrap any method having session.begin() with those decorators? | 13:37 |
rossella_s | enikanorov_ : I don't think so... | 13:37 |
rossella_s | enikanorov_ : but I should check...I wrote that patch long ago | 13:38 |
enikanorov_ | rossella_s: then it's not clear how it can help | 13:38 |
*** amotoki has joined #openstack-neutron | 13:41 | |
openstackgerrit | Jian LI proposed openstack/neutron: Fix extra-dhcp-opt on stateless dhcpv6 subnet https://review.openstack.org/147455 | 13:42 |
rossella_s | enikanorov_ : sorry my memory is a bit blurred ...when I created that patch if i good remember we were not using oslo.db and we had the DBAPI defined in the neutron tree under openstack common. My idea to use that decorator was to put it on top of some method there | 13:42 |
enikanorov_ | rossella_s: yes, for sure, i'd expect that one decorator is enough. | 13:43 |
enikanorov_ | ok, i'll probably have to dig into the code and make some research | 13:43 |
rossella_s | enikanorov_ : sorry but I don't remember the details right now, I will also look into it and try to remember | 13:44 |
*** yapeng has joined #openstack-neutron | 13:44 | |
rossella_s | enikanorov_ : it's probably worth asking to the oslo people...probably to the authors of the safe_for_db_retry | 13:44 |
*** chenleji has quit IRC | 13:45 | |
*** chenleji has joined #openstack-neutron | 13:45 | |
*** flaviof has quit IRC | 13:47 | |
*** trinaths has joined #openstack-neutron | 13:48 | |
*** yapeng has quit IRC | 13:48 | |
*** txomon|fon has quit IRC | 13:53 | |
*** moshele has quit IRC | 13:53 | |
*** changbl has joined #openstack-neutron | 13:54 | |
*** Miouge has joined #openstack-neutron | 13:55 | |
*** moshele has joined #openstack-neutron | 13:55 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Implements the ProcessMonitor in the l3_agent https://review.openstack.org/114931 | 13:55 |
*** anshul has quit IRC | 13:56 | |
*** moshele has quit IRC | 13:57 | |
*** moshele has joined #openstack-neutron | 13:57 | |
*** jistr has quit IRC | 13:58 | |
openstackgerrit | Lionel Zerbib proposed openstack/neutron-specs: RST for blueprint security-group-brute-force-prevention https://review.openstack.org/151247 | 13:58 |
*** trinaths has quit IRC | 13:59 | |
*** jistr has joined #openstack-neutron | 14:00 | |
*** trinaths has joined #openstack-neutron | 14:00 | |
*** rushil has joined #openstack-neutron | 14:03 | |
*** avozza is now known as zz_avozza | 14:04 | |
*** txomon|fon has joined #openstack-neutron | 14:05 | |
trinaths | SumitNaiksatam: ping | 14:07 |
*** feleouet has joined #openstack-neutron | 14:07 | |
*** rkukura has joined #openstack-neutron | 14:08 | |
*** Marga_ has joined #openstack-neutron | 14:09 | |
*** dims has joined #openstack-neutron | 14:10 | |
*** mwagner_lap has joined #openstack-neutron | 14:12 | |
*** claudiub has joined #openstack-neutron | 14:14 | |
*** dims has quit IRC | 14:14 | |
*** banix has joined #openstack-neutron | 14:16 | |
*** dane_leblanc has quit IRC | 14:18 | |
*** ronis_ has joined #openstack-neutron | 14:18 | |
*** aleksandr_null has quit IRC | 14:19 | |
*** aleksandr_null has joined #openstack-neutron | 14:21 | |
*** zzzeek has joined #openstack-neutron | 14:22 | |
*** banix has quit IRC | 14:25 | |
*** Murali has quit IRC | 14:27 | |
*** banix has joined #openstack-neutron | 14:27 | |
*** flaviof has joined #openstack-neutron | 14:27 | |
*** cference has joined #openstack-neutron | 14:28 | |
*** mriedem has joined #openstack-neutron | 14:28 | |
mriedem | obondarev: have you seen this? https://review.openstack.org/#/c/151184/ | 14:28 |
rossella_s | enikanorov_, maybe this can help #link http://lists.openstack.org/pipermail/openstack-dev/2013-July/012296.html | 14:30 |
*** aveiga has quit IRC | 14:31 | |
*** vthapar has quit IRC | 14:31 | |
*** aveiga has joined #openstack-neutron | 14:32 | |
*** heyongli has quit IRC | 14:33 | |
*** karimb has joined #openstack-neutron | 14:33 | |
*** jasondot_ has joined #openstack-neutron | 14:34 | |
*** tiswanso has joined #openstack-neutron | 14:34 | |
*** heyongli has joined #openstack-neutron | 14:36 | |
*** lpetrut1 has joined #openstack-neutron | 14:37 | |
*** jlibosva has quit IRC | 14:37 | |
*** lpetrut has quit IRC | 14:37 | |
*** jlibosva has joined #openstack-neutron | 14:38 | |
*** zzzeek has quit IRC | 14:39 | |
*** cburgess has quit IRC | 14:39 | |
*** irenab has quit IRC | 14:40 | |
*** irenab has joined #openstack-neutron | 14:40 | |
*** tomoe_ has quit IRC | 14:41 | |
*** cburgess has joined #openstack-neutron | 14:41 | |
*** dims has joined #openstack-neutron | 14:41 | |
openstackgerrit | Sergey Belous proposed openstack/neutron: Added check for emptyness where in_ is being used https://review.openstack.org/150034 | 14:44 |
*** aveiga has quit IRC | 14:45 | |
*** jasondot_ has quit IRC | 14:45 | |
*** pal has quit IRC | 14:46 | |
*** aveiga has joined #openstack-neutron | 14:46 | |
*** r-daneel has joined #openstack-neutron | 14:51 | |
*** mlavalle has joined #openstack-neutron | 14:55 | |
*** dane_leblanc has joined #openstack-neutron | 14:56 | |
*** RichardRaseley has joined #openstack-neutron | 14:57 | |
*** irenab has quit IRC | 15:01 | |
*** yeungp has joined #openstack-neutron | 15:02 | |
*** markvoelker_ has quit IRC | 15:03 | |
*** TrevorV_ has joined #openstack-neutron | 15:03 | |
*** heyongli has quit IRC | 15:04 | |
*** gaud has joined #openstack-neutron | 15:04 | |
*** irenab has joined #openstack-neutron | 15:04 | |
*** seizadi has joined #openstack-neutron | 15:05 | |
*** zz_avozza is now known as avozza | 15:05 | |
*** heyongli has joined #openstack-neutron | 15:07 | |
*** oreillyd has quit IRC | 15:08 | |
*** oreillyd has joined #openstack-neutron | 15:08 | |
*** jistr has quit IRC | 15:10 | |
*** RichardRaseley has quit IRC | 15:11 | |
*** jistr has joined #openstack-neutron | 15:12 | |
*** Marga_ has quit IRC | 15:12 | |
trinaths | pc_m: hi, I agree with your comments. Do I need to raise a bug on this. | 15:12 |
*** Marga_ has joined #openstack-neutron | 15:12 | |
*** mriedem has left #openstack-neutron | 15:13 | |
*** irenab has quit IRC | 15:13 | |
*** irenab has joined #openstack-neutron | 15:14 | |
*** jobewan has joined #openstack-neutron | 15:16 | |
*** numan has quit IRC | 15:16 | |
*** sergsh is now known as sergsh_away | 15:17 | |
*** kbringard has joined #openstack-neutron | 15:18 | |
*** irenab has quit IRC | 15:19 | |
*** ZZelle has quit IRC | 15:19 | |
*** jprovazn has joined #openstack-neutron | 15:20 | |
*** ZZelle has joined #openstack-neutron | 15:20 | |
*** nmagnezi has quit IRC | 15:20 | |
*** obondarev_ has joined #openstack-neutron | 15:21 | |
*** irenab has joined #openstack-neutron | 15:22 | |
*** avozza is now known as zz_avozza | 15:24 | |
*** obondarev has quit IRC | 15:24 | |
*** radez_g0n3 is now known as radez | 15:26 | |
*** zz_avozza is now known as avozza | 15:26 | |
*** signed8bit has joined #openstack-neutron | 15:31 | |
*** achanda has joined #openstack-neutron | 15:31 | |
*** anish_ has quit IRC | 15:32 | |
*** yapeng has joined #openstack-neutron | 15:32 | |
*** TrevorV_ has quit IRC | 15:35 | |
*** irenab has quit IRC | 15:35 | |
*** packet has joined #openstack-neutron | 15:35 | |
*** irenab has joined #openstack-neutron | 15:36 | |
*** dane_leblanc has quit IRC | 15:36 | |
*** yapeng has quit IRC | 15:37 | |
*** tiswanso has quit IRC | 15:39 | |
*** dane_leblanc has joined #openstack-neutron | 15:39 | |
*** seizadi has quit IRC | 15:40 | |
*** achanda has quit IRC | 15:41 | |
*** jlibosva has quit IRC | 15:41 | |
rossella_s | enikanorov_ : so I had some time to look into that issue again, now I remember. The magic is in __get_attr__ as I was saying before | 15:43 |
openstackgerrit | Sridhar Gaddam proposed openstack/neutron: Add sanity_check for keepalived https://review.openstack.org/151284 | 15:43 |
*** irenab has quit IRC | 15:43 | |
rossella_s | enikanorov_, As first step __get_attr__ will load a backend. If you see in the UT the backend is set to be test_api.DBAPI or in Nova the backend is db/sqlalchemy/api.py . After loading the backend, the methods who have a decorator set will be retried in the appropriate manner. This works only for the methods defined in the backend. Hope it's clear now. | 15:43 |
*** irenab has joined #openstack-neutron | 15:44 | |
openstackgerrit | Michael Smith proposed openstack/neutron: This patch will be used to compare dvr vs full neturon runs https://review.openstack.org/141897 | 15:45 |
*** markvoelker has joined #openstack-neutron | 15:45 | |
*** SridharG has left #openstack-neutron | 15:45 | |
*** dims has quit IRC | 15:46 | |
*** banix has quit IRC | 15:46 | |
*** jlibosva has joined #openstack-neutron | 15:47 | |
*** dims has joined #openstack-neutron | 15:48 | |
*** devvesa has quit IRC | 15:48 | |
*** Networkn3rd has joined #openstack-neutron | 15:49 | |
*** banix has joined #openstack-neutron | 15:50 | |
*** irenab has quit IRC | 15:55 | |
*** marun has joined #openstack-neutron | 15:55 | |
*** irenab has joined #openstack-neutron | 15:56 | |
*** salv-orlando has quit IRC | 15:57 | |
*** salv-orlando has joined #openstack-neutron | 15:57 | |
*** yamahata has joined #openstack-neutron | 15:57 | |
*** obondarev_ has quit IRC | 15:58 | |
*** jlibosva has quit IRC | 15:58 | |
*** obondarev has joined #openstack-neutron | 15:59 | |
*** dims has quit IRC | 15:59 | |
*** prad has joined #openstack-neutron | 15:59 | |
*** jlibosva has joined #openstack-neutron | 16:00 | |
*** bharath has joined #openstack-neutron | 16:03 | |
*** thedodd has joined #openstack-neutron | 16:04 | |
*** ronis_ has quit IRC | 16:05 | |
*** irenab has quit IRC | 16:05 | |
*** carl_baldwin has joined #openstack-neutron | 16:05 | |
carl_baldwin | pc_m: ping | 16:06 |
*** padkrish has joined #openstack-neutron | 16:06 | |
pc_m | carl_baldwin: pong | 16:06 |
pc_m | carl_baldwin: Hi! | 16:06 |
carl_baldwin | Thanks for taking the reins this morning. | 16:07 |
*** manishg has joined #openstack-neutron | 16:07 | |
carl_baldwin | pc_m: No excuse, I just dropped the ball this morning. | 16:07 |
*** a_le has joined #openstack-neutron | 16:07 | |
*** apuimedo has quit IRC | 16:07 | |
pc_m | carl_baldwin: np. It was a feeble attempt, but we got through | 16:07 |
carl_baldwin | I’m reading through the logs. | 16:08 |
pc_m | carl_baldwin: Please check the logs. There is an issue with DVR tests failing all over. Something with server startup. | 16:08 |
*** krtaylor has quit IRC | 16:08 | |
*** irenab has joined #openstack-neutron | 16:09 | |
pc_m | carl_baldwin: Also, I added you to a VPN review, just as an FYI. https://review.openstack.org/151233 | 16:09 |
carl_baldwin | pc_m: Thanks. | 16:09 |
pc_m | carl_baldwin: Looks like RouterInfo signature change, broke VPN tests. | 16:10 |
*** padkrish has quit IRC | 16:10 | |
pc_m | carl_baldwin: Would be nice if we can mitigate those types of issues. | 16:10 |
*** manishg_ has joined #openstack-neutron | 16:10 | |
*** zz_jgrimm is now known as jgrimm | 16:10 | |
*** apuimedo has joined #openstack-neutron | 16:10 | |
*** devvesa has joined #openstack-neutron | 16:10 | |
*** avozza is now known as zz_avozza | 16:10 | |
*** padkrish has joined #openstack-neutron | 16:11 | |
carl_baldwin | pc_m: It is going to take a little bit before a stable interface can be achieved. | 16:11 |
carl_baldwin | pc_m: I understand though. | 16:11 |
pc_m | carl_baldwin: Not sure if there is a good solution, without a lot of effort. | 16:11 |
pc_m | carl_baldwin: Just wondering how we can catch that, before commits. | 16:11 |
pc_m | before merge that is. | 16:11 |
*** manishg has quit IRC | 16:12 | |
carl_baldwin | It would be best if there was a testing which could +1/ | 16:12 |
*** rpothier has joined #openstack-neutron | 16:12 | |
carl_baldwin | -1 on patches that break such things. | 16:12 |
carl_baldwin | pc_m: ^ | 16:12 |
*** nyechiel has quit IRC | 16:12 | |
pc_m | carl_baldwin: Yeah, but I think it went through and was merged. and then, when someone did a VPN commit, tests failed, due to the Neutron change. | 16:13 |
pc_m | carl_baldwin: It's gonna be hard to tell if a change effects one of the services repos... | 16:13 |
pc_m | carl_baldwin: Unless all Neutron commits run services' tests? | 16:14 |
carl_baldwin | pc_m: Right, that is how it is now. My suggestion is that VPN have a test which runs before merge in the Neutron repo. Either a separate CI or a test in the Jenkins suite. | 16:14 |
carl_baldwin | pc_m: It is something worth discussing with the Neutron team. | 16:14 |
*** obondarev has quit IRC | 16:15 | |
pc_m | carl_baldwin: So when a neutron commit is done, it runs the VPN tests? | 16:15 |
pc_m | UTs | 16:15 |
*** apuimedo has quit IRC | 16:15 | |
*** obondarev has joined #openstack-neutron | 16:15 | |
carl_baldwin | pc_m: If I understand you correctly, no. VPN tests would run on each patch set in neutron is what I’m thinking. | 16:16 |
carl_baldwin | pc_m: But I’m not sure what you mean by “when a neutron commit is done" | 16:16 |
openstackgerrit | Trinath Somanchi proposed openstack/neutron-fwaas: Move 'def _make_firewall_dict_with_rules' from fwaas_plugin.py to firewall_db.py https://review.openstack.org/151298 | 16:16 |
*** pal has joined #openstack-neutron | 16:16 | |
pc_m | carl_baldwin: So, I think a neutron commit, changed RouterInfo() signature. All the neutron tests were updated, so everything passed. | 16:17 |
*** evgenyf has quit IRC | 16:17 | |
carl_baldwin | pc_m: I know how it happened. I’m suggesting a possible change to mitigate it. | 16:17 |
pc_m | carl_baldwin: However, the VPN repo uses RouterInfo() in tests (for good or bad). When those tests run, on any VPN commit, they fail. | 16:17 |
*** jkraj has joined #openstack-neutron | 16:18 | |
ZZelle | ajo, hi | 16:18 |
pc_m | carl_baldwin: Seems like we need Neutron commits to run client (services') tests? | 16:18 |
carl_baldwin | pc_m: Yes, I’m suggesting something like that. | 16:18 |
carl_baldwin | pc_m: I’m not sure what the best way to handle doing that is, though. | 16:19 |
pc_m | I can't see any other way that is easy... | 16:19 |
*** seizadi has joined #openstack-neutron | 16:19 | |
*** ihrachyshka has quit IRC | 16:20 | |
carl_baldwin | pc_m: Of course, we still get breakage. However, we’ll get a little more advanced notice and be prepared to merge a corresponding fix in VPN. | 16:20 |
pc_m | carl_baldwin: true. | 16:21 |
*** krtaylor has joined #openstack-neutron | 16:21 | |
carl_baldwin | pc_m: We can’t have a voting or gating job on neutron because of the whole chicken and egg problem. However, we can get the commits as close as possible to shorten failure time. | 16:22 |
openstackgerrit | Billy Olsen proposed openstack/neutron: Refactor logging in loop to only log debug messages once https://review.openstack.org/149784 | 16:22 |
carl_baldwin | pc_m: I was going to write a spec on how to get patches gated together across repositories but I have not finished that spec. | 16:22 |
pc_m | carl_baldwin: I think the FW folks had similar concerns with commits that needed to be made in two repos for work. | 16:23 |
*** Sukhdev has joined #openstack-neutron | 16:23 | |
carl_baldwin | pc_m: It is a legitimate concern that we need to look into. | 16:24 |
pc_m | carl_baldwin: I think LBaaS did it by committing with a commit message indicating that the UTs are broken, until the other repo commit goes in. | 16:24 |
pc_m | carl_baldwin: Granted, I think that was for a new change and not refactoring/bugfixing | 16:24 |
pc_m | carl_baldwin: Good idea to be bringing it up with community. | 16:25 |
pc_m | carl_baldwin: awareness is half the battle. | 16:25 |
carl_baldwin | pc_m: Yes. | 16:25 |
*** zzzeek has joined #openstack-neutron | 16:25 | |
*** jschwarz has joined #openstack-neutron | 16:26 | |
*** armax has joined #openstack-neutron | 16:27 | |
*** armax has quit IRC | 16:28 | |
*** lazy_prince is now known as killer_prince | 16:30 | |
*** regXboi has joined #openstack-neutron | 16:31 | |
*** dims has joined #openstack-neutron | 16:32 | |
*** itzikb has quit IRC | 16:32 | |
*** tflynn has joined #openstack-neutron | 16:32 | |
bharath | Hi, anyone reproduced this bug https://bugs.launchpad.net/neutron/+bug/1317363 ? | 16:33 |
*** dims has quit IRC | 16:34 | |
*** tflynn has quit IRC | 16:35 | |
*** seizadi has quit IRC | 16:35 | |
marun | HenryG: I think we have a winner - https://review.openstack.org/#/c/142101/ | 16:35 |
*** tflynn has joined #openstack-neutron | 16:35 | |
*** devvesa has quit IRC | 16:36 | |
openstackgerrit | Trinath Somanchi proposed openstack/neutron-fwaas: Move '_make_firewall_dict_with_rules' from fwaas_plugin.py to firewall_db.py https://review.openstack.org/151298 | 16:36 |
*** vhosakot has joined #openstack-neutron | 16:36 | |
pc_m | carl_baldwin: Can you review this, when you can: https://review.openstack.org/150990 | 16:36 |
pc_m | carl_baldwin: It is the vpn repo side of the functional gate setup work | 16:37 |
carl_baldwin | pc_m: Yes. | 16:37 |
pc_m | carl_baldwin: Thanks! | 16:37 |
*** dims has joined #openstack-neutron | 16:38 | |
*** armax has joined #openstack-neutron | 16:38 | |
vhosakot | Hi, I observed that the python neutron client is not thread safe, and if I call the "create_port" API twice simultaneously in two threads, I see that only one of them pass.. Sometimes, both pass... Is this the expected behavior ? Can anyone please tell me if they have used the "create_port" API simultaneously in multiple threads ? If yes, how to do it ? | 16:39 |
carl_baldwin | pc_m: re: https://review.openstack.org/#/c/151233 I gave -1 with one suggestion. If you don’t want to turn around the patch for it, I can change my mind. | 16:39 |
*** Murali has joined #openstack-neutron | 16:39 | |
carl_baldwin | pc_m: I’d even be happy to do the turn-around. But, then we’ll have to wait for tests. | 16:40 |
pc_m | carl_baldwin: looking | 16:40 |
*** obondarev has quit IRC | 16:41 | |
pc_m | carl_baldwin: Actually, that is a great idea! Probably the best way to handle modifying the signature too. | 16:42 |
HenryG | marun: will get to it soon | 16:42 |
*** obondarev has joined #openstack-neutron | 16:42 | |
*** kbringard has quit IRC | 16:42 | |
carl_baldwin | pc_m: There is actually one wrinkle. The tests are across two classes which makes sharing the kwargs dict a little less advantageous. | 16:43 |
*** doude has quit IRC | 16:43 | |
pc_m | carl_baldwin: I guess the big question is whether we should try to fix it ASAP, or get the tests working and do a simple commit for the change to make it less fragile. Thoughts? | 16:45 |
carl_baldwin | Either way. | 16:45 |
carl_baldwin | If you want to get the tests fixed quickly, we can just approve this one now. | 16:45 |
pc_m | Given, everything is broken... as separate commit may be better. | 16:45 |
pc_m | carl_baldwin: Yeah, I'm thinking we can just follow up with another fix for that. | 16:46 |
carl_baldwin | pc_m: +2/+A | 16:47 |
pc_m | thanks! | 16:47 |
pc_m | I can file a bug and get that change in. | 16:47 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Do not run neutron-ns-metadata-proxy as root on dhcp agent https://review.openstack.org/147437 | 16:48 |
*** jaypipes has joined #openstack-neutron | 16:48 | |
pc_m | carl_baldwin: Appreciate the help on this. Will ttyl. I have to get some lunch... | 16:48 |
*** packet has quit IRC | 16:49 | |
*** tflynn has quit IRC | 16:49 | |
carl_baldwin | pc_m: later. | 16:49 |
*** pc_m has quit IRC | 16:49 | |
*** tflynn has joined #openstack-neutron | 16:49 | |
*** david-lyle_afk is now known as david-lyle | 16:49 | |
*** nlahouti has joined #openstack-neutron | 16:50 | |
*** vhosakot has quit IRC | 16:52 | |
*** SridharRamaswamy has joined #openstack-neutron | 16:53 | |
*** RichardRaseley has joined #openstack-neutron | 16:55 | |
*** padkrish has quit IRC | 16:55 | |
*** rwsu-afk is now known as rwsu | 16:55 | |
*** packet has joined #openstack-neutron | 16:57 | |
*** dane_leblanc has quit IRC | 16:57 | |
*** jlanoux has quit IRC | 16:58 | |
*** kbringard has joined #openstack-neutron | 16:59 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Refactor Pinger class https://review.openstack.org/151167 | 17:00 |
*** pask81 has quit IRC | 17:00 | |
*** padkrish has joined #openstack-neutron | 17:01 | |
*** rotbeard has quit IRC | 17:01 | |
*** dane_leblanc has joined #openstack-neutron | 17:01 | |
*** scheuran has quit IRC | 17:01 | |
*** mlavalle has quit IRC | 17:01 | |
*** dsundarraj has joined #openstack-neutron | 17:02 | |
*** krtaylor has quit IRC | 17:03 | |
*** markvoelker has quit IRC | 17:03 | |
*** krtaylor has joined #openstack-neutron | 17:05 | |
*** tflynn has quit IRC | 17:07 | |
*** afazekas has quit IRC | 17:07 | |
*** jkraj has quit IRC | 17:08 | |
*** coolsvap is now known as coolsvap|afk | 17:10 | |
*** safchain has quit IRC | 17:10 | |
*** _cjones_ has joined #openstack-neutron | 17:10 | |
openstackgerrit | Sukhdev Kapur proposed openstack/neutron: Fixing a log message in Arista L3 Service Plugin https://review.openstack.org/147976 | 17:11 |
*** manishg_ has quit IRC | 17:11 | |
openstackgerrit | Trinath Somanchi proposed openstack/neutron-fwaas: Freescale FWaaS Plugin https://review.openstack.org/148884 | 17:13 |
*** ihrachyshka has joined #openstack-neutron | 17:16 | |
*** jpich has quit IRC | 17:17 | |
*** ygbo has quit IRC | 17:18 | |
*** amotoki has quit IRC | 17:18 | |
*** heyongli has quit IRC | 17:18 | |
*** yfauser has joined #openstack-neutron | 17:19 | |
*** yfauser has left #openstack-neutron | 17:19 | |
*** manishg has joined #openstack-neutron | 17:21 | |
*** yapeng has joined #openstack-neutron | 17:21 | |
*** heyongli has joined #openstack-neutron | 17:22 | |
*** tflynn has joined #openstack-neutron | 17:24 | |
*** padkrish has quit IRC | 17:26 | |
*** yapeng has quit IRC | 17:27 | |
*** EmilienM is now known as EmilienM|afk | 17:27 | |
*** suresh12 has joined #openstack-neutron | 17:28 | |
*** karimb has quit IRC | 17:28 | |
*** gaud has quit IRC | 17:29 | |
*** markvoelker has joined #openstack-neutron | 17:30 | |
*** irenab has quit IRC | 17:31 | |
*** jistr has quit IRC | 17:31 | |
*** ronis has joined #openstack-neutron | 17:32 | |
*** SumitNaiksatam has quit IRC | 17:32 | |
*** bharath has quit IRC | 17:32 | |
*** Murali has quit IRC | 17:33 | |
*** trinaths has left #openstack-neutron | 17:34 | |
*** afazekas has joined #openstack-neutron | 17:34 | |
*** moshele has quit IRC | 17:34 | |
*** matrohon has joined #openstack-neutron | 17:34 | |
matrohon | amuller : hi | 17:35 |
amuller | matrohon: in meeting | 17:35 |
openstackgerrit | Carl Baldwin proposed openstack/neutron-vpnaas: Handle common boilerplate arguments to RouterInfo https://review.openstack.org/151326 | 17:35 |
amuller | matrohon: I'll be online for the next few hours | 17:36 |
*** padkrish has joined #openstack-neutron | 17:36 | |
matrohon | safchain, amuller : I'll leave in few minutes :) I just wanted you to give your opinion on : https://review.openstack.org/#/c/141114/ | 17:37 |
amuller | matrohon: Ahh, I'm pretty much with Mike on this one | 17:38 |
amuller | But I need to review it | 17:38 |
*** bradjones has quit IRC | 17:38 | |
*** bradjones has joined #openstack-neutron | 17:39 | |
matrohon | amuller : me either, I'm happy that mike is trying to fix the issue as early as possible. I just think the code needs to be cleaner for maintainability | 17:40 |
*** manishg has quit IRC | 17:40 | |
amuller | OK, hopefully we can clean it up then | 17:40 |
*** aranjan has joined #openstack-neutron | 17:41 | |
*** manishg has joined #openstack-neutron | 17:41 | |
*** bjornar_ has joined #openstack-neutron | 17:41 | |
carl_baldwin | ihrachyshka: ping | 17:41 |
*** tomoe_ has joined #openstack-neutron | 17:41 | |
*** bharath has joined #openstack-neutron | 17:41 | |
ihrachyshka | carl_baldwin, pong | 17:42 |
bharath | Anyone can reproduce this bug https://bugs.launchpad.net/neutron/+bug/1317363 ? | 17:42 |
bharath | I am unable to update the gateway ip | 17:42 |
carl_baldwin | ihrachyshka: I’m following up on the L3 meeting this morning. You mentioned ipam interface maturity. Would you like to elaborate? | 17:43 |
carl_baldwin | ihrachyshka: I will also take a quick look at your test_l3_agent refactoring series. | 17:44 |
ihrachyshka | carl_baldwin, the patch for abstraction has multiple comments, I wonder whether those are worked upon. | 17:44 |
ihrachyshka | carl_baldwin, thanks | 17:44 |
*** tflynn has quit IRC | 17:44 | |
openstackgerrit | Rossella Sblendido proposed openstack/neutron: Add devices to update in RPC call security_groups_provider_updated https://review.openstack.org/148235 | 17:44 |
*** aranjan has quit IRC | 17:45 | |
*** manishg has quit IRC | 17:45 | |
*** tomoe_ has quit IRC | 17:45 | |
*** matrohon has quit IRC | 17:46 | |
*** carl_baldwin has quit IRC | 17:49 | |
openstackgerrit | Merged openstack/neutron-vpnaas: Fix the neutron-vpnaas unit test failures https://review.openstack.org/151233 | 17:51 |
*** krtaylor has quit IRC | 17:51 | |
openstackgerrit | Sandhya Dasu proposed openstack/neutron: Remove duplicate logging of attribute validation errors https://review.openstack.org/149853 | 17:51 |
*** tflynn has joined #openstack-neutron | 17:53 | |
*** sbfox has joined #openstack-neutron | 17:53 | |
*** SumitNaiksatam has joined #openstack-neutron | 17:53 | |
*** jp_at_hp has quit IRC | 17:54 | |
*** salv-orlando has quit IRC | 17:54 | |
*** carl_baldwin has joined #openstack-neutron | 17:55 | |
carl_baldwin | ihrachyshka: Sorry, my internet connection went down for a minute but I just caught up on eavesdrop. | 17:56 |
*** padkrish has quit IRC | 17:56 | |
carl_baldwin | ihrachyshka: There has been a rash of new reviews on the ipam interface review in the last couple of days. I have not had a chance to look at them all yet. | 17:57 |
ihrachyshka | carl_baldwin, that's not bad, it's just that the number of comments is around 30, so it's better to have those handled before we're dug deep into them | 17:58 |
*** thorst1 has left #openstack-neutron | 17:58 | |
carl_baldwin | ihrachyshka: I will get to them. The review has been up for months. I think taking a couple of days to respond to a rash of new comments is reasonable. | 17:59 |
*** Youcef has joined #openstack-neutron | 18:00 | |
ihrachyshka | that's fair, I am guilty myself to get to it now only :( | 18:00 |
*** padkrish has joined #openstack-neutron | 18:00 | |
*** reed has joined #openstack-neutron | 18:00 | |
*** oreillyd has quit IRC | 18:00 | |
*** radez is now known as radez_g0n3 | 18:00 | |
carl_baldwin | ihrachyshka: All good. :) | 18:01 |
*** anilvenkata has left #openstack-neutron | 18:01 | |
carl_baldwin | ihrachyshka: re: split_ra_unit_tests. It will be difficult to work that in at the moment because there is so much churn on that file right now. | 18:01 |
carl_baldwin | ihrachyshka: I hope to settle down in a week or two and then we can get to that patch series. | 18:02 |
*** suresh12 has quit IRC | 18:02 | |
enikanorov_ | rossella_s: thanks for the explanation. what is backend in neutron? | 18:02 |
*** mpath-rax has quit IRC | 18:02 | |
*** leenheer has joined #openstack-neutron | 18:03 | |
*** afazekas_ has joined #openstack-neutron | 18:03 | |
*** krtaylor has joined #openstack-neutron | 18:04 | |
*** dsundarraj has quit IRC | 18:05 | |
*** pal has quit IRC | 18:05 | |
*** f13o has quit IRC | 18:06 | |
*** timbyr_ has quit IRC | 18:06 | |
ihrachyshka | carl_baldwin, ack, I'm not pushing for that one, just had an idea of enhancing coverage for the module and started from tiny preparation steps which ended up with 5 invasive patches :( | 18:06 |
*** moha_hunt has joined #openstack-neutron | 18:06 | |
*** ivar-lazzaro has joined #openstack-neutron | 18:07 | |
carl_baldwin | ihrachyshka: Let’s keep them on hold and look at how they fit it after the refactoring. The refactoring has been splitting UTs out of that massive file. | 18:07 |
*** pc_m has joined #openstack-neutron | 18:07 | |
*** kawa2014 has quit IRC | 18:07 | |
*** f13o has joined #openstack-neutron | 18:08 | |
*** timbyr_ has joined #openstack-neutron | 18:08 | |
carl_baldwin | ihrachyshka: At a glance, I think you’re on a good track with those patches. But, it is in direct conflict with other stuff and will be difficult to merge now. | 18:09 |
ihrachyshka | yeah, I realize that and hence want to sync up with potential reviewers on better time to push for it since I don't want to rebase after rebase :) | 18:09 |
ihrachyshka | tell me when you think it's a good time, and I'll try to be prepared | 18:09 |
*** regXboi has left #openstack-neutron | 18:11 | |
*** doude has joined #openstack-neutron | 18:14 | |
*** spandhe has joined #openstack-neutron | 18:15 | |
*** jschwarz has quit IRC | 18:15 | |
rossella_s | enikanorov_ : I think neutron doesn't implement any backend module | 18:15 |
*** jlibosva has quit IRC | 18:15 | |
enikanorov_ | rossella_s: ok, so it's useless :) | 18:15 |
rossella_s | enikanorov_ yes for neutron yes | 18:16 |
rossella_s | enikanorov_ : we can add a module if needed | 18:16 |
enikanorov_ | yep, i think eventually we'll do it | 18:16 |
rossella_s | enikanorov_ :) gotta go now! bye | 18:16 |
enikanorov_ | rossella_s: good luck! | 18:17 |
*** padkrish has quit IRC | 18:18 | |
*** tflynn has quit IRC | 18:18 | |
*** amotoki has joined #openstack-neutron | 18:18 | |
*** padkrish has joined #openstack-neutron | 18:19 | |
*** s3wong has joined #openstack-neutron | 18:20 | |
*** jpena has quit IRC | 18:21 | |
*** coolsvap|afk is now known as coolsvap | 18:22 | |
*** moshele has joined #openstack-neutron | 18:23 | |
*** amotoki has quit IRC | 18:24 | |
*** salv-orlando has joined #openstack-neutron | 18:25 | |
*** jorgem has joined #openstack-neutron | 18:26 | |
openstackgerrit | Sridhar Gaddam proposed openstack/neutron: Add sanity_check for keepalived https://review.openstack.org/151284 | 18:27 |
*** markmcclain has joined #openstack-neutron | 18:27 | |
*** RichardRaseley has quit IRC | 18:27 | |
*** padkrish has quit IRC | 18:27 | |
*** Sukhdev has quit IRC | 18:28 | |
*** thedodd has quit IRC | 18:28 | |
*** achanda has joined #openstack-neutron | 18:29 | |
*** tflynn has joined #openstack-neutron | 18:33 | |
ChuckC | ZZelle: thanks for your help with https://review.openstack.org/#/c/112129 | 18:35 |
*** thomasem has quit IRC | 18:35 | |
*** EmilienM|afk is now known as EmilienM | 18:36 | |
*** bharath has quit IRC | 18:36 | |
*** doude has quit IRC | 18:37 | |
*** tflynn has quit IRC | 18:38 | |
*** RichardR1seley has joined #openstack-neutron | 18:38 | |
*** harlowja has joined #openstack-neutron | 18:38 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Move ha router functionality from the agent to ha_router https://review.openstack.org/150630 | 18:38 |
*** Sukhdev has joined #openstack-neutron | 18:40 | |
Sukhdev | mestery: Hey Kyle, I had to rebase https://review.openstack.org/#/c/147976/ - can you please put your vote back on this, please? | 18:42 |
mestery | Sukhdev: Looking | 18:42 |
*** harlowja_ has joined #openstack-neutron | 18:42 | |
*** aranjan has joined #openstack-neutron | 18:42 | |
Sukhdev | mestery: Thanks - appreciate it | 18:43 |
*** aveiga has quit IRC | 18:43 | |
*** krtaylor has quit IRC | 18:43 | |
*** amotoki has joined #openstack-neutron | 18:45 | |
*** dims has quit IRC | 18:46 | |
*** harlowja has quit IRC | 18:46 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron-vpnaas: Handle common boilerplate arguments to RouterInfo https://review.openstack.org/151326 | 18:46 |
pc_m | carl_baldwin: ping | 18:47 |
*** aranjan has quit IRC | 18:47 | |
carl_baldwin | pc_m: pong | 18:47 |
pc_m | Please see my comments in PS1 of 151326 | 18:47 |
openstackgerrit | Moshe Levi proposed openstack/neutron: Thin MLNX ML2 mechanism driver and agent https://review.openstack.org/148614 | 18:47 |
*** dims has joined #openstack-neutron | 18:47 | |
*** fandi has joined #openstack-neutron | 18:48 | |
carl_baldwin | pc_m: I will update. | 18:49 |
*** padkrish has joined #openstack-neutron | 18:49 | |
*** manishg has joined #openstack-neutron | 18:49 | |
*** jorgem has quit IRC | 18:50 | |
pc_m | carl_baldwin: THanks for doing this. I was going to do it later, but glad you jumped in (it was your idea anyway). | 18:50 |
carl_baldwin | pc_m: Sometimes it is just easiest to knock something like this out quickly and be done with it. | 18:50 |
*** openstackgerrit has quit IRC | 18:50 | |
pc_m | carl_baldwin: Yeah, especially when it is fresh in mind (and easy change :) | 18:51 |
*** openstackgerrit has joined #openstack-neutron | 18:51 | |
carl_baldwin | pc_m: I’ve updated the patch. | 18:51 |
carl_baldwin | amuller: ping | 18:52 |
*** moshele has quit IRC | 18:52 | |
pc_m | carl_baldwin: Does the upstream neutron code have kwargs for those two arguments? I had a pull of view and it has them as positional args currently. | 18:52 |
*** mwagner_lap has quit IRC | 18:53 | |
carl_baldwin | pc_m: Any arguments can be passed as positional or keyword args anytime. There is no distinction. | 18:53 |
carl_baldwin | The restriction is that positional arguments must be passed first, and then any keyword arguments after tht. | 18:54 |
carl_baldwin | s/tht/that/ | 18:54 |
*** krtaylor has joined #openstack-neutron | 18:54 | |
pc_m | carl_baldwin: duh, as long as no default args before them... | 18:54 |
*** RichardR1seley has quit IRC | 18:54 | |
carl_baldwin | pc_m: Right. And all arguments without a default value must be passed. | 18:54 |
*** manishg has quit IRC | 18:55 | |
*** itzikb has joined #openstack-neutron | 18:55 | |
*** tidwellr has joined #openstack-neutron | 18:56 | |
*** flwang has quit IRC | 18:56 | |
*** coolsvap is now known as coolsvap|afk | 18:56 | |
pc_m | dougwig: mestery: carl_baldwin: Please review https://review.openstack.org/#/c/150990/1 so we can move the VPN functional tests to check queue. | 18:58 |
mestery | pc_m: Looking | 18:59 |
openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn https://review.openstack.org/145005 | 18:59 |
*** ZZelle_ has joined #openstack-neutron | 18:59 | |
openstackgerrit | Michael Smith proposed openstack/neutron: Debug log msgs for experimental dvr job https://review.openstack.org/150998 | 18:59 |
mestery | pc_m: Is there precedent for copying devstack-vm-gate.sh like you did in that review? | 18:59 |
*** aranjan has joined #openstack-neutron | 19:00 | |
*** dsneddon is now known as dsneddon_appt | 19:00 | |
*** thomasem has joined #openstack-neutron | 19:00 | |
pc_m | mestery: Don't know, marun suggested using the Neutron hook files, so I took all the files and copied and tweaked paths and updated copyright notices. | 19:01 |
clarkb | I would highly recommend aginst not doing that | 19:01 |
*** salv-orlando has quit IRC | 19:01 | |
clarkb | and instead just run that script from devstack-gate | 19:01 |
mestery | clarkb: That was my thinking as well. pc_m, can we just run them instead? | 19:01 |
mestery | clarkb: ++ | 19:01 |
*** thomasem has quit IRC | 19:01 | |
*** thomasem has joined #openstack-neutron | 19:02 | |
*** lpetrut1 has quit IRC | 19:03 | |
*** manishg has joined #openstack-neutron | 19:04 | |
pc_m | mestery: clarkb: not sure I fully understand what you're suggesting (I'm barely figuring out what these all do). Can you elaborate? | 19:04 |
*** aepifanov has quit IRC | 19:04 | |
*** amotoki has quit IRC | 19:05 | |
pc_m | Right now, gate_hook.sh runs gevstack-vm-gate.sh, from within the repo area. | 19:05 |
*** kbringard has quit IRC | 19:06 | |
*** salv-orlando has joined #openstack-neutron | 19:07 | |
*** ijw has joined #openstack-neutron | 19:08 | |
clarkb | but as a gate hook you know you are running as part of devstack gate so no reason to copy paste the devstack gate script | 19:08 |
*** RichardRaseley has joined #openstack-neutron | 19:09 | |
*** mlavalle has joined #openstack-neutron | 19:09 | |
*** achanda has quit IRC | 19:10 | |
*** yapeng_ has joined #openstack-neutron | 19:10 | |
*** ivar-lazzaro has quit IRC | 19:10 | |
pc_m | clarkb: OK, so this script exists elsewhere and will be run as part of the devstack gate? | 19:11 |
clarkb | pc_m: http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree it exists there and will not be run as part of devstack gate if you override the gate_hook but when you override the gate hook you can run it | 19:12 |
*** yapeng_ has quit IRC | 19:15 | |
enikanorov_ | question to all | 19:15 |
pc_m | clarkb: Any reason why Neutron has a copy of the script? | 19:15 |
enikanorov_ | if i'm getting | 19:15 |
enikanorov_ | Non-zero exit code (2) from test listing. | 19:15 |
enikanorov_ | error: testr failed (3) | 19:15 |
enikanorov_ | The test run didn't actually run any tests | 19:15 |
clarkb | pc_m: I have no idea but if it does it should probably be deleted too | 19:15 |
enikanorov_ | what's the best way to troubleshoot that? | 19:16 |
clarkb | enikanorov_: it should tell you which module failed to import | 19:16 |
clarkb | then you can attempt to import that module and see why it broke | 19:16 |
enikanorov_ | clarkb: nope, it doesn't tell anything | 19:16 |
enikanorov_ | i guess it's some import failure, but have no clue | 19:17 |
clarkb | enikanorov_: can you paste the entire output from tox -epyXX? | 19:17 |
clarkb | use paste.openstack.org or similar | 19:17 |
enikanorov_ | clarkb: that was pretty much it ^^^ | 19:17 |
*** achanda has joined #openstack-neutron | 19:18 | |
enikanorov_ | clarkb: tried to reset tox environment, making it to install all dependencies, but getting the same | 19:18 |
enikanorov_ | clarkb: i had to install nose and run UTs with nosetests (which works) | 19:19 |
clarkb | enikanorov_: try `.tox/pyXX/bin/testr list-tests` | 19:19 |
clarkb | enikanorov_: nosetests working is probably a side effect of it not properly doing test discovery (eg it probably ignored the tests which failed to import) | 19:19 |
enikanorov_ | clarkb: ok, that cmd actually gives some clue, thanks! | 19:20 |
clarkb | this is probably a bug in the testr wrapper that neutron uses if the outputs are different | 19:20 |
pc_m | clarkb: In https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/requirements.yaml#L22 I see it run devstack-vm-gate.sh | 19:21 |
*** jorgem has joined #openstack-neutron | 19:21 | |
clarkb | pc_m: yes devstack-vm-gate.sh should come from the repo I linked | 19:21 |
pc_m | clarkb: I take it I run it from my gate_hook function. | 19:21 |
clarkb | pc_m: but it shouldn't run its own copy and if it does that copy should go away | 19:21 |
pc_m | clarkb: Right. The one in requirements.yaml also runs some integration.sh. Do I need to do that as well? | 19:22 |
* pc_m no idea what that does... | 19:22 | |
clarkb | no you run what you need to ru nyour tests | 19:23 |
*** mlavalle has quit IRC | 19:24 | |
*** mlavalle has joined #openstack-neutron | 19:25 | |
*** dims has quit IRC | 19:26 | |
*** lpetrut has joined #openstack-neutron | 19:27 | |
*** reed has quit IRC | 19:27 | |
*** smillward has joined #openstack-neutron | 19:27 | |
pc_m | clarkb: Thanks. I'll push another change... | 19:28 |
amuller | carl_baldwin: I have to run an errand or two | 19:30 |
amuller | carl_baldwin: I'll be back later | 19:30 |
*** tflynn has joined #openstack-neutron | 19:30 | |
carl_baldwin | amuller: Okay. I fixed the functional tests on that ha refactor patch. I’m hoping it can go in soon. | 19:30 |
carl_baldwin | amuller: ttyl | 19:31 |
amuller | carl_baldwin: OK I'll be sure to look when I get back | 19:31 |
*** yfauser has joined #openstack-neutron | 19:31 | |
*** yfauser has left #openstack-neutron | 19:31 | |
carl_baldwin | amuller: Thanks. | 19:31 |
*** jaypipes has quit IRC | 19:31 | |
*** wpward has joined #openstack-neutron | 19:32 | |
*** aveiga has joined #openstack-neutron | 19:33 | |
*** popw has quit IRC | 19:33 | |
*** ronis has quit IRC | 19:34 | |
*** popw has joined #openstack-neutron | 19:34 | |
wpward | Quick question for anyone that wants to respond... when doing an attach vnic via rest api, we see that passing an IP of 0.0.0.0 causes openstack to assign the first available IP in the subnet. Is this expected and by design? | 19:35 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional tests https://review.openstack.org/143412 | 19:35 |
*** aix has quit IRC | 19:35 | |
*** manishg has quit IRC | 19:35 | |
*** markmcclain has quit IRC | 19:35 | |
*** markmcclain has joined #openstack-neutron | 19:36 | |
*** manishg has joined #openstack-neutron | 19:36 | |
*** dims has joined #openstack-neutron | 19:36 | |
*** manishg_ has joined #openstack-neutron | 19:37 | |
*** manishg has quit IRC | 19:37 | |
*** dutsmoc has quit IRC | 19:38 | |
*** comstud has joined #openstack-neutron | 19:38 | |
ZZelle_ | ajo, hi | 19:38 |
*** smillward has quit IRC | 19:40 | |
*** manishg_ has quit IRC | 19:41 | |
*** jprovazn has quit IRC | 19:43 | |
*** enikanorov has joined #openstack-neutron | 19:47 | |
*** smillward has joined #openstack-neutron | 19:47 | |
*** ajo has quit IRC | 19:48 | |
*** ajo_ has joined #openstack-neutron | 19:48 | |
*** arif-ali_ has joined #openstack-neutron | 19:49 | |
*** smillward has quit IRC | 19:50 | |
*** smillward has joined #openstack-neutron | 19:50 | |
*** ChuckC_ has joined #openstack-neutron | 19:50 | |
*** ivar-lazzaro has joined #openstack-neutron | 19:50 | |
*** dsundarraj has joined #openstack-neutron | 19:51 | |
*** SpamapS_ has joined #openstack-neutron | 19:51 | |
*** s3wong_ has joined #openstack-neutron | 19:51 | |
*** dsundarraj has quit IRC | 19:51 | |
*** dsundarraj has joined #openstack-neutron | 19:52 | |
*** manishg has joined #openstack-neutron | 19:54 | |
*** baoli has quit IRC | 19:54 | |
*** rha_ has joined #openstack-neutron | 19:54 | |
*** mikal_ has joined #openstack-neutron | 19:55 | |
*** dims_ has joined #openstack-neutron | 19:56 | |
*** kickinz1` has joined #openstack-neutron | 19:56 | |
*** rodrigod` has joined #openstack-neutron | 19:56 | |
*** arif-ali has quit IRC | 19:56 | |
*** ChuckC has quit IRC | 19:56 | |
*** enikanorov_ has quit IRC | 19:56 | |
*** SpamapS has quit IRC | 19:56 | |
*** s3wong has quit IRC | 19:56 | |
*** rodrigods has quit IRC | 19:56 | |
*** a2hill has quit IRC | 19:56 | |
*** clarkb has quit IRC | 19:56 | |
*** kickinz1_mob|off has quit IRC | 19:56 | |
*** rha has quit IRC | 19:56 | |
*** mikal has quit IRC | 19:56 | |
*** txomon|fon has quit IRC | 19:56 | |
*** arif-ali_ is now known as arif-ali | 19:56 | |
*** ptoohill has joined #openstack-neutron | 19:56 | |
*** flwang has joined #openstack-neutron | 19:56 | |
*** wpward1 has joined #openstack-neutron | 19:57 | |
*** txomon|fon has joined #openstack-neutron | 19:57 | |
*** padkrish has quit IRC | 19:58 | |
*** sbfox has quit IRC | 19:58 | |
*** manishg has quit IRC | 19:58 | |
*** padkrish has joined #openstack-neutron | 19:58 | |
*** wpward has quit IRC | 19:58 | |
*** rkukura has quit IRC | 19:58 | |
*** dims has quit IRC | 19:58 | |
*** manishg has joined #openstack-neutron | 19:59 | |
*** manishg has quit IRC | 19:59 | |
*** manishg has joined #openstack-neutron | 19:59 | |
*** thedodd has joined #openstack-neutron | 20:00 | |
*** dims_ has quit IRC | 20:00 | |
*** sbfox has joined #openstack-neutron | 20:01 | |
*** padkrish has quit IRC | 20:02 | |
*** zz_avozza is now known as avozza | 20:02 | |
anteaya | gus: hello, the nova meeting takes place in 57 minutes, would be awesome to have your attendance if that is possible | 20:03 |
*** manishg has quit IRC | 20:04 | |
*** manishg has joined #openstack-neutron | 20:04 | |
*** openstackgerrit has quit IRC | 20:04 | |
*** openstackgerrit has joined #openstack-neutron | 20:05 | |
*** amotoki has joined #openstack-neutron | 20:05 | |
*** clarkb has joined #openstack-neutron | 20:06 | |
*** rkukura has joined #openstack-neutron | 20:07 | |
*** manishg_ has joined #openstack-neutron | 20:07 | |
*** _cjones_ has quit IRC | 20:07 | |
*** manishg has quit IRC | 20:08 | |
*** amotoki has quit IRC | 20:10 | |
*** carl_baldwin has quit IRC | 20:13 | |
ajo_ | hi ZZelle | 20:13 |
ajo_ | sorry, I'm a bit out of office, and I won't be much around, but please tell me :D | 20:14 |
ZZelle_ | ajo_, is it fine if i rebase https://review.openstack.org/114931? as my change requires a lastest master version | 20:14 |
*** tidwellr has quit IRC | 20:15 | |
ajo_ | ZZelle, do you mean to rebase on top of 114931 ? | 20:16 |
ajo_ | or whtat do you mean? | 20:16 |
ajo_ | ahhh | 20:16 |
ajo_ | to rebase 114931 on top of last master? | 20:16 |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: Provide hooks for VPNaaS repo functional gate https://review.openstack.org/150990 | 20:16 |
ajo_ | ok, I will | 20:16 |
ajo_ | ZZelle_ give me a sec | 20:16 |
*** aranjan has quit IRC | 20:16 | |
*** s3wong_ has quit IRC | 20:17 | |
*** aranjan has joined #openstack-neutron | 20:17 | |
ZZelle_ | ajo_, just run rebase command in gerrit for 114931 | 20:18 |
ajo_ | ajo_, sure, I'm addressing a tiny comment, | 20:19 |
ajo_ | so if we are lucky 114931 will be final, and you don't need to rebase anymore on top of it | 20:19 |
*** dsundarraj has quit IRC | 20:19 | |
*** leenheer has quit IRC | 20:19 | |
ZZelle_ | ok | 20:20 |
*** ChuckC has joined #openstack-neutron | 20:20 | |
*** Youcef has quit IRC | 20:20 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Implements the ProcessMonitor in the l3_agent https://review.openstack.org/114931 | 20:20 |
*** itzikb has quit IRC | 20:20 | |
*** mwagner_lap has joined #openstack-neutron | 20:21 | |
*** leenheer has joined #openstack-neutron | 20:22 | |
*** aranjan has quit IRC | 20:22 | |
*** SpamapS_ is now known as SpamapS | 20:23 | |
*** ChuckC_ has quit IRC | 20:23 | |
*** s3wong has joined #openstack-neutron | 20:24 | |
*** fifieldt has quit IRC | 20:24 | |
*** SpamapS has quit IRC | 20:24 | |
*** SpamapS has joined #openstack-neutron | 20:24 | |
*** itzikb has joined #openstack-neutron | 20:24 | |
*** fifieldt has joined #openstack-neutron | 20:25 | |
*** smillward has quit IRC | 20:25 | |
*** smillward has joined #openstack-neutron | 20:25 | |
*** itzikb has quit IRC | 20:26 | |
*** salv-orlando has quit IRC | 20:27 | |
*** ChuckC has quit IRC | 20:27 | |
*** wpward1 has left #openstack-neutron | 20:27 | |
*** yfauser1 has joined #openstack-neutron | 20:28 | |
*** padkrish has joined #openstack-neutron | 20:29 | |
*** annegent_ has joined #openstack-neutron | 20:29 | |
openstackgerrit | Doug Wiegley proposed openstack/neutron: Mechanims to move extensions and config into service repos https://review.openstack.org/151375 | 20:29 |
*** SridharRamaswamy has quit IRC | 20:30 | |
*** SridharRamaswamy has joined #openstack-neutron | 20:31 | |
*** leenheer has quit IRC | 20:33 | |
*** RichardRaseley has quit IRC | 20:33 | |
*** leenheer has joined #openstack-neutron | 20:33 | |
*** padkrish has quit IRC | 20:36 | |
anteaya | obondarev: where is your proxy patch? I can't find anything under your name that is open in the neutron repo | 20:36 |
*** manishg_ has quit IRC | 20:37 | |
*** matrohon has joined #openstack-neutron | 20:37 | |
anteaya | obondarev: found it, guess status:open doesn't find wip patches | 20:37 |
anteaya | https://review.openstack.org/#/c/150490/ | 20:37 |
*** manishg has joined #openstack-neutron | 20:39 | |
*** yfauser1 has left #openstack-neutron | 20:39 | |
*** Sukhdev has quit IRC | 20:40 | |
pc_m | armax: ping | 20:40 |
armax | pc_m: pong, going to luck in a sec | 20:40 |
*** Miouge has quit IRC | 20:40 | |
armax | *lunch | 20:40 |
pc_m | armax: I'm setting up functional gate for vpnaas repo, and was copying from neutron. | 20:40 |
*** vishwanathj has joined #openstack-neutron | 20:40 | |
*** markmcclain has quit IRC | 20:40 | |
pc_m | armax: There is a devstack-vm-gate.sh and functions.sh in neutron. Any reason why these were customizations of the devstack-gate repo files? | 20:41 |
pc_m | armax: Trying to understand why the overriding... not doing that in vpn repo. | 20:41 |
armax | check the commit message that introduced those files | 20:42 |
pc_m | armax: If too long of an answer needed, just let me know later. Lunch is way more important :) | 20:42 |
armax | it’s a stop-gap solution | 20:42 |
pc_m | armax: OK | 20:42 |
vishwanathj | anybody know when the gate-neutron-fwaas-python27 check will be fixed? | 20:43 |
pc_m | armax: Do you think this will also be needed for vpnaas repo? | 20:43 |
*** banix has quit IRC | 20:43 | |
armax | it depends how close you are | 20:43 |
armax | to completion | 20:43 |
armax | I have the respective changes in project-config and devstack-gate that should be merging soon in which case we can drop those files | 20:44 |
armax | but I have no control as to when those merge | 20:44 |
clarkb | armax: stop gap for what? | 20:44 |
pc_m | Well, I've got the functional tests as experimental and hooks are out for review now. But, there are no API tests currently. | 20:44 |
clarkb | armax: that job is literally running inside of devstack-gate... | 20:44 |
*** Sukhdev has joined #openstack-neutron | 20:44 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Implements the ProcessMonitor in the l3_agent https://review.openstack.org/114931 | 20:45 |
*** tidwellr has joined #openstack-neutron | 20:45 | |
ajo_ | ZZelle_ ^ last patchset, also rebased | 20:45 |
ajo_ | HenryG ^ | 20:45 |
pc_m | clarkb: See commit 0edd89fc | 20:45 |
ajo_ | going to get the kids to sleep | 20:45 |
ajo_ | and ready for my trip tomorrow! ;) | 20:45 |
*** banix has joined #openstack-neutron | 20:46 | |
ZZelle_ | ajo_, thx | 20:46 |
clarkb | armax: pc_m just disable tempest in your job | 20:46 |
*** dboik has joined #openstack-neutron | 20:46 | |
*** amuller has quit IRC | 20:47 | |
armax | clarkb: please see https://review.openstack.org/#/c/148052/ and https://review.openstack.org/#/c/148641/ | 20:47 |
armax | once these two merge we can stop carrying over the files in the contrib directory in the neutron repo | 20:48 |
clarkb | so I am prett sure you can already do that | 20:48 |
clarkb | but I need to go look at devstack | 20:48 |
pc_m | clarkb: cool. Let me know how I can do that in the VPN repo case. | 20:49 |
openstackgerrit | sajuptpm proposed openstack/neutron: Removed redundant statement from l3agentscheduler https://review.openstack.org/151380 | 20:49 |
clarkb | set DEVSTACK_GATE_TEMPEST to 0 | 20:50 |
armax | clarkb: by doing that devstack-gate does not pull/configure tempest | 20:50 |
clarkb | armax: and we need tempest but don't want to run it because? | 20:51 |
clarkb | I am all confused | 20:51 |
armax | tempest it’s a dependency for the neutron api job, marun should be able to explain more | 20:51 |
*** aepifanov has joined #openstack-neutron | 20:52 | |
clarkb | hrm I thought tempest was specifically saying don't do that and use tempest-lib instead | 20:53 |
*** britthouser has quit IRC | 20:54 | |
*** ChuckC_ has joined #openstack-neutron | 20:54 | |
*** britthouser has joined #openstack-neutron | 20:54 | |
*** achanda has quit IRC | 20:55 | |
openstackgerrit | enikanorov proposed openstack/neutron: Add option to remove networks from dead DHCP agents https://review.openstack.org/131150 | 20:55 |
*** armax has quit IRC | 20:56 | |
pc_m | clarkb: As I understand from marun, there is an effort to move tempest tests to in-tree (Neutron). | 20:58 |
pc_m | marun: ^^ | 20:58 |
*** annegent_ has quit IRC | 20:58 | |
clarkb | I have left a comment on the change with suggestions to make this much less confusing | 20:58 |
*** yapeng_ has joined #openstack-neutron | 20:59 | |
*** SridharRamaswamy has quit IRC | 21:00 | |
pc_m | clarkb: Wondering how to handle the VPNaaS repo functional tests. | 21:00 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional tests https://review.openstack.org/143412 | 21:00 |
pc_m | The API tests for VPN repo are over in Tempest right now, and I guess we'll move them to the VPN repo, once the tests have been moved from Tempest to Neutron in-tree. | 21:02 |
*** carlp has quit IRC | 21:02 | |
*** claudiub has quit IRC | 21:02 | |
pc_m | clarkb: Suggestions for handling the vpnaas repo functional gate? | 21:02 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional tests https://review.openstack.org/143412 | 21:02 |
pc_m | clarkb: Should we comment out/disable the API part right now or something else? | 21:03 |
clarkb | pc_m: so I will admit to not understanding why tempest is a dependency | 21:03 |
clarkb | I thought that tempest was explicitly not supposed to be a dependency for any of this stuff | 21:03 |
*** igordcard has joined #openstack-neutron | 21:03 | |
*** padkrish has joined #openstack-neutron | 21:03 | |
*** killer_prince has quit IRC | 21:03 | |
pc_m | marun: ping | 21:03 |
clarkb | but if you are going to use tempest I would get https://review.openstack.org/#/c/148052/ in and configure your job to use that flag | 21:03 |
clarkb | rather than copying devstack gate into your repo | 21:03 |
*** RichardR1seley has joined #openstack-neutron | 21:04 | |
*** s3wong has quit IRC | 21:04 | |
*** yapeng_ has quit IRC | 21:04 | |
*** killer_prince has joined #openstack-neutron | 21:04 | |
*** killer_prince is now known as lazy_prince | 21:04 | |
*** SridharRamaswamy has joined #openstack-neutron | 21:06 | |
*** padkrish has quit IRC | 21:08 | |
*** annegent_ has joined #openstack-neutron | 21:08 | |
*** RichardR1seley has quit IRC | 21:08 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Do not run neutron-ns-metadata-proxy as root on dhcp agent https://review.openstack.org/147437 | 21:08 |
*** lpetrut has quit IRC | 21:08 | |
*** dims has joined #openstack-neutron | 21:09 | |
*** s3wong has joined #openstack-neutron | 21:10 | |
pc_m | clarkb: thanks. I'll talk with Maru and try to sort this out. | 21:11 |
*** sripriya has joined #openstack-neutron | 21:13 | |
*** dims has quit IRC | 21:14 | |
*** aranjan has joined #openstack-neutron | 21:17 | |
*** _cjones_ has joined #openstack-neutron | 21:19 | |
*** achanda has joined #openstack-neutron | 21:19 | |
*** manishg has quit IRC | 21:20 | |
*** amotoki has joined #openstack-neutron | 21:20 | |
*** manishg has joined #openstack-neutron | 21:20 | |
openstackgerrit | enikanorov proposed openstack/neutron: Refactor retry mechanism used in some DB operations https://review.openstack.org/149261 | 21:21 |
enikanorov | zzzeek: hi | 21:22 |
zzzeek | enikanorov: hey | 21:22 |
*** aranjan has quit IRC | 21:22 | |
enikanorov | zzzeek: so, regarding https://review.openstack.org/#/c/151017/ | 21:22 |
enikanorov | it appears that neutron doesn't yet supports this functionality | 21:22 |
enikanorov | it has to implement DBAPI backend, does it? | 21:23 |
zzzeek | ym | 21:23 |
zzzeek | um | 21:23 |
*** mwagner_lap has quit IRC | 21:24 | |
*** amotoki has quit IRC | 21:25 | |
zzzeek | enikanorov: im not sure if thats the case | 21:27 |
*** bjornar_ has quit IRC | 21:27 | |
*** armax has joined #openstack-neutron | 21:27 | |
zzzeek | enikanorov: DBAPI has self-based methods and in the decorator, that “self” would be args[0] - I dont see anything accessed from args[0] | 21:28 |
enikanorov | zzzeek: i mean, it clearly not enough to wrap amy method i want in 'retry_on_request' wrapper | 21:29 |
enikanorov | the method has to make calls to DBAPI from oslo_db i guess | 21:29 |
*** salv-orlando has joined #openstack-neutron | 21:30 | |
anteaya | gus: and the nova meeting never happened | 21:30 |
zzzeek | enikanorov: not sure if im missing something, looking at api.py -> wrap_db_retry(), I dont see that anything is happening here specific to api.DBAPI. the DBDeadlock and DBConnectionError are oslo.db errors which neutron is definitely getting because neurtron uses oslo.db’s create_engine | 21:31 |
*** rodrigod` is now known as rodrigods | 21:31 | |
*** rodrigods has quit IRC | 21:31 | |
*** rodrigods has joined #openstack-neutron | 21:31 | |
zzzeek | enikanorov: projects currently get that from EngineFacade, every project is using that | 21:31 |
enikanorov | zzzeek: my question basically is how we get to 'wrap_db_retry' | 21:31 |
*** radez_g0n3 is now known as radez | 21:32 | |
zzzeek | enikanorov: I would think you could use it directly. there’s no need to pull it through the DBAPI.__getattr__ scheme there | 21:33 |
enikanorov | zzzeek: well, looking at the code i think wrap_db_retry is not for direct use due to its big list of parameters | 21:33 |
zzzeek | enikanorov: which means the part above where you added the “f.enable_retry” thing, yeah you’d not use that | 21:34 |
*** tiswanso has joined #openstack-neutron | 21:34 | |
zzzeek | enikanorov: i dont see an underscore preceding it | 21:34 |
zzzeek | enikanorov: and I hate the DBAPI class | 21:34 |
zzzeek | enikanorov: I’d favor adding more to this so that it is more friendly as a standalone decorator | 21:35 |
zzzeek | enikanorov: e.g. default of False for the various flags | 21:35 |
enikanorov | yep, it's not a decorator right now | 21:35 |
zzzeek | enikanorov: it is a decorator | 21:35 |
enikanorov | but it's usage is quite convluted | 21:35 |
*** carlp has joined #openstack-neutron | 21:35 | |
zzzeek | it has a __call__ method that accepts a function | 21:35 |
enikanorov | yep, but with such list of iit parameters... | 21:36 |
zzzeek | enikanorov: it just needs defaults for all the params in __init__ | 21:36 |
enikanorov | *init | 21:36 |
zzzeek | enikanorov: add them in, I’ll +2 it | 21:36 |
zzzeek | enikanorov: i hate the DBAPI part below | 21:36 |
enikanorov | ok, i got your point | 21:36 |
zzzeek | enikanorov: that’s the convoluted part :) | 21:36 |
zzzeek | enikanorov: what i can see about the DBAPI class is that it allows these defaults to be set up in one place | 21:37 |
*** jorgem has quit IRC | 21:37 | |
zzzeek | enikanorov: but at the same time, you could just have a module-level instance of wrap_db_retry() with those defaults that you want | 21:37 |
*** aranjan has joined #openstack-neutron | 21:37 | |
enikanorov | zzzeek: the only usage of wrap_db_retry made me think that it's for internal use | 21:38 |
zzzeek | enikanorov: whoever wrote it probably had that in mind :). but whoever that person was, overused classes like mad :). a handy decorator that doesnt need framework behind it should be available by itself | 21:38 |
*** dims has joined #openstack-neutron | 21:39 | |
enikanorov | agree | 21:40 |
*** dims has quit IRC | 21:40 | |
*** flwang has quit IRC | 21:41 | |
*** flwang has joined #openstack-neutron | 21:41 | |
openstackgerrit | Merged openstack/neutron: Fixing a log message in Arista L3 Service Plugin https://review.openstack.org/147976 | 21:41 |
*** baoli has joined #openstack-neutron | 21:42 | |
openstackgerrit | Merged openstack/neutron: Default security group table https://review.openstack.org/142101 | 21:43 |
*** carl_baldwin has joined #openstack-neutron | 21:46 | |
*** afazekas_ has quit IRC | 21:46 | |
*** moha_hunt has quit IRC | 21:49 | |
openstackgerrit | Merged openstack/neutron: Do not check twice IP allocations for auto-address subnets https://review.openstack.org/149767 | 21:49 |
*** Marga_ has quit IRC | 21:50 | |
*** Marga_ has joined #openstack-neutron | 21:50 | |
*** leenheer has quit IRC | 21:51 | |
*** ajo_ has quit IRC | 21:52 | |
*** baoli has quit IRC | 21:55 | |
*** Marga_ has quit IRC | 21:55 | |
*** armax has quit IRC | 21:55 | |
*** baoli has joined #openstack-neutron | 21:56 | |
*** cference has quit IRC | 21:56 | |
*** RichardRaseley has joined #openstack-neutron | 21:56 | |
*** techcet has quit IRC | 21:59 | |
*** salv-orlando has quit IRC | 22:00 | |
*** radez is now known as radez_g0n3 | 22:00 | |
*** aranjan has quit IRC | 22:01 | |
*** aranjan_ has joined #openstack-neutron | 22:01 | |
openstackgerrit | Manish Godara proposed openstack/neutron: Add filter for provider network attributes in ML2 https://review.openstack.org/124917 | 22:02 |
*** jamielennox|away is now known as jamielennox | 22:03 | |
*** achanda has quit IRC | 22:03 | |
*** ajo has joined #openstack-neutron | 22:04 | |
*** ajo has quit IRC | 22:04 | |
jogo | https://bugs.launchpad.net/neutron/+bug/1357055 | 22:07 |
jogo | top gate bug | 22:07 |
jogo | only happens on neutron jobs | 22:07 |
jogo | mestery carl_baldwin enikanorov: ^ | 22:07 |
mestery | jogo: Looking | 22:08 |
enikanorov | jogo: thanks for letting us know | 22:08 |
*** chlong has quit IRC | 22:08 | |
mestery | enikanorov: Reading Salv's comments from last October ... | 22:09 |
*** flaviof has quit IRC | 22:10 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: WIP Move Floating IP processing to Router classes https://review.openstack.org/142863 | 22:11 |
*** claudiub has joined #openstack-neutron | 22:12 | |
jogo | looks like this is an old bug that came back | 22:13 |
mestery | jogo: Yes, salv's analysis was it was a tempest issue and not a neutron issue last October | 22:13 |
*** achanda has joined #openstack-neutron | 22:14 | |
jogo | mestery: do you think that is still valid? | 22:14 |
*** achanda has quit IRC | 22:14 | |
mestery | jogo: I don't have enough data yet, just reading back through the ntoes in the bug. | 22:14 |
jogo | mestery: thanks | 22:15 |
jogo | mtreinish: ^ may be a tempest bug | 22:15 |
*** pradk has joined #openstack-neutron | 22:15 | |
*** aranjan_ has quit IRC | 22:16 | |
*** aranjan has joined #openstack-neutron | 22:16 | |
*** tiswanso has quit IRC | 22:17 | |
*** achanda has joined #openstack-neutron | 22:17 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: WIP Move Floating IP processing to Router classes https://review.openstack.org/142863 | 22:20 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Encapsulate DVR Fip namespace https://review.openstack.org/145565 | 22:20 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Move DVR floating ip methods to dvr_router https://review.openstack.org/150628 | 22:20 |
*** thomasem has quit IRC | 22:22 | |
*** r-daneel has quit IRC | 22:22 | |
*** lori is now known as lori|away | 22:23 | |
*** s3wong has quit IRC | 22:23 | |
*** padkrish has joined #openstack-neutron | 22:23 | |
*** armax has joined #openstack-neutron | 22:25 | |
*** techcet has joined #openstack-neutron | 22:25 | |
mtreinish | jogo: do I need to do anything? Or is someone else diving into it? | 22:28 |
*** ihrachyshka has quit IRC | 22:28 | |
*** jorgem has joined #openstack-neutron | 22:29 | |
jogo | mtreinish: mestery is diving in a bit on the neutron side, but last time this was triaged as a tempest bug | 22:31 |
jogo | and I am not diving in | 22:31 |
mestery | jogo: I see salv removed neutron as an affected project last time as well | 22:32 |
mestery | jogo: I'll sync with salv on this one as well and see if anything jogs his memory | 22:32 |
*** leenheer has joined #openstack-neutron | 22:32 | |
jogo | mestery: yeah I want to rule neutron out again on this. and hopefully mtreinish can look at the tempest side | 22:33 |
enikanorov | jogo: i see most failures come from rally job, i guess it's some bug there. (I don't mean that there is no issue in neutron) | 22:33 |
mtreinish | jogo: well, right now it'll be tough being in mid-flight. Probably tomorrow I can look at it | 22:34 |
*** matrohon has quit IRC | 22:34 | |
jogo | enikanorov: good poiint about rally | 22:35 |
jogo | but there is even more in dsvm-neutron-dvr | 22:35 |
*** aranjan has quit IRC | 22:35 | |
enikanorov | dvr job is broken at this moment afaik, so it might be expected that some test fails to cleanup ports | 22:35 |
mestery | armax: ^^^ | 22:36 |
*** tflynn_ has joined #openstack-neutron | 22:36 | |
*** rpothier has quit IRC | 22:36 | |
armax | it got healed today afaik | 22:37 |
*** banix has quit IRC | 22:37 | |
*** pc_m has quit IRC | 22:38 | |
armax | it was broken until this morning | 22:39 |
*** tflynn has quit IRC | 22:39 | |
*** annegent_ has quit IRC | 22:42 | |
*** cference has joined #openstack-neutron | 22:44 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Basic subnetpool CRUD. Do not merge https://review.openstack.org/148698 | 22:44 |
*** Sukhdev has quit IRC | 22:44 | |
*** aranjan has joined #openstack-neutron | 22:45 | |
*** padkrish has quit IRC | 22:46 | |
*** markvoelker has quit IRC | 22:46 | |
*** Networkn3rd has quit IRC | 22:46 | |
*** jorgem1 has joined #openstack-neutron | 22:46 | |
jogo | ahhh | 22:46 |
*** padkrish has joined #openstack-neutron | 22:46 | |
jogo | but we were seeing these failures in the gate | 22:47 |
*** bjornar_ has joined #openstack-neutron | 22:47 | |
*** markvoelker_ has joined #openstack-neutron | 22:47 | |
*** avozza is now known as zz_avozza | 22:47 | |
*** jorgem has quit IRC | 22:48 | |
*** yapeng_ has joined #openstack-neutron | 22:48 | |
*** crc32 has joined #openstack-neutron | 22:51 | |
*** padkrish has quit IRC | 22:51 | |
*** openstackgerrit has quit IRC | 22:51 | |
*** sbfox has quit IRC | 22:51 | |
*** tellesnobrega_ has joined #openstack-neutron | 22:51 | |
*** openstackgerrit has joined #openstack-neutron | 22:52 | |
*** yapeng_ has quit IRC | 22:53 | |
openstackgerrit | enikanorov proposed openstack/neutron: Log tenant ports if subnet could not be deleted https://review.openstack.org/151415 | 22:54 |
*** aranjan has quit IRC | 22:54 | |
*** jckasper has quit IRC | 22:54 | |
*** smillward has quit IRC | 22:57 | |
*** sballe__ has joined #openstack-neutron | 22:57 | |
*** Sukhdev has joined #openstack-neutron | 22:59 | |
*** mlavalle has quit IRC | 23:00 | |
*** rushil has quit IRC | 23:00 | |
jogo | ohh rally gate | 23:01 |
*** yamahata has quit IRC | 23:01 | |
*** jckasper has joined #openstack-neutron | 23:02 | |
*** tflynn_ has quit IRC | 23:03 | |
openstackgerrit | Chuck Carlino proposed openstack/neutron: Allow port mac_address to be modified https://review.openstack.org/112129 | 23:03 |
*** tflynn has joined #openstack-neutron | 23:03 | |
*** zz_avozza is now known as avozza | 23:03 | |
openstackgerrit | Doug Wiegley proposed openstack/neutron: Mechanims to move extensions and config into service repos https://review.openstack.org/151375 | 23:06 |
*** padkrish has joined #openstack-neutron | 23:08 | |
*** jorgem1 is now known as jorgem | 23:08 | |
*** cference has quit IRC | 23:09 | |
*** amotoki has joined #openstack-neutron | 23:09 | |
*** salv-orlando has joined #openstack-neutron | 23:12 | |
*** jckasper has quit IRC | 23:13 | |
*** jckasper has joined #openstack-neutron | 23:13 | |
*** amotoki has quit IRC | 23:14 | |
*** gildub has joined #openstack-neutron | 23:15 | |
*** salv-orlando has quit IRC | 23:17 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Do not run neutron-ns-metadata-proxy as root on dhcp agent https://review.openstack.org/147437 | 23:20 |
*** dims has joined #openstack-neutron | 23:22 | |
openstackgerrit | Itsuro Oda proposed openstack/neutron: Metaplugin decomposition https://review.openstack.org/151464 | 23:23 |
*** crc32 has quit IRC | 23:24 | |
*** dims has quit IRC | 23:25 | |
*** dims has joined #openstack-neutron | 23:25 | |
*** bjornar_ has quit IRC | 23:25 | |
*** crc32 has joined #openstack-neutron | 23:27 | |
*** salv-orlando has joined #openstack-neutron | 23:28 | |
*** aepifanov has quit IRC | 23:28 | |
*** tiswanso has joined #openstack-neutron | 23:28 | |
*** pradk has quit IRC | 23:28 | |
*** imcsk8 has quit IRC | 23:32 | |
*** imcsk8 has joined #openstack-neutron | 23:32 | |
*** tiswanso has quit IRC | 23:32 | |
*** aranjan has joined #openstack-neutron | 23:34 | |
*** dboik has quit IRC | 23:35 | |
*** thomasem has joined #openstack-neutron | 23:36 | |
*** watanabe_isao has joined #openstack-neutron | 23:36 | |
openstackgerrit | Itsuro Oda proposed openstack/neutron: Metaplugin decomposition https://review.openstack.org/151464 | 23:36 |
*** prad has quit IRC | 23:37 | |
*** yfauser has joined #openstack-neutron | 23:38 | |
*** yfauser has left #openstack-neutron | 23:38 | |
*** aranjan has quit IRC | 23:39 | |
*** baoli has quit IRC | 23:41 | |
*** dboik has joined #openstack-neutron | 23:41 | |
*** thedodd has quit IRC | 23:41 | |
*** dims has quit IRC | 23:41 | |
*** rushil has joined #openstack-neutron | 23:42 | |
*** dims has joined #openstack-neutron | 23:42 | |
*** ZZelle_ has quit IRC | 23:46 | |
watanabe_isao | Good morning to ALL.:) | 23:48 |
*** seizadi has joined #openstack-neutron | 23:50 | |
*** baoli has joined #openstack-neutron | 23:51 | |
*** seizadi1 has joined #openstack-neutron | 23:53 | |
*** chlong has joined #openstack-neutron | 23:53 | |
*** seizadi has quit IRC | 23:54 | |
*** dane_leblanc has quit IRC | 23:55 | |
*** salv-orlando has quit IRC | 23:56 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Basic subnetpool CRUD. Do not merge https://review.openstack.org/148698 | 23:56 |
*** baoli has quit IRC | 23:57 | |
*** salv-orlando has joined #openstack-neutron | 23:57 | |
*** manishg has quit IRC | 23:58 | |
*** manishg has joined #openstack-neutron | 23:58 | |
*** jorgem has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!