*** ivar-lazzaro has quit IRC | 00:01 | |
*** pradip_vedams has quit IRC | 00:02 | |
*** pradip_vedams has joined #openstack-neutron | 00:02 | |
*** pradip_vedams has quit IRC | 00:03 | |
*** pradip_vedams has joined #openstack-neutron | 00:04 | |
*** achanda has quit IRC | 00:04 | |
*** vivek-eb_ has quit IRC | 00:05 | |
prometheanfire | this is why the length of the merge process sucks... | 00:05 |
---|---|---|
prometheanfire | This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. | 00:05 |
otherwiseguy | prometheanfire: I feel your pain. | 00:08 |
*** vivek-eb_ has joined #openstack-neutron | 00:08 | |
prometheanfire | we all feel the pain I think | 00:10 |
*** ZZelle has quit IRC | 00:10 | |
*** markvoelker has quit IRC | 00:11 | |
*** ivar-lazzaro has joined #openstack-neutron | 00:11 | |
*** ZZelle has joined #openstack-neutron | 00:11 | |
*** Sukhdev has quit IRC | 00:13 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: device driver and agent refactoring https://review.openstack.org/160179 | 00:14 |
*** dane_leblanc has quit IRC | 00:14 | |
*** ivar-laz_ has joined #openstack-neutron | 00:16 | |
*** ivar-lazzaro has quit IRC | 00:17 | |
*** Marga_ has quit IRC | 00:18 | |
*** bquan has quit IRC | 00:19 | |
*** apuimedo has quit IRC | 00:20 | |
*** pc_m has joined #openstack-neutron | 00:20 | |
*** zzzeek has joined #openstack-neutron | 00:20 | |
*** shaohe_feng has quit IRC | 00:20 | |
*** dboik_ has quit IRC | 00:21 | |
*** dboik has joined #openstack-neutron | 00:22 | |
prometheanfire | that and jenkins randomly failing | 00:26 |
*** ruijing has joined #openstack-neutron | 00:26 | |
*** yushiro has joined #openstack-neutron | 00:27 | |
*** ZZelle_ has quit IRC | 00:28 | |
*** tomoe_ has joined #openstack-neutron | 00:28 | |
*** claudiub has quit IRC | 00:29 | |
*** crc32 has quit IRC | 00:29 | |
*** liusheng has quit IRC | 00:29 | |
*** Marga_ has joined #openstack-neutron | 00:29 | |
*** liusheng has joined #openstack-neutron | 00:29 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable pylint on tests subdir https://review.openstack.org/161959 | 00:29 |
amuller | armax: I started working on that a couple of hours ago and by the time I was finished and hit git review the vmware and ofagent code was chucked | 00:30 |
amuller | armax: so, just so you know, there's some vmware unit test that has 'return' as its first line =D | 00:30 |
gus | amuller: does it pass? ;) | 00:31 |
*** techcet has quit IRC | 00:31 | |
amuller | heh :) | 00:31 |
*** trad511 has quit IRC | 00:31 | |
amuller | there was also a test that was calling a mock and then asserting that the same mock was called | 00:31 |
amuller | That also passed surprisingly | 00:31 |
amuller | (It was also calling the mock with the wrong number of parameters) | 00:32 |
*** absubram has quit IRC | 00:32 | |
gus | fwiw, the vmware driver code has been where I've found most of the coding choices that were upsetting pylint. | 00:32 |
amuller | yeah it found a few in the vmware test code, but the code is gone now anyway | 00:33 |
amuller | somebody else's problem =D | 00:33 |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook https://review.openstack.org/161714 | 00:34 |
*** techcet has joined #openstack-neutron | 00:34 | |
gus | amuller: so I'm not sure enabling pylint on tests is a good idea. Using it to find/fix bugs in tests is obviously useful - but my concern is that allowing for the more exotic coding tricks that are "normal" in tests will prevent us from enabling stricter tests on the main codebase. | 00:34 |
gus | urgh, I used the word tests in a potentially ambiguous way. | 00:35 |
amuller | gus: I understand what you mean | 00:35 |
amuller | It's a good point | 00:35 |
amuller | This patch doesn't add any exclusion | 00:35 |
*** rdo has quit IRC | 00:35 | |
amuller | I can imagine some angry commiter pushing a valid test, pylint coming up with a false positive and the commiter adding an exclusion | 00:35 |
amuller | That can be mitigated by reviewers but there's no certainty | 00:36 |
*** pc_m has quit IRC | 00:36 | |
gus | this is when the other run_tests.sh change runs pylint on a freshly modified unittest file? | 00:36 |
amuller | that change is already merged | 00:37 |
amuller | the gate runs tox -e pep8 which runs pep8 and pylint on everything | 00:37 |
amuller | a commiter can manually invoke tox -e pep8 path/to/files | 00:37 |
amuller | which will run flake8 on everything (I'll handle that) and pylint only on path/to/files | 00:37 |
gus | oh right, but it runs pylint with no args which skips tests (thanks to pylintrc ignore) | 00:38 |
amuller | before my patch yes | 00:38 |
amuller | one serious downside to my proposal is that pylint takes at least twice as long now, and it's run as part of tox -e pep8 | 00:38 |
amuller | so now tox -e pep8 takes a really long time | 00:38 |
amuller | less people will run it | 00:38 |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas: Insert validation in creating/updating firewall https://review.openstack.org/147396 | 00:38 |
amuller | but still | 00:38 |
HenryG | armax: around? The functional job on stable seem to be still broken. | 00:39 |
gus | amuller: the one I'm thinking of is armax's change to run pylint on modified files only ... which I see has also merged. | 00:40 |
amuller | gus: yep | 00:40 |
amuller | it doesn't do that by default though | 00:41 |
gus | I was going to say we should make armax's script also skip files in tests and openstack.common. | 00:41 |
amuller | unless I'm missing something | 00:41 |
*** achanda has joined #openstack-neutron | 00:41 | |
*** leenheer has joined #openstack-neutron | 00:42 | |
*** watanabe_isao has joined #openstack-neutron | 00:42 | |
amuller | gus: maybe the default for tox -e pep8 should be to run flake8 and pylint only on modified files of current commit | 00:42 |
amuller | and add an --all parameter | 00:42 |
gus | amuller: yes, but ;) | 00:42 |
gus | the full set of pylint tests must be run by the gate checks, otherwise we won't catch cases where unmodified file is broken by a changed file. | 00:43 |
*** rdo has joined #openstack-neutron | 00:43 | |
gus | so if we make pep8 default to only modified files then we need to modify the pep8 gate check to invoke it in some other way. | 00:43 |
*** shivharis has quit IRC | 00:43 | |
amuller | true | 00:43 |
*** shivharis has joined #openstack-neutron | 00:43 | |
*** dims has quit IRC | 00:44 | |
*** shivharis has quit IRC | 00:45 | |
*** ivar-laz_ has quit IRC | 00:45 | |
*** ivar-lazzaro has joined #openstack-neutron | 00:45 | |
*** achanda has quit IRC | 00:46 | |
openstackgerrit | Brian Haley proposed openstack/neutron: Change linux/ip_lib code to better handle address families https://review.openstack.org/157555 | 00:48 |
* gus is so appalled by the whole sudo-rootwrap thing. | 00:48 | |
*** ivar-lazzaro has quit IRC | 00:48 | |
gus | there are so many trivially abusable commands in the rootwrap filters files that nova/whatever user is trivially root-equivalent anyway. | 00:49 |
*** ivar-lazzaro has joined #openstack-neutron | 00:49 | |
gus | and now I look closer at the rootwrap code it's pretty easy to make it do things that wasn't intended (these are just bugs that could be fixed however). | 00:49 |
*** ijw has quit IRC | 00:49 | |
*** signed8bit is now known as signed8bit_ZZZzz | 00:50 | |
kevinbenton | anteaya: hey, i saw on the review that you tried to reach out to me on IRC | 00:52 |
kevinbenton | anteaya: when was that? | 00:52 |
amuller | gus: Do you know if I can enable an exclusion for a directory? I'd like to exclude bad-super-call on the tests dir | 00:52 |
anteaya | kevinbenton: this week | 00:53 |
gus | I don't think that's possible without patching pylint. | 00:53 |
anteaya | right after you answered my question about wanting the cla | 00:53 |
kevinbenton | anteaya: ok, well the tags are good, thanks | 00:53 |
anteaya | I asked a follow up question | 00:53 |
anteaya | then twice more | 00:53 |
anteaya | okay good | 00:53 |
amuller | gus: ack | 00:54 |
anteaya | I didn't want to make a big deal about it in the review | 00:54 |
kevinbenton | anteaya: i never got any of those messages on IRC | 00:54 |
anteaya | but yes confirming that the author knows what is in the seed repo and wants them in that state is important to me | 00:54 |
anteaya | kevinbenton: really? | 00:54 |
anteaya | your name was in channel | 00:54 |
anteaya | I used tab complete | 00:54 |
anteaya | what are you using as a bouncer | 00:54 |
anteaya | I asked for you in this channel | 00:55 |
kevinbenton | anteaya: quassel | 00:55 |
anteaya | I don't know it | 00:55 |
anteaya | do youusually get messages left for you in channel when you are offline? | 00:55 |
kevinbenton | anteaya: it's possible that it came through and went far up the scrollback buffer followed by someone else pinging me | 00:55 |
kevinbenton | anteaya: yes | 00:55 |
anteaya | ah | 00:55 |
kevinbenton | anteaya: sorry for not responding | 00:55 |
anteaya | see I use weechat | 00:55 |
anteaya | so before I go offline I move the screen to a window that is the freenode windo | 00:55 |
anteaya | then any ping in any channel alerts me | 00:56 |
anteaya | so I scrollback until I find it | 00:56 |
*** shwetaap has joined #openstack-neutron | 00:56 | |
anteaya | since if I leave any channel open with I close the ssh connection I could miss the ping | 00:56 |
anteaya | so yeah, no worries | 00:56 |
anteaya | glad your seed repo is the way you wanted it | 00:56 |
*** amuller has quit IRC | 00:56 | |
kevinbenton | anteaya: thanks for the help. one quick question. is there a workflow doc somewhere for making new tags on the repo once it's in gerrit? | 00:57 |
anteaya | hmmmm | 00:57 |
* anteaya looks | 00:57 | |
arif-ali | hi, does anyone know why the /var/lib/neutron/metadata_proxy file would not be created on the network node; been trying to debug this for approx a week | 00:58 |
anteaya | kevinbenton: give http://docs.openstack.org/infra/manual/drivers.html#tagging-a-release a test drive | 00:58 |
anteaya | kevinbenton: let me know how you do | 00:58 |
kevinbenton | anteaya: thanks, i'll check it out | 00:59 |
*** tomoe_ has quit IRC | 00:59 | |
anteaya | sure | 00:59 |
*** leenheer has quit IRC | 01:00 | |
*** evgenyf has joined #openstack-neutron | 01:02 | |
*** carl_baldwin has quit IRC | 01:02 | |
*** xgerman has quit IRC | 01:03 | |
*** mikedillion has joined #openstack-neutron | 01:03 | |
*** sbalukoff has quit IRC | 01:03 | |
*** shwetaap1 has joined #openstack-neutron | 01:05 | |
*** mikedillion has quit IRC | 01:05 | |
*** mikedillion has joined #openstack-neutron | 01:06 | |
*** shwetaap has quit IRC | 01:08 | |
*** tomoe_ has joined #openstack-neutron | 01:08 | |
*** topshare has joined #openstack-neutron | 01:11 | |
*** tomoe_ has quit IRC | 01:13 | |
openstackgerrit | Merged openstack/neutron: Move _set_subnet_arp_info to dvr_router https://review.openstack.org/158460 | 01:13 |
*** ivar-laz_ has joined #openstack-neutron | 01:15 | |
*** ivar-laz_ has quit IRC | 01:15 | |
*** markvoelker has joined #openstack-neutron | 01:15 | |
*** ivar-laz_ has joined #openstack-neutron | 01:16 | |
*** fandi has joined #openstack-neutron | 01:16 | |
*** aix has joined #openstack-neutron | 01:16 | |
*** rwsu is now known as rwsu-afk | 01:17 | |
openstackgerrit | Merged openstack/neutron: Move Neutron Policy pages into the tree https://review.openstack.org/161799 | 01:18 |
*** ivar-lazzaro has quit IRC | 01:18 | |
*** pradip_vedams has quit IRC | 01:19 | |
*** shaohe_feng has joined #openstack-neutron | 01:20 | |
*** markvoelker has quit IRC | 01:20 | |
*** melwitt has quit IRC | 01:22 | |
*** tomoe_ has joined #openstack-neutron | 01:23 | |
*** zzzeek has quit IRC | 01:23 | |
*** shwetaap has joined #openstack-neutron | 01:23 | |
openstackgerrit | Abhishek Raut proposed openstack/neutron: Cisco Nexus1000V ML2 Mechanism Driver https://review.openstack.org/157243 | 01:25 |
*** shwetaap1 has quit IRC | 01:25 | |
*** tsg has quit IRC | 01:26 | |
*** shwetaap has quit IRC | 01:26 | |
*** tsg has joined #openstack-neutron | 01:26 | |
*** bobmel has quit IRC | 01:27 | |
*** sripriya has quit IRC | 01:27 | |
*** bobmel has joined #openstack-neutron | 01:28 | |
*** shwetaap has joined #openstack-neutron | 01:28 | |
*** tomoe__ has joined #openstack-neutron | 01:28 | |
*** r-daneel has quit IRC | 01:31 | |
*** tomoe_ has quit IRC | 01:31 | |
*** zhhuabj has joined #openstack-neutron | 01:32 | |
*** xuhanp has joined #openstack-neutron | 01:32 | |
*** fandi has quit IRC | 01:33 | |
*** fandi has joined #openstack-neutron | 01:33 | |
*** ruijing has quit IRC | 01:34 | |
*** tsg has quit IRC | 01:37 | |
*** stanzgy has joined #openstack-neutron | 01:38 | |
*** stanzgy_ has joined #openstack-neutron | 01:38 | |
*** manishg_ has quit IRC | 01:39 | |
openstackgerrit | Sukhdev Kapur proposed openstack/neutron: Arista L3 Service Plugin decomposition https://review.openstack.org/161984 | 01:40 |
*** manishg has joined #openstack-neutron | 01:40 | |
*** vishwanathj has quit IRC | 01:40 | |
*** vishwanathj has joined #openstack-neutron | 01:41 | |
*** shwetaap has quit IRC | 01:41 | |
*** popw has joined #openstack-neutron | 01:41 | |
*** evgenyf has quit IRC | 01:42 | |
*** mlavalle has quit IRC | 01:43 | |
*** manishg has quit IRC | 01:44 | |
*** techcet has quit IRC | 01:45 | |
*** vishwanathj has quit IRC | 01:45 | |
*** achanda has joined #openstack-neutron | 01:46 | |
*** manishg has joined #openstack-neutron | 01:50 | |
*** manishg_ has joined #openstack-neutron | 01:53 | |
*** manishg__ has joined #openstack-neutron | 01:56 | |
*** _cjones_ has quit IRC | 01:56 | |
*** manishg has quit IRC | 01:57 | |
*** rkukura has quit IRC | 01:57 | |
*** SridharRamaswamy has quit IRC | 01:57 | |
*** techcet has joined #openstack-neutron | 01:57 | |
*** manishg_ has quit IRC | 01:58 | |
*** manishg has joined #openstack-neutron | 02:01 | |
*** manishg__ has quit IRC | 02:01 | |
*** mikedillion has quit IRC | 02:02 | |
*** techcet has quit IRC | 02:02 | |
*** manishg has quit IRC | 02:04 | |
*** ChuckC has quit IRC | 02:04 | |
*** manishg has joined #openstack-neutron | 02:04 | |
*** tiswanso has joined #openstack-neutron | 02:04 | |
*** ChuckC has joined #openstack-neutron | 02:05 | |
*** tiswanso has quit IRC | 02:05 | |
*** tiswanso has joined #openstack-neutron | 02:05 | |
*** erkules_ has joined #openstack-neutron | 02:07 | |
openstackgerrit | Itsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network https://review.openstack.org/161947 | 02:08 |
*** tiswanso has quit IRC | 02:08 | |
*** tiswanso has joined #openstack-neutron | 02:09 | |
*** manishg has quit IRC | 02:09 | |
*** rkukura has joined #openstack-neutron | 02:09 | |
*** erkules has quit IRC | 02:10 | |
*** flwang has quit IRC | 02:10 | |
*** manishg has joined #openstack-neutron | 02:13 | |
*** tsg has joined #openstack-neutron | 02:14 | |
*** shwetaap has joined #openstack-neutron | 02:14 | |
*** oomichi has quit IRC | 02:14 | |
*** flwang1 has joined #openstack-neutron | 02:15 | |
*** ivar-laz_ has quit IRC | 02:16 | |
openstackgerrit | Sukhdev Kapur proposed openstack/neutron: Arista L3 Service Plugin decomposition https://review.openstack.org/161984 | 02:16 |
*** shaohe_robot has joined #openstack-neutron | 02:16 | |
*** ivar-lazzaro has joined #openstack-neutron | 02:17 | |
*** markvoelker has joined #openstack-neutron | 02:17 | |
*** crc32 has joined #openstack-neutron | 02:17 | |
*** manishg has quit IRC | 02:17 | |
*** baoli has joined #openstack-neutron | 02:17 | |
*** signed8bit_ZZZzz is now known as signed8bit | 02:18 | |
*** signed8bit has quit IRC | 02:19 | |
*** markvoelker has quit IRC | 02:21 | |
*** ivar-lazzaro has quit IRC | 02:23 | |
*** shaohe_robot is now known as shaohe_feng_onli | 02:24 | |
*** ivar-lazzaro has joined #openstack-neutron | 02:24 | |
*** shaohe_feng_onli is now known as shaohe_feng_ | 02:24 | |
*** ivar-lazzaro has quit IRC | 02:25 | |
*** ivar-lazzaro has joined #openstack-neutron | 02:26 | |
*** yamamoto has joined #openstack-neutron | 02:27 | |
*** nlahouti has quit IRC | 02:30 | |
openstackgerrit | Sridar Kandaswamy proposed openstack/neutron-fwaas: FWaaS Insertion Model on Routers https://review.openstack.org/152697 | 02:33 |
*** catohornet has quit IRC | 02:36 | |
*** zzzeek has joined #openstack-neutron | 02:37 | |
*** tomoe__ has quit IRC | 02:38 | |
*** tsg has quit IRC | 02:39 | |
*** bandarji has quit IRC | 02:40 | |
*** tomoe_ has joined #openstack-neutron | 02:40 | |
*** zzzeek_ has joined #openstack-neutron | 02:42 | |
*** zzzeek has quit IRC | 02:42 | |
*** zzzeek_ is now known as zzzeek | 02:42 | |
*** baoli has quit IRC | 02:43 | |
*** zzzeek has quit IRC | 02:47 | |
*** zzzeek has joined #openstack-neutron | 02:48 | |
*** shwetaap1 has joined #openstack-neutron | 02:54 | |
*** shaohe_feng has quit IRC | 02:54 | |
*** ChuckC_ has joined #openstack-neutron | 02:56 | |
*** leenheer has joined #openstack-neutron | 02:57 | |
*** shwetaap has quit IRC | 02:57 | |
*** amrith has left #openstack-neutron | 02:58 | |
*** techcet has joined #openstack-neutron | 02:59 | |
*** ChuckC has quit IRC | 02:59 | |
*** baoli has joined #openstack-neutron | 03:02 | |
*** techcet has quit IRC | 03:03 | |
*** manishg has joined #openstack-neutron | 03:04 | |
*** radez is now known as radez_g0n3 | 03:05 | |
*** jckasper has joined #openstack-neutron | 03:11 | |
*** yamahata has quit IRC | 03:12 | |
*** ivar-lazzaro has quit IRC | 03:16 | |
*** markvoelker has joined #openstack-neutron | 03:18 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver https://review.openstack.org/153946 | 03:18 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 03:18 |
*** tomoe_ has quit IRC | 03:20 | |
*** Murali has joined #openstack-neutron | 03:22 | |
*** markvoelker has quit IRC | 03:22 | |
*** ChuckC_ is now known as ChuckC | 03:27 | |
*** leenheer has quit IRC | 03:32 | |
openstackgerrit | Itsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network https://review.openstack.org/161947 | 03:34 |
*** anish__ has joined #openstack-neutron | 03:34 | |
*** rkukura has quit IRC | 03:36 | |
*** spandhe has quit IRC | 03:37 | |
*** baoli has quit IRC | 03:42 | |
*** david-lyle is now known as david-lyle_afk | 03:44 | |
*** manishg has quit IRC | 03:45 | |
*** bquan has joined #openstack-neutron | 03:45 | |
*** manishg has joined #openstack-neutron | 03:45 | |
*** vivek-eb_ has quit IRC | 03:46 | |
*** fandi has quit IRC | 03:49 | |
*** oomichi has joined #openstack-neutron | 03:51 | |
*** baoli has joined #openstack-neutron | 03:53 | |
*** Murali has quit IRC | 03:55 | |
*** harlowja is now known as harlowja_away | 03:57 | |
*** julim has quit IRC | 03:57 | |
*** achanda has quit IRC | 03:57 | |
openstackgerrit | Brandon Logan proposed openstack/python-neutronclient: Added call to retrieve the loadbalancer status tree https://review.openstack.org/162002 | 03:57 |
*** jckasper has quit IRC | 03:57 | |
openstackgerrit | Vijay Chundury proposed openstack/neutron: Replace IPv4 and IPv6 default addresses with constants https://review.openstack.org/160782 | 03:58 |
openstackgerrit | shihanzhang proposed openstack/neutron: Fix 'router_gateway' port status can't be updated https://review.openstack.org/151501 | 03:59 |
openstackgerrit | Merged openstack/neutron: Decouple L3 and VPN service plugins during router operations https://review.openstack.org/153776 | 03:59 |
*** techcet has joined #openstack-neutron | 04:01 | |
*** anish_ has joined #openstack-neutron | 04:02 | |
*** techcet has quit IRC | 04:05 | |
*** anish__ has quit IRC | 04:06 | |
*** Longgeek has joined #openstack-neutron | 04:08 | |
*** mriedem_away has quit IRC | 04:10 | |
*** mriedem has joined #openstack-neutron | 04:11 | |
*** vivek-ebay has joined #openstack-neutron | 04:11 | |
*** amotoki has joined #openstack-neutron | 04:16 | |
gongysh_ | oda-g: hi | 04:17 |
oda-g | gongysh_: hi | 04:17 |
gongysh_ | oda-g: is it https://review.openstack.org/161947 by you? | 04:18 |
oda-g | gongysh_: yes | 04:19 |
*** markvoelker has joined #openstack-neutron | 04:19 | |
*** SridharG has joined #openstack-neutron | 04:19 | |
gongysh_ | oda-g: how do u know it is a regress bug by your previous patch? | 04:19 |
oda-g | gongysh_: from my customer's test | 04:20 |
*** alexpilotti has quit IRC | 04:22 | |
gongysh_ | oda-g: ok, but do u have an analysis how that your previous changes the traffic to lead to this bug? | 04:23 |
*** Marga_ has quit IRC | 04:24 | |
*** markvoelker has quit IRC | 04:25 | |
oda-g | gongysh_: originally there are rules "--A neutron-l3-agent-snat -s <internal cidr> -j SNAT --to-source <gw-ip>" | 04:25 |
*** tiswanso has quit IRC | 04:27 | |
*** baoli has quit IRC | 04:28 | |
oda-g | gongysh_: my previous patch replaces these to "-A neutron-l3-agent-snat -o <external interface> -j SNAT --to-source <gw-ip>" | 04:31 |
*** baoli has joined #openstack-neutron | 04:31 | |
oda-g | gongysh_: so SNAT toward internal interface is missing. | 04:32 |
*** anilvenkata has joined #openstack-neutron | 04:33 | |
*** vmtrooper has joined #openstack-neutron | 04:33 | |
*** marrusl has quit IRC | 04:35 | |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during delete operation https://review.openstack.org/155470 | 04:37 |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during create/update operations https://review.openstack.org/153775 | 04:37 |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Decouple L3 and service plugins during DVR router migration https://review.openstack.org/154749 | 04:37 |
*** achanda has joined #openstack-neutron | 04:38 | |
*** leenheer has joined #openstack-neutron | 04:39 | |
*** leenheer has quit IRC | 04:40 | |
*** manishg has quit IRC | 04:47 | |
*** leenheer has joined #openstack-neutron | 04:47 | |
*** leenheer has quit IRC | 04:48 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver https://review.openstack.org/153946 | 04:52 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 04:52 |
*** yushiro has quit IRC | 04:53 | |
*** achanda has quit IRC | 04:54 | |
*** Murali has joined #openstack-neutron | 04:58 | |
yamamoto | armax: ping | 04:58 |
yamamoto | or any DVR folks around? | 04:59 |
*** oda-g has quit IRC | 05:03 | |
*** watanabe_isao has quit IRC | 05:04 | |
*** vivek-ebay has quit IRC | 05:06 | |
*** baoli has quit IRC | 05:06 | |
*** tomoe_ has joined #openstack-neutron | 05:09 | |
*** SridharG has quit IRC | 05:15 | |
*** gongysh_ has quit IRC | 05:16 | |
*** shwetaap has joined #openstack-neutron | 05:16 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 05:17 |
*** zhenq has quit IRC | 05:18 | |
*** shwetaap1 has quit IRC | 05:19 | |
*** vmtrooper has quit IRC | 05:19 | |
*** tidwellr has quit IRC | 05:19 | |
*** oomichi has quit IRC | 05:20 | |
*** Murali has quit IRC | 05:21 | |
*** markvoelker has joined #openstack-neutron | 05:21 | |
*** vmtrooper has joined #openstack-neutron | 05:21 | |
*** markvoelker has quit IRC | 05:26 | |
*** Trevor_V has joined #openstack-neutron | 05:27 | |
*** gongysh_ has joined #openstack-neutron | 05:28 | |
*** Trevor_V has quit IRC | 05:29 | |
*** TrevorV|Home has joined #openstack-neutron | 05:29 | |
*** Bhavya has joined #openstack-neutron | 05:33 | |
*** SridharG has joined #openstack-neutron | 05:36 | |
*** bquan has quit IRC | 05:36 | |
*** Marga_ has joined #openstack-neutron | 05:39 | |
*** Marga_ has quit IRC | 05:40 | |
*** tomoe_ has quit IRC | 05:41 | |
*** vmtrooper has quit IRC | 05:41 | |
openstackgerrit | Vijay Chundury proposed openstack/neutron: Replace IPv4 and IPv6 default addresses with constants https://review.openstack.org/160782 | 05:41 |
*** Marga_ has joined #openstack-neutron | 05:41 | |
*** watanabe_isao has joined #openstack-neutron | 05:42 | |
*** yushiro has joined #openstack-neutron | 05:43 | |
*** numan has joined #openstack-neutron | 05:43 | |
*** tflynn has quit IRC | 05:46 | |
*** absubram has joined #openstack-neutron | 05:49 | |
*** SridharG has left #openstack-neutron | 05:50 | |
*** vivek-ebay has joined #openstack-neutron | 05:52 | |
openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 05:53 |
*** tomoe_ has joined #openstack-neutron | 05:53 | |
*** achanda has joined #openstack-neutron | 05:56 | |
*** yfried has joined #openstack-neutron | 05:56 | |
*** vivek-ebay has quit IRC | 05:59 | |
*** absubram has quit IRC | 05:59 | |
*** lori|away is now known as lori | 06:00 | |
garyk | markmcclain: you around? can you please look at https://review.openstack.org/#/c/161878/ | 06:01 |
*** techcet has joined #openstack-neutron | 06:02 | |
*** Networkn_ has quit IRC | 06:04 | |
*** Networkn3rd has joined #openstack-neutron | 06:04 | |
*** Networkn3rd has quit IRC | 06:05 | |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during delete operation https://review.openstack.org/155470 | 06:05 |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during create/update operations https://review.openstack.org/153775 | 06:05 |
*** TrevorV|Home has quit IRC | 06:06 | |
*** Networkn3rd has joined #openstack-neutron | 06:06 | |
*** techcet has quit IRC | 06:06 | |
*** vishwanathj has joined #openstack-neutron | 06:07 | |
*** nlahouti has joined #openstack-neutron | 06:07 | |
*** vishwana_ has joined #openstack-neutron | 06:08 | |
*** armax has quit IRC | 06:09 | |
*** Networkn3rd has quit IRC | 06:09 | |
*** vishwanathj has quit IRC | 06:11 | |
*** coolsvap_ has quit IRC | 06:11 | |
*** Bsony has joined #openstack-neutron | 06:13 | |
*** nlahouti has quit IRC | 06:14 | |
*** nlahouti has joined #openstack-neutron | 06:14 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Imported Translations from Transifex https://review.openstack.org/161614 | 06:14 |
*** setuid has quit IRC | 06:15 | |
*** Bsony has quit IRC | 06:17 | |
*** Marga_ has quit IRC | 06:21 | |
*** setuid has joined #openstack-neutron | 06:22 | |
*** markvoelker has joined #openstack-neutron | 06:22 | |
*** yushiro has quit IRC | 06:24 | |
*** tomoe_ has quit IRC | 06:24 | |
*** markvoelker has quit IRC | 06:27 | |
*** yfauser has joined #openstack-neutron | 06:28 | |
*** yfauser has left #openstack-neutron | 06:29 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 06:32 |
*** yog__ has joined #openstack-neutron | 06:37 | |
*** pradipta has joined #openstack-neutron | 06:37 | |
*** Longgeek has quit IRC | 06:39 | |
*** SridharG has joined #openstack-neutron | 06:39 | |
*** lennyb__ has quit IRC | 06:44 | |
*** tflynn has joined #openstack-neutron | 06:47 | |
*** tflynn has quit IRC | 06:51 | |
*** phschwartz has quit IRC | 06:54 | |
*** yushiro has joined #openstack-neutron | 06:55 | |
*** tomoe_ has joined #openstack-neutron | 06:55 | |
*** gildub has quit IRC | 06:55 | |
*** phschwartz has joined #openstack-neutron | 06:57 | |
*** Bsony has joined #openstack-neutron | 06:57 | |
*** lazy_prince is now known as killer_prince | 06:58 | |
*** tomoe_ has quit IRC | 07:00 | |
*** yamahata has joined #openstack-neutron | 07:00 | |
*** killer_prince is now known as lazy_prince | 07:03 | |
*** techcet has joined #openstack-neutron | 07:04 | |
yushiro | 07:06 | |
*** techcet has quit IRC | 07:08 | |
*** Networkn3rd has joined #openstack-neutron | 07:10 | |
*** Networkn3rd has quit IRC | 07:14 | |
*** jamielennox is now known as jamielennox|away | 07:16 | |
openstackgerrit | pritesh proposed openstack/python-neutronclient: Adding VLAN Transparency support to neutronclient https://review.openstack.org/162040 | 07:17 |
openstackgerrit | ZongKai LI proposed openstack/neutron: fix router schedule in dvr migrate case https://review.openstack.org/158349 | 07:18 |
*** ivar-lazzaro has joined #openstack-neutron | 07:18 | |
*** Longgeek has joined #openstack-neutron | 07:19 | |
*** kickinz1|afk is now known as kickinz1 | 07:21 | |
*** ivar-lazzaro has quit IRC | 07:22 | |
openstackgerrit | pritesh proposed openstack/neutron: Adding VLAN Transparency support for ML2 along with REST API changes https://review.openstack.org/158420 | 07:23 |
*** yamahata has quit IRC | 07:23 | |
*** markvoelker has joined #openstack-neutron | 07:24 | |
*** scheuran has joined #openstack-neutron | 07:27 | |
*** markvoelker has quit IRC | 07:29 | |
*** hichihara has quit IRC | 07:33 | |
*** vthapar has joined #openstack-neutron | 07:34 | |
*** Bsony has quit IRC | 07:36 | |
*** apuimedo has joined #openstack-neutron | 07:39 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: WIP: pecan install https://review.openstack.org/162044 | 07:40 |
openstackgerrit | Kevin Benton proposed openstack/neutron: WIP: pecan install https://review.openstack.org/162044 | 07:41 |
*** kickinz1 is now known as kickinz1|afk | 07:41 | |
*** kickinz1|afk is now known as kickinz1 | 07:42 | |
openstackgerrit | yalei wang proposed openstack/neutron-fwaas: Implementation of Mcafee NGFW Driver https://review.openstack.org/152093 | 07:42 |
*** Longgeek has quit IRC | 07:43 | |
*** achanda has quit IRC | 07:44 | |
*** achanda has joined #openstack-neutron | 07:44 | |
*** sbalukoff has joined #openstack-neutron | 07:45 | |
*** mriedem has quit IRC | 07:47 | |
*** mriedem has joined #openstack-neutron | 07:47 | |
*** tflynn has joined #openstack-neutron | 07:47 | |
*** achanda has quit IRC | 07:48 | |
*** liusheng has quit IRC | 07:50 | |
*** kawa2014 has joined #openstack-neutron | 07:50 | |
*** liusheng has joined #openstack-neutron | 07:51 | |
*** tflynn has quit IRC | 07:52 | |
*** carlp has quit IRC | 07:53 | |
*** tomoe_ has joined #openstack-neutron | 07:56 | |
*** gongysh_ has quit IRC | 07:59 | |
*** shwetaap has quit IRC | 07:59 | |
*** tomoe_ has quit IRC | 08:00 | |
*** tomoe_ has joined #openstack-neutron | 08:01 | |
*** achanda has joined #openstack-neutron | 08:05 | |
*** moha_hunt has joined #openstack-neutron | 08:06 | |
*** carlp has joined #openstack-neutron | 08:06 | |
openstackgerrit | yalei wang proposed openstack/neutron: Add portsecurity extension support https://review.openstack.org/126552 | 08:07 |
*** safchain has joined #openstack-neutron | 08:07 | |
*** gongysh has joined #openstack-neutron | 08:11 | |
*** chlong has quit IRC | 08:11 | |
*** nlahouti has quit IRC | 08:13 | |
*** SumitNaiksatam has quit IRC | 08:13 | |
*** SumitNaiksatam has joined #openstack-neutron | 08:16 | |
*** luqas__ has joined #openstack-neutron | 08:16 | |
*** gongysh_ has joined #openstack-neutron | 08:17 | |
*** yog__ has quit IRC | 08:22 | |
*** krtaylor has quit IRC | 08:22 | |
*** matrohon has joined #openstack-neutron | 08:24 | |
*** ronis has joined #openstack-neutron | 08:24 | |
*** markvoelker has joined #openstack-neutron | 08:25 | |
*** devvesa has joined #openstack-neutron | 08:29 | |
*** devvesa has quit IRC | 08:30 | |
*** markvoelker has quit IRC | 08:31 | |
*** karimb has joined #openstack-neutron | 08:35 | |
*** krtaylor has joined #openstack-neutron | 08:35 | |
*** setuid has quit IRC | 08:37 | |
*** tomoe_ has quit IRC | 08:38 | |
*** vthapar has quit IRC | 08:39 | |
*** afazekas has joined #openstack-neutron | 08:39 | |
*** watanabe_isao has quit IRC | 08:39 | |
*** setuid has joined #openstack-neutron | 08:39 | |
*** scheuran_ has joined #openstack-neutron | 08:40 | |
*** scheuran has quit IRC | 08:43 | |
*** jlanoux has joined #openstack-neutron | 08:44 | |
*** crc32 has quit IRC | 08:46 | |
*** aepifanov has joined #openstack-neutron | 08:47 | |
*** jgrimm is now known as zz_jgrimm | 08:49 | |
*** doude has joined #openstack-neutron | 08:49 | |
openstackgerrit | Elena Ezhova proposed openstack/neutron: test_wsgi: reduce code duplication and fix argument order in assertEqual https://review.openstack.org/162059 | 08:51 |
*** achanda has quit IRC | 08:54 | |
*** krtaylor has quit IRC | 08:54 | |
*** liusheng has quit IRC | 08:55 | |
*** ygbo has joined #openstack-neutron | 08:55 | |
openstackgerrit | Elena Ezhova proposed openstack/neutron: Reduce code duplication and fix argument order in test_wsgi https://review.openstack.org/162059 | 08:55 |
*** liusheng has joined #openstack-neutron | 08:56 | |
*** achanda has joined #openstack-neutron | 08:57 | |
*** SumitNaiksatam has quit IRC | 08:58 | |
*** Networkn3rd has joined #openstack-neutron | 08:59 | |
*** tomoe_ has joined #openstack-neutron | 09:00 | |
*** jistr has joined #openstack-neutron | 09:02 | |
*** Networkn3rd has quit IRC | 09:03 | |
*** jpena has joined #openstack-neutron | 09:03 | |
*** erkules_ is now known as erkules | 09:04 | |
*** ajo has joined #openstack-neutron | 09:05 | |
*** devvesa has joined #openstack-neutron | 09:10 | |
*** yamamoto has quit IRC | 09:10 | |
*** krtaylor has joined #openstack-neutron | 09:10 | |
*** achanda has quit IRC | 09:12 | |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Fix dist_fip_count problem during router migration https://review.openstack.org/151153 | 09:13 |
*** achanda has joined #openstack-neutron | 09:13 | |
*** achanda has quit IRC | 09:14 | |
*** achanda has joined #openstack-neutron | 09:14 | |
*** ronis has quit IRC | 09:15 | |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Remove qg from router namespace for DVR migration https://review.openstack.org/151181 | 09:15 |
*** ronis has joined #openstack-neutron | 09:15 | |
*** achanda has quit IRC | 09:19 | |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Fix validation of physical network name for flat nets https://review.openstack.org/160842 | 09:19 |
openstackgerrit | Qin Zhao proposed openstack/python-neutronclient: Add InvalidIpForSubnetClient exception https://review.openstack.org/162062 | 09:22 |
*** SumitNaiksatam has joined #openstack-neutron | 09:26 | |
openstackgerrit | Preeti Mirji proposed openstack/python-neutronclient: L2gateway cli extension testing https://review.openstack.org/162065 | 09:26 |
*** rotbeard has joined #openstack-neutron | 09:26 | |
*** markvoelker has joined #openstack-neutron | 09:27 | |
*** Longgeek has joined #openstack-neutron | 09:32 | |
*** markvoelker has quit IRC | 09:33 | |
*** ihrachyshka has joined #openstack-neutron | 09:33 | |
*** saju_m has joined #openstack-neutron | 09:34 | |
*** jistr is now known as jistr|biab | 09:36 | |
*** blues-man has joined #openstack-neutron | 09:38 | |
*** jp_at_hp has joined #openstack-neutron | 09:40 | |
openstackgerrit | Merged openstack/neutron: Adding DB model changes for Nuage Plugin post decomposition https://review.openstack.org/159281 | 09:41 |
kevinbenton | salv-orlando: hi | 09:41 |
*** yfauser has joined #openstack-neutron | 09:42 | |
*** yfauser has left #openstack-neutron | 09:42 | |
openstackgerrit | Merged openstack/neutron: Updated from global requirements https://review.openstack.org/161815 | 09:43 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Big Switch Networks code split https://review.openstack.org/160360 | 09:43 |
*** tflynn has joined #openstack-neutron | 09:47 | |
*** anish_ has quit IRC | 09:50 | |
*** tflynn has quit IRC | 09:51 | |
*** popw has quit IRC | 09:54 | |
*** ihrachyshka has quit IRC | 09:57 | |
salv-orlando | hi kevinbenton | 09:58 |
kevinbenton | salv-orlando: had a question about a vmware unit test failure | 09:59 |
kevinbenton | salv-orlando: but i think the split that merged today may have changed that | 09:59 |
*** lazy_prince has quit IRC | 10:00 | |
kevinbenton | salv-orlando: it seems there may be a legitimate timing issue here | 10:00 |
kevinbenton | http://logs.openstack.org/60/160360/4/check/gate-neutron-python27/f6ddb1b/testr_results.html.gz | 10:00 |
*** killer_prince has joined #openstack-neutron | 10:00 | |
salv-orlando | kevinbenton: waiting for the page to load... | 10:01 |
*** killer_prince is now known as lazy_prince | 10:01 | |
kevinbenton | salv-orlando: in that _destroy_metadata_access_network function add_router_interface is called in the exception handling without starting a new transaction | 10:01 |
kevinbenton | salv-orlando: so if the exception resulted in a rollback, i think the session can be stuck in a 'rollback called' state | 10:01 |
salv-orlando | kevinbenton: thanks for analyzing that code! | 10:03 |
salv-orlando | if that is correct this should fail in this way always | 10:04 |
salv-orlando | the thing is that this unit test was coinceived to simulate this nested rollback situation | 10:04 |
salv-orlando | it's just that the failure mode should not have been this one. | 10:04 |
salv-orlando | I'm not sure if this has something to do with a recent change which does not play well with l3_dvr_db | 10:05 |
salv-orlando | but that's the only thing that can make any sense | 10:06 |
salv-orlando | oh wait that code never went in master | 10:06 |
*** Longgeek has quit IRC | 10:06 | |
kevinbenton | it's not deterministic | 10:07 |
kevinbenton | i've been trying to figure out the cause for several hours now | 10:07 |
salv-orlando | kevinbenton: right. perhaps there is some racey problem which leads the metadata network handler to do the wrong thing | 10:07 |
salv-orlando | because from _destory_metadata_access_network it should not call add_router_interface | 10:08 |
salv-orlando | not sure what triggers that | 10:08 |
kevinbenton | salv-orlando: i thought that is exactly what that was triggering? | 10:08 |
*** aepifanov has quit IRC | 10:08 | |
salv-orlando | ah yes it's the failure test sorry | 10:09 |
salv-orlando | I:q | 10:09 |
kevinbenton | https://github.com/openstack/neutron/blob/2387f23f12fdc546df0a160ca791d00ce492a795/neutron/plugins/vmware/dhcp_meta/rpc.py#L203 | 10:10 |
kevinbenton | salv-orlando: interestingly it seemed to be making it there in both the passing and failing condition | 10:11 |
kevinbenton | salv-orlando: so the difference was just in the state of context.session i believe | 10:11 |
*** Longgeek has joined #openstack-neutron | 10:14 | |
*** topshare has quit IRC | 10:14 | |
*** yog__ has joined #openstack-neutron | 10:15 | |
salv-orlando | kevinbenton: it might be. I just need to check whether I can do something to explicitly prevent sqlalchemy to deactivate the session. | 10:16 |
*** saikrishna has joined #openstack-neutron | 10:16 | |
salv-orlando | kevinbenton: it could be be because of those yields. I need to look back at the history of this module, but since the code is split anyway it does not matter. Also, I'm making all that logic asynchronous and running with its own db session | 10:21 |
salv-orlando | so I guess it does not really matter. | 10:21 |
kevinbenton | salv-orlando: ok, i just figured i would point it out in case it was indicative of some issue with the rollback logic there | 10:22 |
salv-orlando | kevinbenton: I believe that for this matter we should stay on the safe side and non insist on performing reattaching the interface on rollback... anyway you're deleting the router so it does not really matter | 10:23 |
*** pask81 has joined #openstack-neutron | 10:23 | |
*** liusheng has quit IRC | 10:23 | |
salv-orlando | probably there's no reason for making the delete process fail at all | 10:23 |
salv-orlando | just ignore and live with some dangling backend resources might be a better solution | 10:24 |
*** liusheng has joined #openstack-neutron | 10:24 | |
kevinbenton | salv-orlando: oh, this is part of a larger router deletion process? | 10:25 |
salv-orlando | yeah the story is that you delete a router and in the process tears down the router's metadata network | 10:26 |
*** yuanying has quit IRC | 10:26 | |
salv-orlando | and I this logic that fails the router deletion, and restores this metadata network in this case | 10:26 |
*** gildub has joined #openstack-neutron | 10:27 | |
salv-orlando | which probably does not make a lot of sense | 10:27 |
salv-orlando | obviously I need to go back into git history and understand why I did this in the first place | 10:27 |
kevinbenton | oh, i see. to make it atomic-ish | 10:27 |
salv-orlando | kevinbenton: yes, I wanted everything to be atomic because I did not want to leave stuff around (these objects are also actual admin-owned neutron objects) | 10:28 |
salv-orlando | I did everything synchronously because at that time it was the way everything in neutron was supposed to be done. But I never believed this operation should be synchronous. If nothing else because it makes some router operations 4x slower | 10:29 |
*** markvoelker has joined #openstack-neutron | 10:29 | |
kevinbenton | salv-orlando: make sense | 10:30 |
kevinbenton | salv-orlando: makes* | 10:30 |
salv-orlando | kevinbenton: btw, great work on the pecan switch!!!! | 10:33 |
openstackgerrit | Xu Han Peng proposed openstack/neutron: Fix DB2 upgrade problem for Remove Hyper-V plugin https://review.openstack.org/162083 | 10:34 |
kevinbenton | salv-orlando: :( | 10:34 |
kevinbenton | salv-orlando: i don't have enough hours in the day | 10:34 |
kevinbenton | salv-orlando: i am in the process of quitting my job | 10:35 |
*** markvoelker has quit IRC | 10:35 | |
kevinbenton | salv-orlando: and it has resulted in a lot of work | 10:35 |
*** carlp has quit IRC | 10:35 | |
openstackgerrit | Jian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols https://review.openstack.org/162084 | 10:35 |
salv-orlando | kevinbenton: that's understandable. | 10:36 |
*** xuhanp has quit IRC | 10:36 | |
*** ZZelle has quit IRC | 10:37 | |
openstackgerrit | Jian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols https://review.openstack.org/151128 | 10:37 |
kevinbenton | salv-orlando: i hope to clean up the stuff i was messing with and push something more substantial over the weekend | 10:39 |
*** jistr|biab is now known as jistr | 10:39 | |
*** liusheng has quit IRC | 10:41 | |
openstackgerrit | Waldemar Znoinski proposed openstack/neutron: Networking OVS-DPDK plugin decomposition https://review.openstack.org/162088 | 10:41 |
*** liusheng has joined #openstack-neutron | 10:42 | |
openstackgerrit | Jian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols https://review.openstack.org/151128 | 10:45 |
*** Networkn3rd has joined #openstack-neutron | 10:47 | |
*** stanzgy has quit IRC | 10:51 | |
*** stanzgy_ has quit IRC | 10:51 | |
*** Networkn3rd has quit IRC | 10:52 | |
openstackgerrit | Elena Ezhova proposed openstack/neutron: Prevent calling waitall() inside a GreenPool's greenthread https://review.openstack.org/157320 | 10:52 |
*** lazy_prince is now known as killer_prince | 10:56 | |
openstackgerrit | Sumit Naiksatam proposed openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo https://review.openstack.org/162099 | 10:57 |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Test https://review.openstack.org/162100 | 10:57 |
*** dims has joined #openstack-neutron | 11:00 | |
*** igordcard has joined #openstack-neutron | 11:04 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Refactor the ProcessMonitor API https://review.openstack.org/154464 | 11:09 |
openstackgerrit | Akihiro Motoki proposed openstack/neutron: NEC plugin code split https://review.openstack.org/162103 | 11:11 |
*** yog__ has quit IRC | 11:12 | |
*** yamamoto has joined #openstack-neutron | 11:20 | |
*** chlong has joined #openstack-neutron | 11:22 | |
*** yamamoto has quit IRC | 11:24 | |
*** markvoelker has joined #openstack-neutron | 11:31 | |
*** markvoelker has quit IRC | 11:36 | |
*** aepifanov has joined #openstack-neutron | 11:39 | |
openstackgerrit | Sumit Naiksatam proposed openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo https://review.openstack.org/162099 | 11:42 |
openstackgerrit | ZongKai LI proposed openstack/neutron: fix router update for LegacyRouter to DvrRouter https://review.openstack.org/162117 | 11:42 |
*** aepifanov has quit IRC | 11:45 | |
*** aepifanov has joined #openstack-neutron | 11:46 | |
*** Bhavya has quit IRC | 11:46 | |
*** tomoe_ has quit IRC | 11:46 | |
*** lizk has quit IRC | 11:49 | |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Fix validation of physical network name for flat nets https://review.openstack.org/160842 | 11:49 |
*** luqas__ has quit IRC | 11:52 | |
*** marrusl has joined #openstack-neutron | 11:55 | |
*** Networkn3rd has joined #openstack-neutron | 11:56 | |
*** yamamoto has joined #openstack-neutron | 11:58 | |
*** pradipta has quit IRC | 11:59 | |
*** Networkn3rd has quit IRC | 12:01 | |
*** pc_m has joined #openstack-neutron | 12:01 | |
*** yushiro has quit IRC | 12:02 | |
*** Marga_ has joined #openstack-neutron | 12:07 | |
openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver https://review.openstack.org/158560 | 12:08 |
openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention https://review.openstack.org/144391 | 12:08 |
*** techcet has joined #openstack-neutron | 12:09 | |
*** alexpilotti has joined #openstack-neutron | 12:13 | |
*** techcet has quit IRC | 12:14 | |
*** yfauser has joined #openstack-neutron | 12:16 | |
*** yfauser has left #openstack-neutron | 12:16 | |
*** baoli has joined #openstack-neutron | 12:16 | |
*** sambetts has quit IRC | 12:17 | |
*** sambetts has joined #openstack-neutron | 12:17 | |
*** johnbelamaric has quit IRC | 12:20 | |
*** johnbelamaric has joined #openstack-neutron | 12:20 | |
*** ZZelle has joined #openstack-neutron | 12:25 | |
*** blues-man has quit IRC | 12:28 | |
*** baoli_ has joined #openstack-neutron | 12:31 | |
openstackgerrit | John Davidge proposed openstack/neutron: Implement Neutron IPv6 Prefix Delegation https://review.openstack.org/158697 | 12:31 |
*** markvoelker has joined #openstack-neutron | 12:32 | |
*** gildub has quit IRC | 12:32 | |
*** baoli has quit IRC | 12:34 | |
*** markvoelker has quit IRC | 12:36 | |
*** setuid has quit IRC | 12:37 | |
*** setuid has joined #openstack-neutron | 12:38 | |
*** aix has quit IRC | 12:38 | |
*** yamamoto has quit IRC | 12:38 | |
*** yamamoto has joined #openstack-neutron | 12:40 | |
*** yamamoto has quit IRC | 12:46 | |
*** raildo_away is now known as raildo | 12:48 | |
*** saikrishna has quit IRC | 12:48 | |
*** banix has joined #openstack-neutron | 12:48 | |
*** saju_m has quit IRC | 12:50 | |
*** yamamoto has joined #openstack-neutron | 12:51 | |
*** banix has quit IRC | 12:56 | |
*** Networkn3rd has joined #openstack-neutron | 12:56 | |
*** Networkn3rd has quit IRC | 13:01 | |
*** markvoelker has joined #openstack-neutron | 13:06 | |
*** humble_ has joined #openstack-neutron | 13:06 | |
*** yamamoto has quit IRC | 13:07 | |
*** amuller has joined #openstack-neutron | 13:14 | |
*** karmatronic has joined #openstack-neutron | 13:14 | |
*** anilvenkata has left #openstack-neutron | 13:16 | |
*** karimb has quit IRC | 13:17 | |
*** techcet has joined #openstack-neutron | 13:25 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook https://review.openstack.org/161714 | 13:26 |
*** dane_leblanc has joined #openstack-neutron | 13:26 | |
*** bobmel has quit IRC | 13:27 | |
*** bobmel has joined #openstack-neutron | 13:27 | |
*** aix has joined #openstack-neutron | 13:30 | |
*** mwagner_lap has joined #openstack-neutron | 13:30 | |
openstackgerrit | Pavel Bondar proposed openstack/neutron: Introduce External IPAM Interface https://review.openstack.org/134339 | 13:37 |
*** banix has joined #openstack-neutron | 13:38 | |
*** moha_hunt has quit IRC | 13:39 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook https://review.openstack.org/161714 | 13:39 |
*** karmatronic has quit IRC | 13:41 | |
*** karimb has joined #openstack-neutron | 13:42 | |
*** dboik has quit IRC | 13:43 | |
*** radez_g0n3 is now known as radez | 13:46 | |
*** SumitNaiksatam has quit IRC | 13:48 | |
*** julim has joined #openstack-neutron | 13:52 | |
*** Marga_ has quit IRC | 13:53 | |
*** yamamoto has joined #openstack-neutron | 13:54 | |
*** setuid has quit IRC | 13:55 | |
*** thomasem has joined #openstack-neutron | 13:57 | |
*** setuid has joined #openstack-neutron | 13:57 | |
*** Marga_ has joined #openstack-neutron | 13:58 | |
*** luqas__ has joined #openstack-neutron | 13:59 | |
*** annegentle has joined #openstack-neutron | 13:59 | |
*** blues-man has joined #openstack-neutron | 14:00 | |
*** blues-man has quit IRC | 14:00 | |
*** blues-man has joined #openstack-neutron | 14:00 | |
*** annegentle has quit IRC | 14:00 | |
*** annegentle has joined #openstack-neutron | 14:01 | |
*** ihrachyshka has joined #openstack-neutron | 14:01 | |
*** thomasem has quit IRC | 14:01 | |
*** jamiec has quit IRC | 14:01 | |
*** jamiec has joined #openstack-neutron | 14:01 | |
*** thomasem has joined #openstack-neutron | 14:01 | |
*** saju_m has joined #openstack-neutron | 14:03 | |
*** Longgeek has quit IRC | 14:05 | |
*** fifieldt_ has quit IRC | 14:05 | |
mestery | ajo: Do you know if kuba had code for this BP: https://blueprints.launchpad.net/neutron/+spec/new-iptables-driver | 14:07 |
*** zz_jgrimm is now known as jgrimm | 14:07 | |
mestery | ajo: There is no code and we're past the FPF now :( | 14:07 |
*** bjornar_ has joined #openstack-neutron | 14:07 | |
*** dboik has joined #openstack-neutron | 14:07 | |
mestery | ajo: I'm going to move this out of Kilo now, but you folks cna propose an exception on the ML for htis if you have code ok? | 14:07 |
*** sc68cal_ has joined #openstack-neutron | 14:07 | |
*** sc68cal_ has quit IRC | 14:07 | |
*** sc68cal_ has joined #openstack-neutron | 14:07 | |
*** dboik has quit IRC | 14:07 | |
*** dboik_ has joined #openstack-neutron | 14:08 | |
*** cference has joined #openstack-neutron | 14:08 | |
*** jamiec has quit IRC | 14:09 | |
*** sc68cal has quit IRC | 14:09 | |
*** jamiec has joined #openstack-neutron | 14:09 | |
*** salv-orl_ has joined #openstack-neutron | 14:09 | |
*** salv-orlando has quit IRC | 14:09 | |
ihrachyshka | mestery, Kuba definitely does not have the code ready | 14:11 |
mestery | ihrachyshka: Ack, moved out of Kilo then :) | 14:12 |
ihrachyshka | mestery, and he is off to New Zealand till end of March | 14:12 |
*** Networkn3rd has joined #openstack-neutron | 14:12 | |
mestery | ihrachyshka: Wow, lucky guy! :) | 14:12 |
*** manishg has joined #openstack-neutron | 14:13 | |
*** shwetaap has joined #openstack-neutron | 14:14 | |
*** mriedem has left #openstack-neutron | 14:16 | |
*** zhenq has joined #openstack-neutron | 14:16 | |
*** shwetaap1 has joined #openstack-neutron | 14:16 | |
*** Networkn3rd has quit IRC | 14:16 | |
mestery | amotoki: Thanks for your help in marking those client bugs as "fix released", I appreciate that. :) | 14:16 |
*** saikrishna has joined #openstack-neutron | 14:17 | |
amotoki | mestery: you made many various jobs :-) | 14:19 |
mestery | amotoki: :) | 14:19 |
*** Marga_ has quit IRC | 14:19 | |
*** shwetaap has quit IRC | 14:20 | |
amotoki | mestery: I got nasty cold from the weekend :-( and in the latter half of the week I needed to spend queued internal items.... | 14:20 |
*** Longgeek has joined #openstack-neutron | 14:20 | |
*** signed8bit has joined #openstack-neutron | 14:21 | |
mestery | amotoki: Get well my friend, colds are never that much fun. | 14:21 |
*** bjornar_ has quit IRC | 14:22 | |
openstackgerrit | Baodong (Robert) Li proposed openstack/neutron: Implement Neutron IPv6 Prefix Delegation https://review.openstack.org/158697 | 14:22 |
amotoki | mestery: I remember I would like to ask you on neutronclient. | 14:23 |
mestery | amotoki: Sure! What about it? | 14:23 |
amotoki | mestery: do we use 2.4.0 or 2.3.12 for the next release? | 14:23 |
*** Murali has joined #openstack-neutron | 14:23 | |
amotoki | I see both milestones are open for targetting bugs. | 14:23 |
mestery | amotoki: I was thinking we'd wait until Kilo is out, then do a 2.4.0. What do you think? | 14:23 |
mestery | If you agree, I'll remove the 2.3.12 milestone | 14:23 |
amotoki | mestery: 2.4.0 sounds good to me too. | 14:24 |
openstackgerrit | Pavel Bondar proposed openstack/neutron: Implement IPAM Driver loader https://review.openstack.org/147479 | 14:24 |
amotoki | mestery: 2.4.0 is for Kilo? | 14:24 |
mestery | amotoki: OK, I'll remove 2.3.12 then. | 14:24 |
mestery | amotoki: I was thinking 2.4.0 for post-kilo, and we don't release another client until kilo ships. Sound ok? | 14:24 |
amotoki | mestery: we have some fixes for new features so I think we need at least one release for kilo. | 14:25 |
*** techcet has joined #openstack-neutron | 14:25 | |
mestery | amotoki: OK, how about if we keep 2.3.12 for the last Kilo release of the client then? We just need to ensure no changes go into that one which are backwards incompatible | 14:26 |
amotoki | mestery: this is the reason I am a bit confused... I assumed we will have another release for kilo. | 14:26 |
mestery | e.g. requirements changes | 14:26 |
mestery | amotoki: Does that make sense? | 14:26 |
amotoki | mestery: makese sense. | 14:26 |
mestery | amotoki: OK, cool. Thanks! | 14:26 |
*** kbringard has joined #openstack-neutron | 14:27 | |
*** SumitNaiksatam has joined #openstack-neutron | 14:28 | |
*** dansmith is now known as superdan | 14:30 | |
*** techcet has quit IRC | 14:30 | |
*** annegentle is now known as superanne | 14:31 | |
*** chlong has quit IRC | 14:34 | |
*** manishg has quit IRC | 14:36 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable pylint on tests subdir https://review.openstack.org/161959 | 14:36 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove 'free' exclusions from pylint https://review.openstack.org/162173 | 14:36 |
*** manishg has joined #openstack-neutron | 14:36 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove 'free' exclusions from pylint https://review.openstack.org/162173 | 14:37 |
*** dims has quit IRC | 14:37 | |
*** saju_m has quit IRC | 14:37 | |
*** banix has quit IRC | 14:37 | |
amuller | mestery: amotoki: HenryG: That last patch (https://review.openstack.org/162173) is a comprehensive list (Only 2, what can we do) of pylint exclusions that don't actually have any violations in the code | 14:38 |
*** dims has joined #openstack-neutron | 14:38 | |
*** banix has joined #openstack-neutron | 14:38 | |
*** tiswanso has joined #openstack-neutron | 14:38 | |
*** manishg has quit IRC | 14:41 | |
*** rushil_ has joined #openstack-neutron | 14:41 | |
*** thomasem_ has joined #openstack-neutron | 14:41 | |
*** ZZelle has quit IRC | 14:43 | |
*** thomasem has quit IRC | 14:44 | |
amotoki | amuller: thanks for such cleanup :-) | 14:44 |
*** TrevorV|Home has joined #openstack-neutron | 14:44 | |
*** alaski is now known as lascii | 14:44 | |
*** lukasa_work has joined #openstack-neutron | 14:44 | |
amuller | amotoki: :) Going through the list of violations now, cleaning up some violations with low counts and removing the exclusions | 14:45 |
*** Networkn3rd has joined #openstack-neutron | 14:46 | |
mestery | amotoki: Nice! | 14:47 |
*** Murali has quit IRC | 14:47 | |
*** lukasa has quit IRC | 14:47 | |
amotoki | not amotoki but amuller :-) | 14:47 |
*** shwetaap1 has quit IRC | 14:48 | |
*** boris-42 has quit IRC | 14:52 | |
*** shwetaap has joined #openstack-neutron | 14:52 | |
*** absubram has joined #openstack-neutron | 14:56 | |
*** amotoki has quit IRC | 14:57 | |
openstackgerrit | Pavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM https://review.openstack.org/153236 | 14:58 |
*** absubram has quit IRC | 14:58 | |
*** absubram has joined #openstack-neutron | 14:59 | |
*** manishg has joined #openstack-neutron | 15:02 | |
*** yfried has quit IRC | 15:04 | |
*** haleyb has quit IRC | 15:05 | |
*** haleyb has joined #openstack-neutron | 15:07 | |
*** dims is now known as dimsum__ | 15:07 | |
*** igordcard has quit IRC | 15:08 | |
*** radez is now known as radez_g0n3 | 15:12 | |
*** jlanoux has quit IRC | 15:14 | |
*** yfauser has joined #openstack-neutron | 15:14 | |
*** yfauser has left #openstack-neutron | 15:15 | |
*** armax has joined #openstack-neutron | 15:15 | |
*** haleyb has quit IRC | 15:18 | |
HenryG | ihrachyshka: ping | 15:19 |
*** changbl has quit IRC | 15:19 | |
ihrachyshka | HenryG, pong | 15:19 |
HenryG | ihrachyshka: functional job in stable branches is still not working, it seems | 15:20 |
ihrachyshka | HenryG, right, infra is on it | 15:20 |
ihrachyshka | HenryG, potentially it's puppet not applied to jenkins | 15:20 |
ihrachyshka | HenryG, they are checking | 15:20 |
*** r-daneel has joined #openstack-neutron | 15:20 | |
*** banix has quit IRC | 15:21 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable pylint on tests subdir https://review.openstack.org/161959 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove non-parent-init-called pylint exclusion https://review.openstack.org/162190 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove access-member-before-definition pylint exclusion https://review.openstack.org/162191 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove no-method-argument pylint exclusion https://review.openstack.org/162192 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove duplicate-key pylint exclusion https://review.openstack.org/162193 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove expression-not-assigned pylint exclusion https://review.openstack.org/162194 | 15:22 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove not-callable pylint exclusion https://review.openstack.org/162195 | 15:22 |
HenryG | ihrachyshka: thanks | 15:22 |
*** yfauser1 has joined #openstack-neutron | 15:23 | |
*** yfauser1 has left #openstack-neutron | 15:23 | |
*** marun has joined #openstack-neutron | 15:24 | |
armax | ihrachyshka: ping | 15:24 |
ihrachyshka | armax, hi! | 15:25 |
armax | looking at the functional job change | 15:25 |
armax | ihrachyshka: I think that’s wrong | 15:25 |
armax | ihrachyshka: now taht I look at it again | 15:25 |
armax | https://review.openstack.org/#/c/161569/2/jenkins/jobs/neutron.yaml | 15:25 |
armax | ihrachyshka: it’s so painful to not being able to test before we roll out | 15:26 |
*** doude has quit IRC | 15:27 | |
*** jlanoux has joined #openstack-neutron | 15:28 | |
*** numan has quit IRC | 15:28 | |
ihrachyshka | armax, ok, then it's just a matter of puppet not applied, I hope | 15:28 |
armax | ihrachyshka: I don’t think so actually | 15:28 |
*** techcet has joined #openstack-neutron | 15:29 | |
*** changbl has joined #openstack-neutron | 15:32 | |
*** tiswanso has quit IRC | 15:33 | |
*** radez_g0n3 is now known as radez | 15:34 | |
*** yamamoto has quit IRC | 15:34 | |
*** techcet has quit IRC | 15:34 | |
*** yamamoto has joined #openstack-neutron | 15:34 | |
*** tiswanso_ has joined #openstack-neutron | 15:34 | |
*** absubram has quit IRC | 15:35 | |
*** tiswanso_ has quit IRC | 15:36 | |
ihrachyshka | salv-orl_, may I ask you to look at comments at: https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py ? | 15:37 |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Use accessors instead of private attributes for Ml2 plugin https://review.openstack.org/162100 | 15:39 |
*** lukasa_work has quit IRC | 15:40 | |
*** lukasa_work has joined #openstack-neutron | 15:41 | |
*** ChuckC_ has joined #openstack-neutron | 15:41 | |
*** ChuckC has quit IRC | 15:42 | |
*** tiswanso has joined #openstack-neutron | 15:43 | |
*** zhhuabj has quit IRC | 15:43 | |
*** zhhuabj has joined #openstack-neutron | 15:44 | |
*** trinaths has joined #openstack-neutron | 15:45 | |
*** trinaths1 has joined #openstack-neutron | 15:45 | |
*** ChuckC_ has quit IRC | 15:46 | |
*** manishg has quit IRC | 15:47 | |
*** vishwana_ has quit IRC | 15:47 | |
*** carlp has joined #openstack-neutron | 15:48 | |
*** xgerman has joined #openstack-neutron | 15:49 | |
*** SridharG has left #openstack-neutron | 15:49 | |
*** trinaths has quit IRC | 15:49 | |
openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 15:51 |
*** lukasa_work has quit IRC | 15:52 | |
*** lukasa has joined #openstack-neutron | 15:53 | |
*** ronis has quit IRC | 15:53 | |
*** lazy_prif has joined #openstack-neutron | 15:58 | |
*** lazy_prif is now known as lazy_prince | 15:58 | |
*** killer_prince has quit IRC | 15:58 | |
*** superanne has quit IRC | 15:59 | |
*** superanne has joined #openstack-neutron | 16:00 | |
*** Miouge has joined #openstack-neutron | 16:02 | |
openstackgerrit | Zengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API https://review.openstack.org/159618 | 16:03 |
*** humble_ has quit IRC | 16:03 | |
dboik_ | ihrachyshka: I just responded to your comment on https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py. I think your suggestion makes sense, and I'll upload a new patch soon. | 16:04 |
ihrachyshka | dboik_, I hope it does! I wanted salv-orl_ to take a look since he introduced the quirk mentioned in the comment in the first place. | 16:05 |
openstackgerrit | Mark Rawlings proposed openstack/python-neutronclient: Reinstate Max URI length checking to V2_0 Client https://review.openstack.org/160923 | 16:06 |
*** imcsk8 has quit IRC | 16:07 | |
*** imcsk8 has joined #openstack-neutron | 16:07 | |
dboik_ | ihrachyshka: Yes, that would be great. Want to make sure there aren't any other subtle bugs introduced, but this seems like it will work. | 16:07 |
*** superanne has quit IRC | 16:07 | |
*** superanne has joined #openstack-neutron | 16:08 | |
*** carl_baldwin has joined #openstack-neutron | 16:08 | |
salv-orl_ | ihrachyshka: what did I break today? | 16:08 |
*** tyjawe has joined #openstack-neutron | 16:08 | |
ihrachyshka | salv-orl_, no way! | 16:08 |
ihrachyshka | salv-orl_, just trying to get your valuable comments on https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py direction | 16:09 |
*** haleyb has joined #openstack-neutron | 16:10 | |
salv-orl_ | ihrachyshka: I've just commented. Up to you to decide whether they're valuable or not | 16:11 |
*** flaviof has quit IRC | 16:11 | |
*** vishwanathj has joined #openstack-neutron | 16:11 | |
*** flaviof has joined #openstack-neutron | 16:12 | |
*** ChuckC_ has joined #openstack-neutron | 16:12 | |
*** jaypipes has joined #openstack-neutron | 16:14 | |
*** jaypipes is now known as leakypipes | 16:14 | |
*** techcet has joined #openstack-neutron | 16:15 | |
*** moha_hunt has joined #openstack-neutron | 16:15 | |
ihrachyshka | salv-orl_, to clarify: "having AUTO_DELETE_PORT_OWNERS as a dict". It's not clear how would dict apply there? | 16:17 |
*** pask81 has quit IRC | 16:18 | |
*** bquan has joined #openstack-neutron | 16:19 | |
dboik_ | salv-orl_, ihrachyshka: Thanks for taking a look. Actually, regarding the AUTO_DELETE_PORT_OWNERS, I was just going to do a filter(~_in(constants.ROUTER_INTERFACE_OWNERS)) on the query to check for all ports except router interfaces. | 16:19 |
*** techcet has quit IRC | 16:20 | |
ihrachyshka | dboik_, actually, leaving refactoring for a separate patch is probably a good thing | 16:21 |
ihrachyshka | dboik_, that's since we may want to backport the fix | 16:22 |
salv-orl_ | ihrachyshka: a dict with different values according to the subnet addressing mode. I'm not sure if it's feasbile, just an idea | 16:23 |
*** krtaylor has quit IRC | 16:23 | |
ihrachyshka | dboik_, I'm looking thru the patch again to make sure no issues are there | 16:23 |
ihrachyshka | salv-orl_, got it | 16:24 |
anteaya | HenryG: okay I'm looking at that patch | 16:24 |
*** dprince has joined #openstack-neutron | 16:24 | |
anteaya | HenryG: help me out here by telling me what fixed looks like | 16:24 |
anteaya | fix this job could mean anything to me | 16:24 |
anteaya | you want it to run on stable branches? | 16:24 |
*** shivharis has joined #openstack-neutron | 16:24 | |
anteaya | you don't want it to run on stable branches? | 16:24 |
anteaya | fixed can be anything | 16:24 |
dprince | Hello all. Could I get some eyes on this: https://review.openstack.org/#/c/141044/ | 16:25 |
anteaya | HenryG: https://review.openstack.org/#/c/161569/ | 16:25 |
anteaya | hey dprince | 16:25 |
dprince | ^^ that regression has been up for 2 weeks and breaks all of our TripleO CI jobs using Ironic | 16:25 |
*** aepifanov has quit IRC | 16:25 | |
*** scheuran_ has quit IRC | 16:25 | |
dprince | note that we've been cherry picking the revert to keep things working for over a week now... | 16:26 |
*** banix has joined #openstack-neutron | 16:27 | |
dprince | anteaya: hi :) | 16:27 |
*** garyk has quit IRC | 16:28 | |
HenryG | anteaya: Hi, thanks for getting back to me. | 16:28 |
anteaya | HenryG: so where do we stand? | 16:28 |
dprince | ihrachyshka: ^^^ might you have a look at that? | 16:28 |
anteaya | for me to march along beside you I really need to know what the name of the mountain is we are trying to scale together | 16:28 |
ihrachyshka | dprince, there was a bug for revert, right? | 16:28 |
*** aleksandr_null has quit IRC | 16:29 | |
dprince | ihrachyshka: yes, here https://bugs.launchpad.net/tripleo/+bug/1421835 | 16:29 |
openstack | Launchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [High,In progress] | 16:29 |
HenryG | anteaya: clarkb and others are already on it, here is the latest: https://review.openstack.org/162199 | 16:29 |
anteaya | wonderful, I hadn't gotten that far in the logs yet | 16:30 |
anteaya | and having some content in the commit message body about _why_ you are doing this would be helpful | 16:30 |
anteaya | HenryG: but if you want to try this setting, fine with me as neutron is the only project affected by this | 16:31 |
*** aleksandr_null has joined #openstack-neutron | 16:32 | |
*** ParsectiX has joined #openstack-neutron | 16:32 | |
*** amotoki has joined #openstack-neutron | 16:33 | |
*** sripriya has joined #openstack-neutron | 16:33 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: Basic subnetpool CRUD https://review.openstack.org/148698 | 16:33 |
*** chlong has joined #openstack-neutron | 16:33 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 16:33 |
*** krtaylor has joined #openstack-neutron | 16:35 | |
*** techcet has joined #openstack-neutron | 16:37 | |
ihrachyshka | dprince, trying to understand how it could influence dhcp... is there something special that I need to know about neutron ports in tripleO? do they use some special states that are different from usual usage? | 16:40 |
dprince | ihrachyshka: let me get more info... just digging into it today but it appears to be required to make things work | 16:41 |
*** criptoverso1 has quit IRC | 16:41 | |
*** wverdugo500 has joined #openstack-neutron | 16:41 | |
*** wverdugo500 has left #openstack-neutron | 16:42 | |
*** busterswt has joined #openstack-neutron | 16:43 | |
*** nlahouti has joined #openstack-neutron | 16:43 | |
*** _cjones_ has joined #openstack-neutron | 16:43 | |
*** _cjones_ has quit IRC | 16:43 | |
*** _cjones_ has joined #openstack-neutron | 16:44 | |
*** sthillma has joined #openstack-neutron | 16:44 | |
*** sthillma has quit IRC | 16:47 | |
ihrachyshka | dprince, aha, I think I see the issue, but I need your help to get complete picture. so as I see, regression is because if dhcp options were updated, and _bind_port_if_needed is called with need_notify=True, we may now miss the notification if port fails to bind | 16:47 |
ihrachyshka | dprince, the question is: were those ports supposed to fail to bind? | 16:47 |
*** devvesa has quit IRC | 16:48 | |
*** sthillma has joined #openstack-neutron | 16:48 | |
*** Marga_ has joined #openstack-neutron | 16:49 | |
ihrachyshka | dprince, do we have logs from tripleO failures? | 16:50 |
*** yfauser has joined #openstack-neutron | 16:50 | |
ChuckC_ | ihrachyshka: I know that vif_type is always BINDING_FAILED for ironic server ports, if that's relevant | 16:51 |
*** kawa2014 has quit IRC | 16:51 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Allow tools/coding-checks.sh to run flake8 on specific commits https://review.openstack.org/162221 | 16:52 |
salv-orl_ | ihrachyshka: rgith the logs would quickly tells us if we're hitting "Failed to commit binding results for". | 16:52 |
*** yamahata has joined #openstack-neutron | 16:52 | |
ihrachyshka | ChuckC_, that's very relevant | 16:53 |
*** boris-42 has joined #openstack-neutron | 16:53 | |
ihrachyshka | ChuckC_, oh well, it's ironic, not tripleO | 16:53 |
ihrachyshka | is it the same thing there? | 16:53 |
shivharis | mestery: hi, ready to bother you again | 16:53 |
*** yfauser has left #openstack-neutron | 16:54 | |
salv-orl_ | ihrachyshka: well, if the overcloud is bare metal | 16:54 |
ChuckC_ | ihrachyshka: probably, but hopefully dprince can verify | 16:54 |
salv-orl_ | it might be that's been relying so far on the binding to be in failed status to work crrectly | 16:55 |
*** sambetts has quit IRC | 16:55 | |
ChuckC_ | salv-orl_: I suspect not, but maybe I'm just hopeful | 16:56 |
ihrachyshka | yamamoto, ping. is https://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ofagent/agent/ofa_neutron_agent.py left from oversight? | 16:57 |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Test the shiny new WeightScheduler https://review.openstack.org/162231 | 16:57 |
*** sambetts has joined #openstack-neutron | 16:57 | |
salv-orl_ | ChuckC_: better not take anything for granted! | 16:57 |
ChuckC_ | salv-orl_: sure :) | 16:57 |
*** Miouge has quit IRC | 16:58 | |
yamamoto | ihrachyshka: it seems so. probably due to merge botches. thank you. | 16:59 |
*** tyjawe has quit IRC | 16:59 | |
*** techcet has quit IRC | 16:59 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: ofagent: kill the left over after decomposition https://review.openstack.org/162234 | 16:59 |
ihrachyshka | yamamoto, ^^ | 16:59 |
*** shivharis has quit IRC | 17:00 | |
*** changbl has quit IRC | 17:00 | |
yamamoto | ihrachyshka: thank you | 17:01 |
*** techcet has joined #openstack-neutron | 17:01 | |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: DHCP Service LoadBalancing Scheduler https://review.openstack.org/137017 | 17:02 |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Test the shiny new WeightScheduler https://review.openstack.org/162231 | 17:02 |
amuller | marun: Morning | 17:03 |
marun | amuller: morning | 17:04 |
amuller | marun: I'm trying to kill run_tests.sh. I moved run_tests.sh -8 like functionality to coding-checks.sh (https://review.openstack.org/#/c/162221/) | 17:04 |
amuller | question is if post-mortem debugging can be accomplished with tox | 17:05 |
amuller | or another non-run_tests.sh method | 17:05 |
*** jlanoux has quit IRC | 17:05 | |
marun | amuller: I do my pm debugging in emacs, so I'm probably not the right person to ask | 17:05 |
yamamoto | who can change bp status? | 17:05 |
marun | amuller: funny how much bash work we're doing... and here I thought this was a python project! | 17:06 |
marun | (or ash, for those who care more than I do) | 17:06 |
amuller | marun: Yeah and I'm the worst with Bash, fun | 17:06 |
marun | amuller: shame that it's so pervasive | 17:07 |
marun | amuller: like javascript of userspace | 17:07 |
marun | amuller: or is javascript the shell of the browser? | 17:07 |
amuller | wow if someone shows me an app written with a combination of javascript and bash I'd throw up | 17:08 |
marun | amuller: I worry that we're just going to end up rewriting run_tests.sh into a bunch of smaller helpers :/ | 17:08 |
*** superanne has quit IRC | 17:08 | |
marun | amuller: probably doesn't make much sense given that js doesn't have a concept of an fs | 17:08 |
amuller | afaik the only useful thing that remains in run_tests.sh is the -8 thing, and possibly post mortem debugging which I'm figuing out now if it can be done otherwise | 17:09 |
*** sthillma has quit IRC | 17:09 | |
*** b3nt_pin has quit IRC | 17:09 | |
marun | amuller: I wish that were true, but everytime we try to kill it we get pushback | 17:09 |
amuller | and it looks like it is | 17:09 |
amuller | last time those were the only two usages that popped up | 17:09 |
marun | amuller: I mean, I'm supportive of what you're trying to do. | 17:09 |
marun | amuller: really? | 17:09 |
amuller | dougwig: ^ | 17:09 |
amuller | yep | 17:09 |
amuller | Doug was the last one to try :) | 17:09 |
marun | amuller: so the cost of maintaining venvs wasn't an issue anymore? | 17:10 |
amuller | I didn't see complaints about that | 17:10 |
ChuckC_ | yamamoto: if code has not been released yet, perhaps changing implementation would work, assuming you want to change status from complete to perhaps started? | 17:10 |
marun | amuller: that was a pretty longstanding complaint - that running tests with tox with its sdist cost took too long | 17:10 |
amuller | Let me wipe a tear off my cheek | 17:10 |
amuller | common | 17:11 |
marun | amuller: my dev env consists of neutron installed editable along with its test dependencies via pip install --user | 17:11 |
marun | amuller: I'm not sure why anyone would develop with tox, frankly. it's a before-push check for me | 17:12 |
yamamoto | ChuckC_: this bp is done now https://blueprints.launchpad.net/neutron/+spec/ofagent-flow-based-tunneling | 17:12 |
*** rotbeard has quit IRC | 17:12 | |
ChuckC_ | yamamoto: did it go out in kilo-2 or earlier? | 17:12 |
yamamoto | ChuckC_: last change has been merged today | 17:13 |
ChuckC_ | yamamoto: just change implementation to 'in progress', i think | 17:13 |
ChuckC_ | yamamoto: are you able to? | 17:14 |
yamamoto | ChuckC_: i made it implemented | 17:14 |
dprince | ihrachyshka: getting fresh logs now...https://review.openstack.org/#/c/162212/ | 17:14 |
dprince | ihrachyshka: and yes, this is TripleO (which uses Ironic for baremetal provisioning) | 17:15 |
*** ronis has joined #openstack-neutron | 17:15 | |
ihrachyshka | dprince, are overcloud ironic? | 17:15 |
* ihrachyshka thinks those who chose the names are geniuses | 17:15 | |
dprince | ihrachyshka: no, only the undercloud | 17:15 |
ChuckC_ | yamamoto: what are you trying to accomplish? | 17:15 |
dprince | ihrachyshka: undercloud uses Ironic for baremetal provisioning. And only it gets broken by this issues | 17:16 |
ihrachyshka | dprince, hm, but ports that fail belong to undercloud then? | 17:16 |
dprince | ihrachyshka: correct. | 17:16 |
ihrachyshka | PXE probably means it's for ports that bootstrap overcloud | 17:16 |
dougwig | amuller, marun - fyi, the feedback when I tried to kill it last year. | 17:16 |
ihrachyshka | ok, then it makes a lot of sense | 17:16 |
dprince | ihrachyshka: undercloud deploys the overcloud | 17:16 |
yamamoto | ChuckC_: i wanted to notify the appropriate party the bp is done | 17:17 |
amuller | dougwig: https://review.openstack.org/#/c/140139/? | 17:17 |
*** safchain has quit IRC | 17:17 | |
ChuckC_ | yamamoto: oh, ok that's it then :) | 17:17 |
ihrachyshka | dprince, I will check in next half an hour whether I can come up with a fix that is not a revert. will you be able to test it somehow in your env? | 17:19 |
*** changbl has joined #openstack-neutron | 17:20 | |
dprince | ihrachyshka: yes, but I'd have to do it manually | 17:21 |
dprince | ihrachyshka: I'm fine w/ a roll forward fix, but in general I really hate to see a revert like this sit around (for almost to weeks in this case) | 17:21 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Migrate to oslo.log https://review.openstack.org/159638 | 17:22 |
openstackgerrit | Merged openstack/neutron: Remove references to 0.0.0.0/0 in iptable rules https://review.openstack.org/161214 | 17:22 |
dprince | ihrachyshka: reverts are very safe... | 17:22 |
anteaya | armax: smart guy | 17:22 |
*** armax has quit IRC | 17:22 | |
dprince | ihrachyshka: sometimes with roll forward fixes there can be other side effects | 17:22 |
*** ajo has quit IRC | 17:22 | |
ihrachyshka | dprince, I'm fine with revert either way, though I wouldn't help you in any case since I don't have +2 hammer, yet :) | 17:22 |
*** sripriya has quit IRC | 17:23 | |
dprince | ihrachyshka: understood, and appreciate the help | 17:23 |
*** manishg has joined #openstack-neutron | 17:23 | |
ihrachyshka | salv-orl_, HenryG: can we merge revert of a patch that breaks tripleo: https://review.openstack.org/#/c/156853/2 ? I think I know how to fix it properly, but it's better to revert to unblock their team first | 17:23 |
*** shwetaap has quit IRC | 17:25 | |
*** shwetaap has joined #openstack-neutron | 17:25 | |
*** matrohon has quit IRC | 17:27 | |
HenryG | ihrachyshka: looking | 17:27 |
salv-orl_ | I love reverting stuff | 17:28 |
ihrachyshka | HenryG, so the problem is that ironic (that runs undercloud) uses BINDING_FAILED ports. And we miss notification to dhcp agent about dhcp options update due to the patch that is reverted | 17:28 |
ihrachyshka | the fix would be to notify if need_notify==True even if binding attempt failed | 17:29 |
*** Marga_ has quit IRC | 17:29 | |
*** luqas__ has quit IRC | 17:29 | |
salv-orl_ | ihrachyshka: I am on board with the plan the original bug fixed by the patch being reverted does not seem critical. Do we have logs or anything else proving the revert is actually successfull? This would be good to have to justify the action wrt the rest of the community | 17:30 |
*** mlavalle has joined #openstack-neutron | 17:30 | |
*** igordcard has joined #openstack-neutron | 17:30 | |
ihrachyshka | salv-orl_, tripleo failing without revert of the patch in their CI not enough? | 17:31 |
*** blues-man has quit IRC | 17:31 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Updated from global requirements https://review.openstack.org/162248 | 17:32 |
*** rwsu-afk is now known as rwsu | 17:33 | |
*** claudiub has joined #openstack-neutron | 17:34 | |
*** arif-ali has quit IRC | 17:34 | |
salv-orl_ | ihrachyshka: tripleo does not gate with neutorn, I wanted a link to a job run or something lke that. but people can look at the bug report | 17:34 |
salv-orl_ | if people are lazy it's not our problem, I gues | 17:34 |
*** vivek-ebay has joined #openstack-neutron | 17:35 | |
salv-orl_ | ihrachyshka, dprince: one last question... as the offending patch merged on feb13th, has tripleo gate been broken for 3 weeks? | 17:36 |
ihrachyshka | salv-orl_, they carried a revert with their CI | 17:36 |
*** jistr has quit IRC | 17:37 | |
salv-orl_ | ihrachyshka: got it | 17:37 |
dprince | salv-orl_: http://git.openstack.org/cgit/openstack-infra/tripleo-ci/commit/?id=f90760f425ec6c80da12ebee4922d799824f4440 | 17:38 |
dprince | salv-orl_: yes, we've had a rough go of it the last few weeks. When I took a closer look yesterday I was a bit surprised this on hadn't landed | 17:38 |
*** ivar-lazzaro has joined #openstack-neutron | 17:40 | |
salv-orl_ | dprince: It has been brougth to my attention today only. We'll sort it out in the next few hours. | 17:40 |
*** armax has joined #openstack-neutron | 17:40 | |
*** rkukura has joined #openstack-neutron | 17:41 | |
dprince | salv-orl_: appreciate it. FWIW I think it was mentioned on IRC but nobody was probably directly ping'ed so it just slipped through the cracks... | 17:41 |
salv-orl_ | ihrachyshka: I am about to go afk now. I've chatted with armax (who's not online), and asked him to have a final look - he should be able to do that soon. | 17:41 |
*** ivar-lazzaro has quit IRC | 17:41 | |
armax | salv-orl_: I decided to pull over to look at this :) | 17:41 |
ihrachyshka | dprince, I feel guilty, for I knew about the issue several days ago | 17:42 |
*** ivar-lazzaro has joined #openstack-neutron | 17:42 | |
salv-orl_ | armax: your dedication to work is impressive. | 17:42 |
*** ivar-lazzaro has quit IRC | 17:42 | |
salv-orl_ | pretty sure your last name actually is Stakanov | 17:42 |
*** ivar-lazzaro has joined #openstack-neutron | 17:43 | |
*** david-lyle_afk is now known as david-lyle | 17:43 | |
*** jprovazn has joined #openstack-neutron | 17:44 | |
ihrachyshka | salv-orl_, the last time I checked, Stakhanov's achievements were considered overrated ;) | 17:44 |
*** armax has quit IRC | 17:45 | |
salv-orl_ | ihrachyshka: I have not checked in a while I am afraid. | 17:46 |
*** tflynn has joined #openstack-neutron | 17:48 | |
*** leenheer has joined #openstack-neutron | 17:48 | |
*** claudiub has quit IRC | 17:48 | |
*** igordcard has quit IRC | 17:49 | |
*** afazekas has quit IRC | 17:49 | |
openstackgerrit | Maru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest https://review.openstack.org/158021 | 17:51 |
*** bquan_ has joined #openstack-neutron | 17:53 | |
*** bquan_ has quit IRC | 17:53 | |
*** bquan_ has joined #openstack-neutron | 17:53 | |
*** bquan has quit IRC | 17:53 | |
*** jpena has quit IRC | 17:55 | |
openstackgerrit | Maru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest https://review.openstack.org/158021 | 17:56 |
*** sripriya has joined #openstack-neutron | 17:56 | |
openstackgerrit | Maru Newby proposed openstack/neutron: Initial copy of api tests from tempest https://review.openstack.org/162257 | 17:57 |
marun | salv-orl_: hi | 17:58 |
marun | salv-orl_: hopefully I've answered your questions re ^^ | 17:58 |
marun | salv-orl_: I'd like to get this merged asap as the first step towards removal of the tests from tempest: https://wiki.openstack.org/wiki/QA/Tempest-test-removal | 17:58 |
marun | salv-orl_: I think there is a need for increased visibility around this effort, as per your and dkranz's comments on the review. I plan on working with armax on this early next week. | 18:00 |
ihrachyshka | dprince, ok, I think I have a patch. do you want me to send it separately, or on top of revert? | 18:01 |
dprince | ihrachyshka: I'd post it separately I think | 18:01 |
ihrachyshka | dprince, ok, sure. | 18:02 |
*** sbfox has joined #openstack-neutron | 18:02 | |
*** banix has quit IRC | 18:02 | |
marun | amuller: wtf is up with this change? | 18:03 |
marun | https://review.openstack.org/#/c/161959/3/neutron/tests/unit/agent/linux/test_async_process.py | 18:03 |
marun | or this? https://review.openstack.org/#/c/161959/3/neutron/tests/unit/bigswitch/fake_server.py | 18:03 |
*** superanne has joined #openstack-neutron | 18:04 | |
*** techcet has quit IRC | 18:05 | |
*** igordcard has joined #openstack-neutron | 18:06 | |
*** techcet has joined #openstack-neutron | 18:06 | |
*** yamahata has quit IRC | 18:07 | |
*** banix has joined #openstack-neutron | 18:07 | |
openstackgerrit | Sandhya Dasu proposed openstack/neutron: Cisco UCS Manager ML2 Mechanism Driver https://review.openstack.org/155436 | 18:07 |
*** spandhe has joined #openstack-neutron | 18:08 | |
*** karimb has quit IRC | 18:08 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: ml2: don't miss notification if binding attempt failed https://review.openstack.org/162260 | 18:08 |
*** yamamoto has quit IRC | 18:09 | |
*** SumitNaiksatam has quit IRC | 18:09 | |
*** techcet has quit IRC | 18:10 | |
*** techcet has joined #openstack-neutron | 18:11 | |
*** mlavalle has quit IRC | 18:11 | |
*** mlavalle has joined #openstack-neutron | 18:12 | |
openstackgerrit | Brian Haley proposed openstack/neutron: Change linux/ip_lib code to better handle address families https://review.openstack.org/157555 | 18:12 |
marun | amuller: I wish you had lumped your trivial pylint fixes together | 18:12 |
marun | amuller: the crunch is coming and I think we all need to conserve ci resources as much as possible | 18:13 |
*** ChrisNBlum has joined #openstack-neutron | 18:14 | |
pc_m | carl_baldwin: I updated https://review.openstack.org/#/c/160179/, can you take a look at the new PS? | 18:14 |
ihrachyshka | salv-orl_, dprince: https://review.openstack.org/#/c/162260/1 | 18:14 |
ihrachyshka | marun, may I ask you for +A at https://review.openstack.org/#/c/159654/4 so that I can rebase conflicting oslo.log patch that depends on it? | 18:15 |
* ihrachyshka does not want to loose +2s | 18:16 | |
*** ygbo has quit IRC | 18:16 | |
*** setuid has quit IRC | 18:16 | |
marun | ihrachyshka: can do | 18:16 |
*** mlavalle has quit IRC | 18:16 | |
*** mlavalle has joined #openstack-neutron | 18:17 | |
*** setuid has joined #openstack-neutron | 18:17 | |
marun | ihrachyshka: done | 18:17 |
ihrachyshka | awesome, thanks | 18:17 |
*** igordcard has quit IRC | 18:18 | |
*** morganfainberg is now known as needscoffeebadly | 18:19 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook https://review.openstack.org/161714 | 18:21 |
*** needscoffeebadly is now known as CaptainMorgan | 18:22 | |
*** achanda has joined #openstack-neutron | 18:23 | |
*** armax has joined #openstack-neutron | 18:23 | |
amuller | marun: about https://review.openstack.org/#/c/161959/3/neutron/tests/unit/agent/linux/test_async_process.py | 18:23 |
amuller | there's a list of blacklisted names in pylint | 18:23 |
amuller | foo is one of them | 18:23 |
*** Marga_ has joined #openstack-neutron | 18:23 | |
amuller | I think that generally speaking banning something like foo is not a terrible idea for readability | 18:23 |
amuller | about https://review.openstack.org/#/c/161959/3/neutron/tests/unit/bigswitch/fake_server.py - get_cert_contents is defined as a function that doesn't return anything, it just raises an exception (Think notimplemented), and is then mocked in testing | 18:24 |
amuller | the mocking business confuses pylint | 18:25 |
*** jp_at_hp has quit IRC | 18:25 | |
*** sbfox has quit IRC | 18:26 | |
*** superanne has quit IRC | 18:27 | |
*** salv-orl_ has quit IRC | 18:28 | |
*** coolsvap has joined #openstack-neutron | 18:29 | |
*** haleyb has quit IRC | 18:30 | |
*** yamahata has joined #openstack-neutron | 18:31 | |
enikanorov_ | kevinbenton: ping | 18:31 |
*** SridharRamaswamy has joined #openstack-neutron | 18:34 | |
openstackgerrit | Chuck Carlino proposed openstack/neutron: Make updating port mac_address configurable https://review.openstack.org/159228 | 18:35 |
trinaths1 | hi, can someone give a look into this, https://review.openstack.org/160702 ,its an update to contribute.rst , it dont take more time. | 18:36 |
*** markvoelker has quit IRC | 18:39 | |
*** aepifanov has joined #openstack-neutron | 18:39 | |
*** markvoelker has joined #openstack-neutron | 18:40 | |
*** jprovazn has quit IRC | 18:43 | |
*** haleyb has joined #openstack-neutron | 18:43 | |
*** zhenq has quit IRC | 18:44 | |
*** markvoelker has quit IRC | 18:44 | |
*** tflynn_ has joined #openstack-neutron | 18:49 | |
*** arif-ali has joined #openstack-neutron | 18:50 | |
*** sthillma has joined #openstack-neutron | 18:51 | |
*** achanda has quit IRC | 18:52 | |
*** tflynn has quit IRC | 18:52 | |
*** absubram has joined #openstack-neutron | 18:52 | |
armax | ihrachyshka: ping | 18:52 |
*** ivar-lazzaro has quit IRC | 18:52 | |
ihrachyshka | armax, pong | 18:53 |
armax | ihrachyshka re: https://review.openstack.org/#/c/162260/ | 18:53 |
*** tflynn_ has quit IRC | 18:53 | |
*** rkukura has quit IRC | 18:53 | |
armax | ihrachyshka: you reckon it would be better to revert and issue a cleaner fix for bug ##1399249 | 18:54 |
armax | ? | 18:54 |
*** sthillma_ has joined #openstack-neutron | 18:54 | |
ihrachyshka | armax, I think yes, in that way we get more time for reviewers to look into my patch | 18:54 |
armax | ihrachyshka: ok | 18:54 |
ihrachyshka | armax, I sent it separately because dprince asked me to do it this way | 18:54 |
ihrachyshka | I'm ok squashing later if revert goes in | 18:55 |
ihrachyshka | also, it's easier to review it separately for now :) | 18:55 |
*** gridinv has joined #openstack-neutron | 18:55 | |
armax | ihrachyshka: cool, you’re taking care of this? | 18:55 |
*** sthillma has quit IRC | 18:55 | |
ihrachyshka | armax, I will definitely monitor the revert | 18:55 |
*** gongysh has quit IRC | 18:55 | |
HenryG | armax: I am siding with ihrachyshka to do a revert for now | 18:56 |
* ihrachyshka understands that he should go and actually vote for revert | 18:56 | |
*** gongysh_ has quit IRC | 18:56 | |
armax | HenryG: ya | 18:56 |
armax | HenryG, ihrachyshka: ok, so long as we have a plan to re-fix #1399249 then we’re good with the revert | 18:57 |
*** achanda has joined #openstack-neutron | 18:57 | |
armax | dprince: I wonder if you’ve given some thoughts into having tripleO in the check pipeline for Neutron, was it ever discussed? | 18:57 |
armax | dprince: or is it just a bad idea? | 18:57 |
armax | HenryG: for your joy then: https://review.openstack.org/#/c/156853/ | 18:58 |
HenryG | armax: already done | 18:58 |
armax | HenryG: kwel | 18:58 |
*** tflynn has joined #openstack-neutron | 18:59 | |
*** arif-ali has quit IRC | 18:59 | |
ChuckC_ | armax: HenryG: wondering if you might have time for a couple of small reviews related to mac address update: https://review.openstack.org/#/c/151804 and https://review.openstack.org/#/c/159228 | 18:59 |
*** ivar-lazzaro has joined #openstack-neutron | 19:00 | |
*** arif-ali has joined #openstack-neutron | 19:00 | |
*** igordcard has joined #openstack-neutron | 19:00 | |
ChuckC_ | since you both were at least somewhat involved with the spec and main code review :) | 19:01 |
dprince | ihrachyshka: I sent an email to the list about CI testing the fix | 19:01 |
ChuckC_ | armax: HenryG: 151804 depends on 159228, so the latter is a bit more urgent | 19:02 |
dprince | ihrachyshka: but after I just sent it I had a simpler idea. I could just swap in your patch instead as a cherry pick | 19:02 |
dprince | ihrachyshka: let me do that and we'll at least see if it works | 19:02 |
armax | ChuckC_: to me change 159228 is borderline -2 | 19:02 |
*** SridharRamaswam1 has joined #openstack-neutron | 19:02 | |
armax | ChuckC_: I reviewed it moments ago | 19:02 |
* ChuckC_ lookin | 19:02 | |
*** markvoelker has joined #openstack-neutron | 19:03 | |
ihrachyshka | dprince, that would be awesome to see your CI report before merging my patch | 19:03 |
*** sripriya has quit IRC | 19:03 | |
*** SridharRamaswamy has quit IRC | 19:03 | |
*** sripriya has joined #openstack-neutron | 19:04 | |
dprince | ihrachyshka: well, that is the goal. I outline one way in the email. Lets see if your cherry pick works. | 19:04 |
*** superanne has joined #openstack-neutron | 19:04 | |
dprince | ihrachyshka: I've still got a slight preference for reverting | 19:04 |
dprince | ihrachyshka: but if your patch works then great too, lets go with it | 19:04 |
ihrachyshka | dprince, we're ok with revert, it's already +A | 19:04 |
ihrachyshka | dprince, it's just that we want to break you later with my fix :) | 19:05 |
ihrachyshka | *we DON'T | 19:05 |
ihrachyshka | how ironic | 19:05 |
dprince | ihrachyshka: ah, cool. well then, once that lands I think a simple 'check experimental' would get you a tripleO ci result | 19:05 |
ChuckC_ | armax: I don't really like the approach myself, but did not find the tempest support you refer to in your comments | 19:05 |
ihrachyshka | dprince, ok, will do then | 19:05 |
*** rkukura has joined #openstack-neutron | 19:06 | |
ihrachyshka | dprince, that's after you remove the workaround? | 19:06 |
armax | ChuckC_: reach out to mtreinish | 19:06 |
dprince | ihrachyshka: correct | 19:06 |
armax | ChuckC_: he should be able to point you in the right direction | 19:06 |
dprince | ihrachyshka: honestly, I think the cherrypick fails gracefully once the patch lands | 19:06 |
ihrachyshka | dprince, ok, I'll sit on the patch for a day before revert is merged, and your workaround is removed | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove access-member-before-definition pylint exclusion https://review.openstack.org/162191 | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable pylint on tests subdir https://review.openstack.org/161959 | 19:06 |
ChuckC_ | armax: perfect, thanks. Do you know what timezone he's in? | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove not-callable pylint exclusion https://review.openstack.org/162195 | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove expression-not-assigned pylint exclusion https://review.openstack.org/162194 | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove duplicate-key pylint exclusion https://review.openstack.org/162193 | 19:06 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Remove no-method-argument pylint exclusion https://review.openstack.org/162192 | 19:06 |
dprince | ihrachyshka: so it should be fine regardless | 19:07 |
ihrachyshka | ack | 19:07 |
dprince | ihrachyshka: sounds good | 19:07 |
armax | ChuckC_: he’s EST, unless he’s travelling the world | 19:07 |
ChuckC_ | :) | 19:07 |
*** melwitt has joined #openstack-neutron | 19:07 | |
*** saikrishna has quit IRC | 19:08 | |
ChuckC_ | armax: also, I'd like to send you a draft of an email to nova/neutron/ironic ML regarding nova's lack of api for detaching/attaching/modifying nics | 19:09 |
*** yamamoto has joined #openstack-neutron | 19:09 | |
armax | ChuckC_: please don’t I am already swamped as it is, I won’t be able to respond you on time :) | 19:09 |
armax | ChuckC_: and I don’t want to be your bottleneck | 19:10 |
ChuckC_ | ok, maybe garyk | 19:10 |
ihrachyshka | eezhova, hey. I think you are one of our policy experts. may I ask you to check https://review.openstack.org/#/c/159862/ ? | 19:10 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable a bunch of pylint checks https://review.openstack.org/162190 | 19:12 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable pylint on tests subdir https://review.openstack.org/161959 | 19:12 |
amuller | marun: squashed the patches | 19:12 |
amuller | I think you're right | 19:12 |
*** yamamoto has quit IRC | 19:14 | |
*** SridharRamaswam1 has quit IRC | 19:14 | |
*** pritesh has joined #openstack-neutron | 19:15 | |
openstackgerrit | Michael Smith proposed openstack/neutron: WIP delay fip namespace cleanup/destroy https://review.openstack.org/151758 | 19:15 |
*** SridharRamaswamy has joined #openstack-neutron | 19:16 | |
*** sripriya has quit IRC | 19:16 | |
*** igordcard has quit IRC | 19:16 | |
*** _cjones_ has quit IRC | 19:18 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Enable a bunch of pylint checks https://review.openstack.org/162190 | 19:20 |
*** shivharis has joined #openstack-neutron | 19:21 | |
mtreinish | ChuckC_: Eastern time :) | 19:23 |
*** superanne has quit IRC | 19:24 | |
ChuckC_ | mtreinish: hi, I'm trying to learn how to have tempest skip a test for something that's not implemented in juno | 19:24 |
*** aix has quit IRC | 19:24 | |
*** ivar-lazzaro has quit IRC | 19:24 | |
mtreinish | ChuckC_: have you seen?: http://docs.openstack.org/developer/tempest/overview.html#branchless-tempest-considerations | 19:25 |
*** coolsvap has quit IRC | 19:25 | |
ChuckC_ | mtreinish: armax objected to adding a config flag for such a minor feature (ability to modify port's mac_address), and I agree | 19:26 |
ChuckC_ | mtreinish: yes, that's what made me believe a config flag was required. What am I missing? | 19:26 |
mtreinish | ChuckC_: do you have a link to the patch? | 19:27 |
shivharis | mestery: hi | 19:27 |
mtreinish | ChuckC_: if it's change the api behvaior you should have a way to signal that to the end user | 19:27 |
mestery | shivharis: yo | 19:27 |
ChuckC_ | the original work was in https://review.openstack.org/#/c/112129 | 19:27 |
ChuckC_ | mtreinish: ^^ | 19:28 |
shivharis | mestery: would like to bother you again, seems the confusion regarding the account is taken care of | 19:28 |
ChuckC_ | mtreinish: what options are there? | 19:28 |
mestery | shivharis: Excellent! :) | 19:28 |
shivharis | mestery: happens when someone leaves | 19:29 |
mestery | shivharis: lol :) | 19:29 |
shivharis | mestery: anyways i need voting permission on "brocade vdx ci" account | 19:29 |
mestery | shivharis: Looking | 19:29 |
*** sbfox has joined #openstack-neutron | 19:29 | |
shivharis | mestery: you may have to remove the one already, and select the same again | 19:29 |
mestery | shivharis: Done, and it even has a correct email address (openstack_gerrit@brocade.com) | 19:30 |
mtreinish | ChuckC_: so that actually goes against the api change guidelines, you're adding something to the api without having an extension or api version to indicate that. (which is why we're having the issue in tempest) | 19:30 |
mtreinish | https://wiki.openstack.org/wiki/APIChangeGuidelines | 19:31 |
shivharis | mestery: cool, i verified already it works!! | 19:31 |
mestery | shivharis: nice! | 19:31 |
shivharis | mestery: thanks | 19:31 |
mtreinish | as an end user I have no idea which version of the api I'm using and whether a put with a new mac address will be allowed or not | 19:31 |
ChuckC_ | mtreinish: ok, so I could bump api version? | 19:31 |
mtreinish | ChuckC_: well neutron doesn't have microversions so I don't think you can. I think this will have to be something marked on the release notes | 19:32 |
mtreinish | mestery: ^^^ | 19:32 |
mtreinish | as for the tempest side the only option is a config flag unfortunately | 19:32 |
mestery | mtreinish: Yes, we have no microversion yet | 19:32 |
*** SumitNaiksatam has joined #openstack-neutron | 19:32 | |
mtreinish | mestery: yeah, so you guys changed your api. I'm not sure how you want to handle that | 19:33 |
mestery | mtreinish: This is for the "allow mac address of ap ort to change" right? /cc ChuckC_ | 19:33 |
mtreinish | yeah | 19:33 |
ChuckC_ | mtreinish: so https://review.openstack.org/#/c/159228 is required? | 19:33 |
ChuckC_ | mtreinish: mestery: or too late? | 19:34 |
*** gridinv has quit IRC | 19:34 | |
mestery | ChuckC_: Looks like armax is highly not in favor of that particular change | 19:34 |
*** gridinv has joined #openstack-neutron | 19:34 | |
ChuckC_ | mestery: yep, hence this discussion :) | 19:35 |
ChuckC_ | not sure what options we have | 19:35 |
mestery | ChuckC_: I see we've stepped into a quagmire here | 19:35 |
mtreinish | well you just need some way to signal that the api changed. A config option may not be the best way, but it would at least make the breakage optional | 19:35 |
mtreinish | normally it's done with an extension, which is also terribad but at least it's not a config option | 19:36 |
ChuckC_ | mtreinish: mestery: does the fact that the change is backward compatible matter? | 19:36 |
mestery | mtreinish: Ack on the extension, ack on it being terribad | 19:36 |
mestery | ChuckC_: It's backward compatible? | 19:36 |
*** ajo has joined #openstack-neutron | 19:37 | |
ChuckC_ | mestery: we allow something that was previously disallowed. | 19:37 |
ChuckC_ | during the review, I came to believe that meant it was backward compatible, but... | 19:38 |
ChuckC_ | maybe I just don't understand what would break | 19:39 |
mtreinish | ChuckC_: but that is breaking the consistency between releases, you need some way to inidcate that | 19:39 |
mtreinish | think about it like it was an application | 19:39 |
ihrachyshka | armax, new func fix for stable branches work | 19:39 |
armax | ihrachyshka: yup, I notived | 19:39 |
armax | noticed | 19:39 |
ChuckC_ | mtreinish: sure, so then what would a 'backward compatible' change be? | 19:39 |
mtreinish | ChuckC_: https://wiki.openstack.org/wiki/APIChangeGuidelines#Generally_Considered_OK | 19:40 |
ChuckC_ | mtreinish: mestery: for this to impact someone, they would be relying on the failure of the request, which could happen of course | 19:40 |
* ChuckC_ looks | 19:40 | |
mtreinish | although re-reading that it seems like this arguably fits on that list | 19:41 |
mtreinish | because it previously resulted in a failure now doesn't | 19:41 |
*** ivar-lazzaro has joined #openstack-neutron | 19:41 | |
ChuckC_ | mtreinish: yeah, if you consider it a 'bug' | 19:41 |
mtreinish | so I think as a team you guys need to say whether it was a bug fix and if so then we can just remove the offending negative tempest test | 19:42 |
mtreinish | if not we need to signal it as a breaking change somehow | 19:42 |
ChuckC_ | mtreinish: the failing test is a positive test case run against juno | 19:43 |
ChuckC_ | https://review.openstack.org/#/c/151804 | 19:43 |
mestery | mtreinish ChuckC_: Reading that list, I think it falls under the second bullet there | 19:43 |
mestery | Thus, removing the negative test may be the best way forward. | 19:43 |
mestery | Maybe I'm simplifying it though | 19:43 |
mtreinish | ChuckC_: oh, you're trying to add the test to update the mac address | 19:44 |
ChuckC_ | well, if there was a negative test case, I guess it was removed | 19:44 |
ChuckC_ | mtreinish: yes | 19:44 |
mtreinish | what is it with you guys and exposing every edge case in branchless tempest :) | 19:45 |
ChuckC_ | mestery: my memory isn't so young any more :P | 19:45 |
ChuckC_ | mtreinish: such a thrill ;) | 19:46 |
mestery | mtreinish: lol | 19:46 |
mtreinish | ChuckC_: well since backporting is probably out of the question. (which is how we advise handling this in the tempest docs) The only option would be to add a config option to tempest | 19:46 |
openstackgerrit | Trinath Somanchi proposed openstack/neutron: [contribute.rst] Current status of Freescale Codebase. https://review.openstack.org/160702 | 19:46 |
mtreinish | ChuckC_: because we assumed that any bug which changes the api behavior would be backported | 19:47 |
ChuckC_ | mestery: mtreinish: armax: one thing: users of plugins/backends that don't support mac address update might prefer the neutron config variable | 19:47 |
ChuckC_ | some platforms never have 'unbound' ports, so cannot use this feature | 19:48 |
mtreinish | heh, this is quite the mess. So basically it's a crapshoot whether you can update the mac address or not :( | 19:48 |
*** bandarji has joined #openstack-neutron | 19:49 | |
mtreinish | it depends on the release and the backend... | 19:49 |
ChuckC_ | mtreinish: it's not really useful except in certain cases, e.g. ironic servers where the nic failed and was replaced | 19:49 |
ChuckC_ | mtreinish: SRIOV nics as well | 19:50 |
*** CaptainMorgan is now known as morganfainberg | 19:50 | |
*** superanne has joined #openstack-neutron | 19:50 | |
*** banix has quit IRC | 19:50 | |
armax | ChuckC_: but that should be done via policy IMO | 19:51 |
armax | ChuckC_: we already bloat in terms of options as we are | 19:51 |
*** spandhe_ has joined #openstack-neutron | 19:51 | |
*** ijw has joined #openstack-neutron | 19:51 | |
*** superanne has quit IRC | 19:51 | |
*** carl_baldwin has quit IRC | 19:52 | |
*** trinaths1 has quit IRC | 19:52 | |
ChuckC_ | armax: I agree, so users I mentioned could just use policy to block the operation... | 19:52 |
*** salv-orlando has joined #openstack-neutron | 19:52 | |
*** superanne has joined #openstack-neutron | 19:52 | |
ChuckC_ | mtreinish: can tempest do the same? | 19:52 |
mtreinish | ChuckC_: no, because as a user you have no way to know what the policy file is | 19:52 |
ihrachyshka | mestery, salv-orlando, may I ask you to check https://bugs.launchpad.net/neutron/+bug/1365727 on whether it's worth a CVE (it would influence how we move forward with a backport that was requested for the bug) | 19:53 |
openstack | Launchpad bug 1365727 in OpenStack Security Advisory "N1kv tenant able to create networks for non-shared network profiles of other N1kv tenants" [Undecided,Incomplete] | 19:53 |
mtreinish | ChuckC_: this fits the criteria for having a tempest config option optional feature (which depends on release and/or backend) | 19:53 |
ihrachyshka | you seem to be in neutron sec team, so... | 19:53 |
*** spandhe has quit IRC | 19:53 | |
*** spandhe_ is now known as spandhe | 19:53 | |
mtreinish | so you'd have to add a tempest config option to you patch in network-feature-enabled, something like update-mac-address | 19:53 |
mestery | ihrachyshka: I just read the description, seems like it would require a CVE to me, do you agree? | 19:53 |
ChuckC_ | mtreinish: I'm surprised, I thought the policy file was intended to be user modifyable | 19:53 |
ihrachyshka | mestery, I would agree, though sthillma_ from Cisco says it's not worth it (see comments) | 19:54 |
mtreinish | ChuckC_: oh no. The policy file is a server side configuration | 19:54 |
ChuckC_ | mtreinish: looking | 19:54 |
mtreinish | ChuckC_: that being said, I'm also tempted to say give up on the tempest patch and let's pretend this doesn't exist :) | 19:55 |
ChuckC_ | mtreinish: lessens my load :P but maybe my paycheck too | 19:55 |
mestery | ihrachyshka: I remain unconvinced | 19:56 |
*** superanne has quit IRC | 19:56 | |
mtreinish | ChuckC_: heh, I should talk to mordred about a paycheck linearly proportional to patch count :) | 19:56 |
mtreinish | I'm not sure that would work in my favor or against it | 19:57 |
ihrachyshka | mestery, ok. anyway, VMT asked @neutron-sec members to consider the bug and leave a comment there, so kindly asking :) | 19:57 |
*** superanne has joined #openstack-neutron | 19:57 | |
ChuckC_ | mtreinish: I'd starve | 19:57 |
mestery | ihrachyshka: I replied in the bug | 19:57 |
ijw | mtreinish: we could use a negative factor... | 19:57 |
mestery | ihrachyshka: Lets take it from there. | 19:57 |
ihrachyshka | mestery++ | 19:57 |
mordred | :) | 19:58 |
*** yfauser has joined #openstack-neutron | 19:58 | |
*** yfauser has left #openstack-neutron | 19:58 | |
ChuckC_ | mtreinish: thanks, I'll look into the tempest config var :) | 19:58 |
openstackgerrit | Maru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest https://review.openstack.org/158021 | 19:58 |
*** banix has joined #openstack-neutron | 19:59 | |
*** Marga_ has quit IRC | 19:59 | |
mtreinish | ChuckC_: if you go down the config option in tempest route, just make sure you outline in the option help and the commit msg very clearly why it's needed | 19:59 |
ijw | ihrachyshka, mestery: Looking at it, it's not really privilege escalation, it's faulty priv checking. What is not mentioned in that bug is the consequences of using someone else's network profile - is it dangerous or harmless? I think that would be key to its significance | 19:59 |
ChuckC_ | mtreinish: will do | 19:59 |
mtreinish | also you'll have to push up stable devstack branch patches to disable the flag in tempest | 19:59 |
mtreinish | and then use Depends-On in the commit message of the tempest patch | 20:00 |
mestery | ijw: It's dangerous and harmless | 20:00 |
mtreinish | (assuming that works with stable branches) | 20:00 |
ChuckC_ | armax: are you ok with a tempest config var? | 20:00 |
mestery | ijw: You're using a network profile (which may contain a VLAN) that someone else created | 20:00 |
ihrachyshka | ijw, well, that's terminology question. But quoting Wikipedia, "Privilege escalation is the act of exploiting a bug, design flaw or configuration oversight in an operating system or software application to gain elevated access to resources that are normally protected from an application or user" | 20:01 |
openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver https://review.openstack.org/158560 | 20:01 |
openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention https://review.openstack.org/144391 | 20:01 |
ChuckC_ | mtreinish: so the devstack patches land first, yes? | 20:01 |
*** _cjones_ has joined #openstack-neutron | 20:01 | |
armax | ChuckC_: what do you mean? | 20:01 |
mtreinish | ChuckC_: yes, otherwise the tempest patch won't get through the check queue | 20:01 |
ihrachyshka | ijw, so it's not like you need to get admin to claim it's an escalation (or so I read it) | 20:01 |
ChuckC_ | armax: mtreinish suggests a tempest config variable instead of neutron, just so the tempest api test can skip when run against juno | 20:02 |
ijw | ihrachyshka: We're really playing word games, but I would argue that escalation means you've somehow acquired a priv flag that lets you do more than you should. In this instance you haven't acquired privileges (therefore no escalation) but you can do something you shouldn't (which is a fault in your lower priv level) | 20:03 |
ijw | ihrachyshka: I doubt the fine distinction makes much difference. | 20:03 |
armax | ChuckC_: ok, if this is the process that Tempest adopts to test Extensions per release, then I am fine with it | 20:03 |
ChuckC_ | mtreinish: ^^ | 20:03 |
*** gridinv has quit IRC | 20:04 | |
*** sripriya has joined #openstack-neutron | 20:04 | |
*** Longgeek has quit IRC | 20:06 | |
*** vivek-ebay has quit IRC | 20:06 | |
*** vivek-ebay has joined #openstack-neutron | 20:07 | |
*** vivek-ebay has quit IRC | 20:07 | |
*** vivek-ebay has joined #openstack-neutron | 20:07 | |
*** salv-orlando has quit IRC | 20:11 | |
*** rkukura has quit IRC | 20:14 | |
*** _cjones_ has quit IRC | 20:14 | |
*** techcet has quit IRC | 20:15 | |
openstackgerrit | Merged openstack/neutron: Remove 'free' exclusions from pylint https://review.openstack.org/162173 | 20:15 |
*** mlavalle has quit IRC | 20:19 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Fixing UT breakage. https://review.openstack.org/162286 | 20:20 |
*** _cjones_ has joined #openstack-neutron | 20:21 | |
*** rkukura has joined #openstack-neutron | 20:22 | |
ChuckC_ | mtreinish: armax: i'll take a look at the backporting option and see if my new manager is ok with whatever timeline I come up with | 20:23 |
ChuckC_ | otherwise, the tempest config patch will have to do | 20:23 |
*** thomasem_ has quit IRC | 20:25 | |
*** _cjones_ has quit IRC | 20:26 | |
*** _cjones_ has joined #openstack-neutron | 20:27 | |
*** leenheer has quit IRC | 20:27 | |
ChuckC_ | mtreinish: armax: nevermind, only bugs are backported I guess | 20:27 |
mtreinish | ChuckC_: heh, well you said it was a bug to fit the 2nd bullet on the change guidelines :) | 20:27 |
*** thomasem has joined #openstack-neutron | 20:27 | |
ChuckC_ | mtreinish: what to do with a 'bug fix' that changes the api.... | 20:29 |
mtreinish | ChuckC_: http://docs.openstack.org/developer/tempest/overview.html#bug-fix-on-core-project-needing-tempest-changes | 20:29 |
ChuckC_ | mtreinish: ok, but first https://wiki.openstack.org/wiki/StableBranch#Appropriate_Fixes | 20:31 |
*** radez is now known as radez_g0n3 | 20:32 | |
ChuckC_ | mtreinish: not sure I could argue the importance of backporting this change... | 20:32 |
mtreinish | ChuckC_: heh, well if the api needs a change that's an exception. I view that stable guideline as more of the general case | 20:32 |
mtreinish | ChuckC_: normally this is something that we shouldn't be doing | 20:33 |
mtreinish | the tempest doc just outlines what you need to do in order to land the change | 20:33 |
ChuckC_ | mtreinish: yep, ok, back to the tempest config var :) | 20:34 |
mtreinish | fwiw, we've done that procedure (with the backports) several times already | 20:34 |
ChuckC_ | mtreinish: what justifications have been made for those changes? | 20:34 |
mtreinish | I don't remember, but I think there was normally just ptl buy in for doing it | 20:35 |
ChuckC_ | mtreinish: ok, let me see what I can do/find out regarding need in juno | 20:36 |
*** techcet has joined #openstack-neutron | 20:37 | |
*** rushil_ has quit IRC | 20:37 | |
*** achanda has quit IRC | 20:37 | |
*** SumitNaiksatam has quit IRC | 20:37 | |
*** ivar-lazzaro has quit IRC | 20:39 | |
*** apuimedo has quit IRC | 20:39 | |
*** tflynn has quit IRC | 20:40 | |
*** TrevorV|Home has quit IRC | 20:41 | |
*** rkukura has quit IRC | 20:41 | |
*** raildo has quit IRC | 20:42 | |
*** crc32 has joined #openstack-neutron | 20:43 | |
*** rushil has joined #openstack-neutron | 20:45 | |
*** Trevor_V has joined #openstack-neutron | 20:45 | |
*** cference has quit IRC | 20:45 | |
*** cference has joined #openstack-neutron | 20:46 | |
*** sc68cal_ is now known as sc68cal | 20:46 | |
*** ChrisNBlum has quit IRC | 20:46 | |
*** cference has quit IRC | 20:51 | |
*** ivar-lazzaro has joined #openstack-neutron | 20:51 | |
*** ivar-lazzaro has quit IRC | 20:51 | |
*** ivar-laz_ has joined #openstack-neutron | 20:52 | |
*** ivar-laz_ has quit IRC | 20:52 | |
*** cference has joined #openstack-neutron | 20:54 | |
*** mlavalle has joined #openstack-neutron | 20:55 | |
*** nlahouti has quit IRC | 20:58 | |
*** Trevor_V has quit IRC | 20:58 | |
*** dprince has quit IRC | 20:59 | |
*** achanda has joined #openstack-neutron | 21:00 | |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: device driver and agent refactoring https://review.openstack.org/160179 | 21:00 |
*** dimsum__ has quit IRC | 21:01 | |
*** pritesh has quit IRC | 21:02 | |
*** rushil has quit IRC | 21:02 | |
*** ijw has quit IRC | 21:05 | |
*** ijw has joined #openstack-neutron | 21:08 | |
*** tflynn has joined #openstack-neutron | 21:08 | |
pc_m | mestery: ping | 21:08 |
mestery | pc_m: yo yo yo! | 21:10 |
pc_m | mestery: I was seeing VPN UTs failing again AFTER I had committed a patch to fix breakage from a recent Neutron commit that changed internal API. | 21:10 |
*** ajo has quit IRC | 21:11 | |
pc_m | mestery: I fixed and posted here https://review.openstack.org/#/c/162286/1 | 21:11 |
pc_m | mestery: It's still running through tests, but once it completes, I'd like to get quick approval, so I can retest other commits | 21:11 |
* pc_m this will be hard on a Friday | 21:12 | |
*** yamamoto has joined #openstack-neutron | 21:12 | |
mestery | pc_m: Will do it once it's done | 21:12 |
pc_m | mestery: take a look at the review. I'm totally baffled as to why this happened. | 21:12 |
pc_m | Essentially Carl did a change on 2/23 (yeah Feb). I did the UT breakage fix, which just merged up and it passed tests. | 21:13 |
pc_m | So did the review that I have out now for refactoring. But another review that ran tests today failed, and sure enough, it is broken. | 21:13 |
pc_m | The UT breakage fix was for some other issue. I don't know why it didn't fail due to the 2/23 change. | 21:14 |
*** tflynn has quit IRC | 21:16 | |
pc_m | There is something unexplainable going on between the two repos... :( | 21:16 |
*** yamamoto has quit IRC | 21:16 | |
*** s3wong has joined #openstack-neutron | 21:17 | |
*** leenheer has joined #openstack-neutron | 21:17 | |
*** absubram has quit IRC | 21:17 | |
*** jobewan has joined #openstack-neutron | 21:17 | |
pc_m | So 160179 review passed python27 test yesterday, and review 161714 failed the test this morning. | 21:18 |
*** rkukura has joined #openstack-neutron | 21:18 | |
pc_m | mestery: In any case, if you can help me get review and approve for this one-liner, I can rebase the other two commits. | 21:22 |
mestery | pc_m: Ack | 21:22 |
pc_m | mestery: Thanks! | 21:22 |
*** absubram has joined #openstack-neutron | 21:23 | |
*** rkukura has quit IRC | 21:24 | |
*** ihrachyshka has quit IRC | 21:26 | |
*** julim has quit IRC | 21:27 | |
*** badveli has joined #openstack-neutron | 21:27 | |
*** jp_at_hp has joined #openstack-neutron | 21:28 | |
*** sthillma_ has quit IRC | 21:31 | |
*** vivek-ebay has quit IRC | 21:32 | |
*** pc_m has quit IRC | 21:32 | |
*** jp_at_hp has quit IRC | 21:33 | |
*** harlowja_away has quit IRC | 21:34 | |
*** vivek-ebay has joined #openstack-neutron | 21:36 | |
openstackgerrit | Phillip Toohill proposed openstack/python-neutronclient: Updating lbaas cli for TLS https://review.openstack.org/161404 | 21:36 |
*** salv-orlando has joined #openstack-neutron | 21:36 | |
*** dboik_ has quit IRC | 21:37 | |
*** dimsum__ has joined #openstack-neutron | 21:41 | |
openstackgerrit | Sripriya Seetharam proposed openstack/neutron: Brocade Vyatta vrouter shim plugin for vendor decomposition https://review.openstack.org/159056 | 21:41 |
*** pritesh_ has joined #openstack-neutron | 21:41 | |
*** pritesh_ is now known as pritesh | 21:42 | |
openstackgerrit | Merged openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo https://review.openstack.org/162099 | 21:42 |
openstackgerrit | Merged openstack/neutron: Fix DB2 upgrade problem for Remove Hyper-V plugin https://review.openstack.org/162083 | 21:43 |
*** superanne has quit IRC | 21:44 | |
openstackgerrit | Phillip Toohill proposed openstack/python-neutronclient: Updating lbaas cli for TLS https://review.openstack.org/161404 | 21:45 |
*** signed8bit has quit IRC | 21:46 | |
*** marun has quit IRC | 21:47 | |
mtreinish | mestery: do you think someone could work on migrating the neutronclient cli tests out of tempest. It should be pretty simple, jogo pushed up instructions to the ML: http://lists.openstack.org/pipermail/openstack-dev/2015-February/057458.html | 21:47 |
*** amotoki has quit IRC | 21:48 | |
*** signed8bit has joined #openstack-neutron | 21:48 | |
*** cference has quit IRC | 21:48 | |
*** baoli_ has quit IRC | 21:49 | |
*** nlahouti has joined #openstack-neutron | 21:50 | |
*** igordcard has joined #openstack-neutron | 21:50 | |
mestery | mtreinish: Ack, that seems doable, thanks for the pointer! | 21:51 |
mtreinish | mestery: I'd really like to see that all be out of tempest by the end of the cycle :) | 21:51 |
mestery | mtreinish: ++ | 21:51 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Replace keepalived notifier bash script with Python ip monitor https://review.openstack.org/125384 | 21:52 |
*** superanne has joined #openstack-neutron | 21:52 | |
amuller | armax: New revision up, addressed your comments (And Cedric's, Akihiro's) | 21:52 |
mestery | mtreinish: I'll take a stab at this over the weekend, it looks pretty simple actually and the instructions look easy, thanks! | 21:53 |
*** sthillma has joined #openstack-neutron | 21:53 | |
*** b3nt_pin has joined #openstack-neutron | 21:53 | |
mtreinish | mestery: cool thanks | 21:53 |
*** luflores has joined #openstack-neutron | 21:53 | |
mestery | mtreinish: yw, and thanks for the reminder. It's hard to juggle a million things, so reminders are very helpful for me :) | 21:54 |
*** kickinz1 is now known as kickinz1|afk | 21:55 | |
mtreinish | mestery: yeah, completely understand. I'm trying to ping someone from every project over the next week to get them all out. | 21:55 |
mestery | mtreinish: Thanks again for the reminder! | 21:56 |
* mtreinish hopes no one tracks all the things hepromised to do | 21:56 | |
mestery | mtreinish: It must almost be happy hour where you are, right? I'm still an hour away ;) | 21:56 |
mestery | mtreinish: lol | 21:56 |
*** prad has joined #openstack-neutron | 21:56 | |
mtreinish | mestery: heh, yeah it's getting to be that time | 21:57 |
openstackgerrit | Rajeev Grover proposed openstack/neutron: If configured, set the MTU for fpr/rfp intefaces https://review.openstack.org/162312 | 21:57 |
openstackgerrit | Sripriya Seetharam proposed openstack/neutron: Brocade Vyatta vrouter shim plugin for vendor decomposition https://review.openstack.org/159056 | 22:00 |
*** vivek-ebay has quit IRC | 22:00 | |
*** vivek-ebay has joined #openstack-neutron | 22:00 | |
*** amuller has quit IRC | 22:02 | |
*** manishg has quit IRC | 22:04 | |
*** manishg has joined #openstack-neutron | 22:05 | |
*** tiswanso has quit IRC | 22:05 | |
*** techcet has quit IRC | 22:05 | |
*** jgrimm is now known as zz_jgrimm | 22:06 | |
*** ijw has quit IRC | 22:08 | |
*** radez_g0n3 is now known as radez | 22:08 | |
*** ijw has joined #openstack-neutron | 22:08 | |
bandarji | neutron subnet-update <project> —allocation-pools start=172.20.24.100,end=172.20.27.250 # this fails - anyone know if something wrong with my format? | 22:09 |
bandarji | the network is 172.20.24.0/22 | 22:09 |
*** baoli has joined #openstack-neutron | 22:10 | |
openstackgerrit | Abhishek Raut proposed openstack/neutron: Cisco Nexus1000V ML2 Mechanism Driver https://review.openstack.org/157243 | 22:11 |
*** aepifanov has quit IRC | 22:12 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: Basic subnetpool CRUD https://review.openstack.org/148698 | 22:13 |
*** Marga_ has joined #openstack-neutron | 22:14 | |
*** dimsum__ has quit IRC | 22:16 | |
haleyb | bandarji: s/allocation-pools/allocation-pool - no 's' on the end ? | 22:16 |
*** dimsum__ has joined #openstack-neutron | 22:17 | |
*** sbfox has quit IRC | 22:17 | |
*** tflynn has joined #openstack-neutron | 22:20 | |
*** banix has quit IRC | 22:21 | |
*** sbfox has joined #openstack-neutron | 22:21 | |
*** dimsum__ has quit IRC | 22:21 | |
bandarji | thanks - got it fixed - it was client software version | 22:21 |
*** dimsum__ has joined #openstack-neutron | 22:23 | |
*** r-daneel has quit IRC | 22:23 | |
*** vmtrooper has joined #openstack-neutron | 22:23 | |
openstackgerrit | Merged openstack/neutron: Refactor the ProcessMonitor API https://review.openstack.org/154464 | 22:24 |
*** chlong has quit IRC | 22:24 | |
*** tflynn has quit IRC | 22:25 | |
*** leenheer has quit IRC | 22:28 | |
*** ijw has quit IRC | 22:28 | |
openstackgerrit | Merged openstack/neutron: oslo: sync all modules that depend on incubator log module https://review.openstack.org/159654 | 22:28 |
*** radez is now known as radez_g0n3 | 22:31 | |
openstackgerrit | Merged openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed" https://review.openstack.org/156853 | 22:31 |
*** leenheer has joined #openstack-neutron | 22:34 | |
*** vmtrooper has quit IRC | 22:37 | |
*** carlp has quit IRC | 22:37 | |
*** sbfox has quit IRC | 22:37 | |
*** thomasem has quit IRC | 22:41 | |
*** julim has joined #openstack-neutron | 22:41 | |
*** igordcard has quit IRC | 22:42 | |
*** dimsum__ has quit IRC | 22:43 | |
*** dimsum__ has joined #openstack-neutron | 22:43 | |
*** sbfox has joined #openstack-neutron | 22:44 | |
*** dimsum__ has quit IRC | 22:48 | |
*** zhenq has joined #openstack-neutron | 22:49 | |
*** manishg_ has joined #openstack-neutron | 22:50 | |
*** carlp has joined #openstack-neutron | 22:51 | |
openstackgerrit | Kyle Mestery proposed openstack/python-neutronclient: Add OS_TEST_PATH to testr https://review.openstack.org/162326 | 22:51 |
openstackgerrit | Kyle Mestery proposed openstack/python-neutronclient: First pass at tempest-lib based functional testing https://review.openstack.org/162327 | 22:51 |
*** salv-orlando has quit IRC | 22:53 | |
*** ajo has joined #openstack-neutron | 22:53 | |
*** manishg has quit IRC | 22:54 | |
*** leenheer has quit IRC | 22:54 | |
*** bandarji has quit IRC | 22:54 | |
*** techcet has joined #openstack-neutron | 22:55 | |
*** igordcard has joined #openstack-neutron | 22:57 | |
*** banix has joined #openstack-neutron | 22:58 | |
*** banix has quit IRC | 22:59 | |
*** _cjones_ has quit IRC | 22:59 | |
*** superanne has quit IRC | 22:59 | |
*** ParsectiX has quit IRC | 23:00 | |
*** eren has quit IRC | 23:00 | |
*** ParsectiX has joined #openstack-neutron | 23:00 | |
*** r-daneel has joined #openstack-neutron | 23:02 | |
*** achanda_ has joined #openstack-neutron | 23:03 | |
*** achanda has quit IRC | 23:03 | |
*** igordcard has quit IRC | 23:03 | |
*** ajo has quit IRC | 23:03 | |
openstackgerrit | Kyle Mestery proposed openstack/python-neutronclient: Add post_test_hook for functional tests https://review.openstack.org/162331 | 23:04 |
mestery | mtreinish: I got a good start on moving the tempest cli tests, thanks for hte pointer! I should hopefully have it finished monday pending merges. | 23:05 |
mestery | mtreinish: Have a good weekend! | 23:05 |
*** claudiub has joined #openstack-neutron | 23:05 | |
claudiub | hello. anyone online who can answer some questions about floating ips? | 23:05 |
*** banix has joined #openstack-neutron | 23:05 | |
claudiub | or about how / why floating ips work? | 23:06 |
claudiub | or why the way floating ips work has changes? | 23:06 |
claudiub | changed * | 23:06 |
*** r-daneel_ has joined #openstack-neutron | 23:06 | |
*** ronis has quit IRC | 23:07 | |
*** r-daneel has quit IRC | 23:07 | |
luflores | My understanding is that floating ips are basically nat | 23:07 |
*** _cjones_ has joined #openstack-neutron | 23:07 | |
*** achanda_ has quit IRC | 23:07 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 23:07 |
claudiub | true, but there has been some recent changes, that broke floating ip binding to hyper-v | 23:08 |
claudiub | and I don't know what / how / when | 23:08 |
*** vmtrooper has joined #openstack-neutron | 23:09 | |
claudiub | for example: ubuntu@ubuntu:/$ nova floating-ip-associate test2 172.24.4.6 | 23:09 |
claudiub | ERROR (BadRequest): Unable to associate floating ip 172.24.4.6 to fixed ip 10.0.0.4 for instance d4cddf87-f600-4d4e-8404-deed0110bf93. Error: Agent with agent_type=L3 agent and host=WIN-SRVR2 could not be found (HTTP 400) (Request-ID: req-ddef9ca4-0b80-46bd-870e-5467d74ff933) | 23:09 |
*** achanda has joined #openstack-neutron | 23:10 | |
*** r-daneel_ has quit IRC | 23:10 | |
mtreinish | mestery: awesome | 23:10 |
*** r-daneel_ has joined #openstack-neutron | 23:10 | |
claudiub | and hyper-v nodes have no L3 agents, only L2 agents, named 'HyperV Agent' | 23:10 |
claudiub | mtreinish: hello | 23:10 |
*** ijw has joined #openstack-neutron | 23:11 | |
*** manishg_ has left #openstack-neutron | 23:11 | |
claudiub | mtreinish: I've uploaded a new patchset for the telemetry metrics collection commit: https://review.openstack.org/#/c/140750/ . If you have some time, could you take a look? Thanks! :D | 23:12 |
claudiub | probably wrong channel for this... sorry :) | 23:12 |
mtreinish | claudiub: sure, I'll put it on my list. But, I'm mostly done for today, so it probably won't be until enxt week | 23:13 |
*** crc32 has quit IRC | 23:13 | |
*** leenheer has joined #openstack-neutron | 23:13 | |
claudiub | mtreinish: sure, no problem :) | 23:13 |
*** yamamoto has joined #openstack-neutron | 23:14 | |
*** kbringard has quit IRC | 23:15 | |
*** techcet has quit IRC | 23:15 | |
claudiub | mtreinish: also, I have a commit for tempest security groups, that have been awaiting reviews for a few months... currently needs rebase, which I'll do tomorrow, but can you also add it to the list? It's quite important, because without it, there is security groups test in Hyper-V CI, so there is no validation for that feature. Plus, there already was an issue regarding that feature, there were some changes that broke secu | 23:16 |
*** prad has quit IRC | 23:16 | |
claudiub | mtreinish: and was not caught for quite some time and the test would help prevent this from happening again. :) | 23:17 |
claudiub | mtreinish: the commit is: https://review.openstack.org/#/c/117520/ | 23:17 |
*** yamamoto has quit IRC | 23:18 | |
*** igordcard has joined #openstack-neutron | 23:20 | |
*** techcet has joined #openstack-neutron | 23:20 | |
mtreinish | claudiub: sure will do | 23:20 |
*** ijw_ has joined #openstack-neutron | 23:21 | |
*** Networkn3rd has quit IRC | 23:21 | |
*** tflynn has joined #openstack-neutron | 23:21 | |
claudiub | mtreinish: thanks. :D | 23:21 |
*** techcet_ has joined #openstack-neutron | 23:21 | |
*** SridharRamaswamy has quit IRC | 23:22 | |
*** ijw_ has quit IRC | 23:22 | |
*** ijw_ has joined #openstack-neutron | 23:23 | |
*** ijw has quit IRC | 23:23 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: Basic subnetpool CRUD https://review.openstack.org/148698 | 23:24 |
*** techcet has quit IRC | 23:25 | |
*** ChuckC_ has quit IRC | 23:25 | |
*** vmtrooper has quit IRC | 23:25 | |
openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 23:25 |
*** tflynn has quit IRC | 23:25 | |
*** techcet_ has quit IRC | 23:26 | |
*** armax has quit IRC | 23:27 | |
openstackgerrit | Yanping Qu proposed openstack/neutron-fwaas: Adds FWaaS driver for Cisco CSR1kv https://review.openstack.org/161019 | 23:28 |
*** leenheer has quit IRC | 23:29 | |
*** luflores has quit IRC | 23:31 | |
*** signed8bit has quit IRC | 23:32 | |
*** sthillma has quit IRC | 23:38 | |
*** s3wong has quit IRC | 23:38 | |
*** ijw_ has quit IRC | 23:39 | |
*** busterswt has quit IRC | 23:40 | |
*** bquan_ has quit IRC | 23:43 | |
*** ChuckC_ has joined #openstack-neutron | 23:43 | |
*** ChuckC_ is now known as ChuckC | 23:44 | |
*** leenheer has joined #openstack-neutron | 23:46 | |
openstackgerrit | Yanping Qu proposed openstack/neutron-fwaas: Provide hooks for FWaaS repo functional gate https://review.openstack.org/161479 | 23:49 |
openstackgerrit | Yanping Qu proposed openstack/neutron-fwaas: Provide Cisco FWaaS functional tests https://review.openstack.org/161938 | 23:49 |
openstackgerrit | Dane LeBlanc proposed openstack/neutron: Support Dual-Stack Gateway Ports on Neutron Routers https://review.openstack.org/149068 | 23:49 |
*** leenheer has quit IRC | 23:58 | |
*** mlavalle has quit IRC | 23:58 | |
*** dimsum__ has joined #openstack-neutron | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!