| *** dims has quit IRC | 00:00 | |
| *** padkrish has quit IRC | 00:01 | |
| *** ijw has quit IRC | 00:01 | |
| *** markvoelker has joined #openstack-neutron | 00:02 | |
| *** achanda has quit IRC | 00:03 | |
| *** flwang1 has joined #openstack-neutron | 00:03 | |
| *** ZZelle_ has quit IRC | 00:05 | |
| *** shaohe_feng has quit IRC | 00:06 | |
| *** baoli has quit IRC | 00:06 | |
| *** _cjones_ has quit IRC | 00:07 | |
| *** Marga_ has quit IRC | 00:08 | |
| *** Marga_ has joined #openstack-neutron | 00:08 | |
| *** Marga__ has joined #openstack-neutron | 00:10 | |
| *** Marga_ has quit IRC | 00:10 | |
| openstackgerrit | Terry Wilson proposed openstack/neutron: Handle non-index lookups in native OVSDB backend https://review.openstack.org/167017 | 00:11 |
|---|---|---|
| *** igordcard_ has quit IRC | 00:13 | |
| *** annegentle has quit IRC | 00:14 | |
| *** emagana has quit IRC | 00:14 | |
| *** baoli has joined #openstack-neutron | 00:15 | |
| openstackgerrit | Assaf Muller proposed openstack/python-neutronclient: Add HA router state to l3-agent-list-hosting-router https://review.openstack.org/126182 | 00:15 |
| amuller | armax: ^ | 00:15 |
| *** Swami_ has joined #openstack-neutron | 00:15 | |
| armax | amuller: at your services, master | 00:15 |
| *** Swami has quit IRC | 00:16 | |
| amuller | armax: Careful I could get used to that | 00:16 |
| *** yamamoto_ has quit IRC | 00:16 | |
| *** _cjones_ has joined #openstack-neutron | 00:17 | |
| *** Swami_ has quit IRC | 00:17 | |
| armax | amuller: you ignored comment 3 of 3 | 00:19 |
| armax | amuller: bad boy | 00:19 |
| amuller | armax: Either I'm blind or I see 2 comments in your latest review | 00:19 |
| *** melwitt has quit IRC | 00:19 | |
| amuller | oh now I see | 00:20 |
| amuller | you hid it! | 00:20 |
| armax | I did | 00:20 |
| armax | on purpose | 00:20 |
| amuller | yeah I'll do that | 00:20 |
| armax | btw you’d want to sync up with mestery or amotoki about this | 00:20 |
| armax | amuller: mestery needs to know that we need to cut another tag for the client | 00:20 |
| *** xgerman_ has quit IRC | 00:21 | |
| openstackgerrit | Assaf Muller proposed openstack/python-neutronclient: Add HA router state to l3-agent-list-hosting-router https://review.openstack.org/126182 | 00:21 |
| amuller | armax: Do you think mestery wasn't planning on a neutronclient release between K3 and GA? Well I suppose that wouldn't be mandatory | 00:22 |
| armax | amuller: I’d suppose so, just saying... | 00:22 |
| amuller | armax: Thanks I'll shoot him an email | 00:23 |
| armax | no need, he’s in channel…he’ll see I guess | 00:23 |
| *** rangansw has joined #openstack-neutron | 00:23 | |
| kevinbenton | how do i make the pep8 check ignore a local script i have in the neutron directory? | 00:25 |
| *** lilynn has quit IRC | 00:26 | |
| *** rangansw_ has quit IRC | 00:26 | |
| *** hitalia has quit IRC | 00:26 | |
| *** ivar-laz_ has quit IRC | 00:27 | |
| *** Marga__ has quit IRC | 00:28 | |
| amuller | kevinbenton: line 92 in tox.ini? | 00:28 |
| *** zhhuabj has quit IRC | 00:29 | |
| kevinbenton | amuller: that would mean i have to edit tox.ini | 00:30 |
| kevinbenton | amuller: i was hoping that was a flake8 flag that i could put at the top of the file or something | 00:30 |
| *** _cjones_ has quit IRC | 00:31 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Remove cleanup clutter from L3 tests https://review.openstack.org/167056 | 00:32 |
| *** padkrish has joined #openstack-neutron | 00:33 | |
| *** baoli has quit IRC | 00:35 | |
| amuller | kevinbenton: https://review.openstack.org/#/c/167030/1 | 00:35 |
| amuller | makes me sad | 00:35 |
| kevinbenton | amuller: why? | 00:36 |
| amuller | took me a while to get rid of all do_delete and no_delete throughout the project | 00:36 |
| amuller | it shouldn't be necessary | 00:36 |
| kevinbenton | amuller: um, the only reason you were able to was because i changed the defaults in the first place :) | 00:37 |
| amuller | why not delete the router deletion at the end of the context manager instead? | 00:37 |
| kevinbenton | amuller: because we need to confirm that there are adequate tests covering that | 00:37 |
| kevinbenton | amuller: then i can remove it | 00:37 |
| kevinbenton | amuller: ultimately i agree | 00:38 |
| kevinbenton | amuller: https://review.openstack.org/#/c/102465/5 | 00:40 |
| amuller | https://review.openstack.org/#/c/92013/ | 00:40 |
| kevinbenton | amuller: was just going to follow a similar path for router | 00:40 |
| kevinbenton | amuller: there is no such thing as do_delete :) | 00:40 |
| amuller | I'm aware of that | 00:41 |
| *** banix has quit IRC | 00:44 | |
| *** yamamoto has joined #openstack-neutron | 00:45 | |
| *** nati_ueno has quit IRC | 00:47 | |
| *** nati_ueno has joined #openstack-neutron | 00:47 | |
| *** banix has joined #openstack-neutron | 00:47 | |
| *** nati_ueno has quit IRC | 00:50 | |
| *** coolsvap|afk is now known as coolsvap | 00:50 | |
| *** Longgeek has joined #openstack-neutron | 00:51 | |
| *** amuller has quit IRC | 00:54 | |
| *** rangansw has quit IRC | 00:55 | |
| *** shaohe_feng has joined #openstack-neutron | 00:57 | |
| *** sicrano has joined #openstack-neutron | 01:00 | |
| *** padkrish has quit IRC | 01:00 | |
| *** tflynn_ has joined #openstack-neutron | 01:01 | |
| *** padkrish has joined #openstack-neutron | 01:01 | |
| *** Networkn3rd has quit IRC | 01:01 | |
| *** sicrano has quit IRC | 01:02 | |
| *** Networkn3rd has joined #openstack-neutron | 01:02 | |
| *** topshare has joined #openstack-neutron | 01:02 | |
| *** tiswanso has joined #openstack-neutron | 01:02 | |
| *** sicrano has joined #openstack-neutron | 01:02 | |
| *** tflynn has quit IRC | 01:04 | |
| *** salv-orlando has quit IRC | 01:04 | |
| *** tiswanso has quit IRC | 01:04 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Remove auto deletion of routers in unit tests https://review.openstack.org/167056 | 01:04 |
| *** tiswanso has joined #openstack-neutron | 01:05 | |
| *** tflynn_ has quit IRC | 01:05 | |
| *** padkrish has quit IRC | 01:06 | |
| *** gildub has joined #openstack-neutron | 01:06 | |
| *** x58 has quit IRC | 01:09 | |
| *** x58 has joined #openstack-neutron | 01:10 | |
| *** aranjan has quit IRC | 01:10 | |
| *** aranjan has joined #openstack-neutron | 01:11 | |
| *** emagana has joined #openstack-neutron | 01:11 | |
| *** trad511 has joined #openstack-neutron | 01:11 | |
| *** baoli has joined #openstack-neutron | 01:11 | |
| *** dannywilson has quit IRC | 01:12 | |
| *** avico- has quit IRC | 01:14 | |
| *** annegentle has joined #openstack-neutron | 01:14 | |
| *** liusheng has quit IRC | 01:16 | |
| *** avico has joined #openstack-neutron | 01:17 | |
| *** emagana has quit IRC | 01:17 | |
| *** emagana has joined #openstack-neutron | 01:18 | |
| *** annegentle has quit IRC | 01:20 | |
| *** emagana has quit IRC | 01:23 | |
| *** topshare_ has joined #openstack-neutron | 01:24 | |
| *** topshare has quit IRC | 01:26 | |
| *** sudipto has joined #openstack-neutron | 01:30 | |
| *** padkrish has joined #openstack-neutron | 01:32 | |
| *** trad511 has quit IRC | 01:33 | |
| sudipto | kevinbenton: Hi, Is there a reason why don't consider the time synchronization in reverse? As in the server being behind the agent? | 01:33 |
| sudipto | kevinbenton: I observed that as old behavior. | 01:34 |
| kevinbenton | sudipto: i don't understand what you mean | 01:34 |
| kevinbenton | sudipto: right now nothing will detect that condition | 01:35 |
| sudipto | kevinbenton: yeah. Is that ok to have? | 01:35 |
| kevinbenton | sudipto: no, the agents will be reported as online even though they are actually down | 01:35 |
| *** aranjan has quit IRC | 01:36 | |
| *** aranjan has joined #openstack-neutron | 01:36 | |
| kevinbenton | sudipto: i need to leave, i will be back on later tonight | 01:37 |
| kevinbenton | sudipto: but my point is that if we are going to detect out of sync clocks, we might as well get it in both directions | 01:37 |
| sudipto | kevinbenton: Ok, yeah that also make sense. But I wondered why that behavior was never present. I am in a different timezone, would you mind telling me when you'd be back? | 01:38 |
| sudipto | kevinbenton: I would like to discuss this in a bit of a detail and sort it out. | 01:38 |
| *** aranjan has quit IRC | 01:41 | |
| sudipto | armax: Would you be ok with the approach that kevinbenton has a suggested where we deal with the clock synchronization on either side? | 01:42 |
| sudipto | armax: The agent needs to set it's clock right w.r.t the server as the recovery step... | 01:42 |
| *** avico has quit IRC | 01:44 | |
| *** dims has joined #openstack-neutron | 01:44 | |
| *** dims_ has quit IRC | 01:46 | |
| *** lykinsbd has joined #openstack-neutron | 01:46 | |
| *** avico has joined #openstack-neutron | 01:48 | |
| openstackgerrit | Merged openstack/neutron: Fix metering agent failure when chain missing https://review.openstack.org/156198 | 01:50 |
| *** sridhar_ram has quit IRC | 01:56 | |
| *** stanzgy has joined #openstack-neutron | 01:56 | |
| openstackgerrit | Merged openstack/neutron: Add no_delete flag to UT router context manager https://review.openstack.org/167030 | 01:59 |
| *** r-daneel has quit IRC | 02:02 | |
| *** _cjones_ has joined #openstack-neutron | 02:04 | |
| *** _cjones_ has quit IRC | 02:04 | |
| *** salv-orlando has joined #openstack-neutron | 02:05 | |
| *** _cjones_ has joined #openstack-neutron | 02:05 | |
| openstackgerrit | Merged openstack/neutron: Fixes floating IP regression with multiple routers https://review.openstack.org/157167 | 02:07 |
| *** erkules_ has joined #openstack-neutron | 02:14 | |
| *** baoli has quit IRC | 02:14 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify base test cases https://review.openstack.org/167041 | 02:14 |
| *** baoli has joined #openstack-neutron | 02:14 | |
| *** watanabe_isao has joined #openstack-neutron | 02:14 | |
| *** popw has joined #openstack-neutron | 02:16 | |
| *** erkules has quit IRC | 02:16 | |
| *** annegentle has joined #openstack-neutron | 02:16 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 02:17 |
| *** sripriya has quit IRC | 02:19 | |
| *** ijw_ has quit IRC | 02:19 | |
| *** dsneddon has quit IRC | 02:20 | |
| *** annegentle has quit IRC | 02:21 | |
| *** apuimedo has quit IRC | 02:22 | |
| *** topshare_ has quit IRC | 02:25 | |
| openstackgerrit | Merged openstack/neutron: Move external port processing to router classes https://review.openstack.org/158495 | 02:25 |
| openstackgerrit | Merged openstack/neutron: Remove downgrade from existing migrations https://review.openstack.org/165740 | 02:26 |
| *** topshare has joined #openstack-neutron | 02:27 | |
| *** achanda has joined #openstack-neutron | 02:37 | |
| *** topshare has quit IRC | 02:38 | |
| *** salv-orlando has quit IRC | 02:38 | |
| *** salv-orlando has joined #openstack-neutron | 02:39 | |
| *** killer_prince has quit IRC | 02:39 | |
| *** absubram has joined #openstack-neutron | 02:40 | |
| *** mlavalle has quit IRC | 02:41 | |
| *** topshare has joined #openstack-neutron | 02:41 | |
| openstackgerrit | Merged openstack/neutron: Expose ha_state per router to agent binding via API https://review.openstack.org/126189 | 02:43 |
| *** topshare has quit IRC | 02:43 | |
| *** padkrish has quit IRC | 02:44 | |
| *** padkrish has joined #openstack-neutron | 02:44 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify base test cases https://review.openstack.org/167041 | 02:46 |
| *** killer_prince has joined #openstack-neutron | 02:46 | |
| *** killer_prince is now known as lazy_prince | 02:46 | |
| *** aranjan has joined #openstack-neutron | 02:47 | |
| *** dims has quit IRC | 02:51 | |
| *** aranjan has quit IRC | 02:52 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 02:53 |
| *** achanda has quit IRC | 02:53 | |
| *** banix has quit IRC | 02:55 | |
| *** achanda has joined #openstack-neutron | 02:56 | |
| *** popw1 has joined #openstack-neutron | 02:57 | |
| *** Networkn3rd has quit IRC | 02:58 | |
| *** Networkn3rd has joined #openstack-neutron | 02:58 | |
| HenryG | marun: ping | 03:00 |
| *** popw has quit IRC | 03:00 | |
| *** haleyb has joined #openstack-neutron | 03:00 | |
| *** banix has joined #openstack-neutron | 03:01 | |
| *** aranjan has joined #openstack-neutron | 03:01 | |
| *** marun has quit IRC | 03:01 | |
| *** xgerman_ has joined #openstack-neutron | 03:04 | |
| *** padkrish has quit IRC | 03:04 | |
| *** salv-orlando has quit IRC | 03:05 | |
| *** xgerman_ has quit IRC | 03:08 | |
| *** Networkn_ has joined #openstack-neutron | 03:10 | |
| *** Networkn3rd has quit IRC | 03:10 | |
| *** aranjan has quit IRC | 03:10 | |
| *** alex_xu has quit IRC | 03:12 | |
| *** tiswanso has quit IRC | 03:13 | |
| *** shwetaap has joined #openstack-neutron | 03:14 | |
| *** chandankumar has joined #openstack-neutron | 03:15 | |
| *** xgerman_ has joined #openstack-neutron | 03:19 | |
| *** Longgeek_ has joined #openstack-neutron | 03:22 | |
| *** achanda has quit IRC | 03:24 | |
| *** chandankumar has quit IRC | 03:25 | |
| *** sbalukoff has quit IRC | 03:25 | |
| *** Longgeek has quit IRC | 03:25 | |
| *** chandankumar has joined #openstack-neutron | 03:25 | |
| *** _cjones_ has quit IRC | 03:26 | |
| *** tflynn has joined #openstack-neutron | 03:29 | |
| *** _cjones_ has joined #openstack-neutron | 03:30 | |
| *** tflynn has quit IRC | 03:31 | |
| *** achanda has joined #openstack-neutron | 03:32 | |
| openstackgerrit | gongysh proposed openstack/python-neutronclient: allow set ip info in router-gateway-set command. https://review.openstack.org/163332 | 03:33 |
| openstackgerrit | gongysh proposed openstack/python-neutronclient: allow set ip info in router-gateway-set command https://review.openstack.org/163332 | 03:34 |
| *** salv-orlando has joined #openstack-neutron | 03:37 | |
| *** gongysh has joined #openstack-neutron | 03:37 | |
| *** baoli has quit IRC | 03:37 | |
| *** watanabe_isao has quit IRC | 03:38 | |
| *** padkrish has joined #openstack-neutron | 03:39 | |
| *** tflynn has joined #openstack-neutron | 03:39 | |
| *** topshare has joined #openstack-neutron | 03:39 | |
| *** banix has quit IRC | 03:40 | |
| *** achanda has quit IRC | 03:41 | |
| *** achanda has joined #openstack-neutron | 03:43 | |
| *** topshare has quit IRC | 03:43 | |
| *** armax has quit IRC | 03:43 | |
| *** armax has joined #openstack-neutron | 03:44 | |
| *** _cjones_ has quit IRC | 03:44 | |
| *** _cjones_ has joined #openstack-neutron | 03:45 | |
| *** _cjones_ has quit IRC | 03:45 | |
| *** nati_ueno has joined #openstack-neutron | 03:47 | |
| *** tflynn has quit IRC | 03:47 | |
| *** tflynn has joined #openstack-neutron | 03:48 | |
| *** topshare has joined #openstack-neutron | 03:48 | |
| *** sbfox has joined #openstack-neutron | 03:49 | |
| *** armax has quit IRC | 03:50 | |
| *** lykinsbd_ has joined #openstack-neutron | 03:50 | |
| *** topshare has quit IRC | 03:50 | |
| *** lykinsbd has quit IRC | 03:51 | |
| *** achanda has quit IRC | 03:53 | |
| *** tflynn has quit IRC | 03:53 | |
| *** tflynn has joined #openstack-neutron | 03:54 | |
| *** flwang1 has quit IRC | 03:54 | |
| *** lykinsbd_ has quit IRC | 03:55 | |
| *** rstarr has quit IRC | 03:57 | |
| *** marun has joined #openstack-neutron | 03:58 | |
| *** _cjones_ has joined #openstack-neutron | 03:58 | |
| *** achanda has joined #openstack-neutron | 03:59 | |
| *** watanabe_isao has joined #openstack-neutron | 04:00 | |
| *** nijaba has quit IRC | 04:02 | |
| *** marun has quit IRC | 04:03 | |
| *** Networkn_ has quit IRC | 04:04 | |
| *** rstarr has joined #openstack-neutron | 04:04 | |
| *** Networkn3rd has joined #openstack-neutron | 04:04 | |
| *** Jianyong has quit IRC | 04:05 | |
| *** Jianyong has joined #openstack-neutron | 04:06 | |
| *** nijaba has joined #openstack-neutron | 04:06 | |
| *** nijaba has quit IRC | 04:06 | |
| *** nijaba has joined #openstack-neutron | 04:06 | |
| *** Marga_ has joined #openstack-neutron | 04:06 | |
| *** Marga_ has quit IRC | 04:06 | |
| *** Marga_ has joined #openstack-neutron | 04:07 | |
| *** salv-orlando has quit IRC | 04:09 | |
| *** dannywilson has joined #openstack-neutron | 04:12 | |
| *** dims has joined #openstack-neutron | 04:12 | |
| *** sudipto has quit IRC | 04:14 | |
| *** tflynn has quit IRC | 04:15 | |
| *** tflynn has joined #openstack-neutron | 04:15 | |
| *** dannywilson has quit IRC | 04:17 | |
| *** xgerman_ has quit IRC | 04:17 | |
| *** annegentle has joined #openstack-neutron | 04:18 | |
| *** dims has quit IRC | 04:19 | |
| *** shz has quit IRC | 04:19 | |
| *** shz has joined #openstack-neutron | 04:19 | |
| *** tflynn has quit IRC | 04:20 | |
| *** tflynn has joined #openstack-neutron | 04:20 | |
| *** dave-mccowan has quit IRC | 04:22 | |
| *** nati_ueno has quit IRC | 04:23 | |
| *** annegentle has quit IRC | 04:23 | |
| *** sudipto has joined #openstack-neutron | 04:23 | |
| *** trinaths has joined #openstack-neutron | 04:24 | |
| *** aranjan has joined #openstack-neutron | 04:27 | |
| *** tflynn has quit IRC | 04:28 | |
| *** SridharG has joined #openstack-neutron | 04:33 | |
| *** sbalukoff has joined #openstack-neutron | 04:33 | |
| *** sudipto has quit IRC | 04:36 | |
| *** amotoki has joined #openstack-neutron | 04:39 | |
| *** coolsvap is now known as coolsvap|afk | 04:44 | |
| *** yatin has joined #openstack-neutron | 04:47 | |
| *** ishant has joined #openstack-neutron | 04:48 | |
| trinaths | Good Morning :) | 04:49 |
| yatin | trinaths: Good Morning :) | 04:50 |
| *** nati_ueno has joined #openstack-neutron | 04:51 | |
| *** amotoki has quit IRC | 04:51 | |
| *** ChuckC has joined #openstack-neutron | 04:51 | |
| *** chandankumar has quit IRC | 04:52 | |
| *** amotoki has joined #openstack-neutron | 04:52 | |
| *** amotoki has quit IRC | 04:52 | |
| *** amotoki has joined #openstack-neutron | 04:52 | |
| *** chandankumar has joined #openstack-neutron | 04:55 | |
| *** haleyb has quit IRC | 04:55 | |
| *** tflynn has joined #openstack-neutron | 04:55 | |
| *** padkrish has quit IRC | 04:56 | |
| *** haleyb has joined #openstack-neutron | 04:57 | |
| *** Bhavya has joined #openstack-neutron | 04:57 | |
| *** marun has joined #openstack-neutron | 04:59 | |
| *** chandankumar has quit IRC | 05:04 | |
| *** marun has quit IRC | 05:04 | |
| *** haleyb has quit IRC | 05:07 | |
| trinaths | yatin: Hi Friend, Good Morning :) How are you doing | 05:08 |
| openstackgerrit | Itsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network https://review.openstack.org/161947 | 05:08 |
| yatin | trinaths: I'm doing thank you. how about you? | 05:08 |
| *** salv-orlando has joined #openstack-neutron | 05:08 | |
| yatin | trinaths: doing good | 05:08 |
| *** Marga_ has quit IRC | 05:10 | |
| trinaths | yatin: good too :) | 05:10 |
| *** marun has joined #openstack-neutron | 05:11 | |
| *** tflynn has quit IRC | 05:16 | |
| *** tflynn has joined #openstack-neutron | 05:17 | |
| *** annegentle has joined #openstack-neutron | 05:19 | |
| *** harlowja is now known as harlowja_away | 05:22 | |
| *** anshul has joined #openstack-neutron | 05:23 | |
| *** annegentle has quit IRC | 05:23 | |
| *** hitalia has joined #openstack-neutron | 05:24 | |
| *** reed has quit IRC | 05:26 | |
| *** boris-42 has quit IRC | 05:28 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 05:29 |
| openstackgerrit | gongysh proposed openstack/python-neutronclient: allow set ip info in router-gateway-set command https://review.openstack.org/163332 | 05:31 |
| *** shaohe_feng has quit IRC | 05:34 | |
| *** veena has joined #openstack-neutron | 05:37 | |
| *** sudipto has joined #openstack-neutron | 05:37 | |
| *** lazy_prince has quit IRC | 05:37 | |
| *** chandankumar has joined #openstack-neutron | 05:38 | |
| *** nati_ueno has quit IRC | 05:40 | |
| *** killer_prince has joined #openstack-neutron | 05:41 | |
| *** killer_prince is now known as lazy_prince | 05:41 | |
| *** shaohe_feng has joined #openstack-neutron | 05:43 | |
| sudipto | kevinbenton: ping | 05:44 |
| *** emagana has joined #openstack-neutron | 05:45 | |
| *** salv-orlando has quit IRC | 05:47 | |
| yalie | hi enikanorov_? | 05:52 |
| *** numan has joined #openstack-neutron | 05:52 | |
| kevinbenton | sudipto: pong | 05:53 |
| sudipto | kevinbenton: I thought through your comments and I think it makes perfect sense. | 05:53 |
| *** yatin has quit IRC | 05:53 | |
| sudipto | kevinbenton: I think the logic for having a check for self.START_TIME > time may have been derived from rejecting stale requests that queue up when the neutron server is down? | 05:53 |
| sudipto | pretty new to this part of the code, and hence making a guess. | 05:54 |
| kevinbenton | sudipto: yes, that logic is just for skipping processing old records | 05:54 |
| kevinbenton | sudipto: not for detecting clock issues | 05:54 |
| sudipto | kevinbenton: The clocks being messed up would in general have multiple problems, not just for neutron but for compute etc. I could imagine a ceilometer metric query being fired from the server based on the server time and then the records being fetched would be inacurate since the time stored in the DB for metrics collected from the host would be different. | 05:55 |
| sudipto | kevinbenton: Your advice on whether this falls under a legit issue or becomes just a documentation? | 05:56 |
| kevinbenton | sudipto: does the behavior of the agent change with this new exception or does it just log it? | 05:56 |
| sudipto | kevinbenton: My issue with the current state of affairs was that, the agent seems to say - connected to AMQP on the agent side but it doesn't register to neutron because of that stale request check which is there. | 05:57 |
| *** yfried has quit IRC | 05:57 | |
| *** yfried has joined #openstack-neutron | 05:57 | |
| sudipto | kevinbenton: It doesn't change the agent behavior. It reports the error back to the agent log - that states that there's a timestamp issue. | 05:57 |
| kevinbenton | sudipto: right. so i'm fine with this patch because it warns the user about it | 05:58 |
| kevinbenton | sudipto: but doesn't try to do anything too smart to auto-magically adjust for it | 05:58 |
| kevinbenton | sudipto: so i think your fix is a good approach | 05:59 |
| kevinbenton | sudipto: i just want to separate it from the START_TIME | 05:59 |
| kevinbenton | sudipto: and check for the server clock being far behind as well | 05:59 |
| sudipto | kevinbenton: Yeah far from it. Just a error reporting for better debug, since i when i saw this, i kept wondering on what was actually the issue for a while. | 05:59 |
| kevinbenton | sudipto: because that has subtle side effects that are much less obvious than the agent being behind | 05:59 |
| sudipto | kevinbenton: That makes sense. | 05:59 |
| sudipto | kevinbenton: So i am guessing, that we should be putting the logic you have suggested in the comments and you would agree to that? | 06:00 |
| kevinbenton | sudipto: yep | 06:00 |
| sudipto | kevinbenton: Thank you for you time. I will make the change :) | 06:00 |
| sudipto | kevinbenton: Don't see any reason why the other cores shouldn't agree. | 06:01 |
| kevinbenton | sudipto: sounds good. send me a message on IRC when the patch is up | 06:01 |
| sudipto | kevinbenton: Will do. | 06:01 |
| kevinbenton | sudipto: yeah, i think they should be okay since it's just an additional warning when the agent starts up | 06:01 |
| sudipto | kevinbenton: Thank you! | 06:01 |
| *** trinaths has quit IRC | 06:02 | |
| *** shwetaap has quit IRC | 06:04 | |
| *** dims has joined #openstack-neutron | 06:04 | |
| sudipto | kevinbenton: just one nit. By branching on this, we allow a larger clock drift as the server runs longer. e.g. if the server has been running for a week, we wouldn't raise exceptions for agents with a clock behind by 6 days. -- I didn't quite understand this statement. My bad. | 06:04 |
| *** haleyb has joined #openstack-neutron | 06:04 | |
| sudipto | could you please explain with an example? | 06:05 |
| sudipto | kevinbenton: why we wouldn't raise an exception if the agent is 6 days behind? | 06:05 |
| *** yamahata has quit IRC | 06:06 | |
| *** yatin has joined #openstack-neutron | 06:06 | |
| kevinbenton | sudipto: because in the current version of the patch, you only get into that code if the server start time is greater than the agent time | 06:06 |
| kevinbenton | so server starts on Jan 1st | 06:07 |
| kevinbenton | a week goes by | 06:07 |
| kevinbenton | agent starts up with behind clock and reports in Jan 2nd as the time | 06:07 |
| kevinbenton | START_TIME will still be less than the agent time | 06:08 |
| kevinbenton | so none of your code would be triggered | 06:08 |
| kevinbenton | sudipto: does that make sense? | 06:08 |
| *** yfried has quit IRC | 06:09 | |
| *** haleyb has quit IRC | 06:09 | |
| kevinbenton | sudipto: that's why in the comment i moved the logic outside of the "if START_TIME > time:" check | 06:10 |
| *** dims has quit IRC | 06:10 | |
| *** achanda has quit IRC | 06:15 | |
| openstackgerrit | Itsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network https://review.openstack.org/161947 | 06:18 |
| *** _cjones_ has quit IRC | 06:20 | |
| *** Networkn3rd has quit IRC | 06:22 | |
| *** tflynn has quit IRC | 06:23 | |
| *** Networkn3rd has joined #openstack-neutron | 06:26 | |
| openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 06:29 |
| *** trinaths has joined #openstack-neutron | 06:35 | |
| *** yog__ has joined #openstack-neutron | 06:36 | |
| *** vishwanathj has quit IRC | 06:37 | |
| *** pcaruana has quit IRC | 06:41 | |
| *** chlong has quit IRC | 06:42 | |
| *** gildub has quit IRC | 06:42 | |
| *** lennyb has joined #openstack-neutron | 06:43 | |
| *** yfried has joined #openstack-neutron | 06:44 | |
| *** _cjones_ has joined #openstack-neutron | 06:47 | |
| openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Set ipsec connection to Error if peer fqdn can't be resolved https://review.openstack.org/166544 | 06:47 |
| *** itzikb has joined #openstack-neutron | 06:48 | |
| *** aranjan has quit IRC | 06:50 | |
| *** moshele has joined #openstack-neutron | 06:50 | |
| *** yfauser has joined #openstack-neutron | 06:50 | |
| *** lionelz has quit IRC | 06:51 | |
| *** yfauser has left #openstack-neutron | 06:51 | |
| *** Marga_ has joined #openstack-neutron | 06:52 | |
| *** irenab has quit IRC | 06:53 | |
| *** evgenyf has joined #openstack-neutron | 06:55 | |
| *** Bsony has joined #openstack-neutron | 06:57 | |
| *** yfried has quit IRC | 07:01 | |
| *** yfried_ has joined #openstack-neutron | 07:01 | |
| *** chlong has joined #openstack-neutron | 07:03 | |
| sudipto | kevinbenton: Sorry, i had to step away. Yeah that logic makes absolute sense to me, i was just thinking, why we should restrict the logic within a certain agent down time limit? | 07:03 |
| sudipto | kevinbenton: sorry, missed your entire comment. Reading :) | 07:03 |
| *** yfried_ is now known as yfried|afk | 07:03 | |
| sudipto | kevinbenton: Great catch :) | 07:04 |
| kevinbenton | sudipto: well we need to determine what range of time difference is acceptable | 07:04 |
| *** yfried|afk is now known as yfried_ | 07:05 | |
| sudipto | kevinbenton: Yeah. Understood it well now. Thx. | 07:05 |
| kevinbenton | sudipto: ok. i have to go now. so just leave me a message on IRC when the review is ready and i'll get it in the morning | 07:05 |
| *** haleyb has joined #openstack-neutron | 07:05 | |
| sudipto | kevinbenton: Sure. Thx a lot! | 07:05 |
| sudipto | kevinbenton: Btw, just re-reading the situation - if the server comes back up after a week, the START_TIME would be 8th of Jan and the agent would report let's say 2nd of Jan - then that case START_TIME would be greater than 2nd of Jan right? | 07:07 |
| sudipto | Sorry to hold you up, if you are still around... | 07:07 |
| *** akanksha has joined #openstack-neutron | 07:07 | |
| *** moshele has quit IRC | 07:07 | |
| sudipto | I thought self.START_TIME was going to report the START_TIME of the server. | 07:08 |
| kevinbenton | sudipto: no, the situation is where the server has been running for a week | 07:08 |
| kevinbenton | sudipto: and an agent is brought online for the first time | 07:08 |
| *** garyk has joined #openstack-neutron | 07:09 | |
| *** sbfox has quit IRC | 07:10 | |
| *** haleyb has quit IRC | 07:10 | |
| sudipto | kevinbenton: Ok. | 07:10 |
| *** killer_prince has joined #openstack-neutron | 07:13 | |
| *** _cjones_ has quit IRC | 07:13 | |
| *** aepifanov has joined #openstack-neutron | 07:14 | |
| *** lazy_prince has quit IRC | 07:14 | |
| *** killer_prince is now known as lazy_prince | 07:14 | |
| *** salv-orlando has joined #openstack-neutron | 07:16 | |
| *** _cjones_ has joined #openstack-neutron | 07:18 | |
| *** lazy_prince has quit IRC | 07:18 | |
| *** irenab has joined #openstack-neutron | 07:19 | |
| *** killer_prince has joined #openstack-neutron | 07:20 | |
| *** killer_prince is now known as lazy_prince | 07:20 | |
| *** annegentle has joined #openstack-neutron | 07:20 | |
| *** emagana has quit IRC | 07:22 | |
| *** emagana has joined #openstack-neutron | 07:22 | |
| *** lazy_prince has quit IRC | 07:25 | |
| *** annegentle has quit IRC | 07:25 | |
| *** yfried_ is now known as yfried|afk | 07:26 | |
| *** emagana has quit IRC | 07:27 | |
| *** tsg has quit IRC | 07:28 | |
| *** yamamoto has quit IRC | 07:29 | |
| *** atuvenie has joined #openstack-neutron | 07:29 | |
| *** lazy_prince has joined #openstack-neutron | 07:30 | |
| *** Networkn3rd has quit IRC | 07:31 | |
| *** Networkn3rd has joined #openstack-neutron | 07:32 | |
| *** Marga_ has quit IRC | 07:33 | |
| *** Marga_ has joined #openstack-neutron | 07:33 | |
| *** Networkn3rd has quit IRC | 07:34 | |
| *** bobmel_ has quit IRC | 07:34 | |
| *** yfried|afk is now known as yfried_ | 07:35 | |
| *** dsneddon has joined #openstack-neutron | 07:36 | |
| *** yog__ has quit IRC | 07:41 | |
| *** Bhavya has quit IRC | 07:41 | |
| *** Bhavya has joined #openstack-neutron | 07:41 | |
| *** yog__ has joined #openstack-neutron | 07:41 | |
| *** veena has quit IRC | 07:43 | |
| *** Networkn3rd has joined #openstack-neutron | 07:43 | |
| *** yamahata has joined #openstack-neutron | 07:45 | |
| *** yamahata has quit IRC | 07:46 | |
| *** ronis has joined #openstack-neutron | 07:48 | |
| *** flwang1 has joined #openstack-neutron | 07:48 | |
| *** Marga_ has quit IRC | 07:49 | |
| *** lykinsbd has joined #openstack-neutron | 07:51 | |
| *** dims has joined #openstack-neutron | 07:55 | |
| *** Networkn3rd has quit IRC | 07:55 | |
| *** hichihara has quit IRC | 07:56 | |
| *** lykinsbd has quit IRC | 07:56 | |
| *** yamahata has joined #openstack-neutron | 07:58 | |
| *** Longgeek_ has quit IRC | 07:58 | |
| *** Networkn3rd has joined #openstack-neutron | 07:59 | |
| *** ajo has quit IRC | 08:00 | |
| *** gildub has joined #openstack-neutron | 08:00 | |
| *** dims has quit IRC | 08:02 | |
| *** salv-orlando has quit IRC | 08:03 | |
| *** Networkn3rd has quit IRC | 08:05 | |
| *** Networkn3rd has joined #openstack-neutron | 08:05 | |
| *** halfss has joined #openstack-neutron | 08:06 | |
| *** haleyb has joined #openstack-neutron | 08:06 | |
| *** jyuso1 has joined #openstack-neutron | 08:08 | |
| *** yamamoto has joined #openstack-neutron | 08:09 | |
| openstackgerrit | Yaroslav Morkovnikov proposed openstack/neutron: Test IP allocation in two SLAAC subnets https://review.openstack.org/167129 | 08:09 |
| *** liusheng has joined #openstack-neutron | 08:10 | |
| *** haleyb has quit IRC | 08:11 | |
| *** Networkn3rd has quit IRC | 08:11 | |
| *** Networkn3rd has joined #openstack-neutron | 08:11 | |
| *** chlong has quit IRC | 08:12 | |
| *** veena has joined #openstack-neutron | 08:12 | |
| *** scheuran has joined #openstack-neutron | 08:13 | |
| *** _cjones_ has quit IRC | 08:15 | |
| *** pask81 has joined #openstack-neutron | 08:17 | |
| *** aranjan has joined #openstack-neutron | 08:17 | |
| *** yatin has quit IRC | 08:18 | |
| *** nmagnezi_ has joined #openstack-neutron | 08:18 | |
| *** yfried_ is now known as yfried|afk | 08:19 | |
| *** yfried|afk is now known as yfried_ | 08:20 | |
| *** annegentle has joined #openstack-neutron | 08:21 | |
| *** erkules_ is now known as erkules | 08:21 | |
| *** erkules has quit IRC | 08:21 | |
| *** erkules has joined #openstack-neutron | 08:21 | |
| *** yamahata has quit IRC | 08:22 | |
| *** aranjan has quit IRC | 08:22 | |
| *** pask81 has quit IRC | 08:23 | |
| *** lijianlj has joined #openstack-neutron | 08:24 | |
| *** yamamoto has quit IRC | 08:24 | |
| *** Networkn3rd has quit IRC | 08:24 | |
| *** annegentle has quit IRC | 08:26 | |
| *** rotbeard has joined #openstack-neutron | 08:27 | |
| *** lazy_prince has quit IRC | 08:28 | |
| *** killer_prince has joined #openstack-neutron | 08:28 | |
| *** killer_prince is now known as lazy_prince | 08:28 | |
| *** Networkn3rd has joined #openstack-neutron | 08:29 | |
| *** bobmel has joined #openstack-neutron | 08:29 | |
| *** yamamoto has joined #openstack-neutron | 08:30 | |
| *** apuimedo has joined #openstack-neutron | 08:31 | |
| *** apuimedo has quit IRC | 08:32 | |
| *** apuimedo has joined #openstack-neutron | 08:32 | |
| *** roeyc has joined #openstack-neutron | 08:33 | |
| *** blues-man has joined #openstack-neutron | 08:33 | |
| *** blues-man has joined #openstack-neutron | 08:33 | |
| *** ajo has joined #openstack-neutron | 08:34 | |
| *** Networkn3rd has quit IRC | 08:36 | |
| *** watanabe_isao has quit IRC | 08:40 | |
| *** safchain has joined #openstack-neutron | 08:40 | |
| openstackgerrit | enikanorov proposed openstack/neutron: Fix handling of before/after notifications in linuxbridge agent https://review.openstack.org/166931 | 08:41 |
| *** Bsony has quit IRC | 08:41 | |
| *** aepifanov has quit IRC | 08:42 | |
| *** Networkn3rd has joined #openstack-neutron | 08:43 | |
| *** yamamoto has quit IRC | 08:43 | |
| *** jpena has joined #openstack-neutron | 08:45 | |
| *** hitalia has quit IRC | 08:45 | |
| *** kickinz1|afk is now known as kickinz1 | 08:46 | |
| *** killer_prince has joined #openstack-neutron | 08:47 | |
| *** Networkn3rd has quit IRC | 08:47 | |
| *** lazy_prince has quit IRC | 08:47 | |
| *** killer_prince is now known as lazy_prince | 08:47 | |
| *** Networkn3rd has joined #openstack-neutron | 08:48 | |
| *** YorikSar has quit IRC | 08:49 | |
| *** nyechiel__ has joined #openstack-neutron | 08:50 | |
| *** liusheng has quit IRC | 08:52 | |
| *** salv-orlando has joined #openstack-neutron | 08:52 | |
| *** akamyshnikova has quit IRC | 08:53 | |
| *** Marga_ has joined #openstack-neutron | 08:53 | |
| *** lijianlj has quit IRC | 08:53 | |
| *** nyechiel__ has quit IRC | 08:55 | |
| *** nyechiel has joined #openstack-neutron | 08:55 | |
| *** jlanoux has joined #openstack-neutron | 08:57 | |
| *** Networkn3rd has quit IRC | 08:58 | |
| *** hichihara has joined #openstack-neutron | 08:59 | |
| *** ygbo has joined #openstack-neutron | 09:00 | |
| *** jistr has joined #openstack-neutron | 09:04 | |
| *** ygbo has quit IRC | 09:07 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define extract_ip helper function https://review.openstack.org/143811 | 09:08 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define extract_prefixlen helper function https://review.openstack.org/143812 | 09:08 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define get_cidr helper function https://review.openstack.org/143869 | 09:08 |
| *** ygbo has joined #openstack-neutron | 09:09 | |
| *** Networkn3rd has joined #openstack-neutron | 09:10 | |
| *** sbelous has quit IRC | 09:11 | |
| *** akamyshnikova has joined #openstack-neutron | 09:13 | |
| *** shaohe_feng has quit IRC | 09:15 | |
| *** dims has joined #openstack-neutron | 09:15 | |
| *** _cjones_ has joined #openstack-neutron | 09:16 | |
| *** nyechiel_ has joined #openstack-neutron | 09:16 | |
| *** nyechiel has quit IRC | 09:18 | |
| *** aranjan has joined #openstack-neutron | 09:19 | |
| *** moshele has joined #openstack-neutron | 09:19 | |
| *** dims has quit IRC | 09:20 | |
| ajo | ping kevinbenton :-) still awake ? :) | 09:20 |
| *** _cjones_ has quit IRC | 09:20 | |
| kevinbenton | ajo: just for a few more minutes | 09:20 |
| ajo | kevinbenton, I was trying to respond via gerrit (process monitor enable by default), but, gerrit is misbehaving again :( | 09:20 |
| kevinbenton | ajo: what's up? | 09:20 |
| ajo | http://www.fpaste.org/201942/27188776/ | 09:20 |
| *** lazy_prince has quit IRC | 09:20 | |
| ajo | I can either change the method names (which are confusing) or add more clear docstrings | 09:20 |
| ajo | what do you think? :) | 09:20 |
| ajo | or both :) | 09:21 |
| *** sbelous has joined #openstack-neutron | 09:21 | |
| *** Marga_ has quit IRC | 09:21 | |
| kevinbenton | ajo: oh, i understand now. it's not stopping the process | 09:21 |
| ajo | correct :) | 09:21 |
| kevinbenton | ajo: probably just update the docstring | 09:21 |
| *** killer_prince has joined #openstack-neutron | 09:22 | |
| ajo | may be monitor.stop is enough, right... | 09:22 |
| *** killer_prince is now known as lazy_prince | 09:22 | |
| ajo | let's put a decent docstring | 09:22 |
| kevinbenton | ajo: yeah | 09:22 |
| ajo | thanks for the review time!, | 09:22 |
| ajo | gongysh, ping | 09:22 |
| ajo | gongysh, I didn't understand your concern about the class variable | 09:22 |
| ajo | I didn't see any comment in the review, just about the exception capture. | 09:22 |
| *** aranjan has quit IRC | 09:23 | |
| *** jlanoux_ has joined #openstack-neutron | 09:23 | |
| *** YorikSar has joined #openstack-neutron | 09:23 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define extract_ip helper function https://review.openstack.org/143811 | 09:25 |
| *** trinaths has left #openstack-neutron | 09:25 | |
| *** jlanoux has quit IRC | 09:25 | |
| gongysh | ajo: class variable is a kind of global variable, which may be a racing resource. | 09:27 |
| ajo | gongysh, yes, but in this case it's only to stop a thread, | 09:27 |
| ajo | it's completely safe | 09:27 |
| *** yatin has joined #openstack-neutron | 09:27 | |
| ajo | ah, wait | 09:27 |
| ajo | let me think, it's the list of processes | 09:27 |
| ajo | I believe it's safe for the current usage, | 09:28 |
| ajo | as we stop on the tests tear down only, I could make it safer by iterating over a copy of the list | 09:29 |
| ajo | and be safer in any future usage | 09:29 |
| ajo | gongysh ^ | 09:29 |
| ajo | does it sound right? | 09:29 |
| *** imcsk8 is now known as imcsk8|zZz | 09:31 | |
| gongysh | sounds good | 09:31 |
| *** aepifanov has joined #openstack-neutron | 09:32 | |
| gongysh | but why does not previous stop in cleanup for each case work? | 09:34 |
| *** salv-orlando has quit IRC | 09:35 | |
| *** Bsony has joined #openstack-neutron | 09:38 | |
| *** garyk has quit IRC | 09:40 | |
| *** garyk has joined #openstack-neutron | 09:40 | |
| *** kerpan has joined #openstack-neutron | 09:40 | |
| *** criptoverso has joined #openstack-neutron | 09:41 | |
| *** lpetrut has joined #openstack-neutron | 09:41 | |
| *** ZZelle has quit IRC | 09:44 | |
| *** ZZelle has joined #openstack-neutron | 09:44 | |
| *** killer_prince has joined #openstack-neutron | 09:47 | |
| *** lazy_prince has quit IRC | 09:48 | |
| *** killer_prince is now known as lazy_prince | 09:48 | |
| *** yfauser has joined #openstack-neutron | 09:50 | |
| *** achanda has joined #openstack-neutron | 09:51 | |
| *** yfauser has left #openstack-neutron | 09:51 | |
| *** [1]evgenyf has joined #openstack-neutron | 09:52 | |
| *** evgenyf has quit IRC | 09:55 | |
| *** [1]evgenyf is now known as evgenyf | 09:55 | |
| openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Enable Process Monitor by default. https://review.openstack.org/165117 | 09:55 |
| ajo | gongysh, kevinbenton ^ | 09:56 |
| *** achanda has quit IRC | 09:56 | |
| ajo | gongysh, basically, in functional test, that works, | 09:56 |
| ajo | gongysh, but in unit testing, there are lots of test that rely on creating agent objects, that then create process monitors | 09:56 |
| *** lazy_prince has quit IRC | 09:57 | |
| ajo | gongysh, I could patch each one individually, but, later in time people could inadvertely reintroduce the issue, so I guess it's better to protect in the long term | 09:57 |
| ajo | making sure any test cleans ups any created process monitor. | 09:57 |
| ajo | cleans up | 09:57 |
| ajo | :D | 09:57 |
| *** killer_prince has joined #openstack-neutron | 09:58 | |
| *** killer_prince is now known as lazy_prince | 09:58 | |
| *** nyechiel_ has quit IRC | 10:00 | |
| *** nyechiel_ has joined #openstack-neutron | 10:00 | |
| openstackgerrit | Darragh O'Reilly proposed openstack/neutron: Fix port status not being updated properly https://review.openstack.org/165351 | 10:01 |
| *** popw1 has quit IRC | 10:02 | |
| ajo | kevinbenton, aren't you getting 503 errors from gerrit? | 10:02 |
| ajo | I hope they fix it soon... or it's going to slow down the end of the cycle :( | 10:02 |
| kevinbenton | ajo: when? | 10:03 |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Improve error detection on agent registration https://review.openstack.org/165539 | 10:03 |
| ajo | kevinbenton, for me, most of the time, when I try to reply... | 10:03 |
| ajo | I get... | 10:03 |
| ajo | 503: The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later. | 10:03 |
| sudipto | kevinbenton: https://review.openstack.org/165539 the fix addressing your comment is in. | 10:03 |
| kevinbenton | ajo: hmm, i haven't hit any yet | 10:04 |
| kevinbenton | sudipto: thanks | 10:04 |
| ajo | kevinbenton, doesn't happen if you try to open: https://review.openstack.org/#/c/165117/ ? | 10:04 |
| kevinbenton | ajo: nope. and i +2'ed without an issue | 10:05 |
| *** ihrachyshka has joined #openstack-neutron | 10:05 | |
| ajo | kevinbenton: http://www.fpaste.org/201965/14271915/ | 10:06 |
| ajo | gerrit hates me | 10:06 |
| *** Networkn3rd has quit IRC | 10:07 | |
| *** alex_xu has joined #openstack-neutron | 10:07 | |
| kevinbenton | ajo: yeah, no idea why you're getting that | 10:10 |
| kevinbenton | ajo: maybe your IP got rate-limited :) | 10:10 |
| ajo | kevinbenton, I don't use gerrty lately, my normal interaction is not so much :) | 10:10 |
| ajo | gertty | 10:11 |
| ajo | I wonder if it's an IPv6 issue | 10:11 |
| kevinbenton | ajo: oh, maybe | 10:11 |
| kevinbenton | ajo: i'm on a v4 connection | 10:11 |
| ajo | I will switch IPv6 off next time I see it, and text | 10:11 |
| ajo | test | 10:11 |
| ajo | :D | 10:11 |
| ajo | I have a funny day with typing... | 10:11 |
| *** Networkn3rd has joined #openstack-neutron | 10:12 | |
| ajo | kevinbenton, I suspect the IP end should be transparent but... | 10:12 |
| kevinbenton | ajo: leaky abstractions :) | 10:12 |
| ajo | :) | 10:12 |
| sudipto | obondarev: Do you agree with the changes in https://review.openstack.org/165539 ? | 10:14 |
| obondarev | sudipto: let me see | 10:15 |
| *** Networkn3rd has quit IRC | 10:16 | |
| *** Networkn3rd has joined #openstack-neutron | 10:17 | |
| sudipto | obondarev: thx. | 10:17 |
| *** _cjones_ has joined #openstack-neutron | 10:17 | |
| *** dims has joined #openstack-neutron | 10:19 | |
| *** aranjan has joined #openstack-neutron | 10:19 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define extract_prefixlen helper function https://review.openstack.org/143812 | 10:20 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Define get_cidr helper function https://review.openstack.org/143869 | 10:20 |
| openstackgerrit | Sam Betts proposed openstack/neutron: Add an internal DHCPv6 client for Prefix Delegation https://review.openstack.org/161381 | 10:21 |
| *** _cjones_ has quit IRC | 10:22 | |
| *** Networkn_ has joined #openstack-neutron | 10:25 | |
| *** Networkn3rd has quit IRC | 10:26 | |
| *** markvoelker has quit IRC | 10:26 | |
| *** rook_ has joined #openstack-neutron | 10:26 | |
| halfss | Hi, is there any body use neutron+dev in production env? | 10:26 |
| halfss | neutron+dvr | 10:26 |
| *** veena has quit IRC | 10:31 | |
| *** salv-orlando has joined #openstack-neutron | 10:31 | |
| sudipto | kenvinbenton: If i move the two lines: | 10:33 |
| sudipto | time_agent = timeutils.isotime(time) | 10:33 |
| sudipto | time_server = timeutils.isotime(self.START_TIME) | 10:33 |
| *** Bsony_ has joined #openstack-neutron | 10:34 | |
| sudipto | inside the if block, then I'd have to access them again in the LOG.debug change that you have suggested. Do you agree? | 10:34 |
| *** Bsony has quit IRC | 10:35 | |
| sudipto | kevinbenton: That maybe repetitive, but adds some sort of optimization... | 10:37 |
| sudipto | kevinbenton: But given that there's already a check to see the agent start_flag - I am guessing the optimization achieved would be very nominal. | 10:38 |
| *** txomon|fon has quit IRC | 10:38 | |
| openstackgerrit | Davide Michelino proposed openstack/neutron-specs: Initial commit of the specs of a port-forwarding extension for the neutron router. https://review.openstack.org/167165 | 10:42 |
| *** rook_ has quit IRC | 10:44 | |
| openstackgerrit | Martin Kletzander proposed openstack/neutron: Fix common misspellings https://review.openstack.org/166832 | 10:44 |
| *** chandankumar_ has joined #openstack-neutron | 10:44 | |
| *** yfried_ is now known as yfried|afk | 10:45 | |
| *** chandankumar has quit IRC | 10:46 | |
| *** Networkn_ has quit IRC | 10:46 | |
| *** Bsony has joined #openstack-neutron | 10:46 | |
| *** Bsony has quit IRC | 10:47 | |
| *** Bsony_ has quit IRC | 10:48 | |
| *** lori|away is now known as lori | 10:48 | |
| *** pc_m has joined #openstack-neutron | 10:50 | |
| *** yuanying has quit IRC | 10:51 | |
| *** txomon|fon has joined #openstack-neutron | 10:51 | |
| kevinbenton | sudipto: oh, if you do share the variables below, with the other debug statement, don't repeat them | 10:52 |
| kevinbenton | sudipto: you are right that the optimization won't be worth it | 10:52 |
| *** Bsony has joined #openstack-neutron | 10:52 | |
| sudipto | kevinbenton: Ok. | 10:52 |
| sudipto | kevinbenton: I actually thought it might be, since we would call this only during a agent's startup coz of the if block. If i have to use it at one place, I will have to move them above the first if block. This would mean, that it gets called everytime the report_state is called. | 10:53 |
| *** stanzgy has quit IRC | 10:53 | |
| sudipto | kevinbenton: So the repeat maybe worth it? | 10:53 |
| *** aranjan has quit IRC | 10:54 | |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Add clock sync error detection on agent registration https://review.openstack.org/165539 | 10:55 |
| *** Networkn3rd has joined #openstack-neutron | 10:55 | |
| sudipto | kevinbenton: Could you take a look at https://review.openstack.org/165539 when you can. I may have addressed your comments. | 10:56 |
| *** yfried|afk is now known as yfried_ | 10:56 | |
| *** Bsony_ has joined #openstack-neutron | 10:57 | |
| kevinbenton | sudipto: a million executions of isotime in 1.7 seconds | 10:59 |
| kevinbenton | >>> timeit.timeit("timeutils.isotime(time)", setup="from oslo_utils import timeutils; time=timeutils.utcnow()") | 10:59 |
| kevinbenton | 1.8193411827087402 | 10:59 |
| kevinbenton | sudipto: 1.8 seconds | 10:59 |
| kevinbenton | sudipto: i don't think that is a performance bottleneck to worry about now | 10:59 |
| *** Bsony has quit IRC | 10:59 | |
| sudipto | kevinbenton: So, i avoid the repeat and move the isotime calls above? | 11:00 |
| sudipto | kevinbenton: Then it would get called for every report_state() call. Is that ok? | 11:00 |
| kevinbenton | sudipto: actually just leave it the way it is for now | 11:01 |
| sudipto | kevinbenton: Ok :) | 11:01 |
| kevinbenton | sudipto: it keeps the two nicely separated | 11:01 |
| sudipto | kevinbenton: And some sort of optimization . | 11:01 |
| kevinbenton | sudipto: yeah | 11:01 |
| *** Bsony_ has quit IRC | 11:02 | |
| *** Bsony has joined #openstack-neutron | 11:05 | |
| openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 11:07 |
| openstackgerrit | John Davidge proposed openstack/neutron: Add the default_ipv6_subnet_pool config option https://review.openstack.org/166973 | 11:07 |
| *** txomon|fon has quit IRC | 11:09 | |
| *** pask81 has joined #openstack-neutron | 11:10 | |
| pc_m | pcm | 11:10 |
| *** hichihara has quit IRC | 11:11 | |
| *** Bsony_ has joined #openstack-neutron | 11:13 | |
| *** shaohe_feng has joined #openstack-neutron | 11:14 | |
| sudipto | gongysh: Can I live with that comment on https://review.openstack.org/165539 - or you'd make that a strict change i should make? | 11:16 |
| *** Bsony has quit IRC | 11:16 | |
| *** SridharG has left #openstack-neutron | 11:17 | |
| *** Bsony_ has quit IRC | 11:18 | |
| *** _cjones_ has joined #openstack-neutron | 11:18 | |
| *** _cjones_ has quit IRC | 11:23 | |
| *** txomon|fon has joined #openstack-neutron | 11:24 | |
| *** markvoelker has joined #openstack-neutron | 11:26 | |
| *** john-davidge has joined #openstack-neutron | 11:26 | |
| *** jlanoux has joined #openstack-neutron | 11:28 | |
| *** Networkn3rd has quit IRC | 11:29 | |
| *** Networkn3rd has joined #openstack-neutron | 11:30 | |
| *** jlanoux_ has quit IRC | 11:31 | |
| *** Bsony has joined #openstack-neutron | 11:31 | |
| *** markvoelker has quit IRC | 11:31 | |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Add clock sync error detection on agent registration https://review.openstack.org/165539 | 11:32 |
| sudipto | kevinbenton: Addressed a minor nit from gongysh, | 11:33 |
| sudipto | kevinbenton: Would really appreciate if you could take a look. | 11:33 |
| sudipto | gongysh: you too please! | 11:33 |
| *** Networkn_ has joined #openstack-neutron | 11:35 | |
| *** Networkn3rd has quit IRC | 11:36 | |
| *** Bsony has quit IRC | 11:36 | |
| *** flaviof has quit IRC | 11:37 | |
| *** shaohe_feng has quit IRC | 11:41 | |
| *** banix has joined #openstack-neutron | 11:43 | |
| *** jamielennox is now known as jamielennox|away | 11:45 | |
| *** kendriu has joined #openstack-neutron | 11:46 | |
| *** salv-orlando has quit IRC | 11:46 | |
| *** jlanoux_ has joined #openstack-neutron | 11:47 | |
| *** halfss has quit IRC | 11:48 | |
| kendriu | hi. I have question: When writing ML2 Mech Driver which architecture I should use - agent or agentless. Is there any good indicator? Maybe someone have good article about this? | 11:48 |
| *** flwang1 has quit IRC | 11:49 | |
| *** aranjan has joined #openstack-neutron | 11:50 | |
| kendriu | "Good practice" advice would be also nice. | 11:50 |
| *** jlanoux has quit IRC | 11:50 | |
| *** banix has quit IRC | 11:53 | |
| *** ronis has quit IRC | 11:55 | |
| *** ronis has joined #openstack-neutron | 11:55 | |
| *** Networkn_ has quit IRC | 11:56 | |
| *** xuhanp has joined #openstack-neutron | 11:58 | |
| *** xuhanp_ has joined #openstack-neutron | 11:58 | |
| *** markvoelker has joined #openstack-neutron | 11:58 | |
| *** jpena is now known as jpena|lunch | 12:05 | |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Add clock sync error detection on agent registration https://review.openstack.org/165539 | 12:05 |
| *** atuvenie has quit IRC | 12:06 | |
| *** jaypipes has quit IRC | 12:06 | |
| *** jaypipes has joined #openstack-neutron | 12:07 | |
| *** boris-42 has joined #openstack-neutron | 12:07 | |
| *** Bsony has joined #openstack-neutron | 12:09 | |
| *** yfried_ is now known as yfried|afk | 12:09 | |
| *** trinaths has joined #openstack-neutron | 12:10 | |
| *** yamamoto has joined #openstack-neutron | 12:11 | |
| *** chlong has joined #openstack-neutron | 12:12 | |
| *** sudipto has quit IRC | 12:12 | |
| *** Networkn3rd has joined #openstack-neutron | 12:12 | |
| *** atuvenie has joined #openstack-neutron | 12:14 | |
| *** yfried|afk is now known as yfried_ | 12:15 | |
| *** ZZelle has quit IRC | 12:15 | |
| *** chlong has quit IRC | 12:15 | |
| *** dims has quit IRC | 12:15 | |
| *** ZZelle has joined #openstack-neutron | 12:15 | |
| *** dims has joined #openstack-neutron | 12:16 | |
| *** txomon|fon has quit IRC | 12:18 | |
| *** chandankumar_ has quit IRC | 12:18 | |
| *** _cjones_ has joined #openstack-neutron | 12:19 | |
| *** evgenyf has quit IRC | 12:19 | |
| *** evgenyf has joined #openstack-neutron | 12:19 | |
| *** Bsony has quit IRC | 12:20 | |
| *** _cjones_ has quit IRC | 12:23 | |
| *** salv-orlando has joined #openstack-neutron | 12:24 | |
| *** aranjan has quit IRC | 12:25 | |
| *** blues-man has quit IRC | 12:25 | |
| *** banix has joined #openstack-neutron | 12:27 | |
| *** dane_leblanc has joined #openstack-neutron | 12:28 | |
| *** banix has quit IRC | 12:28 | |
| *** pask81 has quit IRC | 12:29 | |
| *** yfried_ is now known as yfried|afk | 12:29 | |
| *** jckasper has quit IRC | 12:29 | |
| *** jistr is now known as jistr|class | 12:30 | |
| *** yfried|afk is now known as yfried_ | 12:30 | |
| *** txomon|fon has joined #openstack-neutron | 12:30 | |
| *** banix has joined #openstack-neutron | 12:31 | |
| *** chlong has joined #openstack-neutron | 12:32 | |
| *** flaviof has joined #openstack-neutron | 12:33 | |
| *** johnbelamaric has joined #openstack-neutron | 12:33 | |
| *** dave-mccowan has joined #openstack-neutron | 12:34 | |
| *** chlong has quit IRC | 12:35 | |
| *** irenab has quit IRC | 12:36 | |
| *** ishant has quit IRC | 12:36 | |
| *** chlong has joined #openstack-neutron | 12:36 | |
| *** ChuckC has quit IRC | 12:37 | |
| *** chlong has quit IRC | 12:39 | |
| *** Marga_ has joined #openstack-neutron | 12:42 | |
| openstackgerrit | Pavel Bondar proposed openstack/neutron: Implement IPAM Driver loader https://review.openstack.org/147479 | 12:43 |
| *** Miouge has joined #openstack-neutron | 12:44 | |
| *** gildub has quit IRC | 12:47 | |
| *** yamamoto has quit IRC | 12:48 | |
| *** jpena|lunch is now known as jpena | 12:49 | |
| *** yfried_ is now known as yfried|afk | 12:51 | |
| *** yfried|afk is now known as yfried_ | 12:51 | |
| *** Networkn3rd has quit IRC | 12:55 | |
| *** chlong has joined #openstack-neutron | 12:56 | |
| *** yatin has quit IRC | 12:56 | |
| *** chandankumar has joined #openstack-neutron | 12:57 | |
| *** trinaths has quit IRC | 12:57 | |
| *** ferest has joined #openstack-neutron | 12:57 | |
| *** matrohon has joined #openstack-neutron | 12:58 | |
| openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Refactoring to use callback mechanism https://review.openstack.org/165226 | 12:59 |
| *** ChuckC has joined #openstack-neutron | 13:01 | |
| *** julim has joined #openstack-neutron | 13:01 | |
| *** thomasem has quit IRC | 13:02 | |
| openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 13:04 |
| *** salv-orlando has quit IRC | 13:04 | |
| *** Miouge has quit IRC | 13:04 | |
| *** Miouge has joined #openstack-neutron | 13:05 | |
| *** Miouge has quit IRC | 13:05 | |
| openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 13:05 |
| *** changbl has quit IRC | 13:06 | |
| *** amotoki has quit IRC | 13:09 | |
| openstackgerrit | Sandhya Dasu proposed openstack/neutron: Cisco UCS Manager ML2 Mechanism Driver https://review.openstack.org/155436 | 13:09 |
| *** salv-orlando has joined #openstack-neutron | 13:09 | |
| *** ferest has quit IRC | 13:10 | |
| *** nplanel_ has joined #openstack-neutron | 13:12 | |
| *** amotoki has joined #openstack-neutron | 13:12 | |
| openstackgerrit | Romil Gupta proposed openstack/neutron: Use first() instead of one() in tunnel endpoint query https://review.openstack.org/166947 | 13:13 |
| *** diegows has joined #openstack-neutron | 13:13 | |
| ajo | garyk, I have a split patch as per ihrachyshka request for: https://review.openstack.org/#/c/165117/ | 13:13 |
| ajo | are we still in time to resubmit? | 13:14 |
| ajo | I guess it didn't merge since you just put the +A, | 13:14 |
| ajo | I just need to run git review... and then wait for jenkins againm | 13:14 |
| ihrachyshka | ajo, nah, if we got +A, screw it | 13:14 |
| ajo | but it's ready anyway if we want the split/changes :D | 13:14 |
| *** thomasem has joined #openstack-neutron | 13:14 | |
| ajo | ihrachyshka, ack, ok, if gate gets mad for some reason and -1's, I'll submit it | 13:14 |
| garyk | ajo: i have approved - if you want to split then please push now before the gate competes | 13:15 |
| garyk | ihrachyshka: please set a -1 if you have comments | 13:15 |
| ihrachyshka | garyk, I didn't feel those comments are worth blocking the patch, so no -1 | 13:15 |
| ajo | garyk, they were nits, probably he didn't want to hold for nits | 13:15 |
| *** yfried__ has joined #openstack-neutron | 13:15 | |
| garyk | ihrachyshka: ok, thanks | 13:15 |
| ajo | thank you both guys, | 13:15 |
| garyk | ajo: i guess you can fix them in a follow up patch, | 13:15 |
| *** doude has quit IRC | 13:16 | |
| ajo | ok, let's push it, let's have a cleaner history. | 13:16 |
| ajo | I can do it right now | 13:16 |
| garyk | FYI - if you want to stop the gate just update the commit message | 13:16 |
| *** yfried_ has quit IRC | 13:16 | |
| ajo | I will git review in a second | 13:16 |
| ajo | passing pep8 locally... | 13:16 |
| ajo | it was a clean split | 13:16 |
| ajo | some files went to a patch, some to a different one | 13:17 |
| openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Enable Process Monitor by default. https://review.openstack.org/165117 | 13:18 |
| openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Stop any spawned ProcessMonitor at test cleanup. https://review.openstack.org/167207 | 13:18 |
| ajo | garyk , ihrachyshka ^ | 13:20 |
| *** _cjones_ has joined #openstack-neutron | 13:20 | |
| *** aranjan has joined #openstack-neutron | 13:20 | |
| *** Marga_ has quit IRC | 13:21 | |
| *** lukasa has quit IRC | 13:21 | |
| *** zzzeek has joined #openstack-neutron | 13:21 | |
| garyk | ajo: thanks! | 13:21 |
| *** yfried__ has quit IRC | 13:22 | |
| *** yfried__ has joined #openstack-neutron | 13:22 | |
| *** jpena has quit IRC | 13:23 | |
| *** salv-orl_ has joined #openstack-neutron | 13:24 | |
| *** _cjones_ has quit IRC | 13:25 | |
| *** jpena has joined #openstack-neutron | 13:25 | |
| *** Bhavya has quit IRC | 13:25 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 13:26 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: Add eventlet monkey_patch helper https://review.openstack.org/167214 | 13:26 |
| *** lpetrut has quit IRC | 13:26 | |
| *** jckasper has joined #openstack-neutron | 13:27 | |
| *** salv-orlando has quit IRC | 13:27 | |
| *** lpetrut has joined #openstack-neutron | 13:27 | |
| *** salv-orlando has joined #openstack-neutron | 13:28 | |
| *** amuller has joined #openstack-neutron | 13:29 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 13:30 |
| *** kbringard has joined #openstack-neutron | 13:30 | |
| *** baoli has joined #openstack-neutron | 13:30 | |
| *** salv-orl_ has quit IRC | 13:32 | |
| *** ChuckC has quit IRC | 13:32 | |
| *** dane_leblanc has quit IRC | 13:32 | |
| *** banix has quit IRC | 13:33 | |
| *** jckasper has quit IRC | 13:34 | |
| *** chandankumar has quit IRC | 13:35 | |
| *** claudiub has joined #openstack-neutron | 13:35 | |
| *** Bsony has joined #openstack-neutron | 13:35 | |
| *** rpothier has joined #openstack-neutron | 13:35 | |
| *** dboik has joined #openstack-neutron | 13:38 | |
| *** dboik has quit IRC | 13:38 | |
| *** dboik has joined #openstack-neutron | 13:39 | |
| *** chandankumar has joined #openstack-neutron | 13:41 | |
| *** lazy_prince is now known as killer_prince | 13:41 | |
| *** armax has joined #openstack-neutron | 13:42 | |
| *** yamamoto has joined #openstack-neutron | 13:43 | |
| *** yfried__ has quit IRC | 13:44 | |
| *** r-daneel has joined #openstack-neutron | 13:44 | |
| *** yapeng has joined #openstack-neutron | 13:45 | |
| *** jckasper has joined #openstack-neutron | 13:45 | |
| *** cbouch has joined #openstack-neutron | 13:45 | |
| *** mwagner_lap has quit IRC | 13:46 | |
| *** tiswanso has joined #openstack-neutron | 13:46 | |
| atuvenie | amotoki: I split https://review.openstack.org/#/c/160596/ into two for now. A monkey patch one on top of which I rebased the rest. I will change it even further without a problem, just give me an indication as to how to proceed | 13:46 |
| *** nfedotov has joined #openstack-neutron | 13:51 | |
| *** shwetaap has joined #openstack-neutron | 13:52 | |
| *** amrith has left #openstack-neutron | 13:53 | |
| *** jistr|class is now known as jistr | 13:53 | |
| ihrachyshka | atuvenie, for the first thing, I think code moves into common/... could be split apart? | 13:53 |
| *** aranjan has quit IRC | 13:54 | |
| *** xgerman has joined #openstack-neutron | 13:55 | |
| *** doude has joined #openstack-neutron | 13:55 | |
| *** achanda has joined #openstack-neutron | 13:55 | |
| *** dane_leblanc has joined #openstack-neutron | 13:56 | |
| *** jpena_ has joined #openstack-neutron | 13:57 | |
| *** pritesh has joined #openstack-neutron | 13:57 | |
| atuvenie | ihrachyshka: you mean a separate patch for each movement? | 13:58 |
| *** yamahata has joined #openstack-neutron | 13:58 | |
| amotoki | ihrachyshka: atuvenie: I am sure I got your point. could you elaborate more? | 13:58 |
| amotoki | atuvenie: looking the second one. I am still exploring how to reduce the size of the change. | 13:58 |
| ihrachyshka | atuvenie, amotoki: well, maybe not a patch per move, but just split the simple moves to make it easier to grasp and concentrate on non-obvious changes. | 13:59 |
| *** baoli has quit IRC | 13:59 | |
| amotoki | ihrachyshka: agree. we can split it into two parts: the first one moves ovs-agent to cmd/eventlet and the second one introduces support of hyper-v monkey-patch. right? | 14:00 |
| ihrachyshka | amotoki, nah, that's already done, no? | 14:00 |
| *** baoli has joined #openstack-neutron | 14:00 | |
| *** jpena has quit IRC | 14:00 | |
| *** achanda has quit IRC | 14:00 | |
| *** dboik_ has joined #openstack-neutron | 14:00 | |
| ihrachyshka | amotoki, I referred to eg. code from neutron/agent/linux/ovs_lib.py moving into neutron/agent/common/ovs_lib.py | 14:00 |
| amotoki | ihrachyshka: ah... sorry I misunderstood :-( | 14:01 |
| *** nmagnezi_ has quit IRC | 14:01 | |
| amotoki | ihrachyshka: I thought the first one refers eventlet monkey-patch one... | 14:02 |
| ihrachyshka | amotoki, only that split will shrink the actual patch in more than half in size | 14:02 |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Add some useful notes in devref/db_layer.rst https://review.openstack.org/167233 | 14:02 |
| ihrachyshka | amotoki, no, eventlet seems to be good enough. of course we could split it even more, but no huge benefit from that | 14:03 |
| atuvenie | amotoki: ihrachyshka: the moving of ovs_lib + placeholder for backwards compatibility one | 14:03 |
| atuvenie | amotoki: ihrachyshka: could be one patch | 14:03 |
| *** julim has quit IRC | 14:03 | |
| *** lpetrut has quit IRC | 14:03 | |
| *** dboik has quit IRC | 14:04 | |
| ihrachyshka | atuvenie, similar for polling? | 14:04 |
| atuvenie | amotoki: ihrachyshka: and the polling + utils could be another one? Since that introduces specific windows changes | 14:04 |
| atuvenie | or should polling and utils be separate as well? | 14:04 |
| *** jpena_ is now known as jpena | 14:04 | |
| ihrachyshka | atuvenie, I would be ok with just a single patch for all moves actually | 14:04 |
| ihrachyshka | atuvenie, but you decide | 14:04 |
| ihrachyshka | more pieces are fine to review (though harder to push thru gate) | 14:05 |
| *** julien_ZTE has joined #openstack-neutron | 14:05 | |
| *** carl_baldwin has joined #openstack-neutron | 14:06 | |
| *** julim has joined #openstack-neutron | 14:06 | |
| *** zhipeng has joined #openstack-neutron | 14:07 | |
| openstackgerrit | Yaroslav Morkovnikov proposed openstack/neutron: Test IP allocation in two SLAAC subnets https://review.openstack.org/167129 | 14:07 |
| *** lukasa has joined #openstack-neutron | 14:08 | |
| *** localloop127 has joined #openstack-neutron | 14:09 | |
| *** chandankumar has quit IRC | 14:09 | |
| atuvenie | ihrachyshka: wait, I'm confused now should I split https://review.openstack.org/#/c/160596/ or not? :) If I split ovs_lib move from utils + polling move that would result in two patches of about 4-500 lines. I would go with that, it makes things a little clearer | 14:11 |
| ihrachyshka | atuvenie, yes, I would split out moves from that patch into single separate patch | 14:11 |
| ihrachyshka | atuvenie, but you can go further and split that one into more pieces if you like | 14:12 |
| *** jprovazn has joined #openstack-neutron | 14:14 | |
| *** ajmiller has joined #openstack-neutron | 14:16 | |
| *** nmagnezi_ has joined #openstack-neutron | 14:16 | |
| *** atuvenie has quit IRC | 14:18 | |
| *** _cjones_ has joined #openstack-neutron | 14:21 | |
| *** lpetrut has joined #openstack-neutron | 14:24 | |
| *** aepifanov has quit IRC | 14:25 | |
| *** aepifanov has joined #openstack-neutron | 14:25 | |
| *** _cjones_ has quit IRC | 14:25 | |
| *** fredlhsu has joined #openstack-neutron | 14:29 | |
| *** lori is now known as lori|away | 14:30 | |
| *** achanda has joined #openstack-neutron | 14:32 | |
| *** banix_ has joined #openstack-neutron | 14:34 | |
| *** yfried__ has joined #openstack-neutron | 14:36 | |
| *** jprovazn has quit IRC | 14:36 | |
| *** banix_ is now known as banix | 14:36 | |
| *** akanksha has quit IRC | 14:37 | |
| *** tflynn has joined #openstack-neutron | 14:38 | |
| *** yfried__ has quit IRC | 14:38 | |
| *** jprovazn has joined #openstack-neutron | 14:38 | |
| *** tflynn has quit IRC | 14:38 | |
| *** crose has joined #openstack-neutron | 14:38 | |
| *** lpetrut has quit IRC | 14:38 | |
| *** yfried__ has joined #openstack-neutron | 14:39 | |
| *** tflynn has joined #openstack-neutron | 14:39 | |
| *** prad has joined #openstack-neutron | 14:39 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Simplify keepalived.virtual_routes https://review.openstack.org/160430 | 14:41 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Add extra subnet route to ha router https://review.openstack.org/159772 | 14:41 |
| *** reed has joined #openstack-neutron | 14:41 | |
| nfedotov | Hello All! Does anybody know a job name that runs tests located neutron\tests\tempest ? A job in the check pipeline | 14:41 |
| *** mwagner_lap has joined #openstack-neutron | 14:42 | |
| *** achanda has quit IRC | 14:42 | |
| amuller | nfedotov: check-neutron-dsvm-api | 14:42 |
| nfedotov | Thank you! | 14:43 |
| *** lpetrut has joined #openstack-neutron | 14:45 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Deprecate use_namespaces option https://review.openstack.org/166888 | 14:46 |
| amuller | carl_baldwin: Good morning | 14:47 |
| *** yapeng has quit IRC | 14:48 | |
| *** Networkn3rd has joined #openstack-neutron | 14:49 | |
| *** nmagnezi_ has quit IRC | 14:49 | |
| *** thedodd has joined #openstack-neutron | 14:50 | |
| *** padkrish has joined #openstack-neutron | 14:50 | |
| *** aranjan has joined #openstack-neutron | 14:50 | |
| *** EmilienM|PTO is now known as EmilienM | 14:51 | |
| openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 14:51 |
| amuller | carl_baldwin: Left a comment on https://review.openstack.org/#/c/140863/ | 14:51 |
| *** annegentle has joined #openstack-neutron | 14:51 | |
| carl_baldwin | amuller: thanks. | 14:52 |
| *** padkrish has quit IRC | 14:52 | |
| carl_baldwin | amuller: We need to get to the bottom of this. | 14:53 |
| *** lpetrut has quit IRC | 14:54 | |
| carl_baldwin | amuller: btw, your patch is next up in the refactoring. Needs a rebase (https://review.openstack.org/#/c/160608) | 14:54 |
| amuller | carl_baldwin: oh yay :) | 14:54 |
| *** itzikb has quit IRC | 14:56 | |
| *** jobewan has joined #openstack-neutron | 14:56 | |
| *** lukasa has quit IRC | 14:56 | |
| *** aranjan has quit IRC | 14:57 | |
| carl_baldwin | amuller: Then, I guess I need to polish up mine which follows yours. :) | 14:57 |
| amuller | carl_baldwin: I'll have to remember what on earth I did there | 14:58 |
| *** leenheer has joined #openstack-neutron | 14:58 | |
| carl_baldwin | amuller: I gave the rebase a quick try. It wasn’t really trivial. | 14:58 |
| amuller | carl_baldwin: OK I'll do that today | 14:58 |
| anteaya | marun: thanks | 15:00 |
| marun | anteaya: it's possible to run the tests from neutron already | 15:00 |
| *** neiljerr` has left #openstack-neutron | 15:00 | |
| anteaya | okay | 15:00 |
| anteaya | is there any documentation I can point them to? | 15:00 |
| *** luqas_ has joined #openstack-neutron | 15:00 | |
| anteaya | when they ask me | 15:00 |
| marun | anteaya: not yet | 15:00 |
| anteaya | great | 15:00 |
| marun | anteaya: it's as simple as 'tox -eapi' on the same node that can run tempest | 15:00 |
| anteaya | any eta on something pointable? | 15:00 |
| *** ChuckC has joined #openstack-neutron | 15:00 | |
| anteaya | I'll point them to this log then | 15:00 |
| anteaya | thanks | 15:00 |
| pc_m | armax: ping | 15:01 |
| anteaya | luqas_: run tempest and then 'tox -eapi' after that | 15:01 |
| marun | anteaya: with the caveat that if they aren't using devstack, it would be 'TEMPEST_CONFIG_DIR=/path/to/dir/containing/tempest.conf tox -eapi' | 15:01 |
| *** raildo|away is now known as raildo | 15:01 | |
| anteaya | marun: wonderful | 15:01 |
| anteaya | thank you | 15:01 |
| marun | anteaya: but the devstack default path is assumed if not provided | 15:01 |
| anteaya | cool | 15:01 |
| luqas_ | anteaya: marun: thanks | 15:02 |
| marun | np | 15:02 |
| marun | will add to TESTING.rst shortly | 15:02 |
| anteaya | luqas_: you're good then? | 15:02 |
| anteaya | marun: thanks care to ping luqas_ and I when you do so we can review? | 15:02 |
| luqas_ | anteaya: good to test :) | 15:02 |
| dougwig | anteaya: it's further complicated/simplified in that when we shortly move the *aas tests, you can just run the entire suite for the relevant repos, instead of the piecemeal regex's people use now. | 15:02 |
| marun | anteaya: will do | 15:02 |
| anteaya | luqas_: great, thanks for being proactive on this, you are doing a wonderful job, keep it up | 15:03 |
| marun | dougwig: right... I'm hoping it can be tox -eapi at least for everyone | 15:03 |
| *** mlavalle has joined #openstack-neutron | 15:03 | |
| luqas_ | anteaya: thanks | 15:03 |
| anteaya | dougwig: awesome, looking forward to your contribution to TESTING.rst when that happens | 15:03 |
| anteaya | luqas_: :) | 15:03 |
| amotoki | anteaya's point is just that we need to announce third party CI needs to be changed once moving API test completes. | 15:03 |
| anteaya | amotoki: and have docs available for folks to reference, thank you, yes | 15:04 |
| amotoki | yes. I am also running third party CI, so I can help the moving of course. | 15:05 |
| openstackgerrit | Pavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM https://review.openstack.org/153236 | 15:05 |
| *** jaypipes has quit IRC | 15:05 | |
| anteaya | amotoki: oh that would be great, then you would have first hand knowledge to share with others | 15:05 |
| *** achanda has joined #openstack-neutron | 15:06 | |
| *** achanda has quit IRC | 15:06 | |
| *** carl_baldwin has quit IRC | 15:08 | |
| *** xuhanp_ has quit IRC | 15:09 | |
| *** xuhanp has quit IRC | 15:09 | |
| *** atuvenie has joined #openstack-neutron | 15:09 | |
| *** numan has quit IRC | 15:11 | |
| HenryG | marun: ping | 15:12 |
| marun | HenryG: pong | 15:12 |
| HenryG | marun: I am seeing a new problem locally when running the dsvm-functional tests, I am a bit stumped | 15:12 |
| *** jorgem has joined #openstack-neutron | 15:12 | |
| marun | HenryG: I've been having some strange problems myself... | 15:12 |
| marun | HenryG: What are you seeing? | 15:13 |
| HenryG | marun: DBusException | 15:13 |
| marun | HenryG: hmmm, that's a new one... | 15:13 |
| HenryG | marun: 1 sec, pasting ... | 15:13 |
| HenryG | marun: http://paste.openstack.org/show/196017/ | 15:14 |
| *** jpena has quit IRC | 15:14 | |
| *** pritesh has quit IRC | 15:14 | |
| *** jpena has joined #openstack-neutron | 15:16 | |
| * marun looking | 15:16 | |
| marun | HenryG: er... that's pretty strange. keystone's use of keyring appears to be conflicting with something locally installed | 15:17 |
| ZZelle | HenryG, it seems some clients use gnome keyring | 15:17 |
| marun | HenryG: is this a desktop machine? | 15:17 |
| HenryG | marun: yes, desktop. I should try on server I guess | 15:18 |
| marun | HenryG: I wouldn't recommend running anything more than unit tests on desktop | 15:18 |
| marun | HenryG: the costs of failure could be large | 15:19 |
| *** ijw has joined #openstack-neutron | 15:19 | |
| *** wN has joined #openstack-neutron | 15:19 | |
| *** lpetrut has joined #openstack-neutron | 15:19 | |
| HenryG | marun: ok, thanks for looking and educating | 15:20 |
| *** ijw has quit IRC | 15:20 | |
| *** sudipto has joined #openstack-neutron | 15:20 | |
| marun | HenryG: might be worth raising the issue with the keystone folks... | 15:20 |
| sudipto | obondarev: Hi, could you please tell me which error message you'd want me to modify per this comment: the check now is unrelated to server START_TIME, better to update error message accordingly ? | 15:21 |
| HenryG | marun: ok | 15:21 |
| marun | HenryG: the fact that it happens on import is problematic, it might actually trigger the issue even in unit testing. | 15:21 |
| *** Marga_ has joined #openstack-neutron | 15:22 | |
| *** ijw has joined #openstack-neutron | 15:22 | |
| *** ijw has quit IRC | 15:23 | |
| *** ijw has joined #openstack-neutron | 15:24 | |
| *** carl_baldwin has joined #openstack-neutron | 15:24 | |
| *** tflynn has quit IRC | 15:24 | |
| *** ollivier has joined #openstack-neutron | 15:25 | |
| *** haleyb has joined #openstack-neutron | 15:25 | |
| *** tflynn has joined #openstack-neutron | 15:25 | |
| *** garyk has quit IRC | 15:25 | |
| *** ijw has quit IRC | 15:25 | |
| *** ijw has joined #openstack-neutron | 15:26 | |
| *** emagana has joined #openstack-neutron | 15:28 | |
| *** yog__ has quit IRC | 15:29 | |
| emagana | mestery: ping! | 15:29 |
| mestery | emagana: pong! | 15:29 |
| emagana | mestery: is neutron code freeze? | 15:30 |
| openstackgerrit | Paul Michali proposed openstack/neutron-fwaas: FWaaS: Refactor callback mechanism https://review.openstack.org/167275 | 15:30 |
| mestery | emagana: We're in the feature freeze yes, we're focusing on reviewing things here: https://launchpad.net/neutron/+milestone/kilo-rc1 | 15:30 |
| *** jpena_ has joined #openstack-neutron | 15:30 | |
| emagana | mestery: I was reviewing code and I noticed a couple of commit with two +2 and not approved, it made me wondering about it because I Couldn't attend the meeting | 15:30 |
| *** scheuran has quit IRC | 15:31 | |
| emagana | mestery: Got it.. working on those reviews.. Thanks! | 15:31 |
| mestery | emagana: Tahnks for checking! :) | 15:31 |
| *** leenheer has quit IRC | 15:31 | |
| emagana | mestery: always! ;-) | 15:31 |
| *** rushil_ has quit IRC | 15:32 | |
| pc_m | armax: You around? | 15:32 |
| *** annegentle has quit IRC | 15:33 | |
| *** jpena has quit IRC | 15:33 | |
| sudipto | mestery: https://bugs.launchpad.net/neutron/+bug/1432582 is this no longer part of kilo-rc1? | 15:33 |
| openstack | Launchpad bug 1432582 in neutron "OVS agent shows connected to AMQP but neutron server rejects the request." [High,In progress] - Assigned to Sudipta Biswas (sbiswas7) | 15:33 |
| mestery | sudipto: Yes, armax pulled that out yesterday. | 15:34 |
| armax | pc_m: sup? | 15:34 |
| *** vishwanathj has joined #openstack-neutron | 15:35 | |
| *** dannywilson has joined #openstack-neutron | 15:35 | |
| pc_m | armax: On https://review.openstack.org/#/c/164466/5 I'm running into some problems and wondering if you have any ideas. Have some time? | 15:35 |
| armax | mestery, sudipto: yes, I did, because I don’t think this is critical to the release, and since we didn’t have consensus on the fix... | 15:35 |
| armax | pc_m: in a meeting now... | 15:35 |
| sudipto | armax, mestery: Ok. So I can work on this later for the next release? | 15:35 |
| pc_m | armax: Can you ping me when avail? | 15:35 |
| armax | pc_m: will do | 15:35 |
| pc_m | armax: Thanks! | 15:35 |
| sudipto | armax, mestery: I seem to have consensus now from a few people... | 15:36 |
| mestery | sudipto: Once we cut hte RC branch, we'll take the brakes off of master again for Liberty | 15:36 |
| sudipto | mestery: Ok sure. | 15:36 |
| armax | pc_m: wanna give me a heads-up? | 15:36 |
| *** chandankumar has joined #openstack-neutron | 15:36 | |
| *** tsg has joined #openstack-neutron | 15:37 | |
| emagana | mestery: I just went through all Wishlist ones and none is ready to review.. either no code or there is a -2 | 15:37 |
| emagana | mestery: I guess we need to make more pressure to the owners! | 15:37 |
| mestery | emagana: Some of those wishlist are plugin decomp things which are blocked and armax is tracking. | 15:37 |
| pc_m | armax: Sure... So trying to patch the _get_callback_manager() method to return a unique CallbacksManager object. However, that method is called multiple times during the test cases (twice to subscribe callbacks, and then each time a notification is done. | 15:38 |
| mestery | armax was saying hte same thing to me today emagana :) | 15:38 |
| emagana | mestery: Just saying... maybe we should take them out of the rc-1 | 15:38 |
| pc_m | armax: Right now, I'm trying to figure out how to do that on a per test basis (singleton for a test), but having a few problems. | 15:38 |
| emagana | mestery: anyway they are just wishlist... moving on | 15:38 |
| mestery | emagana: We'll get there, but those plugin decomp ones are close anyways :) | 15:39 |
| armax | pc_m: unit tests right? | 15:39 |
| emagana | mestery: true! | 15:39 |
| pc_m | armax: Testing another try right now. Yes UT | 15:39 |
| pc_m | armax: I mocked _get_callback_manager() to return a new instance, but that will not work, due to the multiple calls. | 15:40 |
| armax | pc_m: did you use the same approach you chose for the functional test? | 15:40 |
| *** absubram has quit IRC | 15:40 | |
| openstackgerrit | Carl Baldwin proposed openstack/neutron: Move create_dvr_fip_interfaces in to DVR https://review.openstack.org/159663 | 15:41 |
| *** kickinz1 is now known as kickinz1|afk | 15:42 | |
| pc_m | armax: Yeah. My guess is that the functional test doesn't exercise this. I think that approach is wrong. | 15:42 |
| armax | pc_m: have you considered creating a test level instance for the callback manager? | 15:42 |
| *** _cjones_ has joined #openstack-neutron | 15:42 | |
| armax | pc_m: don’t think so. | 15:42 |
| *** leenheer has joined #openstack-neutron | 15:42 | |
| *** ronis has quit IRC | 15:42 | |
| armax | reviewing the functional test now | 15:42 |
| armax | pc_m: hang on | 15:42 |
| *** kickinz1|afk is now known as kickinz1 | 15:43 | |
| *** leenheer has quit IRC | 15:43 | |
| armax | pc_m: have a look? | 15:43 |
| *** annegentle has joined #openstack-neutron | 15:43 | |
| *** anshul has quit IRC | 15:44 | |
| *** _cjones_ has quit IRC | 15:44 | |
| *** _cjones_ has joined #openstack-neutron | 15:44 | |
| *** jorgem has quit IRC | 15:44 | |
| pc_m | armax: Right now, I made a member function on the test class, to create a manager, if one doesn't exist (using an attribute on the test class for the callback manager). | 15:44 |
| armax | I saw | 15:45 |
| armax | pc_m: I made a comment on it right now | 15:45 |
| pc_m | armax: Running tests right now. Ah that is probably better. | 15:46 |
| *** changbl has joined #openstack-neutron | 15:46 | |
| pc_m | armax: Thanks! I'll try that. | 15:46 |
| armax | pc_m: pls have a look, I only interpreted in my mind | 15:46 |
| armax | pc_m: not sure if it works ;) | 15:46 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify base test cases https://review.openstack.org/167041 | 15:48 |
| *** kendriu has left #openstack-neutron | 15:49 | |
| *** YorikSar has quit IRC | 15:49 | |
| *** lpetrut has quit IRC | 15:50 | |
| *** annegentle has quit IRC | 15:50 | |
| openstackgerrit | ZongKai LI proposed openstack/neutron: fix l3-agent restart with last runtime fip for dvr https://review.openstack.org/166539 | 15:51 |
| *** bradjones has quit IRC | 15:51 | |
| *** bradjones has joined #openstack-neutron | 15:51 | |
| *** bradjones has quit IRC | 15:51 | |
| *** bradjones has joined #openstack-neutron | 15:51 | |
| *** lpetrut has joined #openstack-neutron | 15:52 | |
| *** Miouge has joined #openstack-neutron | 15:53 | |
| *** wN has left #openstack-neutron | 15:53 | |
| *** nlahouti has joined #openstack-neutron | 15:53 | |
| HenryG | marun: what problems are you seeing with functional tests? | 15:55 |
| *** carl_baldwin has quit IRC | 15:55 | |
| *** zhhuabj has joined #openstack-neutron | 15:55 | |
| openstackgerrit | Aman Kumar proposed openstack/neutron: Added config variable for External Network type in ML2 https://review.openstack.org/149546 | 15:56 |
| *** leenheer has joined #openstack-neutron | 15:56 | |
| *** leenheer has quit IRC | 15:56 | |
| marun | HenryG: I've been seeing failures related to oslo_rootwrap installation and db issues with the imap testing. | 15:56 |
| marun | HenryG: Hard to say what the cause is, really, given that how the environment is installed is so important. | 15:57 |
| *** jorgem has joined #openstack-neutron | 15:57 | |
| marun | HenryG: the functional job has sitepackages=True to allow things like python-openvswitch, but that is problematic. | 15:57 |
| marun | HenryG: I'd like to see us move to docker so that we can have a known-good environment to test in | 15:58 |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Add clock sync error detection on agent registration https://review.openstack.org/165539 | 15:58 |
| marun | HenryG: Or better, at the least. Network namespaces aren't really containable | 15:58 |
| marun | HenryG: but at least all the deps could be frozen in a container once they were tested to work | 15:59 |
| *** yfried__ has quit IRC | 15:59 | |
| *** yfried__ has joined #openstack-neutron | 15:59 | |
| *** tflynn has quit IRC | 15:59 | |
| *** emagana has quit IRC | 16:00 | |
| *** salv-orlando has quit IRC | 16:00 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 16:00 |
| openstackgerrit | Doug Wiegley proposed openstack/neutron: Strawman: Remove pylint entirely https://review.openstack.org/167284 | 16:01 |
| *** carl_baldwin has joined #openstack-neutron | 16:02 | |
| matrohon | Hi | 16:02 |
| *** EmilienM is now known as EmilienM|PTO | 16:02 | |
| *** emagana has joined #openstack-neutron | 16:03 | |
| *** dane_leblanc has quit IRC | 16:03 | |
| matrohon | I want to tag a bug as kilo-rc-potential | 16:03 |
| matrohon | no such tag has been created? | 16:03 |
| *** julien_ZTE has quit IRC | 16:03 | |
| matrohon | mestery : ^^ | 16:03 |
| *** julien_ZTE has joined #openstack-neutron | 16:03 | |
| mestery | matrohon: I'll create that one, doing it now. Or just mark it as kilo-rc1 for now. | 16:04 |
| *** julien_ZTE has quit IRC | 16:04 | |
| matrohon | mestery : done, thanks | 16:04 |
| *** melwitt has joined #openstack-neutron | 16:04 | |
| *** amotoki has quit IRC | 16:04 | |
| mestery | matrohon: Thanks! | 16:04 |
| *** amotoki has joined #openstack-neutron | 16:05 | |
| *** zhipeng has quit IRC | 16:05 | |
| *** Marga_ has quit IRC | 16:05 | |
| *** jistr has quit IRC | 16:05 | |
| *** yamamoto has quit IRC | 16:05 | |
| *** salv-orlando has joined #openstack-neutron | 16:07 | |
| amuller | carl_baldwin: pylint actually helped me during rebasing the refactor patch, it's catching things that flake8 isn't: no-value-for-parameter and too-many-function-args | 16:07 |
| carl_baldwin | amuller: I don’t have anything against pylint. I just insist that it must be pinned if we’re going to use it. | 16:09 |
| amuller | I agree, that's why I proposed that patch :) | 16:09 |
| carl_baldwin | From the most recent comment on the patch, sounds like we could get that through if someone is willing to commit toit. | 16:10 |
| amuller | yeah I'll have to think about that | 16:10 |
| *** jpena_ is now known as jpena | 16:10 | |
| carl_baldwin | Since Neutron is the only project using it for voting, it should just be updating Neutron at the beginning of a cycle. | 16:12 |
| *** garyk has joined #openstack-neutron | 16:13 | |
| *** jprovazn has quit IRC | 16:14 | |
| ZZelle | amuller, you should also pin astroid version | 16:15 |
| *** chlong has quit IRC | 16:16 | |
| *** aranjan has joined #openstack-neutron | 16:16 | |
| *** jorgem has quit IRC | 16:17 | |
| ZZelle | amuller, the 1st trouble we add with pylint 1.4.1 was not pylint itself by new astroid version which was smarter | 16:17 |
| *** melwitt has quit IRC | 16:17 | |
| *** ilyashakhat has joined #openstack-neutron | 16:18 | |
| amuller | ZZelle: astroid is a pylint depdency though, we don't have it in our requirements, so if pylint is pinned (And thus not updated), it shouldn't update its depedencies either? | 16:18 |
| ZZelle | amuller, it appends with https://review.openstack.org/148027 | 16:19 |
| *** thedodd has quit IRC | 16:19 | |
| ihrachyshka | amuller, we can adopt the pin under our oslo janitor efforts. that should be easy. | 16:19 |
| *** lizk_ has quit IRC | 16:19 | |
| *** Miouge has quit IRC | 16:20 | |
| *** melwitt has joined #openstack-neutron | 16:20 | |
| ZZelle | amuller, iirc, pylint does not set a upper version constraint on astroid version | 16:20 |
| *** Miouge has joined #openstack-neutron | 16:20 | |
| *** garyk has quit IRC | 16:21 | |
| *** yamahata has quit IRC | 16:21 | |
| amuller | ZZelle: OK, but if pip install -r requirements doesn't update pylint (Because it's pinned), why would astroid be updated? | 16:21 |
| amuller | ihrachyshka: Do you have a link describing the 'oslo janitor' efforts? All I got from Google were janitor positions in the city of Oslo :) | 16:21 |
| *** zhhuabj has quit IRC | 16:22 | |
| ihrachyshka | amuller, well.. I mostly meant all the things I tracked during kilo as oslo liaison. I handled hacking version bump. | 16:22 |
| armax | HenryG: ping | 16:22 |
| amuller | ihrachyshka: ahh ok | 16:22 |
| ihrachyshka | so I can also do it for pylint | 16:22 |
| *** zhhuabj has joined #openstack-neutron | 16:23 | |
| ZZelle | amuller, on a new virtualenv astroid version can be higher than the one on older virtualenv | 16:23 |
| ihrachyshka | amuller, unless pylint explicitly caps astroid, it will fetch the latest for new venv or with -U | 16:23 |
| amuller | ZZelle: gotchz | 16:23 |
| amuller | a* | 16:23 |
| ihrachyshka | a workaround could be e.g. installing astroid first | 16:24 |
| ihrachyshka | amuller, multi targets are merging in kilo! | 16:24 |
| amuller | ihrachyshka: good news :) | 16:25 |
| openstackgerrit | Merged openstack/neutron-vpnaas: Introduce Vyatta VPN agent cmd in monkey patched eventlet module https://review.openstack.org/166366 | 16:25 |
| *** sudipto has quit IRC | 16:25 | |
| amuller | ihrachyshka: so what version of oslo messaging will include that patch then? How do I know that? | 16:25 |
| *** dane_leblanc has joined #openstack-neutron | 16:25 | |
| *** mestery has quit IRC | 16:26 | |
| *** Miouge has quit IRC | 16:26 | |
| *** nyechiel_ has quit IRC | 16:26 | |
| *** mestery has joined #openstack-neutron | 16:26 | |
| marun | HenryG, armax: Some patches intended to clean up api tests - https://review.openstack.org/#/c/167041/ | 16:27 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Ml2 Mechanism Driver for OVSvApp Solution https://review.openstack.org/160247 | 16:28 |
| HenryG | armax: pong | 16:29 |
| *** absubram has joined #openstack-neutron | 16:29 | |
| HenryG | marun: they are on my radar | 16:29 |
| armax | marun: captured | 16:29 |
| *** ihrachyshka has quit IRC | 16:29 | |
| armax | HenryG: any clue as to why https://review.openstack.org/#/c/157243/ is not liked by its CI? | 16:30 |
| *** Bsony has quit IRC | 16:30 | |
| *** tiswanso has quit IRC | 16:30 | |
| *** tiswanso has joined #openstack-neutron | 16:31 | |
| HenryG | armax: I know they are working on it, I can find out some details if needed | 16:31 |
| armax | HenryG: ok thanks | 16:32 |
| *** thedodd has joined #openstack-neutron | 16:32 | |
| *** Miouge has joined #openstack-neutron | 16:32 | |
| *** dane_leblanc has quit IRC | 16:32 | |
| ZZelle | ihrachyshka, emagana, hi | 16:32 |
| ZZelle | iihrachyshka, emagana, based on the discussion we had last week i updated https://review.openstack.org/165115 and https://review.openstack.org/161494, if you have some time to give some feedbacks | 16:34 |
| *** cbouch has quit IRC | 16:34 | |
| *** carl_baldwin has quit IRC | 16:35 | |
| *** amotoki has quit IRC | 16:35 | |
| emagana | ZZelle: I will do it! | 16:36 |
| ZZelle | emagana, thx | 16:36 |
| pc_m | mestery: hi | 16:37 |
| *** annegentle has joined #openstack-neutron | 16:37 | |
| *** annegent_ has joined #openstack-neutron | 16:38 | |
| *** rushil has joined #openstack-neutron | 16:39 | |
| *** carl_baldwin has joined #openstack-neutron | 16:39 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Remove auto deletion of routers in unit tests https://review.openstack.org/167056 | 16:39 |
| *** kickinz1 has left #openstack-neutron | 16:39 | |
| *** lizk has joined #openstack-neutron | 16:41 | |
| *** jaypipes_ has joined #openstack-neutron | 16:41 | |
| *** dane_leblanc has joined #openstack-neutron | 16:41 | |
| *** ivar-lazzaro has joined #openstack-neutron | 16:42 | |
| *** yatin has joined #openstack-neutron | 16:42 | |
| *** yamahata has joined #openstack-neutron | 16:42 | |
| *** annegent_ has quit IRC | 16:42 | |
| *** annegentle has quit IRC | 16:43 | |
| *** armax has quit IRC | 16:44 | |
| *** ijw has quit IRC | 16:46 | |
| kevinbenton | amuller: https://bugs.launchpad.net/neutron/+bug/1287824 | 16:46 |
| openstack | Launchpad bug 1287824 in neutron "l3 agent makes too many individual sudo/ip netns calls" [High,Fix released] - Assigned to Carl Baldwin (carl-baldwin) | 16:46 |
| *** ivar-lazzaro has quit IRC | 16:46 | |
| *** ivar-lazzaro has joined #openstack-neutron | 16:47 | |
| *** hitalia has joined #openstack-neutron | 16:48 | |
| pc_m | mestery, carl_baldwin: Can one of you review https://review.openstack.org/#/c/165159/? It is the UT for Strongswan implementation. Pretty much wraps that work up. | 16:49 |
| carl_baldwin | pc_m: I had started looking at that one. Didn’t finish the review. Hope to get to it soon. | 16:50 |
| pc_m | carl_baldwin: Thank you! | 16:50 |
| *** matrohon has quit IRC | 16:50 | |
| carl_baldwin | pc_m: Glad to help. | 16:50 |
| *** sbfox has joined #openstack-neutron | 16:51 | |
| pc_m | carl_baldwin: I've been doing refactoring of the L3 agent and services for the past few weeks. This is to switch from the event_notifier mechanism I had made, to the callback mechanism that armax created (so all using same method). | 16:52 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 16:52 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Move API tests to neutron.test.api https://review.openstack.org/167320 | 16:52 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify base test cases https://review.openstack.org/167041 | 16:52 |
| pc_m | carl_baldwin: It also removes more of the dependency on the L3 agent. I have a few patches up for review (all are pretty close, IMHO). | 16:52 |
| carl_baldwin | pc_m: I’ve seen those too. I think that may be too much of a stretch for Kilo. What do you think? | 16:53 |
| pc_m | carl_baldwin: Didn't know if we want to defer these till Liberty or put them in now. | 16:53 |
| marun | armax, HenryG: The end goal of the series is moving the tests to neutron.tests.api where they belong ^^ | 16:53 |
| pc_m | carl_baldwin: They are pretty simple. The Neutron one was hung up on UT with the clean up of callbacks between test, but I think I have that working now. Just doing tests. | 16:54 |
| pc_m | carl_baldwin: The VPN was waiting for Vyatta feedback from Sridhar, and I have that, so that too is going along. | 16:54 |
| pc_m | carl_baldwin: I think it can make it, and isn't high risk, but can defer if that makes more sense. amuller was wondering about backporting, if we wait till Liberty. | 16:55 |
| amuller | kevinbenton: pong | 16:56 |
| pc_m | carl_baldwin: Wondering what you think. | 16:56 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Move API tests to neutron.test.api https://review.openstack.org/167320 | 16:56 |
| *** tflynn has joined #openstack-neutron | 16:56 | |
| pc_m | or recommend. | 16:56 |
| *** tflynn has quit IRC | 16:56 | |
| amuller | kevinbenton: kind of cooking lunch btw so semi afk | 16:57 |
| kevinbenton | amuller: just wanted you to change the status to "fix committed" | 16:57 |
| kevinbenton | amuller: no biggue | 16:57 |
| kevinbenton | amuller: biggie* | 16:57 |
| amuller | kevinbenton: oh right | 16:57 |
| amuller | my bad | 16:57 |
| pc_m | carl_baldwin: I've got no strong opinion, just that it's close to being completed. | 16:57 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Simplify retargetable test framework https://review.openstack.org/167075 | 16:57 |
| amuller | kevinbenton: I don't have permissions to do that it seems | 16:57 |
| *** sripriya has joined #openstack-neutron | 16:57 | |
| *** tflynn has joined #openstack-neutron | 16:57 | |
| openstackgerrit | Maru Newby proposed openstack/neutron: Move API tests to neutron.test.api https://review.openstack.org/167320 | 16:57 |
| amuller | enikanorov_: https://bugs.launchpad.net/neutron/+bug/1287824 - Do you have permissions to change that from fix released to fix commited? | 16:58 |
| openstack | Launchpad bug 1287824 in neutron "l3 agent makes too many individual sudo/ip netns calls" [High,Fix released] - Assigned to Carl Baldwin (carl-baldwin) | 16:58 |
| *** chandankumar has quit IRC | 16:58 | |
| carl_baldwin | amuller: enikanorov_: done | 16:59 |
| *** tsg has quit IRC | 16:59 | |
| amuller | carl_baldwin: thanks | 16:59 |
| *** tflynn_ has joined #openstack-neutron | 16:59 | |
| HenryG | marun: functional tests run fine on server, thanks for the tip | 17:00 |
| *** tflynn_ has quit IRC | 17:00 | |
| marun | HenryG: :) | 17:00 |
| *** tflynn_ has joined #openstack-neutron | 17:00 | |
| *** ivar-laz_ has joined #openstack-neutron | 17:01 | |
| *** baoli has quit IRC | 17:02 | |
| *** emagana has quit IRC | 17:02 | |
| *** tflynn has quit IRC | 17:03 | |
| *** tiswanso has quit IRC | 17:03 | |
| *** ivar-lazzaro has quit IRC | 17:04 | |
| *** dane_leblanc has quit IRC | 17:05 | |
| openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 17:05 |
| *** julien_ZTE has joined #openstack-neutron | 17:05 | |
| *** ronis has joined #openstack-neutron | 17:05 | |
| *** jlanoux_ has quit IRC | 17:07 | |
| *** ollivier has quit IRC | 17:07 | |
| *** yatin has quit IRC | 17:07 | |
| *** kevinbenton has quit IRC | 17:07 | |
| *** moshele has quit IRC | 17:08 | |
| *** Marga_ has joined #openstack-neutron | 17:08 | |
| *** julien_ZTE has quit IRC | 17:10 | |
| *** YorikSar has joined #openstack-neutron | 17:10 | |
| *** chandankumar has joined #openstack-neutron | 17:11 | |
| *** tiswanso has joined #openstack-neutron | 17:11 | |
| *** mikeit has joined #openstack-neutron | 17:11 | |
| pc_m | carl_baldwin: Should we defer the refactoring or try to put it in? | 17:14 |
| *** annegentle has joined #openstack-neutron | 17:14 | |
| carl_baldwin | pc_m: Which/how many reviews are you asking about exactly? | 17:14 |
| *** tiswanso has quit IRC | 17:15 | |
| pc_m | carl_baldwin: One for neutron (close to done), vpn (pretty close as well), and fw (did today, trival). Then a final commit to neutron to remove the dead code from old mechanism. | 17:16 |
| *** zhhuabj has quit IRC | 17:17 | |
| pc_m | carl_baldwin: So two neutron, and two *aaS commits. | 17:17 |
| *** harlowja_away is now known as harlowja | 17:18 | |
| carl_baldwin | pc_m: I think they should be deferred. | 17:18 |
| pc_m | carl_baldwin: ok. Will do. | 17:18 |
| *** fredlhsu has quit IRC | 17:20 | |
| *** ygbo has quit IRC | 17:21 | |
| *** dane_leblanc has joined #openstack-neutron | 17:23 | |
| *** baoli has joined #openstack-neutron | 17:24 | |
| *** imcsk8|zZz is now known as imcsk8 | 17:25 | |
| *** ijw has joined #openstack-neutron | 17:26 | |
| *** salv-orlando has quit IRC | 17:26 | |
| dougwig | pc_m, carl_baldwin - let me know if i can help review. | 17:26 |
| *** chandankumar has quit IRC | 17:27 | |
| carl_baldwin | dougwig: Do you think we need to merge these? pc_m did not feel strongly and so I thought they should be deferred. | 17:27 |
| *** rushil has quit IRC | 17:28 | |
| *** achanda has joined #openstack-neutron | 17:28 | |
| dougwig | carl_baldwin: no, i don't feel strongly. i'm just ready to help out if needed. | 17:28 |
| *** salv-orlando has joined #openstack-neutron | 17:28 | |
| *** zhhuabj has joined #openstack-neutron | 17:28 | |
| *** baoli has quit IRC | 17:28 | |
| pc_m | dougwig: carl_baldwin: It's very close to being done, but I'm ok with deferring. | 17:28 |
| dougwig | carl_baldwin, pc_m - is the refactor work purely internal, or will it help make decomposed external stuff saner? | 17:29 |
| *** aepifanov has quit IRC | 17:29 | |
| *** dboik_ has quit IRC | 17:30 | |
| *** baoli has joined #openstack-neutron | 17:30 | |
| *** dboik has joined #openstack-neutron | 17:30 | |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Subnet allocation from a subnet pool https://review.openstack.org/157597 | 17:31 |
| *** sbfox has quit IRC | 17:31 | |
| pc_m | dougwig: It removes duplication in callback mechanism (L3 agent -> services), and reduces need for L3 agent by drivers (only one vendor driver needs L3 agent and it may be removable later). | 17:32 |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Subnet allocation from a subnet pool https://review.openstack.org/157597 | 17:32 |
| pc_m | dougwig: Eliminates AdvancedService and L3EventObserver (spelling?) classes. | 17:33 |
| pc_m | dougwig: carl_baldwin: amuller was concerned about defering and backporting efforts. Not sure what exactly. | 17:33 |
| *** sridhar_ram has joined #openstack-neutron | 17:33 | |
| pc_m | dougwig: carl_baldwin: It changes all the router notification calls to use the new neutron/callbacks/* code. | 17:34 |
| openstackgerrit | Paul Michali proposed openstack/neutron: Refactoring of L3 agent notifications for router https://review.openstack.org/164466 | 17:34 |
| *** annegentle has quit IRC | 17:34 | |
| pc_m | dougwig: FYI, the code is ^^^ for neutron. For VPN it is https://review.openstack.org/#/c/165226/ | 17:35 |
| carl_baldwin | pc_m: dougwig: I’m happy to hear amuller’s concerns. My review time is tight and so it would take some justification for me to prioritize it. Sounds like dougwig has some review cycles to space. | 17:35 |
| carl_baldwin | *spare | 17:35 |
| pc_m | amuller: you around? | 17:36 |
| amuller | I wasn't raising a concern (I'm not concerned at all if that patch is delayed to L), just stating that a plus for delivering it in K is that it would make backports in the surrounding code easier | 17:36 |
| *** Bsony has joined #openstack-neutron | 17:36 | |
| *** john-davidge has quit IRC | 17:36 | |
| *** nfedotov has quit IRC | 17:39 | |
| openstackgerrit | Baodong (Robert) Li proposed openstack/neutron: allow neutron-keepalived-state-change to run when installed with devstack https://review.openstack.org/167339 | 17:40 |
| dougwig | amuller: that's a pretty decent concern. | 17:40 |
| *** rangansw has joined #openstack-neutron | 17:41 | |
| *** Bsony has quit IRC | 17:41 | |
| pc_m | carl_baldwin: Understood on review time. I've got bandwidth to work this. If dougwig and others have time to review that's cool with me (would be nice to wrap this up), but if not, I'm OK with it going to L. | 17:41 |
| *** jpena has quit IRC | 17:42 | |
| *** annegentle has joined #openstack-neutron | 17:43 | |
| *** lpetrut has quit IRC | 17:44 | |
| *** s3wong has joined #openstack-neutron | 17:44 | |
| *** dboik_ has joined #openstack-neutron | 17:44 | |
| *** lpetrut has joined #openstack-neutron | 17:44 | |
| *** tsg has joined #openstack-neutron | 17:45 | |
| *** carl_baldwin has quit IRC | 17:46 | |
| pc_m | marun: ping | 17:46 |
| *** mikeit has quit IRC | 17:46 | |
| marun | pc_m: pong | 17:46 |
| *** tflynn_ has quit IRC | 17:47 | |
| *** tsg_ has joined #openstack-neutron | 17:47 | |
| pc_m | marun: Nikolay is trying to get a scenario test (functional) working for VPN (https://review.openstack.org/#/c/159746/12) and having some issue with getting the tests running. do you have time for some questions? | 17:47 |
| *** dboik has quit IRC | 17:47 | |
| marun | pc_m: I have a meeting starting in 10m but I'll do my best. | 17:48 |
| *** ivar-laz_ has quit IRC | 17:48 | |
| *** zz_jgrimm is now known as jgrimm | 17:48 | |
| *** tflynn has joined #openstack-neutron | 17:48 | |
| marun | pc_m: looking at that change, it doesn't make sense why tempest is being used | 17:49 |
| *** lori|away is now known as lori | 17:49 | |
| marun | pc_m: I don't think it makes sense for anything outside of neturon to rely on neutron/tests/tempest, since it is slated for eventual remova.l | 17:49 |
| *** ivar-lazzaro has joined #openstack-neutron | 17:49 | |
| *** tflynn has quit IRC | 17:49 | |
| pc_m | I think he was trying to leverage off the BaseNetworkTest class. | 17:50 |
| *** ijw has quit IRC | 17:50 | |
| pc_m | Ran into all sorts of issues trying to enable tempest service. | 17:50 |
| *** Networkn3rd has quit IRC | 17:50 | |
| marun | pc_m: I'd discourage him from reusing something taht he doesn't understand. | 17:50 |
| *** tsg has quit IRC | 17:50 | |
| marun | pc_m: tempest relies on devstack-deployed services | 17:50 |
| *** tflynn has joined #openstack-neutron | 17:50 | |
| marun | pc_m: functional tests are supposed to manage their own fixture | 17:51 |
| *** haleyb has quit IRC | 17:51 | |
| marun | pc_m: mixing those two approaches is bound to be problematic | 17:51 |
| *** Networkn3rd has joined #openstack-neutron | 17:51 | |
| *** tiswanso has joined #openstack-neutron | 17:51 | |
| marun | pc_m: I suggest disallowing use of anything from neutron/tests/tempest for functional tests. | 17:52 |
| *** armax has joined #openstack-neutron | 17:52 | |
| marun | pc_m: And really, disallow it entirely. | 17:52 |
| mestery | marun: How do we run the in-tree tempest api tests? Still using testr? | 17:52 |
| pc_m | marun: Thanks. I'm not sure how to do the functional tests either, so I'm not being much help to him in getting this going. | 17:52 |
| marun | mestery: https://github.com/openstack/neutron/blob/master/TESTING.rst#with-tox | 17:53 |
| marun | mestery: yes. I'm working on making this a bit easier to find, but the instructions there work. | 17:53 |
| mestery | marun: Sweet! | 17:53 |
| marun | pc_m: the key is test-managed fixture. | 17:53 |
| marun | pc_m: tempest is not helpful in that regard, it relies on devstack to deploy things | 17:53 |
| marun | pc_m: so if a functional test needs fixture, it should be creating it. | 17:54 |
| *** stockpirate has joined #openstack-neutron | 17:56 | |
| pc_m | marun: What do think is the best way we can help Nikolay in developing this test? Do you think he can leverage off of what he has already (some)? | 17:56 |
| *** roeyc has quit IRC | 17:56 | |
| stockpirate | http://docs.openstack.org/juno/install-guide/install/apt/content/nova-networking-controller-node.html | 17:56 |
| HenryG | armax: they fixed the CI, https://review.openstack.org/157243 | 17:57 |
| stockpirate | Is: Legacy networking primarily involves compute nodes. However, you must configure the controller node to use legacy networking. | 17:57 |
| stockpirate | controller node the neutron server or the compute node?= | 17:57 |
| *** dsneddon has quit IRC | 17:57 | |
| *** dsneddon has joined #openstack-neutron | 17:57 | |
| pc_m | marun: For the test, routers, private and public subnets are needed. Now devstack creates some normally. Would one use those existing entities in the test or create everything from scratch for the test? | 17:57 |
| *** tiswanso has quit IRC | 17:58 | |
| pc_m | (as part of the fixture). | 17:58 |
| * pc_m trying to get a feel for the approach to take | 17:58 | |
| amuller | pc_m: that's not a functional test | 17:58 |
| *** jamie_h has joined #openstack-neutron | 17:58 | |
| marun | pc_m: it looks more like a tempest scenario test, and that should go into tempest | 17:58 |
| *** baoli has quit IRC | 17:59 | |
| armax | HenryG: looking | 17:59 |
| *** tiswanso has joined #openstack-neutron | 17:59 | |
| *** ijw has joined #openstack-neutron | 18:00 | |
| *** baoli_ has joined #openstack-neutron | 18:00 | |
| *** nyechiel_ has joined #openstack-neutron | 18:01 | |
| pc_m | marun: Confused a bit. Seems like this test is going full circle. It was initially added to tempest, and then he was told that it couldn't go into tempest and had to go into the functional test for the VPN repo. | 18:01 |
| marun | pc_m: uh | 18:01 |
| marun | pc_m: where's the original tempest change? | 18:02 |
| marun | pc_m: there are 2 types of tests in tempest | 18:02 |
| *** yfauser has joined #openstack-neutron | 18:02 | |
| marun | pc_m: is it an api test (logical validation only) or a scenario test (validates state) | 18:02 |
| *** localloop127 has quit IRC | 18:03 | |
| *** padkrish has joined #openstack-neutron | 18:03 | |
| *** emagana has joined #openstack-neutron | 18:03 | |
| *** criptoverso has quit IRC | 18:04 | |
| *** sridhar_ram has quit IRC | 18:04 | |
| pc_m | marun: This review came from an oder review that was abandoned (left idle) as a tempest test. It think it is in the commit message, but if not, I can dig up the original review (from last year). | 18:04 |
| *** jschwarz has joined #openstack-neutron | 18:04 | |
| *** jamielennox|away is now known as jamielennox | 18:04 | |
| *** sripriya has quit IRC | 18:05 | |
| pc_m | marun: It is a scenario test. Goal is to create an IPSec tunnel, and then verify that we can ping across the tunnel. | 18:05 |
| *** sripriya has joined #openstack-neutron | 18:05 | |
| *** shwetaap has quit IRC | 18:06 | |
| *** sridhar_ram has joined #openstack-neutron | 18:06 | |
| *** safchain has quit IRC | 18:06 | |
| *** nyechiel_ has quit IRC | 18:07 | |
| marun | pc_m: in tempest, pinging across the tunnel requires vm's | 18:07 |
| marun | pc_m: in a functional test, that isn't necessary | 18:07 |
| *** emagana has quit IRC | 18:08 | |
| *** shwetaap has joined #openstack-neutron | 18:08 | |
| marun | pc_m: but having a functional test rely on daemons that aren't test-managed is going to be make things complicated | 18:08 |
| pc_m | marun: The original review was spinning up two VMs. This one, instead, is going to create a port on the private net and try to ping using that. | 18:08 |
| *** yfauser has left #openstack-neutron | 18:09 | |
| *** marrusl has quit IRC | 18:10 | |
| pc_m | marun: Which daemons are you referring to? The VPN processes or something else? | 18:10 |
| *** marrusl has joined #openstack-neutron | 18:10 | |
| marun | pc_m: neutron? | 18:11 |
| pc_m | marun: So it gets back to the question above... "What do think is the best way we can help Nikolay in developing this test?" | 18:12 |
| marun | pc_m: in meeting, sorry | 18:13 |
| pc_m | marun: We have some simple functional tests that check the VPN process is running, status is as expected (without a connection). The desire is to create a scenario test that verifies that an end-to-end VPN connection can be established and pass traffic. | 18:14 |
| *** baoli_ has quit IRC | 18:15 | |
| pc_m | marun: Sounds like we need to revisit where that test should live (tempest/vpnaas), and how to best accomplish the test. | 18:15 |
| *** yfauser1 has joined #openstack-neutron | 18:16 | |
| marun | pc_m: it should live in vpnaas... | 18:16 |
| marun | pc_m: that's not the issue | 18:16 |
| marun | pc_m: it's how the test is written | 18:16 |
| *** annegentle has quit IRC | 18:16 | |
| *** yfauser1 has left #openstack-neutron | 18:17 | |
| *** yfauser has joined #openstack-neutron | 18:18 | |
| *** yfauser has left #openstack-neutron | 18:18 | |
| pc_m | marun: would you be able to advise him on how to create the test? | 18:18 |
| *** carl_baldwin has joined #openstack-neutron | 18:18 | |
| *** yfauser has joined #openstack-neutron | 18:18 | |
| *** localloop127 has joined #openstack-neutron | 18:23 | |
| *** yfauser has quit IRC | 18:23 | |
| *** reed has quit IRC | 18:24 | |
| *** Marga_ has quit IRC | 18:24 | |
| *** sbfox has joined #openstack-neutron | 18:24 | |
| *** ZZelle_ has joined #openstack-neutron | 18:26 | |
| *** crc32 has joined #openstack-neutron | 18:26 | |
| *** achanda has quit IRC | 18:28 | |
| *** emagana has joined #openstack-neutron | 18:29 | |
| ZZelle_ | marun, hi | 18:29 |
| marun | ZZelle_: hi | 18:29 |
| marun | pc_m: I can try | 18:30 |
| *** annegentle has joined #openstack-neutron | 18:30 | |
| ZZelle_ | marun, if you have some times, i updated https://review.openstack.org/159852 and follow-up changes on functional test helpers | 18:30 |
| ZZelle_ | marun, there are more changes :( but smaller :) | 18:31 |
| *** jorgem has joined #openstack-neutron | 18:31 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add API tests for Neutron DVR extension https://review.openstack.org/167357 | 18:31 |
| *** rangansw_ has joined #openstack-neutron | 18:31 | |
| *** apuimedo has quit IRC | 18:31 | |
| *** rangansw has quit IRC | 18:31 | |
| *** lpetrut has quit IRC | 18:32 | |
| pc_m | marun: That would be great! | 18:33 |
| *** emagana has quit IRC | 18:33 | |
| *** reed has joined #openstack-neutron | 18:34 | |
| ZZelle_ | mestery, hi | 18:34 |
| mestery | ZZelle_: Yo! | 18:34 |
| pc_m | marun: Also, the neutron-vpnaas hooks are based on the older neutron hooks, which have since changed. Does it make sense to bring the neutron-vpnaas ones in line with neutron? | 18:35 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add API tests for Neutron DVR extension https://review.openstack.org/167357 | 18:35 |
| ZZelle_ | mestery, do you think we can add https://bugs.launchpad.net/neutron/+bug/1427228 to kilo-RC1 milestone? | 18:35 |
| openstack | Launchpad bug 1427228 in neutron "Allow to run neutron-ns-metadata-proxy as nobody" [Undecided,In progress] - Assigned to Cedric Brandily (cbrandily) | 18:35 |
| mestery | ZZelle_: Possibly | 18:35 |
| pc_m | marun: There's some things, especially in the gate hook, that I don't even know what they are there for, and that concerns me. | 18:36 |
| marun | pc_m: anything in particular? | 18:36 |
| ZZelle_ | mestery, that is the expected rc1 release date? | 18:36 |
| marun | ZZelle_: on my short-list | 18:36 |
| ZZelle_ | marun, thx | 18:36 |
| openstackgerrit | Terry Wilson proposed openstack/neutron: Handle non-index lookups in native OVSDB backend https://review.openstack.org/167017 | 18:37 |
| mestery | ZZelle_: Yes sir | 18:37 |
| pc_m | marun: Just in general, uncomfortable with a bunch of test setup that I don't understand and am not sure if needed (as it's not there in neutron any more). | 18:37 |
| *** anshul has joined #openstack-neutron | 18:37 | |
| pc_m | marun: Looks like some rootwrap filters set up, and then database setup. | 18:39 |
| *** sridhar_ram has quit IRC | 18:39 | |
| *** lykinsbd has joined #openstack-neutron | 18:40 | |
| *** dannywilson has quit IRC | 18:42 | |
| *** dannywilson has joined #openstack-neutron | 18:42 | |
| *** sridhar_ram has joined #openstack-neutron | 18:43 | |
| *** annegentle has quit IRC | 18:45 | |
| *** sripriya has quit IRC | 18:45 | |
| *** lykinsbd has quit IRC | 18:46 | |
| *** haleyb has joined #openstack-neutron | 18:46 | |
| *** lykinsbd has joined #openstack-neutron | 18:46 | |
| *** ritesh has joined #openstack-neutron | 18:47 | |
| *** padkrish has quit IRC | 18:47 | |
| *** padkrish has joined #openstack-neutron | 18:47 | |
| *** carl_baldwin has quit IRC | 18:48 | |
| *** evgenyf has quit IRC | 18:48 | |
| *** ritesh has quit IRC | 18:49 | |
| *** bjornar_ has joined #openstack-neutron | 18:51 | |
| *** carl_baldwin has joined #openstack-neutron | 18:52 | |
| *** padkrish has quit IRC | 18:52 | |
| *** anshul has quit IRC | 18:52 | |
| *** anshul has joined #openstack-neutron | 18:52 | |
| marun | pc_m: the config script from neutron is probably helpful in explaining: https://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh | 18:53 |
| *** julien_ZTE has joined #openstack-neutron | 18:54 | |
| marun | pc_m: functional testing requires a) system deps installed and configured b) db setup c) sudo setup | 18:55 |
| marun | pc_m: the rootwrap filters can be installed in the tox env with the sudo setup defined in the setup script, so they are always fresh | 18:55 |
| *** jschwarz has quit IRC | 18:55 | |
| stockpirate | hi, i have a stupid question, again | 18:56 |
| stockpirate | im stucked on neutron. the db connection work | 18:57 |
| stockpirate | but now (OperationalError) (2003, "Can't connect to MySQL server on '10.55.0.28' (113)") None None | 18:57 |
| *** achanda has joined #openstack-neutron | 18:57 | |
| stockpirate | neutron.conf seems to be correct. is there some other config files i have missed? | 18:57 |
| *** julien_ZTE has quit IRC | 18:58 | |
| *** yfauser has joined #openstack-neutron | 18:58 | |
| *** lykinsbd has quit IRC | 18:58 | |
| *** achanda has quit IRC | 19:00 | |
| *** achanda has joined #openstack-neutron | 19:00 | |
| *** rotbeard has quit IRC | 19:01 | |
| *** rangansw_ has quit IRC | 19:01 | |
| *** padkrish has joined #openstack-neutron | 19:01 | |
| *** jistr has joined #openstack-neutron | 19:02 | |
| *** tiswanso has quit IRC | 19:02 | |
| *** rangansw has joined #openstack-neutron | 19:02 | |
| *** aepifanov has joined #openstack-neutron | 19:03 | |
| *** dane_leblanc has quit IRC | 19:05 | |
| *** tiswanso has joined #openstack-neutron | 19:06 | |
| marun | dougwig: If we can't pin, I'm going to suggest *aas start vendoring test infrastructure at the least. | 19:06 |
| pc_m | marun: Thanks for the script, when does that get invoked in the process? | 19:07 |
| dougwig | marun: what do you mean by 'vending test infrastructure' ? | 19:07 |
| dougwig | vendoring, even | 19:07 |
| marun | dougwig: copying | 19:07 |
| marun | dougwig: fine we can't have the different versions of runtime code in the same process | 19:07 |
| dougwig | marun: makes sense. for the lbaas api test, we run entirely standalone. our units still use neutron's base classes. | 19:07 |
| marun | dougwig: not just base classes | 19:08 |
| marun | https://review.openstack.org/#/c/167041/ | 19:08 |
| *** ijw has quit IRC | 19:08 | |
| marun | I'm trying to reverse work that broke some of the base stuff out to allow api tests to import tempest | 19:08 |
| *** yfauser has quit IRC | 19:08 | |
| marun | but as per armax's comment I can't merge this without breaking lbaas | 19:08 |
| *** bobmel has quit IRC | 19:09 | |
| dougwig | marun: yep, you're right. | 19:09 |
| pc_m | marun: I see, gate hook runs it. In neutron-vpnaas, we don't have that script. Should some updates be done? | 19:09 |
| marun | dougwig: is there a reason to not simply copy the test code from neutron on a periodic basis? | 19:09 |
| armax | marun: not lbaas, fwaas | 19:09 |
| armax | lbaas is fine afaik | 19:09 |
| marun | oh, sorry | 19:09 |
| * marun can't read | 19:09 | |
| armax | ffsaas | 19:09 |
| dougwig | marun: no, those repos need to be trending towards standalone. | 19:09 |
| marun | dougwig: so would you suggest landing a fix in fwaas or taking the opportunity to vendor? | 19:10 |
| marun | vendor -> start vendoring | 19:10 |
| marun | (I'm not actually sure why it's called vendoring. Copying was taken?) | 19:10 |
| dougwig | i'm fine to start copying as the fix. | 19:10 |
| pc_m | ncode | 19:11 |
| dougwig | i don't have the fwaas or vpnaas background to substantially edit those tests in functional ways. | 19:11 |
| marun | dougwig: it's a non-functional change, just moves stuff around | 19:11 |
| dougwig | right, i'm saying that's why i think copying is the safer bet. | 19:11 |
| dougwig | sorry, wasn't clear. | 19:11 |
| marun | dougwig: I think the greater cost of vendoring is ensuring things stay updated. | 19:11 |
| marun | ah, ok | 19:12 |
| ZZelle_ | marun, dougwig, if you want i can change fwaas/vpnaas | 19:12 |
| armax | vpnaas is fine too | 19:12 |
| marun | pc_m: I think *aas might want to use the neutron script, since they depend on neutron, and add only what is needed for them. | 19:13 |
| armax | only fwaas is the problem | 19:13 |
| marun | ZZelle_: that would be great if you're up for it | 19:13 |
| armax | if we’re talking aobut change https://review.openstack.org/#/c/167041/ | 19:13 |
| ZZelle_ | marun, how do we do? we duplicate current neutron code in fwaas, update neutron code, update fwaas code and remove obsolete duplicated from fwaas? | 19:15 |
| *** dane_leblanc has joined #openstack-neutron | 19:15 | |
| marun | ZZelle_: yes | 19:15 |
| ZZelle_ | marun, ok | 19:15 |
| marun | ZZelle_: a copy script is suggested | 19:16 |
| marun | ZZelle_: maybe similar to what I created for the tempest api tests | 19:16 |
| marun | https://github.com/openstack/neutron/blob/master/tools/copy_api_tests_from_tempest.sh | 19:16 |
| marun | copy and translate imports, basically | 19:16 |
| marun | though maybe rsync would be better to a path that is copy-only | 19:16 |
| openstackgerrit | Merged openstack/neutron: Deprecate use_namespaces option https://review.openstack.org/166888 | 19:17 |
| openstackgerrit | Merged openstack/neutron-vpnaas: Add some unit tests for strongswan driver https://review.openstack.org/165159 | 19:18 |
| dougwig | marun: is any of the test stuff something we should target at neutron-lib, or is it all in the process of being junked/transitioned away from? | 19:18 |
| marun | dougwig: I'm not sure it makes much sense to maintain test fixture as a library.l | 19:19 |
| marun | dougwig: then we'd have to have tests for our tests | 19:19 |
| dougwig | then we could add neutron-test-lib. and then neutron-test-test-lib. and then ... | 19:19 |
| marun | dougwig: vendoring seems like a better solution until we find ways to minimize the pain of stability | 19:19 |
| marun | heh | 19:19 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 19:21 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: Add eventlet monkey_patch helper https://review.openstack.org/167214 | 19:21 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: Moves ovs_lib to agent/common https://review.openstack.org/167374 | 19:21 |
| *** Marga_ has joined #openstack-neutron | 19:21 | |
| blogan | marun, dougwig: do you then think it makes sense for the *aas repos to start building their own base test classes to eventually get away from importing neutron? or is that fine for just tests? | 19:21 |
| blogan | marun, dougwig: i may have just asked something ayll asnwered above sorry :( | 19:22 |
| pc_m | marun: Should the neutron-vpnaas hooks be modified to be similar to the (current) neutron ones? Should it have a copy of configure_for_func_testing.sh or is it OK to refer to the one in Neutron? | 19:22 |
| *** aepifanov has quit IRC | 19:23 | |
| *** banix has quit IRC | 19:24 | |
| marun | blogan: the idea is that we shouldn't be adding a dependency on the test side of things | 19:26 |
| dougwig | blogan, marun - yes, i think we should have our own base classes. | 19:27 |
| marun | blogan: either vendor/copy or create new base classes | 19:27 |
| marun | blogan: it will probably be more complicated on the fixture side of things, and maybe that stuff does belong in neutron-lib | 19:27 |
| marun | blogan: less for unit tests, more for functional stuff where common stuff will be in play | 19:27 |
| *** emagana has joined #openstack-neutron | 19:30 | |
| *** dboik_ has quit IRC | 19:30 | |
| *** dboik has joined #openstack-neutron | 19:31 | |
| openstackgerrit | Sudipta Biswas proposed openstack/neutron: Add clock sync error detection on agent registration https://review.openstack.org/165539 | 19:31 |
| *** jistr has quit IRC | 19:31 | |
| marun | pc_m: I would say *aas can safely treat the copy script as a black box and call it directly | 19:31 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Move methods from HA agent to HA router https://review.openstack.org/160608 | 19:32 |
| *** doude has quit IRC | 19:32 | |
| amuller | carl_baldwin: Rebased the patch + Added some more cleanups | 19:32 |
| blogan | marun, dougwig: ah okay, sounds good | 19:32 |
| blogan | dougwig: you were planning on bringing the v1 tempest tests in? | 19:33 |
| carl_baldwin | amuller: ack | 19:33 |
| blogan | dougwig: or would you like me to do it? | 19:33 |
| *** banix has joined #openstack-neutron | 19:33 | |
| dougwig | blogan: yes, or seeing if you'd look at it during one of your late night coding binges. | 19:33 |
| blogan | dougwig: you juse use me and abuse me :( | 19:34 |
| *** emagana has quit IRC | 19:34 | |
| *** jorgem has quit IRC | 19:35 | |
| *** dboik_ has joined #openstack-neutron | 19:35 | |
| *** nlahouti has quit IRC | 19:36 | |
| *** emagana has joined #openstack-neutron | 19:37 | |
| *** dboik has quit IRC | 19:38 | |
| *** morganfainberg is now known as needslesscoffee | 19:39 | |
| *** rangansw has quit IRC | 19:40 | |
| *** rpothier has quit IRC | 19:40 | |
| *** jorgem has joined #openstack-neutron | 19:41 | |
| *** aranjan has quit IRC | 19:41 | |
| *** achanda has quit IRC | 19:42 | |
| amuller | armax: about https://review.openstack.org/#/c/126182/ | 19:43 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 19:43 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: Moves ovs_lib to agent/common https://review.openstack.org/167374 | 19:43 |
| *** nfedotov has joined #openstack-neutron | 19:44 | |
| *** _cjones_ has quit IRC | 19:45 | |
| *** _cjones_ has joined #openstack-neutron | 19:46 | |
| claudiub | armax: hello. The comments have been addressed on https://review.openstack.org/#/c/167214/ . Can you take a look when you have a little bit of time? :) | 19:47 |
| *** Networkn3rd has quit IRC | 19:48 | |
| marun | blogan, dougwig: Is there any reason for neutron to have the *aas api tests? | 19:48 |
| marun | I copied them for the sake of completeness, but tempest is still running them for now | 19:48 |
| *** Networkn3rd has joined #openstack-neutron | 19:48 | |
| marun | So all it's doing is duplicate work | 19:48 |
| marun | Or am I missing something? | 19:49 |
| dougwig | marun: no, that's what we're talking about moving. | 19:49 |
| blogan | marun: once its in *aas repos i dont see a reason | 19:49 |
| marun | dougwig: are you planning on moving from neutron or tempest? | 19:49 |
| dougwig | marun: there is a reason for neutron to run them, though, so hold off until they're moved, and we'll submit a delete patch. | 19:49 |
| marun | dougwig: the tests are the same in either case | 19:49 |
| marun | dougwig: what's the reason? | 19:50 |
| dougwig | marun: was going to grab from neutron | 19:50 |
| marun | dougwig: ah, ok. | 19:50 |
| blogan | yeah what is the reason | 19:50 |
| *** needslesscoffee is now known as morganfainberg | 19:50 | |
| blogan | just to grab from neutron? | 19:50 |
| dougwig | marun: it rhymes with snow-gate, but if i say it, give me 3 seconds to duck first. | 19:50 |
| blogan | flow-gate? | 19:50 |
| marun | dougwig: isn't tempest still providing that though? | 19:50 |
| *** _cjones_ has quit IRC | 19:50 | |
| *** doude has joined #openstack-neutron | 19:50 | |
| marun | mo-gate, mo-problems? | 19:50 |
| *** evgenyf has joined #openstack-neutron | 19:51 | |
| *** padkrish has quit IRC | 19:51 | |
| marun | dougwig: btw, may make sense to pull from here | 19:51 |
| marun | https://review.openstack.org/#/c/167320/ | 19:51 |
| dougwig | yes. as long as its in one of the two until it's up and running in the aas'es, that's fine. i was going to submit Depends-On patches in pairs to both repos. | 19:51 |
| *** padkrish has joined #openstack-neutron | 19:51 | |
| *** amuller is now known as amuller_afk | 19:51 | |
| marun | dougwig: we can't remove from tempest until we have stable jobs running, in any case | 19:51 |
| marun | dougwig: so duplication will merrily continue | 19:51 |
| marun | stable -> api jobs targeting stable branches | 19:52 |
| dougwig | since lbaas has an api job, if we can fold in v1, we can be running it on THREE nodes at the same time. triple the protection, yo. | 19:52 |
| marun | dougwig: but I'm not sure how that applies to *aas | 19:52 |
| marun | dougwig: like if I'm safer carrying 1 gun, I'll be twice as safe with one in each hand? | 19:52 |
| *** _cjones_ has joined #openstack-neutron | 19:52 | |
| blogan | we'll also need to convert the v2 tempest tests to whatever v1 is using, bc right now we're depending on the pinned tempest version in tox | 19:53 |
| dougwig | marun: and a third, tongue operated, duct taped to your face. | 19:53 |
| marun | dougwig: I hope it's a plastic gun. metal guns are heavy | 19:53 |
| dougwig | blogan: we can invoke the two suites separately. | 19:53 |
| blogan | 3d printed | 19:53 |
| dougwig | marun: scandium. crazy light. | 19:53 |
| * marun learned something new today | 19:53 | |
| *** nfedotov has quit IRC | 19:54 | |
| blogan | dougwig: i know but thats just ugly and unneeded technical debt | 19:54 |
| marun | blogan: nothing saying you can't run them on the same host | 19:54 |
| dougwig | blogan: i'm sure you'll submit a 15,000 line review that's beautiful, i have no fear. :) | 19:54 |
| marun | so, stable jobs.... | 19:54 |
| *** doude has quit IRC | 19:54 | |
| blogan | dougwig: im sure you're truck will get towed | 19:55 |
| marun | the plan is for neutron to be able to maintain branchless api tests that can run against stable releases | 19:55 |
| marun | This seems tractable | 19:55 |
| *** jpena has joined #openstack-neutron | 19:55 | |
| marun | I'm less sure where *aas sit, though... | 19:55 |
| dougwig | marun: why do you prefer that to running the tests in the branch? | 19:55 |
| marun | dougwig: because they don't exist in the branch | 19:56 |
| *** padkrish has quit IRC | 19:56 | |
| marun | previous to kilo, the tests were in tempest | 19:56 |
| *** amuller_afk has quit IRC | 19:56 | |
| dougwig | marun: aas could work either way. they're more stable than the neutron api's (the interface definitions, i mean, settle down!) | 19:56 |
| marun | to ensure backwards compatibility, we have to have v2 tests running against all supported releases | 19:56 |
| marun | just like tempest does today | 19:56 |
| blogan | im missing something, are the pulled in neutron tempest tests in a branch? | 19:56 |
| marun | blogan: no | 19:56 |
| marun | blogan: 'branchless' is a tempest concept | 19:57 |
| blogan | marun: ah im unfamiliar with that then | 19:57 |
| marun | blogan: branchless test -> a test that can execute against any branch/release of the target | 19:57 |
| marun | blogan: they stopped branching tempest last year | 19:57 |
| blogan | ahh i see | 19:57 |
| ZZelle_ | marun, how do we ensure branchless tests will be really branchless? | 19:57 |
| marun | so master has to be able to run against master and the 2 stable branches and still pass | 19:57 |
| marun | ZZelle_: We run them against stable branches | 19:57 |
| marun | ZZelle_: probably we'd gate on stable test jobs on any changes to neutron/tests/api | 19:58 |
| dougwig | pylint loves and haters, be sure to vent your spleens here: https://review.openstack.org/#/c/167284/ lack of enthusiasm from either direction will likely mean it's not worth spending the resources on it. | 19:58 |
| ZZelle_ | dougwig, sad, pylint is really a good helper when pylintrc is correctly customized | 19:59 |
| dougwig | ZZelle_: go say that in the review. :) | 20:00 |
| blogan | gotta go to a meeating bbl | 20:00 |
| openstackgerrit | Maru Newby proposed openstack/neutron: Enhance TESTING.rst https://review.openstack.org/167384 | 20:04 |
| *** matrohon has joined #openstack-neutron | 20:04 | |
| *** emagana has quit IRC | 20:04 | |
| *** agentle has joined #openstack-neutron | 20:06 | |
| *** baoli has joined #openstack-neutron | 20:06 | |
| *** doude has joined #openstack-neutron | 20:07 | |
| *** baoli has quit IRC | 20:07 | |
| *** rangansw has joined #openstack-neutron | 20:07 | |
| *** baoli has joined #openstack-neutron | 20:08 | |
| *** aranjan has joined #openstack-neutron | 20:08 | |
| *** Networkn3rd has quit IRC | 20:08 | |
| *** carl_baldwin has quit IRC | 20:10 | |
| ZZelle_ | marun, you should be like https://github.com/openstack/neutron/blob/master/tools/copy_api_tests_from_tempest.sh or like oslo-incubator code replication procedure? | 20:11 |
| *** jorgem has quit IRC | 20:11 | |
| *** sripriya has joined #openstack-neutron | 20:12 | |
| *** akanksha has joined #openstack-neutron | 20:12 | |
| *** Networkn3rd has joined #openstack-neutron | 20:13 | |
| marun | ZZelle_: Not sure, tbh | 20:14 |
| marun | ZZelle_: the copy script is one-off that hopefully won't be around for long | 20:14 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 20:14 |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: Moves ovs_lib to agent/common https://review.openstack.org/167374 | 20:14 |
| marun | ZZelle_: My hope would be that vendoring would be similarly limited in scope | 20:15 |
| *** apuimedo has joined #openstack-neutron | 20:15 | |
| *** rangansw_ has joined #openstack-neutron | 20:15 | |
| *** tflynn_ has joined #openstack-neutron | 20:15 | |
| ZZelle_ | marun, if we want to allow de-synchronization between neutron test code and neutron test code in neutron-fwaas, the oslo-incubator workflow seems to better feet | 20:16 |
| *** sripriya has quit IRC | 20:16 | |
| *** rangansw has quit IRC | 20:16 | |
| marun | ZZelle_: de-sync? | 20:16 |
| *** tflynn_ has quit IRC | 20:16 | |
| *** tflynn_ has joined #openstack-neutron | 20:17 | |
| *** anshul has quit IRC | 20:17 | |
| ZZelle_ | marun, ie, neutron tests code is duplicated in neutron-fwaas and a script allows to resync it with neutron reference | 20:17 |
| ZZelle_ | marun, so neutron and neutron-fwaas could reference different versions of the same test code | 20:17 |
| *** tflynn_ has quit IRC | 20:17 | |
| *** tflynn has quit IRC | 20:18 | |
| marun | ZZelle_: I think they're the same thing, but oslo-style has a nicer ux | 20:18 |
| marun | ZZelle_: rather than just an all-or-nothing bash script | 20:18 |
| *** ijw has joined #openstack-neutron | 20:18 | |
| ZZelle_ | marun, ah!, we must duplicate as less as possible because neutron test code references neutron code (typically test_l3_agent) | 20:20 |
| marun | ZZelle_: yes. I'd suggest only the base classes should be copied | 20:20 |
| *** doude has quit IRC | 20:20 | |
| marun | ZZelle_: if something outside of neutron needs to reuse something, it should be isolated from the test code for ruse | 20:21 |
| marun | reuse | 20:21 |
| *** padkrish has joined #openstack-neutron | 20:21 | |
| *** tflynn has joined #openstack-neutron | 20:22 | |
| ZZelle_ | marun, i will propose something as a base for discussion as i am pretty we will face the same trouble multiple times | 20:22 |
| marun | ZZelle_: ok, sounds good | 20:23 |
| marun | ZZelle_: the other option is just manual copying... | 20:23 |
| *** _cjones_ has quit IRC | 20:23 | |
| *** _cjones_ has joined #openstack-neutron | 20:23 | |
| marun | ZZelle_: we do that between other projects | 20:23 |
| marun | ZZelle_: nova comes up with something interesting, we might copy it | 20:23 |
| ijw | On the MTU attribute thing - given that it has backward compatibility with nonsupporting plugins and given that in general any plugin that doesn't implement proper support has broken networking why are we now doing it as an extension? | 20:23 |
| ijw | I'm not clear why the choice was made in this morning's meeting | 20:23 |
| marun | ijw: we need to be able to definitely know whether a given neutron endpoint supports mtu | 20:24 |
| marun | ijw: we can't do that without manual querying of the api without an extension | 20:24 |
| marun | ijw: an extensions allows us to query 'do you support mtu?' and get an answer | 20:24 |
| marun | ijw: we're stuck with that until we start microversioning (e.g. 2.0.1 supports mtu) | 20:25 |
| marun | ijw: does that make sense? | 20:25 |
| ZZelle_ | marun, microversioning won't follow semantic versioning? | 20:26 |
| marun | ZZelle_: I'm not sure what you mean, and I'm probably getting the scheme wrong | 20:26 |
| marun | ZZelle_: my intent was only to highlight the need to bump the api version if we added something like mtu | 20:26 |
| *** jamie_h has quit IRC | 20:28 | |
| ZZelle_ | marun, with semver, an API update backward incompatible increases major number (x.y.z=>x+1.0.0), backward compatible increases medium number (x.y.z ==> x.y+1.0), otherwise increases minor number (typically API doc update) | 20:29 |
| *** sripriya has joined #openstack-neutron | 20:29 | |
| marun | ZZelle_: I actually do know that, but I'm not sure where api versioning fits in | 20:29 |
| *** ijw_ has joined #openstack-neutron | 20:30 | |
| marun | ZZelle_: Nova does microversioning, probably worth looking at what they do | 20:30 |
| *** padkrish has quit IRC | 20:30 | |
| *** baoli has quit IRC | 20:31 | |
| *** nlahouti has joined #openstack-neutron | 20:31 | |
| *** mwagner_lap has quit IRC | 20:32 | |
| *** baoli has joined #openstack-neutron | 20:32 | |
| *** padkrish has joined #openstack-neutron | 20:32 | |
| *** ijw has quit IRC | 20:33 | |
| armax | ajo: ping | 20:34 |
| *** jpena is now known as jpena|away | 20:34 | |
| *** rushil has joined #openstack-neutron | 20:35 | |
| *** achanda has joined #openstack-neutron | 20:35 | |
| *** carl_baldwin has joined #openstack-neutron | 20:39 | |
| *** localloo1 has joined #openstack-neutron | 20:42 | |
| *** julien_ZTE has joined #openstack-neutron | 20:42 | |
| *** reed has quit IRC | 20:42 | |
| *** baoli has quit IRC | 20:43 | |
| *** localloop127 has quit IRC | 20:44 | |
| *** baoli has joined #openstack-neutron | 20:44 | |
| *** carl_baldwin has quit IRC | 20:45 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 20:47 |
| *** julien_ZTE has quit IRC | 20:48 | |
| *** tiswanso has quit IRC | 20:49 | |
| openstackgerrit | Divya ChanneGowda proposed openstack/neutron: Update contribute.rst with Nuage plugin decomposition https://review.openstack.org/165536 | 20:49 |
| *** baoli has quit IRC | 20:50 | |
| *** sn6i23a has joined #openstack-neutron | 20:50 | |
| *** __TheDodd__ has joined #openstack-neutron | 20:50 | |
| *** angela-s has quit IRC | 20:51 | |
| *** baoli has joined #openstack-neutron | 20:52 | |
| *** baoli has quit IRC | 20:53 | |
| *** thedodd has quit IRC | 20:53 | |
| *** baoli has joined #openstack-neutron | 20:54 | |
| *** flaviof has quit IRC | 20:54 | |
| *** nlahouti has quit IRC | 20:55 | |
| *** flaviof has joined #openstack-neutron | 20:55 | |
| *** flaviof has quit IRC | 20:57 | |
| *** apuimedo has quit IRC | 20:59 | |
| *** rook_ has joined #openstack-neutron | 20:59 | |
| *** tflynn_ has joined #openstack-neutron | 21:02 | |
| *** tflynn has quit IRC | 21:02 | |
| *** sripriya has quit IRC | 21:02 | |
| *** sripriya has joined #openstack-neutron | 21:02 | |
| *** sridhar_ram1 has joined #openstack-neutron | 21:03 | |
| *** carl_baldwin has joined #openstack-neutron | 21:03 | |
| *** tflynn_ has quit IRC | 21:03 | |
| *** sridhar_ram has quit IRC | 21:04 | |
| *** flaviof has joined #openstack-neutron | 21:04 | |
| *** melwitt has quit IRC | 21:05 | |
| *** melwitt_ has joined #openstack-neutron | 21:05 | |
| *** melwitt_ has quit IRC | 21:05 | |
| *** emagana has joined #openstack-neutron | 21:05 | |
| *** carl_baldwin has quit IRC | 21:05 | |
| *** melwitt has joined #openstack-neutron | 21:05 | |
| *** openstackgerrit has quit IRC | 21:07 | |
| *** evgenyf has quit IRC | 21:07 | |
| *** openstackgerrit has joined #openstack-neutron | 21:07 | |
| *** apuimedo has joined #openstack-neutron | 21:07 | |
| *** doude has joined #openstack-neutron | 21:09 | |
| *** emagana has quit IRC | 21:10 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/neutron: OVS agent support on Hyper-V https://review.openstack.org/160596 | 21:10 |
| *** flaviof has quit IRC | 21:11 | |
| *** carl_baldwin has joined #openstack-neutron | 21:11 | |
| *** carl_baldwin has quit IRC | 21:12 | |
| *** pc_m has quit IRC | 21:12 | |
| *** flaviof has joined #openstack-neutron | 21:14 | |
| *** carl_baldwin has joined #openstack-neutron | 21:14 | |
| *** carl_baldwin has quit IRC | 21:15 | |
| openstackgerrit | Merged openstack/neutron: Ml2 Mechanism Driver for OVSvApp Solution https://review.openstack.org/160247 | 21:16 |
| *** rook_ has quit IRC | 21:16 | |
| *** aranjan_ has joined #openstack-neutron | 21:19 | |
| *** reed has joined #openstack-neutron | 21:20 | |
| *** aranjan has quit IRC | 21:20 | |
| ijw_ | marun: I take it you don't approve of duck typing | 21:23 |
| *** aranjan_ has quit IRC | 21:23 | |
| *** Networkn3rd has quit IRC | 21:23 | |
| ijw_ | The spec's clear that if an MTU flag is not set on the returned network nothing's provable about the MTU (though I admit I'm going off that) | 21:23 |
| marun | ijw_: I love duck typing | 21:24 |
| * ijw_ hands marun a duck | 21:24 | |
| marun | ijw_: but I'm not convinced that's applicable to a REST api | 21:24 |
| *** carl_baldwin has joined #openstack-neutron | 21:25 | |
| marun | ijw_: at least with the requirement for an extension check we codify how you know that mtu is supported/unsupported | 21:25 |
| marun | ijw_: It's gross, don't get me wrong. But it's better than the alternative, and will hold us until the promised land of microversioning. ;) | 21:25 |
| *** julim has quit IRC | 21:26 | |
| *** stockpirate has left #openstack-neutron | 21:27 | |
| *** lennyb has quit IRC | 21:28 | |
| ijw_ | marun: Well, I'm thinking somewhat pragmatically, I admit, but now it feels like I first check for an extension that damned well ought to exist in every config, since every single plugin currently has MTU issues, and only *then* can I attempt to use the API | 21:28 |
| marun | ijw_: the concern is backwards compatibility, though | 21:28 |
| ijw_ | Versus using the API and getting an arsey result because I passed an unknown attribute, which is actualy easier | 21:28 |
| marun | ijw_: fine, your new cloud works fine | 21:28 |
| marun | ijw_: but how to know if a random cloud supports it? | 21:29 |
| ijw_ | marun: what's the defined behaviour if you pass an unknown attribute to a call/ | 21:29 |
| marun | ijw_: that's what's driving this decision, the need to ensure compatibility across clouds that claim to support the same api (v2) | 21:29 |
| *** emagana has joined #openstack-neutron | 21:29 | |
| marun | ijw_: probably ignored | 21:29 |
| ijw_ | That would be a concern | 21:29 |
| ijw_ | Considering we have done this in the past | 21:30 |
| ijw_ | We might want to choose a more sensible behaviour, in any case | 21:30 |
| ijw_ | That said, the interface has a slightly icky design where you're supposed to check that the object created actually does have the value on it | 21:31 |
| *** jpena|away has quit IRC | 21:31 | |
| *** harlowja is now known as harlowja_away | 21:32 | |
| *** emagana has quit IRC | 21:33 | |
| *** TrevorV|Home has joined #openstack-neutron | 21:35 | |
| TrevorV|Home | I'm back online | 21:35 |
| TrevorV|Home | Sorry for taking so long | 21:35 |
| TrevorV|Home | Had to get/check/shred mail as appropriate | 21:35 |
| *** flaviof has quit IRC | 21:36 | |
| *** claudiub has quit IRC | 21:36 | |
| openstackgerrit | Abhishek Raut proposed openstack/neutron: Cisco Nexus1000V ML2 Mechanism Driver https://review.openstack.org/157243 | 21:42 |
| *** sridhar_ram1 has quit IRC | 21:42 | |
| *** julien_ZTE has joined #openstack-neutron | 21:43 | |
| *** sripriya has quit IRC | 21:44 | |
| *** sripriya has joined #openstack-neutron | 21:46 | |
| *** sridhar_ram has joined #openstack-neutron | 21:46 | |
| *** jckasper has quit IRC | 21:46 | |
| *** agentle has quit IRC | 21:48 | |
| *** dtynan has quit IRC | 21:48 | |
| *** ByteSore has quit IRC | 21:48 | |
| *** peterstac has quit IRC | 21:48 | |
| *** wolsen has quit IRC | 21:48 | |
| *** tristanC has quit IRC | 21:48 | |
| *** harmw has quit IRC | 21:48 | |
| *** flaviof has joined #openstack-neutron | 21:48 | |
| *** julien_ZTE has quit IRC | 21:48 | |
| *** angela-s has joined #openstack-neutron | 21:48 | |
| *** agentle has joined #openstack-neutron | 21:49 | |
| *** dtynan has joined #openstack-neutron | 21:49 | |
| *** peterstac has joined #openstack-neutron | 21:49 | |
| *** ByteSore has joined #openstack-neutron | 21:49 | |
| *** wolsen has joined #openstack-neutron | 21:49 | |
| *** tristanC has joined #openstack-neutron | 21:49 | |
| *** harmw has joined #openstack-neutron | 21:49 | |
| *** agentle has quit IRC | 21:50 | |
| openstackgerrit | Sandhya Dasu proposed openstack/neutron: Cisco UCS Manager ML2 Mechanism Driver https://review.openstack.org/155436 | 21:52 |
| *** emagana has joined #openstack-neutron | 21:53 | |
| *** flaviof has quit IRC | 21:53 | |
| *** ijw has joined #openstack-neutron | 21:54 | |
| *** baoli has quit IRC | 21:56 | |
| *** flaviof has joined #openstack-neutron | 21:56 | |
| *** tflynn has joined #openstack-neutron | 21:56 | |
| *** baoli has joined #openstack-neutron | 21:57 | |
| *** tflynn has quit IRC | 21:57 | |
| *** localloo1 has quit IRC | 21:57 | |
| *** flaviof has quit IRC | 21:57 | |
| *** ronis has quit IRC | 21:57 | |
| *** ijw_ has quit IRC | 21:57 | |
| *** tflynn has joined #openstack-neutron | 21:58 | |
| *** baoli has quit IRC | 21:58 | |
| *** kevinbenton has joined #openstack-neutron | 21:59 | |
| *** Marga_ has quit IRC | 21:59 | |
| *** nlahouti has joined #openstack-neutron | 21:59 | |
| *** baoli has joined #openstack-neutron | 21:59 | |
| *** nlahouti has quit IRC | 21:59 | |
| *** padkrish has quit IRC | 22:00 | |
| *** ronis has joined #openstack-neutron | 22:00 | |
| *** padkrish has joined #openstack-neutron | 22:01 | |
| *** TrevorV|Home has quit IRC | 22:01 | |
| *** nlahouti has joined #openstack-neutron | 22:02 | |
| *** padkrish_ has joined #openstack-neutron | 22:02 | |
| *** achanda_ has joined #openstack-neutron | 22:04 | |
| *** banix has quit IRC | 22:04 | |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Subnet allocation from a subnet pool https://review.openstack.org/157597 | 22:05 |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Only call get_engine().pool.dispose if _FACADE https://review.openstack.org/165364 | 22:05 |
| *** harlowja_away is now known as harlowja | 22:05 | |
| *** padkrish has quit IRC | 22:05 | |
| *** achanda has quit IRC | 22:08 | |
| *** lori is now known as lori|away | 22:08 | |
| *** baoli has quit IRC | 22:08 | |
| *** sbfox1 has joined #openstack-neutron | 22:09 | |
| *** baoli has joined #openstack-neutron | 22:10 | |
| *** sbfox has quit IRC | 22:10 | |
| *** changbl has quit IRC | 22:14 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Fix intermittent failure in TestNetworksFailover UT https://review.openstack.org/167414 | 22:14 |
| *** ronis has quit IRC | 22:16 | |
| *** aranjan has joined #openstack-neutron | 22:17 | |
| *** Marga_ has joined #openstack-neutron | 22:18 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add API tests for Neutron DVR extension https://review.openstack.org/167357 | 22:21 |
| *** kbringard has quit IRC | 22:24 | |
| *** baoli has quit IRC | 22:27 | |
| armax | mtreinish: ping | 22:27 |
| *** baoli has joined #openstack-neutron | 22:27 | |
| *** julien_ZTE has joined #openstack-neutron | 22:28 | |
| armax | I am a bit puzzled by the outcome of some tests | 22:28 |
| armax | http://logs.openstack.org/35/98235/19/check/check-tempest-dsvm-full/8e11cc9/logs/testr_results.html.gz | 22:28 |
| armax | I see a number of skips for tests that should in fact be executed | 22:28 |
| *** emagana has quit IRC | 22:29 | |
| *** aranjan has quit IRC | 22:30 | |
| *** Marga_ has quit IRC | 22:30 | |
| ijw | armax: ping | 22:32 |
| armax | ijw: hello | 22:32 |
| ijw | You're nagging about vlan trunks on the list again, damn you | 22:32 |
| ijw | Just wanted a word before I replied where everyone can see it | 22:32 |
| ijw | What's the specific thing you have an issue with? | 22:33 |
| armax | you’re definitely starting on the wrong foot bare or not | 22:33 |
| armax | I am trying to fix the mess | 22:34 |
| armax | I am not nagging anyone :) | 22:34 |
| ijw | armax: I'm a little conerned there's not a much a mess as you're making out | 22:34 |
| ijw | Also, it'll teach you to read my bloody specs ;) | 22:34 |
| armax | if you only wrote in plain English, perhaps! | 22:34 |
| armax | :) | 22:34 |
| armax | anyhoo | 22:34 |
| ijw | My English is nothing short of delightful, I'll have you know | 22:35 |
| armax | all I am saying is that if I create a VLAN transparent network with OVS/VXLAN the mechdriver doesn’t barf | 22:35 |
| armax | the way you said it should | 22:35 |
| ijw | It doesn't? | 22:35 |
| *** crc32 has quit IRC | 22:35 | |
| *** __TheDodd__ has quit IRC | 22:35 | |
| ijw | OK, you've found a bug, and that disturbs me | 22:35 |
| armax | maybe if you lived at the time of Shakespeare? | 22:35 |
| *** carl_baldwin has quit IRC | 22:35 | |
| ijw | Pfft, middle Englander | 22:36 |
| armax | the other point I raised was about VLAN and LB | 22:36 |
| armax | :O | 22:36 |
| *** Marga_ has joined #openstack-neutron | 22:36 | |
| armax | I can’t see how we can keep sanity of a feature we don’t validate on a continuous basis | 22:36 |
| ijw | It's certainly sounding like it's not seen the workout it should but this is nominally all testable in the unit tests | 22:36 |
| armax | that’s worrying to say the least, mind you | 22:36 |
| armax | UT are so last year | 22:37 |
| ijw | Firstly, when's the last time LB was validated upstream? | 22:37 |
| armax | never | 22:37 |
| armax | or too long for me to remember | 22:37 |
| ijw | So it's not a sane feature that people use in production? | 22:37 |
| ijw | That's really the issue here, we have to use the tests properly | 22:37 |
| ijw | We can't system test this feature comprehensively (which is normal - system tests are not supposed to provide 100% coverage) but you're right that what tests we have aside from the system tests are not strong enough if you're managing to break them | 22:38 |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Subnet allocation from a subnet pool https://review.openstack.org/157597 | 22:39 |
| ijw | Let me have a word with someone | 22:39 |
| *** leenheer has joined #openstack-neutron | 22:39 | |
| armax | ijw: ok, my concern is that the something we know has known quality | 22:39 |
| armax | it doesn’t matter whether it’s called vlan transparent or mtu, so don’t feel like I am picking up on you | 22:39 |
| armax | arcaic English or not | 22:40 |
| ijw | armax: I'm with you on that, I need this thing to work | 22:40 |
| ijw | armax: Can you raise a bug? I don't know we can do much about the system tests but if what you report is true then our testing is not what it should be | 22:41 |
| marun | ijw: we don't modify things we can't test. they can rot, but at least it wasn't deliberate. | 22:41 |
| *** sbfox1 has quit IRC | 22:42 | |
| ijw | But on sanity, as I say, the only thing is that we can't fully test this (or a number of other things up to and including the joys of ML2) in the system tests. That's just a limitation on our system tests. That being the case this needs better tests where we can test it. | 22:42 |
| ijw | marun: disappointing. (I'm definitely a LB fan) | 22:42 |
| armax | ijw: yeah I raised two RC1 cleanup bugs | 22:43 |
| armax | ijw: sort of catch-all | 22:43 |
| marun | ijw: we'd love to see cisco provide 3rd party ci for lb (hint, hint... ;) | 22:43 |
| *** sbfox has joined #openstack-neutron | 22:44 | |
| armax | mtreinish: never mind…I think I was barking up at the wrong tree | 22:45 |
| *** banix has joined #openstack-neutron | 22:49 | |
| *** jobewan has quit IRC | 22:49 | |
| *** banix has quit IRC | 22:52 | |
| *** bjornar_ has quit IRC | 22:53 | |
| *** absubram has quit IRC | 22:53 | |
| *** sbfox has quit IRC | 22:53 | |
| *** baoli_ has joined #openstack-neutron | 22:53 | |
| *** armax has quit IRC | 22:54 | |
| *** baoli has quit IRC | 22:55 | |
| *** baoli_ has quit IRC | 22:56 | |
| *** matrohon has quit IRC | 22:56 | |
| *** rangansw__ has joined #openstack-neutron | 22:56 | |
| *** banix has joined #openstack-neutron | 22:56 | |
| *** thomasem is now known as thomasem-away | 22:58 | |
| *** salv-orl_ has joined #openstack-neutron | 22:58 | |
| *** dannywilson has quit IRC | 22:59 | |
| *** rangansw_ has quit IRC | 23:00 | |
| *** padkrish_ has quit IRC | 23:00 | |
| openstackgerrit | Merged openstack/neutron: Transform BaseLinuxTestCase methods in helpers https://review.openstack.org/159852 | 23:00 |
| *** padkrish has joined #openstack-neutron | 23:01 | |
| *** salv-orlando has quit IRC | 23:02 | |
| *** padkrish_ has joined #openstack-neutron | 23:04 | |
| *** padkrish has quit IRC | 23:05 | |
| *** tflynn_ has joined #openstack-neutron | 23:05 | |
| *** hichihara has joined #openstack-neutron | 23:06 | |
| *** markvoelker has quit IRC | 23:06 | |
| *** claudiub has joined #openstack-neutron | 23:07 | |
| *** prad has quit IRC | 23:07 | |
| *** tflynn has quit IRC | 23:08 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Replace BaseIPVethTestCase by FakeMachine https://review.openstack.org/160290 | 23:10 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Clean neutron.tests.functional.agent.linux.base https://review.openstack.org/161913 | 23:10 |
| *** banix has quit IRC | 23:12 | |
| *** dims has quit IRC | 23:14 | |
| *** dims has joined #openstack-neutron | 23:16 | |
| *** sripriya has quit IRC | 23:16 | |
| *** dims has quit IRC | 23:17 | |
| *** dims has joined #openstack-neutron | 23:17 | |
| *** amuller_afk has joined #openstack-neutron | 23:18 | |
| *** amuller_afk is now known as amuller | 23:19 | |
| *** zhhuabj has quit IRC | 23:20 | |
| *** chlong has joined #openstack-neutron | 23:20 | |
| *** yamamoto has joined #openstack-neutron | 23:20 | |
| *** leenheer has quit IRC | 23:24 | |
| *** sthillma has joined #openstack-neutron | 23:25 | |
| *** yamamoto has quit IRC | 23:25 | |
| openstackgerrit | Zengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API https://review.openstack.org/159618 | 23:29 |
| *** haleyb has quit IRC | 23:30 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Fix intermittent failure in TestNetworksFailover UT https://review.openstack.org/167414 | 23:34 |
| *** chlong has quit IRC | 23:35 | |
| *** chlong has joined #openstack-neutron | 23:35 | |
| *** ChuckC has quit IRC | 23:35 | |
| openstackgerrit | Dane LeBlanc proposed openstack/neutron: Support Dual-Stack Gateway Ports on Neutron Routers https://review.openstack.org/149068 | 23:37 |
| *** ijw_ has joined #openstack-neutron | 23:37 | |
| ijw_ | armax: I'm kind of fine with the one cleanup bug but I kind of had in mind that that was for specific matters of taste | 23:38 |
| *** ChuckC has joined #openstack-neutron | 23:39 | |
| *** mwagner_lap has joined #openstack-neutron | 23:39 | |
| *** ijw has quit IRC | 23:40 | |
| HenryG | FYI, gate-neutron-requirements is currently broken so jenkins will fail patches. Fix is in progress, ETA about one hour. | 23:41 |
| *** ajmiller has quit IRC | 23:45 | |
| *** markvoelker has joined #openstack-neutron | 23:47 | |
| *** julien_ZTE has quit IRC | 23:52 | |
| *** ZZelle_ has quit IRC | 23:52 | |
| *** markvoelker has quit IRC | 23:52 | |
| *** julien_ZTE has joined #openstack-neutron | 23:52 | |
| *** banix has joined #openstack-neutron | 23:52 | |
| *** yamamoto has joined #openstack-neutron | 23:53 | |
| kevinbenton | HenryG: hey, do you have a few minutes for a review? | 23:55 |
| HenryG | kevinbenton: Am I allowed to eat while I review? | 23:55 |
| kevinbenton | HenryG: sure :) | 23:56 |
| kevinbenton | HenryG: it's pretty straight-forward | 23:56 |
| kevinbenton | HenryG: https://review.openstack.org/#/c/163758/ | 23:56 |
| *** julien_ZTE has quit IRC | 23:57 | |
| *** gildub has joined #openstack-neutron | 23:57 | |
| *** tflynn_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!